[PATCH] D79653: [sanitizer] Enable whitelist/blacklist in new PM

This revision was automatically updated to reflect the committed changes. Closed by commit rGa72b9dfd45cd: [sanitizer] Enable whitelist/blacklist in new PM (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79653/new/

[PATCH] D79636: [LangRef] Clarify the semantics of the `byval` attribute

jdoerfert added a comment. In D79636#2028479 , @efriedma wrote: > > @efriedma I'm a bit confused. Could you propose some wording so I get a > > feeling where you want to go? > > Depending on which direction we go, either: > > - "Attributes on a function

[PATCH] D79636: [LangRef] Clarify the semantics of the `byval` attribute

efriedma added a comment. > @efriedma I'm a bit confused. Could you propose some wording so I get a > feeling where you want to go? Depending on which direction we go, either: - "Attributes on a function or callsite describe the behavior of the callee excluding the implied copy. For example,

[PATCH] D75430: [analyzer][NFC] Introduce CXXDeallocatorCall, deploy it in MallocChecker

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Sorry i'm not very responsive these days >.< Comment at: clang/lib/StaticAnalyzer/Checkers/DeleteWithNonVirtualDtorChecker.cpp:95 ExplodedNode *N =

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

NoQ accepted this revision. NoQ added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Analysis/constant-folding.c:127-128 + if (a > 10) { +clang_analyzer_eval((a & 1) <= 1); // expected-warning{{FALSE}} +clang_analyzer_eval((a &

[PATCH] D79636: [LangRef] Clarify the semantics of the `byval` attribute

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/docs/LangRef.rst:1052-1053 +memory of the callee. That means, a callee can write a ``byval`` parameter +and still be ``readonly`` or ``readnone`` because the write is, similar

[PATCH] D79636: [LangRef] Clarify the semantics of the `byval` attribute

jdoerfert added a comment. In D79636#2028294 , @efriedma wrote: > > Do you object to say that the call site argument and the argument point to > > distinct memory locations or something else? > > Like I said, my issue is with the "Attributes on the call

[PATCH] D79636: [LangRef] Clarify the semantics of the `byval` attribute

arsenm added inline comments. Comment at: llvm/docs/LangRef.rst:1052-1053 +memory of the callee. That means, a callee can write a ``byval`` parameter +and still be ``readonly`` or ``readnone`` because the write is, similar to +a write to an ``alloca``, not visible

[PATCH] D79636: [LangRef] Clarify the semantics of the `byval` attribute

aqjune added a comment. I have a minor question: > a call of a readnone function with a byval argument is not classified as > readnone (which it is today: https://godbolt.org/z/dDfQ5r) %0 at caller has readnone attribute - is it related with the propagation of readnone attribute from %0 of

[PATCH] D79667: [Clang] Pass -z max-page-size to linker for Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b02be0b973a: [Clang] Pass -z max-page-size to linker for Fuchsia (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D79667?vs=263004=263037#toc Repository: rG LLVM Github

[PATCH] D79665: [Clang] Pass --pack-dyn-relocs=relr to lld for Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8fbcb1e78ad: [Clang] Pass --pack-dyn-relocs=relr to lld for Fuchsia (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79665/new/

[PATCH] D79667: [Clang] Pass -z max-page-size to linker for Fuchsia

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79667/new/ https://reviews.llvm.org/D79667

[PATCH] D79678: [clangd] Add CSV export for trace metrics

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, jfb, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Example:

[PATCH] D79665: [Clang] Pass --pack-dyn-relocs=relr to lld for Fuchsia

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79665/new/ https://reviews.llvm.org/D79665

[clang] 5b02be0 - [Clang] Pass -z max-page-size to linker for Fuchsia

Author: Petr Hosek Date: 2020-05-09T13:44:20-07:00 New Revision: 5b02be0b973a0d792bf8ce39170487f48b6cbd08 URL: https://github.com/llvm/llvm-project/commit/5b02be0b973a0d792bf8ce39170487f48b6cbd08 DIFF: https://github.com/llvm/llvm-project/commit/5b02be0b973a0d792bf8ce39170487f48b6cbd08.diff

[clang] c8fbcb1 - [Clang] Pass --pack-dyn-relocs=relr to lld for Fuchsia

Author: Petr Hosek Date: 2020-05-09T13:42:19-07:00 New Revision: c8fbcb1e78adcbaeadca9db9188771d81f49493a URL: https://github.com/llvm/llvm-project/commit/c8fbcb1e78adcbaeadca9db9188771d81f49493a DIFF: https://github.com/llvm/llvm-project/commit/c8fbcb1e78adcbaeadca9db9188771d81f49493a.diff

[PATCH] D79677: [clang][OpenMP][OMPIRBuilder] Adding some Privatization clauses to OpenMP `parallel` Directive

fghanim created this revision. fghanim added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. fghanim added a parent revision: D79676: [Clang][OpenMP][OMPBuilder] Moving OMP allocation and cache creation code to OMPBuilderCBHelpers. -

[clang] a881dc1 - Fix typo

Author: Matt Arsenault Date: 2020-05-09T16:00:17-04:00 New Revision: a881dc1103579926f039e81c0d25626ff8a582a9 URL: https://github.com/llvm/llvm-project/commit/a881dc1103579926f039e81c0d25626ff8a582a9 DIFF:

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

fghanim created this revision. fghanim added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, guansong, hiraditya, yaxunl. Herald added projects: clang, LLVM. Added new methods to generate new runtime calls Added all required defenitions Added some target-specific

[PATCH] D79676: [Clang][OpenMP][OMPBuilder] Moving OMP allocation and cache creation code to OMPBuilderCBHelpers

fghanim created this revision. fghanim added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. Modified the OMPBuilderCBHelpers in the following ways: - Moved location of class definition and deleted all constructors - Moved

[PATCH] D79636: [LangRef] Clarify the semantics of the `byval` attribute

efriedma added a comment. > Do you object to say that the call site argument and the argument point to > distinct memory locations or something else? Like I said, my issue is with the "Attributes on the call site argument and function argument are associated with the original and copied memory

[PATCH] D79674: [clang-tidy] Better support for Override function in RenamerClangTidy based checks

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Methods that override virtual methods will now get renamed if the initial virtual method has a name violation.

[PATCH] D79636: [LangRef] Clarify the semantics of the `byval` attribute

jdoerfert updated this revision to Diff 263026. jdoerfert added a comment. Minor wording tweak Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79636/new/ https://reviews.llvm.org/D79636 Files: llvm/docs/LangRef.rst Index: llvm/docs/LangRef.rst

[PATCH] D33029: [clang-format] add option for dangling parenthesis

bbassi added a comment. @MyDeveloperDay Thanks. This would be my first revision and I have few questions before I start coding. Would you be able to answer those over email? They are mainly about the design of clang-format and some existing options. CHANGES SINCE LAST ACTION

[clang-tools-extra] 0e49ac7 - [NFC] Small rework to RenamerClangTidyCheck addUsage

Author: Nathan James Date: 2020-05-09T18:57:05+01:00 New Revision: 0e49ac73eaf554ad4135f51b03ea4eadaebf0466 URL: https://github.com/llvm/llvm-project/commit/0e49ac73eaf554ad4135f51b03ea4eadaebf0466 DIFF: https://github.com/llvm/llvm-project/commit/0e49ac73eaf554ad4135f51b03ea4eadaebf0466.diff

[PATCH] D79636: [LangRef] Clarify the semantics of the `byval` attribute

jdoerfert updated this revision to Diff 263024. jdoerfert marked 3 inline comments as done. jdoerfert added a comment. Fix spelling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79636/new/ https://reviews.llvm.org/D79636 Files:

[PATCH] D79636: [LangRef] Clarify the semantics of the `byval` attribute

jdoerfert added a comment. > "Attributes on the call site argument and function argument are associated > with the original and copied memory respectively" > > This seems to fly in the face of existing practice, which is that function > attributes are copied to each callsite. I'd strongly

[clang-tools-extra] c746781 - [clangd] Fix data race in BackgroundIndex test

Author: Kadir Cetinkaya Date: 2020-05-09T18:15:27+02:00 New Revision: c746781f5085a965cfc64bd8ddf904217b797ab8 URL: https://github.com/llvm/llvm-project/commit/c746781f5085a965cfc64bd8ddf904217b797ab8 DIFF:

[PATCH] D79673: Allow 32-bit pointer extensions to be used without -fms-extensions

davezarzycki added a comment. In D79673#2028204 , @rnk wrote: > Needs a test. > > I believe these are only implemented for x86 in LLVM. What happens if you try > to use this on non-x86? I wouldn't be surprised if we crash, but we should > probably

[PATCH] D79631: #pragma float_control should be permitted at namespace scope

mibintc updated this revision to Diff 263020. mibintc added a comment. I corrected the assertion error by propagating usesFPIntrin flag from the template function to the template instantiation and added a test case. Ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D79636: [LangRef] Clarify the semantics of the `byval` attribute

rnk added a comment. Some copy editing comments, but I agree with the semantics: From the IR perspective, it is better to think of argument stack memory as belonging to the callee. A byval argument has more in common with a local static alloca than a passed in pointer.

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

This revision was automatically updated to reflect the committed changes. Closed by commit rG82ddae061b4b: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79673: Allow 32-bit pointer extensions to be used without -fms-extensions

rnk added a comment. Needs a test. I believe these are only implemented for x86 in LLVM. What happens if you try to use this on non-x86? I wouldn't be surprised if we crash, but we should probably produce a proper error and test it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 82ddae0 - [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

Author: Nathan James Date: 2020-05-09T16:21:49+01:00 New Revision: 82ddae061b4ba11895756004d559160cbd519fff URL: https://github.com/llvm/llvm-project/commit/82ddae061b4ba11895756004d559160cbd519fff DIFF: https://github.com/llvm/llvm-project/commit/82ddae061b4ba11895756004d559160cbd519fff.diff

[PATCH] D79673: Allow 32-bit pointer extensions to be used without -fms-extensions

davezarzycki created this revision. davezarzycki added reviewers: akhuang, rnk, rsmith. davezarzycki added a project: clang. Herald added a reviewer: aaron.ballman. One should not need to use `-fms-extensions` in order to use 32-bit pointers on 64-bit platforms. Repository: rG LLVM Github

[PATCH] D77249: [MSan] Pass command line options to MSan with new pass manager

vitalybuka added inline comments. Comment at: compiler-rt/test/msan/chained_origin_empty_stack_npm.cpp:4 +// this test. +// RUN: %clangxx_msan -fsanitize-memory-track-origins=2 \ +// RUN: -fexperimental-new-pass-manager -O3 %s -o %t && \ vitalybuka wrote: >

[clang] 0b97833 - LTO.h - reduce includes to forward declarations. NFC.

Author: Simon Pilgrim Date: 2020-05-09T15:10:51+01:00 New Revision: 0b9783350b3a9644dc6e0ba94c0f6a87ca45cb36 URL: https://github.com/llvm/llvm-project/commit/0b9783350b3a9644dc6e0ba94c0f6a87ca45cb36 DIFF: https://github.com/llvm/llvm-project/commit/0b9783350b3a9644dc6e0ba94c0f6a87ca45cb36.diff

[clang-tools-extra] 84cbd47 - [clangd] Fix a data race in RecordsLatencies test

Author: Kadir Cetinkaya Date: 2020-05-09T15:42:21+02:00 New Revision: 84cbd472e59236bd8ec541bc764ababc6a10a878 URL: https://github.com/llvm/llvm-project/commit/84cbd472e59236bd8ec541bc764ababc6a10a878 DIFF:

[PATCH] D79629: [Clang][Driver]Pass LLVM options to lld in case of LTO

bin.narwal added a comment. In D79629#2026974 , @MaskRay wrote: > `-mllvm,foobar` is for compilation (.c/.cc -> .o) > > `-Wl,-mllvm,foobar` for LTO options. For linking, `-mllvm,foobar` is not used > and thus warned. Right, that's reasonable design.

[PATCH] D79669: [clangd] Filter pch related flags coming from the user

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79669/new/ https://reviews.llvm.org/D79669

[PATCH] D79465: [clang-format] Fix line lengths w/ comments in align

MyDeveloperDay added a comment. I've been able to reproduce and the patch looks good, I've just not had a chance to read the review in-depth (I don't know this section of the code as well as other parts). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D33029: [clang-format] add option for dangling parenthesis

MyDeveloperDay added a comment. In D33029#1976981 , @bbassi wrote: > @MyDeveloperDay hey, I am currently working on this, and adding a new option > called BreakBeforeClosingBracket. I have some questions to understand the > existing code, they might

[PATCH] D79669: [clangd] Filter pch related flags coming from the user

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. PCH format is unstable, hence using a preamble built with a different version of clang (or

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rG31fd12aa0956: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 31fd12a - [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

Author: mydeveloperday Date: 2020-05-09T11:27:23+01:00 New Revision: 31fd12aa09563d8402b1aefceaa2311b680e138c URL: https://github.com/llvm/llvm-project/commit/31fd12aa09563d8402b1aefceaa2311b680e138c DIFF:

[PATCH] D79667: [Clang] Pass -z max-page-size to linker for Fuchsia

mcgrathr created this revision. mcgrathr added a reviewer: phosek. Herald added a project: clang. Herald added a subscriber: cfe-commits. mcgrathr added a parent revision: D79665: [Clang] Pass --pack-dyn-relocs=relr to lld for Fuchsia. Currently all Fuchsia ABIs use a 4k page size, departing

[PATCH] D79665: [Clang] Pass --pack-dyn-relocs=relr to lld for Fuchsia

mcgrathr created this revision. mcgrathr added a reviewer: phosek. Herald added a project: clang. Herald added a subscriber: cfe-commits. The compact format is fully supported on Fuchsia and is the preferred default. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79665 Files:

[PATCH] D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

vitalybuka added a comment. can you please add some basic IR test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79628/new/ https://reviews.llvm.org/D79628 ___ cfe-commits mailing list

[clang] 6bf0ad7 - [Driver] Don't pass -u__llvm_profile_runtime for clang -fprofile-arcs a.o

Author: Fangrui Song Date: 2020-05-08T23:36:29-07:00 New Revision: 6bf0ad78dc01020c9036ad49de2e0f4d59b6def9 URL: https://github.com/llvm/llvm-project/commit/6bf0ad78dc01020c9036ad49de2e0f4d59b6def9 DIFF: https://github.com/llvm/llvm-project/commit/6bf0ad78dc01020c9036ad49de2e0f4d59b6def9.diff