[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

sameerds added inline comments. Comment at: clang/lib/AST/Decl.cpp:3227 + !(BuiltinID == Builtin::BIprintf || BuiltinID == Builtin::BImalloc)) +return 0; + This needs a test. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3102

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

sameerds added inline comments. Comment at: llvm/include/llvm/ADT/Triple.h:700 return getArch() == Triple::r600 || getArch() == Triple::amdgcn; } yaxunl wrote: > jdoerfert wrote: > > What's the difference between an AMDGPU and AMDGCN? > AMDGPU inlude

[PATCH] D79526: [CUDA][HIP] Workaround for resolving host device function against wrong-sided function

yaxunl marked 6 inline comments as done. yaxunl added inline comments. Comment at: clang/test/SemaCUDA/function-overload.cu:479 +namespace ImplicitHostDeviceVsWrongSided { +inline CorrectOverloadRetTy callee(double x); +#pragma clang force_cuda_host_device begin

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

yaxunl added inline comments. Comment at: llvm/include/llvm/ADT/Triple.h:700 return getArch() == Triple::r600 || getArch() == Triple::amdgcn; } jdoerfert wrote: > What's the difference between an AMDGPU and AMDGCN? AMDGPU inlude r600 and amdgcn. r600

[PATCH] D79378: PR34581: Don't remove an 'if (p)' guarding a call to 'operator delete(p)' under -Oz.

rjmccall added a comment. In D79378#2028705 , @rsmith wrote: > In D79378#2019336 , @rjmccall wrote: > > > Is it reasonable to figure out ahead of time that we can skip the null > > check completely? It'd be

[PATCH] D78444: Perform ActOnConversionDeclarator after looking for any virtual functions it overrides

rjmccall added a comment. LGTM with a minor fix. Comment at: clang/lib/Sema/SemaDecl.cpp:10745 +if (CXXConversionDecl *Conversion = dyn_cast(NewFD)) + ActOnConversionDeclarator(Conversion); Indentation is off. CHANGES SINCE LAST ACTION

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

michele.scandale added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:396-401 +allow_reassoc(LangOpts.FastMath || LangOpts.AllowFPReassoc), +no_nans(LangOpts.FastMath || LangOpts.NoHonorNaNs), +no_infs(LangOpts.FastMath ||

[PATCH] D78767: [Sema] Teach -Wcast-align to compute a more accurate alignment when the source expression has array subscript or pointer arithmetic operators

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13066 +std::tuple +static getBaseAlignmentAndOffsetFromLValue(const Expr *E, ASTContext ) { + E = E->IgnoreParens(); I think an `Optional` would be a more self-documenting type here,

Re: [clang] d82538b - Fix -Wunused compiler warning.

Very much so. Also nice all_of use! I'd have never thought about that :) -eric On Mon, May 11, 2020 at 7:03 PM David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Mon, May 11, 2020 at 12:21 AM Haojian Wu via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >>

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

rjmccall added a comment. Okay. So the only real ABI here is the layout of the memory that the arguments are actually written into? And that memory needs to be treated as constant? Unfortunately, I think `byval` just doesn't match what you want because of the mutability — the frontend *has*

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

rjmccall added a comment. IIUC, the way within-statement contraction is supposed to work is that there are supposed to be blocking intrinsics inserted at various places. I don't remember the details, though, or if anyone's thought about how it interacts with cross-statement contraction, which

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

sameerds added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3162 + Opts.OpenMPIsDevice && (T.isNVPTX() || T.isAMDGCN()) && Args.hasArg(options::OPT_fopenmp_cuda_force_full_runtime); jdoerfert wrote: > Can we please not

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

michele.scandale added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:227 + FMF.setAllowContract(FPFeatures.allowFPContractAcrossStatement() || + FPFeatures.allowFPContractWithinStatement()); } I'm not convinced it

[PATCH] D78134: [Sema] Don't apply an lvalue-to-rvalue conversion to a discarded-value expression if it has an array type

rjmccall accepted this revision. rjmccall added a comment. Alright, let's go with this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78134/new/ https://reviews.llvm.org/D78134 ___ cfe-commits mailing

Re: [clang] d82538b - Fix -Wunused compiler warning.

On Mon, May 11, 2020 at 12:21 AM Haojian Wu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Haojian Wu > Date: 2020-05-11T09:20:48+02:00 > New Revision: d82538b3f691f3ba1cb7a945a5f8594f71816fdf > > URL: >

[PATCH] D68049: Propeller: Clang options for basic block sections

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:114-127 + // -fbasic-block-sections=. The allowed values with this option are: + // {"labels", "all", "", "none"}. + // + // "labels": Only

[PATCH] D78134: [Sema] Don't apply an lvalue-to-rvalue conversion to a discarded-value expression if it has an array type

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaExpr.cpp:601-603 // C++ [conv.lval]p1: // A glvalue of a non-function, non-array type T can be // converted to a prvalue.

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

jdoerfert added inline comments. Comment at: clang/lib/AST/Decl.cpp:3224 + if (Context.getTargetInfo().getTriple().isAMDGCN() && + Context.BuiltinInfo.isPredefinedLibFunction(BuiltinID) && sameerds wrote: > arsenm wrote: > > This is also identical to the

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

sameerds added inline comments. Comment at: clang/lib/AST/Decl.cpp:3224 + if (Context.getTargetInfo().getTriple().isAMDGCN() && + Context.BuiltinInfo.isPredefinedLibFunction(BuiltinID) && arsenm wrote: > This is also identical to the cuda handling above,

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

arsenm added a comment. In D79744#2030535 , @rjmccall wrote: > In D79744#2030481 , @arsenm wrote: > > > In D79744#2030294 , @rjmccall > > wrote: > > > > > The parameter

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram marked an inline comment as done. tmsriram added inline comments. Comment at: lld/ELF/LTO.cpp:80 // Check if basic block sections must be used. // Allowed values for --lto-basicblock-sections are "all", "labels", // "", or none. This is the equivalent

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

arsenm added inline comments. Comment at: clang/lib/AST/Decl.cpp:3224 + if (Context.getTargetInfo().getTriple().isAMDGCN() && + Context.BuiltinInfo.isPredefinedLibFunction(BuiltinID) && This is also identical to the cuda handling above, can you merge

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 263326. atmnpatel added a comment. Fixed check for scalar types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files:

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

arsenm added a comment. Test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79754/new/ https://reviews.llvm.org/D79754 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79755: Implement constexpr BinaryOperator for vector types

erichkeane created this revision. erichkeane added reviewers: eli.friedman, RKSimon, aaron.ballman. These operations do member-wise versions of the all of the listed operations. This patch implements all of the binaryoperators for these types. Note that the test is required to use codegen as I

[PATCH] D79742: [WebAssembly] Implement pseudo-min/max SIMD instructions

tlively marked an inline comment as done. tlively added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:147 +TARGET_BUILTIN(__builtin_wasm_pmin_f64x2, "V2dV2dV2d", "nc", "simd128") +TARGET_BUILTIN(__builtin_wasm_pmax_f64x2, "V2dV2dV2d", "nc",

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram updated this revision to Diff 263322. tmsriram added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 Files: clang/docs/ClangCommandLineReference.rst clang/docs/UsersManual.rst

[PATCH] D78134: [Sema] Don't apply an lvalue-to-rvalue conversion to a discarded-value expression if it has an array type

ahatanak updated this revision to Diff 263309. ahatanak added a comment. Rebase and ping. I audited the calls to `DefaultLvalueConversion`. As far as I can tell, either an array type is never passed to the function call or there are checks that reject array types after the function is called,

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

saiislam created this revision. saiislam added reviewers: ronlieb, yaxunl, b-sumner, scchan, JonChesterfield. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, guansong. Herald added a reviewer: jdoerfert. Herald added projects: clang, LLVM. saiislam updated this revision to Diff

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

saiislam updated this revision to Diff 263314. saiislam added a comment. Fixed lint errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79754/new/ https://reviews.llvm.org/D79754 Files: clang/lib/AST/Decl.cpp

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

rjmccall added a comment. In D79744#2030481 , @arsenm wrote: > In D79744#2030294 , @rjmccall wrote: > > > The parameter variable is formally considered to be in a particular address > > space, and taking the

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

rjmccall added a comment. I think we might have had to change that test on our fork when we changed the parsing order. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/ https://reviews.llvm.org/D72841

[PATCH] D79742: [WebAssembly] Implement pseudo-min/max SIMD instructions

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:147 +TARGET_BUILTIN(__builtin_wasm_pmin_f64x2, "V2dV2dV2d", "nc", "simd128")

[PATCH] D79730: [NFCi] Switch ordering of ParseLangArgs and ParseCodeGenArgs.

rjmccall added a comment. I think it makes sense; if nothing else, we're trying to upstream all that work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79730/new/ https://reviews.llvm.org/D79730 ___

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

plotfi added a comment. @rjmccall @mibintc I think the diagnostics-order.c test is still behaving correctly technically. The note lines are still printing with the associated error lines, it just happens that one of the warning lines prints at the end instead of in the middle. ie: error:

[clang] d0e7fd6 - Revert "[FileCheck] Support comment directives"

Author: Joel E. Denny Date: 2020-05-11T19:41:22-04:00 New Revision: d0e7fd6b624b1943f3780a69883690017d2efad2 URL: https://github.com/llvm/llvm-project/commit/d0e7fd6b624b1943f3780a69883690017d2efad2 DIFF: https://github.com/llvm/llvm-project/commit/d0e7fd6b624b1943f3780a69883690017d2efad2.diff

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

arsenm added a comment. In D79744#2030294 , @rjmccall wrote: > The parameter variable is formally considered to be in a particular address > space, and taking the address of it yields a pointer in that address space. > That can only work for an

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

plotfi added a comment. That was a good fix. I am pretty sure this does mean the diagnostics-order.c will fail on apple's bots. The same diagnostics lines print, but in the wrong order. I haven't root caused that yet. In D72841#2030099 , @mibintc wrote:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 263294. gamesh411 added a comment. Implement a solution without a dependency on clangTooling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files:

[PATCH] D79526: [CUDA][HIP] Workaround for resolving host device function against wrong-sided function

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM, modulo cosmetic test changes mentioned below. Comment at: clang/test/SemaCUDA/function-overload.cu:479 +namespace ImplicitHostDeviceVsWrongSided { +inline

[PATCH] D79357: [SveEmitter] Add builtins for svdup and svindex

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79357/new/ https://reviews.llvm.org/D79357 ___ cfe-commits mailing list

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

JDevlieghere added inline comments. Comment at: llvm/cmake/config-ix.cmake:514 + if(ZLIB_FOUND) +set(LLVM_ENABLE_ZLIB "YES" CACHE STRING + "Use zlib for compression/decompression if available. Can be ON, OFF, or FORCE_ON" phosek wrote: > JDevlieghere

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. In D79219#2029520 , @JDevlieghere wrote: > I'm in favor of this change. I'm not too happy with how this works in CMake, > I've expressed similar concerns when the FORCE_ON approach was suggested in > D71306

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 263288. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/CMakeLists.txt clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in compiler-rt/test/lit.common.configured.in

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 263284. phosek marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/CMakeLists.txt clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in

[PATCH] D77542: [PowerPC] Treat 'Z' inline asm constraint as a true memory constraint

amyk added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:277 break; case 'Q': // Memory operand that is an offset from a register (it is // usually better to use `m' or `es' in asm statements) nemanjai wrote: > amyk wrote:

[PATCH] D79730: [NFCi] Switch ordering of ParseLangArgs and ParseCodeGenArgs.

plotfi added a comment. In D79730#2030037 , @rjmccall wrote: > I don't think the reversion is necessary; it's being fixed to remove the > dependency. This is a good change, though. Should I still try to land this diff so that it matches the behavior

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

rjmccall added a comment. The parameter variable is formally considered to be in a particular address space, and taking the address of it yields a pointer in that address space. That can only work for an indirect argument if either (1) the address space of the pointer that's actually passed

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

rampitec added a comment. Typo in commit message: "Previously, indirect arguments assumed assumed". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79744/new/ https://reviews.llvm.org/D79744 ___ cfe-commits mailing list

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:38 #include "llvm/Frontend/OpenMP/OMPConstants.h" +#include "llvm/Support/ErrorHandling.h" #include Why do you need this here? Comment at:

[PATCH] D79733: [clang][SLH] Add __has_feature(speculative_load_hardening)

This revision was automatically updated to reflect the committed changes. Closed by commit rG379e68a76309: [clang][SLH] Add __has_feature(speculative_load_hardening) (authored by zbrid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79733/new/

[PATCH] D79655: [WebAssembly] Ignore exception specifications

dschuff added a comment. Actually, would it be possible to not ignore `throw()` but make it an alias for `noexcept(true)`? Apparently that is the standard behavior in C++17, so it might make more sense to just implement that now rather than just warning all the time and ignoring it. It would

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

arsenm updated this revision to Diff 263274. arsenm added a comment. Forgot to commit a new test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79744/new/ https://reviews.llvm.org/D79744 Files: clang/include/clang/CodeGen/CGFunctionInfo.h clang/lib/CodeGen/CGCall.cpp

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

zbrid created this revision. zbrid added reviewers: mattdr, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Asm goto is not supported by SLH. Warn if an instance of asm goto is detected while SLH is enabled. Test included. Repository: rG LLVM Github Monorepo

[PATCH] D79526: [CUDA][HIP] Workaround for resolving host device function against wrong-sided function

yaxunl updated this revision to Diff 263268. yaxunl marked 3 inline comments as done. yaxunl added a comment. revised by Artem's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79526/new/ https://reviews.llvm.org/D79526 Files: clang/include/clang/Sema/Sema.h

[PATCH] D79691: [clangd] Have suppression comments take precedence over warning-as-error

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Could you also put `Fixes https://github.com/clangd/clangd/issues/375` in the commit message? Comment at:

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

arsenm created this revision. arsenm added reviewers: yaxunl, hliao, jdoerfert, rjmccall, Anastasia, rampitec. Herald added subscribers: kerbowa, nhaehnle, wdng, jvesely. arsenm added parent revisions: D79732: AMDGPU/HIP: Don't replace pointer types in kernel argument structs, D79630: AMDGPU:

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

rnk added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-codeview-display-name.cpp:10 +// RUN: %clang_cc1 -fblocks -debug-info-kind=limited -gcodeview -emit-llvm %s \ +// RUN: -o - -triple=x86_64-pc-win32 -Wno-new-returns-null -fms-compatibility | \ +//

[clang] 609ef94 - [CMake] Fix building with -DBUILD_SHARED_LIBS=ON on mingw

Author: Martin Storsjö Date: 2020-05-11T23:51:14+03:00 New Revision: 609ef948387ba40e3693c2bd693d82ca34dcdc02 URL: https://github.com/llvm/llvm-project/commit/609ef948387ba40e3693c2bd693d82ca34dcdc02 DIFF:

Re: [PATCH] D72281: [Matrix] Add matrix type to Clang.

FWIW this broke lldb builds due to an unhandled enumeration. I've fixed them in: commit cd7cb1f4ce3ffc8be1146eeba28ae7dc50089459 (origin/master, origin/HEAD) Author: Eric Christopher Date: Mon May 11 13:44:12 2020 -0700 Update lldb for rG10658691951f to avoid Werror messages around

Re: [clang] c90e198 - Fix parsing of enum-base to follow C++11 rules.

On Mon, 11 May 2020 at 06:37, Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Sat, May 9, 2020 at 4:32 AM Richard Smith via cfe-commits > wrote: > > > > > > Author: Richard Smith > > Date: 2020-05-08T19:32:00-07:00 > > New Revision:

[clang] 379e68a - [clang][SLH] Add __has_feature(speculative_load_hardening)

Author: Zola Bridges Date: 2020-05-11T13:37:12-07:00 New Revision: 379e68a763097bed6c6dc7453e4b732e3d68 URL: https://github.com/llvm/llvm-project/commit/379e68a763097bed6c6dc7453e4b732e3d68 DIFF: https://github.com/llvm/llvm-project/commit/379e68a763097bed6c6dc7453e4b732e3d68.diff

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

This revision was automatically updated to reflect the committed changes. Closed by commit rGe97a3e5d9d42: [X86] Add a Pass that builds a Condensed CFG for Load Value Injection (LVI)… (authored by sconstab, committed by craig.topper). Changed prior to commit:

[PATCH] D79698: Run Coverage pass before other *San passes under new pass manager

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d5bb94d7838: Run Coverage pass before other *San passes under new pass manager (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79526: [CUDA][HIP] Workaround for resolving host device function against wrong-sided function

yaxunl marked 6 inline comments as done. yaxunl added inline comments. Comment at: clang/include/clang/Sema/Sema.h:11670 + bool IsCUDAImplicitHostDeviceFunction(const FunctionDecl *D); + tra wrote: > I think this can be `static` as it does not need Sema's

[PATCH] D79636: [LangRef] Clarify the semantics of the `byval` attribute

efriedma added a comment. Sure, I'm happy with the second option. > Alignment at the call site might be higher than of the copy, breaking with > the idea that the call site and callee "properties" match. Though, the > attributes can probably be kept in sync if we teach the relevant parts. The

[PATCH] D79742: [WebAssembly] Implement pseudo-min/max SIMD instructions

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. As proposed in https://github.com/WebAssembly/simd/pull/122. Since these instructions

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79357: [SveEmitter] Add builtins for svdup and svindex

sdesmalen updated this revision to Diff 263258. sdesmalen added a comment. - Use `llvm.aarch64.sve.dup.x` for `svdup_n_b` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79357/new/ https://reviews.llvm.org/D79357 Files: clang/include/clang/Basic/arm_sve.td

[clang] e97a3e5 - [X86] Add a Pass that builds a Condensed CFG for Load Value Injection (LVI) Gadgets

Author: Scott Constable Date: 2020-05-11T13:08:35-07:00 New Revision: e97a3e5d9d428c4d455fa1b1982728bb71f0c397 URL: https://github.com/llvm/llvm-project/commit/e97a3e5d9d428c4d455fa1b1982728bb71f0c397 DIFF:

[clang] 7d5bb94 - Run Coverage pass before other *San passes under new pass manager

Author: Arthur Eubanks Date: 2020-05-11T12:59:09-07:00 New Revision: 7d5bb94d78386e4653535c35d3e8258bf4502340 URL: https://github.com/llvm/llvm-project/commit/7d5bb94d78386e4653535c35d3e8258bf4502340 DIFF:

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. In D72841#2029821 , @plotfi wrote: > @ab @rjmccall @mibintc Posted D79730 for > consideration. > @mibintc can you produce a version of _this_ diff that works with D79730 >

[PATCH] D79733: [clang][SLH] Add __has_feature(speculative_load_hardening)

zbrid updated this revision to Diff 263247. zbrid added a comment. Change langopt type + SpeculativeLoadHardeningEnabled -> SpeculativeLoadHardening This is to match the CodeGenOpt for SLH that already exists and to address mattdr's feedback. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D79735: FP LangOpts should not be dependent on CGOpts

This revision was automatically updated to reflect the committed changes. Closed by commit rG01dc694ccb86: FP LangOpts should not be dependent on CGOpt This bug was observed by Apple… (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78767: [Sema] Teach -Wcast-align to compute a more accurate alignment when the source expression has array subscript or pointer arithmetic operators

ahatanak updated this revision to Diff 263238. ahatanak marked an inline comment as done. ahatanak added a comment. Define two helper functions in Sema that compute the alignment of a VarDecl and a constant offset from it and use them instead of the classes for evaluating lvalue and pointer

[PATCH] D79735: FP LangOpts should not be dependent on CGOpts

plotfi added a comment. @mibintc Nice solution. I think this would work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79735/new/ https://reviews.llvm.org/D79735 ___ cfe-commits mailing list

[PATCH] D79733: [clang][SLH] Add __has_feature(speculative_load_hardening)

mattdr added subscribers: rsmith, mattdr. mattdr added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:369 +BENIGN_LANGOPT(SpeculativeLoadHardeningEnabled, 1, 0, + "Speculative load hardening enabled") I've read the

[PATCH] D79276: [FileCheck] Support comment directives

jdenny marked an inline comment as done. jdenny added inline comments. Comment at: llvm/test/FileCheck/comment/suffixes.txt:1-2 +# Comment prefixes plus check directive suffixes are not comment directives +# and are treated as plain text. + jhenderson wrote: >

[PATCH] D79730: [NFCi] Switch ordering of ParseLangArgs and ParseCodeGenArgs.

rjmccall added a comment. I don't think the reversion is necessary; it's being fixed to remove the dependency. This is a good change, though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79730/new/ https://reviews.llvm.org/D79730

[clang] 01dc694 - FP LangOpts should not be dependent on CGOpt

Author: Melanie Blower Date: 2020-05-11T12:32:35-07:00 New Revision: 01dc694ccb8689a4b4a180da67ed042f85bbcfd5 URL: https://github.com/llvm/llvm-project/commit/01dc694ccb8689a4b4a180da67ed042f85bbcfd5 DIFF:

[PATCH] D79735: FP LangOpts should not be dependent on CGOpts

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, Melanie. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79735/new/ https://reviews.llvm.org/D79735

[PATCH] D79276: [FileCheck] Support comment directives

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a9a5f9893c8: [FileCheck] Support comment directives (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79276/new/

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: clang/test/SemaCXX/deprecated-copy.cpp:7 +#ifdef NO_USER_PROVIDED +// expected-no-diagnostics +#endif xbolva00 wrote: > Quuxplusone wrote: > > I'm fairly confident this should

[PATCH] D62368: Add vendor identity check for Hygon Dhyana processor in Scudo

craig.topper added a comment. In D62368#2029870 , @cryptoad wrote: > In D62368#2029752 , @craig.topper > wrote: > > > I noticed when I pulled this morning that this seems to have been pushed as > > a branch to

[PATCH] D62368: Add vendor identity check for Hygon Dhyana processor in Scudo

cryptoad added a comment. In D62368#2030005 , @craig.topper wrote: > I've deleted the branch in the github web interface. I didn't know I could do > that. Ok thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

xbolva00 marked 4 inline comments as done. xbolva00 added a comment. Thanks for initial comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:158 +def DeprecatedCopy : DiagGroup<"deprecated-copy", [DeprecatedCopyUserProvided]>; +def DeprecatedCopyDtor :

[PATCH] D76996: [analyzer] Improve PlacementNewChecker

f00kat added a comment. In D76996#2017572 , @martong wrote: > > ... This draws a pattern that we should recursively descend down to the top > > most base region. I.e. the different check*RegionAlign methods should call > > into each other until we reach

[PATCH] D79526: [CUDA][HIP] Workaround for resolving host device function against wrong-sided function

tra added inline comments. Comment at: clang/include/clang/Sema/Sema.h:11670 + bool IsCUDAImplicitHostDeviceFunction(const FunctionDecl *D); + I think this can be `static` as it does not need Sema's state. Comment at:

[PATCH] D79639: [SveEmitter] Builtins for SVE matrix multiply `mmla`.

fpetrogalli added a comment. Adding some text here as phabricator refuses to submit with an empty comment... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79639/new/ https://reviews.llvm.org/D79639

[PATCH] D79639: [SveEmitter] Builtins for SVE matrix multiply `mmla`.

fpetrogalli updated this revision to Diff 263239. fpetrogalli marked 4 inline comments as done. fpetrogalli added a comment. Thank you for the review @sdesmalen, I have addressed all your comments. Francesco Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79735: FP LangOpts should not be dependent on CGOpts

mibintc created this revision. mibintc added reviewers: plotfi, rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. This bug was observed by Apple since their compiler processes LangOpts and CGOpts in a different order Repository: rG LLVM Github Monorepo

[clang] 9a9a5f9 - [FileCheck] Support comment directives

Author: Joel E. Denny Date: 2020-05-11T14:53:48-04:00 New Revision: 9a9a5f9893c8db05cebc8818eb8485bff61f7c74 URL: https://github.com/llvm/llvm-project/commit/9a9a5f9893c8db05cebc8818eb8485bff61f7c74 DIFF: https://github.com/llvm/llvm-project/commit/9a9a5f9893c8db05cebc8818eb8485bff61f7c74.diff

[PATCH] D79698: Run Coverage pass before other *San passes under new pass manager

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79698/new/ https://reviews.llvm.org/D79698

[PATCH] D79733: [clang][SLH] Add __has_feature(speculative_load_hardening)

zbrid marked an inline comment as done. zbrid added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5357 - if (Args.hasFlag(options::OPT_mspeculative_load_hardening, options::OPT_mno_speculative_load_hardening, - false)) + if

[PATCH] D79733: [clang][SLH] Add __has_feature(speculative_load_hardening)

zbrid marked an inline comment as done. zbrid added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5357 - if (Args.hasFlag(options::OPT_mspeculative_load_hardening, options::OPT_mno_speculative_load_hardening, - false)) + if

[PATCH] D79733: [clang][SLH] Add __has_feature(speculative_load_hardening)

zbrid created this revision. zbrid added reviewers: craig.topper, echristo. Herald added a project: clang. Herald added a subscriber: cfe-commits. zbrid marked an inline comment as done. zbrid added inline comments. zbrid marked an inline comment as done. Comment at:

[PATCH] D62368: Add vendor identity check for Hygon Dhyana processor in Scudo

cryptoad added a comment. In D62368#2029752 , @craig.topper wrote: > I noticed when I pulled this morning that this seems to have been pushed as a > branch to the repo > > From https://github.com/llvm/llvm-project > > eb7d32e..63a4fdd master ->

[PATCH] D79732: AMDGPU/HIP: Don't replace pointer types in kernel argument structs

arsenm created this revision. arsenm added reviewers: hliao, yaxunl. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. Currently this is counterproductive and doesn't have the desired effect. The way the promotion is handled is by reinterpreting the

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

plotfi added a subscriber: ab. plotfi added a comment. @ab @rjmccall @mibintc Posted D79730 for consideration. @mibintc can you produce a version of _this_ diff that works with D79730 applied. Currently the following fail, as

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

efriedma added a comment. This approach seems to reflect the consensus from the mailing list. Comment at: clang/include/clang/AST/RecordLayout.h:74 + /// The maximum allowed field alignment. This is set by #pragma pack. + CharUnits MaxFieldAlignment; + If we

  1   2   >