[PATCH] D79655: [WebAssembly] Handle exception specifications

This revision was automatically updated to reflect the committed changes. Closed by commit rGbca347508c86: [WebAssembly] Handle exception specifications (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79655/new/

[PATCH] D79655: [WebAssembly] Handle exception specifications

aheejin marked an inline comment as done. aheejin added inline comments. Comment at: clang/test/CodeGenCXX/wasm-eh.cpp:399 +// RUN: %clang_cc1 %s -triple wasm32-unknown-unknown -fms-extensions -fexceptions -fcxx-exceptions -fwasm-exceptions -target-feature

[clang] 945ad14 - Revert "[WebAssembly] Handle exception specifications"

Author: Heejin Ahn Date: 2020-05-15T21:33:44-07:00 New Revision: 945ad141ce63c94b5822d52ad76c49aba906a4b8 URL: https://github.com/llvm/llvm-project/commit/945ad141ce63c94b5822d52ad76c49aba906a4b8 DIFF: https://github.com/llvm/llvm-project/commit/945ad141ce63c94b5822d52ad76c49aba906a4b8.diff

[clang] bca3475 - [WebAssembly] Handle exception specifications

Author: Heejin Ahn Date: 2020-05-15T21:03:38-07:00 New Revision: bca347508c86647f9d44992275c9a364fbd9fb0d URL: https://github.com/llvm/llvm-project/commit/bca347508c86647f9d44992275c9a364fbd9fb0d DIFF: https://github.com/llvm/llvm-project/commit/bca347508c86647f9d44992275c9a364fbd9fb0d.diff

[PATCH] D80055: Diagnose union tail padding

jfb marked an inline comment as done. jfb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:264 +def warn_union_tail_padding_uninitialized : Warning< + "Initializing union %0 field %1 only initializes the first %2 of %3 bytes, leaving the

[PATCH] D80055: Diagnose union tail padding

jfb marked an inline comment as done. jfb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:825 +def Padding : DiagGroup<"padding", [UnionTailPadding]>, + DiagCategory<"Padding Issue">; + I'd like to hear what other

[PATCH] D68115: Zero initialize padding in unions

jfb added a comment. To get this unblocked a bit, I implemented a diagnostic: https://reviews.llvm.org/D80055 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68115/new/ https://reviews.llvm.org/D68115

[PATCH] D80055: Diagnose union tail padding

jfb marked an inline comment as done. jfb added inline comments. Comment at: clang/test/CodeGen/union-tail-padding.c:28-36 +union Front { + int i; + long long ll; +}; + +union Front front1; +union Front front2 = {};// expected-warning {{Initializing union 'Front'

[PATCH] D80055: Diagnose union tail padding

dexonsmith added inline comments. Comment at: clang/test/CodeGen/union-tail-padding.c:28-36 +union Front { + int i; + long long ll; +}; + +union Front front1; +union Front front2 = {};// expected-warning {{Initializing union 'Front' field 'i' only initializes the

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.cpp:71-72 + binaryOperator(hasOperatorName("=="), + hasEitherOperand(ignoringParenImpCasts(StringNpos)), +

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.cpp:1-2 +//===--- StringFindStrContainsCheck.cc - clang-tidy---*- C++ +//-*-===// +// Don't need the C++ specifier in a cpp file. ``` //===---

[PATCH] D80055: Diagnose union tail padding

jfb marked an inline comment as done. jfb added inline comments. Comment at: clang/test/CodeGen/union-tail-padding.c:9 +// RUN: %clang_cc1 -Wunion-tail-padding -xc++ -std=c++17 -triple aarch64-apple-darwin %s -emit-llvm -o /dev/null -verify +// RUN: %clang_cc1

[PATCH] D80054: [ASTMatchers] Added BinaryOperator hasOperands matcher

njames93 created this revision. njames93 added reviewers: klimek, aaron.ballman, gribozavr2, alexfh. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds a matcher called `hasOperands` for `BinaryOperator`'s when you need to match both sides but the order isn't important,

[PATCH] D80055: Diagnose union tail padding

jfb created this revision. jfb added reviewers: rsmith, hubert.reinterpretcast. Herald added subscribers: cfe-commits, ributzka, dexonsmith, jkorous. Herald added a project: clang. jfb marked an inline comment as done. jfb added inline comments. Comment at:

[PATCH] D80046: [StackSafety] Make full LTO to attach metadata if MTE is enabled

vitalybuka updated this revision to Diff 264397. vitalybuka added a comment. module flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80046/new/ https://reviews.llvm.org/D80046 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D80046: [StackSafety] Make full LTO to attach metadata if MTE is enabled

vitalybuka updated this revision to Diff 264399. vitalybuka added a comment. typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80046/new/ https://reviews.llvm.org/D80046 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D80046: [StackSafety] Make full LTO to attach metadata if MTE is enabled

vitalybuka updated this revision to Diff 264398. vitalybuka added a comment. new line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80046/new/ https://reviews.llvm.org/D80046 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D79916: Map -O to -O1 instead of -O2

dexonsmith added reviewers: arphaman, Gerolf. dexonsmith accepted this revision. dexonsmith added a comment. IOW, this LGTM if Alex and Gerolf are happy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79916/new/ https://reviews.llvm.org/D79916

[PATCH] D79916: Map -O to -O1 instead of -O2

dexonsmith added subscribers: arphaman, Gerolf. dexonsmith added a comment. In D79916#2039789 , @echristo wrote: > I'm totally down, but you knew that already :) > > Duncan: Do you have any concerns? I doubt it, but just checking. Xcode doesn't use

[PATCH] D79237: [CUDA][HIP] Fix constexpr variables for C++17

yaxunl updated this revision to Diff 264394. yaxunl marked an inline comment as done. yaxunl added a comment. fix constexpr var in templates CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79237/new/ https://reviews.llvm.org/D79237 Files: clang/include/clang/Sema/Sema.h

[PATCH] D80046: [StackSafety] Make full LTO to attach metadata if MTE is enabled

vitalybuka added a comment. > It could also be better, instead of iterating over all functions, simply run > the global pass, but make sure that it does not do too much work on > non-sanitize_memtag functions. I.e. the function pass should bail out on such > functions, and then the data flow

[PATCH] D79237: [CUDA][HIP] Fix constexpr variables for C++17

yaxunl marked an inline comment as done. yaxunl added a comment. In D79237#2039757 , @rsmith wrote: > In D79237#2039559 , @tra wrote: > > > In D79237#2039417 , @tra wrote: >

[PATCH] D79237: [CUDA][HIP] Fix constexpr variables for C++17

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/test/SemaCUDA/constexpr-variables.cu:30-31 + static constexpr int c = sizeof(a); + a[0] = + a[1] = + foo(a); tra wrote: > yaxunl wrote: > > tra wrote: > > > Can we

[PATCH] D79916: Map -O to -O1 instead of -O2

echristo accepted this revision. echristo added a reviewer: dexonsmith. echristo added a comment. This revision is now accepted and ready to land. I'm totally down, but you knew that already :) Duncan: Do you have any concerns? I doubt it, but just checking. Repository: rG LLVM Github

[PATCH] D80046: [StackSafety] Make full LTO to attach metadata if MTE is enabled

eugenis added a comment. I think this is an OK approach. Perhaps a module flag would be even better, then it can be decoupled from "sanitize_memtag", and it would not require iterating over the entire module. You can check how it is used in CFI: !"CFI Canonical Jump Tables". It could also be

[clang-tools-extra] 7af0c85 - [clang-tidy] Transformer checks now store IncludeStyle option

Author: Nathan James Date: 2020-05-16T01:14:55+01:00 New Revision: 7af0c8559b6d9426dd5e977370516d2baa4c206f URL: https://github.com/llvm/llvm-project/commit/7af0c8559b6d9426dd5e977370516d2baa4c206f DIFF: https://github.com/llvm/llvm-project/commit/7af0c8559b6d9426dd5e977370516d2baa4c206f.diff

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

amyk added a comment. I believe we're also missing `IsISA3_1 = false;` in `PPCSubtarget.cpp`. Comment at: llvm/lib/Target/PowerPC/PPC.td:338 + // still exist with the exception of those we know are Power9 specific. + list P10AdditionalFeatures = [DirectivePwr10]; + list

[PATCH] D80046: [StackSafety] Make full LTO to attach metadata if MTE is enabled

vitalybuka updated this revision to Diff 264386. vitalybuka added a comment. pm test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80046/new/ https://reviews.llvm.org/D80046 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D79237: [CUDA][HIP] Fix constexpr variables for C++17

rsmith added a comment. In D79237#2039559 , @tra wrote: > In D79237#2039417 , @tra wrote: > > > > > > Bad news -- it breaks the standard C++ library. [...] >

[PATCH] D80046: [StackSafety] Make full LTO to attach metadata if MTE is enabled

vitalybuka created this revision. vitalybuka added a reviewer: eugenis. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya, inglorion. Herald added projects: clang, LLVM. Depends on D80039 . Repository: rG LLVM Github

[PATCH] D79237: [CUDA][HIP] Fix constexpr variables for C++17

tra added inline comments. Comment at: clang/test/SemaCUDA/constexpr-variables.cu:30-31 + static constexpr int c = sizeof(a); + a[0] = + a[1] = + foo(a); yaxunl wrote: > tra wrote: > > Can we verify the diags for bad cases, too? > By bad cases you mean the

[PATCH] D79942: [clang] Add an API to retrieve implicit constructor arguments.

rjmccall added a comment. This looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79942/new/ https://reviews.llvm.org/D79942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80031: [clang-format] [NFC] release note placed in the wrong location and other rst linting errors

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:114 + this occurs when the use of the ``extern`` keyword is neglected in the + declaration of a variable in a header file. In some cases, no

[PATCH] D79121: Add nomerge function attribute to clang

zequanwu added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79121/new/ https://reviews.llvm.org/D79121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3434-3435 + if (Stack->getDefaultDSA() == DSA_firstprivate && + VD->getStorageDuration() == SD_Static && + CanonicalVD->getDeclContext()->isFileContext() &&

[PATCH] D80041: [clang-format] [PR45198] deletes whitespace inside of a noexcept specifier

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, rianquinn, JakeMerdichAMD, mitchell-stellar. MyDeveloperDay added projects: clang, clang-format. https://bugs.llvm.org/show_bug.cgi?id=45198 The following: template< typename T, enable_if_t::value> =

[PATCH] D79655: [WebAssembly] Handle exception specifications

dschuff accepted this revision. dschuff added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGenCXX/wasm-eh.cpp:399 +// RUN: %clang_cc1 %s -triple wasm32-unknown-unknown -fms-extensions -fexceptions -fcxx-exceptions

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 264365. atmnpatel added a comment. Necessary cleanups and adds a basic check for static local variables and static data members. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/

[PATCH] D80039: [NFC, StackSafety] LTO tests for MTE and StackSafety

vitalybuka updated this revision to Diff 264361. vitalybuka added a comment. comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80039/new/ https://reviews.llvm.org/D80039 Files: clang/test/Driver/memtag_lto.c Index:

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang updated this revision to Diff 264357. LukeZhuang added a comment. updated 05/15/2020: (1) add documents about __builtin_expect_with_probability (2) modify SemaChecking to handle evaluate constant floating-point expression (3) modify CGBuiltin to evaluate constant floating-point

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang marked 15 inline comments as done. LukeZhuang added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:567 BUILTIN(__builtin_expect, "LiLiLi" , "nc") +BUILTIN(__builtin_expect_with_probability, "LiLiLid" , "nc") BUILTIN(__builtin_prefetch,

[PATCH] D80039: [NFC, StackSafety] LTO tests for MTE and StackSafety

vitalybuka updated this revision to Diff 264360. vitalybuka added a comment. remove fixme Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80039/new/ https://reviews.llvm.org/D80039 Files: clang/test/Driver/memtag_lto.c Index:

[PATCH] D79237: [CUDA][HIP] Fix constexpr variables for C++17

tra added a comment. In D79237#2039417 , @tra wrote: > LGTM in general. Let me check the patch on our tensorflow build. Bad news -- it breaks the standard C++ library. Reproducer: $ bin/clang++ -x cuda /dev/null -fsyntax-only -include algorithm

[PATCH] D80039: [NFC, StackSafety] LTO tests for MTE and StackSafety

vitalybuka created this revision. vitalybuka added a reviewer: eugenis. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya, inglorion. Herald added a project: clang. vitalybuka updated this revision to Diff 264360. vitalybuka added a comment. vitalybuka updated this revision

[libunwind] b31cb3a - unwind: fix unwind build without heap

Author: Saleem Abdulrasool Date: 2020-05-15T14:45:22-07:00 New Revision: b31cb3aa5ee7ea92d830b06a0a7e42c7f2791dd4 URL: https://github.com/llvm/llvm-project/commit/b31cb3aa5ee7ea92d830b06a0a7e42c7f2791dd4 DIFF:

[PATCH] D79694: [tests][Driver] Set `--sysroot=""` to allow `DEFAULT_SYSROOT` build

This revision was automatically updated to reflect the committed changes. Closed by commit rG15f0f824b36e: [tests][Driver] Set `--sysroot=` to allow `DEFAULT_SYSROOT` build (authored by hubert.reinterpretcast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79693: [test][ARM][CMSE] Use clang_cc1 in arm_cmse.h tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f5fc73a9d52: [test][ARM][CMSE] Use clang_cc1 in arm_cmse.h tests (authored by hubert.reinterpretcast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79237: [CUDA][HIP] Fix constexpr variables for C++17

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/test/SemaCUDA/constexpr-variables.cu:30-31 + static constexpr int c = sizeof(a); + a[0] = + a[1] = + foo(a); tra wrote: > Can we verify the diags for bad cases, too?

[clang] 3f5fc73 - [test][ARM][CMSE] Use clang_cc1 in arm_cmse.h tests

Author: Hubert Tong Date: 2020-05-15T17:34:00-04:00 New Revision: 3f5fc73a9d52fc7f128dc4e53ccc63b88fc44fb6 URL: https://github.com/llvm/llvm-project/commit/3f5fc73a9d52fc7f128dc4e53ccc63b88fc44fb6 DIFF: https://github.com/llvm/llvm-project/commit/3f5fc73a9d52fc7f128dc4e53ccc63b88fc44fb6.diff

[clang] 15f0f82 - [tests][Driver] Set `--sysroot=""` to allow `DEFAULT_SYSROOT` build

Author: Hubert Tong Date: 2020-05-15T17:34:00-04:00 New Revision: 15f0f824b36ea06fcb17bc56ecd181520b4bfbcf URL: https://github.com/llvm/llvm-project/commit/15f0f824b36ea06fcb17bc56ecd181520b4bfbcf DIFF: https://github.com/llvm/llvm-project/commit/15f0f824b36ea06fcb17bc56ecd181520b4bfbcf.diff

[PATCH] D79655: [WebAssembly] Handle exception specifications

aheejin updated this revision to Diff 264335. aheejin added a comment. Handle `throw()` in the same way as `noexcept` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79655/new/ https://reviews.llvm.org/D79655 Files:

[PATCH] D80031: [clang-format] [NFC] release note placed in the wrong location and other rst linting errors

Eugene.Zelenko added inline comments. Comment at: clang/docs/ReleaseNotes.rst:114 + this occurs when the use of the ``extern`` keyword is neglected in the + declaration of a variable in a header file. In some cases, no specific translation unit This and

[PATCH] D79655: [WebAssembly] Handle exception specifications

aheejin added a comment. Now this handles `throw()` in the same way as `noexcept`, and prints a warning only in case of `throw(type, ..)`, as you suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79655/new/ https://reviews.llvm.org/D79655

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

njames93 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:15 - `abseil-duration-addition `_, "Yes" - `abseil-duration-comparison `_, "Yes" - `abseil-duration-conversion-cast `_, "Yes" - `abseil-duration-division `_, "Yes" -

[PATCH] D79237: [CUDA][HIP] Fix constexpr variables for C++17

tra added a comment. LGTM in general. Let me check the patch on our tensorflow build. Comment at: clang/test/SemaCUDA/constexpr-variables.cu:30-31 + static constexpr int c = sizeof(a); + a[0] = + a[1] = + foo(a); Can we verify the diags for bad cases,

[PATCH] D80031: [clang-format] [NFC] release note placed in the wrong location and other rst linting errors

ghvg1313 accepted this revision. ghvg1313 added a comment. This revision is now accepted and ready to land. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80031/new/ https://reviews.llvm.org/D80031

[PATCH] D79905: [clang-format] [PR44476] Add space between template and attribute

MyDeveloperDay updated this revision to Diff 264327. MyDeveloperDay edited the summary of this revision. MyDeveloperDay added a comment. Correct the typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79905/new/ https://reviews.llvm.org/D79905 Files:

[PATCH] D80031: [clang-format] [NFC] release note placed in the wrong location and other rst linting errors

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: ghvg1313, krasimir, jolesiak, Eugene.Zelenko. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay edited the summary of this revision. The release notes for `ObjCBreakBeforeNestedBlockParam` was placed between

[PATCH] D80008: [clang-format] [PR45942] [[nodiscard]] causes && to be miss interpreted as BinaryOperators

MyDeveloperDay updated this revision to Diff 264325. MyDeveloperDay added a comment. pre-merge tests showed I wasn't quite rebased however it overlaps with D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration However I feel I

[PATCH] D79237: [CUDA][HIP] Fix constexpr variables for C++17

yaxunl updated this revision to Diff 264329. yaxunl edited the summary of this revision. yaxunl added a comment. add implicit constant attribute to constexpr file scope variables and constexpr static data members in device compilation. CHANGES SINCE LAST ACTION

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

arsenm added a comment. In D71726#1801346 , @__simt__ wrote: > In D71726#1792852 , @yaxunl wrote: > > > In D71726#1791904 , @jfb wrote: > > > > > This generally seems fine.

[PATCH] D79935: [clang-format] [PR44345] Long namespace closing comment is duplicated endlessly

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8ea35e63f50: [clang-format] [PR44345] Long namespace closing comment is duplicated endlessly (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79935: [clang-format] [PR44345] Long namespace closing comment is duplicated endlessly

MyDeveloperDay updated this revision to Diff 264319. MyDeveloperDay added a comment. Fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79935/new/ https://reviews.llvm.org/D79935 Files: clang/lib/Format/NamespaceEndCommentsFixer.cpp clang/unittests/Format/FormatTest.cpp

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

tdl-g added a comment. Eugene, thank you for the comments, I'll address them soon. For the moment I'm trying to figure out what's up with the list.rst changes. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:15 - `abseil-duration-addition `_, "Yes" -

[PATCH] D78508: [Clang] Allow long as size_t printf argument on 32-bit Windows platforms.

jacek added a comment. I don't mind dropping the patch, we can mitigate the problem in Wine. My understanding is that we could use "pedantic" logic similar to NSInteger in checkFormatExpr, please let me know if you'd like something like that. I still think that using casts in such cases is not

[clang] e8ea35e - [clang-format] [PR44345] Long namespace closing comment is duplicated endlessly

Author: mydeveloperday Date: 2020-05-15T21:00:55+01:00 New Revision: e8ea35e63f50486fe497d8565abb8cd5b2820a96 URL: https://github.com/llvm/llvm-project/commit/e8ea35e63f50486fe497d8565abb8cd5b2820a96 DIFF:

[PATCH] D79894: [clang][slh] Add test for SLH feature checking macro

This revision was automatically updated to reflect the committed changes. Closed by commit rG18a855da431e: [clang][slh] Add test for SLH feature checking macro (authored by zbrid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79894/new/

[PATCH] D78508: [Clang] Allow long as size_t printf argument on 32-bit Windows platforms.

rsmith added inline comments. Comment at: clang/lib/AST/FormatString.cpp:407 +if ((isSizeT() || isPtrdiffT()) && +C.getTargetInfo().getTriple().isOSMSVCRT() && +C.getTargetInfo().getTriple().isArch32Bit()) amccarth

[clang] 18a855d - [clang][slh] Add test for SLH feature checking macro

Author: Zola Bridges Date: 2020-05-15T12:23:31-07:00 New Revision: 18a855da431e74499695ce43a8db23a1755ba632 URL: https://github.com/llvm/llvm-project/commit/18a855da431e74499695ce43a8db23a1755ba632 DIFF: https://github.com/llvm/llvm-project/commit/18a855da431e74499695ce43a8db23a1755ba632.diff

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

lei updated this revision to Diff 264303. lei retitled this revision from " [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm" to "[PowerPC] Add support for -mcpu=pwr10 in both clang and llvm". lei added a comment. missed a file Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D79967: Fix debug info for NoDebug attr

dblaikie added a subscriber: vsk. dblaikie added a comment. Could you check the commit history for this feature and rope in some folks who added the function declaration work (it's for debug call sites) - maybe @vsk is the right person, or knows who is, to check this is the right fix for

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

lei updated this revision to Diff 264301. lei added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Add support in llvm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80020/new/

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

zequanwu updated this revision to Diff 264300. zequanwu added a comment. Since the new warning is controlled by `-Wuninitialized`, I disabled it in existing test case and added a separate test case for `-Wuninitialized-const-reference`. CHANGES SINCE LAST ACTION

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.cpp:18 +#include "clang/Tooling/Transformer/Stencil.h" +#include + asserts are not used. Comment at:

[PATCH] D80025: [ASTMatcher] Correct memoization bug ignoring direction (descendants or ancestors)

loic-joly-sonarsource created this revision. loic-joly-sonarsource added a reviewer: klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. In ASTMatcher, when we have `has(...)` and `hasParent(...)` called with the same internal matcher on the same node, the memoization

[PATCH] D79465: [clang-format] Fix line lengths w/ comments in align

JakeMerdichAMD updated this revision to Diff 264294. JakeMerdichAMD added a comment. Rebase to fix merge conflict Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79465/new/ https://reviews.llvm.org/D79465 Files:

[PATCH] D80001: [RFC/WIP][clang] Fix printing of names of inherited constructors

dblaikie added a comment. @rsmith - this changes printing the name of inherited constructors in general, not just for debug info - could you take a gander and make sure that's probably OK for other callers trying to print the name of an inheriting constructor? Repository: rG LLVM Github

[PATCH] D79995: [clang] [MinGW] Fix libunwind extension

mati865 updated this revision to Diff 264292. mati865 added a comment. Applied review comment and formatted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79995/new/ https://reviews.llvm.org/D79995 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp Index:

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

tdl-g created this revision. tdl-g added a reviewer: ymandel. Herald added subscribers: cfe-commits, phosek, Charusso, mgorny. Herald added a project: clang. Eugene.Zelenko edited reviewers, added: alexfh, hokein, aaron.ballman, njames93; removed: ymandel. Eugene.Zelenko added a project:

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

scott.linder added a comment. I'd be interested in the answer concerning why we need to avoid `git rev-parse HEAD`; it seems like the cleanest solution is to just always check if `git rev-parse HEAD` changes to determine whether to regenerate the header. If that is not feasible for some

[PATCH] D79973: [WebAssembly] Update latest implemented SIMD instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc702d4bf4110: [WebAssembly] Update latest implemented SIMD instructions (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79973/new/

[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rGf89f7da999f3: [IR] Convert null-pointer-is-valid into an enum attribute (authored by nikic). Changed prior to commit: https://reviews.llvm.org/D78862?vs=261375=264285#toc Repository: rG LLVM Github

[clang] c702d4b - [WebAssembly] Update latest implemented SIMD instructions

Author: Thomas Lively Date: 2020-05-15T10:53:02-07:00 New Revision: c702d4bf4110b65ba7a00daf3af3353ea5b74787 URL: https://github.com/llvm/llvm-project/commit/c702d4bf4110b65ba7a00daf3af3353ea5b74787 DIFF: https://github.com/llvm/llvm-project/commit/c702d4bf4110b65ba7a00daf3af3353ea5b74787.diff

[PATCH] D79995: [clang] [MinGW] Fix libunwind extension

mstorsjo added a reviewer: rnk. mstorsjo added a subscriber: rnk. mstorsjo added a comment. So, using `-l:libunwind.dll.a` is definitely more correct than `-l:libunwind.so` on this platform, so in that sense this is good. In my toolchains I don't use this option at all so far, because I have

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in the front end

lei created this revision. lei added reviewers: stefanp, nemanjai, amyk, hfinkel, power-llvm-team. Herald added subscribers: shchenz, wuzish. Herald added a project: clang. jsji added a reviewer: PowerPC. jsji added a project: PowerPC. This patch simply adds support for the new CPU in

[PATCH] D78508: [Clang] Allow long as size_t printf argument on 32-bit Windows platforms.

hans added a comment. > clang issues a warning, leaving no good way to print SIZE_T (other than > disabling warnings or adding useless casts) I also don't think Clang should change here though. The warning is legit for code that cares about portability, and inserting a cast is probably the

[clang] f89f7da - [IR] Convert null-pointer-is-valid into an enum attribute

Author: Nikita Popov Date: 2020-05-15T19:41:07+02:00 New Revision: f89f7da999f362e4213c69923328dd1033276e59 URL: https://github.com/llvm/llvm-project/commit/f89f7da999f362e4213c69923328dd1033276e59 DIFF: https://github.com/llvm/llvm-project/commit/f89f7da999f362e4213c69923328dd1033276e59.diff

[PATCH] D74668: [Clang][BPF] implement __builtin_btf_type_id() builtin function

This revision was automatically updated to reflect the committed changes. Closed by commit rG072cde03aaa1: [Clang][BPF] implement __builtin_btf_type_id() builtin function (authored by yonghong-song). Changed prior to commit: https://reviews.llvm.org/D74668?vs=261976=264273#toc Repository:

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 264266. cchen added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/AST/OpenMPClause.cpp

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

balazske added a comment. Created new revisions for parts of this change and a bit improved: D80009 and others in "Stack". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78374/new/ https://reviews.llvm.org/D78374

[clang] 072cde0 - [Clang][BPF] implement __builtin_btf_type_id() builtin function

Author: Yonghong Song Date: 2020-05-15T09:44:54-07:00 New Revision: 072cde03aaa13a2c57acf62d79876bf79aa1919f URL: https://github.com/llvm/llvm-project/commit/072cde03aaa13a2c57acf62d79876bf79aa1919f DIFF: https://github.com/llvm/llvm-project/commit/072cde03aaa13a2c57acf62d79876bf79aa1919f.diff

[PATCH] D80018: [Analyzer][StreamChecker] Added check for "indeterminate file position".

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. According to

[PATCH] D78508: [Clang] Allow long as size_t printf argument on 32-bit Windows platforms.

aaron.ballman added a comment. In D78508#2038793 , @amccarth wrote: > I'll re-iterate my opinion that the casts currently required to bypass the > warnings are useful (e.g., if you ever want to port the code to 64-bit). > There are lots of places where

[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

sepavloff marked an inline comment as done. sepavloff added inline comments. Comment at: llvm/test/CodeGen/RISCV/flt-rounds.ll:23 +; RV64I-NEXT:sd ra, 8(sp) +; RV64I-NEXT:call __flt_rounds +; RV64I-NEXT:ld ra, 8(sp) lenary wrote: > I'm interested to

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

sameerds added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:1261 + /// Currently only supports NVPTX and AMDGCN + static bool isOpenMPGPU(llvm::Triple ) { +return T.isNVPTX() || T.isAMDGCN(); How is "OpenMP-compatible GPU" defined? I

[PATCH] D78508: [Clang] Allow long as size_t printf argument on 32-bit Windows platforms.

amccarth added a comment. I'll re-iterate my opinion that the casts currently required to bypass the warnings are useful (e.g., if you ever want to port the code to 64-bit). There are lots of places where the Windows API essentially required uncomfortable conversions, and we can't paper over

[PATCH] D79465: [clang-format] Fix line lengths w/ comments in align

JakeMerdichAMD updated this revision to Diff 264259. JakeMerdichAMD added a comment. Add a comment explaining why checking IsInsideToken is needed here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79465/new/ https://reviews.llvm.org/D79465

[PATCH] D79895: Fix warning about using uninitialized variable as function const reference parameter

aeubanks added a comment. The summary of this change should be "add warning..." not "fix warning..." Could you add more detail into the commit description? About newly introduced diagnostic groups, etc. Also, I thought I saw tests in a previous revision but now they seem to be gone? CHANGES

[PATCH] D80016: [analyzer] StdLibraryFunctionsChecker: Add support to lookup types

martong created this revision. martong added reviewers: xazax.hun, NoQ, Szelethus, balazske. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. Herald added a

[PATCH] D80015: [Analyzer][StreamChecker] Added support for 'fread' and 'fwrite'.

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. Stream

  1   2   >