[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

2020-05-15 Thread Yonghong Song via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6b01b465388b: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id() (authored by yonghong-song). Changed prior to commit: https://reviews.llvm.org/D74572?vs=262140=264256#toc Repository:

[PATCH] D80014: Turn -Wmax-tokens off by default

2020-05-15 Thread Hans Wennborg via Phabricator via cfe-commits
hans created this revision. hans added a reviewer: thakis. Herald added a project: clang. On the one hand, one might interpret the use of the max-token pragmas or -fmax-tokens flag as an opt-in to the warning. However, in Chromium we've found it useful to only opt in selected build

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

2020-05-15 Thread Francois Ferrand via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4db94094b469: clang-format: support aligned nested conditionals formatting (authored by Typz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50078/new/

[PATCH] D80003: [clang][clang-scan-deps] Add a mode that can compute overhead in duplicated module builds (Patch series 3/3)

2020-05-15 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 264243. dang added a comment. Updating D80003 : [clang][clang-scan-deps] Add a mode that can compute overhead in duplicated module builds (Patch series 3/3) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

2020-05-15 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a subscriber: arsenm. mibintc added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefaultFPContractMode(LangOptions::FPM_Fast); Opts.HexagonQdsp6Compat = Args.hasArg(OPT_mqdsp6_compat);

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

2020-05-15 Thread Melanie Blower via Phabricator via cfe-commits
mibintc updated this revision to Diff 264241. mibintc marked an inline comment as done. mibintc added a comment. This is the same as the previous patch, except I removed the fix for pragma push-pop that John said should be committed separately Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

2020-05-15 Thread Melanie Blower via Phabricator via cfe-commits
mibintc marked an inline comment as done. mibintc added a subscriber: Anastasia. mibintc added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefaultFPContractMode(LangOptions::FPM_Fast);

[clang] 0ee04e6 - [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set

2020-05-15 Thread Francois Ferrand via cfe-commits
Author: Francois Ferrand Date: 2020-05-15T16:40:31+02:00 New Revision: 0ee04e6e0d0e1c808dc6c70ff7b92b35f960b627 URL: https://github.com/llvm/llvm-project/commit/0ee04e6e0d0e1c808dc6c70ff7b92b35f960b627 DIFF:

[clang] 4db9409 - clang-format: support aligned nested conditionals formatting

2020-05-15 Thread Francois Ferrand via cfe-commits
Author: Francois Ferrand Date: 2020-05-15T16:38:25+02:00 New Revision: 4db94094b469b4715d08ef37f1799bf3ea7ca8ea URL: https://github.com/llvm/llvm-project/commit/4db94094b469b4715d08ef37f1799bf3ea7ca8ea DIFF:

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

2020-05-15 Thread Tyker via Phabricator via cfe-commits
Tyker updated this revision to Diff 264238. Tyker added a comment. NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76420/new/ https://reviews.llvm.org/D76420 Files: clang/lib/AST/Expr.cpp clang/lib/AST/ExprConstant.cpp

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

2020-05-15 Thread Tyker via Phabricator via cfe-commits
Tyker updated this revision to Diff 264237. Tyker added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76420/new/ https://reviews.llvm.org/D76420 Files: clang/lib/AST/Expr.cpp clang/lib/AST/ExprConstant.cpp

[PATCH] D79990: [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions after a macro without semicolon

2020-05-15 Thread Andi via Phabricator via cfe-commits
Abpostelnicu added a comment. Please see https://firefox-source-docs.mozilla.org/code-quality/coding-style/format_cpp_code_with_clang-format.html CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79990/new/ https://reviews.llvm.org/D79990 ___

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

2020-05-15 Thread Tyker via Phabricator via cfe-commits
Tyker added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:6807-6808 +llvm::SaveAndRestore InConstantContext(Info.InConstantContext, true); return StmtVisitorTy::Visit(E->getSubExpr()); } rsmith wrote: > I don't think this is really

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

2020-05-15 Thread Francois Ferrand via Phabricator via cfe-commits
Typz updated this revision to Diff 264234. Typz added a comment. Fix random crash on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50078/new/ https://reviews.llvm.org/D50078 Files: clang/lib/Format/ContinuationIndenter.cpp

[PATCH] D79325: [clang-format] [PR42164] Add Option to Break before While

2020-05-15 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay updated this revision to Diff 264235. MyDeveloperDay added a comment. Use BeforeWhile and not IndentBraces to wrap the line Update the release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79325/new/ https://reviews.llvm.org/D79325 Files:

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

2020-05-15 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. In D79704#2038280 , @NoQ wrote: > In D79704#2038257 , @Szelethus wrote: > > > In D79704#2037100

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

2020-05-15 Thread Tyker via Phabricator via cfe-commits
Tyker updated this revision to Diff 264236. Tyker marked 12 inline comments as done. Tyker added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76420/new/ https://reviews.llvm.org/D76420 Files:

[PATCH] D79990: [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions after a macro without semicolon

2020-05-15 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay updated this revision to Diff 264231. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. Change to const & CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79990/new/ https://reviews.llvm.org/D79990 Files:

[PATCH] D78190: Add Bfloat IR type

2020-05-15 Thread Ties Stuij via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG8c24f33158d8: [IR][BFloat] Add BFloat IR type (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D80008: [clang-format] [PR45942] [[nodiscard]] causes && to be miss interpreted as BinaryOperators

2020-05-15 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, JakeMerdichAMD, mitchell-stellar, sylvestre.ledru, Abpostelnicu. MyDeveloperDay added projects: clang, clang-format. https://bugs.llvm.org/show_bug.cgi?id=45942 With Chromium style (although that is not important)

[PATCH] D80009: [Analyzer][StreamChecker] Changed representation of stream error state - NFC.

2020-05-15 Thread Balázs Kéri via Phabricator via cfe-commits
balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. State of error

[PATCH] D72530: Set traversal explicitly where needed in clang-tidy

2020-05-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. The changes here look reasonable, but can some of this code be simplified to use the default behavior and less complex matchers that don't have to carefully ignore implicit nodes? This would demonstrate that the feature really is an improvement over the status

[clang] 8c24f33 - [IR][BFloat] Add BFloat IR type

2020-05-15 Thread Ties Stuij via cfe-commits
Author: Ties Stuij Date: 2020-05-15T14:43:43+01:00 New Revision: 8c24f33158d81d5f4b0c5d27c2f07396f0f1484b URL: https://github.com/llvm/llvm-project/commit/8c24f33158d81d5f4b0c5d27c2f07396f0f1484b DIFF: https://github.com/llvm/llvm-project/commit/8c24f33158d81d5f4b0c5d27c2f07396f0f1484b.diff

[PATCH] D72534: Change default traversal in AST Matchers to ignore invisible nodes

2020-05-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some documentation nits. Comment at: clang/docs/ReleaseNotes.rst:255 + This means that many uses of the ``ignoringImplicit()`` and similar

[PATCH] D80003: [clang][clang-scan-deps] Add a mode that can compute overhead in duplicated module builds

2020-05-15 Thread Daniel Grumberg via Phabricator via cfe-commits
dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, tschuett, dexonsmith. Herald added a project: clang. Adds a command line option "--metrics" that computes and outputs this information at the end of a run. This identifies modules duplicated due

[PATCH] D79990: [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions after a macro without semicolon

2020-05-15 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:906 // trailing semicolons from other constructs split to several lines. -static bool tokenCanStartNewLine(const clang::Token ) { +static bool tokenCanStartNewLine(const FormatToken *Tok) {

[PATCH] D79000: [clang-format] C# property formatting can be controlled by config options

2020-05-15 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe closed this revision. jbcoe added a comment. Submitted as 8fa743ab82027da443bac050e86b70bcdb78cbee Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79000/new/

[PATCH] D72532: Make the ExprMutationAnalyzer explicit about how it traverses the AST

2020-05-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, assuming that this causes existing tests cover the changes so we don't need new tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79998: Add AST_SIGNATURE record to unhashed control block of pcm files (Patch series 2/3)

2020-05-15 Thread Daniel Grumberg via Phabricator via cfe-commits
dang added a comment. Should I add the test here or in the clang-scan-deps patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79998/new/ https://reviews.llvm.org/D79998 ___ cfe-commits mailing list

[clang] 8fa743a - [clang-format] C# property formatting can be controlled by config options

2020-05-15 Thread Jonathan Coe via cfe-commits
Author: Jonathan Coe Date: 2020-05-15T14:08:40+01:00 New Revision: 8fa743ab82027da443bac050e86b70bcdb78cbee URL: https://github.com/llvm/llvm-project/commit/8fa743ab82027da443bac050e86b70bcdb78cbee DIFF: https://github.com/llvm/llvm-project/commit/8fa743ab82027da443bac050e86b70bcdb78cbee.diff

[PATCH] D80001: [RFC/WIP][clang] Fix printing of names of inherited constructors

2020-05-15 Thread Pavel Labath via Phabricator via cfe-commits
labath created this revision. labath added reviewers: rsmith, dblaikie. Herald added a subscriber: aprantl. Herald added a project: clang. This is a fairly hacky fix to the following problem: Debug information entries for inherited constructors are emitted with the name of the base class, instead

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

2020-05-15 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/TestTU.h:1 //===--- TestTU.h - Scratch source files for testing -*- C++-*-===// // This header provides a widely used abstraction and has a clear scope, please don't

[PATCH] D79935: [clang-format] [PR44345] Long namespace closing comment is duplicated endlessly

2020-05-15 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added inline comments. Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:129 + // } // namespace + // // verylongnamespacenamethatdidnotfitonthepreviouscommenline + if (!(Comment->Next && Comment->Next->is(TT_LineComment))) Nit: typo

[PATCH] D72531: Set traversal explicitly where needed in tests

2020-05-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D72531#1845686 , @shafik wrote: > I was looking at the changes to `ASTImporterTest.cpp` and it not obvious to > me how you determined where it was needed. Some of the changes were reasonably obvious to me because they

[PATCH] D79998: Add AST_SIGNATURE record to unhashed control block of pcm files (Patch series 2/3)

2020-05-15 Thread Daniel Grumberg via Phabricator via cfe-commits
dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. This lets users of PCM get a clean hash of the AST for uniquing based on that. This required looking up implicit modules in the module offset map to be

[PATCH] D73037: Add a way to set traversal mode in clang-query

2020-05-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D73037#1839391 , @aaron.ballman wrote: > There should also be a mention of this in the release notes (especially if > the default behavior winds up changing). It looks like none of the comments in the review have not

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

2020-05-15 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D79704#2038257 , @Szelethus wrote: > In D79704#2037100 , @NoQ wrote: > > > > The code changes make me feel like we're doing a lot of chore (and make > > > it super easy to forget checking

[PATCH] D79325: [clang-format] [PR42164] Add Option to Break before While

2020-05-15 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay planned changes to this revision. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. let me try that.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79325/new/ https://reviews.llvm.org/D79325

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

2020-05-15 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 264205. kbobyrev added a comment. Simplify test setup and rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79862/new/ https://reviews.llvm.org/D79862 Files:

[PATCH] D79990: [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions after a macro without semicolon

2020-05-15 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. In D79990#2038207 , @Abpostelnicu wrote: > @MyDeveloperDay thanks for the patch, I'm gonna run it agains mozilla to see > if there is any fallout. I wonder is there a documented way to run clang-format over the gekco

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

2020-05-15 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Alright, I'm up to speed I think, cheers! In D79704#2037100 , @NoQ wrote: > > The code changes make me feel like we're doing a lot of chore (and make it > > super easy to forget checking for parameters explicitly). > > I

[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

2020-05-15 Thread Sam Elliott via Phabricator via cfe-commits
lenary added inline comments. Comment at: llvm/test/CodeGen/RISCV/flt-rounds.ll:23 +; RV64I-NEXT:sd ra, 8(sp) +; RV64I-NEXT:call __flt_rounds +; RV64I-NEXT:ld ra, 8(sp) I'm interested to understand how this function is provided. Is it part of

[PATCH] D79842: [clang][Driver] Correct tool search path priority

2020-05-15 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: clang/test/Driver/program-path-priority.c:72 +// -gcc has lowest priority +// RUN: default_triple=$(%t/clang --version | grep -oP "(?<=Target:\s).*") +// RUN: touch

[PATCH] D79993: Place control block after AST block in PCM files

2020-05-15 Thread Daniel Grumberg via Phabricator via cfe-commits
dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a reviewer: jdoerfert. Herald added a project: clang. dang edited the summary of this revision. This places the control block after the AST block in PCMs so that the AST

[PATCH] D79842: [clang][Driver] Correct tool search path priority

2020-05-15 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 264201. DavidSpickett added a comment. Added target triple as a substitution so the tests don't have to grep for it. (which I didn't manage to verify on Windows in any case) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

2020-05-15 Thread Pushpinder Singh via Phabricator via cfe-commits
pdhaliwal added a comment. I understand that `.git/logs/HEAD` acts as a dependency for `vcs_revision_h` target. However, problem here is that cmake fails when it tries to create `.git/logs/HEAD` in read-only filesystem. I had following ideas for solving above issue, 1. Skip creating

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

2020-05-15 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. Herald added a reviewer: MaskRay. @scott.linder is actually correct, the reason we write the file is precisely as he described in https://reviews.llvm.org/D79400#2021255. When you use tools like `repo` which branchless checkout, `.git/logs/HEAD` won't exist on initial

[clang] 1a3b801 - [analyzer] SATestBuild.py: Fix handling invalid plists after 2to3 conversion.

2020-05-15 Thread Artem Dergachev via cfe-commits
Author: Artem Dergachev Date: 2020-05-15T14:27:30+03:00 New Revision: 1a3b801db5afe98718b31ba9a760e06557daccb1 URL: https://github.com/llvm/llvm-project/commit/1a3b801db5afe98718b31ba9a760e06557daccb1 DIFF:

[clang-tools-extra] aef778d - [clang-tidy] Fix assertion in RenamerClangTidyChecks

2020-05-15 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-05-15T12:15:35+01:00 New Revision: aef778d4d38e45fd413e7e95919fbb72cde42488 URL: https://github.com/llvm/llvm-project/commit/aef778d4d38e45fd413e7e95919fbb72cde42488 DIFF: https://github.com/llvm/llvm-project/commit/aef778d4d38e45fd413e7e95919fbb72cde42488.diff

[PATCH] D79992: [WIP][clangd] Patch PP directives to use stale preambles while building ASTs

2020-05-15 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kadircet retitled this revision from "[clangd] Patch PP directives to use stale preambles while

[PATCH] D79990: [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions after a macro without semicolon

2020-05-15 Thread Andi via Phabricator via cfe-commits
Abpostelnicu added a comment. @MyDeveloperDay thanks for the patch, I'm gonna run it agains mozilla to see if there is any fallout. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79990/new/ https://reviews.llvm.org/D79990 ___ cfe-commits

[PATCH] D79673: Allow 32-bit pointer extensions to be used without -fms-extensions

2020-05-15 Thread David Zarzycki via Phabricator via cfe-commits
davezarzycki abandoned this revision. davezarzycki added a comment. I'm going to abandon this change for now. The problem is that the MS extensions are not as pervasive through the language as I wanted. For example, I'd really like them to work on aggregate types. This would allow all of the

[PATCH] D79285: [clang-tidy] Add diagnostics level to YAML output

2020-05-15 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin added a comment. @alexfh and @gribozavr2 friendly ping could you please take a look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79285/new/ https://reviews.llvm.org/D79285 ___

[PATCH] D79693: [test][ARM][CMSE] Use clang_cc1 in arm_cmse.h tests

2020-05-15 Thread Momchil Velikov via Phabricator via cfe-commits
chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79693/new/ https://reviews.llvm.org/D79693

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

2020-05-15 Thread Saiyedul Islam via Phabricator via cfe-commits
saiislam updated this revision to Diff 264192. saiislam added a comment. Moved isGPU() from llvm's Triple.h to clang's TargetInfo. Renamed it to isOpenMPGPU() to represent target's compatibility with OpenMP offloading and reduce its scope. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D79990: [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions after a macro without semicolon

2020-05-15 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, JakeMerdichAMD, mitchell-stellar, owenpan, sylvestre.ledru. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay retitled this revision from "[clang-format] Incorrectly indents [[nodiscard]] attribute

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

2020-05-15 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. In D79330#2035850 , @balazske wrote: > I was looking at CERT ARR32-C > > "Ensure size arguments

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

2020-05-15 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 264190. kbobyrev marked an inline comment as done. kbobyrev added a comment. Herald added a subscriber: mgorny. Add tests for Protobuf (de)serialization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79842: [clang][Driver] Correct tool search path priority

2020-05-15 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 264187. DavidSpickett added a comment. Update from arc to hopefully run harbormaster builds again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79842/new/ https://reviews.llvm.org/D79842 Files:

[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

2020-05-15 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff updated this revision to Diff 264184. sepavloff added a comment. Updated patch - rebased, - corrected documentation, - fixed formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79322/new/ https://reviews.llvm.org/D79322 Files:

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

2020-05-15 Thread Whisperity via Phabricator via cfe-commits
whisperity added inline comments. Comment at: clang/test/Analysis/vla-overflow.c:8 + if (x == BIGINDEX) { +// We expect here that size_t is a 64 bit value. +// Size of this array should be the first to overflow. While it's generally true nowadays,

[PATCH] D79921: [OpenMP] Fix omp and clang pragmas

2020-05-15 Thread ISHIGURO, Hiroshi via Phabricator via cfe-commits
hishiguro added a comment. Thank you for your comments. I will check those comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79921/new/ https://reviews.llvm.org/D79921 ___ cfe-commits mailing

[PATCH] D78767: [Sema] Teach -Wcast-align to compute a more accurate alignment when the source expression has array subscript or pointer arithmetic operators

2020-05-15 Thread Akira Hatanaka via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG854f5f332af4: [Sema] Teach -Wcast-align to compute an accurate alignment using the alignment… (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78105: [CSInfo][ISEL] Call site info generation support for Mips

2020-05-15 Thread Djordje Todorovic via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG170ac4be3392: [CSInfo][ISEL] Call site info generation support for Mips (authored by djtodoro). Herald added subscribers: cfe-commits, jrtc27. Herald added a project: clang. Repository: rG LLVM Github

[clang] 170ac4b - [CSInfo][ISEL] Call site info generation support for Mips

2020-05-15 Thread Djordje Todorovic via cfe-commits
Author: Djordje Todorovic Date: 2020-05-15T10:13:15+02:00 New Revision: 170ac4be3392201d5f5e124e8a1b7d78de3f82c8 URL: https://github.com/llvm/llvm-project/commit/170ac4be3392201d5f5e124e8a1b7d78de3f82c8 DIFF:

[clang] 854f5f3 - [Sema] Teach -Wcast-align to compute an accurate alignment using the

2020-05-15 Thread Akira Hatanaka via cfe-commits
Author: Akira Hatanaka Date: 2020-05-15T00:59:03-07:00 New Revision: 854f5f332af4640d9425e9a94442629e4f5a3f98 URL: https://github.com/llvm/llvm-project/commit/854f5f332af4640d9425e9a94442629e4f5a3f98 DIFF:

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

2020-05-15 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. ping @tnorth are you planning on fixing this as its currently reverted. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 ___ cfe-commits

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

2020-05-15 Thread Yvan Roux via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0e4827aa4e4a: [ARM][MachineOutliner] Add Machine Outliner support for ARM. (authored by yroux). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76066/new/

[clang] 0e4827a - [ARM][MachineOutliner] Add Machine Outliner support for ARM.

2020-05-15 Thread Yvan Roux via cfe-commits
Author: Yvan Roux Date: 2020-05-15T08:44:23+02:00 New Revision: 0e4827aa4e4ae25813f66d3b872db67d93813009 URL: https://github.com/llvm/llvm-project/commit/0e4827aa4e4ae25813f66d3b872db67d93813009 DIFF: https://github.com/llvm/llvm-project/commit/0e4827aa4e4ae25813f66d3b872db67d93813009.diff

[PATCH] D78767: [Sema] Teach -Wcast-align to compute a more accurate alignment when the source expression has array subscript or pointer arithmetic operators

2020-05-15 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Sema/SemaChecking.cpp:13122 +if (Base->isVirtual()) { + BaseAlignment = Ctx.getTypeAlignInChars(Base->getType()); + Offset =

<    1   2