[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

sameerds added inline comments. Comment at: clang/lib/AST/Decl.cpp:3224 + // HIP does not have device-side standard library. printf and malloc are + // the only special cases that are supported by device-side runtime. This should say "OpenMP does not have

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

sameerds added inline comments. Comment at: clang/lib/AST/Decl.cpp:3227 + !(BuiltinID == Builtin::BIprintf || BuiltinID == Builtin::BImalloc)) +return 0; + sameerds wrote: > This needs a test. This still needs a test. One that shows that specific

[PATCH] D79770: [RISCV] Fix passing two floating-point values in complex separately by two GPRs on RV64

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ee479a760e0: [RISCV] Fix passing two floating-point values in complex separately by two GPRs… (authored by Jim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

saiislam updated this revision to Diff 264529. saiislam added a comment. Removed isOpenMPGPU() to avoid defining OpenMP compatibility of an architecture. Reverting back to explicitly checking NVPTX and AMDGCN architectures. Also, split handling of NVPTX's and AMDGCN's handling of getBuiltinID.

[clang] 7ee479a - [RISCV] Fix passing two floating-point values in complex separately by two GPRs on RV64

Author: Jim Lin Date: 2020-05-18T13:13:22+08:00 New Revision: 7ee479a760e0a4402b4eb7fb6168768a44f66945 URL: https://github.com/llvm/llvm-project/commit/7ee479a760e0a4402b4eb7fb6168768a44f66945 DIFF: https://github.com/llvm/llvm-project/commit/7ee479a760e0a4402b4eb7fb6168768a44f66945.diff LOG:

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/static-init.cpp:14 +// CHECK: @llvm.global_dtors = appending global [1 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 65535, void ()* @__sterm8000_clang_b2e4830f1c9d2d063e5ea946868f3bfd,

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

steven.zhang added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:272 .Default(false); Features["qpx"] = (CPU == "a2q"); Do we miss to define this macro ? ``` __POWER10_VECTOR__ ``` Comment at:

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

steven.zhang added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:272 .Default(false); Features["qpx"] = (CPU == "a2q"); steven.zhang wrote: > Do we miss to define this macro ? > ``` > __POWER10_VECTOR__ > ```

[PATCH] D77704: [gold] Add support for loading pass plugins

ddcc added a comment. ping, any feedback? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77704/new/ https://reviews.llvm.org/D77704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

NoQ added a comment. > It turns out that parameter regions are never created for functions without > `Decl` because of the first lines in > `CallEvent::getCalleeAnalysisDeclContext()`. Removing these lines is more or less the whole point of your work. CHANGES SINCE LAST ACTION

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/MemRegion.cpp:191 +const ParmVarDecl *ParamRegion::getDecl() const { + const Decl *D = getStackFrame()->getDecl(); + baloghadamsoftware wrote: > NoQ wrote: > > baloghadamsoftware wrote: > > >

[PATCH] D80054: [ASTMatchers] Added BinaryOperator hasOperands matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rG74bcb00e00f3: [ASTMatchers] Added BinaryOperator hasOperands matcher (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80054/new/

[PATCH] D79961: [PGO] Fix computation of fuction Hash

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CodeGenPGO.cpp:759 MD5.final(Result); using namespace llvm::support; return Result.low(); Can the using be deleted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79961: [PGO] Fix computation of fuction Hash

MaskRay added a comment. This patch is correct. A clarification of the description: > Previous implementation was incorrectly passing an integer, that got > converted to a pointer, to finalize the hash computation. Working (an `uint64_t`) was truncated to an `uint8_t`, converted to a

[clang] 74bcb00 - [ASTMatchers] Added BinaryOperator hasOperands matcher

Author: Nathan James Date: 2020-05-17T19:54:14+01:00 New Revision: 74bcb00e00f3ef971e4c584a124e99289f2ebf34 URL: https://github.com/llvm/llvm-project/commit/74bcb00e00f3ef971e4c584a124e99289f2ebf34 DIFF: https://github.com/llvm/llvm-project/commit/74bcb00e00f3ef971e4c584a124e99289f2ebf34.diff

[PATCH] D68115: Zero initialize padding in unions

jfb added a comment. In D68115#2040696 , @tschuett wrote: > As an outsider: In Swift, reading an uninitialized variable is a compile-time > error. Clang is not powerful enough to do this analysis. Aren't you really > looking for the Clang Intermediate

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

rjmccall added a comment. In D79744#2040434 , @jdoerfert wrote: > In D79744#2040380 , @rjmccall wrote: > > > In D79744#2040348 , @jdoerfert > > wrote: > > > > > Drive by, I

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:1555 + IndentExternBlockStyle IndentExternBlock; + /// A vector of prefixes ordered by the desired groups for Java imports. Something is not quie right here, this text

[PATCH] D68115: Zero initialize padding in unions

tschuett added a comment. As an outsider: In Swift, reading an uninitialized variable is a compile-time error. Clang is not powerful enough to do this analysis. Aren't you really looking for the Clang Intermediate Language (CIL) ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre marked 4 inline comments as done. tambre added a comment. Thanks for the reviews and design pointers, John! There are still a few tests failing, but I'd rather not dive in before the general approach is considered acceptable. Comment at:

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. Please clang-format the patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 264497. tambre marked an inline comment as not done. tambre added a comment. Semantic compatibility checking for C++ builtin redeclarations. Remove some now unnecessary logic from getBuiltinID(). Update more tests. 4 tests still failing. Repository: rG

[PATCH] D80054: [ASTMatchers] Added BinaryOperator hasOperands matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80054/new/ https://reviews.llvm.org/D80054

[PATCH] D72530: Set traversal explicitly where needed in clang-tidy

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D72530#2040521 , @steveire wrote: > In D72530#2038561 , @aaron.ballman > wrote: > > > The

[PATCH] D72531: Set traversal explicitly where needed in tests

aaron.ballman added inline comments. Comment at: clang/unittests/Tooling/StencilTest.cpp:63 ASTContext = AstUnit->getASTContext(); - auto Matches = ast_matchers::match(wrapMatcher(Matcher), Context); + auto Matches = ast_matchers::match( +

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. In D75791#2040558 , @MarcusJohnson91 wrote: > In D75791#2040532 , @MyDeveloperDay > wrote: > > > LGTM > > > So what's the next step? I've never committed to LLVM before. In my

[PATCH] D78491: Avoid relying on address space zero default parameter in llvm/IR

arichardson added a comment. In D78491#2040424 , @dylanmckay wrote: > I really like the idea behind this patch, but I suspect there is a better way > to go about it. > > The only drawbacks to upstreaming this patch as-is is the idea that because > it is

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

MyDeveloperDay updated this revision to Diff 264495. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80079/new/ https://reviews.llvm.org/D80079 Files: clang/include/clang/Format/Format.h clang/lib/Format/BreakableToken.cpp clang/lib/Format/ContinuationIndenter.cpp

[clang] ede6005 - [AVR] Explicitly set the address of the data section when invoking the linker

Author: Dylan McKay Date: 2020-05-18T02:24:51+12:00 New Revision: ede6005e7092ddae454e4d365d8adefeaec1f5e3 URL: https://github.com/llvm/llvm-project/commit/ede6005e7092ddae454e4d365d8adefeaec1f5e3 DIFF: https://github.com/llvm/llvm-project/commit/ede6005e7092ddae454e4d365d8adefeaec1f5e3.diff

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

MyDeveloperDay updated this revision to Diff 264492. MyDeveloperDay added a comment. Remove erroneous changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80079/new/ https://reviews.llvm.org/D80079 Files: clang/include/clang/Format/Format.h clang/lib/Format/BreakableToken.cpp

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 added a comment. In D75791#2040532 , @MyDeveloperDay wrote: > LGTM So what's the next step? I've never committed to LLVM before. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, JakeMerdichAMD, mitchell-stellar, klimek, owenpan, sammccall, curdeius. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay updated this revision to Diff 264485. MyDeveloperDay added a comment. Missed

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

MyDeveloperDay updated this revision to Diff 264485. MyDeveloperDay added a comment. Missed some cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80079/new/ https://reviews.llvm.org/D80079 Files: clang/include/clang/Format/Format.h clang/lib/Format/BreakableToken.cpp

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72531: Set traversal explicitly where needed in tests

steveire marked an inline comment as done. steveire added inline comments. Comment at: clang/unittests/Tooling/StencilTest.cpp:63 ASTContext = AstUnit->getASTContext(); - auto Matches = ast_matchers::match(wrapMatcher(Matcher), Context); + auto Matches =

[PATCH] D47521: [clang-format] Fix parsing lambdas with noexcept

MyDeveloperDay added a comment. This was addressed with D56909: [clang-format] Fix line parsing for noexcept lambdas can we please abandon Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47521/new/ https://reviews.llvm.org/D47521

[PATCH] D72530: Set traversal explicitly where needed in clang-tidy

steveire added a comment. In D72530#2038561 , @aaron.ballman wrote: > The changes here look reasonable, but can some of this code be simplified to > use the default behavior and less complex matchers that don't have to > carefully ignore implicit

[PATCH] D80031: [clang-format] [NFC] release note placed in the wrong location and other rst linting errors

MyDeveloperDay closed this revision. MyDeveloperDay added a comment. I missed the Differential Revision off the commit message https://reviews.llvm.org/rG49c9a68d7fc62aabdf4d625fcb2954555496772b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79465: [clang-format] Fix line lengths w/ comments in align

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79465/new/ https://reviews.llvm.org/D79465

[clang] 3841ed4 - [Driver] Render -T for Gnu.cpp

Author: Fangrui Song Date: 2020-05-16T23:54:31-07:00 New Revision: 3841ed4104ac32eae7305d07e4558ea607fa69f3 URL: https://github.com/llvm/llvm-project/commit/3841ed4104ac32eae7305d07e4558ea607fa69f3 DIFF: https://github.com/llvm/llvm-project/commit/3841ed4104ac32eae7305d07e4558ea607fa69f3.diff