[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. No, go ahead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79903/new/ https://reviews.llvm.org/D79903

[PATCH] D79617: Add cet.h for writing CET-enabled assembly code

xiangzhangllvm added a comment. Hello rsmith, first, very sorry for have committed this patch before your reply, I waited 10 days, I thought you have agreed it. I think the linux-ABI can be the specification of this head file. The context of this cet.h is according to the linux ABI about

[PATCH] D79617: Add cet.h for writing CET-enabled assembly code

hjl.tools added a comment. In D79617#2045552 , @rsmith wrote: > I would like a specification for this header to be added somewhere. We > shouldn't be implementing random things with no specification. (Suppose > someone claims that our `` is wrong in

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

fghanim added a comment. In D79675#2045405 , @jdoerfert wrote: > > Could you please list the other patches that are being held back by this > > one? I'd be interested to have a look at them. :) > > We need the target type support for D80222

[PATCH] D80263: [HeaderSearch] Fix processing #import-ed headers multiple times with modules enabled.

vsapsai created this revision. vsapsai added reviewers: rsmith, bruno, Bigcheese. Herald added subscribers: ributzka, dexonsmith, jkorous. Herald added a project: clang. HeaderSearch was marking requested HeaderFileInfo as Resolved only based on the presence of ExternalSource. As the result,

[PATCH] D79617: Add cet.h for writing CET-enabled assembly code

rsmith added a comment. I would like a specification for this header to be added somewhere. We shouldn't be implementing random things with no specification. (Suppose someone claims that our `` is wrong in some way. How would we know whether they're right?) Ideally, I'd also like this header

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

AbbasSabra updated this revision to Diff 265095. AbbasSabra added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80171/new/ https://reviews.llvm.org/D80171 Files: clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

jyu2 accepted this revision. jyu2 added a comment. This revision is now accepted and ready to land. LGTM. Please changed format for td file. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:247 + + def warn_slh_does_not_support_asm_goto : Warning< +

[PATCH] D78101: [analyzer][StackAddressEscape] Tie warnings to the diagnostic checkers rather then core.StackAddrEscapeBase

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a6ee4fefec0: [analyzer][StackAddressEscape] Tie warnings to the diagnostic checkers rather… (authored by Szelethus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

AbbasSabra requested review of this revision. AbbasSabra added a comment. What you both said makes sense. Now, reference parameters are escaped and value parameters are treated as the local variables. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5369 if (ES->hasExternalDefinitions(D) == ExternalASTSource::EK_Never) - DebugInfo->completeUnusedClass(cast(*D)); + DebugInfo->completeUnusedClass(*CRD); }

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 265093. nickdesaulniers added a comment. - add C++ `using` and `class` support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 Files:

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. `CXXRecordDecl` is a funny case, the AST looks like: |-CXXRecordDecl 0x5c661a8 col:7 class foo definition | |-DefinitionData pass_in_registers empty aggregate standard_layout trivially_copyable pod trivial literal has_constexpr_non_copy_ |

[clang] 3a6ee4f - [analyzer][StackAddressEscape] Tie warnings to the diagnostic checkers rather then core.StackAddrEscapeBase

Author: Kirstóf Umann Date: 2020-05-20T02:26:40+02:00 New Revision: 3a6ee4fefec0bc97a0340ddc33e7a8ffd4590ad5 URL: https://github.com/llvm/llvm-project/commit/3a6ee4fefec0bc97a0340ddc33e7a8ffd4590ad5 DIFF: https://github.com/llvm/llvm-project/commit/3a6ee4fefec0bc97a0340ddc33e7a8ffd4590ad5.diff

[PATCH] D75432: [analyzer][NFC][MallocChecker] Convert many parameters into CallEvent

This revision was automatically updated to reflect the committed changes. Closed by commit rG39dd7265: [analyzer][NFC][MallocChecker] Convert many parameters into CallEvent (authored by Szelethus). Herald added a subscriber: ASDenysPetrov. Changed prior to commit:

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

AbbasSabra updated this revision to Diff 265090. AbbasSabra added a comment. Fix code review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80171/new/ https://reviews.llvm.org/D80171 Files: clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

Bigcheese added inline comments. Comment at: clang/include/clang/Frontend/CompilerInvocation.h:156 /// \param [out] Res - The resulting invocation. + /// \param [in] CommandLineArgs - Array of argument strings, this should not + /// contain "-cc1". Is this

[clang] 392222d - [analyzer][NFC][MallocChecker] Convert many parameters into CallEvent

Author: Kristóf Umann Date: 2020-05-20T02:03:31+02:00 New Revision: 39dd72657244f13d7f99cc6a497cc78eba2e URL: https://github.com/llvm/llvm-project/commit/39dd72657244f13d7f99cc6a497cc78eba2e DIFF: https://github.com/llvm/llvm-project/commit/39dd72657244f13d7f99cc6a497cc78eba2e.diff

[PATCH] D76510: [analyzer] Change the default output type to PD_TEXT_MINIMAL in the frontend, error if an output loc is missing for PathDiagConsumers that need it

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe1a3a7e8c8b: [analyzer] Change the default output type to PD_TEXT_MINIMAL in the frontend… (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D76510?vs=251673=265087#toc

[clang] fe1a3a7 - [analyzer] Change the default output type to PD_TEXT_MINIMAL in the frontend, error if an output loc is missing for PathDiagConsumers that need it

Author: Kirstóf Umann Date: 2020-05-20T01:36:06+02:00 New Revision: fe1a3a7e8c8be33968b9a768666489823dabab10 URL: https://github.com/llvm/llvm-project/commit/fe1a3a7e8c8be33968b9a768666489823dabab10 DIFF: https://github.com/llvm/llvm-project/commit/fe1a3a7e8c8be33968b9a768666489823dabab10.diff

[PATCH] D76510: [analyzer] Change the default output type to PD_TEXT_MINIMAL in the frontend, error if an output loc is missing for PathDiagConsumers that need it

Szelethus added a comment. I'm committing this now as-is, if something breaks, I'll revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76510/new/ https://reviews.llvm.org/D76510 ___ cfe-commits

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

jdoerfert added a comment. > Could you please list the other patches that are being held back by this one? > I'd be interested to have a look at them. :) We need the target type support for D80222 , D79739 can go in but we need

[PATCH] D60620: [HIP] Support target id by --offload-arch

tra added inline comments. Comment at: clang/lib/Basic/HIP.cpp:16 +const llvm::SmallVector +getAllPossibleTargetIdFeatures(llvm::StringRef Device) { + llvm::SmallVector Ret; Nit: there's an unfortunate clash with already [[

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

zbrid added a comment. In D79743#2044676 , @jyu2 wrote: > This looks good to me. Could you also add a test to use this new DiagGroup > (-Wno-slh-asm-goto)? > > Thanks. > > Jennifer Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

zbrid updated this revision to Diff 265081. zbrid added a comment. Add test; Update command for existing test Also rename file to match warning flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79743/new/ https://reviews.llvm.org/D79743 Files:

[PATCH] D79998: Add AST_SIGNATURE record to unhashed control block of pcm files (Patch series 2/3)

Bigcheese added a comment. In D79998#2038430 , @dang wrote: > Should I add the test here or in the clang-scan-deps patch? It's best to have a test in every non-nfc patch. You should be able to test this with llvm-bcanalyzer. Repository: rG LLVM

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 265077. nickdesaulniers added a comment. - add support for structs, unions, and enums Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 Files:

[PATCH] D79967: Fix debug info for NoDebug attr

dblaikie added a comment. In D79967#2045196 , @vsk wrote: > @yaxunl thanks, this patch lgtm. > > @dblaikie I've kicked off a thread on cfe-dev about the topics you brought up > ("Design discussion re: DW_TAG_call_site support in clang") and cc'd you.

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. For C++, I'd imagine: class foo {}; using my_foo = foo; template struct baz { bar my_bar; }; but it seems that `g++` doesn't emit debug info the for the templated struct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

fghanim updated this revision to Diff 265071. fghanim marked 2 inline comments as done. fghanim added a comment. Addressing reviewer Comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79675/new/ https://reviews.llvm.org/D79675 Files:

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

fghanim marked 21 inline comments as done. fghanim added a comment. In D79675#2044809 , @jdoerfert wrote: > What's the status? Can we split the target specific types stuff if this may > take a while, other patches depend on that :) Could you please

[PATCH] D75431: [analyzer][NFC] Merge checkNewAllocator's paramaters into CXXAllocatorCall

This revision was automatically updated to reflect the committed changes. Closed by commit rGf2be30def37d: [analyzer][NFC] Merge checkNewAllocators paramaters into CXXAllocatorCall (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D75431?vs=254816=265075#toc

[PATCH] D77845: [analyzer][CallAndMessage][NFC] Change old callbacks to rely on CallEvent

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d0d2fefc0a1: analyzer][CallAndMessage][NFC] Change old callbacks to rely on CallEvent (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D77845?vs=256461=265074#toc

[PATCH] D55892: [OpenMP] 'close' map-type-modifier code generation

saghir closed this revision. saghir added a comment. Herald added subscribers: sstefan1, yaxunl. Support for 'close' map-type-modifier code generation in clang has been added by patch D65341 . This revision can be closed. Repository: rC Clang CHANGES SINCE

[PATCH] D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults

JakeMerdichAMD added a comment. +1 for this idea. It'd eventually be neat to also take all samples from the style guide of each project and test them, if there aren't licensing concerns. LGTM with an appropriate merge fix/CI passing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D79465: [clang-format] Fix line lengths w/ comments in align

JakeMerdichAMD added a comment. Hey @MyDeveloperDay, can I get your assistance committing this when you have the chance? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79465/new/ https://reviews.llvm.org/D79465

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4965 + DBuilder.retainType(Ty); +} Looks like I can just reuse CGDebugInfo::EmitExplicitCastType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f2be30d - [analyzer][NFC] Merge checkNewAllocator's paramaters into CXXAllocatorCall

Author: Kirstóf Umann Date: 2020-05-20T00:56:10+02:00 New Revision: f2be30def37d248a7666cfac3c922ca9db308c2a URL: https://github.com/llvm/llvm-project/commit/f2be30def37d248a7666cfac3c922ca9db308c2a DIFF: https://github.com/llvm/llvm-project/commit/f2be30def37d248a7666cfac3c922ca9db308c2a.diff

[clang] 3d0d2fe - analyzer][CallAndMessage][NFC] Change old callbacks to rely on CallEvent

Author: Kirstóf Umann Date: 2020-05-20T00:37:59+02:00 New Revision: 3d0d2fefc0a18f13e45a17be04a3da8d2b1299f8 URL: https://github.com/llvm/llvm-project/commit/3d0d2fefc0a18f13e45a17be04a3da8d2b1299f8 DIFF: https://github.com/llvm/llvm-project/commit/3d0d2fefc0a18f13e45a17be04a3da8d2b1299f8.diff

[PATCH] D80176: [clang-format][PR45816] Add AlignConsecutiveBitFields

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80176/new/ https://reviews.llvm.org/D80176 ___ cfe-commits mailing list

[PATCH] D78124: [analyzer][ObjCGenerics] Don't emit diagnostics under the name core.DynamicTypePropagation

This revision was automatically updated to reflect the committed changes. Closed by commit rG66224d309d08: [analyzer][ObjCGenerics] Dont emit diagnostics under the name core. (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D78124?vs=257375=265067#toc Repository:

[PATCH] D78123: [analyzer][NSOrCFError] Don't emit diagnostics under the name osx.NSOrCFErrorDerefChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rGb47d1baa535a: [analyzer][NSOrCFError] Dont emit diagnostics under the name osx. (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D78123?vs=257373=265066#toc Repository: rG

[PATCH] D80176: [clang-format][PR45816] Add AlignConsecutiveBitFields

JakeMerdichAMD added a comment. Can I get your assistance committing this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80176/new/ https://reviews.llvm.org/D80176 ___ cfe-commits mailing list

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. ah, right. I need to additionally handle structs, unions, enums. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 ___

[PATCH] D80166: [CGCall] Annotate reference parameters with "align" attribute.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/CodeGen/CGCall.cpp:2258 Attrs.addDereferenceableAttr(info.first.getQuantity()); -

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl added a comment. In D60620#1464633 , @tra wrote: > It looks like you are solving two problems here. > a) you want to create multiple device passes for the same GPU, but with > different options. > b) you may want to pass different compiler

[PATCH] D79967: Fix debug info for NoDebug attr

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. @yaxunl thanks, this patch lgtm. @dblaikie I've kicked off a thread on cfe-dev about the topics you brought up ("Design discussion re: DW_TAG_call_site support in clang") and cc'd you. CHANGES

[clang] 66224d3 - [analyzer][ObjCGenerics] Don't emit diagnostics under the name core.DynamicTypePropagation

Author: Kirstóf Umann Date: 2020-05-20T00:19:20+02:00 New Revision: 66224d309d08c048b3bea257ceafe4873ce166c6 URL: https://github.com/llvm/llvm-project/commit/66224d309d08c048b3bea257ceafe4873ce166c6 DIFF: https://github.com/llvm/llvm-project/commit/66224d309d08c048b3bea257ceafe4873ce166c6.diff

[clang] b47d1ba - [analyzer][NSOrCFError] Don't emit diagnostics under the name osx.NSOrCFErrorDerefChecker

Author: Kirstóf Umann Date: 2020-05-20T00:05:49+02:00 New Revision: b47d1baa535abe061e6a89341e91c8b885b5b80e URL: https://github.com/llvm/llvm-project/commit/b47d1baa535abe061e6a89341e91c8b885b5b80e DIFF: https://github.com/llvm/llvm-project/commit/b47d1baa535abe061e6a89341e91c8b885b5b80e.diff

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

dblaikie added a comment. Looks like this only implements support for typedefs, but the flag in GCC does more than that (as the flag name indicates - it's about unused types in general) - could you test this across some non-trivial code and see if it matches GCC's behavior (or, where it

[PATCH] D80251: [X86] Update some av512 shift intrinsics to use "unsigned int" parameter instead of int to match Intel documentaiton

craig.topper created this revision. craig.topper added reviewers: RKSimon, spatel. There are 65 that take a scalar shift amount. Intel documentation shows 60 of them taking unsigned int. There are 5 versions of srli_epi16 that use int, the 512-bit maskz and 128/256 mask/maskz. Fixes PR45931

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

zequanwu updated this revision to Diff 265046. zequanwu added a comment. Update test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80153/new/ https://reviews.llvm.org/D80153 Files: clang/lib/AST/MicrosoftMangle.cpp clang/test/CodeGenCXX/mangle-ms-cxx11.cpp

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

zequanwu updated this revision to Diff 265031. zequanwu added a comment. Remove check for context of `LambdaContextDecl`. Update test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80153/new/ https://reviews.llvm.org/D80153 Files: clang/lib/AST/MicrosoftMangle.cpp Index:

[PATCH] D80176: [clang-format][PR45816] Add AlignConsecutiveBitFields

JakeMerdichAMD updated this revision to Diff 265048. JakeMerdichAMD added a comment. Reformat with a newer clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80176/new/ https://reviews.llvm.org/D80176 Files:

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.cpp:72 + binaryOperator(hasOperatorName("=="), + hasEitherOperand(ignoringParenImpCasts(StringNpos)), +

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

NeHuang added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:339 if (!(ArchDefs & ArchDefinePwr9) && (ArchDefs & ArchDefinePpcgr) && llvm::find(FeaturesVec, "+float128") != FeaturesVec.end()) { I think we also need to check for

[clang] 47650dc - Revert "[clang-misexpect] Fixed typo which causes that --pgo-warn-misexpect option is not passed in the compiler invocation"

Author: Dávid Bolvanský Date: 2020-05-19T23:20:54+02:00 New Revision: 47650dcbeee215f48277ed8bea5f0e43cbf125fc URL: https://github.com/llvm/llvm-project/commit/47650dcbeee215f48277ed8bea5f0e43cbf125fc DIFF:

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl updated this revision to Diff 265025. yaxunl retitled this revision from "[HIP] Support -offloading-target-id" to "[HIP] Support target id by --offload-arch". yaxunl edited the summary of this revision. yaxunl added a comment. rebased the patch and revised by passing target id by

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers created this revision. nickdesaulniers added reviewers: echristo, dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes pr/11710. Signed-off-by: Nick Desaulniers Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80242 Files:

[PATCH] D64128: [CodeGen] Generate llvm.ptrmask instead of inttoptr(and(ptrtoint, C)) if possible.

fhahn abandoned this revision. fhahn added a comment. In D64128#1578916 , @fhahn wrote: > In D64128#1576391 , @rjmccall wrote: > > > I wouldn't favor adding something really obscure that was only useful for > >

[PATCH] D80237: [hip] Ensure pointer in struct argument has proper `addrspacecast`.

tra added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1339 + } + for (uint64_t i = 0, e = SrcATy->getNumElements(); i < e; ++i) { +Address EltPtr = CGF.Builder.CreateConstArrayGEP(Dest, i); Is there a limit on array size? We may

[PATCH] D80240: [OPENMP50]Initial codegen for 'affinity' clauses.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, sstefan1, guansong, yaxunl. Herald added projects: clang, LLVM. Added initial codegen for 'affinity' clauses on task directives. Emits next code: kmp_task_affinity_info_t affs[];

Re: [clang] 6d2b75e - [clang-misexpect] Fixed typo which causes that --pgo-warn-misexpect option is not passed in the compiler invocation

This seems to be missing a test On Wed, May 20, 2020 at 12:12 AM Dávid Bolvanský via cfe-commits wrote: > > > Author: Dávid Bolvanský > Date: 2020-05-19T23:12:08+02:00 > New Revision: 6d2b75e0887ee87e247756c4d51733616bb2f356 > > URL: >

Re: [clang] 6d2b75e - [clang-misexpect] Fixed typo which causes that --pgo-warn-misexpect option is not passed in the compiler invocation

This breaks check-clang: http://45.33.8.238/linux/18098/step_7.txt Please take a look, and revert if it takes a while to fix. On Tue, May 19, 2020 at 5:12 PM Dávid Bolvanský via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Dávid Bolvanský > Date: 2020-05-19T23:12:08+02:00 > New

[clang] 6d2b75e - [clang-misexpect] Fixed typo which causes that --pgo-warn-misexpect option is not passed in the compiler invocation

Author: Dávid Bolvanský Date: 2020-05-19T23:12:08+02:00 New Revision: 6d2b75e0887ee87e247756c4d51733616bb2f356 URL: https://github.com/llvm/llvm-project/commit/6d2b75e0887ee87e247756c4d51733616bb2f356 DIFF:

[PATCH] D80225: [Driver] Recognize -fuse-ld={bfd, gold, lld} but don't prepend "ld." or "ld64." for other values

MaskRay updated this revision to Diff 265026. MaskRay added a comment. Fix fuse-ld-windows.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80225/new/ https://reviews.llvm.org/D80225 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D80239: [libTooling] In Transformer, allow atomic changes to span multiple files.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added subscribers: jfb, mgrang. Herald added a project: clang. Currently, all changes returned by a single application of a rule must fit in one atomic change and therefore must apply to one file. However, there are

[PATCH] D80237: [hip] Ensure pointer in struct argument has proper `addrspacecast`.

hliao created this revision. hliao added reviewers: arsenm, tra, rjmccall, yaxunl. Herald added subscribers: cfe-commits, kerbowa, nhaehnle, wdng, jvesely. Herald added a project: clang. - In last https://reviews.llvm.org/D69826, generic pointers in struct/array types are also replaced with

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

ymandel added a comment. Looks good, just some nits! Comment at: clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.cpp:48 + Options.get("StringLikeClasses", DefaultStringLikeClasses)); + const std::string AbseilStringsMatchHeader( +

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

jcelerier added a comment. Also hit by this issue - a lot more people are certainly going to have it as this has started landing in Linux distros. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324

[PATCH] D75323: Support relative dest paths in headermap files

vsapsai added a comment. The issue with this change is that it claims to add functionality that exists already. I.e., the test is passing without the change. The confusing part might be that even if `DirectoryLookup::LookupFile` doesn't find a file for relative destination immediately, it

[PATCH] D78155: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in wrapper headers

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78155/new/ https://reviews.llvm.org/D78155 ___

[clang] 74ef6a1 - Fix X86_64 complex-returns for regcall.

Author: Erich Keane Date: 2020-05-19T13:21:15-07:00 New Revision: 74ef6a11478abe5f0f3f817640508f0cf5d8de0c URL: https://github.com/llvm/llvm-project/commit/74ef6a11478abe5f0f3f817640508f0cf5d8de0c DIFF: https://github.com/llvm/llvm-project/commit/74ef6a11478abe5f0f3f817640508f0cf5d8de0c.diff

[clang] 350dada - Give helpers internal linkage. NFC.

Author: Benjamin Kramer Date: 2020-05-19T22:16:37+02:00 New Revision: 350dadaa8ab3db34ff41d7291f43442c57719de3 URL: https://github.com/llvm/llvm-project/commit/350dadaa8ab3db34ff41d7291f43442c57719de3 DIFF:

[PATCH] D80213: [analyzer] Move StdCLibraryFunctionArgs to alpha.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe42e5e4d0fc0: [analyzer] Move apiModeling.StdCLibraryFunctionArgs to alpha. (authored by dergachev.a). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D80174: [WebAssembly] Implement i64x2.mul and remove i8x16.mul

This revision was automatically updated to reflect the committed changes. Closed by commit rG3181273be73a: [WebAssembly] Implement i64x2.mul and remove i8x16.mul (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80174/new/

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:950-952 // If the context of a closure type is an initializer for a class - // member (static or nonstatic), it is encoded in a qualified

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:950-952 // If the context of a closure type is an initializer for a class - // member (static or nonstatic), it is encoded in a qualified

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

jdoerfert added a comment. Herald added a subscriber: sstefan1. What's the status? Can we split the target specific types stuff if this may take a while, other patches depend on that :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79675/new/

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

stefanp added a comment. Most of my comments are related to the fact that we are now inserting P10 between P9 and Future and so a few things need to change for the Future code to sit on top of P10 now.

[PATCH] D80174: [WebAssembly] Implement i64x2.mul and remove i8x16.mul

tlively marked 2 inline comments as done. tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:690 defm "" : SIMDBinary; } aheejin wrote: > Can we delete this now then? No, it is still used down in MIN_S and

[PATCH] D78155: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in wrapper headers

jdoerfert added a comment. Herald added a subscriber: sstefan1. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78155/new/ https://reviews.llvm.org/D78155 ___ cfe-commits mailing list

[clang] e42e5e4 - [analyzer] Move apiModeling.StdCLibraryFunctionArgs to alpha.

Author: Artem Dergachev Date: 2020-05-19T23:05:49+03:00 New Revision: e42e5e4d0fc08fed673b453268606bc9fdf0a7d2 URL: https://github.com/llvm/llvm-project/commit/e42e5e4d0fc08fed673b453268606bc9fdf0a7d2 DIFF:

[clang] 3181273 - [WebAssembly] Implement i64x2.mul and remove i8x16.mul

Author: Thomas Lively Date: 2020-05-19T12:50:44-07:00 New Revision: 3181273be73ac798c3d5b9081dd53d87a31c91b3 URL: https://github.com/llvm/llvm-project/commit/3181273be73ac798c3d5b9081dd53d87a31c91b3 DIFF: https://github.com/llvm/llvm-project/commit/3181273be73ac798c3d5b9081dd53d87a31c91b3.diff

[PATCH] D80225: [Driver] Recognize -fuse-ld={bfd, gold, lld} but don't prepend "ld." or "ld64." for other values

MaskRay updated this revision to Diff 264995. MaskRay added a comment. Fix fuse-ld-windows.c (I don't have Windows (REQUIRES: system-windows), so I failed to catch the issue earlier) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80225/new/

[PATCH] D78760: Check a class doesn't have a dependent type before iterating over its base classes

ahatanak updated this revision to Diff 264992. ahatanak retitled this revision from "Check a class has a definition before iterating over its base classes" to "Check a class doesn't have a dependent type before iterating over its base classes". ahatanak edited the summary of this revision.

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.cpp:101-102 + +void StringFindStrContainsCheck::storeOptions( +ClangTidyOptions::OptionMap ) { + Options.store(Opts, "StringLikeClasses", I don't

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

MyDeveloperDay added a comment. https://bugs.llvm.org/show_bug.cgi?id=33896 shows an interesting use case (when using UseTab: Always) std::string CLogView::GetItemText(int item) const { return item == 1 ? "one" : item == 2 ? "two" : item == 3 ? "three" :

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:82 + + Finds s.find(...) == string::npos comparisons (for various string-like types) + and suggests replacing with absl::StrContains. Please use double back-ticks to

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

tdl-g added a comment. Thanks, all for the comments. I believe I've addressed all comments. Note that TransformerClangTidyCheck interacts awkwardly with StoreOptions; I have a FIXME to clean that up. Comment at:

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

tdl-g updated this revision to Diff 264986. tdl-g marked 16 inline comments as done. tdl-g added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80023/new/ https://reviews.llvm.org/D80023 Files:

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

jyu2 added a comment. This looks good to me. Could you also add a test to use this new DiagGroup (-Wno-slh-asm-goto)? Thanks. Jennifer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79743/new/ https://reviews.llvm.org/D79743

[PATCH] D80228: [clang-format] [PR33890] Add support for Microsoft C++/CLI non standard for each looping extension

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, JakeMerdichAMD, mitchell-stellar. MyDeveloperDay added projects: clang, clang-format. https://bugs.llvm.org/show_bug.cgi?id=33890 This revision allow the microsoft `for each( in ...` nonstandard C++ extension

[PATCH] D80172: Revert "Re-fix _lrotl/_lrotr to always take Long, no matter the platform."

Bigcheese added a comment. In D80172#2042946 , @rnk wrote: > I'd be fine going back to the behavior from before. > > > Without this behavior there is no intrinsic for 32 bit rotates on these > > platforms. > > Strictly speaking, there seems to be

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

zequanwu marked an inline comment as done. zequanwu added a comment. In D79895#2042992 , @xbolva00 wrote: > Can you provide some compile time data with warning enabled/disabled? I compiled the test case with warning enabled and disabled. Since it is

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

zequanwu updated this revision to Diff 264976. zequanwu marked 3 inline comments as done. zequanwu added a comment. Fix typo. Diagnose self-init warning if the self-init variable is used as const reference later. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79895/new/

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware updated this revision to Diff 264979. baloghadamsoftware added a comment. SVal explanation extended and tests added for it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79704/new/ https://reviews.llvm.org/D79704 Files:

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:1518 UsesMap uses; + UsesMap constRefUses; rsmith wrote: > zequanwu wrote: > > rnk wrote: > > > If possible, it would be nice to

[PATCH] D80166: [CGCall] Annotate reference parameters with "align" attribute.

efriedma marked 2 inline comments as done. efriedma added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2116 +if (PTy->isObjectType()) { + if (unsigned Alignment = getContext().getTypeAlignIfKnown(PTy)) +RetAttrs.addAlignmentAttr(

[PATCH] D80225: [Driver] Recognize -fuse-ld={bfd, gold, lld} but don't prepend "ld." or "ld64." for other values

MaskRay created this revision. MaskRay added reviewers: martell, rnk, sbc100, theraven. Herald added subscribers: cfe-commits, sunfish, aheejin. Herald added a project: clang. - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55470 added support for -fuse-ld=bfd to mean `ld.bfd` and -fuse-ld=gold

  1   2   3   >