[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang updated this revision to Diff 269408. LukeZhuang added a comment. **updated: 06/08/2020** (1) update llvm side test for intrinsic llvm.expect.with.probability, which mimics test for llvm.expect CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/

[PATCH] D81420: Fix size for _ExtInt types with builtins

rjmccall added a comment. Linking compiler-rt is something that should be automatically happening. It's possible that compiler-rt will have different maximum widths on different targets, though. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7939 "to a

[PATCH] D80462: Fix floating point math function attributes definition.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. This looks great, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D80462

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

rjmccall added inline comments. Comment at: clang/include/clang/Sema/Sema.h:4708 + /// conversion. + ExprResult tryConvertExprToTy(Expr *E, QualType Ty); + Please spell out "type" in the method name. Comment at:

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

efriedma added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:666 +FirstNonOverlappingEmptyFieldHandled + } FirstNonOverlappingEmptyFieldStatus; + Xiangling_L wrote: > efriedma wrote: > > Instead of specifically tracking whether you've

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

Tridacnid added a comment. Awesome. I don't have commit access, https://llvm.org/docs/Phabricator.html says I just need to ask here and someone will pick it up. Let me know if there's anything else I need to do. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L updated this revision to Diff 269396. Xiangling_L marked 2 inline comments as done. Xiangling_L added a comment. Simplify the code; Add one more testcase related to [[no_unique_addr]]; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:666 +FirstNonOverlappingEmptyFieldHandled + } FirstNonOverlappingEmptyFieldStatus; + efriedma wrote: > Instead of specifically tracking whether you've found an

[PATCH] D81444: Make the diagnostic-missing-prototypes put the suggested `static` in front of `const` if exists.

oontvoo created this revision. oontvoo added a reviewer: gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. Consider: `const int* get_foo() {return nullptr;}` The suggested fix should be `static const int* get_foo(){}` and not `const static int* get_foo(){}`

[PATCH] D57626: Disallow trivial_abi on a class if all copy and move constructors are deleted

rsmith added a comment. Herald added a subscriber: ributzka. Are you still interested in pursuing this? This change looks good to me if so. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57626/new/ https://reviews.llvm.org/D57626

[PATCH] D80462: Fix floating point math function attributes definition.

michele.scandale updated this revision to Diff 269387. michele.scandale added a comment. Store `CGF` in RAII object. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D80462 Files:

Re: [clang] 4e3d462 - Fix undefined behaviour when trying to deref nullptr.

Is this covered by existing tests? On Thu, Jun 4, 2020 at 2:52 PM Alexey Bataev via cfe-commits wrote: > > > Author: Alexey Bataev > Date: 2020-06-04T17:52:06-04:00 > New Revision: 4e3d4622b1e7bd419815510e5f7cd0f96595b2a3 > > URL: >

[PATCH] D80917: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 2

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:1333 +return GridValues[gv]; + } + I somehow believe `!GridValues` is the wrong way around. You should also initialize it directly to null so this makes more sense. The

[PATCH] D80944: Add begin source location for the attributed statement created from PragmaLoopHint decorated loop

ychen updated this revision to Diff 269380. ychen added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80944/new/ https://reviews.llvm.org/D80944 Files: clang/lib/Parse/ParsePragma.cpp clang/lib/Parse/ParseStmt.cpp

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

fhahn marked 9 inline comments as done. fhahn added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10789 +def err_builtin_matrix_scalar_constant_unsigned_expr_arg: Error< + "%0 argument must be a constant unsigned integer expression">; +

[PATCH] D80462: Fix floating point math function attributes definition.

michele.scandale updated this revision to Diff 269381. michele.scandale added a comment. Modify IR function attribute directly. RAII object modifies IR builder state and function attributes only if needed. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81439: [X86] Move CPUKind enum from clang to llvm/lib/Support. NFCI

craig.topper created this revision. craig.topper added reviewers: erichkeane, echristo, RKSimon, spatel, LuoYuanke. Herald added subscribers: hiraditya, mgorny. Herald added projects: clang, LLVM. Similar to what some other targets have done. This information could be reused by other frontends so

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

fhahn updated this revision to Diff 269378. fhahn marked 5 inline comments as done. fhahn added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Simplified code as suggested, check if matrix type extensions is enabled (and add test) and set align attribute for

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

efriedma added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11571 + Diag(Loc, + getLangOpts().C11 + ? diag::ext_typecheck_compare_complete_incomplete_pointers I think this condition is backwards? Should be

[PATCH] D81408: [builtins] Improve compatibility with 16 bit targets

efriedma added inline comments. Comment at: compiler-rt/lib/builtins/fp_lib.h:49 -static __inline int rep_clz(rep_t a) { return __builtin_clz(a); } +static __inline int rep_clz(rep_t a) { return clzsi(a); } MaskRay wrote: > atrosinenko wrote: > > MaskRay

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

zixuw added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:108 +def Undefined : DiagGroup<"undef">; +def UndefinedPrefix : DiagGroup<"undef-prefix", [Undefined]>; def UnsupportedNan : DiagGroup<"unsupported-nan">; arphaman wrote: >

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:15130 + +ElementTy.removeLocalConst(); +if (!ConstantMatrixType::isValidElementType(ElementTy)) { fhahn wrote: > rjmccall wrote: > > It's almost never correct to do "local"

[PATCH] D81408: [builtins] Improve compatibility with 16 bit targets

MaskRay added inline comments. Comment at: compiler-rt/lib/builtins/fp_lib.h:49 -static __inline int rep_clz(rep_t a) { return __builtin_clz(a); } +static __inline int rep_clz(rep_t a) { return clzsi(a); } atrosinenko wrote: > MaskRay wrote: > > Why is this

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

rjmccall added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10789 +def err_builtin_matrix_scalar_constant_unsigned_expr_arg: Error< + "%0 argument must be a constant unsigned integer expression">; + These are the same now.

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

arphaman added a comment. Can you still modify the state of `-Wundef` with `#pragma clang diagnostic`? Could you add a test to cover it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80751/new/ https://reviews.llvm.org/D80751

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

fhahn marked 12 inline comments as done. fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:15107 + { +ExprResult PtrConv = DefaultLvalueConversion(PtrExpr); +if (PtrConv.isInvalid()) rjmccall wrote: > You should be doing

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

arphaman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:108 +def Undefined : DiagGroup<"undef">; +def UndefinedPrefix : DiagGroup<"undef-prefix", [Undefined]>; def UnsupportedNan : DiagGroup<"unsupported-nan">; It seems like

[PATCH] D81432: Add #includes so that ROCm.h is compilable stand-alone.

jyknight added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81432/new/ https://reviews.llvm.org/D81432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D81390: [KernelAddressSanitizer] Make globals constructors compatible with kernel

nathanchance added a comment. I do not know enough about KASAN enough to review this patch but I can say that against mainline at https://git.kernel.org/linus/af7b4801030c07637840191c69eb666917e4135d, there appear to be no visible regressions with this version of the patch on top of

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

fhahn updated this revision to Diff 269363. fhahn added a comment. Updated to - use DefaultFunctionArrayLvalueConversion for pointer conversion, use getAs subsequently - return Context.DependentTy if any part of the result matrix type is still type-dependent - add assertion & todo for volatile

[PATCH] D81432: Add #includes so that ROCm.h is compilable stand-alone.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf07b3d41e739: Add #includes so that ROCm.h is compilable stand-alone. (authored by saugustine). Repository: rG LLVM

[PATCH] D81427: [hip] Fix device-only relocatable code compilation.

tra added a comment. LGTM in general, but I'll let Sam stamp it. Comment at: clang/lib/Driver/Driver.cpp:4594-4599 +if (!AtTopLevel && JA.getType() == types::TY_LLVM_BC && +(C.getArgs().hasArg(options::OPT_emit_llvm) || + (JA.getOffloadingDeviceKind() ==

[PATCH] D81432: Add #includes so that ROCm.h is compilable stand-alone.

saugustine added a comment. For post-commit review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81432/new/ https://reviews.llvm.org/D81432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D81432: Add #includes so that ROCm.h is compilable stand-alone.

saugustine created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. saugustine added reviewers: jyknight, echristo. saugustine added a comment. For post-commit review. ROCm.h had been getting the declarations for various data structures by being #included

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

rjmccall added a comment. Yeah, that's fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72778/new/ https://reviews.llvm.org/D72778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 56a8729 - Remove improper uses of DiagnosticErrorTrap and hasErrorOccurred.

Author: Richard Smith Date: 2020-06-08T14:19:57-07:00 New Revision: 56a872947acca7635ca969f39f50062f2f779af0 URL: https://github.com/llvm/llvm-project/commit/56a872947acca7635ca969f39f50062f2f779af0 DIFF: https://github.com/llvm/llvm-project/commit/56a872947acca7635ca969f39f50062f2f779af0.diff

[clang] f07b3d4 - Add #includes so that ROCm.h is compilable stand-alone.

Author: Sterling Augustine Date: 2020-06-08T14:16:30-07:00 New Revision: f07b3d41e73979e46f468dbaa27866bbb53c1ab6 URL: https://github.com/llvm/llvm-project/commit/f07b3d41e73979e46f468dbaa27866bbb53c1ab6 DIFF:

[PATCH] D78442: Create a warning flag for 'warn_conv_*_not_used'

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Sorry for the delay, LG. Comment at: clang/test/Misc/warning-flags.c:21 -CHECK: Warnings without flags (72): +CHECK: Warnings without flags (69): +

[PATCH] D81131: [DebugInfo] Fix assertion for extern void type

This revision was automatically updated to reflect the committed changes. Closed by commit rG3eb465a329e2: [DebugInfo] Fix assertion for extern void type (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81131/new/

[PATCH] D81420: Fix size for _ExtInt types with builtins

lebedev.ri added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:1747-1748 break; case Builtin::BI__builtin_add_overflow: case Builtin::BI__builtin_sub_overflow: case Builtin::BI__builtin_mul_overflow: I don't think this applies to

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

pratlucas created this revision. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. pratlucas added reviewers: chill, rjmccall, ostannard. pratlucas added a parent revision: D75169: [ARM] Enforcing calling convention for

[PATCH] D81427: [hip] Fix device-only relocatable code compilation.

hliao created this revision. hliao added reviewers: yaxunl, tra. Herald added a project: clang. Herald added a subscriber: cfe-commits. - In HIP, just as the regular device-only compilation, the device-only relocatable code compilation should not involve offload bundle. - In addition, that

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dexonsmith added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3647 + DiagnosticsEngine ) { +#define OPTION_WITH_MARSHALLING +#define OPTION_WITH_MARSHALLING_FLAG(PREFIX_TYPE, NAME, ID, KIND, GROUP, \

[PATCH] D78442: Create a warning flag for 'warn_conv_*_not_used'

rdwampler added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78442/new/ https://reviews.llvm.org/D78442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D81424: Driver: Accept multiple --config options if filenames are the same

tstellar created this revision. tstellar added reviewers: sepavloff, hfinkel. Herald added a project: clang. Herald added a subscriber: cfe-commits. We're trying to use the --config options to pass distro specific options for Fedora via the CFLAGS variable. However, some projects end up using

[PATCH] D80917: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 2

saiislam marked 7 inline comments as done. saiislam added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:202 + const unsigned *GridValues; + const uint64_t *LongGridValues; jdoerfert wrote: > I would recommend adding a descriptive

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

fhahn marked 2 inline comments as done. fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:15051 + + Expr *Arg = TheCall->getArg(0); + if (!Arg->getType()->isConstantMatrixType()) { rjmccall wrote: > fhahn wrote: > > rjmccall wrote: > > >

[PATCH] D81394: [clang-format] Brace breaking for C# lambdas

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81394/new/ https://reviews.llvm.org/D81394 ___ cfe-commits mailing list

[PATCH] D80804: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics

saiislam updated this revision to Diff 269327. saiislam added a comment. Atomic inc/dec operation width is now based on return type of the builtin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80804/new/ https://reviews.llvm.org/D80804 Files:

[PATCH] D75414: [clangd] Resolve driver symlinks, and look up unknown relative drivers in PATH.

sammccall added a comment. Sorry, got interrupted right after landing this. Thanks for the revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75414/new/ https://reviews.llvm.org/D75414 ___

[clang] 58f831d - More robust fix for crash on invalid range-based for statement.

Author: Richard Smith Date: 2020-06-08T13:11:23-07:00 New Revision: 58f831d2b3885bbbc2366045e46211c507fa5f8b URL: https://github.com/llvm/llvm-project/commit/58f831d2b3885bbbc2366045e46211c507fa5f8b DIFF: https://github.com/llvm/llvm-project/commit/58f831d2b3885bbbc2366045e46211c507fa5f8b.diff

[clang] a92ce3b - Revert "Reland D80966 [codeview] Put !heapallocsite on calls to operator new"

Author: Arthur Eubanks Date: 2020-06-08T12:49:41-07:00 New Revision: a92ce3b706d71a67913bca8445f7be9f3682f0c7 URL: https://github.com/llvm/llvm-project/commit/a92ce3b706d71a67913bca8445f7be9f3682f0c7 DIFF:

[PATCH] D77168: Add a flag to debug automatic variable initialization

This revision was automatically updated to reflect the committed changes. Closed by commit rG4db2b7024868: Add a flag to debug automatic variable initialization (authored by jcai19). Changed prior to commit: https://reviews.llvm.org/D77168?vs=269301=269324#toc Repository: rG LLVM Github

[PATCH] D81420: Fix size for _ExtInt types with builtins

erichkeane added a comment. So the idea of the SEMA check is right, but it ultimately isn't correct. Integers up to 128 can be called, as long as you use compiler-rt (--rtlib=compiler-rt), see https://godbolt.org/z/JDXZG_. However, 129 bits results in a crash in LLVM:

[PATCH] D81420: Fix size for _ExtInt types with builtins

erichkeane added a comment. Also, please file a bug (if you haven't already) about the >128 bit problem. We have a similar bug for normal division (https://bugs.llvm.org/show_bug.cgi?id=45649), but this needs one as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81420/new/

[PATCH] D81385: Fix libdl linking for libclang in standalone mode

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Thank you! mceier: https://reviews.llvm.org/D81385 LebedevRI: clang built successfully with that patch But consider waiting for @beanz Repository: rG LLVM Github Monorepo

[PATCH] D80804: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14553 +case AMDGPU::BI__builtin_amdgcn_atomic_inc32: + IntType = Int32Ty; + BuiltinAtomicOp = Intrinsic::amdgcn_atomic_inc; This should be implied by the return type of the

[PATCH] D81420: Fix size for _ExtInt types with builtins

jtmott-intel created this revision. jtmott-intel added reviewers: erichkeane, rjmccall. This patch addresses two issues. The first issue is use of the checked arithmetic builtins in combination with _ExtInt

[PATCH] D75414: [clangd] Resolve driver symlinks, and look up unknown relative drivers in PATH.

thakis added a comment. reverted in f25e3c2d0e8553e6640ca5e0d1933c0e9455bd71 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75414/new/ https://reviews.llvm.org/D75414

[PATCH] D80932: [SYCL] Make default address space a superset of OpenCL address spaces.

Anastasia added a comment. > @Anastasia, if we make this change specific to SYCL mode, will it address > your concerns? I can't answer this question for the reasons I have explained above. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80932/new/

[PATCH] D80917: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 2

saiislam updated this revision to Diff 269314. saiislam added a comment. 1. Renamed the GPU namespace as omp. 2. Added assert in getter functions. 3. Added comments. 4. Removed unnecassary parantheses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4db2b70 - Add a flag to debug automatic variable initialization

Author: Jian Cai Date: 2020-06-08T12:30:56-07:00 New Revision: 4db2b70248686b8ac0667237768008762a66bb06 URL: https://github.com/llvm/llvm-project/commit/4db2b70248686b8ac0667237768008762a66bb06 DIFF: https://github.com/llvm/llvm-project/commit/4db2b70248686b8ac0667237768008762a66bb06.diff

[clang-tools-extra] f25e3c2 - Revert "[clangd] Resolve driver symlinks, and look up unknown relative drivers in PATH."

Author: Nico Weber Date: 2020-06-08T15:20:16-04:00 New Revision: f25e3c2d0e8553e6640ca5e0d1933c0e9455bd71 URL: https://github.com/llvm/llvm-project/commit/f25e3c2d0e8553e6640ca5e0d1933c0e9455bd71 DIFF: https://github.com/llvm/llvm-project/commit/f25e3c2d0e8553e6640ca5e0d1933c0e9455bd71.diff

[PATCH] D81323: Move *San module passes later in the NPM pipeline

This revision was automatically updated to reflect the committed changes. Closed by commit rGc07339c6754e: Move *San module passes later in the NPM pipeline (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81323/new/

[clang] c07339c - Move *San module passes later in the NPM pipeline

Author: Arthur Eubanks Date: 2020-06-08T12:08:49-07:00 New Revision: c07339c6754e1faf4078d3c592c0ae28455503cd URL: https://github.com/llvm/llvm-project/commit/c07339c6754e1faf4078d3c592c0ae28455503cd DIFF:

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

rjmccall added a comment. `SubstTemplateTypeParmType` is a "sugar" type node, like a `typedef`, and code should generally be looking through it automatically by using `getAs` rather than `isa` / `dyn_cast`. Comment at: clang/lib/Sema/SemaChecking.cpp:15107 + { +

[PATCH] D77168: Add a flag to debug automatic variable initialization

jcai19 marked 2 inline comments as done. jcai19 added a comment. In D77168#2080296 , @jfb wrote: > Two minor corrections, looks good otherwise. Thank you for all the comments and help. I have fixed the issues. Repository: rG LLVM Github Monorepo

[PATCH] D81045: [MLIR] Modify HasParent trait to allow one of several op's as a parent

jurahul added inline comments. Comment at: llvm/include/llvm/Support/Casting.h:147 +template +LLVM_NODISCARD inline typename std::enable_if::type +isa(const Y ) { jpienaar wrote: > I'm worried that folks may not notice this change based on the change >

[PATCH] D77168: Add a flag to debug automatic variable initialization

jcai19 updated this revision to Diff 269301. jcai19 added a comment. Fix typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77168/new/ https://reviews.llvm.org/D77168 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D81178: [FPEnv] Initialization of C++ globals not strictfp aware

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:4348 + /// Query for the use of constrained floating point math + bool isStrictFP() { return Builder.getIsFPConstrained(); } + kpn wrote: > rjmccall wrote: > > How is this set that

[PATCH] D81408: [builtins] Improve compatibility with 16 bit targets

atrosinenko added inline comments. Comment at: compiler-rt/lib/builtins/fp_lib.h:49 -static __inline int rep_clz(rep_t a) { return __builtin_clz(a); } +static __inline int rep_clz(rep_t a) { return clzsi(a); } MaskRay wrote: > Why is this needed? First of

[PATCH] D81045: [MLIR] Modify HasParent trait to allow one of several op's as a parent

jpienaar added inline comments. Comment at: llvm/include/llvm/Support/Casting.h:147 +template +LLVM_NODISCARD inline typename std::enable_if::type +isa(const Y ) { I'm worried that folks may not notice this change based on the change description (e.g., the

[PATCH] D81131: [DebugInfo] Fix assertion for extern void type

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81131/new/ https://reviews.llvm.org/D81131

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM with the given testing suggestion. Comment at: clang/lib/Sema/SemaChecking.cpp:15051 + + Expr *Arg = TheCall->getArg(0); + if

[clang] 4615abc - Rename arg name in __clang_hip_math.h

Author: Yaxun (Sam) Liu Date: 2020-06-08T14:13:32-04:00 New Revision: 4615abc11f2fcbf7526f7c939f2a3f71d80f0d93 URL: https://github.com/llvm/llvm-project/commit/4615abc11f2fcbf7526f7c939f2a3f71d80f0d93 DIFF:

[PATCH] D81178: [FPEnv] Initialization of C++ globals not strictfp aware

kpn marked an inline comment as done. kpn added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:4348 + /// Query for the use of constrained floating point math + bool isStrictFP() { return Builder.getIsFPConstrained(); } + rjmccall wrote: >

[PATCH] D80944: Add begin source location for the attributed statement created from PragmaLoopHint decorated loop

jdenny marked an inline comment as done. jdenny added inline comments. Comment at: clang/test/AST/sourceranges.cpp:116 + void f() { +// CHECK: AttributedStmt {{.*}} +DO_PRAGMA (unroll(2)) ychen wrote: > jdenny wrote: > > Is there any reason not to

[PATCH] D77168: Add a flag to debug automatic variable initialization

jfb accepted this revision. jfb added a comment. This revision is now accepted and ready to land. Two minor corrections, looks good otherwise. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:491 +def err_drv_trivial_auto_var_init_stop_after_invalid_value :

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM once @aprantl is happy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81347/new/ https://reviews.llvm.org/D81347

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

Szelethus added a comment. > If there are multiple resource leak paths for the same stream, only one wil > be reported. What is the rationale behind this? Do all leaks from the same opening describe the same kind of error? Is this based on observations on a codebase? I'm not against it -- but

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

ributzka added inline comments. Comment at: clang/include/clang/Driver/Options.td:475 + Alias, + HelpText<"Aliased to '-Wundef-prefix=\"\"', enable warnings for undefined macros">; def Wwrite_strings : Flag<["-"], "Wwrite-strings">, Group, Flags<[CC1Option, HelpHidden]>;

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

aprantl added a comment. I was going to ask why make this change, but looking at the patch, it's pretty obvious :-) Comment at: clang/include/clang/Basic/Module.h:29 #include "llvm/ADT/iterator_range.h" +#include #include Can you move the code that

[PATCH] D80944: Add begin source location for the attributed statement created from PragmaLoopHint decorated loop

ychen added inline comments. Comment at: clang/test/AST/sourceranges.cpp:116 + void f() { +// CHECK: AttributedStmt {{.*}} +DO_PRAGMA (unroll(2)) jdenny wrote: > Is there any reason not to check for `LoopHintAttr` here and on the `_Pragma` > case

[PATCH] D80944: Add begin source location for the attributed statement created from PragmaLoopHint decorated loop

ychen updated this revision to Diff 269282. ychen marked 3 inline comments as done. ychen added a comment. - add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80944/new/ https://reviews.llvm.org/D80944 Files:

[PATCH] D80721: Updates to the 'CLion Integration' section in ClangFormat docs

This revision was automatically updated to reflect the committed changes. Closed by commit rG9982d48a92be: Updates to the CLion Integration section in ClangFormat docs (authored by ilya-biryukov). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ef65adb6f9d: [Sema][CodeComplete][ObjC] Dont include arrow/dot fixits (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/

[PATCH] D81404: [AArch64] Add clang command line support for -mharden-sls=

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. LGTM, inline comment could be done as a follow-up patch given that this is time-sensitive (recently published security vulnerability). Comment at:

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev added a comment. **Ping?** CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79477/new/ https://reviews.llvm.org/D79477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman updated this revision to Diff 269271. dgoldman added a comment. - Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files: clang/lib/Sema/SemaCodeComplete.cpp

[PATCH] D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs

hyd-dev added a comment. **Ping?** CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80360/new/ https://reviews.llvm.org/D80360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman updated this revision to Diff 269269. dgoldman marked an inline comment as done. dgoldman added a comment. - Minor comment fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files:

[PATCH] D81408: [builtins] Improve compatibility with 16 bit targets

MaskRay added inline comments. Comment at: compiler-rt/lib/builtins/fp_lib.h:49 -static __inline int rep_clz(rep_t a) { return __builtin_clz(a); } +static __inline int rep_clz(rep_t a) { return clzsi(a); } Why is this needed? Repository: rG LLVM Github

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5199 + // Objective-C property reference. Bail if we're performing fix-it code + // completion since we don't handle forwarding the fix-it for Objective-C + // objects. Since

[clang] 2ef65ad - [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

Author: David Goldman Date: 2020-06-08T12:46:00-04:00 New Revision: 2ef65adb6f9dbebdd250dc6210e813711fb478d9 URL: https://github.com/llvm/llvm-project/commit/2ef65adb6f9dbebdd250dc6210e813711fb478d9 DIFF: https://github.com/llvm/llvm-project/commit/2ef65adb6f9dbebdd250dc6210e813711fb478d9.diff

[clang-tools-extra] d267217 - [clangd] Drop unnecessary FS modifications in FindSymbolsTests

Author: Kadir Cetinkaya Date: 2020-06-08T18:36:18+02:00 New Revision: d26721776ff08e0ecdd73b8851c44032d7c0a366 URL: https://github.com/llvm/llvm-project/commit/d26721776ff08e0ecdd73b8851c44032d7c0a366 DIFF:

[clang] fc935fc - Reland D80979 [clang] Implement VectorType logic not operator

Author: Fangrui Song Date: 2020-06-08T09:32:30-07:00 New Revision: fc935fc35bc2f76c4d1ec984a17e9db508a172de URL: https://github.com/llvm/llvm-project/commit/fc935fc35bc2f76c4d1ec984a17e9db508a172de DIFF: https://github.com/llvm/llvm-project/commit/fc935fc35bc2f76c4d1ec984a17e9db508a172de.diff

[clang] 9982d48 - Updates to the 'CLion Integration' section in ClangFormat docs

Author: Ilya Biryukov Date: 2020-06-08T19:27:25+03:00 New Revision: 9982d48a92beb35525c50890ae3a96ece3cf8de1 URL: https://github.com/llvm/llvm-project/commit/9982d48a92beb35525c50890ae3a96ece3cf8de1 DIFF: https://github.com/llvm/llvm-project/commit/9982d48a92beb35525c50890ae3a96ece3cf8de1.diff

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

njames93 added a comment. These test cases don't show it, from what i can see this will erroneously match: if (onFire) { tryPutFireOut(); } else { if (isHot && onFire) { scream(); } } It appears that this will change the second if to: if (isHot) { scream(); }

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b529e311a90: [ObjC] Fix AST serialization for pseudo-strong parameters (authored by dgoldman, committed by erik.pilkington). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   3   >