[PATCH] D81959: [HIP] Enable -amdgpu-internalize-symbols

arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:64-65 +"-shared", +"-mllvm", +"-amdgpu-internalize-symbols", +"-o", We should probably

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

clementval added a comment. In D81736#2096336 , @jdoerfert wrote: > In D81736#2095947 , @clementval > wrote: > > > In D81736#2093926 , @jdoerfert > > wrote: > > > > >

[clang] 237c2a2 - DR458: Search template parameter scopes in the right order.

Author: Richard Smith Date: 2020-06-16T19:41:14-07:00 New Revision: 237c2a23b6d4fa953f5ae910dccf492db61bb959 URL: https://github.com/llvm/llvm-project/commit/237c2a23b6d4fa953f5ae910dccf492db61bb959 DIFF: https://github.com/llvm/llvm-project/commit/237c2a23b6d4fa953f5ae910dccf492db61bb959.diff

[clang] 1b8125b - Don't assert if we find a dependently-typed variable in the

Author: Richard Smith Date: 2020-06-16T19:41:13-07:00 New Revision: 1b8125b041e28a315e5c5fe64441a2fb07a2f5ea URL: https://github.com/llvm/llvm-project/commit/1b8125b041e28a315e5c5fe64441a2fb07a2f5ea DIFF: https://github.com/llvm/llvm-project/commit/1b8125b041e28a315e5c5fe64441a2fb07a2f5ea.diff

[PATCH] D81478: [OPENMP50]Codegen for scan directives in parallel for regions.

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3627 + emitScanBasedDirective(CGF, S, NumIteratorsGen, FirstGen, SecondGen); +} else { + OMPCancelStackRAII CancelRegion(CGF, OMPD_parallel_for, S.hasCancel()); ABataev

[PATCH] D79411: [VE] Clang toolchain for VE

kaz7 added reviewers: hfinkel, b-sumner, jmolloy, kparzysz, majnemer, igorb. kaz7 added a comment. Add people who reviewed patches adding new target to clang. Sorry for bothering you guys, but I appreciate if you review our patch or give us suggestions how to get reviewed. Thanks in advance.

[PATCH] D81543: [CodeGen][TLS] Set TLS Model for __tls_guard as well.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a1776979fd8: [CodeGen][TLS] Set TLS Model for __tls_guard as well. (authored by junparser). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81543/new/

[PATCH] D81003: [clang] SequenceChecker: Also visit default arguments.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Seems reasonable. I think we need similar handling for `CXXDefaultInitExpr`, for cases like this: int a; struct X { int b = ++a; }; int c = X{} + a; Comment at:

[PATCH] D81330: [clang] SequenceChecker: C++17 sequencing rule for overloaded operators.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. It would be nice to avoid the duplication between the builtin and overloaded cases here, but I don't see a good way to do that. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 4a17769 - [CodeGen][TLS] Set TLS Model for __tls_guard as well.

Author: Jun Ma Date: 2020-06-17T08:31:13+08:00 New Revision: 4a1776979fd8e9473e433d7ec6f2bbf4bf9523ff URL: https://github.com/llvm/llvm-project/commit/4a1776979fd8e9473e433d7ec6f2bbf4bf9523ff DIFF: https://github.com/llvm/llvm-project/commit/4a1776979fd8e9473e433d7ec6f2bbf4bf9523ff.diff LOG:

[PATCH] D81966: [clang][module] Improve -Wincomplete-umbrella

zixuw abandoned this revision. zixuw added a comment. Abandoning this revision because the upstream for this work is not correctly tracking the llvm.org branch. The method `setGenModuleActionWrapper` is available in `apple/master` but not in llvm. Repository: rG LLVM Github Monorepo

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:4489 + // DestructCallBlock, otherwise jump to EndBlock directly. + CGF.EmitCXXGuardedInitBranch(NeedsDestruct, DestructCallBlock, EndBlock, +

[PATCH] D81868: [libTooling] Add parser for string representation of `RangeSelector`.

ymandel updated this revision to Diff 271246. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81868/new/ https://reviews.llvm.org/D81868 Files: clang/include/clang/Tooling/Transformer/Parsing.h

[PATCH] D81868: [libTooling] Add parser for string representation of `RangeSelector`.

ymandel marked 6 inline comments as done. ymandel added a comment. Thanks for the review! Comment at: clang/lib/Tooling/Transformer/Parsing.cpp:29 + +namespace { +using llvm::Error; gribozavr2 wrote: > I'm a bit concerned about the abundance of parsers in

[PATCH] D81970: [Clang][Driver] Remove gold linker support for PS4 toolchain

ychen updated this revision to Diff 271237. ychen added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81970/new/ https://reviews.llvm.org/D81970 Files: clang/lib/Driver/ToolChains/PS4CPU.cpp

[PATCH] D81959: [HIP] Enable -amdgpu-internalize-symbols

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81959/new/ https://reviews.llvm.org/D81959 ___ cfe-commits mailing list

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

DmitryPolukhin updated this revision to Diff 271232. DmitryPolukhin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 Files: clang/include/clang/Tooling/ReplacementsYaml.h

[PATCH] D80342: [SVE] Deprecate default false variant of VectorType::get

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb81c85afdcd: [SVE] Deprecate default false variant of VectorType::get (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80342/new/

[PATCH] D81972: [NFC] Cleanup of EmitCXXGlobalInitFunc() and EmitCXXGlobalDtorFunc()

jasonliu added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:596 } + // Include the filename in the symbol name. Including "sub_" matches gcc I think this patch is missing what @hubert.reinterpretcast mentioned in

[PATCH] D81975: [clangd] Add command line option for ClangTidyConfig

njames93 created this revision. njames93 added reviewers: sammccall, kadircet, hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Adds a command line flag `clang-tidy-config` for specifing configuration of checks,

[PATCH] D80944: Add begin source location for the attributed statement created from PragmaLoopHint decorated loop

ychen added a comment. In D80944#2095564 , @erichkeane wrote: > Note that this causes a regression (reported here) > https://bugs.llvm.org/show_bug.cgi?id=46336 > > The assert added here breaks in the case where a pragma loop attribute is > combined

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 271221. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D81949: [clang-tidy] Extend InheritParentConfig to CommandLineConfig

DmitryPolukhin accepted this revision. DmitryPolukhin added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81949/new/ https://reviews.llvm.org/D81949

[PATCH] D81970: [Clang][Driver] Remove gold linker support for PS4 toolchain

ychen updated this revision to Diff 271218. ychen added a comment. - update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81970/new/ https://reviews.llvm.org/D81970 Files: clang/lib/Driver/ToolChains/PS4CPU.cpp

[clang] eb81c85 - [SVE] Deprecate default false variant of VectorType::get

Author: Christopher Tetreault Date: 2020-06-16T15:16:11-07:00 New Revision: eb81c85afdcd3aa6d5e3c1ab73821a659630b799 URL: https://github.com/llvm/llvm-project/commit/eb81c85afdcd3aa6d5e3c1ab73821a659630b799 DIFF:

[PATCH] D80342: [SVE] Deprecate default false variant of VectorType::get

ctetreau updated this revision to Diff 271217. ctetreau added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. catch stragglers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80342/new/

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7927 + CurStrides.push_back(CurStride); + DI++; +} Use preincrement Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8243 +

[PATCH] D81972: [NFC] Cleanup of EmitCXXGlobalInitFunc() and EmitCXXGlobalDtorFunc()

Xiangling_L created this revision. Xiangling_L added reviewers: jasonliu, hubert.reinterpretcast. Herald added a project: clang. Herald added a subscriber: cfe-commits. Xiangling_L edited the summary of this revision. Tidy up some code of `EmitCXXGlobalInitFunc()` and `EmitCXXGlobalDtorFunc()`as

[PATCH] D80681: [clang][SourceManager] cache Macro Expansions

nickdesaulniers added a comment. > I've seen quite nice benchmarks for kernel build times in the issues you've > mentioned it would be nice if you could back that claim with similar data(not > that I don't take your word for it, I just love tables and I am jealous that > kernel has some but we

[PATCH] D81920: [clangd] Change FSProvider::getFileSystem to take CurrentWorkingDirectory

sammccall added a comment. Looks like an improvement but I don't like the `(".")` in various places. Maybe make the param optional and don't cd if it's none? I wouldn't give it a default arg though, the idea is to force a choice. Comment at:

[PATCH] D81970: [Clang][Driver] Remove gold linker support for PS4 toolchain

ychen created this revision. ychen added a reviewer: probinson. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81970 Files: clang/lib/Driver/ToolChains/PS4CPU.cpp clang/test/Driver/ps4-linker-non-win.c

[PATCH] D81967: [clang-tools-extra] Prevent linking to duplicate .a libs and dylib

mgorny added a comment. Herald added a subscriber: wuzish. For the record, this seems to trigger some command-line option parser problem: TEST 'Clang Tools :: clang-tidy/infrastructure/invalid-command-line.cpp' FAILED

[PATCH] D81967: [clang-tools-extra] Prevent linking to duplicate .a libs and dylib

mgorny created this revision. mgorny added reviewers: alexfh, hokein, sammccall, ilya-biryukov, kadircet, ioeric, bkramer, aaron.ballman, klimek, juliehockett. Herald added subscribers: sstefan1, phosek, usaxena95, lebedev.ri, arphaman, jkorous, kbarton, nemanjai. Herald added a reviewer:

[PATCH] D80712: [SVE] Add checks for no warnings in SVE tests

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80712/new/ https://reviews.llvm.org/D80712 ___ cfe-commits mailing list

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

hliao added a comment. In D81938#2096500 , @arsenm wrote: > I'm not entirely convinced this is safe in all contexts. I think you can > argue that this is safe if it directly feeds a memory instruction, as the > access would be undefined if it weren't

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

rjmccall added inline comments. Comment at: clang/include/clang/AST/Expr.h:2280 } + FPOptionsOverride getFPFeatures(const LangOptions ) const { +if (UnaryOperatorBits.HasFPFeatures) I would call this one getFPOptionOverrides or getOverriddenFPOptions.

[PATCH] D81672: [Driver] When forcing a crash call abort to get the correct diagnostic

aganea added inline comments. Comment at: clang/tools/driver/driver.cpp:518 + CRC.DumpStackAndCleanupOnFailure = true; + CRC.RunSafely([&]() { abort(); }); } The only concern I have is that a unrelated call stack will be printed. Could you

[PATCH] D81923: [clang-tidy] Add modernize-use-ranges check.

njames93 updated this revision to Diff 271191. njames93 marked 4 inline comments as done. njames93 added a comment. Tweaked documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81923/new/ https://reviews.llvm.org/D81923 Files:

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc updated this revision to Diff 271188. mibintc added a comment. This version passes all the lit tests, i believe it's functional tho' maybe not elegant. I still need to add a test case that PCH behaves as desired, and that the floating point command line options from PCH create do not

[PATCH] D81966: [clang][module] Improve -Wincomplete-umbrella

zixuw created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. zixuw added reviewers: arphaman, rsmith, bruno. Herald added a subscriber: dexonsmith. Change the warning message for `-Wincomplete-umbrella` to report the location of the umbrella header; Add a

[clang] 0f631bd - Revert "[OPENMP50]Codegen for scan directive in for simd regions."

Author: Alexey Bataev Date: 2020-06-16T17:01:59-04:00 New Revision: 0f631bd3bb6496fbca96a450719a9e99837de6c0 URL: https://github.com/llvm/llvm-project/commit/0f631bd3bb6496fbca96a450719a9e99837de6c0 DIFF: https://github.com/llvm/llvm-project/commit/0f631bd3bb6496fbca96a450719a9e99837de6c0.diff

Re: [PATCH] D81953: [clang-tidy] warnings-as-error no longer exits with ErrorCount

I didn’t have a specific use case in mind for it, so no preference either way. LGTM as well On Tue, Jun 16, 2020 at 1:05 PM Aaron Ballman via Phabricator < revi...@reviews.llvm.org> wrote: > aaron.ballman accepted this revision. > aaron.ballman added a comment. > This revision is now accepted

[PATCH] D81658: [OPENMP50]Codegen for scan directive in for simd regions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e78a3086a7f: [OPENMP50]Codegen for scan directive in for simd regions. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81658/new/

[PATCH] D81959: [HIP] Enable -amdgpu-internalize-symbols

yaxunl added a comment. In D81959#2096616 , @arsenm wrote: > Isn't the internalization implied by LTO? I thought part of the appeal of LTO > is killing this off How does LTO know that the kernels need to be kept? CHANGES SINCE LAST ACTION

[PATCH] D78903: [Driver] Add option -fproc-stat-report

aganea added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3782 + = Cmd.getProcessStatistics(); + if (ProcStat) { +if (PrintProcessStat) { In the case where `!ProcStat`, I am wondering if we shouldn't emit zero values, in the

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 271183. cchen added a comment. Fix Int64Ty issue (The bitNum of APInt I used before is 32) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files:

[PATCH] D81953: [clang-tidy] warnings-as-error no longer exits with ErrorCount

njames93 added a comment. In D81953#2096388 , @aaron.ballman wrote: > LGTM unless @jroelofs has a reason why the code was originally written that > way, but can you add test coverage for it? How would you suggest I add test coverage for this, afaik

[clang] 6e78a30 - [OPENMP50]Codegen for scan directive in for simd regions.

Author: Alexey Bataev Date: 2020-06-16T16:13:27-04:00 New Revision: 6e78a3086a7f563cc55d2ba83a8697b3320857fb URL: https://github.com/llvm/llvm-project/commit/6e78a3086a7f563cc55d2ba83a8697b3320857fb DIFF: https://github.com/llvm/llvm-project/commit/6e78a3086a7f563cc55d2ba83a8697b3320857fb.diff

[PATCH] D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option

This revision was automatically updated to reflect the committed changes. Closed by commit rG37e72f47a41d: [PowerPC] Add -m[no-]power10-vector clang and llvm option (authored by saghir). Changed prior to commit: https://reviews.llvm.org/D80758?vs=268893=271179#toc Repository: rG LLVM Github

[PATCH] D81959: [HIP] Enable -amdgpu-internalize-symbols

arsenm added a comment. Isn't the internalization implied by LTO? I thought part of the appeal of LTO is killing this off CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81959/new/ https://reviews.llvm.org/D81959 ___ cfe-commits mailing

[PATCH] D81304: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

fpetrogalli updated this revision to Diff 271178. fpetrogalli marked 3 inline comments as done. fpetrogalli added a comment. Fix formatting issues, remove an unnecessary empty line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81304/new/

[PATCH] D81951: [OPENMP]Fix PR46347: several ordered directives in a single region.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3488e8c21cec: [OPENMP]Fix PR46347: several ordered directives in a single region. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81304: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

fpetrogalli added inline comments. Comment at: clang/include/clang/Basic/AArch64SVEACLETypes.def:44 #define SVE_VECTOR_TYPE(Name, MangledName, Id, SingletonId, NumEls, ElBits, \ -IsSigned, IsFP) \ +

[PATCH] D81964: [clangd] Make use of preamble bounds from the patch inside ReplayPreamble

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Clangd was using bounds from the stale preamble, which might result in crashes. For example:

[PATCH] D81718: [Analyzer][NFC] Add methods `getReturnObject()` and `getArgObject()` to `CallEvent`

NoQ requested changes to this revision. NoQ added a comment. This revision now requires changes to proceed. In D81718#2095965 , @baloghadamsoftware wrote: > Your test case unfortunately does not test what you want, because raw > pointers are not

[clang] 8d4a806 - Revert "remove gold linker"

Author: Yuanfang Chen Date: 2020-06-16T13:05:53-07:00 New Revision: 8d4a806ef0b988200111b7d99f792361bcd3f7d1 URL: https://github.com/llvm/llvm-project/commit/8d4a806ef0b988200111b7d99f792361bcd3f7d1 DIFF: https://github.com/llvm/llvm-project/commit/8d4a806ef0b988200111b7d99f792361bcd3f7d1.diff

[clang] 8c6c606 - [Clang] Add a "#pragma unroll" test case for correct error reporting

Author: Yuanfang Chen Date: 2020-06-16T13:03:32-07:00 New Revision: 8c6c606cdc72c3ddd55f382d91ef1afc3cb9f2a8 URL: https://github.com/llvm/llvm-project/commit/8c6c606cdc72c3ddd55f382d91ef1afc3cb9f2a8 DIFF: https://github.com/llvm/llvm-project/commit/8c6c606cdc72c3ddd55f382d91ef1afc3cb9f2a8.diff

[clang] 719c87e - remove gold linker

Author: Yuanfang Chen Date: 2020-06-16T13:03:31-07:00 New Revision: 719c87edc58018a0e9f3ee04305e081d4b582c2b URL: https://github.com/llvm/llvm-project/commit/719c87edc58018a0e9f3ee04305e081d4b582c2b DIFF: https://github.com/llvm/llvm-project/commit/719c87edc58018a0e9f3ee04305e081d4b582c2b.diff

[clang] 3488e8c - [OPENMP]Fix PR46347: several ordered directives in a single region.

Author: Alexey Bataev Date: 2020-06-16T15:53:14-04:00 New Revision: 3488e8c21cec8bac7dabd8f6b7c642dbace31d65 URL: https://github.com/llvm/llvm-project/commit/3488e8c21cec8bac7dabd8f6b7c642dbace31d65 DIFF: https://github.com/llvm/llvm-project/commit/3488e8c21cec8bac7dabd8f6b7c642dbace31d65.diff

[clang] 37e72f4 - [PowerPC] Add -m[no-]power10-vector clang and llvm option

Author: Ahsan Saghir Date: 2020-06-16T14:47:35-05:00 New Revision: 37e72f47a41d83bd2509798a304f2f30ae094488 URL: https://github.com/llvm/llvm-project/commit/37e72f47a41d83bd2509798a304f2f30ae094488 DIFF: https://github.com/llvm/llvm-project/commit/37e72f47a41d83bd2509798a304f2f30ae094488.diff

[PATCH] D81424: Driver: Accept multiple --config options if filenames are the same

This revision was automatically updated to reflect the committed changes. Closed by commit rGd970ab63e22e: Driver: Accept multiple --config options if filenames are the same (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81959: [HIP] Enable -amdgpu-internalize-symbols

yaxunl created this revision. yaxunl added reviewers: arsenm, rampitec, tra, ashi1. Herald added subscribers: t-tye, tpr, dstuttard, wdng, kzhuravl. Enable -amdgpu-internalize-symbols to eliminate unused functions and global variables for whole program to speed up compilation and improve

[PATCH] D81861: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/Driver/hip-toolchain-no-rdc.hip:164 +// LKONLY-NOT: llvm-link +// LKONLY-NOT: opt +// LKONLY-NOT: llc arsenm wrote: > yamauchi wrote: > > Hi, this test seems to fail

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:660 + /// When there are OverlappingEmptyFields existing in the aggregate, the + /// flag shows if the following first non-overlappingEmptyField has been + /// handled, if any.

[PATCH] D81330: [clang] SequenceChecker: C++17 sequencing rule for overloaded operators.

riccibruno added a comment. @rsmith Friendly ping on this patch and D81003 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81330/new/ https://reviews.llvm.org/D81330

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

arsenm added a comment. I'm not entirely convinced this is safe in all contexts. I think you can argue that this is safe if it directly feeds a memory instruction, as the access would be undefined if it weren't valid to do the no-op cast. However, I'm not sure if this is safe if used purely in

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

sammccall created this revision. sammccall added reviewers: adamcz, hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is designed for tweaking compile commands by specifying flags to add/remove in a

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

hliao added a comment. In D81938#2095982 , @tra wrote: > In D81938#2095869 , @hliao wrote: > > > In D81938#2095828 , @lebedev.ri > > wrote: > > > > > This should be two

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir updated this revision to Diff 271164. saghir added a comment. Updated comment for allowing __int128 for vector bool. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81816/new/ https://reviews.llvm.org/D81816 Files:

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

hliao updated this revision to Diff 271162. hliao added a comment. Fix constant expression handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81938/new/ https://reviews.llvm.org/D81938 Files:

[PATCH] D81672: [Driver] When forcing a crash call abort to get the correct diagnostic

john.brawn added reviewers: aganea, rnk. john.brawn added a comment. Added a couple of reviewers that have recently worked on CrashRecoveryContext. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81672/new/ https://reviews.llvm.org/D81672

[PATCH] D81951: [OPENMP]Fix PR46347: several ordered directives in a single region.

ABataev added a comment. In D81951#2096397 , @jdoerfert wrote: > LGTM, can you add the nested ordered + depend test case too, assuming we > don't have it. We have such tests in ordered_ast_print.cpp and ordered_codegen.cpp tests Repository: rG LLVM

[clang] d970ab6 - Driver: Accept multiple --config options if filenames are the same

Author: Tom Stellard Date: 2020-06-16T12:23:57-07:00 New Revision: d970ab63e22eb5918774953da6b99ac27e5832a0 URL: https://github.com/llvm/llvm-project/commit/d970ab63e22eb5918774953da6b99ac27e5832a0 DIFF: https://github.com/llvm/llvm-project/commit/d970ab63e22eb5918774953da6b99ac27e5832a0.diff

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:4489 + // DestructCallBlock, otherwise jump to EndBlock directly. + CGF.EmitCXXGuardedInitBranch(NeedsDestruct, DestructCallBlock, EndBlock, +

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L updated this revision to Diff 271156. Xiangling_L marked 35 inline comments as done. Xiangling_L added a comment. Renamed some functions; Add one more test; etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/

[PATCH] D81951: [OPENMP]Fix PR46347: several ordered directives in a single region.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, can you add the nested ordered + depend test case too, assuming we don't have it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

aaron.ballman added a comment. In D75844#2076260 , @tbaeder wrote: > I'm looking at this again and I am not sure how it is meant to work. For > example in `Parser::parseClassSpecifier` in `ParseDeclCXX.cpp`. > Here `attrs` is a local variable of type

[PATCH] D81953: [clang-tidy] warnings-as-error no longer exits with ErrorCount

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM unless @jroelofs has a reason why the code was originally written that way, but can you add test coverage for it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

lei added inline comments. Comment at: clang/lib/Sema/DeclSpec.cpp:1170 // Only 'short' and 'long long' are valid with vector bool. (PIM 2.1) if ((TypeSpecWidth != TSW_unspecified) && (TypeSpecWidth != TSW_short) && Do we not need to add a check

[PATCH] D81478: [OPENMP50]Codegen for scan directives in parallel for regions.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3627 + emitScanBasedDirective(CGF, S, NumIteratorsGen, FirstGen, SecondGen); +} else { + OMPCancelStackRAII CancelRegion(CGF, OMPD_parallel_for,

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

lei added inline comments. Comment at: clang/lib/Sema/DeclSpec.cpp:1155 + // TODO: Update comment with correct Programming Interface Manual + // version once it is available. __int128 has also been added + // to vector bool for Power10. saghir

[PATCH] D81861: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

arsenm added inline comments. Comment at: clang/test/Driver/hip-toolchain-no-rdc.hip:164 +// LKONLY-NOT: llvm-link +// LKONLY-NOT: opt +// LKONLY-NOT: llc yamauchi wrote: > Hi, this test seems to fail for me because I happen to have the string "opt" > in the

[PATCH] D81641: [SYCL][OpenMP] Implement thread-local storage restriction

jdoerfert accepted this revision. jdoerfert added a comment. In D81641#2096114 , @Fznamznon wrote: > In D81641#2088446 , @jdoerfert wrote: > > > OpenMP has the same restriction (no surprise I guess). Thanks for the

[PATCH] D81881: [OPENMP]Fix overflow during counting the number of iterations.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. In D81881#2095509 , @ABataev wrote: > In D81881#2094062 , @jdoerfert wrote: > > > So the idea is to do

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

jdoerfert added a comment. In D81736#2095947 , @clementval wrote: > In D81736#2093926 , @jdoerfert wrote: > > > Assuming this passes all the tests, it looks good to me. Let's wait a day > > or two for people to

[PATCH] D81478: [OPENMP50]Codegen for scan directives in parallel for regions.

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3627 + emitScanBasedDirective(CGF, S, NumIteratorsGen, FirstGen, SecondGen); +} else { + OMPCancelStackRAII CancelRegion(CGF, OMPD_parallel_for, S.hasCancel()); This

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir updated this revision to Diff 271144. saghir added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81816/new/ https://reviews.llvm.org/D81816 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D81658: [OPENMP50]Codegen for scan directive in for simd regions.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Nice :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81658/new/ https://reviews.llvm.org/D81658

[PATCH] D81861: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

yamauchi added inline comments. Comment at: clang/test/Driver/hip-toolchain-no-rdc.hip:164 +// LKONLY-NOT: llvm-link +// LKONLY-NOT: opt +// LKONLY-NOT: llc Hi, this test seems to fail for me because I happen to have the string "opt" in the "InstallDir" file

[PATCH] D81868: [libTooling] Add parser for string representation of `RangeSelector`.

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Transformer/Parsing.h:1 +//===--- Parsing.h - Parsing library for Transformer -*- C++ -*-===// +// Please pad the first line to match the other line (throughout the patch).

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

lei added inline comments. Comment at: clang/test/Parser/altivec-bool-128.c:2 +// RUN: %clang_cc1 -triple=powerpc64-unknown-linux-gnu -target-feature +altivec -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple=powerpc64le-unknown-linux-gnu -target-feature +altivec

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang added a comment. @rsmith Hi, could you please take a look at my revision since last comment? Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 ___ cfe-commits mailing list

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-prefer-member-initializer-assignment.cpp:29 +public: + Simple2() : n (0) { +x = 0.0; baloghadamsoftware wrote: > aaron.ballman wrote: > > By my

[PATCH] D81953: [clang-tidy] warnings-as-error no longer exits with ErrorCount

lebedev.ri added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81953/new/ https://reviews.llvm.org/D81953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir updated this revision to Diff 271137. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81816/new/ https://reviews.llvm.org/D81816 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/DeclSpec.cpp

[PATCH] D81953: [clang-tidy] warnings-as-error no longer exits with ErrorCount

njames93 created this revision. njames93 added reviewers: alexfh, jroelofs, aaron.ballman. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. When using `-warnings-as-errors`, If there are any warnings promoted to errors, clang-tidy exits with the number of

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir marked 4 inline comments as done. saghir added inline comments. Comment at: clang/lib/Sema/DeclSpec.cpp:1155 + // TODO: Update comment with correct Programming Interface Manual + // version once it is available. __int128 has also been added + // to vector

[PATCH] D81837: [ARM][bfloat] Removing lowering of bfloat arguments and returns from Clang's CodeGen

chill added a comment. Pretty straightforward, LGTM. I'd suggest rewording the title (presumably commit message summary) into something like "Do not coerce bfloat arguments and returns to integers", as we're obviously still lowering C and C++ to LLVM LR.§§ Repository: rG LLVM Github

[PATCH] D81951: [OPENMP]Fix PR46347: several ordered directives in a single region.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: sstefan1, guansong, yaxunl. Herald added a project: clang. According to OpenMP, During execution of an iteration of a worksharing-loop or a loop nest within a worksharing-loop, simd, or worksharing-loop

[PATCH] D81451: [ARM][Clang] Removing lowering of half-precision FP arguments and returns from Clang's CodeGen

stuij added a comment. In D81451#2092997 , @pratlucas wrote: > Hi @stuij, > > The changes to the backend only handle the half (f16) type itself, not > vectors that have it as their base type. > > From what I've checked on the AAPCS, the rules for

  1   2   3   >