[PATCH] D82213: [Remarks] Add callsite locations to inline remarks

davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. lgtm Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:383 + const Function , const InlineCost , + bool

[PATCH] D81707: [PowerPC][Power10] Implement Vector Clear Left/Rightmost Bytes Builtins in LLVM/Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc95635b1bf2: [PowerPC][Power10] Implement Vector Clear Left/Rightmost Bytes Builtins in… (authored by amyk). Changed prior to commit: https://reviews.llvm.org/D81707?vs=270283=272281#toc Repository:

[clang] cc95635 - [PowerPC][Power10] Implement Vector Clear Left/Rightmost Bytes Builtins in LLVM/Clang

Author: Amy Kwan Date: 2020-06-20T18:29:16-05:00 New Revision: cc95635b1bf28e626b4c2ac296b0a0ca22ab3c91 URL: https://github.com/llvm/llvm-project/commit/cc95635b1bf28e626b4c2ac296b0a0ca22ab3c91 DIFF: https://github.com/llvm/llvm-project/commit/cc95635b1bf28e626b4c2ac296b0a0ca22ab3c91.diff

[PATCH] D82256: [analyzer] Enabling ctr in evalCall event

vrnithinkumar updated this revision to Diff 272275. vrnithinkumar marked an inline comment as done. vrnithinkumar added a comment. Addressing review comment adding miised new line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82256/new/

[PATCH] D82256: [analyzer] Enabling ctr in evalCall event

vrnithinkumar updated this revision to Diff 272276. vrnithinkumar marked an inline comment as done. vrnithinkumar added a comment. Fixing wrongly deleted the old commit via arc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82256/new/

[PATCH] D82256: [analyzer] Enabling ctr in evalCall event

vrnithinkumar marked 2 inline comments as done. vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:586 ExplodedNodeSet dstCallEvaluated; + EvalCallOptions CallOpts;

[clang] 0861889 - [clang/llvm] As part of using inclusive language within

Author: Eric Christopher Date: 2020-06-20T16:03:58-07:00 New Revision: 0861889be103bf7bcf013768e913695ed94b50bf URL: https://github.com/llvm/llvm-project/commit/0861889be103bf7bcf013768e913695ed94b50bf DIFF:

[clang-tools-extra] da6332f - [clang-tidy] As part of using inclusive language within

Author: Eric Christopher Date: 2020-06-20T15:20:11-07:00 New Revision: da6332f5f9f15f7b182f27bc9b8edbf709b48093 URL: https://github.com/llvm/llvm-project/commit/da6332f5f9f15f7b182f27bc9b8edbf709b48093 DIFF:

[clang-tools-extra] ef455a5 - Update comment to be more clear.

Author: Eric Christopher Date: 2020-06-20T14:44:41-07:00 New Revision: ef455a55bcf2cfea04a99c361b182ad18b7f03f1 URL: https://github.com/llvm/llvm-project/commit/ef455a55bcf2cfea04a99c361b182ad18b7f03f1 DIFF:

[PATCH] D82259: Deprecate error prone temporary directory APIs

lattner added a comment. Hi Dave, This is doing two things - changing the behavior of clang (where it stores its module cache) and deprecating an API. I'd recommend we start by focusing on whether the first part is the right thing to do, and just remove the API if this is the only client of

[PATCH] D82213: [Remarks] Add callsite locations to inline remarks

wenlei marked an inline comment as done. wenlei added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:392 +if (ProfileGuidedInline) + Remark << " by profile guided inliner"; +Remark << " with " << IC; davidxl wrote: > Perhaps reword

[PATCH] D82213: [Remarks] Add callsite locations to inline remarks

wenlei updated this revision to Diff 272263. wenlei added a comment. Update remark message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82213/new/ https://reviews.llvm.org/D82213 Files:

[PATCH] D82256: [analyzer] Enabling ctr in evalCall event

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Fantastic, thank you! Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:586 ExplodedNodeSet dstCallEvaluated; + EvalCallOptions CallOpts;

[PATCH] D82213: [Remarks] Add callsite locations to inline remarks

davidxl added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:392 +if (ProfileGuidedInline) + Remark << " by profile guided inliner"; +Remark << " with " << IC; Perhaps reword it to " to match profiling context" .. Repository:

[PATCH] D82259: Deprecate error prone temporary directory APIs

davezarzycki created this revision. davezarzycki added reviewers: compnerd, aprantl, jakehehrlich, espindola, respindola, ilya-biryukov, pcc, sammccall. davezarzycki added a project: LLVM. Herald added subscribers: cfe-commits, hiraditya. Herald added a project: clang. Naive usage of shared

[clang] 10563e1 - [Analysis/Transforms/Sanitizers] As part of using inclusive language

Author: Eric Christopher Date: 2020-06-20T00:42:26-07:00 New Revision: 10563e16aa2c432a883695ddd714da68751bbd77 URL: https://github.com/llvm/llvm-project/commit/10563e16aa2c432a883695ddd714da68751bbd77 DIFF:

[clang-tools-extra] 16897e4 - Update test file.

Author: Eric Christopher Date: 2020-06-19T23:13:28-07:00 New Revision: 16897e47baa2b7cd1f63f40f8355c372b841f83d URL: https://github.com/llvm/llvm-project/commit/16897e47baa2b7cd1f63f40f8355c372b841f83d DIFF:

[clang-tools-extra] 25ed42f - [clang-change-namespace] As part of using inclusive language

Author: Eric Christopher Date: 2020-06-19T23:01:42-07:00 New Revision: 25ed42f05d07d3ad85c58ee001752338211c911c URL: https://github.com/llvm/llvm-project/commit/25ed42f05d07d3ad85c58ee001752338211c911c DIFF:

Re: [PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white, black}list to -fsanitize-coverage-{allow,block}list

On Fri, Jun 19, 2020 at 10:43 PM Fangrui Song via Phabricator < revi...@reviews.llvm.org> wrote: > MaskRay added inline comments. > > > > Comment at: clang/docs/ClangCommandLineReference.rst:891 > > Restrict sanitizer coverage instrumentation exclusively to modules and >

[PATCH] D81408: [builtins] Improve compatibility with 16 bit targets

atrosinenko added a subscriber: goncharov. atrosinenko added a comment. In D81408#2104572 , @efriedma wrote: > > Those flaky test failures seems to be due to ld.lld being not built from > > source as part of testing compiler-rt/-only patches. > > That

[PATCH] D82256: [analyzer] Enabling ctr in evalCall event

vrnithinkumar marked an inline comment as done. vrnithinkumar added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h:100 +/// Hints for figuring out of a call should be inlined during evalCall(). +struct EvalCallOptions { + ///

[clang] f5bbe39 - [clang] SequenceChecker: C++17 sequencing rule for overloaded operators.

Author: Bruno Ricci Date: 2020-06-20T10:51:46+01:00 New Revision: f5bbe390d23d7da0ffb110cdb24b583c2dc87eba URL: https://github.com/llvm/llvm-project/commit/f5bbe390d23d7da0ffb110cdb24b583c2dc87eba DIFF: https://github.com/llvm/llvm-project/commit/f5bbe390d23d7da0ffb110cdb24b583c2dc87eba.diff

[clang-tools-extra] d313cb6 - Update redirected output file.

Author: Eric Christopher Date: 2020-06-19T23:30:16-07:00 New Revision: d313cb6e956de9448e4b979763ee8d12ce4103cb URL: https://github.com/llvm/llvm-project/commit/d313cb6e956de9448e4b979763ee8d12ce4103cb DIFF:

[clang] 1f593f4 - [AST/Lex/Parse/Sema] As part of using inclusive language within

Author: Eric Christopher Date: 2020-06-20T01:15:32-07:00 New Revision: 1f593f46f35b3afb1ba6e4700285cf8fd1b81bc7 URL: https://github.com/llvm/llvm-project/commit/1f593f46f35b3afb1ba6e4700285cf8fd1b81bc7 DIFF:

[PATCH] D82103: [analyzer] Remove forbidden characters from a SourceLocation filename for a graph dump on Windows

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Great, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82103/new/ https://reviews.llvm.org/D82103 ___ cfe-commits mailing list

[PATCH] D82256: Enabling ctr in evalCall event

vrnithinkumar created this revision. Herald added subscribers: cfe-commits, martong. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82256 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D82122: [analyzer][Liveness][RFC][NFC] Propose to turn statement liveness into expression liveness

Szelethus added a comment. Cheers! I'll leave this here for conversation's sake, and start working on refactoring LivenessAnalysis. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82122/new/ https://reviews.llvm.org/D82122

[PATCH] D81330: [clang] SequenceChecker: C++17 sequencing rule for overloaded operators.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5bbe390d23d: [clang] SequenceChecker: C++17 sequencing rule for overloaded operators. (authored by riccibruno). Changed prior to commit: https://reviews.llvm.org/D81330?vs=269012=272249#toc

[PATCH] D82122: [analyzer][Liveness][RFC][NFC] Propose to turn statement liveness into expression liveness

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/Environment.cpp:193 + +assert((isa(BlkExpr.getStmt()) || !IsBlkExprLive) && + "Only Exprs can be live, LivenessAnalysis argues about the liveness

[PATCH] D81678: Introduce frozen attribute at call sites for stricter poison analysis

aqjune accepted this revision. aqjune added a comment. This revision is now accepted and ready to land. For the LangRef part, LGTM modulo the suggested change. Could anyone review clang and LLVM's updated part? Comment at: llvm/docs/LangRef.rst:1644 +and return values.

[PATCH] D81678: Introduce frozen attribute at call sites for stricter poison analysis

guiand updated this revision to Diff 272213. guiand retitled this revision from "Introduce partialinit attribute at call sites for stricter poison analysis" to "Introduce frozen attribute at call sites for stricter poison analysis". guiand edited the summary of this revision. guiand added a

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a4317bfb319: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize… (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81678: Introduce frozen attribute at call sites for stricter poison analysis

eugenis added a comment. > Could you explicitly state that if it is aggregate or vector type all > elements and paddings should be frozen too? If an aggregate is passed as an aggregate at IR level, we should not care about the padding. Unless it's coerced to an integer. Repository: rG LLVM

[PATCH] D81678: Introduce partialinit attribute at call sites for stricter poison analysis

aqjune added a comment. In D81678#2099444 , @efriedma wrote: > So I guess we've discussed the following alternatives so far: > > (snip) > > Maybe (1) is the least-bad; all the others compromise by making LLVM harder > to understand. We can make porting

[clang-tools-extra] a146991 - Update error to read a little better when an error occurs.

Author: Eric Christopher Date: 2020-06-19T23:34:30-07:00 New Revision: a1469914fd7542526693b07a26a0bdcaa27591a3 URL: https://github.com/llvm/llvm-project/commit/a1469914fd7542526693b07a26a0bdcaa27591a3 DIFF:

[PATCH] D82213: [Remarks] Add callsite locations to inline remarks

wenlei updated this revision to Diff 272240. wenlei added a comment. Address David's comments, add test for nested inlinining. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82213/new/ https://reviews.llvm.org/D82213 Files: