[PATCH] D82767: clang-format: Explicitly use python3

compnerd added a comment. The thread that I was basing the timeline from is http://lists.llvm.org/pipermail/llvm-dev/2020-January/138730.html. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82767/new/ https://reviews.llvm.org/D82767 ___

[PATCH] D83079: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

fpetrogalli updated this revision to Diff 275283. fpetrogalli added a comment. Update the patch to limit its scope to generate the feature macros for `-march=armv8.6a+sve`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83079/new/

[PATCH] D83079: [clang] Default target features implied by `-march` on AArch64.

fpetrogalli marked an inline comment as done. fpetrogalli added a comment. In D83079#2129371 , @SjoerdMeijer wrote: > I haven't looked into details of these arch extensions yet, will do that > tomorrow, but I don't think there's any disagreement, i.e.,

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dexonsmith requested changes to this revision. dexonsmith added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:150 -static llvm::Optional normalizeSimpleEnum(OptSpecifier Opt, -

[PATCH] D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test

smeenai added a comment. Super late to the party here, sorry. I don't understand why the type of linking needs to be changed depending on if the library is static or shared. If a static library A depends on a static library B as PRIVATE, and then executable C links to A, CMake will make sure

[PATCH] D82694: [clang-shlib] Don't link with static clang libraries

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82694/new/ https://reviews.llvm.org/D82694

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb updated this revision to Diff 275266. jfb marked 18 inline comments as done. jfb added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 Files:

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

NoQ added a comment. This looks good at a glance to me! I only have minor nits left. It looks like we still need the option to be in place even though we moved the warnings into a separate checker, so that not to accidentally behave worse than with conservative modeling, but it becomes much

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:489 BUILTIN(__builtin_memcpy_inline, "vv*vC*Iz", "nt") +BUILTIN(__builtin_overloaded_memcpy, "v*v*vC*z", "nt") BUILTIN(__builtin_memmove, "v*v*vC*z", "nF") gchatelet wrote: >

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:179 +ArgStringList ) const { + // return if -nostdinc/-nostdlibinc is specified as a driver option. + if (DriverArgs.hasArg(options::OPT_nostdinc)

[PATCH] D80897: [OpenMP] Initial support for std::complex in target regions

jdoerfert added a comment. @JonChesterfield @hfinkel @tra ping I would really like to land this before the release branches off to allow people to use complex in target regions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80897/new/

[PATCH] D80897: [OpenMP] Initial support for std::complex in target regions

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. I think this change is good. The library story is a bit difficult, but fundamentally openmp needs a shim of some sort to map target math functions onto the libm of the

[PATCH] D82967: [analyzer][tests] Measure peak memory consumption for every project

NoQ accepted this revision. NoQ added inline comments. This revision is now accepted and ready to land. Comment at: clang/utils/analyzer/SATestUtils.py:113 +peak_mem = max(peak_mem, get_memory(process)) +time.sleep(.5) +

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

vrnithinkumar updated this revision to Diff 275254. vrnithinkumar added a comment. Addressing review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81315/new/ https://reviews.llvm.org/D81315 Files: clang/docs/analyzer/checkers.rst

[PATCH] D82999: [CodeGen] Check the cleanup flag before destructing lifetime-extended temporaries created in conditional expressions

ahatanak added a comment. And if the constructor call for `A` in the true expression throws, it's not necessary to call the destructor either since the object hasn't been constructed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82999/new/

[PATCH] D83074: [clang] Check ValueDependent instead of InstantiationDependent before executing the align expr for builtin align functions.

arichardson accepted this revision. arichardson added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/SemaCXX/builtin-align-cxx.cpp:40 template void test_incorrect_alignment_without_instatiation(T value) { Could also

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

vrnithinkumar marked 4 inline comments as done. vrnithinkumar added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:582 + "false", + InAlpha>, + ]>, Szelethus wrote: > Let's `Hide` this in

[PATCH] D82999: [CodeGen] Check the cleanup flag before destructing lifetime-extended temporaries created in conditional expressions

ahatanak added a comment. In test case `test13` in clang/test/CodeGenCXX/exceptions.cpp, I think you can turn `invoke void @_ZN6test131AC1Ev` into `call void @_ZN6test131AC1Ev`, no? If the false expression throws, there is nothing to clean up in the false expression and also nothing in the

[PATCH] D83076: Revert AST Matchers default to AsIs mode

steveire updated this revision to Diff 275248. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83076/new/ https://reviews.llvm.org/D83076 Files: clang-tools-extra/clang-query/Query.cpp

[PATCH] D83079: [clang] Default target features implied by `-march` on AArch64.

SjoerdMeijer added a comment. I haven't looked into details of these arch extensions yet, will do that tomorrow, but I don't think there's any disagreement, i.e., these options and their behaviour are synchronised with the GCC community. Thus, it's better if you remove this wording from both

[PATCH] D82774: [Power10] Implement Vector Blend Builtins in LLVM/Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rGca464639a1c9: [PowerPC] Implement Vector Blend Builtins in LLVM/Clang (authored by biplmish, committed by lei). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to

[PATCH] D83076: Revert AST Matchers default to AsIs mode

steveire updated this revision to Diff 275245. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83076/new/ https://reviews.llvm.org/D83076 Files: clang-tools-extra/clang-query/Query.cpp

[PATCH] D83099: Revert "[clangd] Store index in '.clangd/index' instead of '.clangd-index'"

sammccall created this revision. sammccall added reviewers: kadircet, hokein. Herald added subscribers: llvm-commits, cfe-commits, usaxena95, arphaman, omtcyfz, jkorous, MaskRay, ilya-biryukov. Herald added projects: clang, LLVM. This was well-intentioned, but it turns out `.clangd` is the best

[PATCH] D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

fghanim added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82822/new/ https://reviews.llvm.org/D82822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] ca46463 - [PowerPC] Implement Vector Blend Builtins in LLVM/Clang

Author: Biplob Mishra Date: 2020-07-02T16:52:52-05:00 New Revision: ca464639a1c9dd3944eb055ffd2796e8c2e7639f URL: https://github.com/llvm/llvm-project/commit/ca464639a1c9dd3944eb055ffd2796e8c2e7639f DIFF: https://github.com/llvm/llvm-project/commit/ca464639a1c9dd3944eb055ffd2796e8c2e7639f.diff

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

ABataev added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:1933 } +if (getLangOpts().OpenMP >= 50 && Tok.is(tok::colon)) { + // Consume ':' Seems to me, it is too broad. According to the standard, it must be allowed only

[PATCH] D83088: Introduce CfgTraits abstraction

nhaehnle created this revision. nhaehnle added reviewers: arsenm, RKSimon, mehdi_amini, courbet. Herald added subscribers: cfe-commits, msifontes, jurahul, Kayjukh, vkmr, grosul1, Joonsoo, stephenneuendorffer, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst,

[PATCH] D83095: [clangd] Config: compute config in TUScheduler and BackgroundIndex

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. sammccall added a parent revision: D82964: [clangd] Config: loading and caching config

[PATCH] D83079: [clang] Default target features implied by `-march` on AArch64.

sdesmalen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:118 + case llvm::AArch64::ArchKind::ARMV8_6A: +Features.push_back("+i8mm"); +Features.push_back("+bf16"); Looking at what Clang emits for e.g. `-march=armv8.5-a`,

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen updated this revision to Diff 275241. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82800/new/ https://reviews.llvm.org/D82800 Files: clang/include/clang-c/Index.h

[PATCH] D83087: DomTree: remove explicit use of DomTreeNodeBase::iterator

nhaehnle created this revision. nhaehnle added reviewers: arsenm, RKSimon, mehdi_amini, courbet. Herald added subscribers: cfe-commits, msifontes, jurahul, Kayjukh, vkmr, grosul1, Joonsoo, stephenneuendorffer, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst,

[PATCH] D83084: DomTree: Remove the releaseMemory() method

nhaehnle created this revision. nhaehnle added reviewers: arsenm, RKSimon, mehdi_amini, courbet. Herald added subscribers: cfe-commits, wdng. Herald added projects: clang, LLVM. nhaehnle added a parent revision: D83083: DomTree: Remove getChildren() accessor. nhaehnle added a child revision:

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

ShuhongL updated this revision to Diff 275221. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82677/new/ https://reviews.llvm.org/D82677 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolChains/AIX.h

[PATCH] D75740: [ASTImporter] Corrected import of repeated friend declarations.

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75740/new/ https://reviews.llvm.org/D75740

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

spatel added a comment. In D78478#2128631 , @xbolva00 wrote: > >> UTC_ARGS (I can't help associating it with Coordinated Universal Time). > > Me too. Any suggestions for new name? TCU_ARGS? I also reflexively think of universal time when reading "UTC".

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

ABataev added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:1928-1930 if (Tok.isNot(tok::r_square)) -Length = ParseExpression(); +if (getLangOpts().OpenMP < 50 || +((Tok.isNot(tok::colon) && getLangOpts().OpenMP >=

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

ShuhongL added a comment. Modified changes: 1. Add sysroot 2. return if `options::OPT_nostdlibinc` is specified, and will not add `/usr/local/include` to the path since it's different from other system (linux,darwin etc.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

ShuhongL updated this revision to Diff 275220. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82677/new/ https://reviews.llvm.org/D82677 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolChains/AIX.h

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

curdeius marked an inline comment as done. curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:13540 CHECK_PARSE_BOOL(AlignConsecutiveMacros); + CHECK_PARSE_BOOL(AlwaysBreakBeforeConceptDeclarations);

[PATCH] D82999: [CodeGen] Check the cleanup flag before destructing lifetime-extended temporaries created in conditional expressions

rjmccall added a comment. In D82999#2129031 , @ahatanak wrote: > After-full-expression cleanup looks fine to me. `pushCleanupAfterFullExpr` > sets the flags and saves the values when it's in a conditional branch. > > I think ideally we shouldn't have to

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay updated this revision to Diff 275213. MyDeveloperDay added a comment. Still a work in progress but covers I think the case @JohelEGP found. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79773/new/ https://reviews.llvm.org/D79773 Files:

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

avl added a comment. @efriedma What do you think about current state of this patch? Is it OK? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82085/new/ https://reviews.llvm.org/D82085 ___ cfe-commits

[PATCH] D82999: [CodeGen] Check the cleanup flag before destructing lifetime-extended temporaries created in conditional expressions

ahatanak added a comment. After-full-expression cleanup looks fine to me. `pushCleanupAfterFullExpr` sets the flags and saves the values when it's in a conditional branch. I think ideally we shouldn't have to clean up anything in the true expression when the false expression throws, but I

[PATCH] D83057: [OpenMP][NFC] Remove hard-coded line numbers from more tests

grokos accepted this revision. grokos added a comment. This revision is now accepted and ready to land. Like D82224 , looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83057/new/

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

jdoerfert added a comment. In D78478#2128926 , @arichardson wrote: > In D78478#2128604 , @MaskRay wrote: > > > The idea look good to me, but I want some opinions on the name `UTC_ARGS` > > (I can't help

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. See inline comments. Changes needed are: - test for eBroadcastBitSymbolsLoaded - add "version" to module info - test all data we expect in module info ('name', 'symbolFilePath',

[PATCH] D82869: [Power10] Implement Vector Permute Extended Builtins in LLVM/Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG286073484f7d: [PowerPC]Implement Vector Permute Extended Builtin (authored by biplmish, committed by lei). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen updated this revision to Diff 275196. cchen added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82800/new/ https://reviews.llvm.org/D82800 Files: clang/include/clang-c/Index.h clang/include/clang/AST/ExprOpenMP.h

[PATCH] D83079: [clang] Default target features implied by `-march` on AArch64.

fpetrogalli created this revision. fpetrogalli added reviewers: sdesmalen, efriedma, SjoerdMeijer. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. This patch is trying to align the interpretation of `-march` on AArch64 to what GCC has, in terms of

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

arichardson added a comment. In D78478#2128604 , @MaskRay wrote: > The idea look good to me, but I want some opinions on the name `UTC_ARGS` (I > can't help associating it with Coordinated Universal Time). Adding some folks > who may have opinions:

[PATCH] D83076: Revert AST Matchers default to AsIs mode

steveire created this revision. steveire added reviewers: aaron.ballman, klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. steveire added a reviewer: sammccall. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83076 Files:

[clang] 2860734 - [PowerPC]Implement Vector Permute Extended Builtin

Author: Biplob Mishra Date: 2020-07-02T14:53:18-05:00 New Revision: 286073484f7d36c8d0481be2a2f436f973389f54 URL: https://github.com/llvm/llvm-project/commit/286073484f7d36c8d0481be2a2f436f973389f54 DIFF: https://github.com/llvm/llvm-project/commit/286073484f7d36c8d0481be2a2f436f973389f54.diff

[PATCH] D83074: [clang] Check ValueDependent instead of InstantiationDependent before executing the align expr for builtin align functions.

hokein created this revision. hokein added a reviewer: arichardson. Herald added a project: clang. in general, value dependent is a subset of instnatiation dependent. This would allows us to produce diagnostics for the align expression (which is instantiation dependent but not value dependent).

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. This enables automatically parsing and generating CC1 arguments for options where two flags control the same field, e.g.

[PATCH] D82874: Add diagnostic option backing field for -fansi-escape-codes

dang updated this revision to Diff 275187. dang added a comment. Make the tablegen description of the new option more consistent with other flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82874/new/ https://reviews.llvm.org/D82874 Files:

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:172 +return; + + const Driver = getDriver(); daltenty wrote: > hubert.reinterpretcast wrote: > > Please investigate the handling of `OPT_nostdlibinc`. > If we are

[PATCH] D80225: [Driver] Recognize -fuse-ld={bfd, gold, lld} but don't prepend "ld." or "ld64." for other values

MaskRay abandoned this revision. MaskRay added a comment. Abandon in favor of D83015 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80225/new/ https://reviews.llvm.org/D80225

[clang] fcf4d5e - Revert "[clang][NFC] Store a pointer to the ASTContext in ASTDumper and TextNodeDumper"

Author: Bruno Ricci Date: 2020-07-02T19:40:09+01:00 New Revision: fcf4d5e4499a391dff42ea1a096f146db44147b6 URL: https://github.com/llvm/llvm-project/commit/fcf4d5e4499a391dff42ea1a096f146db44147b6 DIFF: https://github.com/llvm/llvm-project/commit/fcf4d5e4499a391dff42ea1a096f146db44147b6.diff

[clang] aa7fd90 - [clang][NFC] Store a pointer to the ASTContext in ASTDumper and TextNodeDumper

Author: Bruno Ricci Date: 2020-07-02T19:29:02+01:00 New Revision: aa7fd905e4e1bc510448431da9310e8cf5197523 URL: https://github.com/llvm/llvm-project/commit/aa7fd905e4e1bc510448431da9310e8cf5197523 DIFF: https://github.com/llvm/llvm-project/commit/aa7fd905e4e1bc510448431da9310e8cf5197523.diff

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

daltenty requested changes to this revision. daltenty added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:172 +return; + + const Driver = getDriver(); hubert.reinterpretcast wrote: > Please

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. ping @ABataev Have you checked the alternative scheme? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing

[PATCH] D82860: Port ObjCMTAction to new option parsing system

dang updated this revision to Diff 275171. dang added a comment. Ensure that `mergeForwardValue` can accept default values whose type doesn't quite match the associated keypath. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added a comment. In D76342#2128739 , @Meinersbur wrote: > ping > > @ABataev Have you checked the alternative scheme? Working on it, need a little bit more time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82964: [clangd] Config: loading and caching config from disk.

sammccall updated this revision to Diff 275165. sammccall added a comment. Try to get the tests to pass on windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82964/new/ https://reviews.llvm.org/D82964 Files:

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

Conanap marked an inline comment as done. Conanap added a comment. fixed a missing comma and ensure that it compiles Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82502/new/ https://reviews.llvm.org/D82502

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

Conanap updated this revision to Diff 275159. Conanap added a comment. Fixed a missing comma; ensured it builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82502/new/ https://reviews.llvm.org/D82502 Files: clang/lib/Headers/altivec.h

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

zequanwu updated this revision to Diff 275161. zequanwu added a comment. update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83013/new/ https://reviews.llvm.org/D83013 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

zequanwu updated this revision to Diff 275160. zequanwu marked 7 inline comments as done. zequanwu added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/test/Layout/aix-double-struct-member.cpp:1 +// RUN: %clang_cc1 -emit-llvm-only -triple powerpc-ibm-aix-xcoff \ +// RUN: -fdump-record-layouts -fsyntax-only %s 2>/dev/null | \ Xiangling_L wrote:

[PATCH] D82999: [CodeGen] Check the cleanup flag before destructing temporaries created in conditional expressions

rjmccall added a comment. Please adjust the commit message to be clear that this is about lifetime-extended temporaries; it's not like we got this wrong for all temporaries. Do we need to do anything to ensure that the after-full-expression cleanup is configured conditionally? Repository:

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

xbolva00 added a comment. >> UTC_ARGS (I can't help associating it with Coordinated Universal Time). Me too. Any suggestions for new name? TCU_ARGS? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78478/new/ https://reviews.llvm.org/D78478

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

jdenny created this revision. jdenny added reviewers: ABataev, jdoerfert, hfinkel, Meinersbur, kkwli0, grokos, sfantao, gtbercea. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a project: clang. jdenny added a parent revision: D83057: [OpenMP][NFC] Remove

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

MaskRay added subscribers: xbolva00, greened, spatel, lebedev.ri. MaskRay added a comment. The idea look good to me, but I want some opinions on the name `UTC_ARGS` (I can't help associating it with Coordinated Universal Time). Adding some folks who may have opinions: @greened @lebedev.ri

[PATCH] D75740: [ASTImporter] Corrected import of repeated friend declarations.

martong added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75740/new/ https://reviews.llvm.org/D75740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

lei added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.h:487 +/// Allows utilization of the Load VSX Vector Rightmost Instructions. +LXVRZX + missing `,`? Comment at:

[PATCH] D50229: [ARM][AArch64] Add feature +fp16fml

SjoerdMeijer marked an inline comment as done. SjoerdMeijer added inline comments. Comment at: test/Driver/aarch64-cpus.c:518 +// RUN: %clang -target aarch64 -march=armv8.4-a -### -c %s 2>&1 | FileCheck -check-prefix=GENERICV84A-NO-FP16FML %s +// GENERICV84A-NO-FP16FML-NOT:

[PATCH] D82659: Fix missing build dependency on omp_gen.

jdoerfert added a comment. Thank you both for figuring this out! *Much* appreciated! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82659/new/ https://reviews.llvm.org/D82659 ___ cfe-commits mailing

[PATCH] D83057: [OpenMP][NFC] Remove hard-coded line numbers from more tests

jdenny created this revision. jdenny added reviewers: ABataev, jdoerfert, hfinkel, grokos, sfantao, Hahnfeld. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a project: clang. This is a continuation of D82224 . Repository: rG

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Nice cleanup again! I think eventually we need to teach the common logic to recognize top-level entities, e.g., functions, and with these changes it will be accessible w/o duplication

[PATCH] D82964: [clangd] Config: loading and caching config from disk.

sammccall updated this revision to Diff 275146. sammccall marked 5 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82964/new/ https://reviews.llvm.org/D82964 Files:

[PATCH] D82964: [clangd] Config: loading and caching config from disk.

sammccall marked 15 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigProvider.cpp:39 +std::vector ) { +assert(llvm::sys::path::is_absolute(Path)); +auto FS = TFS.view(/*CWD=*/llvm::None);

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:179 + } + addSystemInclude(DriverArgs, CC1Args, "/usr/include"); +} This does not observe `--sysroot`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:172 +return; + + const Driver = getDriver(); Please investigate the handling of `OPT_nostdlibinc`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D83055: [clang][Driver] Fix tool path priority test failure

DavidSpickett updated this revision to Diff 275138. DavidSpickett added a comment. - Added check for alternate gcc names in the first test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/ https://reviews.llvm.org/D83055 Files:

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

chill added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:292-297 + auto checkFPDisabledInArchName = [](const StringRef ) { +SmallVector Split; +ArchName.split(Split, '+', -1, false); +return llvm::any_of( +Split, [](const StringRef )

[PATCH] D83055: [clang][Driver] Fix tool path priority test failure

DavidSpickett created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This test can fail when the path of the build includes the strings we're checking for. E.g "/gcc" is found in ".../gcc_7.3.0/..." To correct this look for '"' on the end of all matches. So

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM other than minor nit Comment at: clang/test/Driver/aix-toolchain-include.cpp:13 + +// Check powerpc-ibm-aix, 64-bit. +// RUN: %clangxx -### -no-canonical-prefixes

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

Conanap updated this revision to Diff 275124. Conanap marked 4 inline comments as done. Conanap added a comment. Fixed some formatting stuff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82502/new/ https://reviews.llvm.org/D82502 Files:

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L marked an inline comment as done. Xiangling_L added inline comments. Comment at: clang/test/Layout/aix-double-struct-member.cpp:1 +// RUN: %clang_cc1 -emit-llvm-only -triple powerpc-ibm-aix-xcoff \ +// RUN: -fdump-record-layouts -fsyntax-only %s 2>/dev/null | \

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

Conanap added a comment. Addressed Lei's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82502/new/ https://reviews.llvm.org/D82502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

avl updated this revision to Diff 275123. avl added a comment. rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82085/new/ https://reviews.llvm.org/D82085 Files: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp

[PATCH] D83053: [clang-tidy] OptionsView::store specialized on bool

njames93 marked an inline comment as done. njames93 added inline comments. Herald added a subscriber: wuzish. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp:31 Options.store(Opts, "GslHeader", GslHeader); -

[PATCH] D83048: [LiveDebugValues] 3/4 Add Xclang and CodeGen options for using instr-ref variable locations

djtodoro added a comment. Please add a test case for the Driver option (you can take a look into existing ones within `clang/test/Driver/`). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83048/new/ https://reviews.llvm.org/D83048

[PATCH] D83053: [clang-tidy] OptionsView::store specialized on bool

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added subscribers: cfe-commits, arphaman, kbarton, xazax.hun, nemanjai. Herald added a project: clang. njames93 marked an inline comment as done. njames93 added inline comments. Herald added a

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

Conanap marked 2 inline comments as done. Conanap added a comment. Addressed Anil's comments with regards to the test cases Comment at: llvm/test/CodeGen/PowerPC/p10-vsx-builtins.ll:56 + +; CHECK: lxvrdx +; Function Attrs: norecurse nounwind readonly anil9

[PATCH] D83006: [ASTImporter] Add unittest case for friend decl import

This revision was automatically updated to reflect the committed changes. Closed by commit rG59f1bf46f8c2: [ASTImporter] Add unittest case for friend decl import (authored by vabridgers, committed by einvbri vince.a.bridg...@ericsson.com). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

ShuhongL updated this revision to Diff 275111. ShuhongL marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82677/new/ https://reviews.llvm.org/D82677 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D83048: [LiveDebugValues] 3/4 Add Xclang and CodeGen options for using instr-ref variable locations

jmorse created this revision. jmorse added reviewers: aprantl, vsk, probinson, Orlando, StephenTozer, TWeaver, djtodoro. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. jmorse added a parent revision: D83047: [LiveDebugValues] 2/4 Add

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:1509 +TEST_F(SymbolCollectorTest, UndefOfModuleMacro) { + auto TU =

[PATCH] D81169: [clangd] Improve hover on arguments to function call

adamcz updated this revision to Diff 275104. adamcz marked an inline comment as done. adamcz added a comment. removed some more {} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81169/new/ https://reviews.llvm.org/D81169 Files:

  1   2   >