[PATCH] D83154: clang: Add -fcoverage-prefix-map

MaskRay added a comment. In D83154#2146085 , @phosek wrote: > In D83154#2134984 , @MaskRay wrote: > > > -fdebug-prefix-map does not make sense to me because coverage is not debug > > info. > > I am on the fence

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

yaxunl updated this revision to Diff 277272. yaxunl marked 3 inline comments as done. yaxunl added a comment. Only allow cuid to be alphanumeric and underscore. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80858/new/ https://reviews.llvm.org/D80858 Files:

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

yaxunl marked 9 inline comments as done. yaxunl added inline comments. Herald added a subscriber: dang. Comment at: clang/lib/AST/ASTContext.cpp:10068 +isa(D) && cast(D)->isFileVarDecl() && +cast(D)->getStorageClass() == SC_Static) { + return

[PATCH] D71124: [RISCV] support clang driver to select cpu

khchen added a comment. @asb @lenary I thought this path is ready to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71124/new/ https://reviews.llvm.org/D71124 ___ cfe-commits mailing list

[PATCH] D82930: [HIP] Fix rocm detection

thakis added a comment. Great, thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82930/new/ https://reviews.llvm.org/D82930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83154: clang: Add -fcoverage-prefix-map

phosek added a comment. Herald added a subscriber: dang. In D83154#2134984 , @MaskRay wrote: > -fdebug-prefix-map does not make sense to me because coverage is not debug > info. > I am on the fence whether we need -fcoverage-prefix-map. I created >

[PATCH] D82728: [clang] Add -Wsuggest-override

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. In D82728#2142071 , @logan-5 wrote: > Feels like a dumb question, but I'm not sure if and how those build failures > are related to this patch?

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

MaskRay added a subscriber: mehdi_amini. MaskRay added a comment. In D82477#2145967 , @clayborg wrote: > In D82477#2145565 , @MaskRay wrote: > > > Hi, your git commit contains extra Phabricator tags. You can drop

[clang] b8409c0 - Fix `-Wreturn-type` warning. NFC.

Author: Michael Liao Date: 2020-07-11T16:20:41-04:00 New Revision: b8409c03ed90807f3d49c7d98dceea98cf461f7a URL: https://github.com/llvm/llvm-project/commit/b8409c03ed90807f3d49c7d98dceea98cf461f7a DIFF: https://github.com/llvm/llvm-project/commit/b8409c03ed90807f3d49c7d98dceea98cf461f7a.diff

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

clayborg added a comment. In D82477#2145565 , @MaskRay wrote: > Hi, your git commit contains extra Phabricator tags. You can drop > `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git > commit with the following script: > >

[PATCH] D82930: [HIP] Fix rocm detection

yaxunl added a comment. In D82930#2145827 , @njames93 wrote: > This is causing a test case to fail on mac > http://45.33.8.238/mac/17048/step_7.txt 5d2c3e031a6861b3e95673d0e238c09938dd9c0d

[PATCH] D82930: [HIP] Fix rocm detection

yaxunl added a comment. In D82930#2145914 , @thakis wrote: > This breaks check-clang on macOS: http://45.33.8.238/mac/17053/step_7.txt > > The output contains > > 5: clang: warning: argument unused during compilation: >

[clang] 5d2c3e0 - Fix regression due to test hip-version.hip

Author: Yaxun (Sam) Liu Date: 2020-07-11T12:45:29-04:00 New Revision: 5d2c3e031a6861b3e95673d0e238c09938dd9c0d URL: https://github.com/llvm/llvm-project/commit/5d2c3e031a6861b3e95673d0e238c09938dd9c0d DIFF:

[PATCH] D82930: [HIP] Fix rocm detection

thakis added a comment. …oh, njames said that already 5h ago :) I guess I'll wait another hour or two, and then I'll revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82930/new/ https://reviews.llvm.org/D82930

[PATCH] D82930: [HIP] Fix rocm detection

thakis added a comment. This breaks check-clang on macOS: http://45.33.8.238/mac/17053/step_7.txt The output contains 5: clang: warning: argument unused during compilation: '--rocm-path=/Users/thakis/src/llvm-project/clang/test/Driver/Inputs/rocm' [-Wunused-command-line-argument] which if

[PATCH] D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json

ArcsinX added a comment. Also I think that `FileMatchTrie` introduced in https://reviews.llvm.org/D30 is not efficient solution to fight with symlinks and for most cases `InterpolatingCompilationDatabase` will be accurate enough. But I am not sure, is it safe to completely remove

[PATCH] D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, ilya-biryukov. Herald added a project: clang. If there is no record in compile_commands.json, we try to find suitable record with `MatchTrie.findEquivalent()` call. This is very expensive operation with a

[PATCH] D82930: [HIP] Fix rocm detection

njames93 added a comment. Herald added a subscriber: ormris. This is causing a test case to fail on mac http://45.33.8.238/mac/17048/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82930/new/ https://reviews.llvm.org/D82930

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7907e9d223d: [TRE] allow TRE for non-capturing calls. (authored by avl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82085/new/

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3bdc9814d94: [clang-tidy] Reworked enum options handling(again) (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D82188?vs=275520=277227#toc Repository: rG LLVM Github

[clang-tools-extra] c3bdc98 - [clang-tidy] Reworked enum options handling(again)

Author: Nathan James Date: 2020-07-11T10:13:20+01:00 New Revision: c3bdc9814d947946bf8e1062f6bf41b7f8813f80 URL: https://github.com/llvm/llvm-project/commit/c3bdc9814d947946bf8e1062f6bf41b7f8813f80 DIFF: https://github.com/llvm/llvm-project/commit/c3bdc9814d947946bf8e1062f6bf41b7f8813f80.diff

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

aqjune added a comment. Seems like a bug in instsimplify: define i1 @f(i32 %x, i32 %y) { %cmp9.not.1 = icmp eq i32 %x, %y %cmp15 = icmp slt i32 %x, %y %spec.select39 = select i1 %cmp9.not.1, i1 undef, i1 %cmp15 %spec.select40 = xor i1 %cmp9.not.1, 1 %spec.select = and