[PATCH] D83213: [AST][RecoveryExpr] Don't set the instantiation-bit.

hokein updated this revision to Diff 277332. hokein marked 12 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83213/new/ https://reviews.llvm.org/D83213 Files:

[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

MaskRay added a comment. Created http://lists.llvm.org/pipermail/cfe-dev/2020-July/066245.html [cfe-dev] Usage of clang::driver::options::DriverOption (-Xarch_ & gcc toolchain) to ask about the use case. When I get time, I'll work on a patch fixing the whole class of options instead of just

[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

MaskRay added a comment. Actually, the way we tag options recognized by GCC is wrong. We should use a more specific group instead of `DriverOption`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83648/new/ https://reviews.llvm.org/D83648

[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

MaskRay added inline comments. Comment at: clang/test/Driver/integrated-as.c:10 +// RUN: %clang -### -fintegrated-as %s 2>&1 | FileCheck %s -check-prefix FIAS-LINK + MaskRay wrote: > This test is incorrect. You need a specific target triple to select >

<    1   2   3