[PATCH] D83497: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc5530862870: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to… (authored by amyk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] fc55308 - [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments.

Author: Amy Kwan Date: 2020-07-16T00:30:24-05:00 New Revision: fc55308628709bfc64b100dadf9a030fbb2afaee URL: https://github.com/llvm/llvm-project/commit/fc55308628709bfc64b100dadf9a030fbb2afaee DIFF: https://github.com/llvm/llvm-project/commit/fc55308628709bfc64b100dadf9a030fbb2afaee.diff

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

craig.topper added a comment. Merge request for 11.0 https://bugs.llvm.org/show_bug.cgi?id=46740 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/ https://reviews.llvm.org/D83360 ___

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

craig.topper reopened this revision. craig.topper added a comment. This revision is now accepted and ready to land. Reverted in 00f3579aea6e3d4a4b7464c3db47294f71cef9e4 Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 00f3579 - Revert "[InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X transforms" and subsequent patches

Author: Craig Topper Date: 2020-07-15T22:02:33-07:00 New Revision: 00f3579aea6e3d4a4b7464c3db47294f71cef9e4 URL: https://github.com/llvm/llvm-project/commit/00f3579aea6e3d4a4b7464c3db47294f71cef9e4 DIFF: https://github.com/llvm/llvm-project/commit/00f3579aea6e3d4a4b7464c3db47294f71cef9e4.diff

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

craig.topper added a comment. I'm going to revert this as Eric requested. And I'll ask to merge the revert to the 11 branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/ https://reviews.llvm.org/D83360

[PATCH] D70411: [analyzer] CERT STR rule checkers: STR31-C

Charusso added a comment. Thanks for the reviews! In D70411#2153562 , @Szelethus wrote: > Please do not bypass the previous comments that hadn't reached a conclusion > -- littering inlines about miscellaneous stuff at this stage does more harm > then

[PATCH] D70411: [analyzer] CERT STR rule checkers: STR31-C

Charusso updated this revision to Diff 278368. Charusso marked 18 inline comments as done. Charusso edited the summary of this revision. Charusso added a comment. - Resolve most of the review comments. - We really need to specify the design of future checkers. CHANGES SINCE LAST ACTION

[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

pzheng updated this revision to Diff 278361. pzheng added a comment. Add target triple used in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83648/new/ https://reviews.llvm.org/D83648 Files: clang/include/clang/Driver/Options.td

[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

pzheng marked 2 inline comments as done. pzheng added a comment. In D83648#2146606 , @MaskRay wrote: > Created http://lists.llvm.org/pipermail/cfe-dev/2020-July/066245.html > [cfe-dev] Usage of clang::driver::options::DriverOption (-Xarch_ & gcc >

[libunwind] fd802cc - [libunwind] Fix getSLEB128 on large values

Author: Ryan Prichard Date: 2020-07-15T19:12:56-07:00 New Revision: fd802cc4dea4ed1a233ff725f98c686dc2836bf3 URL: https://github.com/llvm/llvm-project/commit/fd802cc4dea4ed1a233ff725f98c686dc2836bf3 DIFF: https://github.com/llvm/llvm-project/commit/fd802cc4dea4ed1a233ff725f98c686dc2836bf3.diff

[libunwind] 52d0a78 - [libunwind] Fix CIE v1 return address parsing

Author: Ryan Prichard Date: 2020-07-15T19:12:55-07:00 New Revision: 52d0a78b831584c46eda78b7cf349ab93ce13df0 URL: https://github.com/llvm/llvm-project/commit/52d0a78b831584c46eda78b7cf349ab93ce13df0 DIFF: https://github.com/llvm/llvm-project/commit/52d0a78b831584c46eda78b7cf349ab93ce13df0.diff

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

This revision was automatically updated to reflect the committed changes. Closed by commit rG537b16e9b8da: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime (authored by grokos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

grokos added a comment. OK, now it works. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67833/new/ https://reviews.llvm.org/D67833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

echristo added a comment. In D83360#2154637 , @aqjune wrote: > In D83360#2154584 , @echristo wrote: > > > It's that even before the msan instrumentation the IR doesn't look correct > > - thus a miscompile. > > >

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

jdenny updated this revision to Diff 278343. jdenny edited the summary of this revision. jdenny set the repository for this revision to rG LLVM Github Monorepo. jdenny added a comment. Rebased, and extracted D83922 as discussed. Repository: rG LLVM Github

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

jdenny created this revision. jdenny added reviewers: ABataev, jdoerfert, hfinkel, Meinersbur, kkwli0, grokos, sfantao, gtbercea, Hahnfeld. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a project: clang. For example, without this patch: $ cat test.c int

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh added a comment. In D67833#2154312 , @grokos wrote: > I tried to build clang with this patch and I get errors like: > > CGOpenMPRuntime.cpp:9463:38: error: > ‘OMPRTL___tgt_target_teams_nowait_mapper’ was not declared in this scope >

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh updated this revision to Diff 278344. lildmh added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Include the llvm part CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67833/new/ https://reviews.llvm.org/D67833 Files:

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

aqjune added a comment. In D83360#2154584 , @echristo wrote: > It's that even before the msan instrumentation the IR doesn't look correct - > thus a miscompile. I'll share a prototype of the InstSimplify patch on Phabricator, in a day or two; it would

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs updated this revision to Diff 278341. dokyungs added a comment. Ensure the fuzzer RT module is initialized at the beginning of the interceptors. Interceptors can be called before __fuzzer_init is called. So I added a check at the beginning of the interceptors, which ensures that

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

echristo added a comment. It's that even before the msan instrumentation the IR doesn't look correct - thus a miscompile. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/ https://reviews.llvm.org/D83360

[PATCH] D83893: [CUDA][HIP] Always defer diagnostics for wrong-sided reference

jlebar added a comment. tra and I talked offline and I...think this makes sense. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83893/new/ https://reviews.llvm.org/D83893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

lebedev.ri added a comment. In D83360#2154545 , @echristo wrote: > We're starting to see miscompiles as we do more testing as well, just nothing > smaller at the moment. Could you clarify, do you mean that this fix is causing (new) miscompiles?

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

echristo added a comment. We're starting to see miscompiles as we do more testing as well, just nothing smaller at the moment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/ https://reviews.llvm.org/D83360

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

lebedev.ri added a comment. In D83360#2154540 , @echristo wrote: > This seems like something that we should then revert until we know that > instsimplify can be updated with a fix? Possibility for a miscompile sounds much worse to me than a

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

echristo added a comment. This seems like something that we should then revert until we know that instsimplify can be updated with a fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/ https://reviews.llvm.org/D83360

[PATCH] D83914: [clangd] Plan features for FoldingRanges

kbobyrev updated this revision to Diff 278329. kbobyrev added a comment. Add some missing ranges. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83914/new/ https://reviews.llvm.org/D83914 Files:

[PATCH] D83914: [clangd] Plan features for FoldingRanges

kbobyrev updated this revision to Diff 278327. kbobyrev added a comment. Fix some typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83914/new/ https://reviews.llvm.org/D83914 Files:

[PATCH] D83914: [clangd] Plan features for FoldingRanges

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is not an actual patch, this is an RFC + TDD plan for future RAV implementation.

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

This revision was automatically updated to reflect the committed changes. Closed by commit rGed6b578040a8: [CodeGen] Emit a call instruction instead of an invoke if the called llvm… (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ed6b578 - [CodeGen] Emit a call instruction instead of an invoke if the called

Author: Akira Hatanaka Date: 2020-07-15T14:47:45-07:00 New Revision: ed6b578040a85977026c93bf4188f996148f3218 URL: https://github.com/llvm/llvm-project/commit/ed6b578040a85977026c93bf4188f996148f3218 DIFF:

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

ahatanak updated this revision to Diff 278316. ahatanak marked an inline comment as done. ahatanak added a comment. Update comment in test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83906/new/ https://reviews.llvm.org/D83906 Files:

[PATCH] D83820: Change metadata to deferred evalutaion in Clang Transformer.

asoffer added inline comments. Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:93 + // Not all transformations will want or need to attach metadata and therefore + // sholud not be requierd to do so. AnyGenerator Metadata = [](const

[PATCH] D83820: Change metadata to deferred evalutaion in Clang Transformer.

asoffer updated this revision to Diff 278315. asoffer marked 2 inline comments as done. asoffer added a comment. Typo fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83820/new/ https://reviews.llvm.org/D83820 Files:

[PATCH] D83909: [OPENMP] Fix PR46730: Fix compiler crash on taskloop over constructible loop counters.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: sstefan1, guansong, yaxunl. Herald added a project: clang. If the variable is constrcutible, its copy is created by calling a constructor. Such variables are duplicated and thus, must be captured.

[PATCH] D83099: [clangd] Store index in '.cache/clangd/index' instead of '.clangd/index'

davidvancleve added a comment. Thanks for the quick response! Nope, no compile_commands.json files, and they didn't previously contain .clangd files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83099/new/ https://reviews.llvm.org/D83099

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:614 + +TEST_F(SymbolCollectorTest, ObjCClassExtensions) { + Annotations Header(R"( Here's the ClassExtension that

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Looks good to me. Comment at: clang/test/CodeGenObjCXX/os_log.mm:16 // An `invoke` of a `nounwind` callee is simplified to a direct // call by an optimization in llvm.

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 278310. dgoldman marked an inline comment as done. dgoldman added a comment. SymbolCollector fixes + more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files:

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

ahatanak added a comment. In case it wasn't clear, the calls to `mayThrow()` in the test cases are needed to prevent `TryMarkNoThrow` from annotating the functions with nounwind, which would cause a lot of churn. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83242: [clang][BPF] support expr with typedef/record type for FIELD_EXISTENCE reloc

yonghong-song updated this revision to Diff 278305. yonghong-song added a comment. fix clang-format warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83242/new/ https://reviews.llvm.org/D83242 Files:

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

ahatanak created this revision. ahatanak added reviewers: vsk, rjmccall, ABataev. ahatanak added a project: clang. Herald added subscribers: ributzka, dexonsmith, jkorous. This fixes cases where an invoke is emitted, despite the called llvm function being marked nounwind, because

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

grokos added a comment. I tried to build clang with this patch and I get errors like: CGOpenMPRuntime.cpp:9463:38: error: ‘OMPRTL___tgt_target_teams_nowait_mapper’ was not declared in this scope ? OMPRTL___tgt_target_teams_nowait_mapper Where are these

[PATCH] D82118: [clang][module] Improve incomplete-umbrella warning

zixuw added a comment. In D82118#2154280 , @vsapsai wrote: > Didn't get into details but overall GenModuleActionWrapper approach looks > pretty complicated. Haven't tried to accomplish the same myself, so cannot > say if such complexity is warranted or

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman marked 7 inline comments as done. dgoldman added a comment. In D83501#2153605 , @sammccall wrote: > In D83501#2148671 , @dgoldman wrote: > > > I implemented goto-definition from Foo() --> Foo impl in

[PATCH] D83099: [clangd] Store index in '.cache/clangd/index' instead of '.clangd/index'

sammccall added a comment. In D83099#2154185 , @davidvancleve wrote: > Hey, quick question about this change: > > I'm seeing .cache directories appear off of subdirectories too, not just my > project root: > > 1. Untracked files: 31 #» .cache/ 32

[PATCH] D82118: [clang][module] Improve incomplete-umbrella warning

vsapsai added a comment. Didn't get into details but overall GenModuleActionWrapper approach looks pretty complicated. Haven't tried to accomplish the same myself, so cannot say if such complexity is warranted or not. What happens with fixits in modules when you don't have

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9566 +MEHandler.generateAllInfo(BasePointers, Pointers, Sizes, MapTypes, + CapturedVarSet, /*PresentModifierOnly=*/true); jdenny wrote: > ABataev

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh added a comment. @grokos Could you upstream this patch and the runtime patch neck to neck? Upstreaming one of them will break the OpenMP offloading. It will be nice if you can test this patch locally with the runtime patch. Thanks CHANGES SINCE LAST ACTION

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

jdenny added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9566 +MEHandler.generateAllInfo(BasePointers, Pointers, Sizes, MapTypes, + CapturedVarSet, /*PresentModifierOnly=*/true); ABataev wrote: > jdenny

[PATCH] D83242: [clang][BPF] support expr with typedef/record type for FIELD_EXISTENCE reloc

yonghong-song added a comment. In D83242#2154145 , @ast wrote: > lgtm. > curious what happens when type is defined within args, like: > __builtin_preserve_field_info(*(struct { int a; } *)0, 2); -bash-4.4$ clang -target bpf -O2 -g -S t1.c t1.c:3:40:

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67833/new/ https://reviews.llvm.org/D67833 ___ cfe-commits mailing list

[PATCH] D83242: [clang][BPF] support expr with typedef/record type for FIELD_EXISTENCE reloc

anakryiko added a comment. This is awesome. I'll apply patches locally and will play with them tonight to see if everything works in libbpf as well. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83242/new/ https://reviews.llvm.org/D83242

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh updated this revision to Diff 278291. lildmh added a comment. Update diff and pass test. Please accept CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67833/new/ https://reviews.llvm.org/D67833 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D83901: [clang] Disable a few formatting options for test/

riccibruno created this revision. riccibruno added reviewers: aaron.ballman, jdoerfert, lebedev.ri, MyDeveloperDay. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Hopefully this will make the bot a little less noisy. Rationale for each: `AlignTrailingComments`: We

[PATCH] D83099: [clangd] Store index in '.cache/clangd/index' instead of '.clangd/index'

davidvancleve added a comment. Hey, quick question about this change: I'm seeing .cache directories appear off of subdirectories too, not just my project root: Untracked files: 31 #» .cache/

[PATCH] D83897: [X86] Add a generic 32-bit CPU with sse2 with modern tuning flags to be used as the default for the 32-bit targets instead of pentium4

echristo added a comment. Did you want to just change the pentium4 tuning? Otherwise naming things is hard and this feels awkward, but I don't have any better ideas :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83897/new/ https://reviews.llvm.org/D83897

[PATCH] D83398: [OPENMP50]Perform data mapping analysis only for explicitly mapped data.

ABataev updated this revision to Diff 278284. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83398/new/ https://reviews.llvm.org/D83398 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D83820: Change metadata to deferred evalutaion in Clang Transformer.

ymandel added a comment. Looks like your changes to the .cpp and test files were reverted... Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:93 + // Not all transformations will want or need to attach metadata and therefore + // sholud not be requierd to do

[PATCH] D83242: [clang][BPF] support expr with typedef/record type for FIELD_EXISTENCE reloc

ast added a comment. lgtm. curious what happens when type is defined within args, like: __builtin_preserve_field_info(*(struct { int a; } *)0, 2); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83242/new/ https://reviews.llvm.org/D83242

[PATCH] D82576: [PowerPC][Power10] Implement low-order Vector Modulus Builtins, and add Vector Multiply/Divide/Modulus Builtins Tests

bsaleil added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:28 + return vec_mul(vulla, vullb); +} + Are the tests for `vec_mul` with `v4i32` missing ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83893: [CUDA][HIP] Always defer diagnostics for wrong-sided reference

tra added subscribers: jlebar, rsmith. tra added a comment. > This is different from nvcc behavior, where it is diagnosed only if the > function is really emitted: That by itself is not a sufficient reason for relaxing the checks. Clang is stricter/more principled in diagnosing other

[PATCH] D83334: [OPENMP]Fix PR46593: Reduction initializer missing construnctor call.

This revision was automatically updated to reflect the committed changes. Closed by commit rG41d0af00740a: [OPENMP]Fix PR46593: Reduction initializer missing construnctor call. (authored by ABataev). Changed prior to commit: https://reviews.llvm.org/D83334?vs=277448=278276#toc Repository:

[clang] 41d0af0 - [OPENMP]Fix PR46593: Reduction initializer missing construnctor call.

Author: Alexey Bataev Date: 2020-07-15T15:14:22-04:00 New Revision: 41d0af00740ac5140f11c7f37157fc6e6dd1b016 URL: https://github.com/llvm/llvm-project/commit/41d0af00740ac5140f11c7f37157fc6e6dd1b016 DIFF: https://github.com/llvm/llvm-project/commit/41d0af00740ac5140f11c7f37157fc6e6dd1b016.diff

[PATCH] D83696: [OPENMP]Fix PR46688: cast the type of the allocated variable to the initial one.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9dc327d1b746: [OPENMP]Fix PR46688: cast the type of the allocated variable to the initial one. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 9dc327d - [OPENMP]Fix PR46688: cast the type of the allocated variable to the initial one.

Author: Alexey Bataev Date: 2020-07-15T14:54:19-04:00 New Revision: 9dc327d1b74637dac6dc432fb66f88711af16a55 URL: https://github.com/llvm/llvm-project/commit/9dc327d1b74637dac6dc432fb66f88711af16a55 DIFF: https://github.com/llvm/llvm-project/commit/9dc327d1b74637dac6dc432fb66f88711af16a55.diff

[PATCH] D83820: Change metadata to deferred evalutaion in Clang Transformer.

asoffer marked 4 inline comments as done. asoffer added inline comments. Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:92 TextGenerator Note; - llvm::Any Metadata; + AnyGenerator Metadata = [](const ast_matchers::MatchFinder::MatchResult &) { +return

[PATCH] D83820: Change metadata to deferred evalutaion in Clang Transformer.

asoffer updated this revision to Diff 278262. asoffer added a comment. Add comments describing why we provide defaults for Metadata generation and design of withMetadata function template. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83820/new/

[PATCH] D83897: [X86] Add a generic 32-bit CPU with sse2 with modern tuning flags to be used as the default for the 32-bit targets instead of pentium4

craig.topper created this revision. craig.topper added reviewers: RKSimon, spatel, echristo, andreadb. Herald added subscribers: jfb, hiraditya. Herald added a project: LLVM. Currently our default 32-bit CPU on Linux and Windows is "pentium4" which comes with pentium4 tuning settings and almost

[clang] 268025e - Fix "unused variable" warning from recent GCC.

Author: Richard Smith Date: 2020-07-15T11:33:25-07:00 New Revision: 268025e2636c023fc39eed80cc4589f7ce9db786 URL: https://github.com/llvm/llvm-project/commit/268025e2636c023fc39eed80cc4589f7ce9db786 DIFF: https://github.com/llvm/llvm-project/commit/268025e2636c023fc39eed80cc4589f7ce9db786.diff

[PATCH] D83893: [CUDA][HIP] Always defer diagnostics for wrong-sided reference

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a subscriber: kristof.beyls. When a device function calls a host function or vice versa, this is wrong-sided reference. Currently clang immediately diagnose it. This is different from nvcc behavior, where it is diagnosed

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

c-rhodes marked 6 inline comments as done. c-rhodes added inline comments. Comment at: clang/test/Sema/arm-feature-sve-bits-macro.c:3 + +#include + aaron.ballman wrote: > c-rhodes wrote: > > aaron.ballman wrote: > > > This should not be using a system include

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

c-rhodes updated this revision to Diff 278249. c-rhodes added a comment. - Add a note to docs explaining this feature is a WIP. - `s/__ARM_FEATURE_SVE_BITS__EXPERIMENTAL/__ARM_FEATURE_SVE_BITS_EXPERIMENTAL`. - `s/validIntegerConstantExpr/verifyValidIntegerConstantExpr`. - Removed unrelated

[PATCH] D83892: Port CodeGen option flags to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D83698 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83892 Files:

[PATCH] D82663: [CodeGen] Have CodeGen for fixed-point unsigned with padding emit signed operations.

rjmccall added a comment. In D82663#2153176 , @ebevhan wrote: > In D82663#2144551 , @rjmccall wrote: > > > In D82663#2144219 , @ebevhan wrote: > > > > > In D82663#2142426

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

morehouse added a comment. I applied this patch locally and ran the fuzzer tests. I get a segfault: $ clang++ -fsanitize=fuzzer -g -m32 SimpleHashTest.cpp $ gdb --args ./a.out -seed=1 ... (gdb) run ... Program received signal SIGSEGV, Segmentation fault. 0x in ?? ()

[PATCH] D83120: [Analyzer][StreamChecker] Use BugType::SuppressOnSink at resource leak report.

NoQ accepted this revision. NoQ added a comment. In D83120#2152919 , @Szelethus wrote: > Unless @NoQ has anything else to add :) @balazske seems innocent indeed! :) :) :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83877: [Analyzer] Changed in SmartPtrModeling to handle Swap

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:198 void SmartPtrModeling::handleSwap(const CallEvent , CheckerContext ) const { I think it would be good to add some

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

guiand updated this revision to Diff 277992. guiand added a comment. Update tests again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82317/new/ https://reviews.llvm.org/D82317 Files: clang/test/ARCMT/objcmt-instancetype.m

[PATCH] D83826: [clangd] Don't send invalid messages from remote index

kbobyrev planned changes to this revision. kbobyrev added a comment. Wrap marshalling into a class, think about filtering vs failing? I think filtering should be done on the clangd-indexer side and marshalling should deal with **valid** symbols only and shouldn't have to filter them.

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. Thanks for the changes @c-rhodes, the use of a LANGOPT for this makes sense to me. With my nits addressed, I'm happy with the patch if @aaron.ballman is. Comment at:

[PATCH] D83831: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:63 +trace::Span Tracer("Remote index server Lookup"); +SPAN_ATTACH(Tracer, "LookupRequest", Request->ShortDebugString()); clangd::LookupRequest Req;

[PATCH] D83831: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 278237. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Resolve the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83831/new/ https://reviews.llvm.org/D83831 Files:

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

Conanap updated this revision to Diff 278235. Conanap marked 7 inline comments as done. Conanap added a comment. Formatting fixes, fixed test case return type, updated builtins' signatures to correct signatures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json

ArcsinX marked 3 inline comments as done. ArcsinX added a comment. As far as I do not have commit access, could you please commit for me? Aleksandr Platonov Comment at: clang/lib/Tooling/FileMatchTrie.cpp:111 + // As far as we do not support file symlinks we compare +

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

fpallares added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:99 // load vd, (rs1), vm class VUnitStrideLoad I believe that with the changes introduced in the encoding of the loads and stores we can do without the `mop` parameter in

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

sammccall added a comment. Thanks, this looks pretty good, I think there are a couple of adjustments... Comment at: clang-tools-extra/clangd/XRefs.cpp:276 getDeclAtPosition(AST, CurLoc, Relations, NodeKind)) { // Special case: void foo() ^override: jump to the

[PATCH] D83877: [Analyzer] Changed in SmartPtrModeling to handle Swap

xazax.hun added inline comments. Comment at: clang/test/Analysis/Inputs/system-header-simulator-cxx.h:964-965 + + template + void swap(unique_ptr , unique_ptr ) noexcept { +x.swap(y); NoQ wrote: > You seem to be relying on the fact that global `std::swap`

[PATCH] D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json

ArcsinX updated this revision to Diff 278230. ArcsinX added a comment. Update comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83621/new/ https://reviews.llvm.org/D83621 Files: clang/lib/Tooling/FileMatchTrie.cpp

[clang] ef30a00 - [NFC] Add float aggregate ABI test for PowerPC

Author: Qiu Chaofan Date: 2020-07-16T00:11:09+08:00 New Revision: ef30a00a57c78a91571a66555f2531af0f1f51e5 URL: https://github.com/llvm/llvm-project/commit/ef30a00a57c78a91571a66555f2531af0f1f51e5 DIFF: https://github.com/llvm/llvm-project/commit/ef30a00a57c78a91571a66555f2531af0f1f51e5.diff

[PATCH] D83836: [Analyzer] Implementing checkRegionChanges for SmartPtrModeling

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:97 +// If a region is removed all of the subregions needs to be removed too. +static ProgramStateRef removeTrackedRegions(ProgramStateRef State, nit: *need to

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

c-rhodes updated this revision to Diff 278218. c-rhodes edited the summary of this revision. c-rhodes added a comment. Herald added a subscriber: dang. Added `-msve-vector-bits=` flag. If specified the `__ARM_FEATURE_SVE_BITS__EXPERIMENTAL` macro is defined and a language option

[PATCH] D83877: [Analyzer] Changed in SmartPtrModeling to handle Swap

NoQ added inline comments. Comment at: clang/test/Analysis/Inputs/system-header-simulator-cxx.h:964-965 + + template + void swap(unique_ptr , unique_ptr ) noexcept { +x.swap(y); You seem to be relying on the fact that global `std::swap` is implemented in

[PATCH] D83772: [Windows] Fix limit on command line size

sepavloff updated this revision to Diff 278221. sepavloff added a comment. Fixed unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83772/new/ https://reviews.llvm.org/D83772 Files: llvm/include/llvm/Support/Program.h

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9566 +MEHandler.generateAllInfo(BasePointers, Pointers, Sizes, MapTypes, + CapturedVarSet, /*PresentModifierOnly=*/true); jdenny wrote: > ABataev

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

sammccall added a comment. In D83501#2148671 , @dgoldman wrote: > I implemented goto-definition from Foo() --> Foo impl in Xrefs, on the > symbolcollector side I don't think there's anything to do? This can't be done purely in xrefs as the AST may not

[clang] d6e79e3 - [OpenMP][Docs] Update `present` map type modifier status

Author: Joel E. Denny Date: 2020-07-15T11:17:00-04:00 New Revision: d6e79e3dd6df63425eb098f482be2c9744ad48eb URL: https://github.com/llvm/llvm-project/commit/d6e79e3dd6df63425eb098f482be2c9744ad48eb DIFF: https://github.com/llvm/llvm-project/commit/d6e79e3dd6df63425eb098f482be2c9744ad48eb.diff

[PATCH] D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Hmm, there is actually a case the old behavior may have been papering over: case-insensitive filesystems. If the real file is foo.cc and we query Foo.cc, then the trie would

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. In D79219#2152747 , @labath wrote: > I wouldn't mind separate (internal) cache variable, though I am somewhat > surprised by this problem. A (non-cache) variable set in one of the parent > scopes should still take precedence over

  1   2   3   >