[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

jdenny updated this revision to Diff 278658. jdenny added a comment. Rebased onto latest D83922 . Implemented rejection of `present` if not OpenMP >= 5.1. Cleaned up tests some. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83061/new/

[PATCH] D83999: [CMake][Fuchsia] Include additional tools in the toolchain

phosek created this revision. phosek added a reviewer: leonardchan. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. These are needed on Windows. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83999 Files: clang/cmake/caches/Fuchsia-stage2.cmake

[PATCH] D83997: [os_log] Improve the way we extend the lifetime of objects passed to __builtin_os_log_format

ahatanak created this revision. ahatanak added reviewers: rjmccall, erik.pilkington. ahatanak added a project: clang. Herald added subscribers: ributzka, dexonsmith, jkorous, martong. Herald added a reviewer: shafik. This patch fixes several shortcomings of the way we currently extend the

[clang] 8ef9e2b - Revert "[libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked."

Author: Richard Smith Date: 2020-07-16T18:06:37-07:00 New Revision: 8ef9e2bf355d05bc81d8b0fe1e5333eec59a0a91 URL: https://github.com/llvm/llvm-project/commit/8ef9e2bf355d05bc81d8b0fe1e5333eec59a0a91 DIFF: https://github.com/llvm/llvm-project/commit/8ef9e2bf355d05bc81d8b0fe1e5333eec59a0a91.diff

[PATCH] D83731: Add Debug Info Size to Symbol Status

wallace added a comment. @clayborg, the tests will fail on linux because the Makefile is expecting a .dsym file. I think it's okay if she does it just for Darwin and then I update the test to cover also linux, as I have my linux already well set up. Repository: rG LLVM Github Monorepo

[PATCH] D83731: Add Debug Info Size to Symbol Status

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So you should revert any clang format changes that are not in modified lines of source, mostly revert a lot of lines in lldb-vscode.cpp. Comment at:

[PATCH] D83731: Add Debug Info Size to Symbol Status

wallace added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:333-335 + if (section_name.startswith(".debug") || section_name.startswith("__debug")) +debug_info_size += section.GetFileByteSize(); + if (section_name.startswith(".apple") ||

[PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278631. aelitashen added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. The tests added are only for macOS, Walter will help me write tests on Linux. This update optimize the code and apply git clang format.

[PATCH] D83992: [ASTImporter] Add Visitor for TypedefNameDecl's

vabridgers updated this revision to Diff 278630. vabridgers added a comment. Fix lint pre-merge check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83992/new/ https://reviews.llvm.org/D83992 Files: clang/lib/AST/ASTImporterLookupTable.cpp

[PATCH] D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling

vrnithinkumar marked 2 inline comments as done. vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:97 +// If a region is removed all of the subregions needs to be removed too. +static ProgramStateRef

[PATCH] D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling

vrnithinkumar updated this revision to Diff 278628. vrnithinkumar marked 8 inline comments as done. vrnithinkumar added a comment. - Adding a missed todo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83836/new/ https://reviews.llvm.org/D83836

[PATCH] D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling

vrnithinkumar updated this revision to Diff 278622. vrnithinkumar marked an inline comment as done. vrnithinkumar added a comment. - Addressing review comments - Enabling commented out tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83836/new/

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

jdenny marked an inline comment as done. jdenny added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7043-7044 OMP_MAP_CLOSE = 0x400, +/// Produce a runtime error if the data is not already allocated. +OMP_MAP_PRESENT = 0x800, /// The 16

[PATCH] D83992: [ASTImporter] Add Visitor for TypedefNameDecl's

vabridgers created this revision. vabridgers added a reviewer: martong. Herald added subscribers: cfe-commits, teemperor, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. We found a case where Typedef Name Declarations were not being added correctly when importing

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

This revision was automatically updated to reflect the committed changes. Closed by commit rG12d1124c49be: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when… (authored by dokyungs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 12d1124 - [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

Author: Dokyung Song Date: 2020-07-16T22:53:54Z New Revision: 12d1124c49beec0fb79d36944960e5bf0f236d4c URL: https://github.com/llvm/llvm-project/commit/12d1124c49beec0fb79d36944960e5bf0f236d4c DIFF: https://github.com/llvm/llvm-project/commit/12d1124c49beec0fb79d36944960e5bf0f236d4c.diff LOG:

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

hctim accepted this revision. hctim added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83987/new/ https://reviews.llvm.org/D83987 ___ cfe-commits mailing list

[PATCH] D83592: [Parser] Add comment to skipped regions

zequanwu added a comment. In D83592#2157130 , @vsk wrote: > > ! In D83592#2156758 , @zequanwu > > wrote: > > One way I could think is probably when we visit decl in > > `CounterCoverageMappingBuilder`, check for

[PATCH] D83516: [PowerPC][Power10] 128-bit Binary Integer Operation instruction definitions and MC Tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2735635523d: [PowerPC][Power10] Add 128-bit Binary Integer Operation instruction definitions… (authored by Conanap, committed by amyk). Changed prior to commit:

[PATCH] D83592: [Parser] Add comment to skipped regions

vsk added a comment. > ! In D83592#2156758 , @zequanwu > wrote: > One way I could think is probably when we visit decl in > `CounterCoverageMappingBuilder`, check for if there is `SkippedRegion` in the > same line and then mark the decl range as

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

morehouse accepted this revision. morehouse added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83987/new/ https://reviews.llvm.org/D83987 ___ cfe-commits mailing list

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

dokyungs updated this revision to Diff 278613. dokyungs added a comment. Adjusted the comment as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83987/new/ https://reviews.llvm.org/D83987 Files: clang/lib/Driver/SanitizerArgs.cpp

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

hctim added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:1092 + // libFuzzer wants to intercept calls to certain library functions, so the + // following -fno-builtin-* flags disable implicit builtin knowledge about + // those functions. Other sanitizers

[PATCH] D83820: Change metadata to deferred evalutaion in Clang Transformer.

asoffer updated this revision to Diff 278611. asoffer marked an inline comment as done. asoffer added a comment. Typo fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83820/new/ https://reviews.llvm.org/D83820 Files:

[PATCH] D83893: [CUDA][HIP] Always defer diagnostics for wrong-sided reference

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83893/new/ https://reviews.llvm.org/D83893 ___ cfe-commits mailing list

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

dokyungs marked an inline comment as done. dokyungs added a comment. Thanks Mitch for the comment! Added a comment that explains that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83987/new/ https://reviews.llvm.org/D83987

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

dokyungs updated this revision to Diff 278610. dokyungs added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83987/new/ https://reviews.llvm.org/D83987 Files: clang/lib/Driver/SanitizerArgs.cpp

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

hctim accepted this revision. hctim added a comment. This revision is now accepted and ready to land. LGTM w/ nit Comment at: clang/lib/Driver/SanitizerArgs.cpp:1091 + if (Sanitizers.has(SanitizerKind::FuzzerNoLink)) { +CmdArgs.push_back("-fno-builtin-memcmp");

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

jdenny added a comment. In D83922#2156567 , @ABataev wrote: > In D83922#2156510 , @jdenny wrote: > > > In D83922#2155749 , @ABataev wrote: > > > > > I would add checks for

[PATCH] D81031: [OpenMP] Add Additional Function Attribute Information to OMPKinds.def

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Apologies for the wait. I think with the comments below this is good to go. If you have questions or concerns, let me know. Thanks for these changes! Comment at:

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

dokyungs created this revision. dokyungs added reviewers: morehouse, hctim. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. This patch disables implicit builtin knowledge about memcmp-like functions when compiling the program for fuzzing, i.e., when

[PATCH] D83970: [ASTImporter] Refactor ASTImporter to support custom downstream tests

vabridgers added a comment. @shafik, Thanks! I'll wait 'til Gabor gets a chance to review before landing. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83970/new/ https://reviews.llvm.org/D83970

[PATCH] D83974: [AIX] report_fatal_error on `-fregister_global_dtors_with_atexit` for static init

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1212 if (CodeGenOpts.RegisterGlobalDtorsWithAtExit) { +if (getContext().getTargetInfo().getTriple().isOSAIX()) + llvm::report_fatal_error( This should query

[PATCH] D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor.

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:227 continue; + // Ignore tokens in disabled preprocessor sections. + if (Buf.expandedTokens(SM.getMacroArgExpandedLocation(T->location())) sammccall wrote: > I

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

c-rhodes added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1541 +def ArmSveVectorBits128 : TypeAttr { + let Spellings = []; aaron.ballman wrote: > c-rhodes wrote: > > c-rhodes wrote: > > > aaron.ballman wrote: > > > > aaron.ballman wrote: >

[PATCH] D83553: [PATCH 3/4][Sema][AArch64] Add codegen for arm_sve_vector_bits attribute

efriedma added inline comments. Comment at: clang/lib/CodeGen/CodeGenTypes.h:138 + llvm::Type *ConvertTypeForMem(QualType T, bool ForBitField = false, +bool EnforceFixedLengthSVEAttribute = false); c-rhodes wrote: > efriedma

[PATCH] D82994: [RFC] Instrumenting Clang/LLVM with Perfetto

lebedev.ri added inline comments. Comment at: llvm/cmake/modules/AddPerfetto.cmake:9 + ExternalProject_Add(perfetto_git + GIT_REPOSITORY https://github.com/google/perfetto.git + GIT_TAG releases/v4.x nickdesaulniers wrote: > lebedev.ri wrote: > > I

[PATCH] D83984: Explicitly use utf-8 in send_string

trixirt created this revision. trixirt added reviewers: serge-sans-paille, michaelplatings. trixirt added a project: clang. Herald added a subscriber: cfe-commits. send_patched_file decodes with utf-8. The default encoder for python 2 is ascii. So it is necessary to also change send_string to

[PATCH] D82994: [RFC] Instrumenting Clang/LLVM with Perfetto

nickdesaulniers added inline comments. Herald added a subscriber: dang. Comment at: clang/lib/Driver/Driver.cpp:3754 + // We don't need to count the assembler as a job since it doesn't + // cause the memory issue that requires disabling integrated-cc1.

[PATCH] D83974: [AIX] report_fatal_error on `-fregister_global_dtors_with_atexit` for static init

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. LGTM with minor nit. Comment at: clang/test/CodeGenCXX/aix-sinit-register-global-dtors-with-atexit.cpp:10 +struct T{ +T(); +~T(); nit: fix

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf78d9fceea73: [libFuzzer] Link libFuzzers own interceptors when other compiler runtimes are… (authored by dokyungs, committed by morehouse). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] f78d9fc - [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

Author: Dokyung Song Date: 2020-07-16T20:26:35Z New Revision: f78d9fceea736d431e9e3cbca291e3909e3aa46d URL: https://github.com/llvm/llvm-project/commit/f78d9fceea736d431e9e3cbca291e3909e3aa46d DIFF: https://github.com/llvm/llvm-project/commit/f78d9fceea736d431e9e3cbca291e3909e3aa46d.diff LOG:

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs updated this revision to Diff 278589. dokyungs added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83494/new/ https://reviews.llvm.org/D83494 Files: clang/include/clang/Driver/SanitizerArgs.h

[PATCH] D83857: Harmonize python shebang

This revision was automatically updated to reflect the committed changes. Closed by commit rG515bc8c1554f: Harmonize Python shebang (authored by serge-sans-paille). Herald added projects: clang, Sanitizers, LLDB, libc++, OpenMP, libc-project. Herald added subscribers: libc-commits,

[clang] 4fd91b0 - Remove an unused variable in Clang.

Author: Nadav Rotem Date: 2020-07-16T12:48:48-07:00 New Revision: 4fd91b0f946f49370a3ab33c480a807a3f48b247 URL: https://github.com/llvm/llvm-project/commit/4fd91b0f946f49370a3ab33c480a807a3f48b247 DIFF: https://github.com/llvm/llvm-project/commit/4fd91b0f946f49370a3ab33c480a807a3f48b247.diff

[PATCH] D83592: [Parser] Add comment to skipped regions

zequanwu added a comment. In D83592#2151773 , @zequanwu wrote: > In D83592#2151217 , @vsk wrote: > > > Could you add an end-to-end llvm-cov test (see e.g. > > compiler-rt/test/profile/Linux/coverage_ctors.cpp)?

[PATCH] D83979: Port LangOpts option flags to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, sstefan1, dexonsmith, aheejin, dschuff. Herald added a reviewer: jdoerfert. Herald added a project: clang. Depends on D83940 Repository: rG LLVM Github

[PATCH] D83820: Change metadata to deferred evalutaion in Clang Transformer.

ymandel added inline comments. Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:93 + // Not all transformations will want or need to attach metadata and therefore + // should not be requierd to do so. + AnyGenerator Metadata = [](const

[PATCH] D83820: Change metadata to deferred evalutaion in Clang Transformer.

ymandel added inline comments. Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:93 + // Not all transformations will want or need to attach metadata and therefore + // sholud not be requierd to do so. AnyGenerator Metadata = [](const

[PATCH] D75677: [Analyzer] Only add iterator note tags to the operations of the affected iterators

baloghadamsoftware updated this revision to Diff 278574. baloghadamsoftware added a comment. Rebased, no tricks with `LazyCompoundVal`s are used anymore. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75677/new/ https://reviews.llvm.org/D75677 Files:

[PATCH] D74541: [Analyzer] Use note tags to track iterator increments and decrements

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/test/Analysis/iterator-modelling.cpp:434 + //expected-note@-1 0-1{{Calling 'next}} + //expected-note@-2 0-1{{Passing the value 1 via 2nd parameter 'n'}} +

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

morehouse added inline comments. Comment at: compiler-rt/lib/fuzzer/FuzzerInterceptors.cpp:51 +static int fuzzerInited = 0; +static bool fuzzerInitIsRunning; + Sorry, one last nit: If we're preferring LLVM style, let's

[clang] 5e8b4be - [AST][NFC] Simplify a regression test

Author: Jan Korous Date: 2020-07-16T12:07:18-07:00 New Revision: 5e8b4be9f8546884889b1f178a6a2c2a5c1c9d1f URL: https://github.com/llvm/llvm-project/commit/5e8b4be9f8546884889b1f178a6a2c2a5c1c9d1f DIFF: https://github.com/llvm/llvm-project/commit/5e8b4be9f8546884889b1f178a6a2c2a5c1c9d1f.diff

[PATCH] D83713: [WebAssembly] Triple::wasm64 related cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit rG29f8c9f6c25d: [WebAssembly] Triple::wasm64 related cleanup (authored by aardappel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83713/new/

[clang] 29f8c9f - [WebAssembly] Triple::wasm64 related cleanup

Author: Wouter van Oortmerssen Date: 2020-07-16T12:01:10-07:00 New Revision: 29f8c9f6c25d50fd21e255060ea36eb0025ca2eb URL: https://github.com/llvm/llvm-project/commit/29f8c9f6c25d50fd21e255060ea36eb0025ca2eb DIFF:

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs updated this revision to Diff 278565. dokyungs added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83494/new/ https://reviews.llvm.org/D83494 Files: clang/include/clang/Driver/SanitizerArgs.h

[PATCH] D83015: [Driver] Add --ld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path

MaskRay added a comment. I tweaked the following item in the last revision > a relative path without a path component separator (/), the value is searched > using the -B, COMPILER_PATH, then PATH. My communication with GCC folks is that they will be happy to adopt something like --ld-path.

[clang] a59d4ae - [Analyzer] Hotfix for various crashes in iterator checkers

Author: Adam Balogh Date: 2020-07-16T20:49:33+02:00 New Revision: a59d4ae4313c0a961c50d14c0616b49220c5a469 URL: https://github.com/llvm/llvm-project/commit/a59d4ae4313c0a961c50d14c0616b49220c5a469 DIFF: https://github.com/llvm/llvm-project/commit/a59d4ae4313c0a961c50d14c0616b49220c5a469.diff

[PATCH] D83970: [ASTImporter] Refactor ASTImporter to support custom downstream tests

shafik added a comment. LGTM but I want @martong to take a look as well and accept. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83970/new/ https://reviews.llvm.org/D83970 ___ cfe-commits mailing

[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

This revision was automatically updated to reflect the committed changes. Closed by commit rGa59d4ae4313c: [Analyzer] Hotfix for various crashes in iterator checkers (authored by baloghadamsoftware). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

ABataev added a comment. Check, if it fixed https://bugs.llvm.org/show_bug.cgi?id=46012 Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9468-9469 CurSizes, CurMapTypes, PartialStruct); +if (!CI->capturesThis()) +

[PATCH] D71124: [RISCV] support clang driver to select cpu

This revision was automatically updated to reflect the committed changes. Closed by commit rG294d1eae75bf: [RISCV] Add support for -mcpu option. (authored by Zakk Chen zakk.c...@sifive.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71124/new/

[clang] 294d1ea - [RISCV] Add support for -mcpu option.

Author: Zakk Chen Date: 2020-07-16T11:46:22-07:00 New Revision: 294d1eae75bf8867821a4491f0d67445227f8470 URL: https://github.com/llvm/llvm-project/commit/294d1eae75bf8867821a4491f0d67445227f8470 DIFF: https://github.com/llvm/llvm-project/commit/294d1eae75bf8867821a4491f0d67445227f8470.diff

[PATCH] D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins

NeHuang added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-p10vsx.ll:2 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu \ +; RUN: -mcpu=pwr10

[PATCH] D83974: [AIX] report_fatal_error on `-fregister_global_dtors_with_atexit` for static init

Xiangling_L created this revision. Xiangling_L added reviewers: jasonliu, hubert.reinterpretcast, yusra.syeda. Herald added a project: clang. Herald added a subscriber: cfe-commits. On AIX, the semantic of global_dtors contains `__sterm` functions associated with C++ cleanup actions and

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

ABataev added a comment. In D83922#2156510 , @jdenny wrote: > In D83922#2155749 , @ABataev wrote: > > > I would add checks for mapping of `declare target to/link` vars and checked > > if they work in runtime. > >

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5385 + if (getCodeGenOpts().hasMaybeUnusedDebugInfo() && CRD->hasDefinition()) +DI->completeUnusedClass(*CRD); + else if (auto *ES = D->getASTContext().getExternalSource())

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 278557. nickdesaulniers marked 9 inline comments as done. nickdesaulniers added a comment. Herald added a subscriber: dang. - rebase on 227db86a1b7dd , update NOT checks

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

simoncook added a comment. In D80802#2156221 , @HsiangKai wrote: > The modification is put in D81213 . Ah ok, missed that, thanks for pointing it out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

NeHuang added a comment. Overall seems fine to me, but of course, please wait to hear from Amy. Just some nits for the test case. Comment at: llvm/test/CodeGen/PowerPC/p10-vector-shift.ll:9 +; RUN: FileCheck %s + +define dso_local <1 x i128> @test_vec_slq(<1 x i128> %a, <1

[PATCH] D83820: Change metadata to deferred evalutaion in Clang Transformer.

asoffer marked an inline comment as done. asoffer added inline comments. Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:93 + // Not all transformations will want or need to attach metadata and therefore + // sholud not be requierd to do so. AnyGenerator

[PATCH] D83015: [Driver] Add --ld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path

MaskRay updated this revision to Diff 278555. MaskRay edited the summary of this revision. MaskRay removed a subscriber: gkm. MaskRay added a comment. Herald added subscribers: dang, emaste. Respect -B and COMPILER_PATH Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

jdenny added a comment. In D83922#2155749 , @ABataev wrote: > I would add checks for mapping of `declare target to/link` vars and checked > if they work in runtime. There are existing codegen tests for that, and they don't seem to be affected by this

[clang] 0afe172 - [Driver] Make -B take precedence over COMPILER_PATH

Author: Fangrui Song Date: 2020-07-16T11:27:16-07:00 New Revision: 0afe172e2ee5fb7600fb423a992dbeb884cbebd2 URL: https://github.com/llvm/llvm-project/commit/0afe172e2ee5fb7600fb423a992dbeb884cbebd2 DIFF: https://github.com/llvm/llvm-project/commit/0afe172e2ee5fb7600fb423a992dbeb884cbebd2.diff

[PATCH] D83820: Change metadata to deferred evalutaion in Clang Transformer.

asoffer updated this revision to Diff 278552. asoffer added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83820/new/ https://reviews.llvm.org/D83820 Files: clang/include/clang/Tooling/Transformer/RewriteRule.h

[PATCH] D83972: Modify ImportDefiniton for ObjCInterfaceDecl so that we always the ImportDeclContext one we start the definition

shafik created this revision. shafik added reviewers: teemperor, martong. Herald added a subscriber: rnkovacs. Once we start the definition of an `ObjCInterfaceDecl` we won't attempt to `ImportDeclContext` later on. Unlike `RecordDecl` case which uses `DefinitionCompleter` to force

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

jdenny marked an inline comment as done. jdenny added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7948-7949 + MapFlagsArrayTy , + const llvm::DenseSet = + llvm::DenseSet()) const {

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

jdenny updated this revision to Diff 278546. jdenny marked 7 inline comments as done. jdenny edited the summary of this revision. jdenny added a comment. Use `CanonicalDeclPtr`, as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83922/new/ https://reviews.llvm.org/D83922

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

v.g.vassilev removed a reviewer: aaron.ballman. v.g.vassilev added a comment. >> Also, I would like to add that the current test present in this diff does >> not fail in the existing system but it was the best I and Vassil could come >> up with to replicate our problem. > > Is there a way to

[PATCH] D83959: Fix compiling warnings in OpenMP declare mapper codegen

lildmh added a comment. Thanks George! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83959/new/ https://reviews.llvm.org/D83959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

NeHuang added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:14156 + + // This transformation is only valid if the we are loading either a byte, + // halfword, word, or doubleword. nit: if we are loading either a byte

[PATCH] D83970: [ASTImporter] Refactor ASTImporter to support custom downstream tests

vabridgers created this revision. vabridgers added a reviewer: martong. Herald added subscribers: cfe-commits, teemperor, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. The purpose of this change is to do a small refactoring of code

[PATCH] D83959: Fix compiling warnings in OpenMP declare mapper codegen

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc47c0e0a6a2: [clang] Fix compilation warnings in OpenMP declare mapper codegen. (authored by grokos). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[clang] fc47c0e - [clang] Fix compilation warnings in OpenMP declare mapper codegen.

Author: George Rokos Date: 2020-07-16T11:04:12-07:00 New Revision: fc47c0e0a6a2681154efa9d31b8605fc91a62daa URL: https://github.com/llvm/llvm-project/commit/fc47c0e0a6a2681154efa9d31b8605fc91a62daa DIFF: https://github.com/llvm/llvm-project/commit/fc47c0e0a6a2681154efa9d31b8605fc91a62daa.diff

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. The description includes `... however it is more preferable to use bitcast`. It is not a question of preference but of correctness. The fp to int conversions truncate while

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

fghanim added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:433 - Builder.SetInsertPoint(OuterFn->getEntryBlock().getFirstNonPHI()); - AllocaInst *TIDAddr = Builder.CreateAlloca(Int32, nullptr, "tid.addr"); - AllocaInst *ZeroAddr =

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

aaron.ballman added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1159 + case BuiltinType::UInt128: +OS << "Ui128"; +break; davidstone wrote: > aaron.ballman wrote: > > riccibruno wrote: > > > riccibruno wrote: > > > > davidstone wrote: > >

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

aaron.ballman added a comment. In D83174#2155143 , @gargvaibhav64 wrote: > The tests weren't failing for me. So, we are possibly missing test coverage. > I have made the change now. Thanks for making the change. > Also, I would like to add that the

[PATCH] D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP support

jsji added a comment. In D83915#2155650 , @hubert.reinterpretcast wrote: > Should we indicate planned removal in the Release Notes for version 11 and > actual removal in those for version 12? Good suggestion. https://reviews.llvm.org/D83968 for adding

[PATCH] D83099: [clangd] Store index in '.cache/clangd/index' instead of '.clangd/index'

davidvancleve added a comment. Super! Once we pull in that version (unsure of the latency; this is my first time reporting an issue with clangd), I'll be sure to come back and confirm that the fix is working for me. Thank you again for the quick turnaround! Repository: rG LLVM Github

[PATCH] D83099: [clangd] Store index in '.cache/clangd/index' instead of '.clangd/index'

sammccall added a comment. https://bugs.llvm.org/show_bug.cgi?id=46754 to get the fixed merged Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83099/new/ https://reviews.llvm.org/D83099 ___ cfe-commits

[PATCH] D83099: [clangd] Store index in '.cache/clangd/index' instead of '.clangd/index'

sammccall added a comment. In D83099#2155900 , @davidvancleve wrote: > Yes, these two are exactly the case! > > > - you'd be using an editor/plugin that sends compile commands over LSP > > (such as YCM + ycm_extra_conf). What are you using? > > - there

[PATCH] D83942: [analyzer][tests] Add a notion of project sizes

NoQ added a comment. > Sizes assigned to the projects in this commit, do not directly > correspond to the number of lines or files in the project. Maybe `QUICK`/`NORMAL`/`SLOW` then? Or by purpose: `BENCHMARK`/`DAILY`/`PARANOID`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D83961: [Analyzer] Fix bug report source locations in minimal output.

NoQ added a comment. > These will be updated if the code change looks good. Hard to tell; this entire code is too convoluted, i'd rather look at the changes. Can you update at least some tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83966: Enable the test for hasArraySize() in all language modes

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In C++11 and later Clang generates an implicit conversion from int to size_t in the AST. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83966 Files:

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

morehouse added inline comments. Comment at: compiler-rt/lib/fuzzer/FuzzerInterceptors.cpp:17 + +#define GET_CALLER_PC() __builtin_return_address(0) + Nit: Let's move this down with the other defines. Comment at:

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

HsiangKai added a comment. In D80802#2155432 , @simoncook wrote: > Since this patch replaces 0.8 support with 0.9, it should include an update > to the version check in `clang/lib/Driver/ToolChains/Arch/RISCV.cpp` to match. The modification is put in

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

morehouse added inline comments. Comment at: compiler-rt/lib/fuzzer/FuzzerInterceptors.cpp:53 +int fuzzer_inited = 0; +bool fuzzer_init_is_running; + These are in the global namespace, and have C mangling, which is unnecessary. Please either put them in a

[PATCH] D83868: Use TestClangConfig in AST Matchers tests and run them in more configurations

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f244c4b42b0: Use TestClangConfig in AST Matchers tests and run them in more configurations (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4f244c4 - Use TestClangConfig in AST Matchers tests and run them in more configurations

Author: Dmitri Gribenko Date: 2020-07-16T18:36:53+02:00 New Revision: 4f244c4b42b096a55f2e7f719e1101c6fd26c034 URL: https://github.com/llvm/llvm-project/commit/4f244c4b42b096a55f2e7f719e1101c6fd26c034 DIFF:

  1   2   >