[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

Meinersbur added a comment. Seems that it already has been applied ;-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67833/new/ https://reviews.llvm.org/D67833 ___ cfe-commits mailing list

[PATCH] D83261: [OPENMP]Redesign of OMPExecutableDirective representation.

Meinersbur added a comment. AFAICS this extract out the handling of subnodes of OMPExecutableDirectives into the OMPChildren class which is made optional since `OMPChildren *OMPExecutableDirectives::Data` can be nullptr. However, since it also stores clauses, it seems that about every

[PATCH] D82728: [clang] Add -Wsuggest-override

logan-5 added a comment. In D82728#2161152 , @xbolva00 wrote: > Is it possible to emit fixit note with "override" ? This is a good idea, though unfortunately (after eyeballing the implementation of `modernize-use-override` in clang-tidy

[PATCH] D82728: [clang] Add -Wsuggest-override

xbolva00 added a comment. Is it possible to emit fixit note with "override" ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82728/new/ https://reviews.llvm.org/D82728 ___ cfe-commits mailing list

[clang] cf11050 - [Utils][Fix] remove unnecessary ; at the end

Author: sstefan1 Date: 2020-07-19T20:48:28+02:00 New Revision: cf1105069648446d58adfb7a6cc590013d6886ba URL: https://github.com/llvm/llvm-project/commit/cf1105069648446d58adfb7a6cc590013d6886ba DIFF: https://github.com/llvm/llvm-project/commit/cf1105069648446d58adfb7a6cc590013d6886ba.diff

[clang] 937bad3 - [Utils] Check function attributes in update_test_checks

Author: sstefan1 Date: 2020-07-19T20:07:24+02:00 New Revision: 937bad3594e7cba44cddae4661e1bae911beba3e URL: https://github.com/llvm/llvm-project/commit/937bad3594e7cba44cddae4661e1bae911beba3e DIFF: https://github.com/llvm/llvm-project/commit/937bad3594e7cba44cddae4661e1bae911beba3e.diff

[PATCH] D83629: [Utils] Check function attributes in update_test_checks

This revision was automatically updated to reflect the committed changes. Closed by commit rG937bad3594e7: [Utils] Check function attributes in update_test_checks (authored by sstefan1). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

logan-5 added a comment. Pinging this. I believe all feedback from @EricWF was addressed back in my update to the patch in March. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72282/new/ https://reviews.llvm.org/D72282 ___ cfe-commits

[clang] 13316a7 - [clang] Disable a few formatting options for test/

Author: Bruno Ricci Date: 2020-07-19T17:07:24+01:00 New Revision: 13316a77053514be552a0dad932e3455413b4f82 URL: https://github.com/llvm/llvm-project/commit/13316a77053514be552a0dad932e3455413b4f82 DIFF: https://github.com/llvm/llvm-project/commit/13316a77053514be552a0dad932e3455413b4f82.diff

[PATCH] D83901: [clang] Disable a few formatting options for test/

This revision was automatically updated to reflect the committed changes. Closed by commit rG13316a770535: [clang] Disable a few formatting options for test/ (authored by riccibruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83901/new/

[clang] 89ff9bf - [clang] Fix the warning for a non-void consteval function without a return value to actually say "consteval".

Author: Bruno Ricci Date: 2020-07-19T17:08:17+01:00 New Revision: 89ff9bf061b4985d11cd4785958d8f8156d10f5d URL: https://github.com/llvm/llvm-project/commit/89ff9bf061b4985d11cd4785958d8f8156d10f5d DIFF: https://github.com/llvm/llvm-project/commit/89ff9bf061b4985d11cd4785958d8f8156d10f5d.diff

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

bernhardmgruber updated this revision to Diff 279088. bernhardmgruber marked 3 inline comments as done. bernhardmgruber added a comment. - Added two more tests with a macro supplied on the command line - Rebased onto master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80514/new/

[clang-tools-extra] 9791416 - Silence a "logical operation on address of string constant" via CMake instead.

Author: Aaron Ballman Date: 2020-07-19T11:19:48-04:00 New Revision: 97914164f8454e745219566d58479b5762cccd51 URL: https://github.com/llvm/llvm-project/commit/97914164f8454e745219566d58479b5762cccd51 DIFF: https://github.com/llvm/llvm-project/commit/97914164f8454e745219566d58479b5762cccd51.diff

[clang-tools-extra] b79ca34 - Revert 7dfff42f019583076c55993d30a63889613922dd as it broke non-Windows builds.

Author: Aaron Ballman Date: 2020-07-19T11:12:39-04:00 New Revision: b79ca34530e88c3a13a9c7afb1df42d7a622e3dd URL: https://github.com/llvm/llvm-project/commit/b79ca34530e88c3a13a9c7afb1df42d7a622e3dd DIFF: https://github.com/llvm/llvm-project/commit/b79ca34530e88c3a13a9c7afb1df42d7a622e3dd.diff

[clang-tools-extra] 7dfff42 - Silencing some 'logical operation on address of string constant diagnostics; NFC

Author: Aaron Ballman Date: 2020-07-19T10:53:51-04:00 New Revision: 7dfff42f019583076c55993d30a63889613922dd URL: https://github.com/llvm/llvm-project/commit/7dfff42f019583076c55993d30a63889613922dd DIFF: https://github.com/llvm/llvm-project/commit/7dfff42f019583076c55993d30a63889613922dd.diff

[PATCH] D83645: Bump the default target CPU for i386-freebsd to i686

dim added a comment. In D83645#2160761 , @MaskRay wrote: > @dim > > Hi, your git commit contains extra Phabricator tags. You can drop > `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git > commit with the following script: > >

[PATCH] D84090: [clang-format] Add SpaceAroundBitFieldColon option

MyDeveloperDay added a comment. Let’s do all 4, None, Both, Left, Right Neither is an odd word for non English speakers Also I before e can confuse the slightly dyslexic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84090/new/

[PATCH] D83519: [NewPM] Support optnone under new pass manager

ychen added inline comments. Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:57 +class OptNoneInstrumentation { +public: I may probably name this `SkipPassInstrumentation`. But it is up to you. Comment at:

[PATCH] D84122: [clangd] Handle deduction guides in TargetFinder and ExplicitReferenceCollector

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/463. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84122 Files: