[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

This revision was automatically updated to reflect the committed changes. Closed by commit rG160ff83765ac: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3 (authored by saiislam). Changed prior to commit: https://reviews.llvm.org/D84260?vs=282010=282502#toc

[clang] 160ff83 - [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

Author: Saiyedul Islam Date: 2020-08-03T05:38:39Z New Revision: 160ff83765ac284f3c7dd7b25d4ef105b9952ac0 URL: https://github.com/llvm/llvm-project/commit/160ff83765ac284f3c7dd7b25d4ef105b9952ac0 DIFF: https://github.com/llvm/llvm-project/commit/160ff83765ac284f3c7dd7b25d4ef105b9952ac0.diff

[PATCH] D84886: Create LoopNestPass

ychen added a comment. I think this needs unit tests like LoopPassManagerTest.cpp (in that file or a similarly named file) to demonstrate the expected behavior: the expected usage comparing with LoopPass/LoopAnalysisPass, how the adaptor is used and the invalidation interaction within its pass

[PATCH] D85105: [doxygen] Fix bad doxygen results for BugReporterVisitors.h

OikawaKirie created this revision. OikawaKirie added reviewers: NoQ, vsavchenko. OikawaKirie added a project: clang. Herald added subscribers: cfe-commits, Charusso. OikawaKirie requested review of this revision. Because of `{@code x}` will trigger a Doxygen bug. And as far as I am thinking,

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:408-412 +SmallString<128> Msg; +llvm::raw_svector_ostream Out(Msg); +TagDetails.trackValidExpr(BR); +TagDetails.explainSmartPtrAction(Out); +

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:14047 +static bool isComparisonOpSamePrecedence(BinaryOperatorKind Opc) { + switch (Opc) { Same precedence as what? I think this should just be called `isRelationalOperator`, and I

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:14010 + << Bop->getSourceRange() << OpLoc; + SuggestParentheses(Self, Bop->getOperatorLoc(), + Self.PDiag(diag::note_precedence_silence) vabridgers wrote: >

[PATCH] D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter

nridge added a comment. (This should be ready for another round of review.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84136/new/ https://reviews.llvm.org/D84136 ___ cfe-commits mailing list

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

tschuett updated this revision to Diff 282485. tschuett added a comment. add/updated test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85102/new/ https://reviews.llvm.org/D85102 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

vabridgers added a comment. I believe I've addressed all comments so far. Looks like Arthur suggested some particular cases that are not currently covered, and are not covered by this change since I think addressing those issues are our of scope of my original intent. If this patch is

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

vabridgers updated this revision to Diff 282484. vabridgers added a comment. refactor test cases per comment from Arthur Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85097/new/ https://reviews.llvm.org/D85097 Files:

[PATCH] D85026: [analyzer] Introduce minor refactoring of SVal::getSubKind function

ASDenysPetrov added a comment. @vsavchenko: > However, I'm going to complain about commit messages again  I would prefer > having imperative mood in the message, something like "Refactor ..." or > "Introduce minor refactoring..." Changed title. Thank you, guys! Repository: rG LLVM

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

xbolva00 added a comment. Thanks. Can you add some test cases? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85102/new/ https://reviews.llvm.org/D85102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

tschuett added a comment. introduced in https://reviews.llvm.org/D45319 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85102/new/ https://reviews.llvm.org/D85102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D85034: [analyzer] Simplify functions SVal::getAsSymbolicExpression and similar ones

ASDenysPetrov added a comment. @vsavchenko > I again have to nitpick about the commit message, can you please change it to > "Simplify ..."? Ready! Sorry, I remember, you've already told me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

tschuett updated this revision to Diff 282483. tschuett added a comment. Replaced (...) by ; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85102/new/ https://reviews.llvm.org/D85102 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:274 + "misaligned atomic operation may incur " + "significant performance penalty " + "(the expected (%0 bytes) exceeds the actual alignment (%1 bytes)">, Use ;

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

tschuett created this revision. tschuett added a reviewer: rsmith. Herald added a reviewer: jfb. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. tschuett requested review of this revision. Herald added a subscriber: dexonsmith. "Listing the alignment and access size (==

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

vabridgers added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:14010 + << Bop->getSourceRange() << OpLoc; + SuggestParentheses(Self, Bop->getOperatorLoc(), + Self.PDiag(diag::note_precedence_silence) vabridgers wrote: >

[PATCH] D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

hoyFB added a comment. In D82822#2189692 , @jdoerfert wrote: > In D82822#2189366 , @hoyFB wrote: > >> In D82822#2187576 , @jdoerfert >> wrote: >> >>> @davezarzycki The bots

[clang] 00a0282 - [Clang] Remove run-lines which use opt to run -ipconstprop.

Author: Florian Hahn Date: 2020-08-02T21:47:32+01:00 New Revision: 00a0282ff8f9a790e93c19ef6fa3758e209cdbe6 URL: https://github.com/llvm/llvm-project/commit/00a0282ff8f9a790e93c19ef6fa3758e209cdbe6 DIFF: https://github.com/llvm/llvm-project/commit/00a0282ff8f9a790e93c19ef6fa3758e209cdbe6.diff

[PATCH] D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling

vrnithinkumar marked an inline comment as done. vrnithinkumar added a comment. In D83836#2189636 , @NoQ wrote: > These patches look like they're done, maybe let's land them? This one also committed.

[PATCH] D83877: [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling

vrnithinkumar marked an inline comment as done. vrnithinkumar added a comment. In D83877#2189637 , @NoQ wrote: > These patches look like they're done, maybe let's land them? I have already committed this changes.

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

vabridgers updated this revision to Diff 282475. vabridgers added a comment. back out last unwanted changes from clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85097/new/ https://reviews.llvm.org/D85097 Files:

[PATCH] D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

jdoerfert added a comment. In D82822#2189366 , @hoyFB wrote: > In D82822#2187576 , @jdoerfert wrote: > >> @davezarzycki The bots reported this as well, didn't build MLIR locally, >> this should have been fixed by

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis added a comment. I have managed to improve the checker, but could not set up the test files to work only in POSIX platforms. Could you help me or show me an example? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis updated this revision to Diff 282472. abelkocsis marked 5 inline comments as done. abelkocsis added a comment. Fixes Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://reviews.llvm.org/D75229 Files:

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

vabridgers added inline comments. Comment at: clang/test/Misc/warning-wall.c:6 + CHECK - + NEXT : -Wchar -

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

vabridgers added a comment. Thanks for the comments. I posted an update for the simpler issues, working on refactoring the test cases and creating a fixit. Thanks for the good and actionable review comments! Comment at: clang/docs/DiagnosticsReference.rst:2853

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

vabridgers updated this revision to Diff 282471. vabridgers marked 2 inline comments as done. vabridgers added a comment. Address simpler issues brought up during review so far. Tests to be refactored, and a fixit added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83877: [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling

NoQ added a comment. These patches look like they're done, maybe let's land them? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83877/new/ https://reviews.llvm.org/D83877 ___ cfe-commits mailing list

[PATCH] D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling

NoQ added a comment. These patches look like they're done, maybe let's land them? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83836/new/ https://reviews.llvm.org/D83836 ___ cfe-commits mailing list

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

vabridgers added a comment. Thank you for the comments @lebedev.ri and @Quuxplusone. I'll abandon the tidy approach (https://reviews.llvm.org/D84898) and work towards satisfying these review comments (and any others), driving towards acceptance. Best! Repository: rG LLVM Github Monorepo

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

Quuxplusone added a comment. Btw, this is an awesome patch! I'm looking forward to getting to use it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85097/new/ https://reviews.llvm.org/D85097 ___

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

lebedev.ri added a comment. Thank you! I strongly prefer this path forward. Comment at: clang/lib/Sema/SemaExpr.cpp:14010 + << Bop->getSourceRange() << OpLoc; + SuggestParentheses(Self, Bop->getOperatorLoc(), +

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

Quuxplusone added inline comments. Comment at: clang/docs/DiagnosticsReference.rst:2853 +-Wcompare-no-parentheses + s/-no-/-op-/ Comment at: clang/docs/DiagnosticsReference.rst:9885 -Also controls

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

vabridgers added a comment. This is an implementation in the CFE, after submitting and getting comments on https://reviews.llvm.org/D84898. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85097/new/ https://reviews.llvm.org/D85097

[PATCH] D85074: [WebAssembly] Use "signed char" instead of "char" in SIMD intrinsics.

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. Nice! Thanks for doing that :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85074/new/ https://reviews.llvm.org/D85074

[PATCH] D84898: [clang-tidy] Add new checker for complex conditions with no meaning

vabridgers added a comment. I've posted https://reviews.llvm.org/D85097 to replace this review. https://reviews.llvm.org/D85097 implements this check in the CFE instead of as a tidy check per recommendation from @lebedev.ri . If acceptable, I'll abandon this review. Repository: rG LLVM

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

vabridgers created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. vabridgers requested review of this revision. This changes add a new warning named -Wcompare-op-parentheses that's part of the -Wparentheses diagnostic group. This diagnostic produces a

[PATCH] D72103: [Sema] Avoid using an invalid InsertPos

Mordante updated this revision to Diff 282460. Mordante added a comment. Rebased the patch and updated the unit tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72103/new/ https://reviews.llvm.org/D72103 Files: clang/lib/Sema/SemaTemplate.cpp

[PATCH] D85093: [analyzer] StdLibraryFunctionsChecker: Add support for new functions

zukatsinadze created this revision. zukatsinadze added reviewers: NoQ, Charusso, martong, Szelethus. zukatsinadze added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun.

[clang] 90dab1a - Remove unused param tag to fix Wdocumentation warning. NFC.

Author: Simon Pilgrim Date: 2020-08-02T15:12:01+01:00 New Revision: 90dab1aece7100ace855321162c0d2a09b31c1b3 URL: https://github.com/llvm/llvm-project/commit/90dab1aece7100ace855321162c0d2a09b31c1b3 DIFF: https://github.com/llvm/llvm-project/commit/90dab1aece7100ace855321162c0d2a09b31c1b3.diff

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

Mordante created this revision. Mordante added reviewers: rsmith, rjmccall. Mordante added a project: clang. Herald added subscribers: llvm-commits, hiraditya. Herald added a reviewer: aaron.ballman. Herald added a project: LLVM. Mordante requested review of this revision. This contains the

[PATCH] D44536: Avoid segfault when destructor is not yet known

dim added a comment. Hm, this review's still open after two years, and even as of 2020-08-02 clang still crashes on the sample. :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44536/new/ https://reviews.llvm.org/D44536

[PATCH] D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

hoyFB added a comment. In D82822#2187576 , @jdoerfert wrote: > @davezarzycki The bots reported this as well, didn't build MLIR locally, this > should have been fixed by 4d83aa4771d84940626d86c883193af390812281 >

[PATCH] D84987: [CMake] Pass bugreport URL to standalone clang build

mgorny added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84987/new/ https://reviews.llvm.org/D84987 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D84987: [CMake] Pass bugreport URL to standalone clang build

This revision was automatically updated to reflect the committed changes. Closed by commit rG21c165de2a1b: [CMake] Pass bugreport URL to standalone clang build (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 21c165d - [CMake] Pass bugreport URL to standalone clang build

Author: Michał Górny Date: 2020-08-02T08:32:05+02:00 New Revision: 21c165de2a1bcca9dceb452f637d9e8959fba113 URL: https://github.com/llvm/llvm-project/commit/21c165de2a1bcca9dceb452f637d9e8959fba113 DIFF: https://github.com/llvm/llvm-project/commit/21c165de2a1bcca9dceb452f637d9e8959fba113.diff