[clang] 000ad1a - [clang] fix a compilation bug

2020-08-16 Thread Yonghong Song via cfe-commits
Author: Yonghong Song Date: 2020-08-16T21:53:37-07:00 New Revision: 000ad1a976a537256b17788dcf8b50ca117007b8 URL: https://github.com/llvm/llvm-project/commit/000ad1a976a537256b17788dcf8b50ca117007b8 DIFF: https://github.com/llvm/llvm-project/commit/000ad1a976a537256b17788dcf8b50ca117007b8.diff

[clang] ae500e4 - Always keep unset fields in FPOptionsOverride zeroed.

2020-08-16 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-08-16T15:44:51-07:00 New Revision: ae500e4d0964adea69372d083416b0f13e9a87eb URL: https://github.com/llvm/llvm-project/commit/ae500e4d0964adea69372d083416b0f13e9a87eb DIFF: https://github.com/llvm/llvm-project/commit/ae500e4d0964adea69372d083416b0f13e9a87eb.diff

[clang] 948219d - Replace setter named 'getAsOpaqueInt' with a real getter.

2020-08-16 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-08-16T16:38:33-07:00 New Revision: 948219d1098736758123c43f995ec784db5d921e URL: https://github.com/llvm/llvm-project/commit/948219d1098736758123c43f995ec784db5d921e DIFF: https://github.com/llvm/llvm-project/commit/948219d1098736758123c43f995ec784db5d921e.diff

[clang] ae30670 - Use consistent code for setting FPFeatures from operator constructors.

2020-08-16 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-08-16T15:40:38-07:00 New Revision: ae3067055b33f6ab5657fbae5845cc743b91c299 URL: https://github.com/llvm/llvm-project/commit/ae3067055b33f6ab5657fbae5845cc743b91c299 DIFF: https://github.com/llvm/llvm-project/commit/ae3067055b33f6ab5657fbae5845cc743b91c299.diff

[PATCH] D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter

2020-08-16 Thread Nathan Ridge via Phabricator via cfe-commits
nridge marked 2 inline comments as done. nridge added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1843 + if (const auto *TC = D->getTypeConstraint()) { +TRY_TO(TraverseStmt(TC->getImmediatelyDeclaredConstraint()));

[PATCH] D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter

2020-08-16 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 285911. nridge added a comment. Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84136/new/ https://reviews.llvm.org/D84136 Files: clang-tools-extra/clangd/unittests/FindTargetTests.cpp

[PATCH] D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter

2020-08-16 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 285910. nridge added a comment. Only visit the TypeConstraint if the immediately-declared-constraint is null Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84136/new/ https://reviews.llvm.org/D84136 Files:

[clang] 9860e68 - Don't leave the FPOptions in a UnaryOperator uninitialized.

2020-08-16 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-08-16T15:16:12-07:00 New Revision: 9860e68450cd04ec2c53fe2dbcfab64a86c76673 URL: https://github.com/llvm/llvm-project/commit/9860e68450cd04ec2c53fe2dbcfab64a86c76673 DIFF: https://github.com/llvm/llvm-project/commit/9860e68450cd04ec2c53fe2dbcfab64a86c76673.diff

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

2020-08-16 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 285907. nridge marked 4 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83536/new/ https://reviews.llvm.org/D83536 Files:

[clang] ae7f088 - [InstCombine] Aggregate reconstruction simplification (PR47060)

2020-08-16 Thread Roman Lebedev via cfe-commits
Author: Roman Lebedev Date: 2020-08-16T23:27:56+03:00 New Revision: ae7f08812e0995481eb345cecc5dd4529829ba44 URL: https://github.com/llvm/llvm-project/commit/ae7f08812e0995481eb345cecc5dd4529829ba44 DIFF: https://github.com/llvm/llvm-project/commit/ae7f08812e0995481eb345cecc5dd4529829ba44.diff

[PATCH] D85787: [InstCombine] Aggregate reconstruction simplification (PR47060)

2020-08-16 Thread Roman Lebedev via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae7f08812e09: [InstCombine] Aggregate reconstruction simplification (PR47060) (authored by lebedev.ri). Repository: rG LLVM Github Monorepo

[PATCH] D85934: Enable OpenMP offloading to VE and enable tests for offloading to VE

2020-08-16 Thread Joachim Protze via Phabricator via cfe-commits
protze.joachim added inline comments. Comment at: openmp/libomptarget/test/lit.cfg:67 append_dynamic_library_path('DYLD_LIBRARY_PATH', \ config.omp_host_rtl_directory, ";") config.test_flags += " -Wl,-rpath," + config.library_dir Unrelated to

[PATCH] D85787: [InstCombine] Aggregate reconstruction simplification (PR47060)

2020-08-16 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri updated this revision to Diff 285898. lebedev.ri marked 4 inline comments as done. lebedev.ri added a comment. Patch updated - addressed all nits other than the question about decoupling `enum` values from variable names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D86037: [OpenMP][FIX] Do not use TBAA in type punning reduction GPU code PR46156

2020-08-16 Thread Johannes Doerfert via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG95a25e4c3203: [OpenMP][FIX] Do not use TBAA in type punning reduction GPU code PR46156 (authored by jdoerfert). Changed prior to commit:

[clang] 95a25e4 - [OpenMP][FIX] Do not use TBAA in type punning reduction GPU code PR46156

2020-08-16 Thread Johannes Doerfert via cfe-commits
Author: Johannes Doerfert Date: 2020-08-16T14:38:31-05:00 New Revision: 95a25e4c3203f35e9f57f9fac620b4a21bffd6e1 URL: https://github.com/llvm/llvm-project/commit/95a25e4c3203f35e9f57f9fac620b4a21bffd6e1 DIFF:

[PATCH] D85787: [InstCombine] Aggregate reconstruction simplification (PR47060)

2020-08-16 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. @spatel thank you for taking a look! In D85787#2220343 , @spatel wrote: > This seems similar in spirit to the recursive element tracking that we do in > collectShuffleElements() in this file or foldIdentityShuffles() in >

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

2020-08-16 Thread Mark de Wever via Phabricator via cfe-commits
Mordante marked 14 inline comments as done. Mordante added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1288 +def Likely : StmtAttr { + let Spellings = [CXX11<"", "likely", 201803>]; + let Documentation = [LikelihoodDocs]; aaron.ballman

[PATCH] D85875: [OpenMP][FIX] Do not crash trying to print a missing (demangled) user condition

2020-08-16 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Seems OK to me as a local fix. I'm not sure about encoding 'missing condition' as 0, but that's a preexisting choice. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D85878: [OpenMP] Context selector extensions for return value overloading

2020-08-16 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Link error seems reasonable to me. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85878/new/

[PATCH] D85787: [InstCombine] Aggregate reconstruction simplification (PR47060)

2020-08-16 Thread Sanjay Patel via Phabricator via cfe-commits
spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. This seems similar in spirit to the recursive element tracking that we do in collectShuffleElements() in this file or foldIdentityShuffles() in InstSimplify, but a bit more complicated

[PATCH] D85321: [OPENMP]Do not capture base pointer by reference if it is used as a base for array-like reduction.

2020-08-16 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. While we should be able to optimize this later in the pipeline soon, I guess we can do it early for now. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] fef2607 - [Sema] Use the proper cast for a fixed bool enum.

2020-08-16 Thread Mark de Wever via cfe-commits
Author: Mark de Wever Date: 2020-08-16T18:40:08+02:00 New Revision: fef26071240711e8f7305715b5f22cfc7ad04bfe URL: https://github.com/llvm/llvm-project/commit/fef26071240711e8f7305715b5f22cfc7ad04bfe DIFF: https://github.com/llvm/llvm-project/commit/fef26071240711e8f7305715b5f22cfc7ad04bfe.diff

[PATCH] D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type

2020-08-16 Thread Mark de Wever via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfef260712407: [Sema] Use the proper cast for a fixed bool enum. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85612/new/

[clang] 827ba67 - [Sema] Validate calls to GetExprRange.

2020-08-16 Thread Mark de Wever via cfe-commits
Author: Mark de Wever Date: 2020-08-16T18:32:38+02:00 New Revision: 827ba67e383313b05e9b10c8215e501530d6c9e3 URL: https://github.com/llvm/llvm-project/commit/827ba67e383313b05e9b10c8215e501530d6c9e3 DIFF: https://github.com/llvm/llvm-project/commit/827ba67e383313b05e9b10c8215e501530d6c9e3.diff

[PATCH] D85601: Fixes an assertion when IntRange processes a throw expression

2020-08-16 Thread Mark de Wever via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG827ba67e3833: [Sema] Validate calls to GetExprRange. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85601/new/

[PATCH] D86037: [OpenMP][FIX] Do not use TBAA in type punning reduction GPU code PR46156

2020-08-16 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86037/new/ https://reviews.llvm.org/D86037 ___

[PATCH] D86037: [OpenMP][FIX] Do not use TBAA in type punning reduction GPU code PR46156

2020-08-16 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, ABataev. Herald added subscribers: guansong, bollu, kosarev, yaxunl. Herald added a project: clang. jdoerfert requested review of this revision. Herald added a subscriber: sstefan1. When we implement OpenMP GPU

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

2020-08-16 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1288 +def Likely : StmtAttr { + let Spellings = [CXX11<"", "likely", 201803>]; + let Documentation = [LikelihoodDocs]; Mordante wrote: > aaron.ballman wrote: > > Hmm, I'm on the

[clang] 44613bb - Create strict aligned code for OpenBSD/arm64.

2020-08-16 Thread Brad Smith via cfe-commits
Author: Brad Smith Date: 2020-08-16T07:14:34-04:00 New Revision: 44613bbec88be9e86b8c52c4f40bb1b1ab48d84c URL: https://github.com/llvm/llvm-project/commit/44613bbec88be9e86b8c52c4f40bb1b1ab48d84c DIFF: https://github.com/llvm/llvm-project/commit/44613bbec88be9e86b8c52c4f40bb1b1ab48d84c.diff

[PATCH] D86034: [WIP] Attribute harden_misspeculation

2020-08-16 Thread Zola Bridges via Phabricator via cfe-commits
zbrid created this revision. Herald added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. zbrid requested review of this revision. Starting with if support first - Parse attribute check for diagnosable issues with its usage Repository: rG

[PATCH] D86033: This is mostly prototype code that should be deleted.

2020-08-16 Thread Zola Bridges via Phabricator via cfe-commits
zbrid created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. zbrid requested review of this revision. Revert or squash this before uploading for review. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86033 Files: