[PATCH] D86279: [clangd] Don't crash on `#pragma clang __debug parser_crash`

2020-08-20 Thread Aleksandr Platonov via Phabricator via cfe-commits
ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. ArcsinX requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Currently, clangd crashes when opening a file with `#pragma

[PATCH] D85736: [Sema][AArch64] Support arm_sve_vector_bits attribute

2020-08-20 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm added a comment. LGTM from a spec point of view, but I don't think I should be the one to approve. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85736/new/ https://reviews.llvm.org/D85736 ___ cfe-commits mailing list

[PATCH] D86277: [NFC][compiler-rt] Factor out __mulv[sdt]i3 implementations to .inc file

2020-08-20 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko created this revision. atrosinenko added reviewers: MaskRay, kamleshbhalui, luismarques, efriedma, aykevl. Herald added subscribers: Sanitizers, dberris. Herald added a project: Sanitizers. atrosinenko requested review of this revision. The existing implementations are almost

[PATCH] D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

2020-08-20 Thread Dave Green via Phabricator via cfe-commits
dmgreen added a comment. I mean, do we need upgrade code in llvm/lib/IR/AutoUpgrade.cpp for the new intrinsic forms? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86146/new/ https://reviews.llvm.org/D86146 ___ cfe-commits mailing list

[PATCH] D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

2020-08-20 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 286761. miyuki added a comment. Keep the second vbfmlaltq_laneq_f32 test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86146/new/ https://reviews.llvm.org/D86146 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

2020-08-20 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 286762. eduucaldas added a comment. Implicit `MemberExpr` generates `id-expression` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86227/new/ https://reviews.llvm.org/D86227 Files:

[PATCH] D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

2020-08-20 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. In D86146#2226702 , @dmgreen wrote: > Do we need to upgrade the old bfmmla to the new signatures? What is the old bfmmla? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86146/new/

[PATCH] D86274: [Constants] Handle FNeg in getWithOperands.

2020-08-20 Thread Florian Hahn via Phabricator via cfe-commits
fhahn created this revision. fhahn added reviewers: efriedma, aprantl, arsenm. Herald added subscribers: cfe-commits, hiraditya. Herald added projects: clang, LLVM. fhahn requested review of this revision. Herald added a subscriber: wdng. Currently ConstantExpr::getWithOperands does not handle

[PATCH] D83296: [clang-format] Add a MacroExpander.

2020-08-20 Thread Manuel Klimek via Phabricator via cfe-commits
klimek added inline comments. Comment at: clang/lib/Format/MacroExpander.cpp:186 +Tok->MacroCtx = MacroContext(MR_ExpandedArg); + pushToken(Tok); +} sammccall wrote: > klimek wrote: > > sammccall wrote: > > > you're pushing here without copying.

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

2020-08-20 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:180 + MemberExpression_member, + MemberExpression_accessToken, }; Could you order new items in source order? object, access token, member. Comment at:

[PATCH] D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder.

2020-08-20 Thread Bevin Hansson via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e7ec4842c1a: [AST] Get field size in chars rather than bits in RecordLayoutBuilder. (authored by ebevhan). Repository: rG LLVM Github Monorepo

[clang] 1a995a0 - [ADT] Move FixedPoint.h from Clang to LLVM.

2020-08-20 Thread Bevin Hansson via cfe-commits
Author: Bevin Hansson Date: 2020-08-20T10:29:45+02:00 New Revision: 1a995a0af3c4e97c1135b6c9c3a243072ee0463c URL: https://github.com/llvm/llvm-project/commit/1a995a0af3c4e97c1135b6c9c3a243072ee0463c DIFF: https://github.com/llvm/llvm-project/commit/1a995a0af3c4e97c1135b6c9c3a243072ee0463c.diff

[PATCH] D85312: [ADT] Move FixedPoint.h from Clang to LLVM.

2020-08-20 Thread Bevin Hansson via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a995a0af3c4: [ADT] Move FixedPoint.h from Clang to LLVM. (authored by ebevhan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1e7ec48 - [AST] Get field size in chars rather than bits in RecordLayoutBuilder.

2020-08-20 Thread Bevin Hansson via cfe-commits
Author: Bevin Hansson Date: 2020-08-20T10:29:29+02:00 New Revision: 1e7ec4842c1a8b0c686e5674e215012867938a8d URL: https://github.com/llvm/llvm-project/commit/1e7ec4842c1a8b0c686e5674e215012867938a8d DIFF: https://github.com/llvm/llvm-project/commit/1e7ec4842c1a8b0c686e5674e215012867938a8d.diff

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

2020-08-20 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm added a comment. I'm not qualified to review the CodeGen stuff (or accept the patch, obvs. :-)) but FWIW, here are some comments on the doc and Sema side. It might be good to have more Sema tests for valid and invalid usage, e.g. for which operators are valid and which aren't.

[PATCH] D85706: [compiler-rt] Compile assembly files as ASM not C

2020-08-20 Thread Petr Hosek via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGd58fd4e52197: [compiler-rt] Compile assembly files as ASM not C (authored by phosek). Repository: rG LLVM Github

[clang] d58fd4e - [compiler-rt] Compile assembly files as ASM not C

2020-08-20 Thread Petr Hosek via cfe-commits
Author: Petr Hosek Date: 2020-08-20T00:34:59-07:00 New Revision: d58fd4e52197d55bf42ca446c8b0ed31b5c2ec1f URL: https://github.com/llvm/llvm-project/commit/d58fd4e52197d55bf42ca446c8b0ed31b5c2ec1f DIFF: https://github.com/llvm/llvm-project/commit/d58fd4e52197d55bf42ca446c8b0ed31b5c2ec1f.diff

[PATCH] D85706: [compiler-rt] Compile assembly files as ASM not C

2020-08-20 Thread Raul Tambre via Phabricator via cfe-commits
tambre added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85706/new/ https://reviews.llvm.org/D85706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

<    1   2