[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

MaskRay added a comment. Note that Harbormaster actually reported the check-clang-codegencxx issues B69369 .. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86491/new/ https://reviews.llvm.org/D86491

[clang] 05777ab - Temporarily Revert "[DebugInfo] Move constructor homing case in shouldOmitDefinition."

Author: Eric Christopher Date: 2020-08-24T21:51:31-07:00 New Revision: 05777ab941063192b9ccb1775358a83a2700ccc1 URL: https://github.com/llvm/llvm-project/commit/05777ab941063192b9ccb1775358a83a2700ccc1 DIFF:

RE: [clang] 589ce5f - [DebugInfo] Move constructor homing case in shouldOmitDefinition.

Hi Amy, Looks like there's some test failures on the PS4 Linux bot as a result of this commit. Could you take a look? If the failure persists for a while, I may need to revert this to unclog the bots and our internal CI.

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG589ce5f7050d: [DebugInfo] Move constructor homing case in shouldOmitDefinition. (authored by akhuang). Repository: rG LLVM Github Monorepo

[clang] 589ce5f - [DebugInfo] Move constructor homing case in shouldOmitDefinition.

Author: Amy Huang Date: 2020-08-24T20:17:59-07:00 New Revision: 589ce5f7050dd83fd3f7dbc182ea0fb051ece994 URL: https://github.com/llvm/llvm-project/commit/589ce5f7050dd83fd3f7dbc182ea0fb051ece994 DIFF: https://github.com/llvm/llvm-project/commit/589ce5f7050dd83fd3f7dbc182ea0fb051ece994.diff

[PATCH] D86503: [X86] Support -march=sapphirerapids

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86503/new/ https://reviews.llvm.org/D86503

[PATCH] D86503: [X86] Support -march=sapphirerapids

FreddyYe created this revision. FreddyYe added reviewers: craig.topper, pengfei, LuoYuanke. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, hiraditya. Herald added projects: clang, Sanitizers, LLVM. FreddyYe requested review of this revision. Support -march=sapphirerapids for

[PATCH] D79279: Add overloaded versions of builtin mem* functions

rsmith added a comment. Thanks, I'm happy with this approach. If I understand correctly, the primary (perhaps sole) purpose of `__builtin_memcpy_sized` is to provide a primitive from which an atomic operation can be produced. That being the case, I wonder if the name is emphasizing the wrong

[PATCH] D86502: [CSSPGO] Pseudo probe instrumentation for basic blocks

hoy created this revision. Herald added subscribers: llvm-commits, cfe-commits, wenlei, dang, dexonsmith, hiraditya. Herald added projects: clang, LLVM. hoy requested review of this revision. This change introduces a new clang switch `-fpseudo-probe-for-profiling` to enable AutoFDO with pseudo

[clang] 9160494 - Properly pass modules flags to frontend when using -std=c++20 instead of -std=c++2a.

Author: Richard Smith Date: 2020-08-24T17:49:58-07:00 New Revision: 91604949ef2fc8401d17a31362c46c310d5550b6 URL: https://github.com/llvm/llvm-project/commit/91604949ef2fc8401d17a31362c46c310d5550b6 DIFF: https://github.com/llvm/llvm-project/commit/91604949ef2fc8401d17a31362c46c310d5550b6.diff

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang added a comment. unfortunately not any thorough testing :) I just happened to notice it the last time I looked at this code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86491/new/ https://reviews.llvm.org/D86491

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Thanks for testing/catching this (what sort of testing have you been doing that discovered this?)! & yeah, the way shouldOmitDefinition is now written (with this fix) is right - that

[PATCH] D86494: Work around GCC 10 not emitting base variants of structors for final classes, by avoiding referencing the symbols in question.

rsmith created this revision. rsmith added a reviewer: rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. rsmith requested review of this revision. As far as I can determine, the only case we need to be careful about is when we would generate a reference to the

[PATCH] D86376: [HIP] Improve kernel launching latency

tra added a comment. In D86376#2234719 , @yaxunl wrote: >> This patch appears to be somewhere in the gray area to me. My prior >> experience with CUDA suggests that it will make little to no difference. On >> the other hand, AMD GPUs may be different

[PATCH] D86097: [OpenMP][AMDGCN] Generate global variables and attributes for AMDGCN

saiislam updated this revision to Diff 287513. saiislam added a comment. 1. Moved amdgcn specific functions to CGOpenMPAMDGCN.cpp 2. Removed tautology condition 3. Corrected case of local variables 4. Restored original formatting 5. Changed back declaration of emit kernel methods as private 6.

[PATCH] D86027: [analyzer] Add bool operator modeling for unque_ptr

vrnithinkumar updated this revision to Diff 287512. vrnithinkumar marked 11 inline comments as done. vrnithinkumar added a comment. - Adding checkLiveSymbols and review comments changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86027/new/

[PATCH] D86027: [analyzer] Add bool operator modeling for unque_ptr

vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:137 + const auto *RecordDecl = MethodDecl->getParent(); + if (!RecordDecl || !RecordDecl->getDeclContext()->isStdNamespace()) +return InnerType;

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang created this revision. akhuang added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang requested review of this revision. For some reason the ctor homing case was before the template specialization case, and could have returned false too

[PATCH] D86376: [HIP] Improve kernel launching latency

yaxunl added a comment. In D86376#2234547 , @tra wrote: > I'm OK with how the patch is implemented. > I'm still on the fence regarding whether it should be implemented. > > In D86376#2234458 , @yaxunl wrote: > >>

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

hubert.reinterpretcast added a comment. In D85324#2233290 , @abhina.sreeskantharajan wrote: > Thanks Hubert, I fixed the comment. Got it; I'll look into committing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

fhahn added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85473/new/ https://reviews.llvm.org/D85473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D86488: [X86] Default to -mtune=generic unless -march is passed to the driver. Add TuneCPU to the AST serialization

craig.topper created this revision. craig.topper added reviewers: spatel, erichkeane, RKSimon, echristo, efriedma. craig.topper requested review of this revision. This patch defaults to -mtune=generic unless -march is present. If -march is present we'll use the empty string unless its overridden

[libunwind] 9e32d7b - [libunwind] Remove static_assert / __has_feature macros

Author: Ryan Prichard Date: 2020-08-24T14:07:20-07:00 New Revision: 9e32d7b6e7e6615dbc5049a53f8e2ba03ae0292f URL: https://github.com/llvm/llvm-project/commit/9e32d7b6e7e6615dbc5049a53f8e2ba03ae0292f DIFF: https://github.com/llvm/llvm-project/commit/9e32d7b6e7e6615dbc5049a53f8e2ba03ae0292f.diff

[PATCH] D86376: [HIP] Improve kernel launching latency

tra added a comment. I'm OK with how the patch is implemented. I'm still on the fence regarding whether it should be implemented. In D86376#2234458 , @yaxunl wrote: > `__hipPushConfiguration/__hipPopConfiguration' and kernel stub can cause 40 > ns

[PATCH] D86299: [compiler-rt][builtins] Factor out some common bit manipulations

atrosinenko added inline comments. Comment at: compiler-rt/lib/builtins/int_mulo_impl.inc:22 +// themselves indefinitely when compiled with UBSan. +#if defined(__clang__) +#define NO_UBSAN __attribute__((no_sanitize("undefined"))) MaskRay wrote: > AFAIK

[PATCH] D86299: [compiler-rt][builtins] Factor out some common bit manipulations

atrosinenko updated this revision to Diff 287479. atrosinenko added a comment. Explicilty mention that UBSan have to be manually configured in trap-on-error mode to operate of builtins library. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85697: [clang-tidy] Add cppcoreguidelines-prefer-scoped-enums-over-unscoped

janosbenjaminantal updated this revision to Diff 287478. janosbenjaminantal added a comment. Fix clang-tidy issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85697/new/ https://reviews.llvm.org/D85697 Files:

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

zahen added inline comments. Comment at: clang/test/Driver/cl-options.c:686 +// vctoolsdir is handled by the driver; just check that we don't error. Pass -c because fakedir isn't a real toolchain path +// RUN: %clang_cl -c -vctoolsdir fakedir -- %s 2>&1 + zahen

[PATCH] D85697: [clang-tidy] Add cppcoreguidelines-prefer-scoped-enums-over-unscoped

janosbenjaminantal updated this revision to Diff 287461. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85697/new/ https://reviews.llvm.org/D85697 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D85697: [clang-tidy] Add cppcoreguidelines-prefer-scoped-enums-over-unscoped

janosbenjaminantal added a comment. I addressed all of the review comments. Apart from the small fixes I extended a checker logic. The check collects the following information from every unscoped enum (into the `FoundEnumInfo` struct): 1. **The enum's definition**: Every information from an

[PATCH] D86376: [HIP] Improve kernel launching latency

yaxunl added a comment. In D86376#2234259 , @tra wrote: > How much does this inlining buy you in practice? I.e. what's a typical launch > latency before/after the patch? For CUDA, config push/pop is negligible > compared to the cost of actually

[PATCH] D84414: [RISCV] Support Shadow Call Stack

lenary added a comment. In D84414#2234327 , @pcc wrote: > FWIW, on aarch64 we decided to make `-fsanitize=shadow-call-stack` require > the x18 reservation (instead of implying it) to try to avoid ABI mismatch > problems. That is, it should be safe to

[PATCH] D84414: [RISCV] Support Shadow Call Stack

pcc added a comment. FWIW, on aarch64 we decided to make `-fsanitize=shadow-call-stack` require the x18 reservation (instead of implying it) to try to avoid ABI mismatch problems. That is, it should be safe to mix and match code compiled with and without `-fsanitize=shadow-call-stack`. If we

[PATCH] D86299: [compiler-rt][builtins] Factor out some common bit manipulations

MaskRay added inline comments. Comment at: compiler-rt/lib/builtins/int_mulo_impl.inc:22 +// themselves indefinitely when compiled with UBSan. +#if defined(__clang__) +#define NO_UBSAN __attribute__((no_sanitize("undefined"))) AFAIK LLVM_USE_SANITIZER does not

[PATCH] D84049: Disable use of _ExtInt with '__atomic' builtins

hans added a comment. In D84049#2224061 , @jtmott-intel wrote: > Committed to master, and created bug to cherry pick into 11.0. > > https://bugs.llvm.org/show_bug.cgi?id=47222 Pushed to 11.x as 82e48a579024d0ffbc352702ec0c52b47a6fe691

[PATCH] D86400: [NFC][compiler-rt] Factor out __div[sdt]i3 and __mod[dt]i3 implementations

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86400/new/ https://reviews.llvm.org/D86400 ___

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks.

hoy added a comment. In D86193#2232609 , @wmi wrote: > Thanks for the patch! A few questions: > >> probe blocks some CFG transformations that can mess up profile correlation. > > Can you enumerate some CFG transformations which be blocked? Is it possible

[PATCH] D84414: [RISCV] Support Shadow Call Stack

lenary added a comment. In D84414#2234255 , @zzheng wrote: > In D84414#2234112 , @lenary wrote: > >> Why do we have to pass `-ffixed-x18` when compiling? Is it enough to just >> reserve `x18` whenever the function

[PATCH] D86376: [HIP] Improve kernel launching latency

tra added a comment. How much does this inlining buy you in practice? I.e. what's a typical launch latency before/after the patch? For CUDA, config push/pop is negligible compared to the cost of actually launching the kernel on the GPU. It is measurable if the launch is asynchronous, but

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

zahen added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:73 + MSVCToolChain::ToolsetLayout ) { + // Don't validate the input; trust the value supplied by the user. + // The primary motivation is to prevent unnecessary file and

[PATCH] D84414: [RISCV] Support Shadow Call Stack

zzheng added a comment. In D84414#2234112 , @lenary wrote: > Why do we have to pass `-ffixed-x18` when compiling? Is it enough to just > reserve `x18` whenever the function has the shadow call stack attribute? When SCS is on, x18 must be preserved

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

hans added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:73 + MSVCToolChain::ToolsetLayout ) { + // Don't validate the input; trust the value supplied by the user. + // The primary motivation is to prevent unnecessary file and

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

zahen added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:73 + MSVCToolChain::ToolsetLayout ) { + // Don't validate the input; trust the value supplied by the user. + // The primary motivation is to prevent unnecessary file and

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb added a comment. Ping, I think I've addressed all comments here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 ___ cfe-commits mailing list

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

aganea added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:73 + MSVCToolChain::ToolsetLayout ) { + // Don't validate the input; trust the value supplied by the user. + // The primary motivation is to prevent unnecessary file and

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

hans added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:73 + MSVCToolChain::ToolsetLayout ) { + // Don't validate the input; trust the value supplied by the user. + // The primary motivation is to prevent unnecessary file and

[PATCH] D86223: [analyzer][z3] Use more elaborate Z3 variable names

mikhail.ramalho accepted this revision. mikhail.ramalho added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86223/new/ https://reviews.llvm.org/D86223

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

zahen marked an inline comment as done. zahen added a comment. @hans the explicit path must be declared, all exes and dlls. The unexpected probes for link.exe when invoking clang-cl.exe when it isn't actually going to be invoked are what we want to avoid. Comment at:

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

amyk updated this revision to Diff 287444. amyk added a comment. Update to address clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83500/new/ https://reviews.llvm.org/D83500 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

zahen updated this revision to Diff 287443. zahen added a comment. Good call @aganea on these comments. Updated CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85998/new/ https://reviews.llvm.org/D85998 Files: clang/include/clang/Driver/Options.td

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

hans added a comment. In D85998#2231001 , @zahen wrote: > The build system strives to be deterministic so all file probes need to be > accounted for; environment variables are also problematic. Our builds > deliberately don't run from a Visual Studio

[PATCH] D83088: Introduce CfgTraits abstraction

nhaehnle updated this revision to Diff 287441. nhaehnle added a comment. - cleanup operators on CfgOpaqueType - address other review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83088/new/ https://reviews.llvm.org/D83088 Files:

[PATCH] D84414: [RISCV] Support Shadow Call Stack

lenary added a comment. Why do we have to pass `-ffixed-x18` when compiling? Is it enough to just reserve `x18` whenever the function has the shadow call stack attribute? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84414/new/

[PATCH] D82726: [PowerPC] Implement Vector Count Mask Bits builtins in LLVM/Clang

amyk added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82726/new/ https://reviews.llvm.org/D82726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82725: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang

amyk added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82725/new/ https://reviews.llvm.org/D82725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82727: [PowerPC] Implement Vector Expand Mask builtins in LLVM/Clang

amyk updated this revision to Diff 287434. amyk added a comment. Update clang test names for `vec_expandm`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82727/new/ https://reviews.llvm.org/D82727 Files:

[PATCH] D86473: [clangd] When inserting "using", add "::" in front if that's the style.

adamcz created this revision. adamcz added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. adamcz requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. We guess the style based on the

[PATCH] D84603: Thread safety analysis: More consistent warning message

aaronpuchert added a comment. @aaron.ballman, can you have a look again? I think this change is consistent with what we're already doing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84603/new/ https://reviews.llvm.org/D84603

[PATCH] D86065: [SVE] Make ElementCount members private

fpetrogalli added inline comments. Comment at: llvm/include/llvm/Support/TypeSize.h:56 + friend bool operator>(const ElementCount , const ElementCount ) { +assert(LHS.Scalable == RHS.Scalable && paulwalker-arm wrote: > david-arm wrote: > > ctetreau wrote:

[PATCH] D84414: [RISCV] Support Shadow Call Stack

zzheng updated this revision to Diff 287428. zzheng added a comment. Rebased & ping... IMHO, the patch is in good shape. As we discussed in the bi-weekly meetings, RV32E only has 16 registers. Systems based on RV32E may have limited memory as well. Besides, LLVM does not have full support for

Re: [clang] c9b45ce - [clang][NFC] Fix a GCC warning in ASTImporterTest.cpp

Usually this would be addressed with a "using Base::Function" - makes it clear you aren't intending to override any base behavior, just want to continue to expose the full overload set On Mon, Aug 24, 2020 at 8:11 AM Raphael Isemann via cfe-commits < cfe-commits@lists.llvm.org> wrote: > >

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

eduucaldas updated this revision to Diff 287431. eduucaldas marked 4 inline comments as done. eduucaldas added a comment. - Nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85330/new/ https://reviews.llvm.org/D85330 Files:

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

dblaikie added a comment. In D81347#2080217 , @aprantl wrote: > I was going to ask why make this change, but looking at the patch, it's > pretty obvious :-) Might be worth writing it down for everyone else - isn't exactly obvious to me (though not a

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

eduucaldas updated this revision to Diff 287430. eduucaldas marked an inline comment as done. eduucaldas added a comment. Update tests to dump role Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85330/new/ https://reviews.llvm.org/D85330 Files:

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

aganea added a comment. Thanks, one more minor thing and it should be good to go. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:764 // Check the environment first, since that's probably the user telling us // what they want to use. Please update

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

vsavchenko added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:88 + // structure is preferred. + using ImplType = llvm::SmallVector; + grandinj wrote: > Just curious - if they mostly contain 1

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

zahen updated this revision to Diff 287425. zahen edited reviewers, added: aganea; removed: thakis. zahen added a comment. Updates as requested CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85998/new/ https://reviews.llvm.org/D85998 Files: clang/include/clang/Driver/Options.td

[PATCH] D86470: [SyntaxTree] Use annotations on ClassTemplate_MemberClassDefinition test

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86470 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index:

[PATCH] D86469: [SyntaxTree] Split ConstVolatileQualifiers tests

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86469 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index:

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

grandinj added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:88 + // structure is preferred. + using ImplType = llvm::SmallVector; + Just curious - if they mostly contain 1 or 2 elements, why

[PATCH] D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

tambre added a comment. In D86308#2233934 , @teemperor wrote: > In D86308#2229936 , @tambre wrote: > >> In D86308#2229901 , @teemperor >> wrote: >> >>> Sorry, just got

[PATCH] D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

tambre updated this revision to Diff 287421. tambre added a comment. Gate Apple workaround behind CMake version 3.19 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86308/new/ https://reviews.llvm.org/D86308 Files: clang/runtime/CMakeLists.txt

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

sepavloff added a comment. In D85960#2218798 , @kpn wrote: > You mentioned in D85920 a need to merge > this review with that review. I don't think that's needed. This code here is > farther along. It does everything

[PATCH] D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

teemperor added a comment. In D86308#2229936 , @tambre wrote: > In D86308#2229901 , @teemperor wrote: > >> Sorry, just got around to check this out. With the new workaround this seems >> to work on macOS (the

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

martong planned changes to this revision. martong added a comment. Planning to rebase this on a dependent patch that uses an API with Optionals. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84415/new/ https://reviews.llvm.org/D84415

[PATCH] D86467: [SyntaxTree] Split `MemberPointer` tests with annotations

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86467 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index:

[PATCH] D82663: [CodeGen] Have CodeGen for fixed-point unsigned with padding emit signed operations.

ebevhan abandoned this revision. ebevhan added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82663/new/ https://reviews.llvm.org/D82663 ___ cfe-commits mailing list

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

martong added a comment. Thanks @balazske for your comments, you always make an assiduous review! Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:350 + } else { +*this = Signature(Args, *RetTy); } balazske

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

martong updated this revision to Diff 287409. martong marked 4 inline comments as done. martong added a comment. - Remove private ctor of Signature - Assert a valid signature in Signature::matces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin, xazax.hun, Szelethus, ASDenysPetrov, steakhal. Herald added subscribers: cfe-commits, martong, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, mgrang, rnkovacs, szepet, baloghadamsoftware. Herald added a

[PATCH] D85762: [OPENMP]Do not allow threadprivates as base for array-like reduction.

ABataev updated this revision to Diff 287406. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85762/new/ https://reviews.llvm.org/D85762 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D86424: [clang] Do not consider the template arguments of bases to be bases themselves

nridge added inline comments. Comment at: clang/lib/Index/IndexTypeSourceInfo.cpp:167 +if (!TraverseTemplateName(TL.getTypePtr()->getTemplateName())) + return false; + hokein wrote: > nit: this could be simplified by calling the >

[PATCH] D85635: [clangd] Compute the inactive code range for semantic highlighting.

hokein updated this revision to Diff 287405. hokein marked an inline comment as done. hokein added a comment. Herald added a subscriber: mgrang. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85635/new/

[clang] c9b45ce - [clang][NFC] Fix a GCC warning in ASTImporterTest.cpp

Author: Raphael Isemann Date: 2020-08-24T17:10:55+02:00 New Revision: c9b45ce1fd97531c228e092bedee719b971f82a3 URL: https://github.com/llvm/llvm-project/commit/c9b45ce1fd97531c228e092bedee719b971f82a3 DIFF:

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

steakhal added a comment. In D86295#2233694 , @vsavchenko wrote: > And what is the error right now? F12760388: error.txt BTW this sort of ping-pong should be done on a different forum, eg. on the Static Analyzer

[PATCH] D84887: [OPENMP]Fix codegen for is_device_ptr component, captured by reference.

ABataev updated this revision to Diff 287396. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84887/new/ https://reviews.llvm.org/D84887 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[clang] 512e256 - [PowerPC] Add clang options to control MMA support

Author: Baptiste Saleil Date: 2020-08-24T09:35:55-05:00 New Revision: 512e256c0d8c0fed5b4603ed5ed74b6ad503f368 URL: https://github.com/llvm/llvm-project/commit/512e256c0d8c0fed5b4603ed5ed74b6ad503f368 DIFF:

[PATCH] D81442: [PowerPC] Add clang options to control MMA support

This revision was automatically updated to reflect the committed changes. Closed by commit rG512e256c0d8c: [PowerPC] Add clang options to control MMA support (authored by bsaleil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81442/new/

[PATCH] D86135: [analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to __VA_ARGS__

xazax.hun added a comment. Is this related to https://bugs.llvm.org/show_bug.cgi?id=44493? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86135/new/ https://reviews.llvm.org/D86135 ___ cfe-commits

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

vsavchenko added a comment. In D86295#2233666 , @steakhal wrote: > In D86295#2233401 , @vsavchenko > wrote: > >> Yep, I guess that is the cause. I'll take a look. Did you try it with this >> fast fix? > > I

[PATCH] D86459: [SyntaxTree] Split `ParametersAndQualifiers` tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4baa163c7423: [SyntaxTree] Split `ParametersAndQualifiers` tests (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D86443: [SyntaxTree] Group tests related to `using`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG90f85dfc14bc: [SyntaxTree] Group tests related to `using` (authored by eduucaldas). Changed prior to commit:

[clang] a722d6a - [SyntaxTree] Split ExplicitTemplateInstantiation test

Author: Eduardo Caldas Date: 2020-08-24T14:31:45Z New Revision: a722d6a197c7a4f7a1afb72b4732b8ebe8272628 URL: https://github.com/llvm/llvm-project/commit/a722d6a197c7a4f7a1afb72b4732b8ebe8272628 DIFF: https://github.com/llvm/llvm-project/commit/a722d6a197c7a4f7a1afb72b4732b8ebe8272628.diff

[clang] ed83095 - [SyntaxTree] Use annotations to reduce noise on member function tests

Author: Eduardo Caldas Date: 2020-08-24T14:31:45Z New Revision: ed83095254a3e212d14b293a6a0e6c85d1f3331c URL: https://github.com/llvm/llvm-project/commit/ed83095254a3e212d14b293a6a0e6c85d1f3331c DIFF: https://github.com/llvm/llvm-project/commit/ed83095254a3e212d14b293a6a0e6c85d1f3331c.diff

[clang] 90f85df - [SyntaxTree] Group tests related to `using`

Author: Eduardo Caldas Date: 2020-08-24T14:31:46Z New Revision: 90f85dfc14bc6020486eb2d2c6399f8207ef3625 URL: https://github.com/llvm/llvm-project/commit/90f85dfc14bc6020486eb2d2c6399f8207ef3625 DIFF: https://github.com/llvm/llvm-project/commit/90f85dfc14bc6020486eb2d2c6399f8207ef3625.diff

[clang] 4baa163 - [SyntaxTree] Split `ParametersAndQualifiers` tests

Author: Eduardo Caldas Date: 2020-08-24T14:31:46Z New Revision: 4baa163c74237b30c5094c1fafd7ed355575bcfa URL: https://github.com/llvm/llvm-project/commit/4baa163c74237b30c5094c1fafd7ed355575bcfa DIFF: https://github.com/llvm/llvm-project/commit/4baa163c74237b30c5094c1fafd7ed355575bcfa.diff

[PATCH] D86439: [SyntaxTree] Use annotations to reduce noise on member function tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed83095254a3: [SyntaxTree] Use annotations to reduce noise on member function tests (authored by eduucaldas). Repository: rG LLVM Github Monorepo

[PATCH] D86437: [SyntaxTree] Split array declarator tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e8dd506e666: [SyntaxTree] Split array declarator tests (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 235f9f7 - [SyntaxTree] Split `DynamicExceptionSpecification` test

Author: Eduardo Caldas Date: 2020-08-24T14:31:46Z New Revision: 235f9f7fe94488904a60a8a1f5430183b0504945 URL: https://github.com/llvm/llvm-project/commit/235f9f7fe94488904a60a8a1f5430183b0504945 DIFF: https://github.com/llvm/llvm-project/commit/235f9f7fe94488904a60a8a1f5430183b0504945.diff

[PATCH] D86441: [SyntaxTree] Split ExplicitTemplateInstantiation test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa722d6a197c7: [SyntaxTree] Split ExplicitTemplateInstantiation test (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE

  1   2   >