[PATCH] D88526: [clang][Sema] Fix PR47676: Handle dependent AltiVec C-style cast

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: pkubaj, nemanjai, jasonliu, aaron.ballman. Herald added a project: clang. hubert.reinterpretcast requested review of this revision. Fix premature decision in the presence of type-dependent expression operands

[PATCH] D88518: Recognize setjmp and friends as builtins even if jmp_buf is not declared yet.

tambre added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88518/new/ https://reviews.llvm.org/D88518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

The change https://reviews.llvm.org/rG4e4f926e83cf removes the problematic test. Sorry for troubles. Thanks, --Serge On Wed, Sep 30, 2020 at 2:55 AM Petr Hosek via Phabricator < revi...@reviews.llvm.org> wrote: > phosek added a comment. > > In D87822#2301293

[clang] 4e4f926 - Remove test AST/const-fpfeatures-diag.c

Author: Serge Pavlov Date: 2020-09-30T11:07:55+07:00 New Revision: 4e4f926e83cf77f0d36b821a3d2aa1de78338a82 URL: https://github.com/llvm/llvm-project/commit/4e4f926e83cf77f0d36b821a3d2aa1de78338a82 DIFF: https://github.com/llvm/llvm-project/commit/4e4f926e83cf77f0d36b821a3d2aa1de78338a82.diff

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

nickdesaulniers added a comment. bumping for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87956/new/ https://reviews.llvm.org/D87956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88469: [clangd] Heuristic resolution for dependent type and template names

nridge added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:128 const auto ValueFilter = [](const NamedDecl *D) { return isa(D); }; +const auto TypeFilter = [](const NamedDecl *D) { return !isa(D); }; hokein wrote: > why not using

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. In D54943#2292377 , @0x8000- wrote: > In D54943#2291969 , @JonasToth wrote: > >> @AlexanderLanin @0x8000- i created the branch `release-11-const` >>

[clang] 6f01c53 - Remove further OpenBSD/sparc bits

Author: Brad Smith Date: 2020-09-29T22:17:12-04:00 New Revision: 6f01c53f26af7fb0393464079ec5e839a497d4da URL: https://github.com/llvm/llvm-project/commit/6f01c53f26af7fb0393464079ec5e839a497d4da DIFF: https://github.com/llvm/llvm-project/commit/6f01c53f26af7fb0393464079ec5e839a497d4da.diff

[PATCH] D88377: Diagnose invalid target ID for AMDGPU toolchain for assembler

yaxunl updated this revision to Diff 295163. yaxunl marked an inline comment as done. yaxunl added a comment. fix bug CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88377/new/ https://reviews.llvm.org/D88377 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp

[PATCH] D88524: [CUDA][HIP] Fix bound arch for offload action for fat binary

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Currently CUDA/HIP toolchain uses "unknown" as bound arch for offload action for fat binary. This causes -mcpu or -march with "unknown" added in HIPToolChain::TranslateArgs or

[clang] d04775e - Add remquo, frexp and modf overload functions to HIP header

Author: Yaxun (Sam) Liu Date: 2020-09-29T20:57:56-04:00 New Revision: d04775e16bba456f0be0aaa7478959c5bfa22c41 URL: https://github.com/llvm/llvm-project/commit/d04775e16bba456f0be0aaa7478959c5bfa22c41 DIFF:

[PATCH] D88522: [DebugInfo] Add types from constructor homing to the retained types list.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c4fc581d5fe: [DebugInfo] Add types from constructor homing to the retained types list. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5c4fc58 - [DebugInfo] Add types from constructor homing to the retained types list.

Author: Amy Huang Date: 2020-09-29T17:00:45-07:00 New Revision: 5c4fc581d5fe8427f03ec90b0d745453398aa3ad URL: https://github.com/llvm/llvm-project/commit/5c4fc581d5fe8427f03ec90b0d745453398aa3ad DIFF: https://github.com/llvm/llvm-project/commit/5c4fc581d5fe8427f03ec90b0d745453398aa3ad.diff

[PATCH] D88497: [objc] Fix memory leak in CGObjCMac.cpp

rjmccall added a comment. Committed (with substantial changes) as 984744a1314ce165378e7945bc45995302a8cb80 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88497/new/

[clang] 984744a - Fix a variety of minor issues with ObjC method mangling:

Author: John McCall Date: 2020-09-29T19:51:53-04:00 New Revision: 984744a1314ce165378e7945bc45995302a8cb80 URL: https://github.com/llvm/llvm-project/commit/984744a1314ce165378e7945bc45995302a8cb80 DIFF: https://github.com/llvm/llvm-project/commit/984744a1314ce165378e7945bc45995302a8cb80.diff

[PATCH] D88522: [DebugInfo] Add types from constructor homing to the retained types list.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88522/new/ https://reviews.llvm.org/D88522

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 295149. atmnpatel added a comment. Fixing buildkite build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp

[PATCH] D88522: [DebugInfo] Add types from constructor homing to the retained types list.

akhuang created this revision. akhuang added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang requested review of this revision. Add class types to the retained types list to make sure they don't get dropped if the constructor is optimized out

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel marked 3 inline comments as done. atmnpatel added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:801 + getLangOpts().CPlusPlus11 || getLangOpts().CPlusPlus14 || + getLangOpts().CPlusPlus17 || getLangOpts().C2x) { +MustProgress =

[clang] 1c604a9 - Recognize setjmp and friends as builtins even if jmp_buf is not declared yet.

Author: Richard Smith Date: 2020-09-29T15:53:17-07:00 New Revision: 1c604a9f5fd65c91f097c856fa6643373fc869e1 URL: https://github.com/llvm/llvm-project/commit/1c604a9f5fd65c91f097c856fa6643373fc869e1 DIFF: https://github.com/llvm/llvm-project/commit/1c604a9f5fd65c91f097c856fa6643373fc869e1.diff

[PATCH] D88518: Recognize setjmp and friends as builtins even if jmp_buf is not declared yet.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c604a9f5fd6: Recognize setjmp and friends as builtins even if jmp_buf is not declared yet. (authored by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith added a comment. In D67678#1856229 , @rsmith wrote: > In D67678#1836953 , @dexonsmith > wrote: > >> In D67678#1836922 , @rsmith wrote: >> >>> If there's no timeline

[PATCH] D88518: Recognize setjmp and friends as builtins even if jmp_buf is not declared yet.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. I like this better as a fix for PR40692 anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88518/new/

[PATCH] D88500: [AIX][Clang][Driver] Link libm in c++ mode

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with minor comments. Comment at: clang/test/Driver/aix-ld.c:406 // CHECK-LD32-NOSTDLIBXX-LCXX:

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

rsmith added a comment. In D77491#2300013 , @rjmccall wrote: > Being permissive about recognizing builtins when the expected signature > requires a type that lookup can't find seems completely reasonable. We don't > really want to force library

[PATCH] D88518: Recognize setjmp and friends as builtins even if jmp_buf is not declared yet.

rsmith created this revision. rsmith added reviewers: tambre, rjmccall. Herald added a project: clang. rsmith requested review of this revision. This happens in glibc's headers. It's important that we recognize these functions so that we can mark them as returns_twice. Repository: rG LLVM

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

alanphipps added a comment. In D84467#2264205 , @vsk wrote: > @alanphipps thanks for bearing with me. I think this is about ready to land. > I do ask that you back out any punctuation/whitespace changes in code/tests > that aren't directly modified in

[PATCH] D88265: Fix comma with half vectors.

arames added a comment. I do not have commit rights, so it would be great if you can land it. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88265/new/ https://reviews.llvm.org/D88265 ___

[PATCH] D88446: docs: add documentation describing API Notes

rsmith added a comment. Broadly, it seems reasonable to me for Clang to support this. I have no major concerns with the overall approach here, and it seems like you already have sufficient implementation experience with this approach to know that it's going to work out well in practice. I'm

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 updated this revision to Diff 295120. jhuber6 added a comment. Adding check for Windows file path. Updating some files after rebasing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87946/new/ https://reviews.llvm.org/D87946 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 295119. atmnpatel added a comment. NFC fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp

[PATCH] D88265: Fix comma with half vectors.

arames updated this revision to Diff 295116. arames added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88265/new/ https://reviews.llvm.org/D88265 Files: clang/lib/Sema/SemaExpr.cpp

[PATCH] D88500: [AIX][Clang][Driver] Link libm in c++ mode

daltenty updated this revision to Diff 295111. daltenty marked an inline comment as done. daltenty added a comment. - Make dependant on just c++ mode - Add missing colons Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88500/new/

[PATCH] D88297: [clangd] Trivial setter support when moving items to fields

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01a30fa6787d: [clangd] Trivial setter support when moving items to fields (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] 01a30fa - [clangd] Trivial setter support when moving items to fields

Author: Nathan James Date: 2020-09-29T21:51:15+01:00 New Revision: 01a30fa6787d8375e1df573150f9927561b0a0f1 URL: https://github.com/llvm/llvm-project/commit/01a30fa6787d8375e1df573150f9927561b0a0f1 DIFF: https://github.com/llvm/llvm-project/commit/01a30fa6787d8375e1df573150f9927561b0a0f1.diff

[PATCH] D88500: [AIX][Clang][Driver] Link libm when we would libc++

daltenty updated this revision to Diff 295107. daltenty added a comment. - Add blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88500/new/ https://reviews.llvm.org/D88500 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D88500: [AIX][Clang][Driver] Link libm when we would libc++

daltenty updated this revision to Diff 295105. daltenty added a comment. - Remove deps comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88500/new/ https://reviews.llvm.org/D88500 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

chrish_ericsson_atx reopened this revision. chrish_ericsson_atx added a comment. This revision is now accepted and ready to land. Reverted due to another obscure test failure. Working to diagnose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88507: [clangd][remote] Make sure relative paths are absolute with respect to posix style

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Ahh, good catch! Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88507/new/ https://reviews.llvm.org/D88507

[clang] 155d2d5 - Revert "[Sema] Address-space sensitive check for unbounded arrays (v2)"

Author: Chris Hamilton Date: 2020-09-29T22:46:14+02:00 New Revision: 155d2d5300551c6ac26eaeef259d73d62f939d0b URL: https://github.com/llvm/llvm-project/commit/155d2d5300551c6ac26eaeef259d73d62f939d0b DIFF:

[PATCH] D88265: Fix comma with half vectors.

ahatanak accepted this revision. ahatanak added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Sema/fp16vec-sema.c:33 + 1, hv0; // expected-warning 2 {{expression result unused}} // Implicit conversion between half vectors and

[PATCH] D88333: Better diagnostics for anonymous bit-fields with attributes or an initializer

aaron.ballman closed this revision. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Thank you for the reviews, I've committed in 538762fef0b662048be2a261ebc12da249efa977

[clang] 538762f - Better diagnostics for anonymous bit-fields with attributes or an initializer.

Author: Aaron Ballman Date: 2020-09-29T16:32:20-04:00 New Revision: 538762fef0b662048be2a261ebc12da249efa977 URL: https://github.com/llvm/llvm-project/commit/538762fef0b662048be2a261ebc12da249efa977 DIFF: https://github.com/llvm/llvm-project/commit/538762fef0b662048be2a261ebc12da249efa977.diff

[PATCH] D88498: [FPEnv] Evaluate initializers in constant rounding mode

mibintc added inline comments. Comment at: clang/test/AST/const-fpfeatures-strict.c:39 + +// CHECK: @var_04 = {{.*}} %struct.S { float 0x3FF02000 } +// CHECK: @var_05 = {{.*}} %struct.S { float 0x3FF02000 } I think the initializer for var_04 is

[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

phosek added a comment. In D87822#2301293 , @sepavloff wrote: > In D87822#2301194 , @leonardchan > wrote: > >> Thanks for looking into it. We have that commit but it still seems to be >> failing for us with the

[PATCH] D88297: [clangd] Trivial setter support when moving items to fields

kadircet accepted this revision. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:466 +auto *ND = llvm::dyn_cast(CE->getCalleeDecl()); +if (!ND) + return llvm::None; njames93 wrote: > kadircet wrote: > > nit: combine

[PATCH] D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally

NoQ added a comment. A load from a region of type `T` should always yield a value of type `T` because that's what a load is. I'd rather have it as an assertion: if the region is typed, the type shouldn't be specified. If such assertion is hard to satisfy, we could allow the same canonical

[PATCH] D88445: Use "default member initializer" instead of "in-class initializer" for diagnostics

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the review! I've commit in 15fbae8ac303d8601ea95418d4818cb50d0765e1 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88445/new/

[clang] 15fbae8 - Use "default member initializer" instead of "in-class initializer" for diagnostics.

Author: Aaron Ballman Date: 2020-09-29T15:04:23-04:00 New Revision: 15fbae8ac303d8601ea95418d4818cb50d0765e1 URL: https://github.com/llvm/llvm-project/commit/15fbae8ac303d8601ea95418d4818cb50d0765e1 DIFF: https://github.com/llvm/llvm-project/commit/15fbae8ac303d8601ea95418d4818cb50d0765e1.diff

[PATCH] D88500: [AIX][Clang][Driver] Link libm along with libc++

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:165 +// Since libc++ has dependencies on libm, if we have one then add the other. +if (getToolChain().ShouldLinkCXXStdlib(Args)) Is that right? My check of

[PATCH] D88497: [objc] Fix memory leak in CGObjCMac.cpp

JDevlieghere added a comment. Thanks for updating the comment in dsymutil! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88497/new/ https://reviews.llvm.org/D88497 ___ cfe-commits mailing list

[clang-tools-extra] 962a247 - [clangd] Fix assertion in remote-index marshalling

Author: Kadir Cetinkaya Date: 2020-09-29T20:40:19+02:00 New Revision: 962a247aebba39bc8f2d6aa901ed512f5c09dc72 URL: https://github.com/llvm/llvm-project/commit/962a247aebba39bc8f2d6aa901ed512f5c09dc72 DIFF:

[PATCH] D88507: [clangd][remote] Make sure relative paths are absolute with respect to posix style

kadircet created this revision. kadircet added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Relative paths received from the server are

[PATCH] D77598: Integral template argument suffix and cast printing

rnk added inline comments. Comment at: clang/lib/AST/TemplateBase.cpp:71-72 if (T->isBooleanType() && !Policy.MSVCFormatting) { Out << (Val.getBoolValue() ? "true" : "false"); } else if (T->isCharType()) { rsmith wrote: > reikdas wrote: > > rsmith

[PATCH] D88445: Use "default member initializer" instead of "in-class initializer" for diagnostics

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88445/new/ https://reviews.llvm.org/D88445 ___ cfe-commits mailing list

[PATCH] D88497: [objc] Fix memory leak in CGObjCMac.cpp

ellis updated this revision to Diff 295055. ellis added a subscriber: vsapsai. ellis added a comment. Herald added a reviewer: JDevlieghere. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Fix a comment to reference the correct method. Thanks to @vsapsai for pointing this

[PATCH] D88403: Migrate Declarators to use the List API

eduucaldas updated this revision to Diff 295053. eduucaldas added a comment. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88403/new/ https://reviews.llvm.org/D88403 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

vsapsai added inline comments. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:929 - /// \param[out] NameOut - The return value. - void GetNameForMethod(const ObjCMethodDecl *OMD, -const ObjCContainerDecl *CD, Note that the removed method

[PATCH] D87737: Add -fprofile-update={atomic,prefer-atomic,single}

This revision was automatically updated to reflect the committed changes. Closed by commit rG3681be876fea: Add -fprofile-update={atomic,prefer-atomic,single} (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D87737?vs=294781=295042#toc Repository: rG LLVM Github

[clang] 3681be8 - Add -fprofile-update={atomic,prefer-atomic,single}

Author: Fangrui Song Date: 2020-09-29T10:43:23-07:00 New Revision: 3681be876fea9b270c7a1d2dc41679a399610e06 URL: https://github.com/llvm/llvm-project/commit/3681be876fea9b270c7a1d2dc41679a399610e06 DIFF: https://github.com/llvm/llvm-project/commit/3681be876fea9b270c7a1d2dc41679a399610e06.diff

[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

sepavloff added a comment. In D87822#2301194 , @leonardchan wrote: > Thanks for looking into it. We have that commit but it still seems to be > failing for us with the same error. In D88498 this test is removed because

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

erichkeane resigned from this revision. erichkeane added a comment. I'm not really a good person to review this, OMP isn't nearly my expertise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88430/new/ https://reviews.llvm.org/D88430

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 updated this revision to Diff 295032. jhuber6 added a reviewer: erichkeane. jhuber6 added a comment. Adding test cases for incompatible architecture messages. Checking the architecture is done by checking all combinations of architectures. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

ArcsinX closed this revision. ArcsinX added a comment. Don't know why this didn't close automatically Commit: https://reviews.llvm.org/rGd8ba6b4ab3eceb6bbcdf4371d4ffaab9d1a5cebe Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87891/new/

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

rjmccall added a comment. Richard and I had a long conversation about this further up-thread, if you missed it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87528/new/ https://reviews.llvm.org/D87528 ___ cfe-commits mailing list

[PATCH] D88498: [FPEnv] Evaluate initializers in constant rounding mode

rsmith requested changes to this revision. rsmith added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Parse/ParseDecl.cpp:2290 + // rounding mode. + if (VD->isFileVarDecl() || VD->isConstexpr() || +

[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

rjmccall added a comment. Commented in that review, but that patch has the wrong fix: it's based on the targets LLVM is configured with rather than the current test target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87822/new/

Re: [PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

Thanks for looking into it. We have that commit but it still seems to be failing for us with the same error. On Tue, Sep 29, 2020 at 12:58 AM Serge Pavlov wrote: > Hi! > > This issue must be fixed by: https://reviews.llvm.org/rGf91b9c0f9858 > Do you have recent changes from the trunk? > >

[PATCH] D88265: Fix comma with half vectors.

arames updated this revision to Diff 295025. arames marked an inline comment as done. arames added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88265/new/ https://reviews.llvm.org/D88265 Files:

[clang-tools-extra] d8ba6b4 - [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

Author: Aleksandr Platonov Date: 2020-09-29T19:54:55+03:00 New Revision: d8ba6b4ab3eceb6bbcdf4371d4ffaab9d1a5cebe URL: https://github.com/llvm/llvm-project/commit/d8ba6b4ab3eceb6bbcdf4371d4ffaab9d1a5cebe DIFF:

[PATCH] D88265: Fix comma with half vectors.

arames marked 2 inline comments as done. arames added inline comments. Comment at: clang/test/Sema/fp16vec-sema.c:29 sv0 = hv0 >= hv1; + hv0, 1; // expected-warning 2 {{expression result unused}} sv0 = hv0 || hv1; // expected-error{{logical expression with vector types

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

Szelethus added a comment. In D72705#2274568 , @balazske wrote: > I am not sure if this checker is worth to further development. A part of the > found bugs can be detected with other checkers too, specially if the > preconditions of many standard

[PATCH] D88497: [objc] Fix memory leak in CGObjCMac.cpp

ellis added a comment. Yes please commit for me :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88497/new/ https://reviews.llvm.org/D88497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88497: [objc] Fix memory leak in CGObjCMac.cpp

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Oh, oops, I should've caught this in review. I assume you still need a commit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88497/new/

[PATCH] D88500: [AIX][Clang][Driver] Link libm along with libc++

daltenty created this revision. daltenty added reviewers: hubert.reinterpretcast, DiggerLin. Herald added a project: clang. Herald added a subscriber: cfe-commits. daltenty requested review of this revision. since libc++ has dependencies on libm. Repository: rG LLVM Github Monorepo

[PATCH] D88462: FP math settings for static duration initialization - work in progress

mibintc abandoned this revision. mibintc added a comment. refer to https://reviews.llvm.org/D88498 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88462/new/ https://reviews.llvm.org/D88462 ___

[PATCH] D88498: [FPEnv] Evaluate initializers in constant rounding mode

mibintc accepted this revision. mibintc added a comment. This revision is now accepted and ready to land. thanks for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88498/new/ https://reviews.llvm.org/D88498

[PATCH] D88359: [analyzer][RFC] Complete rewrite of ArrayBoundCheckerV2

steakhal added a comment. Thank you for your time @balazske! Your catches were really valuable. Comment at: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:61 + + return NeedsExtraBitToPreserveSigness ? Signed : ExtendedSigned; +} balazske wrote: >

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:801 + getLangOpts().CPlusPlus11 || getLangOpts().CPlusPlus14 || + getLangOpts().CPlusPlus17 || getLangOpts().C2x) { +MustProgress = true; Also in C? And C2x in

[PATCH] D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally

steakhal added a comment. In D88477#2300687 , @martong wrote: >> In this example, it cast to the `unsigned char` (which is the type of the >> stored value of `**b`, stored at `#1`) instead of the static type of the >> access (the type of `**b` is

[PATCH] D88462: FP math settings for static duration initialization - work in progress

sepavloff added a comment. Please look at D88498 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88462/new/ https://reviews.llvm.org/D88462 ___ cfe-commits mailing list

[PATCH] D88498: [FPEnv] Evaluate initializers in constant rounding mode

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, mibintc. Herald added a project: clang. sepavloff requested review of this revision. Previously initializers were evaluated using rounding mode currently specified by Sema. If at the same time FP exception behavior was

[clang] 1192747 - NFC, add a missing stdlib include for the use of abort

Author: Alex Lorenz Date: 2020-09-29T08:50:51-07:00 New Revision: 119274748bce6d1248aa57cb55d79bfeae8a2f8e URL: https://github.com/llvm/llvm-project/commit/119274748bce6d1248aa57cb55d79bfeae8a2f8e DIFF: https://github.com/llvm/llvm-project/commit/119274748bce6d1248aa57cb55d79bfeae8a2f8e.diff

[clang-tools-extra] a9f63d2 - [clangd] Disable msan instrumentation for generated Evaluate().

Author: Utkarsh Saxena Date: 2020-09-29T17:44:10+02:00 New Revision: a9f63d22fafb0d7de768efc6b7447f8e7f6bb220 URL: https://github.com/llvm/llvm-project/commit/a9f63d22fafb0d7de768efc6b7447f8e7f6bb220 DIFF:

[PATCH] D88495: [clangd] Disable msan instrumentation for generated Evaluate().

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9f63d22fafb: [clangd] Disable msan instrumentation for generated Evaluate(). (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78938: Make LLVM build in C++20 mode

dblaikie added inline comments. Comment at: llvm/include/llvm/IR/BasicBlock.h:324-325 +template ::value>> phi_iterator_impl(const phi_iterator_impl ) dblaikie wrote: > Quuxplusone wrote: > > BRevzin wrote: > > > dblaikie wrote: > > > > BRevzin wrote: >

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

ellis added a comment. https://reviews.llvm.org/D88497 will fix the leak Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88329/new/ https://reviews.llvm.org/D88329 ___ cfe-commits mailing list

[PATCH] D88497: [objc] Fix memory leak in CGObjCMac.cpp

ellis created this revision. ellis added a reviewer: rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. ellis requested review of this revision. A memory leak was introduced in https://reviews.llvm.org/D88329 CGObjCMac.cpp was leaking a MangleContext everytime it

[PATCH] D88495: [clangd] Disable msan instrumentation for generated Evaluate().

usaxena95 updated this revision to Diff 295005. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88495/new/ https://reviews.llvm.org/D88495 Files:

[PATCH] D88359: [analyzer][RFC] Complete rewrite of ArrayBoundCheckerV2

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:61 + + return NeedsExtraBitToPreserveSigness ? Signed : ExtendedSigned; +} Should not the `ExtendedSigned` be in the true branch? Comment

[PATCH] D88495: [clangd] Disable msan instrumentation for generated Evaluate().

adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/quality/CompletionModelCodegen.py:164 +LLVM_NO_SANITIZE("memory") float Evaluate(const %s&); Please add a

[PATCH] D88495: [clangd] Disable msan instrumentation for generated Evaluate().

usaxena95 created this revision. usaxena95 added a reviewer: adamcz. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. MSAN build times out for generated

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

ellis added a comment. Oops, I meant to create a new commit rather than amend to this one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88329/new/ https://reviews.llvm.org/D88329 ___ cfe-commits mailing

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

ellis updated this revision to Diff 295000. ellis added a comment. [objc] Fix memory leak in CGObjCMac.cpp CGObjCMac.cpp was leaking a MangleContext everytime it mangled an ObjC method. We now have an instance variable that allocates and deallocates the context. Repository: rG LLVM Github

[PATCH] D70378: [LLD][COFF] Cover usage of LLD as a library

ayrivera added inline comments. Comment at: lld/ELF/Driver.cpp:895 const char *argv[] = {config->progName.data(), opt.data()}; + cl::ResetAllOptionOccurrences(); if (cl::ParseCommandLineOptions(2, argv, "", )) aganea wrote: > ayrivera wrote: > > MaskRay

[PATCH] D88491: [ASTContext] Use AllowCXX in all merge*Type methods, strip references

jdoerfert created this revision. jdoerfert added a reviewer: aaron.ballman. Herald added a subscriber: bollu. Herald added a project: clang. jdoerfert requested review of this revision. Add and pass AllowCXX not only in mergeFunctionTypes but all merge*Type methods. Use it to determine if

[PATCH] D88434: [clangd] Improve PopulateSwitch tweak to work on non-empty switches

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fb303f340e2: [clangd] Improve PopulateSwitch tweak to work on non-empty switches (authored by tdeo, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 4fb303f - [clangd] Improve PopulateSwitch tweak to work on non-empty switches

Author: Tadeo Kondrak Date: 2020-09-29T16:37:51+02:00 New Revision: 4fb303f340e2c55783f9b0f3ed33fa2c36360acf URL: https://github.com/llvm/llvm-project/commit/4fb303f340e2c55783f9b0f3ed33fa2c36360acf DIFF: https://github.com/llvm/llvm-project/commit/4fb303f340e2c55783f9b0f3ed33fa2c36360acf.diff

[PATCH] D88489: [clangd] Mark code action as "preferred" if it's the sole quickfix action

sammccall created this revision. sammccall added a reviewer: usaxena95. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo

[PATCH] D88260: [NFC][FE] Replace TypeSize with StorageUnitSize

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1749-1750 -// Otherwise, allocate just the number of bytes required to store -// the bitfield. +

  1   2   >