[clang-tools-extra] 79fbcbf - [clangd] clangd --check: standalone diagnosis of common problems

Author: Sam McCall Date: 2020-10-01T15:47:47+02:00 New Revision: 79fbcbff41734e3d07e6200d33c3e40732dfae6a URL: https://github.com/llvm/llvm-project/commit/79fbcbff41734e3d07e6200d33c3e40732dfae6a DIFF: https://github.com/llvm/llvm-project/commit/79fbcbff41734e3d07e6200d33c3e40732dfae6a.diff LO

[PATCH] D88314: Added llvm-string-referencing check

bogser01 updated this revision to Diff 295553. bogser01 added a comment. Fixed failing unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88314/new/ https://reviews.llvm.org/D88314 Files: clang-tools-extra/clang-tidy/llvm/CMakeLists.txt c

[PATCH] D88634: [clangd] Extend the rename API.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:408 return CB(InpAST.takeError()); -auto &AST = InpAST->AST; -const auto &SM = AST.getSourceManager(); -auto Loc = sourceLocationInMainFile(SM, Pos); -if (!Loc) - re

[PATCH] D88613: [flang] Semantic analysis for FINAL subroutines

klausler updated this revision to Diff 295423. klausler added a comment. Previous update to this review had inadvertent changes to other files because I neglected to rebase after updating master; now fixed. Sorry for the scare! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77062: [analyzer] Improve zero assumption in CStringChecke::assumeZero

ASDenysPetrov added a comment. @steakhal > @ASDenysPetrov Do you still want to rework the API of the `assumeZero`? This patch more looks like NFC, being just refactored. Actually I see that if we find and fix the root cause, we can freely refuse this patch. Another thing I see is that this patc

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

balazske marked 12 inline comments as done. balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:95 + std::deque> CalledFunctions{ + {HandlerDecl, HandlerExpr}}; + baloghadamsoftware wrote: > Do we really need

[PATCH] D88640: [Format] Don't treat compound extension headers (foo.proto.h) as foo.cc main file.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Inclusions/HeaderIncludes.cpp:237 + + StringRef HeaderStem = + llvm::sys::path::stem(IncludeName.drop_front(1).drop_back( --

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

balazske updated this revision to Diff 295538. balazske added a comment. Added support for C++ code. Improved detection of 'signal' function. Simplified collection of called functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87449/new/ https:

[PATCH] D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry.

fmayer added a comment. I do not have commit access. Could someone submit this patch please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83144/new/ https://reviews.llvm.org/D83144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D88648: Refactor fixed point conversion test.

ebevhan created this revision. Herald added subscribers: cfe-commits, bjope. Herald added a project: clang. ebevhan requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D88648 Files: clang/test/Frontend/fixed_point_conversions.c clang/test/Fronten

Re: [PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

Hi Louis, ARM and AArch64 libcxx bots are still broken after this commit (host compiler is clang-8), logs are available here: http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-aarch64-linux/builds/3143 Cheers, Yvan On Mon, 28 Sep 2020 at 23:44, Louis Dionne via Phabricator via cfe-com

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

Tyker created this revision. Tyker added a reviewer: aaron.ballman. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Tyker requested review of this revision. Herald added a subscriber: jdoerfert. This allows using annotation in a much more contexts than it c

[PATCH] D88643: [NFC] Correct name of profile function to Profile in APValue

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Tyker requested review of this revision. Capitalize the profile function of APValue such that it can be used by FoldingSetNodeID Repository: rG LLVM Github Monor

[PATCH] D88640: [Format] Don't treat compound extension headers (foo.proto.h) as foo.cc main file.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. hokein requested review of this revision. We receive internal bugs about this false positives after D86597 . Repository: rG LLVM Github Monorepo https://reviews.l

[PATCH] D88567: [clangd] Fix invalid UTF8 when extracting doc comments.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:93 + // Clang requires source to be UTF-8, but doesn't enforce this in comments. + if (!llvm::json::isUTF8(Doc)) +Doc = llvm::json::fixUTF8(Doc); sammccall wrote:

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

steakhal added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85528/new/ https://reviews.llvm.org/D85528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D88338: [clangd] clangd --check: standalone diagnosis of common problems

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks LGTM! Comment at: clang-tools-extra/clangd/tool/Check.cpp:107 + +Cmd = CDB->getFallbackCommand(File); +if (auto TrueCmd = CDB->getCompileCommand(File)) { -

[PATCH] D86743: [analyzer] Ignore VLASizeChecker case that could cause crash

NoQ added a comment. But that's for a different bug, no? Even if that patch somehow dodges *this* crash, the underlying problem of us being unable to account for mutability of VLA sizes still remains to be addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

nomanous added a comment. In D87962#2298021 , @aaron.ballman wrote: > Multichar literals are implementation-defined in C and conditionally > supported with implementation-defined semantics in C++. I agree that it may > make sense to warn about their use

[PATCH] D88590: [clangd] Add bencmark for measuring latency of DecisionForest model.

usaxena95 updated this revision to Diff 295479. usaxena95 added a comment. Distribution change and better formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88590/new/ https://reviews.llvm.org/D88590 Files: clang-tools-extra/clangd/benchm

[PATCH] D88590: [clangd] Add bencmark for measuring latency of DecisionForest model.

usaxena95 updated this revision to Diff 295478. usaxena95 added a comment. Added benchmark. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88590/new/ https://reviews.llvm.org/D88590 Files: clang-tools-extra/clangd/benchmarks/CMakeLists.txt clan

[PATCH] D86743: [analyzer] Ignore VLASizeChecker case that could cause crash

balazske added a comment. I do not know if it got overlooked but there is another patch D81061 that removes the crash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86743/new/ https://reviews.llvm.org/D86743

[PATCH] D88634: [clangd] Extend the rename API.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. several changes: - return a structure result in ren

[PATCH] D88630: [clang/CMake] Respect LLVM_TOOLS_INSTALL_DIR

mgorny added a comment. Well, I've tested it and it doesn't seem to break anything for us (Gentoo) but I don't really understand why you'd have a different install dir for LLVM and Clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88630/new/ h

<    1   2