[PATCH] D88790: [libTooling] Recognize sccache as a compiler wrapper in compilation database commands

nridge added a comment. Link to sccache for those not familiar: https://github.com/mozilla/sccache/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88790/new/ https://reviews.llvm.org/D88790 ___

[PATCH] D88790: [libTooling] Recognize sccache as a compiler wrapper in compilation database commands

nridge created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. nridge requested review of this revision. sccache is a compiler caching tool similar to ccache. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D88790 Files:

[PATCH] D88469: [clangd] Heuristic resolution for dependent type and template names

nridge updated this revision to Diff 296019. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88469/new/ https://reviews.llvm.org/D88469 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

MaskRay added inline comments. Comment at: lld/Common/TargetOptionsCommandFlags.cpp:17 +llvm::TargetOptions +lld::initTargetOptionsFromCodeGenFlags(const llvm::Triple ) { + return llvm::codegen::InitTargetOptionsFromCodeGenFlags(TheTriple); Currently lld does

[PATCH] D88786: [CUDA] Don't call __cudaRegisterVariable on C++17 inline variables

MaskRay updated this revision to Diff 296007. MaskRay retitled this revision from "[CUDA] Suppress comdat on host-side shadow variables registered by __cuda_register_globals" to "[CUDA] Don't call __cudaRegisterVariable on C++17 inline variables". MaskRay edited the summary of this revision.

[PATCH] D88786: [CUDA] Suppress comdat on host-side shadow variables registered by __cuda_register_globals

MaskRay added a comment. Maybe we should disallow it instead. nvcc from CUDA 11.1 does not allow `__device__ inline` or `__device__ constexpr` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88786/new/ https://reviews.llvm.org/D88786

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

lebedev.ri updated this revision to Diff 296005. lebedev.ri added a comment. Re-fix clang tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87972/new/ https://reviews.llvm.org/D87972 Files: clang/test/CodeGenCXX/union-tbaa2.cpp

[PATCH] D88786: [CUDA] Suppress comdat on host-side shadow variables registered by __cuda_register_globals

MaskRay created this revision. MaskRay added reviewers: jlebar, tra. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. MaskRay requested review of this revision. Host-side shadow variables of external declarations of device-side global variables have internal linkage

[PATCH] D88452: [Driver] Move detectLibcxxIncludePath to ToolChain

thakis added a comment. On https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8867483277057489840/+/steps/package_clang/0/stdout?format=raw too. Reverted in ba60dc0aa75e86165e260b2c08afafd1c394e95a

[clang] ba60dc0 - Revert "[Driver] Move detectLibcxxIncludePath to ToolChain"

Author: Nico Weber Date: 2020-10-03T14:22:53-04:00 New Revision: ba60dc0aa75e86165e260b2c08afafd1c394e95a URL: https://github.com/llvm/llvm-project/commit/ba60dc0aa75e86165e260b2c08afafd1c394e95a DIFF: https://github.com/llvm/llvm-project/commit/ba60dc0aa75e86165e260b2c08afafd1c394e95a.diff

[clang] fcb0ab5 - [clang][NFC] Change a mention of `objc_static_protocol` to `non_runtime`

Author: Nathan Lanza Date: 2020-10-03T14:04:14-04:00 New Revision: fcb0ab59335be185e05258c905ef57da9e7f3324 URL: https://github.com/llvm/llvm-project/commit/fcb0ab59335be185e05258c905ef57da9e7f3324 DIFF: https://github.com/llvm/llvm-project/commit/fcb0ab59335be185e05258c905ef57da9e7f3324.diff

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza added inline comments. Comment at: clang/include/clang/AST/DeclObjC.h:2181 + /// This is true iff the protocol is tagged with the `objc_static_protocol` + /// attribute. kastiglione wrote: > This comment refers to the original spelling. Yes indeed,

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:109 "multi-character character constant">, InGroup; -def ext_four_char_character_literal : Extension< +def ext_four_char_character_literal : Warning< "multi-character character

[PATCH] D88784: Improve ccc-analyzer error message

trixirt created this revision. trixirt added a reviewer: dcoughlin. trixirt added a project: clang. Herald added subscribers: cfe-commits, steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. trixirt requested review of this revision. When ccc-analyzer

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

kastiglione added inline comments. Comment at: clang/include/clang/AST/DeclObjC.h:2181 + /// This is true iff the protocol is tagged with the `objc_static_protocol` + /// attribute. This comment refers to the original spelling. Repository: rG LLVM Github

[PATCH] D88700: [clang-tidy] modernize-use-trailing-return-type fix #44206

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:72 +TL.getAs().getTypePtr()->getDecl()->getName())) + return false; default: bernhardmgruber wrote: >

[clang-tools-extra] 089e628 - Add a break statement to appease the build bots; NFC

Author: Aaron Ballman Date: 2020-10-03T11:10:26-04:00 New Revision: 089e628b61f929ccd26565cd4118395f0a0273c3 URL: https://github.com/llvm/llvm-project/commit/089e628b61f929ccd26565cd4118395f0a0273c3 DIFF: https://github.com/llvm/llvm-project/commit/089e628b61f929ccd26565cd4118395f0a0273c3.diff

[PATCH] D88700: [clang-tidy] modernize-use-trailing-return-type fix #44206

bernhardmgruber marked an inline comment as done. bernhardmgruber added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:72 +TL.getAs().getTypePtr()->getDecl()->getName())) + return false;

[PATCH] D88700: [clang-tidy] modernize-use-trailing-return-type fix #44206

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:72 +TL.getAs().getTypePtr()->getDecl()->getName())) + return false; default: bernhardmgruber wrote: > There is

[PATCH] D88700: [clang-tidy] modernize-use-trailing-return-type fix #44206

bernhardmgruber added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:72 +TL.getAs().getTypePtr()->getDecl()->getName())) + return false; default: There is a `break;` missing

[PATCH] D88700: [clang-tidy] modernize-use-trailing-return-type fix #44206

aaron.ballman added a comment. In D88700#2309431 , @bernhardmgruber wrote: > Thank you for the quick review! Can you please commit it for me as well? > Thank you! Happy to! I've commit on your behalf in 07028cd5dbb8417fb41121a7e75290fab00f65fc

[clang-tools-extra] 07028cd - modernize-use-trailing-return-type fix for PR44206

Author: Bernhard Manfred Gruber Date: 2020-10-03T10:08:44-04:00 New Revision: 07028cd5dbb8417fb41121a7e75290fab00f65fc URL: https://github.com/llvm/llvm-project/commit/07028cd5dbb8417fb41121a7e75290fab00f65fc DIFF:

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM modulo comment nits. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:1622 EmitBranchOnBoolExpr(CondOp->getCond(), LHSBlock, RHSBlock, - getProfileCount(CondOp), Weights); +

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

lebedev.ri added a comment. In D36836#2310170 , @lebedev.ri wrote: > In D36836#2310169 , @lebedev.ri > wrote: > >> In D36836#2310168 , @RKSimon wrote: >> >>> @lebedev.ri

[clang-tools-extra] 1596cc8 - [NFCI][clang-tidy] FunctionCognitiveComplexityCheck::check(): try to fix windows arm build bots

Author: Roman Lebedev Date: 2020-10-03T16:02:19+03:00 New Revision: 1596cc83509342eb37dbfe6b95e906759afc6741 URL: https://github.com/llvm/llvm-project/commit/1596cc83509342eb37dbfe6b95e906759afc6741 DIFF: https://github.com/llvm/llvm-project/commit/1596cc83509342eb37dbfe6b95e906759afc6741.diff

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

lebedev.ri added a comment. In D36836#2310169 , @lebedev.ri wrote: > In D36836#2310168 , @RKSimon wrote: > >> @lebedev.ri This is failing on the windows arm build bots - please can you >> take a look? >> >>

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

lebedev.ri added a comment. In D36836#2310168 , @RKSimon wrote: > @lebedev.ri This is failing on the windows arm build bots - please can you > take a look? > > http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/1482 >

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

RKSimon added a comment. @lebedev.ri This is failing on the windows arm build bots - please can you take a look? http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/1482 http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/3285 Repository: rG LLVM Github Monorepo

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

Mordante marked 2 inline comments as done. Mordante added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:1622 EmitBranchOnBoolExpr(CondOp->getCond(), LHSBlock, RHSBlock, - getProfileCount(CondOp), Weights); +

[clang] 0ce6d6b - [Sema] List conversion validate character array.

Author: Mark de Wever Date: 2020-10-03T14:33:28+02:00 New Revision: 0ce6d6b46eb7040283ad0800c5533672fbfb9bac URL: https://github.com/llvm/llvm-project/commit/0ce6d6b46eb7040283ad0800c5533672fbfb9bac DIFF: https://github.com/llvm/llvm-project/commit/0ce6d6b46eb7040283ad0800c5533672fbfb9bac.diff

[PATCH] D87561: [Sema] List conversion validate character array

This revision was automatically updated to reflect the committed changes. Mordante marked 2 inline comments as done. Closed by commit rG0ce6d6b46eb7: [Sema] List conversion validate character array. (authored by Mordante). Changed prior to commit:

[PATCH] D87561: [Sema] List conversion validate character array

Mordante marked 6 inline comments as done. Mordante added inline comments. Comment at: clang/test/CXX/drs/dr14xx.cpp:411-414 + void f(const char[4]); + void f(const wchar_t[4]); + void f(const char16_t[4]); + void f(const char32_t[4]); rsmith wrote: >

[PATCH] D88452: [Driver] Move detectLibcxxIncludePath to ToolChain

thakis added a comment. Breaks tests on windows: http://45.33.8.238/win/25123/step_7.txt Please take a look, and revert if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88452/new/ https://reviews.llvm.org/D88452

[PATCH] D60748: Adds an option "malign-pass-aggregate" to make the alignment of the struct and union parameters compatible with the default gcc

RKSimon added a comment. Herald added a subscriber: dang. @wxiao3 @LiuChen3 Are you still looking at this or should it be abandoned? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60748/new/ https://reviews.llvm.org/D60748 ___ cfe-commits

[PATCH] D88780: Allow interfaces to operate on in-memory buffers with no source location info.

reikdas created this revision. reikdas added reviewers: rsmith, lebedev.ri, shafik, v.g.vassilev. Herald added a project: clang. Herald added a subscriber: cfe-commits. reikdas requested review of this revision. This is a part of the RFC mentioned here -

[PATCH] D88518: Recognize setjmp and friends as builtins even if jmp_buf is not declared yet.

mstorsjo added a comment. In D88518#2309538 , @rsmith wrote: > In D88518#2308085 , @mstorsjo wrote: > >> This broke use of setjmp for mingw on x86_64. > > Thanks, should be fixed in