[PATCH] D89212: PR47663: Warn if an entity becomes weak after its first use.

rjmccall added a comment. Patch looks good to me. I think we're running some internal tests; do you want to wait for those? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89212/new/ https://reviews.llvm.org/D89212

[PATCH] D89212: PR47663: Warn if an entity becomes weak after its first use.

rsmith updated this revision to Diff 297767. rsmith added a comment. - Don't warn if we see a weak definition for a declaration that's already Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89212/new/ https://reviews.llvm.org/D89212 Files:

[PATCH] D76211: OpenMP Metadirective with user defined condition

jdoerfert added a comment. Are you still working on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/ https://reviews.llvm.org/D76211 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

Thanks, Vitaly! Let's have them there for at least 24 hours, shall we? Could you move sanitizer-buildbot1, sanitizer-buildbot3, sanitizer-buildbot7 as well, please? AnnotatedCommand on the staging has been tested functionally and is good. My only concern at this point is how it would handle a

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

Looks like staging AnnotatedCommand fixed step statuses, so we can see which one is green. Please let me know when to switch bots back from the staging. Thank you! On Mon, 12 Oct 2020 at 21:38, Vitaly Buka wrote: > Switched all but PPC, I don't have access to them. But they run the same >

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

Switched all but PPC, I don't have access to them. But they run the same script as sanitizer-x86_64-linux. http://lab.llvm.org:8014/#/waterfall?tags=sanitizer On Mon, 12 Oct 2020 at 19:19, Galina Kistanova wrote: > We have a better version of AnnotatedCommand on the staging. It should be > a

[clang] 913f600 - Canonicalize declaration pointers when forming APValues.

Author: Richard Smith Date: 2020-10-12T19:32:57-07:00 New Revision: 913f6005669cfb590c99865a90bc51ed0983d09d URL: https://github.com/llvm/llvm-project/commit/913f6005669cfb590c99865a90bc51ed0983d09d DIFF: https://github.com/llvm/llvm-project/commit/913f6005669cfb590c99865a90bc51ed0983d09d.diff

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

rsmith added a comment. In D76620#2324858 , @erichkeane wrote: > The feature that this supports is a part of the SYCL 2020 Provisional Spec, I > thought that was sufficient. We'll look into an RFC to re-submit in the > future. Does that cover only

[PATCH] D89286: [DebugInfo] Check for templated static data member when adding constant to record static fields

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1421-1425 + else if (auto *TemplateDecl = Var->getInstantiatedFromStaticDataMember()) { +// Inline static data members might not have an initialization. +if (TemplateDecl->getInit()) +

Re: [clang] 9dcd96f - Canonicalize declaration pointers when forming APValues.

Thanks, yes, it looks like we don't properly inherit inheritable attributes in redeclarations of ObjCInterfaceDecls. Fixed in e2d4174e9c66251d1b408234b53f53d0903c0285. Let's try unreverting and see if things look better. On Mon, 12 Oct 2020 at 11:08, Arthur Eubanks wrote: > Could there be an

[clang] e2d4174 - Ensure that InheritedAttrs are properly inherited along a redeclaration

Author: Richard Smith Date: 2020-10-12T19:22:31-07:00 New Revision: e2d4174e9c66251d1b408234b53f53d0903c0285 URL: https://github.com/llvm/llvm-project/commit/e2d4174e9c66251d1b408234b53f53d0903c0285 DIFF: https://github.com/llvm/llvm-project/commit/e2d4174e9c66251d1b408234b53f53d0903c0285.diff

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

We have a better version of AnnotatedCommand on the staging. It should be a functional equivalent of the old one. We need to stress test it well before moving to the production build bot. For that we need all sanitizer + other bots which use the AnnotatedCommand directly or indirectly moved

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

keryell added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3704-3705 + Result = E->EvaluateAsRValue(Eval, Context, true); +else + Result = E->EvaluateAsLValue(Eval, Context, true); + Tyker wrote: > keryell wrote: > > aaron.ballman

[PATCH] D89066: [Coroutine][Sema] Only tighten the suspend call temp lifetime for final awaiter

junparser added a comment. In D89066#2325358 , @lxfind wrote: > In D89066#2324291 , @junparser wrote: > >> In D89066#2324151 , @lxfind wrote: >> >>> In D89066#2324115

[PATCH] D89286: [DebugInfo] Check for templated static data member when adding constant to record static fields

akhuang created this revision. akhuang added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang requested review of this revision. Debug info for inline static data members was missing the constant value, because the initializer for these static

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

keryell added a reviewer: Ralender. keryell added a comment. Enabling this feature only with SYCL seems like an easy and quick mitigation, as SYCL compilers downstream can easily update their runtime to the new builtin name. Otherwise, just removing a feature used for almost 6 months will cause

[PATCH] D89102: [X86] Add HRESET instruction.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG412cdcf2edf2: [X86] Add HRESET instruction. (authored by pengfei). Changed prior to commit: https://reviews.llvm.org/D89102?vs=297402=297732#toc

[clang] 412cdcf - [X86] Add HRESET instruction.

Author: Wang, Pengfei Date: 2020-10-13T08:47:26+08:00 New Revision: 412cdcf2edf2344632e01d5f71da4bbd9838ab7d URL: https://github.com/llvm/llvm-project/commit/412cdcf2edf2344632e01d5f71da4bbd9838ab7d DIFF: https://github.com/llvm/llvm-project/commit/412cdcf2edf2344632e01d5f71da4bbd9838ab7d.diff

[PATCH] D89284: [clangd] Propagate CollectMainFileRefs to BackgroundIndex

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This appears to have been an omission in D83536

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

vsk added a comment. @plotfi Sorry this work has stalled, unfortunately I haven't had any bandwidth to drive it forward. At this point I don't think there are any outstanding concerns with this patch. If anyone is willing to rebase and land it, I would be really grateful. It looks like part

[PATCH] D89276: Support ObjC in IncludeInserter

compositeprimes updated this revision to Diff 297728. compositeprimes edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89276/new/ https://reviews.llvm.org/D89276 Files:

[PATCH] D89078: Add `-f[no-]split-cold-code` toggling outlining & enable in -O

vsk added a comment. @compnerd thank you for working on upstreaming this patch! Would you be open to commandeering D57265 instead? This is my (unfortunately stalled) attempt to upstream the same patch, and it has some review concerns from Fedor Sergeev, Philip

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Basic/LangOptions.h:299 + /// This overrides the default ABI used by the target. + llvm::Optional CXXABIOverride; +

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2174 + } + unsigned ArgNo = 0; rsmith wrote: > CJ-Johnson wrote: > > jdoerfert wrote: > > > Even if null pointer is valid we should place dereferenceable. > > > > > > We also could

[clang] cffb0dd - [SemaTemplate] Stop passing insertion position around during VarTemplate instantiation

Author: Bruno Cardoso Lopes Date: 2020-10-12T16:48:50-07:00 New Revision: cffb0dd54d41d8e249d2009467c4beb5b681ba26 URL: https://github.com/llvm/llvm-project/commit/cffb0dd54d41d8e249d2009467c4beb5b681ba26 DIFF:

[PATCH] D87853: [SemaTemplate] Stop passing insertion position around during VarTemplate instantiation

This revision was automatically updated to reflect the committed changes. Closed by commit rGcffb0dd54d41: [SemaTemplate] Stop passing insertion position around during VarTemplate… (authored by bruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

nridge added a comment. This is neat! Are there plans to add vscode client support to invoke this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89277/new/ https://reviews.llvm.org/D89277 ___

[PATCH] D89098: [clang] Fix returning the underlying VarDecl as top-level decl for VarTemplateDecl.

nridge added a comment. I posted about this a while ago, but wasn't sure how to fix. Thanks for fixing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89098/new/

[PATCH] D60954: [clangd] Test case demonstrating variable template issue

nridge abandoned this revision. nridge added a comment. Herald added a subscriber: usaxena95. Fixed by D89098 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60954/new/ https://reviews.llvm.org/D60954

[PATCH] D88463: [clangd] Try harder to get accurate ranges for documentSymbols in macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb764edc59ff7: [clangd] Try harder to get accurate ranges for documentSymbols in macros (authored by nridge). Repository: rG LLVM Github Monorepo

[clang-tools-extra] b764edc - [clangd] Try harder to get accurate ranges for documentSymbols in macros

Author: Nathan Ridge Date: 2020-10-12T19:26:36-04:00 New Revision: b764edc59ff7768e052bc2b9e76e3bb69dd5147b URL: https://github.com/llvm/llvm-project/commit/b764edc59ff7768e052bc2b9e76e3bb69dd5147b DIFF: https://github.com/llvm/llvm-project/commit/b764edc59ff7768e052bc2b9e76e3bb69dd5147b.diff

[PATCH] D88463: [clangd] Try harder to get accurate ranges for documentSymbols in macros

nridge updated this revision to Diff 297712. nridge marked 2 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88463/new/ https://reviews.llvm.org/D88463 Files:

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

MaskRay added a comment. In D88712#2326223 , @rsmith wrote: > In D88712#2325823 , @MaskRay wrote: > >> In D88712#2324105 , @rsmith wrote: >> >>> What are the expected

[clang] d80ecdf - [Coroutine] Rename coro-semmetric-transfer.cpp and possibly fix test failure

Author: Xun Li Date: 2020-10-12T15:29:07-07:00 New Revision: d80ecdf27faf2c45a4264064ddfd5c4524dadce4 URL: https://github.com/llvm/llvm-project/commit/d80ecdf27faf2c45a4264064ddfd5c4524dadce4 DIFF: https://github.com/llvm/llvm-project/commit/d80ecdf27faf2c45a4264064ddfd5c4524dadce4.diff LOG:

[PATCH] D89269: [Coroutine] Rename coro-semmetric-transfer.cpp and fix test failure

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd80ecdf27faf: [Coroutine] Rename coro-semmetric-transfer.cpp and possibly fix test failure (authored by lxfind). Repository: rG LLVM Github

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Performs a detailed profiling of clangd

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

rsmith added a comment. In D88712#2325823 , @MaskRay wrote: > In D88712#2324105 , @rsmith wrote: > >> What are the expected semantics in this case? Is this: >> >> - the function is still the builtin, but if it ends

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. A lot of the test changes here seem to be over-constraining the existing tests. Tests that don't care about `nonnull` / `dereferenceable` `this` pointers should generally not be

[PATCH] D78658: [clang][Frontend] Add missing error handling

dblaikie added a comment. Perhaps this'd be more robust with ScopeExit? ( https://llvm.org/doxygen/ScopeExit_8h_source.html ) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-commits mailing

[PATCH] D89276: Support ObjC in IncludeInserter

compositeprimes created this revision. compositeprimes added a reviewer: alexfh. compositeprimes added a project: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. compositeprimes requested review of this revision. Update IncludeSorter/IncludeInserter to

[PATCH] D89274: [WebAssembly] Use the new crt1-command.o if present.

sunfish created this revision. sunfish added a reviewer: sbc100. Herald added subscribers: cfe-commits, ecnelises, jgravelle-google, dschuff. Herald added a project: clang. sunfish requested review of this revision. Herald added a subscriber: aheejin. If crt1-command.o exists in the sysroot, the

[PATCH] D89136: Lex: Avoid MemoryBuffer* key in ExcludedPreprocessorDirectiveSkipMapping, NFC

dexonsmith added a comment. I cleaned up the access and removed `getBufferPtr` separately in d07b290e4b7c55823895e88b683de4178ffc66db , then landed my change in 69feac12d0539a7cc19cbda906d46f67029486e1

[PATCH] D89136: Lex: Avoid MemoryBuffer* key in ExcludedPreprocessorDirectiveSkipMapping, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG69feac12d053: Lex: Avoid MemoryBuffer* key in ExcludedPreprocessorDirectiveSkipMapping, NFC (authored by dexonsmith). Herald added a project: clang. Changed prior to commit:

[clang] 69feac1 - Lex: Avoid MemoryBuffer* key in ExcludedPreprocessorDirectiveSkipMapping, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-12T17:39:01-04:00 New Revision: 69feac12d0539a7cc19cbda906d46f67029486e1 URL: https://github.com/llvm/llvm-project/commit/69feac12d0539a7cc19cbda906d46f67029486e1 DIFF:

[clang] ac73caf - Ensure TreeTransform considers ParmVarDecls as transformed Decls

Author: Erich Keane Date: 2020-10-12T14:38:04-07:00 New Revision: ac73cafac0e523879b42b305106cd6e67bfb412e URL: https://github.com/llvm/llvm-project/commit/ac73cafac0e523879b42b305106cd6e67bfb412e DIFF: https://github.com/llvm/llvm-project/commit/ac73cafac0e523879b42b305106cd6e67bfb412e.diff

[PATCH] D89270: [clang-tidy] Add an example for misc-unused-alias-decls

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: gribozavr. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. sylvestre.ledru requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D89270 Files:

[clang] d07b290 - DependencyScanning: pull factory function into MinimizedVFS, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-12T17:25:10-04:00 New Revision: d07b290e4b7c55823895e88b683de4178ffc66db URL: https://github.com/llvm/llvm-project/commit/d07b290e4b7c55823895e88b683de4178ffc66db DIFF:

[PATCH] D89066: [Coroutine][Sema] Only tighten the suspend call temp lifetime for final awaiter

lxfind added a comment. Test failures are being fixed in https://reviews.llvm.org/D89269. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89066/new/ https://reviews.llvm.org/D89066 ___ cfe-commits mailing

[PATCH] D89269: [Coroutine] Rename coro-semmetric-transfer.cpp and possibly fix test failure

lxfind created this revision. lxfind added reviewers: wenlei, junparser. Herald added subscribers: cfe-commits, modimo, modocache. Herald added a project: clang. lxfind requested review of this revision. Some tests start to fail after https://reviews.llvm.org/D89066. It's because the size of

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

vsk removed a subscriber: loic-joly-sonarsource. vsk added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1169 +createBranchRegion(S->getCond(), BodyCount, + subtractCounters(CondCount, BodyCount)); }

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

scott.linder added a comment. In D88978#2325991 , @ABataev wrote: > In D88978#2325982 , @scott.linder > wrote: > >> @ABataev Sorry if I'm pulling you in without enough context/work on my end, >> but I wanted to

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

Szelethus added a subscriber: aaron.ballman. Szelethus added inline comments. Comment at: clang/lib/Analysis/SarifPathDiagnosticConsumer.cpp:307 .Case(FULLNAME, HELPTEXT) #include "clang/StaticAnalyzer/Checkers/Checkers.inc" #undef CHECKER NoQ wrote: >

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

ABataev added a comment. In D88978#2325982 , @scott.linder wrote: > @ABataev Sorry if I'm pulling you in without enough context/work on my end, > but I wanted to ask how the Clang codegen for OpenMP locals works at a high > level? > > Is the idea that

[PATCH] D87604: [X86] Convert integer _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87604/new/ https://reviews.llvm.org/D87604

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

scott.linder added a comment. @ABataev Sorry if I'm pulling you in without enough context/work on my end, but I wanted to ask how the Clang codegen for OpenMP locals works at a high level? Is the idea that instead of an `alloc` the frontend can insert calls into the runtime in some cases, like

[PATCH] D89225: [MinGW][clang-shlib] Build only when LLVM_LINK_LLVM_DYLIB is enabled

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b1d018c0dba: [MinGW][clang-shlib] Build only when LLVM_LINK_LLVM_DYLIB is enabled (authored by mati865, committed by mstorsjo). Repository: rG

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 added a comment. In D87946#2325934 , @grokos wrote: > In D87946#2325756 , @jhuber6 wrote: > >> Current build, fails `offloading/target_depend_nowait` for an unknown reason >> after calling

[clang] 3b1d018 - [MinGW][clang-shlib] Build only when LLVM_LINK_LLVM_DYLIB is enabled

Author: Mateusz Mikuła Date: 2020-10-12T23:28:23+03:00 New Revision: 3b1d018c0dba45408164f5e69cb400976efa350f URL: https://github.com/llvm/llvm-project/commit/3b1d018c0dba45408164f5e69cb400976efa350f DIFF:

[libunwind] fc5e68f - [libunwind] [SEH] Don't interact with foreign exceptions

Author: Martin Storsjö Date: 2020-10-12T23:28:22+03:00 New Revision: fc5e68fab965bdc8fdf6db9ae2603f9dd02dec5b URL: https://github.com/llvm/llvm-project/commit/fc5e68fab965bdc8fdf6db9ae2603f9dd02dec5b DIFF:

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ added inline comments. Comment at: clang/lib/Analysis/SarifPathDiagnosticConsumer.cpp:307 .Case(FULLNAME, HELPTEXT) #include "clang/StaticAnalyzer/Checkers/Checkers.inc" #undef CHECKER Szelethus wrote: > NoQ wrote: > > This thing still worries me but

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

grokos added a comment. In D87946#2325756 , @jhuber6 wrote: > Current build, fails `offloading/target_depend_nowait` for an unknown reason > after calling cuStreamSynchronize in __tgt_target_teams_mapper_nowait. Is your tree up to date? We had a problem

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

spatel added a comment. In D88154#2325713 , @venkataramanan.kumar.llvm wrote: > As per review comments from Sanjay, updated the test case to use metadata. > Also autogenerated the checks in the test cases using > llvm/utils/update_test_checks.py.

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

jdoerfert added subscribers: aaron.ballman, lebedev.ri. jdoerfert added a comment. Overall this looks sane to me. Don't know who wants to accept this. @rjmccall @lebedev.ri @aaron.ballman @rsmith Comment at: clang/lib/CodeGen/CGCall.cpp:2165 +

[PATCH] D89102: [X86] Add HRESET instruction.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89102/new/ https://reviews.llvm.org/D89102

[PATCH] D89066: [Coroutine][Sema] Only tighten the suspend call temp lifetime for final awaiter

lxfind added a comment. There seems to be build failures in the buildbot, but I don't understand why it's happening.. (unable to repro locally and the patterns seem reasonable) http://lab.llvm.org:8011/#/builders/12/builds/92/steps/7/logs/FAIL__Clang__coro-semmetric-transfer_cpp Repository:

[PATCH] D89136: Lex: Avoid MemoryBuffer* key in ExcludedPreprocessorDirectiveSkipMapping, NFC

arphaman accepted this revision. arphaman added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:249 if (!Entry->getPPSkippedRangeMapping().empty() && PPSkipMappings) -

[PATCH] D66782: SourceManager: Prefer Optional over MemoryBuffer*

dexonsmith planned changes to this revision. dexonsmith added a comment. I'm going to change my approach here to be less error-prone. The real goal is changing from `MemoryBuffer*` to `MemoryBufferRef`. I was adding `Optional<>` as a cleanup but that's really a nice-to-have, which is better

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

MaskRay added a comment. In D88712#2324105 , @rsmith wrote: > What are the expected semantics in this case? Is this: > > - the function is still the builtin, but if it ends up being a libcall, call > a function with a different asm name, or > - the

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

MaskRay updated this revision to Diff 297667. MaskRay edited the summary of this revision. MaskRay added a comment. Mention the limitation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88712/new/ https://reviews.llvm.org/D88712 Files:

[clang] 9a33f02 - Revert "Canonicalize declaration pointers when forming APValues."

Author: Arthur Eubanks Date: 2020-10-12T12:37:24-07:00 New Revision: 9a33f027ac7d73e14ae287e78ab554142d1cbc8f URL: https://github.com/llvm/llvm-project/commit/9a33f027ac7d73e14ae287e78ab554142d1cbc8f DIFF:

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 updated this revision to Diff 297661. jhuber6 added a subscriber: tianshilei1992. jhuber6 added a comment. Current build, fails `offloading/target_depend_nowait` for an unknown reason after calling cuStreamSynchronize in __tgt_target_teams_mapper_nowait. Repository: rG LLVM Github

[PATCH] D89066: [Coroutine][Sema] Only tighten the suspend call temp lifetime for final awaiter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdce8f2bb25ea: [Coroutine][Sema] Only tighten the suspend call temp lifetime for final awaiter (authored by lxfind). Repository: rG LLVM Github

[clang] dce8f2b - [Coroutine][Sema] Only tighten the suspend call temp lifetime for final awaiter

Author: Xun Li Date: 2020-10-12T12:00:20-07:00 New Revision: dce8f2bb25ea1d01533d8e602f2520492fa67259 URL: https://github.com/llvm/llvm-project/commit/dce8f2bb25ea1d01533d8e602f2520492fa67259 DIFF: https://github.com/llvm/llvm-project/commit/dce8f2bb25ea1d01533d8e602f2520492fa67259.diff LOG:

[PATCH] D89066: [Coroutine][Sema] Only tighten the suspend call temp lifetime for final awaiter

lxfind updated this revision to Diff 297656. lxfind added a comment. Add more comments and TODO Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89066/new/ https://reviews.llvm.org/D89066 Files: clang/lib/Sema/SemaCoroutine.cpp

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

CJ-Johnson added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2174 + } + unsigned ArgNo = 0; jdoerfert wrote: > Even if null pointer is valid we should place dereferenceable. > > We also could never place nonnull and let the middle-end make the

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm updated this revision to Diff 297654. venkataramanan.kumar.llvm added a comment. As per review comments from Sanjay, updated the test case to use metadata. Also autogenerated the checks in the test cases using llvm/utils/update_test_checks.py. CHANGES SINCE LAST

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

CJ-Johnson updated this revision to Diff 297655. CJ-Johnson added a comment. Apply dereferenceable even if null is a valid address CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/ https://reviews.llvm.org/D17993 Files: clang/lib/CodeGen/CGCall.cpp

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

On Wed, Oct 7, 2020 at 4:32 PM Galina Kistanova via lldb-commits < lldb-comm...@lists.llvm.org> wrote: > They are online now - http://lab.llvm.org:8011/#/waterfall?tags=sanitizer > > AnnotatedCommand has severe design conflict with the new buildbot. > We have changed it to be safe and still do

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

CJ-Johnson added inline comments. Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp:1082 +bool isGFX9Plus(const MCSubtargetInfo ) { + return isGFX9(STI) || isGFX10(STI); +} CJ-Johnson wrote: > arsenm wrote: > > How are these changes related? > This is

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2174 + } + unsigned ArgNo = 0; Even if null pointer is valid we should place dereferenceable. We also could never place nonnull and let the middle-end make the dereferenceable ->

[PATCH] D89066: [Coroutine][Sema] Only tighten the suspend call temp lifetime for final awaiter

wenlei accepted this revision. wenlei added a comment. This revision is now accepted and ready to land. LGTM. I think we can get this in first to address the fall out from https://reviews.llvm.org/D87470, while investigating ASAN failure. Comment at:

[PATCH] D89136: Lex: Avoid MemoryBuffer* key in ExcludedPreprocessorDirectiveSkipMapping, NFC

dexonsmith marked an inline comment as done. dexonsmith added a comment. Agreed, looks cleaner without the indirection. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89136/new/ https://reviews.llvm.org/D89136 ___ cfe-commits mailing list

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

jdoerfert added a comment. I think this is the wrong patch now. @xbolva00 posted a command that works if `git show HEAD` shows the commit you want to upload. If not, replace HEAD with the commit hash. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/

[PATCH] D89136: Lex: Avoid MemoryBuffer* key in ExcludedPreprocessorDirectiveSkipMapping, NFC

dexonsmith updated this revision to Diff 297648. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89136/new/ https://reviews.llvm.org/D89136 Files: clang/include/clang/Lex/PreprocessorExcludedConditionalDirectiveSkipMapping.h clang/lib/Lex/PPDirectives.cpp

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

CJ-Johnson added inline comments. Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp:1082 +bool isGFX9Plus(const MCSubtargetInfo ) { + return isGFX9(STI) || isGFX10(STI); +} arsenm wrote: > How are these changes related? This is a mistake. I did not

[PATCH] D88299: [clang-format] Add MacroUnexpander.

sammccall added a comment. This is magnificently difficult :-) I've sunk a fair few hours into understanding it now, and need to send some comments based on the interface+tests. Some of these will be misguided or answered by the implementation, but I'm afraid I can't fit it all into my head (on

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

CJ-Johnson updated this revision to Diff 297647. CJ-Johnson added a comment. Update with full diff context CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/ https://reviews.llvm.org/D17993 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CXX/except/except.spec/p14-ir.cpp

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp:1082 +bool isGFX9Plus(const MCSubtargetInfo ) { + return isGFX9(STI) || isGFX10(STI); +} How are these changes related? CHANGES SINCE LAST ACTION

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

CJ-Johnson updated this revision to Diff 297645. CJ-Johnson added a comment. Herald added subscribers: llvm-commits, kerbowa, hiraditya, nhaehnle, arsenm. Herald added a project: LLVM. Update diff with full context CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

xbolva00 added a comment. In D17993#2325616 , @CJ-Johnson wrote: > In D17993#2325610 , @jdoerfert wrote: > >> Can you please upload again with full context? > > My apologies, I am new to LLVM contribution. What is

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

CJ-Johnson added a comment. In D17993#2325610 , @jdoerfert wrote: > Can you please upload again with full context? My apologies, I am new to LLVM contribution. What is the best way to do that such that it squashes all of my local git commits? CHANGES

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

jdoerfert added a comment. Can you please upload again with full context? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/ https://reviews.llvm.org/D17993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [clang] 9dcd96f - Canonicalize declaration pointers when forming APValues.

Could there be an issue with Objective C property attributes? https://crbug.com/1134762 On Sun, Oct 11, 2020 at 2:11 PM Richard Smith wrote: > Please can you try building with https://reviews.llvm.org/D89212 applied > first, and see if it produces any warnings? If so, you're probably hitting >

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

CJ-Johnson updated this revision to Diff 297640. CJ-Johnson edited the summary of this revision. CJ-Johnson added a comment. Herald added subscribers: jdoerfert, aheejin, sbc100, jvesely, dschuff. Rebasing on head, removing flag changes since that was added in https://reviews.llvm.org/D47894 and

[PATCH] D89177: [cmake] Add support for multiple distributions

phosek added a comment. Herald added a subscriber: rdzhabarov. We've already considered introducing a similar mechanism so thank you for working on this! There's one issue that I haven't figured out how to resolve and I'd be interested in your thoughts: building executables and libraries in

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

CJ-Johnson commandeered this revision. CJ-Johnson added a reviewer: bkramer. CJ-Johnson added a comment. The patch is ready! Commandeering this change :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/ https://reviews.llvm.org/D17993

[PATCH] D66782: SourceManager: Prefer Optional over MemoryBuffer*

dexonsmith added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:459 Position P) { - llvm::StringRef Code = SM.getBuffer(SM.getMainFileID())->getBuffer(); + llvm::StringRef Code =

[PATCH] D88469: [clangd] Heuristic resolution for dependent type and template names

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b962fdd5f36: [clangd] Heuristic resolution for dependent type and template names (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 1b962fd - [clangd] Heuristic resolution for dependent type and template names

Author: Nathan Ridge Date: 2020-10-12T13:37:22-04:00 New Revision: 1b962fdd5f365a10684d9f70d703ae101c20d37a URL: https://github.com/llvm/llvm-project/commit/1b962fdd5f365a10684d9f70d703ae101c20d37a DIFF: https://github.com/llvm/llvm-project/commit/1b962fdd5f365a10684d9f70d703ae101c20d37a.diff

[clang] 012dd42 - [X86] Support -march=x86-64-v[234]

Author: Fangrui Song Date: 2020-10-12T10:29:46-07:00 New Revision: 012dd42e027e2ff3d183cc9dcf27004cf9711720 URL: https://github.com/llvm/llvm-project/commit/012dd42e027e2ff3d183cc9dcf27004cf9711720 DIFF: https://github.com/llvm/llvm-project/commit/012dd42e027e2ff3d183cc9dcf27004cf9711720.diff

  1   2   3   >