[PATCH] D89276: Support ObjC in IncludeInserter

compositeprimes added a comment. clang-format is complaining about my ordering of headers in my test case in IncludeInserterTest (but that's correct objc formatting). Not sure if there's a way to disable that on those lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 9dbb088 - Perform lvalue conversions on the left of a pseudo-destructor call 'p->~T()'.

Author: Richard Smith Date: 2020-10-14T22:09:01-07:00 New Revision: 9dbb0886ea799061baf79d4dce3203524a8468cc URL: https://github.com/llvm/llvm-project/commit/9dbb0886ea799061baf79d4dce3203524a8468cc DIFF: https://github.com/llvm/llvm-project/commit/9dbb0886ea799061baf79d4dce3203524a8468cc.diff

[clang] 0065198 - clang-{tools,unittests}: Stop using SourceManager::getBuffer, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-15T00:35:16-04:00 New Revision: 006519816689acef5fd971955e21b7ab17ae65d9 URL: https://github.com/llvm/llvm-project/commit/006519816689acef5fd971955e21b7ab17ae65d9 DIFF:

[PATCH] D89416: clang-{tools,unittests}: Stop using SourceManager::getBuffer, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG006519816689: clang-{tools,unittests}: Stop using SourceManager::getBuffer, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

Thanks everyone! I would like to keep the bots in the staging till Friday. And if everything is good, then apply the changes to the production and let you move all the green bots back there. Thanks Galina On Tue, Oct 13, 2020 at 10:43 PM Vitaly Buka wrote: > They do on staging. >

[clang] af4fb41 - clang/StaticAnalyzer: Stop using SourceManager::getBuffer

Author: Duncan P. N. Exon Smith Date: 2020-10-15T00:34:24-04:00 New Revision: af4fb416bd355960ce93f271a0591f24f58d25ec URL: https://github.com/llvm/llvm-project/commit/af4fb416bd355960ce93f271a0591f24f58d25ec DIFF:

[PATCH] D89414: clang/StaticAnalyzer: Stop using SourceManager::getBuffer

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf4fb416bd35: clang/StaticAnalyzer: Stop using SourceManager::getBuffer (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89441: RFC: Potential fixes to function-instrument=xray-never

dberris added a comment. > Do you think we should fix this by handling the xray-never attribute in > XRayInstrumentation, or having CodeGenFunction remove the threshold if > xray-never is set? Good catch, thanks! I think we should go with the former (handling the case in XRayInstrumentation)

[clang] dde4e03 - clang/CodeGen: Stop using SourceManager::getBuffer, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-14T23:32:43-04:00 New Revision: dde4e0318c4cd2054ed241bf248fdddb8d1973e3 URL: https://github.com/llvm/llvm-project/commit/dde4e0318c4cd2054ed241bf248fdddb8d1973e3 DIFF:

[PATCH] D89411: clang/CodeGen: Stop using SourceManager::getBuffer, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGdde4e0318c4c: clang/CodeGen: Stop using SourceManager::getBuffer, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89025: [RISCV] Add -mtune support

kito-cheng marked an inline comment as done. kito-cheng added a comment. @MaskRay Thanks, that's first time I know the suffix `-SAME` :P CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89025/new/ https://reviews.llvm.org/D89025 ___

[PATCH] D89025: [RISCV] Add -mtune support

kito-cheng updated this revision to Diff 298293. kito-cheng added a comment. ChangeLog: - Update testcase according to MaskRay's suggestion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89025/new/ https://reviews.llvm.org/D89025 Files: clang/include/clang/Driver/Options.td

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

I switched sanitizers and two rnk@ bots back to the primary server. http://lab.llvm.org:8011/#/waterfall?tags=sanitizer On Tue, 13 Oct 2020 at 22:42, Vitaly Buka wrote: > They do on staging. > http://lab.llvm.org:8014/#/builders/sanitizer-windows >

[PATCH] D89446: [WebAssembly] Prototype i8x16.popcnt

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. tlively requested review of this revision. As proposed at

[PATCH] D89366: [WebAssembly] v128.load{8, 16, 32, 64}_lane instructions

tlively updated this revision to Diff 298291. tlively added a comment. - Remove "Pure" from load builtins Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89366/new/ https://reviews.llvm.org/D89366 Files:

[PATCH] D89445: clang/Basic: Remove ContentCache::getRawBuffer, NFC

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added subscribers: ributzka, kbarton, nemanjai. dexonsmith requested review of this revision. Replace `ContentCache::getRawBuffer` with `getBufferDataIfLoaded` and `getBufferIfLoaded`, excising another accessor for

[PATCH] D89409: clang/Frontend: Mostly stop using SourceManager::getBuffer, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG63af24227981: clang/Frontend: Mostly stop using SourceManager::getBuffer, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 63af242 - clang/Frontend: Mostly stop using SourceManager::getBuffer, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-14T23:31:28-04:00 New Revision: 63af2422798188d70a411f76b0f06ab63a783a0d URL: https://github.com/llvm/llvm-project/commit/63af2422798188d70a411f76b0f06ab63a783a0d DIFF:

[PATCH] D89443: [PowerPC][AIX] Make `__vector [un]signed long` an error

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: nemanjai, ZarkoCA, cebowleratibm. Herald added a subscriber: shchenz. Herald added a project: clang. hubert.reinterpretcast requested review of this revision. The semantics associated with `__vector [un]signed

[clang] 54c1bca - clang/Basic: Stop using SourceManager::getBuffer, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-14T22:42:56-04:00 New Revision: 54c1bcab90102481fe43b73f8547d47446ba2163 URL: https://github.com/llvm/llvm-project/commit/54c1bcab90102481fe43b73f8547d47446ba2163 DIFF:

[PATCH] D89394: clang/Basic: Stop using SourceManager::getBuffer, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG54c1bcab9010: clang/Basic: Stop using SourceManager::getBuffer, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89441: RFC: Potential fixes to function-instrument=xray-never

ianlevesque created this revision. ianlevesque added reviewers: dberris, MaskRay. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. ianlevesque requested review of this revision. When using https://reviews.llvm.org/D87953 I discovered that the

[PATCH] D89366: [WebAssembly] v128.load{8, 16, 32, 64}_lane instructions

tlively added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:180 +TARGET_BUILTIN(__builtin_wasm_load32_lane, "V4iIii*", "nU", "simd128") +TARGET_BUILTIN(__builtin_wasm_load64_lane, "V2LLiIiLLi*", "nU", "simd128")

[PATCH] D87565: [Sema] Improve const_cast conformance to N4261

rsmith added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:1817-1819 + NeedToMaterializeTemporary = + SrcType->isRecordType() || SrcType->isArrayType() || + SrcType->isFunctionPointerType() || SrcType->isMemberPointerType(); It

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

rjmccall added a comment. Thanks, this looks a lot better. Comment at: clang/include/clang/Basic/Diagnostic.h:1065 +/// +class StreamableDiagnosticBase { +public: I think I would prefer `StreamingDiagnostic` as the class name here. Comment

[PATCH] D89366: [WebAssembly] v128.load{8, 16, 32, 64}_lane instructions

tlively added a comment. In D89366#2331154 , @aheejin wrote: > Do loads need the vector argument? The proposal has that but I'm wondering > why... Can that possibly be an error from the author's side? Oops, I meant to answer that before but I did not.

[clang] f7f2e42 - PR47805: Use a single object for a function parameter in the caller and

Author: Richard Smith Date: 2020-10-14T17:43:51-07:00 New Revision: f7f2e4261a98b2da519d58e7f6794b013cda7a4b URL: https://github.com/llvm/llvm-project/commit/f7f2e4261a98b2da519d58e7f6794b013cda7a4b DIFF: https://github.com/llvm/llvm-project/commit/f7f2e4261a98b2da519d58e7f6794b013cda7a4b.diff

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

rsmith added a comment. Reverse ping: I have a patch implementing class type non-type template parameters that's blocked on this landing. If you won't have time to address @martong's comments soon, do you mind if I take this over and land it? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D89212: PR47663: Warn if an entity becomes weak after its first use.

rsmith updated this revision to Diff 298268. rsmith marked 3 inline comments as done. rsmith added a comment. - Addressing review feedback from @aaron.ballman. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89212/new/

[PATCH] D89212: PR47663: Warn if an entity becomes weak after its first use.

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6435-6436 +Attr *WeakA = nullptr; +for (Attr *A : VD->getAttrs()) { + if (!isa(A)) +continue; aaron.ballman wrote: > Ah, it's too

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan added a comment. In D85802#2331290 , @rnk wrote: > I'd like to point out that we used to have a very similar flag, but we > removed it back in 2014: http://reviews.llvm.org/D2545 > > Are you sure you need all the flexibility that this flag

[PATCH] D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex

kastiglione added a comment. Reverted here: 4cb4db11ee1323c5d4bf66d21deb046970f4e516 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89318/new/ https://reviews.llvm.org/D89318

[clang] 4cb4db1 - Revert "[ASTImporter] Fix crash caused by unset AttributeSpellingListIndex"

Author: Dave Lee Date: 2020-10-14T17:21:56-07:00 New Revision: 4cb4db11ee1323c5d4bf66d21deb046970f4e516 URL: https://github.com/llvm/llvm-project/commit/4cb4db11ee1323c5d4bf66d21deb046970f4e516 DIFF: https://github.com/llvm/llvm-project/commit/4cb4db11ee1323c5d4bf66d21deb046970f4e516.diff

[PATCH] D89276: Support ObjC in IncludeInserter

compositeprimes updated this revision to Diff 298264. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89276/new/ https://reviews.llvm.org/D89276 Files: clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp

[PATCH] D88498: [FPEnv] Evaluate initializers in constant rounding mode

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. In D88498#2329845 , @sepavloff wrote: > - Reverted check to the previous version, in which it applied to C++ file > level variables also.

[PATCH] D89212: PR47663: Warn if an entity becomes weak after its first use.

rsmith added a comment. In D89212#2326771 , @rjmccall wrote: > Patch looks good to me. I think we're running some internal tests; do you > want to wait for those? More testing and validation would be nice; I don't think this patch is urgent so I'm

[PATCH] D89360: Treat constant contexts as being in the default rounding mode.

rsmith added inline comments. Comment at: clang/test/SemaCXX/rounding-math.cpp:9 + +constexpr int f(int n) { return int(n * (1.0 / 3.0)); } + rsmith wrote: > sepavloff wrote: > > This code requires additional solution. The function body is built using > >

[PATCH] D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex

kastiglione added a comment. @martong here's a partial backtrace: 3: LLDB`llvm::llvm_unreachable_internal(char const*, char const*, unsigned int) 4: LLDB`clang::AttributeCommonInfo::calculateAttributeSpellingListIndex() const 5: LLDB`clang::ASTImporter::Import(clang::Attr const*) 6:

[clang] 8b6d1c0 - [ADT] Use alignas + sizeof for inline storage, NFC

Author: Reid Kleckner Date: 2020-10-14T16:16:02-07:00 New Revision: 8b6d1c0467b2dfa14cb2d2dec7637bf95c78364b URL: https://github.com/llvm/llvm-project/commit/8b6d1c0467b2dfa14cb2d2dec7637bf95c78364b DIFF: https://github.com/llvm/llvm-project/commit/8b6d1c0467b2dfa14cb2d2dec7637bf95c78364b.diff

[PATCH] D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex

kastiglione added a comment. @martong hi, this caused a test regression. In `TestImportBuiltinFileID.py`, this unreachable assertion is hit: Ignored/unknown shouldn't get here UNREACHABLE executed at tools/clang/include/clang/Sema/AttrSpellingListIndex.inc:13! See

[PATCH] D66782: SourceManager: Prefer Optional over MemoryBuffer*

dexonsmith abandoned this revision. dexonsmith added a comment. I finished reimplementing this patch mostly as discussed, culminating in https://reviews.llvm.org/D89431. I've rebased https://reviews.llvm.org/D89431 on top of that. Abandoning this revision. CHANGES SINCE LAST ACTION

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

rnk added a comment. I'd like to point out that we used to have a very similar flag, but we removed it back in 2014: http://reviews.llvm.org/D2545 Are you sure you need all the flexibility that this flag allows? For example, this will let users ask for the MSVC C++ ABI on Linux. I really don't

[PATCH] D67030: ContentCache: Simplify by always owning the MemoryBuffer

dexonsmith updated this revision to Diff 298257. dexonsmith edited the summary of this revision. dexonsmith added a comment. Rebased on top of https://reviews.llvm.org/D89431 (the tests haven't finished yet; I'll update if necessary, but this is pretty straightforward). CHANGES SINCE LAST

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-static-member.cpp:144-147 +// For some reason, const_va is not emitted when the target is MS. +// NOT-MS: !DIDerivedType(tag: DW_TAG_member, name: "const_va",

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang updated this revision to Diff 298258. akhuang marked an inline comment as done. akhuang added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https://reviews.llvm.org/D89072 Files:

Re: [clang] 683b308 - [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

Updated with 8487bfd4e9ae186f9f588ef989d27a96cc2438c9 On Wed, Oct 14, 2020 at 1:53 PM Richard Smith wrote: > On Wed, 14 Oct 2020 at 12:31, Leonard Chan via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> Author: Leonard Chan >> Date: 2020-10-14T12:31:21-07:00 >> New Revision:

[clang] 8487bfd - [clang][NFC] Change diagnostic to start with lowercase letter

Author: Leonard Chan Date: 2020-10-14T15:48:29-07:00 New Revision: 8487bfd4e9ae186f9f588ef989d27a96cc2438c9 URL: https://github.com/llvm/llvm-project/commit/8487bfd4e9ae186f9f588ef989d27a96cc2438c9 DIFF: https://github.com/llvm/llvm-project/commit/8487bfd4e9ae186f9f588ef989d27a96cc2438c9.diff

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai added a subscriber: ldionne. smeenai added a comment. In D89177#2326875 , @phosek wrote: > In D89177#2326832 , @smeenai wrote: > >> In D89177#2325566 , @phosek

[PATCH] D89431: clang/Basic: ContentCache::InvalidFlag => ContentCache::IsBufferInvalid, NFC

dexonsmith updated this revision to Diff 298252. dexonsmith added a comment. Add missing constructor initializations for the new bitfield member... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89431/new/ https://reviews.llvm.org/D89431 Files:

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai updated this revision to Diff 298251. smeenai added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177 Files: clang/cmake/caches/MultiDistributionExample.cmake

[PATCH] D89431: clang/Basic: ContentCache::InvalidFlag => ContentCache::IsBufferInvalid, NFC

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Move a flag out of the `MemoryBuffer*` to unblock changing it to a `unique_ptr`. There are plenty of bits available in the bitfield below.

[PATCH] D89430: clang/Basic: Remove SourceManager::getBufferPointer, NFC

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Inline `Source::getBufferPointer` into its only remaining caller, `getBufferOrNone`. No functionality change.

[PATCH] D89429: clang/Basic: Replace SourceManager::getMemoryBufferForFile, NFC

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Replace `SourceManager::getMemoryBufferForFile`, which returned a dereferenceable `MemoryBuffer*` and had a `bool*Invalid` out parameter,

[PATCH] D89366: [WebAssembly] v128.load{8, 16, 32, 64}_lane instructions

aheejin added a comment. Do loads need the vector argument? The proposal has that but I'm wondering why... Can that possibly be an error from the author's side? Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:180 +TARGET_BUILTIN(__builtin_wasm_load32_lane,

Re: [PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

On Wed, Oct 14, 2020 at 6:10 PM Kadir Cetinkaya via Phabricator < revi...@reviews.llvm.org> wrote: > kadircet added a comment. > > In D89277#2329947 , @sammccall > wrote: > > > (sorry out today and haven't looked at code yet) > > no worries it is a

[PATCH] D89372: [OpenCL] Remove unused extensions

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:16 // // If the extensions are to be enumerated without the supported OpenCL version, // define OPENCLEXT(ext) where ext is the name of the extension. yaxunl wrote: >

[PATCH] D88603: [WebAssembly] Add support for DWARF type units

dschuff added inline comments. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:962 + case Triple::Wasm: +return Ctx->getWasmSection(Name, SectionKind::getMetadata(), utostr(Hash), + ~0); dblaikie wrote: > dschuff wrote: > >

[clang] e7b4fee - [Format/ObjC] Add NS_SWIFT_NAME() and CF_SWIFT_NAME() to WhitespaceSensitiveMacros

Author: Ben Hamilton Date: 2020-10-14T15:42:51-06:00 New Revision: e7b4feea8e1bf520b34ad8c116abab6677344b74 URL: https://github.com/llvm/llvm-project/commit/e7b4feea8e1bf520b34ad8c116abab6677344b74 DIFF: https://github.com/llvm/llvm-project/commit/e7b4feea8e1bf520b34ad8c116abab6677344b74.diff

[PATCH] D89425: [Format/ObjC] Add NS_SWIFT_NAME() and CF_SWIFT_NAME() to WhitespaceSensitiveMacros

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7b4feea8e1b: [Format/ObjC] Add NS_SWIFT_NAME() and CF_SWIFT_NAME() to… (authored by benhamilton). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89425/new/

[PATCH] D89286: [DebugInfo] Check for templated static data member when adding constant to record static fields

akhuang updated this revision to Diff 298243. akhuang added a comment. update test case and add check for dependent values Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89286/new/ https://reviews.llvm.org/D89286 Files:

[PATCH] D89427: clang/Frontend: Use MemoryBufferRef in FrontendInputFile (and remove SourceManager::getBuffer)

dexonsmith updated this revision to Diff 298242. dexonsmith added a comment. Adding a couple of changes I forgot to stage (remove now-unused `UnownedTag` and a minor simplification to `createFileID`). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89427/new/

[PATCH] D89276: Support ObjC in IncludeInserter

compositeprimes updated this revision to Diff 298241. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89276/new/ https://reviews.llvm.org/D89276 Files: clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp

[PATCH] D89414: clang/StaticAnalyzer: Stop using SourceManager::getBuffer

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Sounds good! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89414/new/ https://reviews.llvm.org/D89414 ___ cfe-commits

[PATCH] D89427: clang/Frontend: Use MemoryBufferRef in FrontendInputFile (and remove SourceManager::getBuffer)

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. In order to drop the final callers to `SourceManager::getBuffer`, change `FrontendInputFile` to use `Optional`. Also updated the "unowned"

[clang] 0ff9116 - Register TargetCXXABI.def as a textual header

Author: Adrian Prantl Date: 2020-10-14T14:20:39-07:00 New Revision: 0ff9116b36781d6fa61c25841edd53dc8f366bec URL: https://github.com/llvm/llvm-project/commit/0ff9116b36781d6fa61c25841edd53dc8f366bec DIFF: https://github.com/llvm/llvm-project/commit/0ff9116b36781d6fa61c25841edd53dc8f366bec.diff

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

leonardchan added a comment. > This change implement a slightly different approach from what we discussed, > which is providing an Itanium-compatible (that is `-fc++abi=itanium`) > multilib for compatibility with other compilers, and then enabling relative > vtables by default. Unless there's

Re: [clang] 683b308 - [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

On Wed, 14 Oct 2020 at 12:31, Leonard Chan via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Leonard Chan > Date: 2020-10-14T12:31:21-07:00 > New Revision: 683b308c07bf827255fe1403056413f790e03729 > > URL: >

[PATCH] D89425: [Format/ObjC] Add NS_SWIFT_NAME() and CF_SWIFT_NAME() to WhitespaceSensitiveMacros

benhamilton created this revision. benhamilton added reviewers: sammccall, JakeMerdichAMD, curdeius. Herald added a project: clang. Herald added a subscriber: cfe-commits. benhamilton requested review of this revision. The argument passed to the preprocessor macros `NS_SWIFT_NAME(x)` and

[PATCH] D89372: [OpenCL] Remove unused extensions

yaxunl added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:16 // // If the extensions are to be enumerated without the supported OpenCL version, // define OPENCLEXT(ext) where ext is the name of the extension. Can you add a

[PATCH] D89221: [clang-rename] Fix rename on function template specializations.

kbobyrev requested changes to this revision. kbobyrev added a comment. This revision now requires changes to proceed. And indeed I did miss that :( Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89221/new/ https://reviews.llvm.org/D89221

[PATCH] D89372: [OpenCL] Remove unused extensions

yaxunl added a comment. In D89372#2330868 , @Anastasia wrote: >> Does the spec requires cl_* macro to be defined if an extension is enabled? > > The extension spec currently has: > > Every extension which affects the OpenCL language semantics, syntax or

[PATCH] D89286: [DebugInfo] Check for templated static data member when adding constant to record static fields

akhuang added a subscriber: rsmith. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1421-1425 + else if (auto *TemplateDecl = Var->getInstantiatedFromStaticDataMember()) { +// Inline static data members might not have an initialization. +if

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

phosek added a comment. In D85576#2330923 , @leonardchan wrote: > This should also be ready now that https://reviews.llvm.org/D85802 landed, > unless we don't want to submit this *right* now so the clang builders don't > build these multilibs that won't

[clang] 633f9fc - Make header self-contained. NFC.

Author: Benjamin Kramer Date: 2020-10-14T22:03:19+02:00 New Revision: 633f9fcb820bf01d59cdcdd8038889eec61cf2f2 URL: https://github.com/llvm/llvm-project/commit/633f9fcb820bf01d59cdcdd8038889eec61cf2f2 DIFF:

[PATCH] D89348: clang/Basic: Replace ContentCache::getBuffer with Optional semantics

This revision was automatically updated to reflect the committed changes. Closed by commit rGd758f79e5d38: clang/Basic: Replace ContentCache::getBuffer with Optional semantics (authored by dexonsmith). Herald added a project: clang. Changed prior to commit:

[clang] d758f79 - clang/Basic: Replace ContentCache::getBuffer with Optional semantics

Author: Duncan P. N. Exon Smith Date: 2020-10-14T15:55:18-04:00 New Revision: d758f79e5d381bd4f5122193a9538d89c907c812 URL: https://github.com/llvm/llvm-project/commit/d758f79e5d381bd4f5122193a9538d89c907c812 DIFF:

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

leonardchan added a comment. This should also be ready now that https://reviews.llvm.org/D85802 landed, unless we don't want to submit this *right* now so the clang builders don't build these multilibs that won't be used yet? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89414: clang/StaticAnalyzer: Stop using SourceManager::getBuffer

dexonsmith updated this revision to Diff 298223. dexonsmith added a comment. Fix a warning about an unused `Invalid` flag. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89414/new/ https://reviews.llvm.org/D89414 Files: clang/lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp

[PATCH] D89372: [OpenCL] Remove unused extensions

Anastasia added a comment. In D89372#2330822 , @yaxunl wrote: > In D89372#2330362 , @Anastasia wrote: > >> In D89372#2330217 , @yaxunl wrote: >> >>> With this change, clang

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG683b308c07bf: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use (authored by leonardchan). Changed prior to commit:

[clang] 683b308 - [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

Author: Leonard Chan Date: 2020-10-14T12:31:21-07:00 New Revision: 683b308c07bf827255fe1403056413f790e03729 URL: https://github.com/llvm/llvm-project/commit/683b308c07bf827255fe1403056413f790e03729 DIFF: https://github.com/llvm/llvm-project/commit/683b308c07bf827255fe1403056413f790e03729.diff

[PATCH] D89372: [OpenCL] Remove unused extensions

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:74 OPENCLEXT_INTERNAL(cl_khr_mipmap_image_writes, 200, ~0U) -OPENCLEXT_INTERNAL(cl_khr_srgb_image_writes, 200, ~0U) OPENCLEXT_INTERNAL(cl_khr_subgroups, 200, ~0U)

[PATCH] D89372: [OpenCL] Remove unused extensions

yaxunl added a comment. In D89372#2330362 , @Anastasia wrote: > In D89372#2330217 , @yaxunl wrote: > >> With this change, clang basically will have no knowledge about the removed >> extensions, i.e., it will not

[PATCH] D88976: [clang] Use correct address space for global variable debug info

scott.linder added inline comments. Comment at: clang/lib/Basic/Targets/NVPTX.h:47 -1, // Default, opencl_private or opencl_generic - not defined -5, // opencl_global +-1, // opencl_global -1, Does anyone have any thoughts on this change

[PATCH] D89366: [WebAssembly] v128.load{8, 16, 32, 64}_lane instructions

tlively requested review of this revision. tlively added a comment. The structure is the same, but I would appreciate a review of the diff since a lot of things had to change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89366/new/

[PATCH] D89366: [WebAssembly] v128.load{8, 16, 32, 64}_lane instructions

tlively updated this revision to Diff 298209. tlively marked 2 inline comments as done. tlively added a comment. This revision is now accepted and ready to land. - Add missing vec argument to loads and fix argument order - Add comments and fix formatting Repository: rG LLVM Github Monorepo

[PATCH] D88227: [clang-format] Add a SpaceAroundPointerQualifiers style option

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88227/new/ https://reviews.llvm.org/D88227

[PATCH] D89416: clang-{tools,unittests}: Stop using SourceManager::getBuffer, NFC

dexonsmith updated this revision to Diff 298206. dexonsmith added a comment. Removed the now-unused `Invalid` local variable from the libclang change; not sure how I missed the warning before. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89416/new/ https://reviews.llvm.org/D89416

[PATCH] D89276: Support ObjC in IncludeInserter

compositeprimes updated this revision to Diff 298203. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89276/new/ https://reviews.llvm.org/D89276 Files: clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2165 +assert(getContext().getTargetAddressSpace(FI.arg_begin()->type) == 0 && + "Expected `this` pointer without address space attribute."); + jdoerfert wrote: > I'm unsure why

[PATCH] D89416: clang-{tools,unittests}: Stop using SourceManager::getBuffer, NFC

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added subscribers: usaxena95, ributzka, kadircet. Herald added a reviewer: shafik. dexonsmith requested review of this revision. Update clang-tools-extra, clang/tools, clang/unittests to migrate from

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Basic/PartialDiagnostic.h:51 + : DiagID(DiagID) { +Allocator = _; + } tra wrote: > Is there a particular reason to move field initialization into the

[PATCH] D89407: [clang-tidy] Add scoped enum constants to identifier naming check

njames93 updated this revision to Diff 298200. njames93 added a comment. Small tweak to the docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89407/new/ https://reviews.llvm.org/D89407 Files:

[PATCH] D89372: [OpenCL] Remove unused extensions

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:74 OPENCLEXT_INTERNAL(cl_khr_mipmap_image_writes, 200, ~0U) -OPENCLEXT_INTERNAL(cl_khr_srgb_image_writes, 200, ~0U) OPENCLEXT_INTERNAL(cl_khr_subgroups, 200, ~0U)

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

njames93 added a comment. Is this diff been created incorrectly again? Taking a step back, Is Hungarian notation really a case style, Seems to me its mainly about the prefix and a user may want `DWORD dwUPPER_CASE`, Right now there is no way of adopting that. Maybe extend the options for

[PATCH] D89414: clang/StaticAnalyzer: Stop using SourceManager::getBuffer

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added subscribers: steakhal, ASDenysPetrov, martong, ributzka, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. dexonsmith requested review of this revision. Update clang/lib/StaticAnalyzer to stop

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

tra added inline comments. Comment at: clang/include/clang/Basic/PartialDiagnostic.h:51 + : DiagID(DiagID) { +Allocator = _; + } Is there a particular reason to move field initialization into the body here and in other constructors? CHANGES SINCE

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

MaskRay added a comment. In case my previous comment is not clear: we can do renaming in LLVM, but the benefit is small (for a few libcalls (only some really simple libcalls) with custom code emitting, if they have `asm(...)`, they are now optimizable). We will require a renaming

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added a comment. In D86119#2330601 , @jdenny wrote: > In D86119#2330339 , @ABataev wrote: > >> In D86119#2330310 , @jdenny wrote: >> >>> Thanks for working on this.

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

jdenny added a comment. In D86119#2330339 , @ABataev wrote: > In D86119#2330310 , @jdenny wrote: > >> Thanks for working on this. Sorry to take so long to review. Before I try >> to digest the code, I have a few

  1   2   >