[PATCH] D90975: [clangd] Don't run clang-tidy AST traversal if there are no checks.

This revision was automatically updated to reflect the committed changes. Closed by commit rG053110b22aa9: [clangd] Dont run clang-tidy AST traversal if there are no checks. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 053110b - [clangd] Don't run clang-tidy AST traversal if there are no checks.

Author: Sam McCall Date: 2020-11-09T08:44:06+01:00 New Revision: 053110b22aa93b1f7bccdb0dae9dea7f755b045c URL: https://github.com/llvm/llvm-project/commit/053110b22aa93b1f7bccdb0dae9dea7f755b045c DIFF: https://github.com/llvm/llvm-project/commit/053110b22aa93b1f7bccdb0dae9dea7f755b045c.diff

[PATCH] D90116: [llvm] CMake: Force MSVC to read code as UTF-8

ArcsinX added inline comments. Comment at: llvm/CMakeLists.txt:604 + add_compile_options("$<$:/utf-8>") + add_compile_options("$<$:/utf-8>") else() I think we could replace these two lines with the one line ``` add_compile_options(/utf-8) ``` Because we could

[PATCH] D90116: [clangd] Escape Unicode characters to fix Windows builds

kbobyrev updated this revision to Diff 303754. kbobyrev added a comment. Rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90116/new/ https://reviews.llvm.org/D90116 Files: llvm/CMakeLists.txt Index: llvm/CMakeLists.txt

[PATCH] D90116: [clangd] Escape Unicode characters to fix Windows builds

kbobyrev updated this revision to Diff 303753. kbobyrev added a comment. Herald added subscribers: llvm-commits, mgorny. Herald added a project: LLVM. Force MSVC to read code as UTF-8 via CMake options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91047: Add a call super attribute plugin example

psionic12 created this revision. psionic12 added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. psionic12 requested review of this revision. If a virtual method is marked as call_super, the override method must call it, simpler feature

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

zinovy.nis updated this revision to Diff 303750. zinovy.nis edited the summary of this revision. zinovy.nis added a comment. auto -> const auto. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91037/new/ https://reviews.llvm.org/D91037 Files:

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

zinovy.nis added a comment. In D91037#2381606 , @njames93 wrote: > Think this has an incorrect name, seems to have something to do with > `bugprone-redundant-branch-condition` Oops, thanks to autofill. Fixed. Repository: rG LLVM Github Monorepo

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous updated this revision to Diff 303749. nomanous added a comment. Some more format fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D89242: [PowerPC] [Clang] Port SSE4.1-compatible insert intrinsics

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89242/new/ https://reviews.llvm.org/D89242

[PATCH] D89242: [PowerPC] [Clang] Port SSE4.1-compatible insert intrinsics

qiucf added a comment. Ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89242/new/ https://reviews.llvm.org/D89242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D89296: [clangd] Implement call hierarchy (incoming calls)

nridge added a reviewer: kadircet. nridge added a comment. Kadir, would you like to take a look at this, as you're already familiar with the index changes? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89296/new/

[PATCH] D91037: [clang-tidy][bugprone-use-after-mnove] Warn on std::move for consts

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp:87 + if (!BinOpCond) +if (auto *ExprWithCleanupsCond = +dyn_cast_or_null(InnerIf->getCond())) Please fix warning.

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

aeubanks updated this revision to Diff 303737. aeubanks added a comment. Herald added a subscriber: dexonsmith. check if pass manager is empty before adding Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89158/new/ https://reviews.llvm.org/D89158

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

belliash added a comment. When do you plan to enable this on x86? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___ cfe-commits mailing list

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 303733. kbobyrev added a comment. Store progress. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-extra/clangd/refactor/Rename.cpp

[PATCH] D91037: [clang-tidy][bugprone-use-after-mnove] Warn on std::move for consts

njames93 added a comment. Think this has an incorrect name, seems to have something to do with `bugprone-redundant-branch-condition` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91037/new/ https://reviews.llvm.org/D91037

[PATCH] D91009: Include std::basic_string_view in readability-redundant-string-init.

njames93 added a comment. You don't really need to duplicate every single `std::string` test. Just enough so that it detects it, kind of like `::out::TestString`. Also can you update the docs and release notes to explain this behaviour. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D91037: [clang-tidy][bugprone-use-after-mnove] Warn on std::move for consts

zinovy.nis created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. zinovy.nis requested review of this revision. Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups. Bug: https://bugs.llvm.org/show_bug.cgi?id=48008. Repository:

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

steveire updated this revision to Diff 303728. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90982/new/ https://reviews.llvm.org/D90982 Files: clang/include/clang/AST/ASTNodeTraverser.h

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

steveire added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-make-shared.cpp:51 // CHECK-FIXES: std::shared_ptr P1 = std::make_shared(); + std::shared_ptr P2 = std::shared_ptr(new int); ckennelly wrote: > steveire

[PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum

faisalv created this revision. faisalv added reviewers: aaron.ballman, bruno, BRevzin, wchilders. faisalv added a project: clang. faisalv requested review of this revision. [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum Repository: rG LLVM Github Monorepo

[clang-tools-extra] 4dde325 - [clang-tidy] Fix build for gcc5.3 after d725f1ce

Author: Nathan James Date: 2020-11-08T17:25:18Z New Revision: 4dde325004da32fa1a036accd544f57addab9f0c URL: https://github.com/llvm/llvm-project/commit/4dde325004da32fa1a036accd544f57addab9f0c DIFF: https://github.com/llvm/llvm-project/commit/4dde325004da32fa1a036accd544f57addab9f0c.diff LOG:

[clang] 09fc779 - [NFC][tests] Replace use of GNUisms in usage of diff

Author: Hubert Tong Date: 2020-11-08T12:07:51-05:00 New Revision: 09fc7796e57417071523c82bdac8b3bf050648a0 URL: https://github.com/llvm/llvm-project/commit/09fc7796e57417071523c82bdac8b3bf050648a0 DIFF: https://github.com/llvm/llvm-project/commit/09fc7796e57417071523c82bdac8b3bf050648a0.diff

[PATCH] D91033: GNU nano 4.8 /tmp/edit.7czvmlx7um4go4c0/commit-message Modified [clang-tidy][NFC] Tweak GlobList to iterate backwards

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 requested review of this revision. By iterating backwards over the globs we can exit the loop as soon as we find a

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 updated this revision to Diff 303723. njames93 added a comment. Fix last compile error, check-clangd ran without a hitch. Testing the binary in another project seems to work ok. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91029/new/

[PATCH] D90534: [clang-format] Add new option PenaltyIndentedWhitespace

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90534/new/ https://reviews.llvm.org/D90534

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 updated this revision to Diff 303721. njames93 added a comment. Fix compile errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91029/new/ https://reviews.llvm.org/D91029 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 updated this revision to Diff 303720. njames93 added a comment. Fix potential race when updating cache in `FileTidyProvider`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91029/new/ https://reviews.llvm.org/D91029 Files:

[PATCH] D90992: [clang-tidy] Use vfs::FileSystem when getting config

thakis added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:366 } -return OptionsSource(*ParsedOptions, ConfigFile.c_str()); +return OptionsSource(*ParsedOptions, ConfigFile.str()); } This breaks bootstrap builds

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous updated this revision to Diff 303712. nomanous added a comment. Some format fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous updated this revision to Diff 303709. nomanous added a comment. In this update I delete some extra test code, move several comments and split the new type comparing code into a new function to make sure that the commonly used old type comparing function not affected by it.

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgorny. Herald added a project: clang. njames93 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Added some new

[clang] 8930032 - Don't dereference a dyn_cast<> result - use cast<> instead. NFCI.

Author: Simon Pilgrim Date: 2020-11-08T13:06:07Z New Revision: 8930032f53322405ca2d06cac78b9503542e5b62 URL: https://github.com/llvm/llvm-project/commit/8930032f53322405ca2d06cac78b9503542e5b62 DIFF: https://github.com/llvm/llvm-project/commit/8930032f53322405ca2d06cac78b9503542e5b62.diff

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

aeubanks reopened this revision. aeubanks added a comment. This revision is now accepted and ready to land. need to fix new-pass-manager.ll when polly is enabled Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89158/new/

[PATCH] D90221: Include more attribute details when dumping AST in JSON

aronsky added a comment. In D90221#2379793 , @aaron.ballman wrote: > I think the issue is that ASTNodeTraverser is visiting all of the attribute > arguments (around ASTNodeTraverse.h:726) and your patch also visits them (as > part of what's emitted

[clang] 226e179 - Revert "[NewPM] Provide method to run all pipeline callbacks, used for -O0"

Author: Arthur Eubanks Date: 2020-11-08T00:32:35-08:00 New Revision: 226e179f7400025d3d320a6f63ded7d747d25c4a URL: https://github.com/llvm/llvm-project/commit/226e179f7400025d3d320a6f63ded7d747d25c4a DIFF: