[PATCH] D91975: clang-tidy: detect narrowing conversions involving typedefs

gridaphobe created this revision. Herald added subscribers: cfe-commits, kbarton, nemanjai. Herald added a project: clang. gridaphobe requested review of this revision. The check 'cppcoreguidelines-narrowing-conversions' does not detect conversions involving typedef. This notably includes the stan

[PATCH] D91966: [clangd] AddUsing: Used spelled text instead of type name.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:268 + SpelledTokens->back()); + llvm::StringRef NameRef = SpelledRange.text(SM); + what about saving the full rang

[PATCH] D91531: [RFC][OpenCL] Provide mechanisms for defining extension macros

azabaznov added a comment. > Perhaps if you give me an example it would help to understand I was meant that this can potentially be used to undefine macros inside clang directly. In this case there will no need to add a lot of conditional preprocessor directives in the header, also the existing

[PATCH] D91974: [PowerPC] Rename the pair intrinsics and builtins to replace the _mma_ prefix by _vsx_

bsaleil created this revision. bsaleil added reviewers: nemanjai, amyk, saghir, lei, PowerPC. bsaleil added projects: PowerPC, LLVM. Herald added subscribers: llvm-commits, cfe-commits, shchenz, kbarton, hiraditya. Herald added a project: clang. bsaleil requested review of this revision. On PPC,

[PATCH] D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base.

aaronpuchert added a comment. Thread safety attributes want **callers** of a function to have the same attribute, while this change wants **callees** to have the same attribute. So the attributes propagate in different directions. By contraposition

[PATCH] D90282: [clang-tidy] Add IgnoreShortNames config to identifier naming checks

njames93 accepted this revision. njames93 added a comment. LGTM, before you push this, can you edit the summary and title as its no longer about just the length of the name. Otherwise the commit message will likely lead to confusion on whats being added. CHANGES SINCE LAST ACTION https://rev

[PATCH] D91531: [RFC][OpenCL] Provide mechanisms for defining extension macros

Anastasia added a comment. In D91531#2406390 , @azabaznov wrote: > Yes, in general this approach looks good to me conceptually. I have two > suggestions: > > 1. As we discussed, the term //core functionality// should be revisited here. > There's no clear

[PATCH] D72184: [BPF] support atomic instructions

jackmanb added a comment. > I did not see kernel has atomic_store, do you mean atomic_set? Sorry yep I meant `atomic_set` > Do you suggest we also implement atomic_set? There is no need for 64-bit > architecture like x64, right? Yeah actually now I think about it, `atomic_set` is pretty pointl

[PATCH] D88220: [C++20] P1825R0: More implicit moves

Quuxplusone added inline comments. Comment at: clang/include/clang/Sema/Sema.h:4626 CES_AllowExceptionVariables = 4, -CES_FormerDefault = (CES_AllowParameters), -CES_Default = (CES_AllowParameters | CES_AllowDifferentTypes), -CES_AsIfByStdMove = (CES_AllowParamet

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song added a comment. Ya, the above llvm crash is expected as bpf backend does not handle AtomicStore. For kernel code, I can see: kvm/x86.c: vcpu->arch.nmi_pending += atomic_xchg(&vcpu->arch.nmi_queued, 0); ... kvm/x86.c: atomic_set(&kvm_guest_has_master_clock,

[PATCH] D90928: [OpenCL] Check for extension string extension lookup

Anastasia added a comment. In D90928#2408249 , @erik2020 wrote: > In D90928#2405796 , @Anastasia wrote: > >> Do you think we could improve testing? I presume there is something that >> triggers a failure without yo

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks for the changes. From what I can tell, this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91695/new/ https://reviews.llvm.org/D91

Re: [clang-tools-extra] 76bd444 - Fix tests for clang-query completion

On Mon, Nov 23, 2020 at 10:34 AM Nico Weber via cfe-commits wrote: > > Thanks for fixing the tests, but didn't the tests point out a true regression > in clang-query functionality here? We removed the IgnoreImplicitCastsAndParentheses traversal mode (it was poorly supported and obviated by Ignor

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

MarkMurrayARM updated this revision to Diff 307083. MarkMurrayARM added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91695/new/ https://reviews.llvm.org/D91695 Files: clang/test/Driver/aarch64-cpus.c clang/test/Driver/arm-c

Re: [clang-tools-extra] 76bd444 - Fix tests for clang-query completion

Thanks for fixing the tests, but didn't the tests point out a true regression in clang-query functionality here? On Mon, Nov 23, 2020 at 10:23 AM Stephen Kelly via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Stephen Kelly > Date: 2020-11-23T15:23:13Z > New Revision: 76bde3619

[PATCH] D91315: [RISCV] Handle zfh in the arch string.

luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91315/new/ https://reviews.llvm.org/D91315 __

[PATCH] D90188: Add support for attribute 'using_if_exists'

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:442 +// Make the selection of the recovery decl deterministic. +(RealRes)->getLocation().getRawEncoding() < IIDecl->getLocation().getRawEncoding())

[clang-tools-extra] 76bd444 - Fix tests for clang-query completion

Author: Stephen Kelly Date: 2020-11-23T15:23:13Z New Revision: 76bde36197465f1c72f4b6f1d59721012a59 URL: https://github.com/llvm/llvm-project/commit/76bde36197465f1c72f4b6f1d59721012a59 DIFF: https://github.com/llvm/llvm-project/commit/76bde36197465f1c72f4b6f1d59721012a59.diff LOG:

[PATCH] D72184: [BPF] support atomic instructions

jackmanb added a comment. BTW to investigate my previous comment I tried compiling this code: // SPDX-License-Identifier: GPL-2.0 #include #include #include __u64 add64_value = 1; __u64 add64_result; __u32 add32_value = 1; __u32 add32_result; __u64 add_stack_value_copy;

[PATCH] D72184: [BPF] support atomic instructions

jackmanb added a comment. I thought a little more about something I was saying in the office hours. I'm pretty sure GCC's `__atomic_store(&x, &y, order)` should fail to compile for anything other than `order=__ATOMIC_RELAXED`, since with the current kernel patchset we have `BPF_SET` (which is c

[PATCH] D91966: [clangd] AddUsing: Used spelled text instead of type name.

adamcz created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. adamcz requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This improves the behavior related to type aliases, as well as cases of typ

[PATCH] D91949: [clang-format] Add BreakBeforeStructInitialization configuration

MyDeveloperDay added a comment. Could you make you patch with a full context diff, plus we really want unit tests for all changes if you change Format.h you need to regenerate the ClangFormatStyleOptions.rst by running dump_style.py in clang/docs/tools Repository: rG LLVM Github Monorepo C

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

MyDeveloperDay added a comment. 1. this needs a full context diff (diff -U 99) 2. this needs unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91950/new/ https://reviews.llvm.org/D91950 ___ c

[PATCH] D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base.

aaron.ballman added reviewers: aaronpuchert, delesley. aaron.ballman added a comment. This feels an awful lot like a set of attributes we already have -- can capability attributes be used for this instead? https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#basic-concepts-capabilities The doc

[PATCH] D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check

aaron.ballman added a comment. In D91055#2410447 , @lebedev.ri wrote: > Ping. > If there's no pushback within next 24h i will commit this and wait for > post-commit review (if any). > Thanks. FWIW, that's not the way we usually do things, so please don't

[PATCH] D91916: Remove automatic traversal from forEach matcher

thakis added a comment. Looks like this broke clang-query tests: http://45.33.8.238/linux/33556/step_8.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91916/new/ https://reviews

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro updated this revision to Diff 307067. ro added a comment. Herald added a project: LLVM. - Move declarations to new `sanitizer_solaris.h`. - Augment `check_linker_flag` do reject unknown `-z` options that GNU ld noisily accepts. Tested on `amd64-pc-solaris2.11`, `sparcv9-sun-solaris2.11`, and

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:614 + if (CRD->isUnion()) +return ""; + Returning {} as default initializer will be better. Same in other places. Repository: rG LLVM Gi

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro added inline comments. Comment at: clang/tools/driver/CMakeLists.txt:123 + +check_linker_flag("-Wl,-z,relax=transtls" LINKER_SUPPORTS_Z_RELAX_TRANSTLS) MaskRay wrote: > ro wrote: > > MaskRay wrote: > > > ro wrote: > > > > MaskRay wrote: > > > > > GNU ld report

[PATCH] D91918: Remove the IgnoreImplicitCastsAndParentheses traversal kind

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e1801813d93: Remove the IgnoreImplicitCastsAndParentheses traversal kind (authored by stephenkelly). Changed prior to commit: https://reviews.llv

[PATCH] D91917: Update mode used in traverse() examples

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf052cf494f07: Update mode used in traverse() examples (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91916: Remove automatic traversal from forEach matcher

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG72a9f365e993: Remove automatic traversal from forEach matcher (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 5e18018 - Remove the IgnoreImplicitCastsAndParentheses traversal kind

Author: Stephen Kelly Date: 2020-11-23T14:27:48Z New Revision: 5e1801813d93210acae84ff3c68a01512c2df9bc URL: https://github.com/llvm/llvm-project/commit/5e1801813d93210acae84ff3c68a01512c2df9bc DIFF: https://github.com/llvm/llvm-project/commit/5e1801813d93210acae84ff3c68a01512c2df9bc.diff LOG:

[clang] f052cf4 - Update mode used in traverse() examples

Author: Stephen Kelly Date: 2020-11-23T14:27:48Z New Revision: f052cf494f07a33af5aa7c680cfe0bfcca24beae URL: https://github.com/llvm/llvm-project/commit/f052cf494f07a33af5aa7c680cfe0bfcca24beae DIFF: https://github.com/llvm/llvm-project/commit/f052cf494f07a33af5aa7c680cfe0bfcca24beae.diff LOG:

[clang] 72a9f36 - Remove automatic traversal from forEach matcher

Author: Stephen Kelly Date: 2020-11-23T14:27:47Z New Revision: 72a9f365e9933d68645f796592932a27d11bbfd0 URL: https://github.com/llvm/llvm-project/commit/72a9f365e9933d68645f796592932a27d11bbfd0 DIFF: https://github.com/llvm/llvm-project/commit/72a9f365e9933d68645f796592932a27d11bbfd0.diff LOG:

[PATCH] D90282: [clang-tidy] Add IgnoreShortNames config to identifier naming checks

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please wait for @njames93 in case they have additional feedback. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h:64 +

[PATCH] D91930: [clangd] Implement textDocument/codeLens

kadircet added a comment. Thanks a lot for working on improving clangd! Can you also give a high-level overview of what kind of functionality you are providing here? Looks like there's a lot going on here, and it would be nice to know what you are attempting to do, rather than inferring that fr

[PATCH] D91915: [clang-tidy] Fix RenamerClangTidy checks trying to emit a fix that isnt a valid identifier

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91915/new/ https://reviews.llvm.org/D91915 ___ cfe-commits mailing list cfe-commit

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:616-619 + if (CRD->isStruct() && !isHungarianNotationOptionEnabled("TreatStructAsClass", + HNOption.Gen

[PATCH] D91918: Remove the IgnoreImplicitCastsAndParentheses traversal kind

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a documentation request, thank you for this cleanup! Comment at: clang/docs/ReleaseNotes.rst:237 +- The TK_IgnoreImplicitCastsAndParentheses t

[PATCH] D91916: Remove automatic traversal from forEach matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91916/new/ https://reviews.llvm.org/D91916 __

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4062 + if ((FLAGS)&options::CC1Option) { \ +const auto &Extracted = EXTRACTOR(this->KEYPATH); \ +if (ALWAYS_EMI

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

jakubjelinek added a comment. In D87974#2409829 , @zoecarver wrote: > @jwakely It looks like `UnsizedTail` causes a crash. Filed https://gcc.gnu.org/PR97943 for that. Avoiding the crash is trivial, deciding what we want to do exactly for flexible array

[PATCH] D91917: Update mode used in traverse() examples

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91917/new/ https://reviews.llvm.org/D91917 __

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

aaron.ballman edited subscribers, added: ymandel; removed: aaron.ballman. aaron.ballman added a comment. In D89743#2409115 , @sammccall wrote: > In D89743#2409001 , @sammccall wrote: > >> We didn't talk about overlo

[PATCH] D91948: [WIP][analyzer][doc] Add Container- and IteratorModeling developer docs

dkrupp added a comment. In D91948#2411058 , @whisperity wrote: > Actually, while the explanation is understandable for me with additional > knowledge about the representation... I think it would be useful to add the > most simple example from the iterato

[PATCH] D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context

aaron.ballman added a comment. In D91828#2411210 , @thejh wrote: > In D91828#2411207 , @aaron.ballman > wrote: > >> In D91828#2411203 , @thejh wrote: >> >>> @aaron.ballman C

[clang] 00dad9d - Ignore noderef attribute in unevaluated context

Author: Jann Horn Date: 2020-11-23T08:10:35-05:00 New Revision: 00dad9d028ce31739b992a3ce2df5de054a9fa3c URL: https://github.com/llvm/llvm-project/commit/00dad9d028ce31739b992a3ce2df5de054a9fa3c DIFF: https://github.com/llvm/llvm-project/commit/00dad9d028ce31739b992a3ce2df5de054a9fa3c.diff LOG

[PATCH] D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context

thejh added a comment. In D91828#2411207 , @aaron.ballman wrote: > In D91828#2411203 , @thejh wrote: > >> @aaron.ballman Can you land it for me? I don't have commit access. > > Happy to do so -- are you okay with "

[PATCH] D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context

aaron.ballman added a comment. In D91828#2411203 , @thejh wrote: > @aaron.ballman Can you land it for me? I don't have commit access. Happy to do so -- are you okay with "Jann Horn " for author attribution? Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D91948: [WIP][analyzer][doc] Add Container- and IteratorModeling developer docs

Szelethus added a comment. I don't have the time to comb through this doc, unfortunately, but I want to applaud this effort to make the iterator checker family more accessible. Its certainly a forerunner in modeling tricky C++ constructs, and I can't wait to be a more valuable reviewer after be

[PATCH] D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context

thejh added a comment. @aaron.ballman Can you land it for me? I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91828/new/ https://reviews.llvm.org/D91828 ___ cfe-commits mailing

[PATCH] D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91828/new/ https://reviews.llvm.org/D91828 ___ cfe-commits mailing list cfe-commit

[PATCH] D91721: [clangd] textDocument/implementation (LSP layer)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb31486ad9717: [clangd] textDocument/implementation (LSP layer) (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang-tools-extra] b31486a - [clangd] textDocument/implementation (LSP layer)

Author: Utkarsh Saxena Date: 2020-11-23T13:50:44+01:00 New Revision: b31486ad971774c859e3e031fc0d8d9b77e3b083 URL: https://github.com/llvm/llvm-project/commit/b31486ad971774c859e3e031fc0d8d9b77e3b083 DIFF: https://github.com/llvm/llvm-project/commit/b31486ad971774c859e3e031fc0d8d9b77e3b083.diff

[PATCH] D91656: [clang-tidy] add concurrency module

segoon added a comment. In D91656#2411072 , @lebedev.ri wrote: > LGTM thanks for comments, fixed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 ___ cfe-commi

[PATCH] D83697: [clang][cli] Port Frontend option flags to new option parsing system

jansvoboda11 updated this revision to Diff 307045. jansvoboda11 added a comment. Drop namespace specifier & names of unused args, add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83697/new/ https://reviews.llvm.org/D83697 Files: clang/inc

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3576 +} else { + auto SectionCB = [this, CS](InsertPointTy AllocaIP, + InsertPointTy CodeGenIP, Meinersbur wrote: > In what situation would t

[PATCH] D91656: [clang-tidy] add concurrency module

segoon updated this revision to Diff 307039. segoon added a comment. - sort order - do not link with FrontendOpenMP CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-tools-extra/clang-ti

[PATCH] D83694: [clang][cli] Port DependencyOutput option flags to new option parsing system

jansvoboda11 updated this revision to Diff 307037. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83694/new/ https://reviews.llvm.org/D83694 Files: clang/include/clang/Driver/Options.td clang/lib/Frontend/Co

[clang-tools-extra] 61e538b - Revert "[clangd] testPath's final result agrees with the passed in Style"

Author: Kadir Cetinkaya Date: 2020-11-23T13:12:59+01:00 New Revision: 61e538b15ddb2de9250277d151f0f655c2220d9b URL: https://github.com/llvm/llvm-project/commit/61e538b15ddb2de9250277d151f0f655c2220d9b DIFF: https://github.com/llvm/llvm-project/commit/61e538b15ddb2de9250277d151f0f655c2220d9b.dif

[PATCH] D91656: [clang-tidy] add concurrency module

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clang-tidy/CMakeLists.txt:57-58 add_subdirectory(bugprone) add_subdirectory(cert) add_subdirectory(cppcoreguidelines) add_subdi

[PATCH] D83694: [clang][cli] Port DependencyOutput option flags to new option parsing system

jansvoboda11 added a comment. Addressed review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83694/new/ https://reviews.llvm.org/D83694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D83694: [clang][cli] Port DependencyOutput option flags to new option parsing system

jansvoboda11 updated this revision to Diff 307034. jansvoboda11 added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Reduce template instantiations, remove names of unused parameters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D91656: [clang-tidy] add concurrency module

segoon added a comment. jdoerfert, alexfh, hokein, aaron.ballman, Any comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D91948: [WIP][analyzer][doc] Add Container- and IteratorModeling developer docs

whisperity added a comment. Actually, while the explanation is understandable for me with additional knowledge about the representation... I think it would be useful to add the most simple example from the iterator checkers to the end of the document, how this whole thing ties together and how

[PATCH] D91948: [WIP][analyzer][doc] Add Container- and IteratorModeling developer docs

whisperity added a comment. In general, perhaps you should go over the rendered text once again and make use of //emph// and **bold** some more. Explanation looks okay from my part, although I'm really not knowledgeable about CSA internals. But there are plenty of "typesetting" issues. Do you h

[PATCH] D91947: [clangd] testPath's final result agrees with the passed in Style

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8cec8de2a4e6: [clangd] testPath's final result agrees with the passed in Style (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGE

[clang-tools-extra] 8cec8de - [clangd] testPath's final result agrees with the passed in Style

Author: Kadir Cetinkaya Date: 2020-11-23T12:45:06+01:00 New Revision: 8cec8de2a4e6692da6226bb02cf417eb0e50adde URL: https://github.com/llvm/llvm-project/commit/8cec8de2a4e6692da6226bb02cf417eb0e50adde DIFF: https://github.com/llvm/llvm-project/commit/8cec8de2a4e6692da6226bb02cf417eb0e50adde.dif

[PATCH] D91861: [clang][cli] Split DefaultAnyOf into a default value and ImpliedByAnyOf

jansvoboda11 updated this revision to Diff 307028. jansvoboda11 added a comment. Add tests, fix condition in generator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91861/new/ https://reviews.llvm.org/D91861 Files: clang/include/clang/Driver/Opt

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag updated this revision to Diff 307022. AMDChirag added a comment. Fixed usage of BodyGenCallbackTy Removed ArrayRef variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91054/new/ https://reviews.llvm.org/D91054 Files: clang/lib/CodeG

[PATCH] D91861: [clang][cli] Split DefaultAnyOf into a default value and ImpliedByAnyOf

jansvoboda11 added a comment. Thanks for the feedback. I left some comments inline and will update the patch accordingly. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3762-3764 +this->KEYPATH = MERGER(this->KEYPATH, DEFAULT_VALUE); \ +if

[PATCH] D91951: [clangd] Get rid of clangToolingRefactoring dependency

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1319c6624ed6: [clangd] Get rid of clangToolingRefactoring dependency (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang-tools-extra] 1319c66 - [clangd] Get rid of clangToolingRefactoring dependency

Author: Kirill Bobyrev Date: 2020-11-23T11:59:38+01:00 New Revision: 1319c6624ed6b0a6fb48d975bbf278263a85fcef URL: https://github.com/llvm/llvm-project/commit/1319c6624ed6b0a6fb48d975bbf278263a85fcef DIFF: https://github.com/llvm/llvm-project/commit/1319c6624ed6b0a6fb48d975bbf278263a85fcef.diff

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This was originally a part of D71880

[PATCH] D91696: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c696a212ba4: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors (authored by joechrisellis). Repository: rG LLVM Github Monorepo

[clang] 3c696a2 - [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors

Author: Joe Ellis Date: 2020-11-23T10:47:17Z New Revision: 3c696a212ba4328e4f8f92136bc4d728a6490ef7 URL: https://github.com/llvm/llvm-project/commit/3c696a212ba4328e4f8f92136bc4d728a6490ef7 DIFF: https://github.com/llvm/llvm-project/commit/3c696a212ba4328e4f8f92136bc4d728a6490ef7.diff LOG: [AA

[PATCH] D91951: [clangd] Get rid of clangToolingRefactoring dependency

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, mgorny. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. D71880

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf39bdb49086: [clangd] Implement Decl canonicalization rules for rename (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] cf39bdb - [clangd] Implement Decl canonicalization rules for rename

Author: Kirill Bobyrev Date: 2020-11-23T11:42:56+01:00 New Revision: cf39bdb49086350e7178a0a058273907d180e809 URL: https://github.com/llvm/llvm-project/commit/cf39bdb49086350e7178a0a058273907d180e809 DIFF: https://github.com/llvm/llvm-project/commit/cf39bdb49086350e7178a0a058273907d180e809.diff

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 307013. kbobyrev marked an inline comment as done. kbobyrev added a comment. Get rid of forward declaration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: c

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:78 +const NamedDecl *canonicalRenameDecl(const NamedDecl *D); + nit: maybe we can just move the function definition to here. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, this looks great now. I think we can get rid of the `clangToolingRefactoring` dependence from clangd CMake files, clangd now should have no use of any functions there, could you take

[PATCH] D89046: [AST] Build recovery expression by default for all language.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1444edbf41c: [AST] Build recovery expression by default for all language. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] b1444ed - [AST] Build recovery expression by default for all language.

Author: Haojian Wu Date: 2020-11-23T11:08:28+01:00 New Revision: b1444edbf41c1fe9f7e676df6e873e9c9318283e URL: https://github.com/llvm/llvm-project/commit/b1444edbf41c1fe9f7e676df6e873e9c9318283e DIFF: https://github.com/llvm/llvm-project/commit/b1444edbf41c1fe9f7e676df6e873e9c9318283e.diff LO

[PATCH] D89046: [AST] Build recovery expression by default for all language.

hokein updated this revision to Diff 306992. hokein added a comment. rebase and update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89046/new/ https://reviews.llvm.org/D89046 Files: clang/include/clang/AST/Expr.h clang/include/clang/Basic/Lan

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. This looks great! Thanks a lot for bearing with me and doing all of this! Comment at: clang-tools-extra/clangd/XRefs.cpp:1613 +if (auto CHI = declToCallHierarchyItem(

[PATCH] D91948: [analyzer][doc] Add Container- and IteratorModeling developer docs

gamesh411 created this revision. Herald added subscribers: cfe-commits, steakhal, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a project: clang. gamesh411 requested review of this revis

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 306988. kbobyrev added a comment. Make use of TemplatedDecl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-extra/clangd/refactor/Rename.cpp Ind

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 306987. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Resolve comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-ext

[PATCH] D91947: [clangd] testPath's final result agrees with the passed in Style

kadircet created this revision. kadircet added reviewers: hokein, sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This was confusing, as testRoot on w

[clang-tools-extra] fee78fb - [clangd] Second attempt at fixing windows buildbots

Author: Kadir Cetinkaya Date: 2020-11-23T10:06:48+01:00 New Revision: fee78fb0049ae2556c99768a06421d7cdbb9d016 URL: https://github.com/llvm/llvm-project/commit/fee78fb0049ae2556c99768a06421d7cdbb9d016 DIFF: https://github.com/llvm/llvm-project/commit/fee78fb0049ae2556c99768a06421d7cdbb9d016.dif

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu created this revision. alokmishra.besu added a project: OpenMP. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, martong, arphaman, guansong, hiraditya, yaxunl. Herald added projects: clang, LLVM. alokmishra.besu requested review of this revision. Herald added a rev

[PATCH] D91941: [clangd] Use WorkScheduler.run() in ClangdServer::resolveTypeHierarchy()

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91941/new/ https://reviews.llvm.org/D91941 __

[PATCH] D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base.

vsavchenko added a comment. LGTM! But I'd like other folks to take a look at it first. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91898/new/ https://reviews.llvm.org/D91898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D91614: [clang-tidy] Fix a nullptr-access crash in unused-raii-check.

This revision was automatically updated to reflect the committed changes. Closed by commit rG66ace4dc0275: [clang-tidy] Fix a nullptr-access crash in unused-raii-check. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91614/new/ h

[clang-tools-extra] 66ace4d - [clang-tidy] Fix a nullptr-access crash in unused-raii-check.

Author: Haojian Wu Date: 2020-11-23T09:44:19+01:00 New Revision: 66ace4dc0275c8d7740bc5ff57c20e85e6660371 URL: https://github.com/llvm/llvm-project/commit/66ace4dc0275c8d7740bc5ff57c20e85e6660371 DIFF: https://github.com/llvm/llvm-project/commit/66ace4dc0275c8d7740bc5ff57c20e85e6660371.diff LO

[PATCH] D91721: [clangd] textDocument/implementation (LSP layer)

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91721/new/ https://reviews.llvm.org/D91721 __

[PATCH] D91721: [clangd] textDocument/implementation (LSP layer)

usaxena95 updated this revision to Diff 306969. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91721/new/ https://reviews.llvm.org/D91721 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-t

[PATCH] D91721: [clangd] textDocument/implementation (LSP layer)

usaxena95 marked 3 inline comments as done. usaxena95 added a comment. > Looks like the patch is based on the old revision (pre-merging tests are > failing), I assume you have fixed the failure tests last week? Yes. That was fixed last week. Rebased. Repository: rG LLVM Github Monorepo CHAN

<    1   2   3   >