[PATCH] D92148: [clangd] Do not treat line as inactive if skipped range ends at character position 0

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92148/new/ https://reviews.llvm.org/D92148

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

njames93 added a comment. Is it possible to write tests for this, obviously they will only work with plugin support on the current platform. Also now that this is loaded from the command line, how will this play nicely with other tools that haven't been built with plugin support? Repository:

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

psionic12 updated this revision to Diff 307763. psionic12 added a comment. Fix some syntax Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92155/new/ https://reviews.llvm.org/D92155 Files: clang-tools-extra/clangd/tool/CMakeLists.txt

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

psionic12 created this revision. psionic12 added reviewers: njames93, grosser, chapuni, john.brawn, alexfh, sammccall, nridge. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, mgorny. Herald added a project: clang. psionic12 requested review of this revision. Herald added a

[PATCH] D91651: [clang] Add a warning (à la gcc) for too small enum bitfields

faisalv added a comment. In D91651#2416423 , @thakis wrote: > Do you have any numbers on false positives / true positives uncovered by this > tweak? That's a great question - and unfortunately not only do I have no hard data to support or discourage

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu added a comment. I have replied to the comments and will update the code accordingly. Some of the codes are intentionally left to be update in 5.1 implementation. Will add TODO comments there. I will revisit the implementation of getBestWhenMatchForContext and also add more

[PATCH] D92041: [clangd] Add hover info for `this` expr

xndcn updated this revision to Diff 307749. xndcn added a comment. Thanks! Update the commit as review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92041/new/ https://reviews.llvm.org/D92041 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf added a comment. In D92080#2416625 , @craig.topper wrote: > gcc calls the *l version with -mlong-double-128 on x86. Should we match gcc > here? Ah, yes, so this should be PPC-only change. But I see under x86 `-mlong-double-128`, std functions

[PATCH] D92117: [AIX] Enabling vector types for AIX

ZarkoCA updated this revision to Diff 307748. ZarkoCA added a comment. Added regex and variable for function attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92117/new/ https://reviews.llvm.org/D92117 Files:

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 8PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D92148: [clangd] Do not treat line as inactive if skipped range ends at character position 0

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Fixes https://github.com/clangd/clangd/issues/602 Repository: rG LLVM

[PATCH] D92000: [clangd] Collect main file refs by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc6cb47b640ff: [clangd] Collect main file refs by default (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] c6cb47b - [clangd] Collect main file refs by default

Author: Nathan Ridge Date: 2020-11-25T20:33:57-05:00 New Revision: c6cb47b640ffafda113581c488a73fb62b6ea38a URL: https://github.com/llvm/llvm-project/commit/c6cb47b640ffafda113581c488a73fb62b6ea38a DIFF: https://github.com/llvm/llvm-project/commit/c6cb47b640ffafda113581c488a73fb62b6ea38a.diff

[PATCH] D92000: [clangd] Collect main file refs by default

nridge updated this revision to Diff 307730. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92000/new/ https://reviews.llvm.org/D92000 Files: clang-tools-extra/clangd/ClangdServer.h

[clang] 7c327db - Part of C++ DR 39: a class member lookup is not ambiguous if it finds the

Author: Richard Smith Date: 2020-11-25T17:03:11-08:00 New Revision: 7c327db3ef73d771bc022d0723672fc356dc9017 URL: https://github.com/llvm/llvm-project/commit/7c327db3ef73d771bc022d0723672fc356dc9017 DIFF: https://github.com/llvm/llvm-project/commit/7c327db3ef73d771bc022d0723672fc356dc9017.diff

[PATCH] D92141: Fix noderef for AddrOf on MemberExpr

thejh marked an inline comment as done. thejh added inline comments. Comment at: clang/test/Frontend/noderef.c:75-76 + // enclosing AddrOf. + p = >a;// ok + p = &(*s).a; // ok + p2 = >a; // expected-warning{{casting to dereferenceable pointer removes 'noderef'

[PATCH] D92141: Fix noderef for AddrOf on MemberExpr

thejh updated this revision to Diff 307728. thejh added a comment. Removed duplicate tests as suggested by leonardchan Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92141/new/ https://reviews.llvm.org/D92141 Files:

[PATCH] D92141: Fix noderef for AddrOf on MemberExpr

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. Thanks Comment at: clang/test/Frontend/noderef.c:75-76 + // enclosing AddrOf. + p = >a;// ok + p = &(*s).a; // ok + p2 = >a; //

[PATCH] D92140: Fix noderef for array member of deref expr

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. Thanks for catching this. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92140/new/ https://reviews.llvm.org/D92140

[clang] 3fb0879 - Refactor and simplify class scope name lookup.

Author: Richard Smith Date: 2020-11-25T16:25:33-08:00 New Revision: 3fb0879867d7039cb61ffb6287ac17ac949adfa9 URL: https://github.com/llvm/llvm-project/commit/3fb0879867d7039cb61ffb6287ac17ac949adfa9 DIFF: https://github.com/llvm/llvm-project/commit/3fb0879867d7039cb61ffb6287ac17ac949adfa9.diff

[PATCH] D92141: Fix noderef for AddrOf on MemberExpr

thejh added a comment. (I marked this as depending on D92140 because if you apply this patch to the current HEAD directly, the tests will break.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92141/new/

[PATCH] D92141: Fix noderef for AddrOf on MemberExpr

thejh created this revision. thejh added reviewers: leonardchan, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. thejh requested review of this revision. As part of this change, one existing test case has to be adjusted because it accidentally stripped the

[PATCH] D92140: Fix noderef for array member of deref expr

thejh created this revision. thejh added reviewers: leonardchan, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. thejh requested review of this revision. Given an __attribute__((noderef)) pointer "p" to the struct struct s { int a[2]; }; ensure that the

[PATCH] D91311: Add new 'preferred_name' attribute.

rsmith added a comment. In D91311#2416940 , @ldionne wrote: > LGTM from the libc++ point of view. The CI is passing -- those failures are > flaky modules tests that we need to fix. Perhaps we need to specify `-fmodules-validate-system-headers` in the

[PATCH] D92133: [clangd] Cache .clang-tidy files again.

njames93 added inline comments. Comment at: clang-tools-extra/clangd/TidyProvider.cpp:34 + llvm::Optional + get(const ThreadsafeFS , + std::chrono::steady_clock::time_point FreshTime) const { To save a copy, could this not return a const pointer to whats

[PATCH] D91895: [Clang] improve -Wimplicit-fallthrough GCC compat

Quuxplusone added a comment. In D91895#2417170 , @kees wrote: > I think this should warn too. While this won't turn into a "missing break" > error, there's no way to know (from looking at code) what the _intent_ is > here. Hear, hear. +1 on everything

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:1569-1593 +int idx = -1; +if (Tok.isAnyIdentifier()) { + II = Tok.getIdentifierInfo(); + llvm::StringSwitch SS(II->getName()); + for (const AssumptionClauseMappingInfo :

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added a comment. In D91980#2417129 , @ABataev wrote: > In D91980#2417049 , @jdoerfert wrote: > >> In D91980#2416950 , @ABataev wrote: >> >>> Why don't yo want to

[PATCH] D92136: [clang] Enhanced test for --relocatable-pch, and corresponding fixes for Windows

saudi created this revision. saudi added reviewers: rnk, thakis, rsmith, AndyG. saudi added a project: clang. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, ormris, hiraditya. Herald added a project: LLVM. saudi requested review of this revision. The test now moves the header

[PATCH] D92117: [AIX] Enabling vector types for AIX

Xiangling_L accepted this revision. Xiangling_L added a comment. This revision is now accepted and ready to land. Just a minor suggestion: Maybe `Enabling return and argument vector types for AIX` is more accurate. Otherwise, LGTM. Comment at:

[PATCH] D91895: [Clang] improve -Wimplicit-fallthrough GCC compat

kees added a comment. The kernel's [[ https://www.kernel.org/doc/html/latest/process/deprecated.html#implicit-switch-case-fall-through | stance ]] on switch statements reads: | | All switch/case blocks must end in one of: break; fallthrough; continue; goto ; return

[PATCH] D92133: [clangd] Cache .clang-tidy files again.

sammccall created this revision. sammccall added reviewers: njames93, kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This cache went away

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added a comment. In D91980#2417049 , @jdoerfert wrote: > In D91980#2416950 , @ABataev wrote: > >> Why don't yo want to try to implement the scheme similar to the declare >> target? > > Because it is not

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added a comment. In D91980#2416950 , @ABataev wrote: > Why don't yo want to try to implement the scheme similar to the declare > target? Because it is not clear that the standard even says that right now. Even if, as you noted, what is the

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert updated this revision to Diff 307697. jdoerfert marked 8 inline comments as done. jdoerfert added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91980/new/ https://reviews.llvm.org/D91980 Files:

[PATCH] D91261: [OPENMP]Do not use OMP_MAP_TARGET_PARAM for data movement directives.

ABataev updated this revision to Diff 307694. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91261/new/ https://reviews.llvm.org/D91261 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L updated this revision to Diff 307685. Xiangling_L added a comment. Update the logic to tell if two AlignPackInfo are equal; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87702/new/ https://reviews.llvm.org/D87702 Files: clang/include/clang/Basic/Attr.td

[clang-tools-extra] cbf336a - [clangd] Track deprecation of 'member' semantic token type in LSP.

Author: Sam McCall Date: 2020-11-25T21:31:46+01:00 New Revision: cbf336ad76cd619495b213e8364acaccb7a7c0d6 URL: https://github.com/llvm/llvm-project/commit/cbf336ad76cd619495b213e8364acaccb7a7c0d6 DIFF: https://github.com/llvm/llvm-project/commit/cbf336ad76cd619495b213e8364acaccb7a7c0d6.diff

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added a comment. Why don't yo want to try to implement the scheme similar to the declare target? Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return

[PATCH] D91311: Add new 'preferred_name' attribute.

ldionne accepted this revision as: libc++. ldionne added a comment. LGTM from the libc++ point of view. The CI is passing -- those failures are flaky modules tests that we need to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91311/new/

[PATCH] D92062: [MS] Add more 128bit cmpxchg intrinsics for AArch64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e843a987d84: [MS] Add more 128bit cmpxchg intrinsics for AArch64 (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 1e843a9 - [MS] Add more 128bit cmpxchg intrinsics for AArch64

Author: Reid Kleckner Date: 2020-11-25T12:07:28-08:00 New Revision: 1e843a987d847da48aaf41801b79cfb364937e8f URL: https://github.com/llvm/llvm-project/commit/1e843a987d847da48aaf41801b79cfb364937e8f DIFF: https://github.com/llvm/llvm-project/commit/1e843a987d847da48aaf41801b79cfb364937e8f.diff

[PATCH] D92000: [clangd] Collect main file refs by default

kadircet added a comment. nope, as it doesn't change the serialization format. but any existing shards won't have refs from the main file, they'll accumulate over time as sources gets modified. (i don't think it is worth bumping the version to invalidate existing shards, if a user cares enough

[PATCH] D92062: [MS] Add more 128bit cmpxchg intrinsics for AArch64

rnk marked an inline comment as done. rnk added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:336 + + // For Release ordering, the failure ordering should be Monotonic. + auto FailureOrdering = SuccessOrdering == AtomicOrdering::Release thakis

[PATCH] D92062: [MS] Add more 128bit cmpxchg intrinsics for AArch64

rnk updated this revision to Diff 307678. rnk marked an inline comment as done. rnk added a comment. - add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92062/new/ https://reviews.llvm.org/D92062 Files:

[PATCH] D92122: [FPEnv] clang should get from the AST the metadata for constrained FP builtins

kpn created this revision. kpn added reviewers: sepavloff, mibintc, rjmccall. kpn added a project: clang. Herald added a subscriber: cfe-commits. kpn requested review of this revision. Currently clang is not correctly retrieving from the AST the metadata for constrained FP builtins. This patch

[clang] 3bd0672 - [MS] Fix double evaluation of MSVC builtin arguments

Author: Reid Kleckner Date: 2020-11-25T11:55:01-08:00 New Revision: 3bd06727267184223464f11d4e2470048ac40cb1 URL: https://github.com/llvm/llvm-project/commit/3bd06727267184223464f11d4e2470048ac40cb1 DIFF: https://github.com/llvm/llvm-project/commit/3bd06727267184223464f11d4e2470048ac40cb1.diff

[PATCH] D92061: [MS] Fix double evaluation of MSVC builtin arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG3bd067272671: [MS] Fix double evaluation of MSVC builtin arguments (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D92061?vs=307468=307674#toc Repository: rG LLVM Github

[PATCH] D92000: [clangd] Collect main file refs by default

nridge added a comment. One thing that just occurred to me: does this need an index version bump? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92000/new/ https://reviews.llvm.org/D92000 ___ cfe-commits

[PATCH] D92061: [MS] Fix double evaluation of MSVC builtin arguments

rnk marked an inline comment as done. rnk added a comment. Thanks! Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1019 + default: +break; + case ARM::BI_BitScanForward: thakis wrote: > Maybe `return None` here and LLVM_UNREACHABLE at the bottom? Sure, why

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington added inline comments. Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:1704-1707 +void ASTDeclReader::VisitUnresolvedUsingIfExistsDecl( +UnresolvedUsingIfExistsDecl *D) { + VisitNamedDecl(D); +} aaron.ballman wrote: > I'm not super

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington updated this revision to Diff 307670. erik.pilkington marked 4 inline comments as done. erik.pilkington added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90188/new/ https://reviews.llvm.org/D90188 Files:

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

erik.pilkington added a comment. In D91630#235 , @aaron.ballman wrote: > Can you mention this change in the release notes? Also, should we document it > explicitly in the Language Extensions documentation, or do you think this is > too tiny of a

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

erik.pilkington updated this revision to Diff 307669. erik.pilkington marked 6 inline comments as done. erik.pilkington added a comment. Herald added a subscriber: dexonsmith. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91630/new/

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89065/new/ https://reviews.llvm.org/D89065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssumeScoped.empty(); } + ABataev wrote: > jdoerfert wrote: >

[PATCH] D92109: [ASTImporter] Support import of CXXDeductionGuideDecl

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. You think it's worth it to have a test for a user-specified deduction guide? I think this is missing an 'explicit' deduction guide test, so maybe we could test both things in

[PATCH] D92117: [AIX] Enabling vectory types for AIX

ZarkoCA created this revision. ZarkoCA added reviewers: cebowleratibm, sfertile, jasonliu, Xiangling_L, hubert.reinterpretcast. Herald added a project: clang. Herald added a subscriber: cfe-commits. ZarkoCA requested review of this revision. This patch enables vector types for AIX. Repository:

[PATCH] D92041: [clangd] Add hover info for `this` expr

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:610 +/// Generate a \p Hover object given the \p this pointer. +HoverInfo getHoverContents(const CXXThisExpr *CTE, const SymbolIndex *Index) { + const NamedDecl *D =

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 added a comment. Whoops, probably should've updated the summary before pushing, ah well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91029/new/ https://reviews.llvm.org/D91029 ___ cfe-commits

[PATCH] D91029: [clangd] Implement clang-tidy options from config

This revision was automatically updated to reflect the committed changes. Closed by commit rG73fdd998701c: [clangd] Implement clang-tidy options from config (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91029/new/

[clang-tools-extra] 73fdd99 - [clangd] Implement clang-tidy options from config

Author: Nathan James Date: 2020-11-25T18:35:35Z New Revision: 73fdd998701cce3aa6c4d8d2a73ab97351a0313b URL: https://github.com/llvm/llvm-project/commit/73fdd998701cce3aa6c4d8d2a73ab97351a0313b DIFF: https://github.com/llvm/llvm-project/commit/73fdd998701cce3aa6c4d8d2a73ab97351a0313b.diff LOG:

[PATCH] D92115: AMDGPU - Add diagnostic for compiling modules with AMD HSA OS type and GFX 6 arch

rampitec added a comment. You need to add a new test for this new error. Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp:134 + if (isAmdHsaOS() && getGeneration() == AMDGPUSubtarget::SOUTHERN_ISLANDS) { +report_fatal_error("GFX6 (SI) ASICs does not support AMD HSA

[PATCH] D92115: AMDGPU - Add diagnostic for compiling modules with AMD HSA OS type and GFX 6 arch

pvellien created this revision. pvellien added reviewers: rampitec, arsenm, sameerds. Herald added subscribers: llvm-commits, cfe-commits, kerbowa, jfb, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. Herald added projects: clang, LLVM. pvellien requested review of this

[PATCH] D91029: [clangd] Implement clang-tidy options from config

sammccall accepted this revision. sammccall added a comment. Hooray, ship it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91029/new/ https://reviews.llvm.org/D91029 ___ cfe-commits mailing list

[PATCH] D91495: [clang-tidy] false-positive for bugprone-redundant-branch-condition in case of passed-by-ref params

zinovy.nis updated this revision to Diff 307646. zinovy.nis added a comment. Handle ref & val mixed cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91495/new/ https://reviews.llvm.org/D91495 Files: clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

craig.topper added a comment. gcc calls the *l version with -mlong-double-128 on x86. Should we match gcc here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92080/new/ https://reviews.llvm.org/D92080

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 updated this revision to Diff 307642. njames93 added a comment. Removed CWD references. Added some fixme comments about function_ref<->unique_function and null values. Added asserts in provideClangTidyFiles ensuring path is absolute. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D92109: [ASTImporter] Support import of CXXDeductionGuideDecl

martong created this revision. martong added reviewers: teemperor, shafik, balazske. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. martong requested review of this revision. CXXDeductionGuideDecl

[PATCH] D92108: Fix inconsistent availability attribute message string literal check.

nigelp-xmos updated this revision to Diff 307638. nigelp-xmos added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92108/new/ https://reviews.llvm.org/D92108 Files: clang/lib/Parse/ParseDecl.cpp

[PATCH] D92108: Fix inconsistent availability attribute message string literal check.

nigelp-xmos updated this revision to Diff 307636. nigelp-xmos added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92108/new/ https://reviews.llvm.org/D92108 Files: clang/lib/Parse/ParseDecl.cpp

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

SjoerdMeijer added a comment. Thanks @david-arm for posting this proposal to the cfe list. My confusion has been cleared up. The (new) proposal is to have: 1. vectorize_width(X) where X is an integer. 2. vectorize_width(X, fixed|scalable) 3. vectorize_width(fixed|scalable) And with that 3rd

[PATCH] D89528: [clang][test] Fix prefix operator++ signature in iterators

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc96cc33c13e: [clang][test] Fix prefix operator++ signature in iterators (authored by gamesh411). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89528/new/

[clang] dc96cc3 - [clang][test] Fix prefix operator++ signature in iterators

Author: Endre Fülöp Date: 2020-11-25T18:05:11+01:00 New Revision: dc96cc33c13e1e38382118c25bf26de480eb2b12 URL: https://github.com/llvm/llvm-project/commit/dc96cc33c13e1e38382118c25bf26de480eb2b12 DIFF: https://github.com/llvm/llvm-project/commit/dc96cc33c13e1e38382118c25bf26de480eb2b12.diff

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 added inline comments. Comment at: clang-tools-extra/clangd/TidyProvider.h:25 +/*Filename=*/llvm::StringRef, +/*CWD*/ PathRef) const>; + sammccall wrote: >

[PATCH] D92108: Fix inconsistent availability attribute message string literal check.

nigelp-xmos added a comment. Alternatively, if all 1-byte-character strings are acceptable, should I remove the check that the first token is a string literal, and omit the failing test case on XCore? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92108: Fix inconsistent availability attribute message string literal check.

nigelp-xmos created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. nigelp-xmos requested review of this revision. Function Parser::ParseAvailabilityAttribute checks that the message string of an availability attribute is not a wide string literal. Test case

[PATCH] D91029: [clangd] Implement clang-tidy options from config

sammccall added inline comments. Comment at: clang-tools-extra/clangd/TidyProvider.h:25 +/*Filename=*/llvm::StringRef, +/*CWD*/ PathRef) const>; + sammccall wrote: >

[PATCH] D91029: [clangd] Implement clang-tidy options from config

sammccall added inline comments. Comment at: clang-tools-extra/clangd/TidyProvider.h:25 +/*Filename=*/llvm::StringRef, +/*CWD*/ PathRef) const>; + njames93 wrote: >

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 added inline comments. Comment at: clang-tools-extra/clangd/TidyProvider.h:25 +/*Filename=*/llvm::StringRef, +/*CWD*/ PathRef) const>; + sammccall wrote: >

[PATCH] D92041: [clangd] Add hover info for `this` expr

xndcn updated this revision to Diff 307622. xndcn added a comment. Update the diff with `getHoverContents(const NamedDecl ..)` overload function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92041/new/ https://reviews.llvm.org/D92041 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D91651: [clang] Add a warning (à la gcc) for too small enum bitfields

thakis added a comment. Do you have any numbers on false positives / true positives uncovered by this tweak? In general, warning at use time instead of at declaration time tends to be much better for this rate, and we do this differently than gcc in several instances, because the gcc way has

[PATCH] D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs

balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5906 + Lang_CXX17, "input.cc"); + TU->dump(); + auto *Guide = FirstDeclMatcher().match( These `dump` calls should be removed (in the other case too)? Repository: rG

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L added inline comments. Comment at: clang/include/clang/Sema/Sema.h:637 PragmaStack VtorDispStack; - // #pragma pack. - // Sentinel to represent when the stack is set to mac68k alignment. - static const unsigned kMac68kAlignmentSentinel = ~0U; - PragmaStack

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L updated this revision to Diff 307617. Xiangling_L marked an inline comment as done. Xiangling_L added a comment. Herald added a subscriber: dexonsmith. Addressed the comments; Handle PCH for AIX; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87702/new/

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 updated this revision to Diff 307615. njames93 added a comment. Removed duplicated logging of options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91029/new/ https://reviews.llvm.org/D91029 Files:

[PATCH] D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs

martong added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5893 + // in the global scope. + EXPECT_EQ(Param->getType()->getAs()->getDecl(), Typedef); +} Note, this "expectation" fails in baseline. Repository: rG LLVM Github Monorepo

[PATCH] D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs

martong created this revision. martong added a reviewer: rsmith. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: shafik. Herald added a project: clang. martong requested review of this revision.

[PATCH] D92062: [MS] Add more 128bit cmpxchg intrinsics for AArch64

thakis accepted this revision. thakis added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:336 + + // For Release ordering, the failure ordering should be Monotonic. + auto FailureOrdering = SuccessOrdering ==

[PATCH] D92061: [MS] Fix double evaluation of MSVC builtin arguments

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Nice! Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1019 + default: +break; + case ARM::BI_BitScanForward: Maybe `return None` here and LLVM_UNREACHABLE

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

trixirt updated this revision to Diff 307602. trixirt added a comment. Addresses issues before refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91789/new/ https://reviews.llvm.org/D91789 Files:

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko updated this revision to Diff 307594. vsavchenko marked an inline comment as done. vsavchenko added a comment. Add another comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92039/new/ https://reviews.llvm.org/D92039 Files:

[PATCH] D92051: [clangd] PopulateSwitch: disable on dependent enums.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6970503d291: [clangd] PopulateSwitch: disable on dependent enums. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92051/new/

[clang-tools-extra] f697050 - [clangd] PopulateSwitch: disable on dependent enums.

Author: Adam Czachorowski Date: 2020-11-25T14:12:29+01:00 New Revision: f6970503d291b7cae70fe583bed392387f93f9e4 URL: https://github.com/llvm/llvm-project/commit/f6970503d291b7cae70fe583bed392387f93f9e4 DIFF:

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

venkataramanan.kumar.llvm added a comment. In D88712#2414171 , @spatel wrote: > In D88712#2413877 , > @venkataramanan.kumar.llvm wrote: > >> In D88712#2413688 , @spatel

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas marked 25 inline comments as done. reikdas added inline comments. Comment at: clang/test/SemaTemplate/temp_arg_nontype_cxx1z.cpp:471 + template struct X {}; + X<1, 1u>::type y; // expected-error {{no type named 'type' in 'TypeSuffix::X<1, 1u>'}} + X<1, 1>::type z;

[PATCH] D92012: [clangd][query-driver] Extract target

sammccall added a comment. Sorry, code reviews are racy :-) Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:134 elog("System include extraction: end marker missing: {0}", Output); -return {}; - } - - for (llvm::StringRef Line : llvm::make_range(StartIt,

[PATCH] D92012: [clangd][query-driver] Extract target

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! just nits, apart from the "-target already explicitly set" issue Kadir raised. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:99 + } +

[PATCH] D92012: [clangd][query-driver] Extract target

kadircet added inline comments. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:67 + +bool isValidTarget(llvm::StringRef Triple) { + std::shared_ptr TargetOpts(new TargetOptions); i think you can just do `TargetRegistry::lookupTarget`

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 307587. reikdas added a comment. Address @rsmith 's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/include/clang/AST/DeclTemplate.h clang/include/clang/AST/StmtDataCollectors.td

  1   2   >