[PATCH] D92270: [ConstantFold] Fold more operations to poison

aqjune updated this revision to Diff 308200. aqjune added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. update clang/test/Frontend/fixed_point_unary.c It seems unsigned _Fract type can only represent [0.0, 1.0)? I tried to find a relevant sentence from

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

kristof.beyls added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:276-277 "-fembed-bitcode is not supported on versions of iOS prior to 6.0">; +def err_drv_stack_clash_protection_unsupported_on_toolchain : Error< + "-fstack-clash-protection

[PATCH] D92272: [clang-tidy] [clangd] Avoid multi-line diagnostic range for else-after-return diagnostic

nridge added a comment. I see that you have a more sophisticated fix at D91149 . Will leave it up to you if we should just wait for that to land, or land this in the interim. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92272: [clang-tidy] [clangd] Avoid multi-line diagnostic range for else-after-return diagnostic

nridge created this revision. nridge added a reviewer: njames93. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, xazax.hun. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Fixes

[PATCH] D91596: [PowerPC] [Clang] Fix alignment of 128-bit floating types

hubert.reinterpretcast added a comment. Reverting this patch makes va_arg with the default 128-bit (double-double) long double work again: #include void abort(void); void foo(int x, ...) { va_list ap; va_start(ap, x); long double ans = va_arg(ap, long double); if (ans

[PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

gamesh411 added a comment. On bitcoin v0.18.1 , there is an assertion introduced by this change. The TU that can be used for reproduction is `src/script/interpreter.cpp`. Assertion message: CTU loaded AST file:

[PATCH] D92269: [TableGen] Eliminate the 'code' type

Paul-C-Anagnostopoulos created this revision. Paul-C-Anagnostopoulos added reviewers: lattner, nhaehnle, madhur13490, asb. Herald added subscribers: llvm-commits, cfe-commits, teijeong, frasercrmck, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, kerbowa, liufengdb,

[PATCH] D92267: [clang-tidy][NFC] Use moves instead of copies when constructing OptionsProviders.

Quuxplusone added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.h:225 + ClangTidyOptions &, + ConfigFileHandlers &); njames93 wrote: > Quuxplusone wrote: > > I'd strongly recommend

[PATCH] D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

tambre added a comment. In D86308#2421249 , @aaronpuchert wrote: > In D86308#2421237 , @tambre wrote: > >> This has already been backported to 11.0.1: >>

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

njames93 updated this revision to Diff 308176. njames93 added a comment. Added fixit to remove extern. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73413/new/ https://reviews.llvm.org/D73413 Files:

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

aaronpuchert added a comment. In D86308#2421237 , @tambre wrote: > This has already been backported to 11.0.1: > https://github.com/llvm/llvm-project/commit/03565ffd5da8370f5b89b69cd9868f32e2d75403 Thanks! I didn't see any mention of that here so I

[PATCH] D91996: [clang-format] Remove double trim

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. In D91996#2417892 , @klimek wrote: > Isn't the comment incorrect after this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

tambre added a comment. In D86308#2421228 , @aaronpuchert wrote: > @tstellar, can we have this in 11.0.1? I've already ported it back in > openSUSE because we were having problems with the CMake 3.19 update. This has already been backported to 11.0.1:

[PATCH] D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

aaronpuchert added subscribers: tstellar, aaronpuchert. aaronpuchert added a comment. @tstellar, can we have this in 11.0.1? I've already ported it back in openSUSE because we were having problems with the CMake 3.19 update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92267: [clang-tidy][NFC] Use moves instead of copies when constructing OptionsProviders.

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.h:176 public: - DefaultOptionsProvider(const ClangTidyGlobalOptions , - const ClangTidyOptions ) - : GlobalOptions(GlobalOptions), DefaultOptions(Options) {}

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

njames93 updated this revision to Diff 308165. njames93 added a comment. Removed warnings on template definitions. Added some basic fix-it support, need some lexer magic to create the fix-it for declarations declared with extern. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92267: [clang-tidy][NFC] Use moves instead of copies when constructing OptionsProviders.

Quuxplusone added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.h:176 public: - DefaultOptionsProvider(const ClangTidyGlobalOptions , - const ClangTidyOptions ) - : GlobalOptions(GlobalOptions), DefaultOptions(Options)

[PATCH] D92202: [clangd] Add symbol origin for remote index

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4169c520f6d7: [clangd] Add symbol origin for remote index (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 4169c52 - [clangd] Add symbol origin for remote index

Author: Kirill Bobyrev Date: 2020-11-28T15:38:11+01:00 New Revision: 4169c520f6d7029d87098997e9f256a0170aa8cf URL: https://github.com/llvm/llvm-project/commit/4169c520f6d7029d87098997e9f256a0170aa8cf DIFF:

[PATCH] D92268: [clang-tidy][NFC] Skip intermediate cache directories when inheriting configs.

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 requested review of this revision. If an configuration specifies InheritParentOption and is cached in child

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

sylvestre.ledru updated this revision to Diff 308160. sylvestre.ledru added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245 Files:

[PATCH] D92267: [clang-tidy][NFC] Use moves instead of copies when constructing OptionsProviders.

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D92267 Files:

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2727 + + * ``unsigned Maximum`` The maximum number of spaces at the start of the comment. + MyDeveloperDay wrote: > I'm personally not a massive fan of stuffing -1

[PATCH] D84924: [clang-tidy][WIP] Added command line option `fix-notes`

njames93 updated this revision to Diff 308153. njames93 added a comment. Fix documentation. Ping?? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84924/new/ https://reviews.llvm.org/D84924 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

LuoYuanke updated this revision to Diff 308146. LuoYuanke added a comment. Add the handler of "bitcast <256 x i32>* to x86_amx*". Refactor the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91927/new/ https://reviews.llvm.org/D91927 Files:

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2727 + + * ``unsigned Maximum`` The maximum number of spaces at the start of the comment. + I'm personally not a massive fan of stuffing -1 into an unsigned but I

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

tonyelewis added a comment. Thank you very much for coming back to this and for bringing the changes up to date. I still think this would be really valuable. > Right now it will flag template definitions in source files, Is this good or > bad behaviour? Do you mean that both of the following