[PATCH] D93038: [NFC] clang/test/openMP/target_codegen.cpp should not depend on ssa name

jeroen.dobbelaere added a comment. Thanks ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93038/new/ https://reviews.llvm.org/D93038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] c102b96 - [X86] Correct the comments about comparison intrinsics. NFCI.

Author: Wang, Pengfei Date: 2021-01-08T15:36:15+08:00 New Revision: c102b9697bd4ec2b12dab9865661bfb2facc97ec URL: https://github.com/llvm/llvm-project/commit/c102b9697bd4ec2b12dab9865661bfb2facc97ec DIFF: https://github.com/llvm/llvm-project/commit/c102b9697bd4ec2b12dab9865661bfb2facc97ec.diff

[PATCH] D94287: [clang-format] Fix include sorting bug

curdeius added a comment. Seems to be a duplicate of D94206 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94287/new/ https://reviews.llvm.org/D94287 ___ cfe-commits

[PATCH] D93591: [MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation.

ergawy added inline comments. Comment at: mlir/lib/Target/SPIRV/Deserialization.cpp:1791 + + // Since the enclosed op is emitted in the current block, split it in a + // separate new block. antiagainst wrote: > What about first creating the spec op, set the

[PATCH] D93591: [MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation.

ergawy updated this revision to Diff 315302. ergawy marked 4 inline comments as done. ergawy added a comment. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. Handle review comments: - Use different value map for emitting SpecConstOperation. -

[PATCH] D94287: [clang-format] Fix include sorting bug

kentsommer created this revision. kentsommer added a project: clang-format. kentsommer requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Fixes a bug that caused `// clang-format off` in a includes section to disabled include sorting even

[PATCH] D92714: Make -fno-pic respect -fno-direct-access-external-data

MaskRay added a comment. This is straightforward, too :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92714/new/ https://reviews.llvm.org/D92714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92270: [ConstantFold] Fold more operations to poison

aqjune added a comment. In D92270#2483557 , @thakis wrote: > It turned out to be UB in our code as far as I can tell, see > https://bugs.chromium.org/p/angleproject/issues/detail?id=5500#c36 and the > follow-on. > > (If this is known to trigger an

[clang] 6b0ee02 - Revert "Revert "Revert "Revert "[analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.""""

Author: Artem Dergachev Date: 2021-01-07T20:22:22-08:00 New Revision: 6b0ee02747ed22d41e175d15f27025183341e6f8 URL: https://github.com/llvm/llvm-project/commit/6b0ee02747ed22d41e175d15f27025183341e6f8 DIFF:

[PATCH] D94268: Allow _mm_empty() (via llvm.x86.mmx.emms) to be a no-op without MMX.

pengfei added a comment. Is inline assembly the only case `emms` instruction will be needed? But inline assembly doesn't enable `mmx` attribute automatically, right? E.g. https://godbolt.org/z/43ases Analyzing asm block and appending the `mmx` attribute if we see `mmx` instructions might be

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

aeubanks added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:462 + if (!PIC->hasPassName(P)) +report_fatal_error("unrecognized pass name: " + P); +} hoy wrote: > @aeubanks This seems not working with MIR passes under newpm. Would

[PATCH] D92806: Single function compilation mode.

aeubanks added a comment. WDYT about adding optnone to all functions except the ones you're interested in? Would that cut down the compile times? We could reuse ForceFunctionAttrsPass rather than adding so much plumbing. This is too much plumbing for my liking. And since this is a debug thing,

Re: [clang] d2ddc69 - Revert "Revert "[analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.""

I've reverted this in b12f26733a4259c90e5f387aceb9f23c35e003b8 On Thu, Jan 7, 2021 at 3:04 PM David Blaikie wrote: > > > > On Thu, Jan 7, 2021 at 12:29 AM Artem Dergachev via cfe-commits > wrote: >> >> >> Author: Artem Dergachev >> Date: 2021-01-07T00:28:22-08:00 >> New Revision:

[clang] b12f267 - Revert "Revert "Revert "[analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis."""

Author: David Blaikie Date: 2021-01-07T18:18:23-08:00 New Revision: b12f26733a4259c90e5f387aceb9f23c35e003b8 URL: https://github.com/llvm/llvm-project/commit/b12f26733a4259c90e5f387aceb9f23c35e003b8 DIFF: https://github.com/llvm/llvm-project/commit/b12f26733a4259c90e5f387aceb9f23c35e003b8.diff

[PATCH] D92633: Add -f[no-]direct-access-external-data to deprecate -mpie-copy-relocations

tmsriram accepted this revision. tmsriram added a comment. This revision is now accepted and ready to land. In D92633#2485811 , @MaskRay wrote: > In D92633#2434768 , @tmsriram wrote: > >> In D92633#2434766

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

hoy added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:462 + if (!PIC->hasPassName(P)) +report_fatal_error("unrecognized pass name: " + P); +} @aeubanks This seems not working with MIR passes under newpm. Would it make sense to

[PATCH] D93743: [NewPM] Run ObjC ARC passes

aeubanks added a comment. In D93743#2485876 , @ahatanak wrote: > Is this change safe considering calls to `EP.get()` can add function > declarations to the module as you mentioned in > https://reviews.llvm.org/D86178? It's definitely safe right now

[PATCH] D93743: [NewPM] Run ObjC ARC passes

ahatanak added a comment. Is this change safe considering calls to `EP.get()` can add function declarations to the module as you mentioned in https://reviews.llvm.org/D86178? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93743/new/

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507

[PATCH] D94261: [clang] Add powerpc64le-none-linux-gnu to gnu toolchain for PPC64

This revision was automatically updated to reflect the committed changes. Closed by commit rG48baa7f5b11c: [clang] Add powerpc64le-none-linux-gnu to gnu toolchain for PPC64 (authored by clementval). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 48baa7f - [clang] Add powerpc64le-none-linux-gnu to gnu toolchain for PPC64

Author: clementval Date: 2021-01-07T20:08:20-05:00 New Revision: 48baa7f5b11cbe6b00711864a19cd8b722f5940d URL: https://github.com/llvm/llvm-project/commit/48baa7f5b11cbe6b00711864a19cd8b722f5940d DIFF: https://github.com/llvm/llvm-project/commit/48baa7f5b11cbe6b00711864a19cd8b722f5940d.diff

[PATCH] D92633: Add -f[no-]direct-access-external-data to deprecate -mpie-copy-relocations

MaskRay added a comment. In D92633#2434768 , @tmsriram wrote: > In D92633#2434766 , @MaskRay wrote: > >> In D92633#2434714 , @tmsriram wrote: >> >>> Correct me if I am

[PATCH] D93668: [clang] Add -ffuchsia-c++-abi flag to explicitly use the Fuchsia C++ ABI

mcgrathr added a comment. It's fine to have a target tuple translate to a default C++ ABI. But the C++ ABI selection is fundamentally not a target flavor thing. It's just a C++ ABI thing. So using the target tuple as the sole mechanism to determine C++ ABI is fundamentally wrong. Repository:

[PATCH] D93743: [NewPM] Run ObjC ARC passes

asbirlea added a comment. The changes LGTM, but I'd rather defer final review to ahatanak@. It would be good to have some testing but it could be addressed in a separate patch, potentially by folks more familiar with the ObjCARC passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

Re: [clang] d2ddc69 - Revert "Revert "[analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.""

On Thu, Jan 7, 2021 at 12:29 AM Artem Dergachev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Artem Dergachev > Date: 2021-01-07T00:28:22-08:00 > New Revision: d2ddc694ff94743d9735aaf07edcaf6db8aaca04 > > URL: >

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

alanphipps marked an inline comment as done. alanphipps added inline comments. Comment at: llvm/test/tools/llvm-cov/branch-noShowBranch.test:3 +// RUN: llvm-profdata merge %S/Inputs/branch-c-general.proftext -o %t.profdata +// RUN: llvm-cov show %S/Inputs/branch-c-general.o32l

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf78d6af7319a: [hip] Enable HIP compilation with `complex` on MSVC. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] f78d6af - [hip] Enable HIP compilation with ` on MSVC.

Author: Michael Liao Date: 2021-01-07T17:41:28-05:00 New Revision: f78d6af7319aa676a0f9f6cbb982f21c96e9aac5 URL: https://github.com/llvm/llvm-project/commit/f78d6af7319aa676a0f9f6cbb982f21c96e9aac5 DIFF: https://github.com/llvm/llvm-project/commit/f78d6af7319aa676a0f9f6cbb982f21c96e9aac5.diff

[PATCH] D94268: Allow _mm_empty() (via llvm.x86.mmx.emms) to be a no-op without MMX.

jyknight created this revision. jyknight added reviewers: craig.topper, spatel, RKSimon. Herald added subscribers: pengfei, hiraditya. jyknight requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. In Clang, the other "MMX"

[PATCH] D94261: [clang] Add powerpc64le-none-linux-gnu to gnu toolchain for PPC64

jdenny accepted this revision. jdenny added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94261/new/ https://reviews.llvm.org/D94261 ___

[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

danielmarjamaki added a comment. In D92634#2484404 , @steakhal wrote: > Here is a link for our results on a few more projects. It might be useful for > you. > https://codechecker-demo.eastus.cloudapp.azure.com/Default/runs?run=D92634=50=name=false >

[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

danielmarjamaki added a comment. > Typically in such cases bug visitors should be added/improved until it is > clear from the user-facing report why does the analyzer think so. They'd > highlight the important events, prevent path pruning, and potentially > suppress reports if the reason is

[PATCH] D94265: [clangd] Search compiler in PATH for system include extraction If the compiler is specified by its name, search it in the system PATH instead of the command directory: this is what th

qchateau abandoned this revision. qchateau added a comment. Ah ! It's been done already ! https://reviews.llvm.org/D93600 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94265/new/ https://reviews.llvm.org/D94265

[PATCH] D94257: [test] Move coro-retcon-unreachable.ll into llvm/test

This revision was automatically updated to reflect the committed changes. Closed by commit rGd002cd4e0f10: [test] Move coro-retcon-unreachable.ll into llvm/test (authored by aeubanks). Changed prior to commit: https://reviews.llvm.org/D94257?vs=315209=315240#toc Repository: rG LLVM Github

[clang] d002cd4 - [test] Move coro-retcon-unreachable.ll into llvm/test

Author: Arthur Eubanks Date: 2021-01-07T14:06:01-08:00 New Revision: d002cd4e0f10f20c4f8b419ffa23d782636e46d8 URL: https://github.com/llvm/llvm-project/commit/d002cd4e0f10f20c4f8b419ffa23d782636e46d8 DIFF:

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

rjelonek updated this revision to Diff 315236. rjelonek added a comment. Use LF instead of CRLF for case with extended `#pragma hdrstop` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94217/new/ https://reviews.llvm.org/D94217 Files: clang/lib/Format/Format.cpp

[PATCH] D93978: [clangd] DefineOutline doesn't require implementation file being saved

njames93 updated this revision to Diff 315235. njames93 marked an inline comment as done. njames93 added a comment. Address most comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93978/new/ https://reviews.llvm.org/D93978 Files:

[PATCH] D93978: [clangd] DefineOutline doesn't require implementation file being saved

njames93 marked 9 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.h:248 + /// ontop of \p Base. + llvm::IntrusiveRefCntPtr overlayFileContents( + llvm::IntrusiveRefCntPtr Base) const; sammccall

[PATCH] D94265: [clangd] Search compiler in PATH for system include extraction If the compiler is specified by its name, search it in the system PATH instead of the command directory: this is what th

qchateau created this revision. qchateau added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. qchateau requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

rjelonek added a comment. I do not have commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94206/new/ https://reviews.llvm.org/D94206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94257: [test] Move coro-retcon-unreachable.ll into llvm/test

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Yeah, that's definitely an LLVM test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94257/new/ https://reviews.llvm.org/D94257

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

rjelonek added a comment. In D94217#2485178 , @curdeius wrote: > LGTM if you add a test for hdrstop(filename) and possibly with LF newline (as > the test you've already added tests CRLF). You would like to 2 unit tests called

[PATCH] D93038: [NFC] clang/test/openMP/target_codegen.cpp should not depend on ssa name

This revision was automatically updated to reflect the committed changes. Closed by commit rG63b42a051456: [NFC] clang/test/openMP/target_codegen.cpp should not depend on ssa name (authored by jeroen.dobbelaere, committed by tianshilei1992). Herald added a project: clang. Herald added a

[clang] 63b42a0 - [NFC] clang/test/openMP/target_codegen.cpp should not depend on ssa name

Author: Jeroen Dobbelaere Date: 2021-01-07T16:39:17-05:00 New Revision: 63b42a0514567d24df617e4587e80e4564ebf120 URL: https://github.com/llvm/llvm-project/commit/63b42a0514567d24df617e4587e80e4564ebf120 DIFF:

[PATCH] D94261: [clang] Add powerpc64le-none-linux-gnu to gnu toolchain for PPC64

clementval created this revision. clementval added reviewers: dlj, jdenny. Herald added subscribers: steven.zhang, shchenz, nemanjai. clementval requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang.

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

rjelonek updated this revision to Diff 315223. rjelonek added a comment. Add test to check extended form of `#pragma hdrstop` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94217/new/ https://reviews.llvm.org/D94217 Files: clang/lib/Format/Format.cpp

[PATCH] D93668: [clang] Add -ffuchsia-c++-abi flag to explicitly use the Fuchsia C++ ABI

leonardchan added a comment. In D93668#2482986 , @phosek wrote: > I'd prefer to use the target triple rather than introducing a custom flag. > > With dedicated flags, you might eventually end up in a similar situation as > D85802

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

andreil99 added a comment. Post commit review is a normal practice in the LLVM community. This is not an excuse to revert somebody's patch per se, unless there are other serious reasons for the revert. The text does not describe “clang internals”, it describes the semantic of that flag with

[PATCH] D94259: [clangd] Fix type printing in the presence of qualifiers

adamcz created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. When printing QualType with qualifiers like "const", or pointing to an

[PATCH] D94185: [OpenMP][Docs] Mark finished features as done

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e7101530dae: [OpenMP][Docs] Mark finished features as done (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94185/new/

[clang] 6e71015 - [OpenMP][Docs] Mark finished features as done

Author: Johannes Doerfert Date: 2021-01-07T14:39:18-06:00 New Revision: 6e7101530dae78efd7b5cdffc1338790ed3e5705 URL: https://github.com/llvm/llvm-project/commit/6e7101530dae78efd7b5cdffc1338790ed3e5705 DIFF:

[PATCH] D92892: [clang] Change builtin object size to be compatible with GCC when sub-object is invalid

This revision was automatically updated to reflect the committed changes. Closed by commit rG275f30df8ad6: [clang] Change builtin object size when subobject is invalid (authored by jtmott-intel, committed by george.burgess.iv). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[clang] 275f30d - [clang] Change builtin object size when subobject is invalid

Author: Jeffrey T Mott Date: 2021-01-07T12:34:07-08:00 New Revision: 275f30df8ad6de75e1f29e4b33eaeb67686caf0d URL: https://github.com/llvm/llvm-project/commit/275f30df8ad6de75e1f29e4b33eaeb67686caf0d DIFF:

[PATCH] D94257: [test] Move coro-retcon-unreachable.ll into llvm/test

aeubanks created this revision. Herald added a subscriber: lxfind. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94257 Files:

[PATCH] D93785: [OpenMP][FIX] Ensure the isa trait is evaluated last

This revision was automatically updated to reflect the committed changes. Closed by commit rG36c4dc9b42fe: [OpenMP][FIX] Ensure the isa trait is evaluated last (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93785/new/

[clang] 36c4dc9 - [OpenMP][FIX] Ensure the isa trait is evaluated last

Author: Johannes Doerfert Date: 2021-01-07T14:31:20-06:00 New Revision: 36c4dc9b42fe2e6af4ab488b7c4013d5082b67f6 URL: https://github.com/llvm/llvm-project/commit/36c4dc9b42fe2e6af4ab488b7c4013d5082b67f6 DIFF:

[PATCH] D93786: [OpenMP][Fix] Make the arch selector for x86_64 work

This revision was automatically updated to reflect the committed changes. Closed by commit rGd970a285b856: [OpenMP][Fix] Make the arch selector for x86_64 work (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93786/new/

[clang] d970a28 - [OpenMP][Fix] Make the arch selector for x86_64 work

Author: Johannes Doerfert Date: 2021-01-07T14:31:18-06:00 New Revision: d970a285b8567b93aea39e7e4d10965fe8b7340c URL: https://github.com/llvm/llvm-project/commit/d970a285b8567b93aea39e7e4d10965fe8b7340c DIFF:

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

curdeius added a comment. LGTM if you add a test for hdrstop(filename) and possibly with LF newline (as the test you've already added tests CRLF). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94217/new/ https://reviews.llvm.org/D94217 ___

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

jdoerfert added a comment. In D86844#2484679 , @xbolva00 wrote: > In D86844#2484639 , @atmnpatel wrote: > >> In D86844#2484568 , @fhahn wrote: >> >>> In D86844#2481922

[PATCH] D91944: OpenMP 5.0 metadirective

jdoerfert added a comment. Are the test all passing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

curdeius accepted this revision. curdeius added a comment. LGTM from my perspective. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94206/new/ https://reviews.llvm.org/D94206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This LGTM, thank you for the patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94206/new/ https://reviews.llvm.org/D94206

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:2308 IncludesInBlock.clear(); -FirstIncludeBlock = false; +if (Trimmed.startswith("#pragma hdrstop")) // precompiled headers + FirstIncludeBlock = true;

[PATCH] D93772: [Clang][Driver] Fix read-after-free when using /clang:

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3854b81b0fd2: [Clang][Driver] Fix read-after-free when using /clang: (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 3854b81 - [Clang][Driver] Fix read-after-free when using /clang:

Author: Alexandre Ganea Date: 2021-01-07T15:15:13-05:00 New Revision: 3854b81b0fd23adc9bab91bf68918d102dc31f51 URL: https://github.com/llvm/llvm-project/commit/3854b81b0fd23adc9bab91bf68918d102dc31f51 DIFF:

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

fghanim added a comment. Ping. Please add the Lit test for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91054/new/ https://reviews.llvm.org/D91054 ___ cfe-commits mailing list

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

awarzynski added a comment. In D94169#2484968 , @andreil99 wrote: > I'm fine with having this text in the ClangCommandLineReference.rst only, and > removing it from `clang -help`. > > However, reverting the patch would not do, as

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/ https://reviews.llvm.org/D84673

[PATCH] D94252: Delete (most) of the MMX builtin functions from Clang.

jyknight created this revision. jyknight added reviewers: craig.topper, spatel, RKSimon. jyknight requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. After switching the headers to implement the intrinsics using SSE2 (see

[clang] ad55d5c - Simplify vectorcall argument classification of HVAs, NFC

Author: Reid Kleckner Date: 2021-01-07T11:14:18-08:00 New Revision: ad55d5c3f32f6598f8ac30b68f4961d82cdb1fed URL: https://github.com/llvm/llvm-project/commit/ad55d5c3f32f6598f8ac30b68f4961d82cdb1fed DIFF: https://github.com/llvm/llvm-project/commit/ad55d5c3f32f6598f8ac30b68f4961d82cdb1fed.diff

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

andreil99 requested changes to this revision. andreil99 added a comment. This revision now requires changes to proceed. I'm fine with having this text in the ClangCommandLineReference.rst only, and removing it from `clang -help`. However, reverting the patch would not do, as

[PATCH] D94233: [NFC] make clang/test/CodeGen/arm_neon_intrinsics.c resistent to function attribute id changes

jeroen.dobbelaere added a comment. Thanks ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94233/new/ https://reviews.llvm.org/D94233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93638/new/ https://reviews.llvm.org/D93638 ___ cfe-commits mailing list

[PATCH] D94239: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests

abhina.sreeskantharajan updated this revision to Diff 315182. abhina.sreeskantharajan added a comment. There was an extra ^M carriage return at the end of two lines in lld/test/COFF/pdb-type-server-invalid-signature.yaml CHECK lines. This update removes them. Repository: rG LLVM Github

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. In D93638#2483913 , @hliao wrote: > Forget that C function could be overloaded on Clang with overloadable > extension. With that, we don't need to mark

[PATCH] D94039: [WebAssembly] Update WasmEHPrepare for the new spec

tlively added inline comments. Comment at: llvm/lib/CodeGen/WasmEHPrepare.cpp:374-375 + // be lowered to wasm 'catch' instruction. We do this mainly because + // instruction selection cannot handle wasm.get.exception intrinsic's token + // argument. + Instruction *CatchCI =

[PATCH] D94188: [OpenCL] Documentation for experimental C++ libraries support

Anastasia marked 6 inline comments as done. Anastasia added inline comments. Comment at: clang/docs/OpenCLSupport.rst:134 + #pragma OPENCL EXTENSION __cl_clang_variadic_functions : enable + #include "type_traits" + #pragma OPENCL EXTENSION __cl_clang_function_pointers :

[PATCH] D94188: [OpenCL] Documentation for experimental C++ libraries support

Anastasia updated this revision to Diff 315173. Anastasia added a comment. Addressed review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94188/new/ https://reviews.llvm.org/D94188 Files: clang/docs/OpenCLSupport.rst Index: clang/docs/OpenCLSupport.rst

[clang] d015445 - Silence warning: comparison of integers of different signs: 'const unsigned int' and 'const long' [-Wsign-compare]

Author: Alexandre Ganea Date: 2021-01-07T13:01:06-05:00 New Revision: d0154456e61c5ab79e25fc9b8bb684ebdca3a7c2 URL: https://github.com/llvm/llvm-project/commit/d0154456e61c5ab79e25fc9b8bb684ebdca3a7c2 DIFF:

[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

rnk added inline comments. Comment at: clang/lib/CodeGen/CGCXXABI.h:143 /// Returns how an argument of the given record type should be passed. virtual RecordArgABI getRecordArgABI(const CXXRecordDecl *RD) const = 0; nit: I would group the new virtual

[PATCH] D92892: [clang] Change builtin object size to be compatible with GCC when sub-object is invalid

jtmott-intel added a comment. Seems I don't have commit access. I'll look into it. For now, could someone push this commit? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92892/new/ https://reviews.llvm.org/D92892 ___ cfe-commits

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

rjelonek updated this revision to Diff 315169. rjelonek added a comment. Add support to `#pragma hdrstop( "c:\\projects\\include\\myinc.pch" )' CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94217/new/ https://reviews.llvm.org/D94217 Files: clang/lib/Format/Format.cpp

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

rjelonek updated this revision to Diff 315166. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94206/new/ https://reviews.llvm.org/D94206 Files: clang/lib/Format/Format.cpp clang/unittests/Format/SortIncludesTest.cpp Index: clang/unittests/Format/SortIncludesTest.cpp

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel added a comment. I'm happy to add a patch amending this, the reason it wasn't done that way was because at the time and even now, out of icc/clang/msvc/gcc, gcc seems to be the only one that happily removed such loops in C++ (https://godbolt.org/z/W9vj99), and I didn't have a

[PATCH] D93483: Add element-type to the Vector TypeLoc types.

This revision was automatically updated to reflect the committed changes. Closed by commit rG43043adcfbc6: Add element-type to the Vector TypeLoc types. (authored by erichkeane). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D93483?vs=312582=315164#toc

[clang] 43043ad - Add element-type to the Vector TypeLoc types.

Author: Erich Keane Date: 2021-01-07T09:14:36-08:00 New Revision: 43043adcfbc60945646b791d7162e5a1307a5318 URL: https://github.com/llvm/llvm-project/commit/43043adcfbc60945646b791d7162e5a1307a5318 DIFF: https://github.com/llvm/llvm-project/commit/43043adcfbc60945646b791d7162e5a1307a5318.diff

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

This revision was automatically updated to reflect the committed changes. Closed by commit rGacbb3652931a: [AST][NFC] Silence GCC warning about multiline comments (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92409/new/

[clang] acbb365 - [AST][NFC] Silence GCC warning about multiline comments

Author: Thomas Preud'homme Date: 2021-01-07T17:11:49Z New Revision: acbb3652931a735a861b756075b1cc86fd041761 URL: https://github.com/llvm/llvm-project/commit/acbb3652931a735a861b756075b1cc86fd041761 DIFF: https://github.com/llvm/llvm-project/commit/acbb3652931a735a861b756075b1cc86fd041761.diff

[PATCH] D94233: [NFC] make clang/test/CodeGen/arm_neon_intrinsics.c resistent to function attribute id changes

pratlucas added a comment. No problem! I've pushed the commit on your behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94233/new/ https://reviews.llvm.org/D94233 ___ cfe-commits mailing list

[PATCH] D94233: [NFC] make clang/test/CodeGen/arm_neon_intrinsics.c resistent to function attribute id changes

This revision was automatically updated to reflect the committed changes. Closed by commit rG59fce6b06616: [NFC] make clang/test/CodeGen/arm_neon_intrinsics.c resistent to function… (authored by jeroen.dobbelaere, committed by pratlucas). Herald added a project: clang. Herald added a subscriber:

[clang] 59fce6b - [NFC] make clang/test/CodeGen/arm_neon_intrinsics.c resistent to function attribute id changes

Author: Jeroen Dobbelaere Date: 2021-01-07T17:08:15Z New Revision: 59fce6b0661647062918a47bdb1874950d3938d5 URL: https://github.com/llvm/llvm-project/commit/59fce6b0661647062918a47bdb1874950d3938d5 DIFF: https://github.com/llvm/llvm-project/commit/59fce6b0661647062918a47bdb1874950d3938d5.diff

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

richard.barton.arm accepted this revision. richard.barton.arm added a comment. This revision is now accepted and ready to land. The rationale for this revert looks good to me. I don't see the rationale behind the original change as it was committed without review. If @andrei99 gets back to us

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

xbolva00 added a comment. In D86844#2484639 , @atmnpatel wrote: > In D86844#2484568 , @fhahn wrote: > >> In D86844#2481922 , @xbolva00 wrote: >> >>> int a, b; >>> >>>

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

fhahn added a comment. In D86844#2484639 , @atmnpatel wrote: > I might be misunderstanding the standard here but since 1 is a non-zero > constant expression, it can't be assumed to terminate by the implementation > right? The relevant section from C11

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

fhahn added subscribers: xbolva00, fhahn. fhahn added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:799 EmitBoolCondBranch = false; + FnIsMustProgress = false; +} Shouldn't this only apply for C?

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel added a comment. In D86844#2484568 , @fhahn wrote: > In D86844#2481922 , @xbolva00 wrote: > >> int a, b; >> >> int f(void) { >> while (1) { >> if (a != b) return 1; >> } >>

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92409/new/ https://reviews.llvm.org/D92409

[PATCH] D94239: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan added reviewers: Kai, fanbo-meng, muiez, zibi, hubert.reinterpretcast. Herald added subscribers: wenlei, rupprecht, steven_wu, gbedwell, hiraditya, emaste. Herald added a reviewer: JDevlieghere. Herald added a reviewer:

[PATCH] D94237: [clang] Use SourceLocations in unions

miyuki created this revision. miyuki added reviewers: dexonsmith, aprantl, rsmith. Herald added a subscriber: jfb. miyuki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, there are many instances where `SourceLocation` objects

  1   2   >