[PATCH] D93829: [clangd] Support outgoing calls in call hierarchy

nridge added a comment. Thanks for working on this! I haven't looked at the whole patch in detail, but I looked at some parts (mainly the `SymbolIndex` API and what in-memory structures we store to implement it) and wrote a few thoughts. Comment at:

[PATCH] D93822: [clang][Sema] Add diagnostics for implicit widening of multiplication result

lebedev.ri added a comment. Ping In D93822#2474475 , @dblaikie wrote: > In D93822#2474355 , @lebedev.ri > wrote: > >> Thank you for taking a look! >> >> In D93822#2474236

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag updated this revision to Diff 315708. AMDChirag added a comment. Added OMP delegating code for `createSection` (`EmitOMPSectionDirective`). @fghanim working on clang lit test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91054/new/

[PATCH] D94382: [clangd] Avoid recursion in TargetFinder::add()

nridge added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:379 if (const TypedefNameDecl *TND = dyn_cast(D)) { add(TND->getUnderlyingType(), Flags | Rel::Underlying); Flags |= Rel::Alias; // continue with the alias.

[PATCH] D93591: [MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. ergawy marked an inline comment as done. Closed by commit rGa40767ec8851: [MLIR][SPIRV] Add (de-)serialization support for

[PATCH] D94382: [clangd] Avoid recursion in TargetFinder::add()

kadircet added a comment. oh and also thanks a lot for all the investigation and fix of the issue! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94382/new/ https://reviews.llvm.org/D94382 ___

[PATCH] D94382: [clangd] Avoid recursion in TargetFinder::add()

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:379 if (const TypedefNameDecl *TND = dyn_cast(D)) { add(TND->getUnderlyingType(), Flags | Rel::Underlying); Flags |= Rel::Alias; // continue with the alias.

[PATCH] D94359: [clangd] Remove ScratchFS from tests

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/GlobalCompilationDatabaseTests.cpp:277 + llvm::formatv(CDB, llvm::sys::path::convert_to_slash(testRoot())); + ; EXPECT_THAT(Command("x/foo.cc"), Contains("-DXYZZY")); nit:

[clang] b8d2842 - CGDebugInfo: Delete unneeded UnwrapTypeForDebugInfo

Author: Fangrui Song Date: 2021-01-10T22:22:07-08:00 New Revision: b8d28420885a42d16a57e02c28129d0eb92474a1 URL: https://github.com/llvm/llvm-project/commit/b8d28420885a42d16a57e02c28129d0eb92474a1 DIFF: https://github.com/llvm/llvm-project/commit/b8d28420885a42d16a57e02c28129d0eb92474a1.diff

[clang] 6215c1b - CGDebugInfo: Delete redundant test

Author: Fangrui Song Date: 2021-01-10T22:22:06-08:00 New Revision: 6215c1b778f62433f3d79addc299a1bbd0e524d0 URL: https://github.com/llvm/llvm-project/commit/6215c1b778f62433f3d79addc299a1bbd0e524d0 DIFF: https://github.com/llvm/llvm-project/commit/6215c1b778f62433f3d79addc299a1bbd0e524d0.diff

[PATCH] D94162: [PowerPC] Add variants of 64-bit vector types for vec_sel.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGffa67873a3f9: [PowerPC] Add variants of 64-bit vector types for vec_sel. (authored by Esme). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] ffa6787 - [PowerPC] Add variants of 64-bit vector types for vec_sel.

Author: Esme-Yi Date: 2021-01-11T03:52:16Z New Revision: ffa67873a3f93a6baa0046221edd08a90b0db6f8 URL: https://github.com/llvm/llvm-project/commit/ffa67873a3f93a6baa0046221edd08a90b0db6f8 DIFF: https://github.com/llvm/llvm-project/commit/ffa67873a3f93a6baa0046221edd08a90b0db6f8.diff LOG:

[PATCH] D93817: [InstCombine] Update transformations to use poison for insertelement/shufflevector's placeholder value (2/2)

aqjune added inline comments. Comment at: llvm/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp:1221 if (!isa(I->getOperand(1))) { -I->setOperand(1, UndefValue::get(I->getOperand(1)->getType())); MadeChange = true; This change

[PATCH] D94382: [clangd] Avoid recursion in TargetFinder::add()

nridge updated this revision to Diff 315689. nridge marked an inline comment as done. nridge added a comment. Use map lookup instead of iteration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94382/new/ https://reviews.llvm.org/D94382 Files:

[PATCH] D94382: [clangd] Avoid recursion in TargetFinder::add()

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:333 Decls; + const Decl *CurrentlyProcessing = nullptr; RelSet Flags; njames93 wrote: > Whats the purpose in tracking this? Is

[PATCH] D94382: [clangd] Avoid recursion in TargetFinder::add()

njames93 added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:333 Decls; + const Decl *CurrentlyProcessing = nullptr; RelSet Flags; Whats the purpose in tracking this? Is the Decls lookup not enough? Comment

[PATCH] D94382: [clangd] Avoid recusion in TargetFinder::add()

nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:790 +TEST_F(TargetDeclTest, TypedefCascade) { + Code = R"cpp( This test case is not strictly related to the bug, but it adds test coverage for a scenario that I

[PATCH] D94382: [clangd] Avoid recusion in TargetFinder::add()

nridge created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/633 Repository: rG LLVM

[PATCH] D94381: [test] Add Clang side tests for -fdebug-info-for-profiling

MaskRay created this revision. MaskRay added reviewers: dblaikie, davidxl, wmi. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is currently a driver test but no test for its effect on linkageName & pass pipeline.

[PATCH] D94337: Add cuda header type for cuh files

jlebar added a comment. Hi, welcome! Thank you for the careful and well-motivated first commit. (I also see https://github.com/ccache/ccache/issues/772, hooray for noticing that...) I am also not 100% sure how to write a test, but I think you may be able to observe the effect of your driver

[PATCH] D94380: [InstCombine] Update transformations to use poison for insertelement/shufflevector's placeholder value (1/2)

aqjune added inline comments. Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:1728 // Vec. if (IdxN % DstNumElts != 0 || IdxN + DstNumElts > VecNumElts) { replaceInstUsesWith(CI, UndefValue::get(CI.getType())); Guarded by

[PATCH] D93978: [clangd] DefineOutline doesn't require implementation file being saved

njames93 added a comment. So I did some tweaking and I have a snapshot filesystem that will hold shared references to the contents, thereby avoiding the need to copy the file contents. It works for rename and tweaks with no visible issues. Reasoning behind this a long term goal of letting a user

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf added a comment. In D93986#2489140 , @HazardyKnusperkeks wrote: > Apart from my inline comment and the pre merge check this is superb. (I will > not accept it, until we have reached a conclusion for the documentation.) Regarding the pre-merge

[clang] 02bc320 - CGDebugInfo: Delete unused DIFile* parameter

Author: Fangrui Song Date: 2021-01-10T15:03:40-08:00 New Revision: 02bc320545deb0212a43acae24fcf2383755d383 URL: https://github.com/llvm/llvm-project/commit/02bc320545deb0212a43acae24fcf2383755d383 DIFF: https://github.com/llvm/llvm-project/commit/02bc320545deb0212a43acae24fcf2383755d383.diff

[PATCH] D94359: [clangd] Remove ScratchFS from tests

adamcz accepted this revision. adamcz added a comment. This revision is now accepted and ready to land. Thanks, that's better than my hacky workaround! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94359/new/ https://reviews.llvm.org/D94359

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

HazardyKnusperkeks added a comment. Apart from my inline comment and the pre merge check this is superb. (I will not accept it, until we have reached a conclusion for the documentation.) Comment at: clang/docs/ClangFormatStyleOptions.rst:338 + + int = 12; + int

[clang] abfe348 - [test] Improve CodeGenCXX/difile_entry.cpp

Author: Fangrui Song Date: 2021-01-10T12:24:49-08:00 New Revision: abfe348e6b4c50c750d70adcf0b99fd3d8d4132e URL: https://github.com/llvm/llvm-project/commit/abfe348e6b4c50c750d70adcf0b99fd3d8d4132e DIFF: https://github.com/llvm/llvm-project/commit/abfe348e6b4c50c750d70adcf0b99fd3d8d4132e.diff

[PATCH] D87147: PR-47391 : Two DIFile entries are describing the same file two different ways

MaskRay added inline comments. Comment at: clang/test/CodeGenCXX/difile_entry.cpp:1 +// RUN: rm -rf %t/test_dir +// RUN: mkdir -p %t/test_dir MaskRay wrote: > @umesh.kalappa0 Can you clarify how this test demonstrates the behavior > difference? > > Reverting

[PATCH] D87147: PR-47391 : Two DIFile entries are describing the same file two different ways

MaskRay added inline comments. Comment at: clang/test/CodeGenCXX/difile_entry.cpp:1 +// RUN: rm -rf %t/test_dir +// RUN: mkdir -p %t/test_dir @umesh.kalappa0 Can you clarify how this test demonstrates the behavior difference? Reverting the code part does not

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

xbolva00 added a comment. Just note: gcc enables -ffinite-loops with opt level -O2 and higher. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94367/new/ https://reviews.llvm.org/D94367 ___ cfe-commits

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

lebedev.ri added a comment. In D94367#2489090 , @fhahn wrote: > Thanks for putting up the patch! > > I think the code here and D94366 could be > simplified if we would introduce 2 codegen options to distinguish the >

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

fhahn added reviewers: rjmccall, aaron.ballman, erichkeane. fhahn added a comment. Thanks for putting up the patch! I think the code here and D94366 could be simplified if we would introduce 2 codegen options to distinguish the differences between C and C++:

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93986/new/ https://reviews.llvm.org/D93986 ___ cfe-commits mailing list

[PATCH] D93591: [MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation.

antiagainst accepted this revision. antiagainst added a comment. Awesome, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93591/new/ https://reviews.llvm.org/D93591 ___ cfe-commits mailing list

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf updated this revision to Diff 315665. tinloaf added a comment. Fix merge conflict in the release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93986/new/ https://reviews.llvm.org/D93986 Files:

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf marked 3 inline comments as done. tinloaf added a comment. This is now an all-in-one revision, including bit fields, assignments, declarations and macros. I did not reproduce the full "across empty lines, across comments, across empty lines *and* comments" test suite for all four of

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf added a comment. In D93986#2477860 , @HazardyKnusperkeks wrote: > In D93986#2477474 , @tinloaf wrote: > >> In D93986#2477383 , @MyDeveloperDay >> wrote: >> >>>

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf updated this revision to Diff 315664. tinloaf marked an inline comment as done. tinloaf added a comment. - Unify the type of the options for `AlignConsecutive`{`BitFields`, `Declarations`, `Assignments`, `Macros`} - Implement across-alignment for bit fields, declarations, assignments and

[PATCH] D93591: [MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation.

ergawy marked 2 inline comments as done. ergawy added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:623 {"referencesProvider", true}, -{"astProvider", true}, +{"astProvider", true}, // clangd extension

[PATCH] D93591: [MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation.

ergawy updated this revision to Diff 315658. ergawy marked 5 inline comments as done. ergawy added a comment. Handle review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93591/new/ https://reviews.llvm.org/D93591 Files: