[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=" for MSInlineASM

FreddyYe updated this revision to Diff 318123. FreddyYe added a comment. consider Clobber == "edx" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94466/new/ https://reviews.llvm.org/D94466 Files: clang/lib/CodeGen/CGStmt.cpp

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

pdhaliwal updated this revision to Diff 318120. pdhaliwal added a comment. - Moved common methods of HIP and OpenMP to base ROCMToolChain - Removed unnecessary asserts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94961/new/

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:642-649 +const internal::VariadicDynCastAllOfMatcher cxxFoldExpr; + +AST_MATCHER_P(CXXFoldExpr, hasOperator, BinaryOperatorKind, Op) { + return Node.getOperator() == Op; +}

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer added a comment. @HazardyKnusperkeks let me know if the additions to the unit test are along the lines you were hoping for or not, I think this captures what you had in mind. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer updated this revision to Diff 318111. kentsommer added a comment. Expanded unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D95017: [clang-format] add case aware include sorting

HazardyKnusperkeks added a comment. Please expand the test case to different options like grouping. Otherwise looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

vabridgers added a comment. Ping. Could someone pick up review of this patch again, please? Ilya left off with a question to @rsmith , and at that point all activity fell off. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71714/new/

[PATCH] D95089: [Clang][OpenMP] Use `clang_cc1` test for `declare_target_device_only_compilation.cpp`

This revision was automatically updated to reflect the committed changes. Closed by commit rG3809e5dac965: [Clang][OpenMP] Use `clang_cc1` test for… (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95089/new/

[clang] 3809e5d - [Clang][OpenMP] Use `clang_cc1` test for `declare_target_device_only_compilation.cpp`

Author: Shilei Tian Date: 2021-01-20T20:34:10-05:00 New Revision: 3809e5dac965e7c25f3c286884a7af6e48946865 URL: https://github.com/llvm/llvm-project/commit/3809e5dac965e7c25f3c286884a7af6e48946865 DIFF: https://github.com/llvm/llvm-project/commit/3809e5dac965e7c25f3c286884a7af6e48946865.diff

[PATCH] D94820: Support for instrumenting only selected files or functions

davidxl added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2591 + } + return false; +} phosek wrote: > davidxl wrote: > > If the profile list contains only one line of exclude list, it seems that > > all functions will be rejected as the

[PATCH] D94806: [OpenMP] Add support for mapping names in mapper API

jhuber6 updated this revision to Diff 318061. jhuber6 added a comment. Adding a test case for the mapper names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94806/new/ https://reviews.llvm.org/D94806 Files:

[PATCH] D94269: Adds -Wfree-nonheap-object to -Wmost

xbolva00 added a comment. Can you mention this new warning in release notes? https://clang.llvm.org/docs/ReleaseNotes.html CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94269/new/ https://reviews.llvm.org/D94269 ___ cfe-commits mailing list

[PATCH] D94732: [CUDA] Normalize handling of defauled dtor.

tra updated this revision to Diff 318052. tra added a comment. Added a test for the corner case Richard has pointed out in the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94732/new/ https://reviews.llvm.org/D94732 Files:

[PATCH] D95053: [Demangle] Support demangling Swift calling convention in MS demangler.

varungandhi-apple marked an inline comment as done. varungandhi-apple added a comment. I've fixed this by including an additional space in the string instead of using a method like `outputSpaceIfNecessary`; (1) that method doesn't work as it is and I think changing it for this purpose is not

[PATCH] D95053: [Demangle] Support demangling Swift calling convention in MS demangler.

varungandhi-apple updated this revision to Diff 318050. varungandhi-apple added a comment. Add extra space for better readability, as suggested by @compnerd. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95053/new/ https://reviews.llvm.org/D95053

[PATCH] D94617: [RISCV] Add Zba feature and move add.uw and slli.uw to it.

craig.topper updated this revision to Diff 318038. craig.topper added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94617/new/ https://reviews.llvm.org/D94617 Files: clang/lib/Driver/ToolChains/Arch/RISCV.cpp

[PATCH] D94582: [RISCV] Rename mnemonics slliu.w->slli.uw and addu.w->add.uw to match 0.93 bitmanip spec.

craig.topper updated this revision to Diff 318037. craig.topper added a comment. Remove Zba changes that accidentally got merged in the previous rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94582/new/ https://reviews.llvm.org/D94582

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

rjmccall added a comment. I think the plan should be to use this code pattern on all targets, but starting it with arm64 seems fine. Comment at: clang/lib/CodeGen/CGObjC.cpp:2342 +attrs = attrs.addAttribute(CGF.getLLVMContext(), +

[PATCH] D94582: [RISCV] Rename mnemonics slliu.w->slli.uw and addu.w->add.uw to match 0.93 bitmanip spec.

craig.topper updated this revision to Diff 318032. craig.topper added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94582/new/ https://reviews.llvm.org/D94582

[PATCH] D95099: [clang-scan-deps] : Support -- in clang command lines.

saudi created this revision. saudi added reviewers: arphaman, jkolek, Bigcheese, kousikk, dexonsmith, hans. saudi added a project: clang. Herald added a subscriber: tschuett. saudi requested review of this revision. Herald added a subscriber: cfe-commits. This fixes argument injection when clang

[PATCH] D95081: [clang-format] [NFC] Restructure getLineCommentIndentPrefix

curdeius added inline comments. Comment at: clang/lib/Format/BreakableToken.cpp:44 const FormatStyle ) { + // Keep these prefixes sorted after length. static constexpr StringRef KnownCStylePrefixes[] = {"///<", "//!<", "///",

[PATCH] D94732: [CUDA] Normalize handling of defauled dtor.

tra updated this revision to Diff 318018. tra added a comment. Removed unneeded changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94732/new/ https://reviews.llvm.org/D94732 Files: clang/lib/Sema/SemaCUDA.cpp

[PATCH] D94732: [CUDA] Normalize handling of defauled dtor.

tra added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:15162-15170 + bool SkipDtorChecks = VD->getType()->isArrayType(); + + // CUDA: Skip destructor checks for host-only variables during device-side + // compilation + SkipDtorChecks |= +

[PATCH] D95078: [clang-format] [NFC] Use some constexpr StringRef instead of const char*.

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95078/new/ https://reviews.llvm.org/D95078

[PATCH] D94732: [CUDA] Normalize handling of defauled dtor.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:15162-15170 + bool SkipDtorChecks = VD->getType()->isArrayType(); + + // CUDA: Skip destructor checks for host-only variables during device-side + // compilation + SkipDtorChecks |= +

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

tstellar updated this revision to Diff 318003. tstellar added a comment. Fix shared object symlinks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94941/new/ https://reviews.llvm.org/D94941 Files: clang/CMakeLists.txt

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

tstellar added inline comments. Comment at: clang/tools/clang-shlib/CMakeLists.txt:54 + PROPERTIES + SOVERSION ${LIBCLANG_LIBRARY_VERSION}) cuviper wrote: > tstellar wrote: > > cuviper wrote: > > > I think you also need `VERSION` here, or else it

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

cuviper added inline comments. Comment at: clang/tools/clang-shlib/CMakeLists.txt:54 + PROPERTIES + SOVERSION ${LIBCLANG_LIBRARY_VERSION}) tstellar wrote: > cuviper wrote: > > I think you also need `VERSION` here, or else it symlinks back to `.so.11`.

[PATCH] D95089: [Clang][OpenMP] Use `clang_cc1` test for `declare_target_device_only_compilation.cpp`

tianshilei1992 created this revision. tianshilei1992 added a reviewer: echristo. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Use

[PATCH] D95053: [Demangle] Support demangling Swift calling convention in MS demangler.

compnerd accepted this revision. compnerd added a subscriber: rnk. compnerd added a comment. This revision is now accepted and ready to land. Perhaps @rnk has any thoughts, but this seems very straightforward. Thanks for fixing this! Comment at:

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

tstellar added inline comments. Comment at: clang/tools/clang-shlib/CMakeLists.txt:54 + PROPERTIES + SOVERSION ${LIBCLANG_LIBRARY_VERSION}) cuviper wrote: > I think you also need `VERSION` here, or else it symlinks back to `.so.11`. I think

[PATCH] D95075: [hip] Fix `` compilation on Windows with VS2019.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7b5d7c7b0a24: [hip] Fix `complex` compilation on Windows with VS2019. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 7b5d7c7 - [hip] Fix `` compilation on Windows with VS2019.

Author: Michael Liao Date: 2021-01-20T16:43:44-05:00 New Revision: 7b5d7c7b0a2479de007ad18b947459b71667 URL: https://github.com/llvm/llvm-project/commit/7b5d7c7b0a2479de007ad18b947459b71667 DIFF: https://github.com/llvm/llvm-project/commit/7b5d7c7b0a2479de007ad18b947459b71667.diff

[PATCH] D94806: [OpenMP] Add support for mapping names in mapper API

jhuber6 updated this revision to Diff 317994. jhuber6 added a comment. Changing the handling of `OMP_TGT_MAPTYPE_PTR_AND_OBJ` so it will not pass the same name for the base object. This doesn't pass in the correct name, simply makes it show up as `unknown` if queried. Repository: rG LLVM

[PATCH] D95087: [clangd] Inject context provider rather than config into ClangdServer. NFC

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This is a step towards allowing CDB

[PATCH] D93668: [clang] Override the Fuchsia platform ABI using the triple environment

mcgrathr added a comment. The Fuchsia platform ABI includes the SS & SCS ABI. There is no compatibility issue with those. PIC-friendly optimizations are purely an optimization and correctness issue for any PIC/PIE code, and is not an ABI issue. The only thing where we have an incompatible

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

njames93 updated this revision to Diff 317984. njames93 added a comment. - Replace getFinalOverrides for a manual implementation, that method wasn't quite suited to what was needed w.r.t tracking access. - Add support for template classes with no dependant bases. - Add tests for template

[PATCH] D95081: [clang-format] [NFC] Restructure getLineCommentIndentPrefix

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When sorting the

[PATCH] D94269: Adds -Wfree-nonheap-object to -Wmost

cjdb closed this revision. cjdb added a comment. Merged in 4a47da2cf440c2f2006d9b04acfef4292de1e263 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94269/new/ https://reviews.llvm.org/D94269

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa3d7cee7f9bd: [CodeView] Emit function types in -gline-tables-only. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] a3d7cee - [CodeView] Emit function types in -gline-tables-only.

Author: Amy Huang Date: 2021-01-20T12:47:35-08:00 New Revision: a3d7cee7f9bdfbe3e88e4de39a76c3d3e2690fdb URL: https://github.com/llvm/llvm-project/commit/a3d7cee7f9bdfbe3e88e4de39a76c3d3e2690fdb DIFF: https://github.com/llvm/llvm-project/commit/a3d7cee7f9bdfbe3e88e4de39a76c3d3e2690fdb.diff

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

akhuang updated this revision to Diff 317975. akhuang added a comment. Add comments describing reason for emitting types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95001/new/ https://reviews.llvm.org/D95001 Files:

[PATCH] D95078: [clang-format] [NFC] Use some constexpr StringRef instead of const char*.

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D95075: [hip] Fix `` compilation on Windows with VS2019.

hliao updated this revision to Diff 317966. hliao added a comment. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95075/new/ https://reviews.llvm.org/D95075 Files: clang/lib/Headers/__clang_hip_cmath.h Index:

[PATCH] D93922: Mangle `__alignof__` differently than `alignof`.

rjmccall added a reviewer: fhahn. rjmccall added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:4032 + } } break; The old case doesn't seem to be adding the `u8__uuidof` prefix anymore. Your patch description does not say anything

[PATCH] D95075: [hip] Fix `` compilation on Windows with VS2019.

hliao created this revision. hliao added reviewers: tra, yaxunl. hliao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95075 Files: clang/lib/Headers/__clang_hip_cmath.h

[PATCH] D92290: [clangd] Factor out the heuristic resolver code into its own class

nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:90 +for (const auto : + allTargetDecls(N->ASTNode, AST.getHeuristicResolver())) ActualDecls.emplace_back(Entry.first, Entry.second); sammccall

[PATCH] D93922: Mangle `__alignof__` differently than `alignof`.

rsmith added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:4010 +if (Context.getASTContext().getLangOpts().getClangABICompat() >= +LangOptions::ClangABI::Ver11) { + Out << "u8__uuidof"; Should this be `>= Ver12` / `> Ver11` (given

[PATCH] D95070: Fix crash when emitting NullReturn guards for functions returning BOOL

jroelofs updated this revision to Diff 317959. jroelofs added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95070/new/ https://reviews.llvm.org/D95070 Files: clang/lib/CodeGen/CGObjCMac.cpp

[PATCH] D85223: [CUDA][HIP] Support accessing static device variable in host code for -fgpu-rdc

tra added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11446-11447 bool ASTContext::mayExternalizeStaticVar(const Decl *D) const { - return !getLangOpts().GPURelocatableDeviceCode && + return (!getLangOpts().CUID.empty() || +

[clang] 8776e3f - [EXTINT][OMP] Fix _ExtInt type checking in device code

Author: Erich Keane Date: 2021-01-20T11:35:52-08:00 New Revision: 8776e3f289c19ee2e85c593792806e6503408d59 URL: https://github.com/llvm/llvm-project/commit/8776e3f289c19ee2e85c593792806e6503408d59 DIFF: https://github.com/llvm/llvm-project/commit/8776e3f289c19ee2e85c593792806e6503408d59.diff

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

cuviper added inline comments. Comment at: clang/tools/clang-shlib/CMakeLists.txt:54 + PROPERTIES + SOVERSION ${LIBCLANG_LIBRARY_VERSION}) I think you also need `VERSION` here, or else it symlinks back to `.so.11`. Repository: rG LLVM Github

[PATCH] D95012: [WebAssembly] Prototype new f64x2 conversions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG11802eced5d6: [WebAssembly] Prototype new f64x2 conversions (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 11802ec - [WebAssembly] Prototype new f64x2 conversions

Author: Thomas Lively Date: 2021-01-20T11:28:06-08:00 New Revision: 11802eced5d67394c1dcb5acfaef38b0038c6d90 URL: https://github.com/llvm/llvm-project/commit/11802eced5d67394c1dcb5acfaef38b0038c6d90 DIFF: https://github.com/llvm/llvm-project/commit/11802eced5d67394c1dcb5acfaef38b0038c6d90.diff

[PATCH] D93668: [clang] Override the Fuchsia platform ABI using the triple environment

phosek added a comment. In D93668#2510463 , @leonardchan wrote: > Also, this probably isn't very important, but just as a heads up: if we were > to depend on the environment component in the triple as the flag for > selecting which multilib to use, then

[PATCH] D93668: [clang] Override the Fuchsia platform ABI using the triple environment

leonardchan added a comment. Also, this probably isn't very important, but just as a heads up: if we were to depend on the environment component in the triple as the flag for selecting which multilib to use, then the multilib would be stored in a directory containing that environment. So

[PATCH] D92892: [clang] Change builtin object size to be compatible with GCC when sub-object is invalid

aaron.ballman added a comment. In D92892#2510445 , @george.burgess.iv wrote: > reverted in > https://github.com/llvm/llvm-project/commit/b270fd59f0a86fe737853abc43e76b9d29a67eea > until we can figure out how to address the issues outlined above.

[PATCH] D92892: [clang] Change builtin object size to be compatible with GCC when sub-object is invalid

george.burgess.iv added a comment. reverted in https://github.com/llvm/llvm-project/commit/b270fd59f0a86fe737853abc43e76b9d29a67eea until we can figure out how to address the issues outlined above. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94732: [CUDA] Normalize handling of defauled dtor.

tra added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:15162-15170 + bool SkipDtorChecks = VD->getType()->isArrayType(); + + // CUDA: Skip destructor checks for host-only variables during device-side + // compilation + SkipDtorChecks |= +

[clang] b270fd5 - Revert "[clang] Change builtin object size when subobject is invalid"

Author: George Burgess IV Date: 2021-01-20T11:03:34-08:00 New Revision: b270fd59f0a86fe737853abc43e76b9d29a67eea URL: https://github.com/llvm/llvm-project/commit/b270fd59f0a86fe737853abc43e76b9d29a67eea DIFF:

[PATCH] D94732: [CUDA] Normalize handling of defauled dtor.

tra updated this revision to Diff 317946. tra added a comment. Addressed Richard's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94732/new/ https://reviews.llvm.org/D94732 Files: clang/lib/Sema/SemaCUDA.cpp

[PATCH] D92892: [clang] Change builtin object size to be compatible with GCC when sub-object is invalid

aaron.ballman added a comment. In D92892#2510299 , @manojgupta wrote: > This CL has caused two issues in Chrome OS : > Compilation fail with FORTIFY: > https://bugs.chromium.org/p/chromium/issues/detail?id=1168199 > Runtime failures: >

[PATCH] D94986: Remove requirement for -maltivec to be used when using -mabi=vec-extabi or -mabi=vec-default when not using vector code

ZarkoCA marked 3 inline comments as done. ZarkoCA added inline comments. Comment at: clang/test/CodeGen/altivec.c:13 // RUN: not %clang -S -emit-llvm -maltivec -target powerpc64-unknown-aix %s 2>&1 | FileCheck %s --check-prefix=AIX-ERROR -// RUN: not %clang -S -emit-llvm

[PATCH] D95007: [CUDA][HIP] Add -fuse-cuid

tra added inline comments. Herald added a reviewer: jansvoboda11. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2307 + // Only alphanumeric and underscore is allowed in -cuid option. + if (auto *A = Args.getLastArg(OPT_cuid_EQ)) { +const char *V = A->getValue();

[PATCH] D95061: [OpenCL][Docs] Moved information about internals from UsersManual into OpenCLSupport

Anastasia updated this revision to Diff 317943. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95061/new/ https://reviews.llvm.org/D95061 Files: clang/docs/OpenCLSupport.rst clang/docs/UsersManual.rst Index: clang/docs/UsersManual.rst

[PATCH] D94986: Remove requirement for -maltivec to be used when using -mabi=vec-extabi or -mabi=vec-default when not using vector code

ZarkoCA updated this revision to Diff 317936. ZarkoCA added a comment. Readd test for mabi=vec-default. Add -mcpu=pwr8 to AIX specific test case invocations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94986/new/

[PATCH] D83154: clang: Add -fprofile-prefix-map

keith added a comment. Yes sorry, big company reviews month. I will try to land Friday Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83154/new/ https://reviews.llvm.org/D83154 ___ cfe-commits mailing

[PATCH] D83154: clang: Add -fcoverage-prefix-map

phosek added a comment. Herald added a reviewer: jansvoboda11. @keith do you plan on landing this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83154/new/ https://reviews.llvm.org/D83154 ___

[PATCH] D92892: [clang] Change builtin object size to be compatible with GCC when sub-object is invalid

manojgupta added a comment. This CL has caused two issues in Chrome OS : Compilation fail with FORTIFY: https://bugs.chromium.org/p/chromium/issues/detail?id=1168199 Runtime failures: https://bugs.chromium.org/p/chromium/issues/detail?id=1167504 I have requested George to take a look but will

[PATCH] D95070: Fix crash when emitting NullReturn guards for functions returning BOOL

jroelofs created this revision. jroelofs added reviewers: rjmccall, arphaman. jroelofs requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. CodeGenModule::EmitNullConstant() creates constants with their "in memory" type, not their "in vregs"

[PATCH] D94979: [CGExpr] Use getCharWidth() more consistently in ConstantAggregateBuilderUtils. NFC

rjmccall added a comment. I don't mind generally abstracting Clang to handle this better. Comment at: clang/lib/CodeGen/CodeGenModule.h:1229 + // Return the LLVM type sized as one character unit. + llvm::Type *getCharSizedType(); + Please just add a CharTy

[PATCH] D94977: [CodeGen] Use getCharWidth() more consistently in CGRecordLowering. NFC

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94977/new/ https://reviews.llvm.org/D94977

[PATCH] D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj updated this revision to Diff 317924. timwoj added a comment. Add tests for Whitesmiths with all of the NamespaceIndentation options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94500/new/ https://reviews.llvm.org/D94500 Files:

[PATCH] D95063: AMDGPU: Use optimization remarks for register usage

arsenm created this revision. arsenm added reviewers: yaxunl, rampitec, scott.linder, t-tye, b-sumner. Herald added subscribers: kerbowa, hiraditya, tpr, dstuttard, nhaehnle, jvesely, kzhuravl. arsenm requested review of this revision. Herald added a subscriber: wdng. Herald added a project:

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen updated this revision to Diff 317916. khchen added a comment. address reviewer's suggestion, do not include test generator related part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/ https://reviews.llvm.org/D95016 Files:

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen added a comment. Really thanks for @jrtc27 and @craig.topper 's review suggestions. Before I upload the patch, I would want to discuss about the test generator, because if we don't want to upstream it, I don't need to fix some issues which are addressed by reivewers. @asb @jrtc27

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap closed this revision. Conanap added a comment. Pushed; differential revision link accidentally had an extra `https://` so it did not automatically close. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173

[PATCH] D95061: [OpenCL][Docs] Moved information about internals from UsersManual into OpenCLSupport

Anastasia created this revision. Anastasia added a reviewer: svenvh. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. Moved information detailing the implementation from UsersManual into OpenCLSupport page as it is not relevant to the user's of clang but

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

shafik accepted this revision. shafik added a comment. LGTM, thank you for expanding the test! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94786/new/ https://reviews.llvm.org/D94786 ___ cfe-commits

[PATCH] D95057: [clangd] WIP: configurable compilation database directory

sammccall created this revision. Herald added subscribers: usaxena95, kadircet, jfb, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D95055: [clang] Don't look into for C++ headers if they are found alongside the toolchain

ldionne added a comment. I would like to cherry-pick this change onto LLVM 11.1.0, if there is still time to do so. It is breaking Clang when the `sysroot` contains headers for libc++. Is it too late? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

martong accepted this revision. martong added a comment. Thanks for the update! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94786/new/ https://reviews.llvm.org/D94786 ___ cfe-commits mailing list

[PATCH] D95055: [clang] Don't look into for C++ headers if they are found alongside the toolchain

ldionne created this revision. ldionne added reviewers: tstellar, dexonsmith. Herald added a subscriber: jkorous. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, Clang looks for libc++ headers alongside the installation

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

wenlei added a subscriber: lxfind. wenlei added a comment. In D93747#2475852 , @dblaikie wrote: > In D93747#2470504 , @hoy wrote: > >> In D93747#2470387 , @dblaikie wrote:

[PATCH] D93922: Mangle `__alignof__` differently than `alignof`.

jyknight added a comment. Was the "group" libc++abi accept intended to be an accept for the whole revision? Or should still ping for review from rsmith or someone else? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93922/new/

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

jdoerfert added a comment. In D93525#2509836 , @t-tye wrote: > In D93525#2509796 , @jdoerfert wrote: > >>> At the moment this patch defines compatibility as exact string match of >>> bundler entry ID. >>> [...]

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

balazske updated this revision to Diff 317894. balazske added a comment. Removed use of `auto`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94786/new/ https://reviews.llvm.org/D94786 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D93224: [RFC][analyzer] Use the MacroExpansionContext for macro expansions in plists

martong added a comment. In D93224#2497632 , @steakhal wrote: > It seems quite a challenge to hook the `Preprocessor` for all possible > configurations for every `CompilerInvocation`. > The underlying machinery is somewhat complex and spaghetti to me. >

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

sylvestre.ledru added a comment. I guess this will be clearly mentioned in the release notes :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94941/new/ https://reviews.llvm.org/D94941 ___ cfe-commits

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Let's do it then :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94941/new/ https://reviews.llvm.org/D94941

[PATCH] D95053: [Demangle] Support demangling Swift calling convention in MS demangler.

varungandhi-apple created this revision. varungandhi-apple added a reviewer: compnerd. Herald added a subscriber: hiraditya. varungandhi-apple requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Previously, Clang was able to

[PATCH] D95031: [clangd] Log warning when using legacy (theia) semantic highlighting.

nridge added a comment. Thanks for the heads up! It would be nice to get D77702 landed before the removal of `TheiaSemanticHighlighting`. I'll try to find some time to rebase it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93222: [RFC][analyzer] Introduce MacroExpansionContext to libAnalysis

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Nice work! Thanks! Comment at: clang/lib/Analysis/MacroExpansionContext.cpp:210 +} \ No newline at end of file Missing newline?

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

cuviper added a comment. If the SONAME is different in any way, it is totally distinct to the dynamic linker. There's no semver parsing or anything like that. That's all we can do from a technical perspective, and the rest is just communication in the release. Repository: rG LLVM Github

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

sylvestre.ledru added a comment. Yeah, my question is more "is that enough for distro?" https://www.debian.org/doc/manuals/maint-guide/advanced.en.html https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html I might be wrong but if 11.1 and 11.0 aren't compatible (not

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

tstellar added a comment. In D94941#2509829 , @sylvestre.ledru wrote: > I might be wrong but if the ABI is incompatible, are we not supposed to > update the SONAME itself? That's what this patch does, it updates the SONAME from *-11 to *-11.1.

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

t-tye requested changes to this revision. t-tye added a comment. This revision now requires changes to proceed. In D93525#2509796 , @jdoerfert wrote: >> At the moment this patch defines compatibility as exact string match of >> bundler entry ID. >> [...]

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

sylvestre.ledru added a comment. I might be wrong but if the ABI is incompatible, are we not supposed to update the SONAME itself? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94941/new/ https://reviews.llvm.org/D94941

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

ASDenysPetrov added a comment. My propositions for the function `negate`. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:421 + ContainerType Result; + Result.reserve(What.getMinValue() == MIN ? What.size() + 1 : What.size()); Here you

[PATCH] D94865: [ASTMatchers] Add callOrConstruct matcher

steveire added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2867 +extern const internal::MapAnyOfMatcher +callOrConstruct; + aaron.ballman wrote: > steveire wrote: > > aaron.ballman wrote: > > > I'm not super keen on this name.

  1   2   >