[PATCH] D95299: Fix truncated __OPENMP_NVPTX__ preprocessor condition

r-burns created this revision. Herald added subscribers: guansong, yaxunl. r-burns requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I don't have a test case for this but noticed this warning when including system headers with `-I` rather

[PATCH] D93040: [InlineFunction] Use llvm.experimental.noalias.scope.decl for noalias arguments.

jeroen.dobbelaere added a comment. In D93040#2517769 , @jdoerfert wrote: > In D93040#2517758 , @xbolva00 wrote: > >>

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

tianshilei1992 updated this revision to Diff 318788. tianshilei1992 added a comment. Code cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94745/new/ https://reviews.llvm.org/D94745 Files: clang/lib/Driver/ToolChains/Cuda.cpp

[PATCH] D93040: [InlineFunction] Use llvm.experimental.noalias.scope.decl for noalias arguments.

jdoerfert added a comment. In D93040#2517758 , @xbolva00 wrote: > http://llvm-compile-time-tracker.com/compare.php?from=344afa853fcfcc085cb5c957b4a07c7ea013bb1b=2b9a834c43cb1f93d33958c14b695896bb4e9c1e=size-text > > Codesize regression 1% for tramp3d. Can

[PATCH] D93040: [InlineFunction] Use llvm.experimental.noalias.scope.decl for noalias arguments.

xbolva00 added a comment. http://llvm-compile-time-tracker.com/compare.php?from=344afa853fcfcc085cb5c957b4a07c7ea013bb1b=2b9a834c43cb1f93d33958c14b695896bb4e9c1e=size-text Codesize regression 1% for tramp3d. Can you check it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95161: [Clang][OpenMP][NVPTX] Replace `libomptarget-nvptx-path` with `libomptarget-nvptx-bc-path`

tianshilei1992 added a comment. In D95161#2517662 , @JonChesterfield wrote: > Still LGTM. A little surprised these are being run on windows, but good to be > robust. It's driver test which only invokes `-###`. ;-) No actual execution. Repository:

[PATCH] D95161: [Clang][OpenMP][NVPTX] Replace `libomptarget-nvptx-path` with `libomptarget-nvptx-bc-path`

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ad038aafa3a: [Clang][OpenMP][NVPTX] Replace `libomptarget-nvptx-path` with `libomptarget… (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5ad038a - [Clang][OpenMP][NVPTX] Replace `libomptarget-nvptx-path` with `libomptarget-nvptx-bc-path`

Author: Shilei Tian Date: 2021-01-23T14:42:38-05:00 New Revision: 5ad038aafa3a07a4491bf12cf6edf2026f3f17d1 URL: https://github.com/llvm/llvm-project/commit/5ad038aafa3a07a4491bf12cf6edf2026f3f17d1 DIFF: https://github.com/llvm/llvm-project/commit/5ad038aafa3a07a4491bf12cf6edf2026f3f17d1.diff

[PATCH] D95161: [Clang][OpenMP][NVPTX] Replace `libomptarget-nvptx-path` with `libomptarget-nvptx-bc-path`

JonChesterfield added a comment. Still LGTM. A little surprised these are being run on windows, but good to be robust. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95161/new/ https://reviews.llvm.org/D95161

[PATCH] D95161: [Clang][OpenMP][NVPTX] Replace `libomptarget-nvptx-path` with `libomptarget-nvptx-bc-path`

tianshilei1992 updated this revision to Diff 318772. tianshilei1992 added a comment. Fixed test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95161/new/ https://reviews.llvm.org/D95161 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:37 } MCUInfo[] = { {"at90s1200", "", "avr1"}, {"attiny11", "", "avr1"}, This may

[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

wenlei added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:609 + // Pass an option to enable pseudo probe emission. + if (Args.hasArg(options::OPT_fpseudo_probe_for_profiling)) +CmdArgs.push_back("-plugin-opt=pseudo-probe-for-profiling");

[PATCH] D63852: [Clang] Move assembler into a separate file

aykevl added a comment. Yeah I was wondering the same thing when I saw the failure. Unfortunately such design is a bit outside of my LLVM knowledge. I would just like to use cc1as_main.cpp functionality outside of LLVM without needing to update my copy of cc1as with every LLVM update.

[PATCH] D63852: [Clang] Move assembler into a separate file

hubert.reinterpretcast added a comment. In D63852#2517500 , @aykevl wrote: > or maybe I've put `AssemblerInvocation` in the wrong directory/library. This seems to be a good design question. I think a lot of people consider `-cc1` functionality to be the

[PATCH] D63852: [Clang] Move assembler into a separate file

hubert.reinterpretcast added a comment. @aykevl, please check http://lab.llvm.org:8011/#/builders/57/builds/3704: it seems you are missing a change to `clang/lib/Frontend/CMakeLists.txt` to update the `LLVM_LINK_COMPONENTS`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D63852: [Clang] Move assembler into a separate file

aykevl added a comment. @echristo do you have an idea what's going on or how to fix this? I suspect I'm not including a required dependency or maybe I've put `AssemblerInvocation` in the wrong directory/library. I'm not very familiar with CMake or C++ so I'm not sure how to best fix this.

[clang] 0057cc5 - Revert "[Clang] Move assembler into a separate file"

Author: Ayke van Laethem Date: 2021-01-23T15:04:27+01:00 New Revision: 0057cc5a215e5a26cfbd7e1707b55bf05fa9b6bf URL: https://github.com/llvm/llvm-project/commit/0057cc5a215e5a26cfbd7e1707b55bf05fa9b6bf DIFF:

[PATCH] D63852: [Clang] Move assembler into a separate file

aykevl added a comment. Well that didn't quite work. I get errors like this: tools/clang/lib/Frontend/CMakeFiles/obj.clangFrontend.dir/AssemblerInvocation.cpp.o:(.toc+0x0): undefined reference to `vtable for llvm::MCSubtargetInfo'

[PATCH] D63852: [Clang] Move assembler into a separate file

aykevl added a comment. Thanks! I have updated this patch to match LLVM main and committed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63852/new/ https://reviews.llvm.org/D63852 ___ cfe-commits

[PATCH] D63852: [Clang] Move assembler into a separate file

This revision was automatically updated to reflect the committed changes. Closed by commit rG2325157c0568: [Clang] Move assembler into a separate file (authored by aykevl). Changed prior to commit: https://reviews.llvm.org/D63852?vs=206769=318750#toc Repository: rG LLVM Github Monorepo

[clang] 2325157 - [Clang] Move assembler into a separate file

Author: Ayke van Laethem Date: 2021-01-23T14:34:23+01:00 New Revision: 2325157c0568ffd16f3318ad54f947e4e2109ef6 URL: https://github.com/llvm/llvm-project/commit/2325157c0568ffd16f3318ad54f947e4e2109ef6 DIFF:

[PATCH] D93040: [InlineFunction] Use llvm.experimental.noalias.scope.decl for noalias arguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b9a834c43cb: [InlineFunction] Use llvm.experimental.noalias.scope.decl for noalias arguments. (authored by jeroen.dobbelaere). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[clang] 2b9a834 - [InlineFunction] Use llvm.experimental.noalias.scope.decl for noalias arguments.

Author: Jeroen Dobbelaere Date: 2021-01-23T12:10:57+01:00 New Revision: 2b9a834c43cb1f93d33958c14b695896bb4e9c1e URL: https://github.com/llvm/llvm-project/commit/2b9a834c43cb1f93d33958c14b695896bb4e9c1e DIFF:

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

jasperswallen added a comment. Is there any possibility of this being merged/reimplemented? This is a big annoyance for our project right now. If needed, I can potentially take a look at redoing it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D27651/new/

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

dylanmckay accepted this revision. dylanmckay added a comment. This revision is now accepted and ready to land. Great patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93579/new/ https://reviews.llvm.org/D93579