[PATCH] D92290: [clangd] Factor out the heuristic resolver code into its own class

nridge added inline comments. Comment at: clang-tools-extra/clangd/HeuristicResolver.h:60 + // or more declarations that it likely references. + std::vector resolveExprToDecls(const Expr *E); + sammccall wrote: > This is pretty vaguely defined. From reading

[PATCH] D92290: [clangd] Factor out the heuristic resolver code into its own class

nridge updated this revision to Diff 318910. nridge marked 4 inline comments as done. nridge added a comment. Address (many of the) review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92290/new/ https://reviews.llvm.org/D92290 Files:

[PATCH] D95057: [clangd] Allow configuration database to be specified in config.

kadircet added a comment. I believe we should log some warning at startup if user has provided `--compile-commands-dir`. Saying that "CDB search customizations through config is disabled". (only emitting the warning when we hit a config with CDB search customization would be nicer, but

[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

wenlei accepted this revision. wenlei added a comment. This revision is now accepted and ready to land. lgtm, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95271/new/ https://reviews.llvm.org/D95271

[PATCH] D94583: [RISCV] Update V extension to v1.0-draft 08a0b464.

HsiangKai added a comment. In D94583#2514434 , @jrtc27 wrote: > In D94583#2513915 , @HsiangKai wrote: > >> In D94583#2513070 , @jrtc27 wrote: >> >>> There are a lot of

[PATCH] D95270: [clangd][NFC] Simplify handing on methods with no params

kadircet added a comment. thanks this LG, but I suppose we can do some more trimming. after the trimming we are introducing a single partial specialization which is luckily more specialized than existing notification-binding specialization, so all should be fine. Comment

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

benshi001 added a comment. committed as https://github.com/llvm/llvm-project/commit/89a5147e5a0c2e886cdf7ffa34799c069d825940 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93579/new/ https://reviews.llvm.org/D93579 ___ cfe-commits mailing

[clang] 89a5147 - [clang][AVR] Improve avr-ld command line options

Author: Ben Shi Date: 2021-01-25T12:01:26+08:00 New Revision: 89a5147e5a0c2e886cdf7ffa34799c069d825940 URL: https://github.com/llvm/llvm-project/commit/89a5147e5a0c2e886cdf7ffa34799c069d825940 DIFF: https://github.com/llvm/llvm-project/commit/89a5147e5a0c2e886cdf7ffa34799c069d825940.diff LOG:

[PATCH] D94403: [RISCV] Implement new architecture extension macros

kito-cheng accepted this revision. kito-cheng added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94403/new/ https://reviews.llvm.org/D94403 ___ cfe-commits mailing list

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer updated this revision to Diff 31. kentsommer added a comment. Undo some accidental comment formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files:

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2039 +**IncludeSortCaseAware** (``bool``) + Specify if sorting should be done in a case aware fashion. MyDeveloperDay wrote: > curdeius wrote: > > The name is somewhat

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer updated this revision to Diff 318886. kentsommer marked 5 inline comments as done. kentsommer added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files:

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93579/new/ https://reviews.llvm.org/D93579 ___ cfe-commits mailing list

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

benshi001 marked an inline comment as done. benshi001 added a comment. In D93579#2518307 , @MaskRay wrote: > If you remove your system GCC avr, does the test still work? This is the > criteria whether the patch is acceptable. Yes. The "make

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

benshi001 updated this revision to Diff 318881. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93579/new/ https://reviews.llvm.org/D93579 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/bin/avr-ld

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

hvdijk added a comment. In D91913#2518448 , @rsmith wrote: > Looks like this change matches the behavior of GCC all the way back to at > least GCC 4.1. Yes, it's worked this way in GCC ever since it was first introduced back when 3.3 was in

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4537935dcdb: Suppress non-conforming GNU paste extension in all standard-conforming modes (authored by hvdijk). Repository: rG LLVM Github

[clang] f453793 - Suppress non-conforming GNU paste extension in all standard-conforming modes

Author: Harald van Dijk Date: 2021-01-25T00:56:45Z New Revision: f4537935dcdbf390c863591cf556e76c3abab9c1 URL: https://github.com/llvm/llvm-project/commit/f4537935dcdbf390c863591cf556e76c3abab9c1 DIFF: https://github.com/llvm/llvm-project/commit/f4537935dcdbf390c863591cf556e76c3abab9c1.diff

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

tianshilei1992 updated this revision to Diff 318879. tianshilei1992 added a comment. rebase and prep for a new patch for CUDA instrinsics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94745/new/ https://reviews.llvm.org/D94745 Files:

[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

hoy updated this revision to Diff 318878. hoy added a comment. Addressing Wenleis' feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95271/new/ https://reviews.llvm.org/D95271 Files: clang/include/clang/Driver/Options.td

[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

hoy added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:609 + // Pass an option to enable pseudo probe emission. + if (Args.hasArg(options::OPT_fpseudo_probe_for_profiling)) +CmdArgs.push_back("-plugin-opt=pseudo-probe-for-profiling");

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

HsiangKai added a comment. D95016 focuses on the Clang RVV builtin generator and it depends on this commit. I know it is clumsy to list the combinations for vadd plainly, but it is a simple way to demonstrate how to add RVV builtins in Clang. Could we accept

[PATCH] D95307: [StaticAnalyzer] Add checking for degenerate base class in MemRegion

NoQ added reviewers: vsavchenko, xazax.hun, martong, kromanenkov. NoQ added a comment. Herald added a subscriber: rnkovacs. This patch shoots the messenger but someone still needs to conduct a proper investigation. The assertion is losing a lot more of its bug-finding power than necessary to

[PATCH] D95017: [clang-format] add case aware include sorting

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2039 +**IncludeSortCaseAware** (``bool``) + Specify if sorting should be done in a case aware fashion. curdeius wrote: > The name is somewhat awkward IMO (in the sense it

[PATCH] D94955: [clang-format] Treat ForEachMacros as loops

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:995 TEST_F(FormatTest, ForEachLoops) { verifyFormat("void f() {\n" + " foreach (Item *item, itemlist) {\n" I'd like you to assert that short loops are off

[PATCH] D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:13548 " {\n" "class A\n" " {\n" you are removing the test with 1 namespace nesting Repository: rG LLVM Github Monorepo

[PATCH] D94403: [RISCV] Implement new architecture extension macros

simoncook updated this revision to Diff 318869. simoncook added a comment. - Update to bitmanip 0.93 - Expand and support vector as per workaround in D95146 - Add negative testing (check __riscv_b not defined for just subextension) Repository: rG LLVM Github

[PATCH] D94930: [RISCV] Add support for Zvamo/Zvlsseg to driver

This revision was automatically updated to reflect the committed changes. Closed by commit rGafd483e57d16: [RISCV] Add support for Zvamo/Zvlsseg to driver (authored by simoncook). Changed prior to commit: https://reviews.llvm.org/D94930?vs=317408=318868#toc Repository: rG LLVM Github

[clang] afd483e - [RISCV] Add support for Zvamo/Zvlsseg to driver

Author: Simon Cook Date: 2021-01-24T22:07:56Z New Revision: afd483e57d166418e94a65bd9716e7dc4c114eed URL: https://github.com/llvm/llvm-project/commit/afd483e57d166418e94a65bd9716e7dc4c114eed DIFF: https://github.com/llvm/llvm-project/commit/afd483e57d166418e94a65bd9716e7dc4c114eed.diff LOG:

[PATCH] D95313: [WIP] Move part of nvptx devicertl under clang

tianshilei1992 added a comment. In general we're moving to the direction that target specific implementation will be compiled along with user code, which is fantastic. In this way, we only need to provide one bitcode library for one target. The change in FE lacks of some efficiency. If user

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf added a comment. In D93986#2518402 , @HazardyKnusperkeks wrote: > I did not re-accept this, because of the script change. I'm okay with it, but > I never looked really at the script. I think it should be changed afterwards > to error or warn

[PATCH] D95017: [clang-format] add case aware include sorting

curdeius added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2039 +**IncludeSortCaseAware** (``bool``) + Specify if sorting should be done in a case aware fashion. The name is somewhat awkward IMO (in the sense it doesn't read nicely),

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

HazardyKnusperkeks added a comment. Do you need someone to push this? If so please post email and name to use for the commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93846/new/ https://reviews.llvm.org/D93846

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks like this change matches the behavior of GCC all the way back to at least GCC 4.1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. I did not re-accept this, because of the script change. I'm okay with it, but I never looked really at the script. I think it should be changed afterwards to error or warn again, but not on this enum. Maybe one could

[PATCH] D95313: [WIP] Move part of nvptx devicertl under clang

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1204 +{ + auto *CTC = static_cast( + C.getSingleOffloadToolChain()); Logic very like this could pick out a second, small devicertl bitcode library

[PATCH] D95313: [WIP] Move part of nvptx devicertl under clang

JonChesterfield created this revision. JonChesterfield added reviewers: jdoerfert, tianshilei1992. Herald added subscribers: mgorny, jvesely. JonChesterfield requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald added projects: clang, OpenMP.

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf added a comment. In D93986#2518259 , @curdeius wrote: > Do you have commit access? Since this is my first contribution to LLVM ever, probably not. > If no, please write your Name Surname that should be used for > the commit. Lukas Barth

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

MaskRay added inline comments. Comment at: clang/test/Driver/avr-ld.c:46 + +int main() { return 0; } You can entirely delete the code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93579/new/ https://reviews.llvm.org/D93579

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

MaskRay added a comment. If you remove your system GCC avr, does the test still work? This is the criteria whether the patch is acceptable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93579/new/ https://reviews.llvm.org/D93579 ___

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

curdeius added a comment. Do you have commit access? If no, please write your Name Surname that should be used for the commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93986/new/ https://reviews.llvm.org/D93986

[PATCH] D95231: [clangd] Selection handles CXXBaseSpecifier

njames93 added inline comments. Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:272-283 + R"cpp( +struct Foo {}; +struct Bar : [[private Fo^o]] {}; + )cpp", + "CXXBaseSpecifier", + }, + {

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf added a comment. If I understand the LLVM mailing list correctly, everything in the repo by the 26th will still go into LLVM 12, right? Any chance we could get this in by then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93986/new/

[PATCH] D90157: [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way

steakhal added a comment. What you are basically doing is a visitation on the kind of the `SVal`. Why don't you use the `SValVisitor` instead? That way you could focus on the leaf nodes in the hierarchy, leaving you an even cleaner solution. class CastEvaluator : public SValVisitor {

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

hvdijk added a comment. Ping 4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91913/new/ https://reviews.llvm.org/D91913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D95307: [StaticAnalyzer] Add checking for degenerate base class in MemRegion

steakhal added a comment. Looks fine to me. Thank you for addressing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95307/new/ https://reviews.llvm.org/D95307 ___ cfe-commits mailing list

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

benshi001 updated this revision to Diff 318821. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93579/new/ https://reviews.llvm.org/D93579 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/bin/avr-ld

[PATCH] D95307: [StaticAnalyzer] Add checking for degenerate base class in MemRegion

RedDocMD created this revision. Herald added subscribers: steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, a.sidorin, szepet, baloghadamsoftware. RedDocMD requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In the function