[PATCH] D97137: Bug fix of https://bugs.llvm.org/show_bug.cgi?id=49175

darwin created this revision. darwin added a reviewer: clang-format. darwin added a project: clang-format. darwin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The AlignConsecutiveDeclarations option doesn't handle pointer properly: The

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

njames93 added inline comments. Herald added a subscriber: shchenz. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp:184 +bool AddComma = false; +if (!Ctor->getNumCtorInitializers() && FirstToCtorInits) { +

[PATCH] D93800: [clangd] Add caching behaviour for clang-format config

njames93 updated this revision to Diff 325267. njames93 added a comment. Update to support inheriting configurations from D93844 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93800/new/

[clang] b42d57a - [clang][Driver][OpenBSD] libcxx also requires pthread

Author: Brad Smith Date: 2021-02-20T20:53:25-05:00 New Revision: b42d57a100c5df6ace68f686f5adaabeafe8a0f6 URL: https://github.com/llvm/llvm-project/commit/b42d57a100c5df6ace68f686f5adaabeafe8a0f6 DIFF: https://github.com/llvm/llvm-project/commit/b42d57a100c5df6ace68f686f5adaabeafe8a0f6.diff

[PATCH] D96286: [clangd] Change TidyProvider cache to use a linked list approach

njames93 added a comment. Ping @sammccall Any issues with this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96286/new/ https://reviews.llvm.org/D96286 ___ cfe-commits mailing list

[PATCH] D96286: [clangd] Change TidyProvider cache to use a linked list approach

njames93 updated this revision to Diff 325266. njames93 added a comment. Update using absoluteParent helper Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96286/new/ https://reviews.llvm.org/D96286 Files:

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 added a comment. In D96853#2577133 , @aykevl wrote: > I am not very familiar with Clang so I can't say much about it. Although I > wonder whether a macro is the right way to implement this? Is there something > similar in other targets? (GPUs

[PATCH] D97132: [clang-tidy] Harden PreferMemberInitializerCheck

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, baloghadamsoftware, gribozavr2. Herald added subscribers: rnkovacs, kbarton, xazax.hun, nemanjai. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D97003: [Clang][OpenMP] Require CUDA 9.2+ for OpenMP offloading on NVPTX target

tianshilei1992 updated this revision to Diff 325262. tianshilei1992 added a comment. optimize error handle process Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97003/new/ https://reviews.llvm.org/D97003 Files:

[PATCH] D97003: [Clang][OpenMP] Require CUDA 9.2+ for OpenMP offloading on NVPTX target

tianshilei1992 updated this revision to Diff 325261. tianshilei1992 added a comment. update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97003/new/ https://reviews.llvm.org/D97003 Files:

[PATCH] D96838: Add GNU attribute 'retain'

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CodeGen/attr-retain.c:11 +/// Set !retain only on ELF platforms. +// NORETAIN-NOT: !retain + There are no `FileCheck

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

aykevl added a comment. I am not very familiar with Clang so I can't say much about it. Although I wonder whether the macro is the right way to implement this? Is there something similar in other targets? (GPUs tend to have lots of address spaces, you could take a look there).

[PATCH] D96147: [SEMA] Added warn_decl_shadow support for structured bindings

Vexthil updated this revision to Diff 325256. Vexthil added a comment. Fixing clang format issues. The SemaDecl.cpp has a pile of incorrect clang format issues but i've only updated changes relevant to changes I have made Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 557d2ad - [NFC] Refactor PreferMemberInitializerCheck

Author: Nathan James Date: 2021-02-20T23:35:58Z New Revision: 557d2ade016f3e228e90aab317b94f804e0bc1cd URL: https://github.com/llvm/llvm-project/commit/557d2ade016f3e228e90aab317b94f804e0bc1cd DIFF: https://github.com/llvm/llvm-project/commit/557d2ade016f3e228e90aab317b94f804e0bc1cd.diff LOG:

[PATCH] D96147: [SEMA] Added warn_decl_shadow support for structured bindings

Vexthil updated this revision to Diff 325252. Vexthil added a comment. Update with changes suggested by @rsmith . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96147/new/ https://reviews.llvm.org/D96147 Files: clang/docs/ReleaseNotes.rst

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:908 +CodeGenerator *CodeGenAction::getCodeGenerator() const { + return BEConsumer->getCodeGenerator(); lhames wrote: > v.g.vassilev wrote: > > sgraenitz wrote: > > >

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev updated this revision to Diff 325249. v.g.vassilev marked 7 inline comments as done. v.g.vassilev added a comment. Address Lang's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 Files:

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre created this revision. thopre added reviewers: kpn, efriedma, mibintc, sepavloff, rjmccall. Herald added a subscriber: pengfei. thopre requested review of this revision. Herald added a project: clang. __builtin_isinf currently generates a floating-point compare operation which triggers a

[PATCH] D96132: [clang-tidy] Simplify throw keyword missing check

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77056fe58e83: [clang-tidy] Simplify throw keyword missing check (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] 77056fe - [clang-tidy] Simplify throw keyword missing check

Author: Stephen Kelly Date: 2021-02-20T22:07:20Z New Revision: 77056fe58e83100b902216d7bc6274129f80abda URL: https://github.com/llvm/llvm-project/commit/77056fe58e83100b902216d7bc6274129f80abda DIFF: https://github.com/llvm/llvm-project/commit/77056fe58e83100b902216d7bc6274129f80abda.diff

[PATCH] D96131: [clang-tidy] Simplify function complexity check

This revision was automatically updated to reflect the committed changes. Closed by commit rG6852a29a3b5b: [clang-tidy] Simplify function complexity check (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D96131?vs=325226=325241#toc Repository: rG LLVM Github

[clang-tools-extra] 6852a29 - [clang-tidy] Simplify function complexity check

Author: Stephen Kelly Date: 2021-02-20T22:06:16Z New Revision: 6852a29a3b5b7858757c175f39e04676fb856dab URL: https://github.com/llvm/llvm-project/commit/6852a29a3b5b7858757c175f39e04676fb856dab DIFF: https://github.com/llvm/llvm-project/commit/6852a29a3b5b7858757c175f39e04676fb856dab.diff

[PATCH] D96224: [clang-itdy] Simplify virtual near-miss check

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a4b574dd6a0: [clang-itdy] Simplify virtual near-miss check (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96224/new/

[clang-tools-extra] 9a4b574 - [clang-itdy] Simplify virtual near-miss check

Author: Stephen Kelly Date: 2021-02-20T22:02:00Z New Revision: 9a4b574dd6a07d6811356529ebb8a3f15d6e40a2 URL: https://github.com/llvm/llvm-project/commit/9a4b574dd6a07d6811356529ebb8a3f15d6e40a2 DIFF: https://github.com/llvm/llvm-project/commit/9a4b574dd6a07d6811356529ebb8a3f15d6e40a2.diff

[PATCH] D97003: [Clang][OpenMP] Require CUDA 9.2+ for OpenMP offloading on NVPTX target

tianshilei1992 updated this revision to Diff 325235. tianshilei1992 added a comment. fixed the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97003/new/ https://reviews.llvm.org/D97003 Files:

[PATCH] D96224: [clang-itdy] Simplify virtual near-miss check

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. Fair enough, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96224/new/ https://reviews.llvm.org/D96224

[PATCH] D96838: Add GNU attribute 'retain'

MaskRay updated this revision to Diff 325233. MaskRay retitled this revision from "CodeGen: Set !retain metadata on UsedAttr definitions for FreeBSD/Fuchsia/Linux" to "Add GNU attribute 'retain'". MaskRay edited the summary of this revision. MaskRay added a comment. Herald added a reviewer:

[PATCH] D96224: [clang-itdy] Simplify virtual near-miss check

steveire added a comment. > What happens when TBase is an explicit specialization. It's not changed before or after this patch. This check is documented as changing code based on the derived classes based on typos of methods overridden from the base. Your suggestion makes sense to me, but it

[PATCH] D96224: [clang-itdy] Simplify virtual near-miss check

steveire updated this revision to Diff 325232. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96224/new/ https://reviews.llvm.org/D96224 Files: clang-tools-extra/clang-tidy/bugprone/VirtualNearMissCheck.cpp

[PATCH] D97003: [Clang][OpenMP] Require CUDA 9.2+ for OpenMP offloading on NVPTX target

tianshilei1992 updated this revision to Diff 325229. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97003/new/ https://reviews.llvm.org/D97003 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D97120: [Clang][OpenMP] Update driver test case for OpenMP offload to use sm_35

This revision was automatically updated to reflect the committed changes. Closed by commit rG33d660939d9a: [Clang][OpenMP] Update driver test case for OpenMP offload to use sm_35 (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 33d6609 - [Clang][OpenMP] Update driver test case for OpenMP offload to use sm_35

Author: Shilei Tian Date: 2021-02-20T15:14:13-05:00 New Revision: 33d660939d9acb027f9941f037802936124dad8c URL: https://github.com/llvm/llvm-project/commit/33d660939d9acb027f9941f037802936124dad8c DIFF: https://github.com/llvm/llvm-project/commit/33d660939d9acb027f9941f037802936124dad8c.diff

[PATCH] D97120: [Clang][OpenMP] Update driver test case for OpenMP offload to use sm_35

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. LG. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97120/new/ https://reviews.llvm.org/D97120

[PATCH] D96135: [clang-tidy] Simplify braced init check

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe8b8f8960246: [clang-tidy] Simplify braced init check (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] e8b8f89 - [clang-tidy] Simplify braced init check

Author: Stephen Kelly Date: 2021-02-20T20:09:13Z New Revision: e8b8f896024620eb86bf924be73100d83c74c736 URL: https://github.com/llvm/llvm-project/commit/e8b8f896024620eb86bf924be73100d83c74c736 DIFF: https://github.com/llvm/llvm-project/commit/e8b8f896024620eb86bf924be73100d83c74c736.diff

[PATCH] D96131: [clang-tidy] Simplify function complexity check

steveire updated this revision to Diff 325226. steveire added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96131/new/ https://reviews.llvm.org/D96131 Files:

[PATCH] D95746: clang: Exclude efi_main from -Wmissing-prototypes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7dd42ecfa2a2: clang: Exclude efi_main from -Wmissing-prototypes (authored by DaanDeMeyer). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 7dd42ec - clang: Exclude efi_main from -Wmissing-prototypes

Author: Daan De Meyer Date: 2021-02-20T20:00:50Z New Revision: 7dd42ecfa2a29bac89c965544c14b32805c8f02b URL: https://github.com/llvm/llvm-project/commit/7dd42ecfa2a29bac89c965544c14b32805c8f02b DIFF: https://github.com/llvm/llvm-project/commit/7dd42ecfa2a29bac89c965544c14b32805c8f02b.diff

[PATCH] D95746: clang: Exclude efi_main from -Wmissing-prototypes

dblaikie accepted this revision. dblaikie added a comment. Reaffirming approval with the test change - looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95746/new/ https://reviews.llvm.org/D95746

[PATCH] D95746: clang: Exclude efi_main from -Wmissing-prototypes

DaanDeMeyer added a comment. I should be able to commit it myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95746/new/ https://reviews.llvm.org/D95746 ___ cfe-commits mailing list

[PATCH] D95746: clang: Exclude efi_main from -Wmissing-prototypes

DaanDeMeyer updated this revision to Diff 325224. DaanDeMeyer added a comment. Moved the test into the no-warn-missing-prototype test as requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95746/new/ https://reviews.llvm.org/D95746 Files:

[PATCH] D97123: [clangd] Support FixIts that use InsertFromRange instead of inserting raw text

njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Currently clangd will ignore

[PATCH] D97119: [flang][driver] Add options for -std=2018

tskeith added a comment. Please make sure the test works with f18 also. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:294 +// We only allow 2018 as the given standard +if (standard.equals("2018")) { + res.SetStandard(); This should be

[PATCH] D96224: [clang-itdy] Simplify virtual near-miss check

njames93 added a comment. What happens when TBase is an explicit specialization. In that situation a warning for the explicit specialization may be useful. template <> struct TBase { virtual void tfunt(T t); }; Comment at:

[PATCH] D97120: [Clang][OpenMP] Update driver test case for OpenMP offload to use sm_35

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, JonChesterfield. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. `sm_35` is the minimum

[PATCH] D96131: [clang-tidy] Simplify function complexity check

steveire updated this revision to Diff 325216. steveire added a comment. Trigger rebuild Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96131/new/ https://reviews.llvm.org/D96131 Files:

[PATCH] D96131: [clang-tidy] Simplify function complexity check

njames93 added a comment. Can you have a look at the failed tests, they seem to be related. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96131/new/ https://reviews.llvm.org/D96131 ___ cfe-commits

[PATCH] D97095: [ASTMatchers] Fix hasUnaryOperand matcher for postfix operators

This revision was automatically updated to reflect the committed changes. Closed by commit rG559f3728441d: [ASTMatchers] Fix hasUnaryOperand matcher for postfix operators (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 559f372 - [ASTMatchers] Fix hasUnaryOperand matcher for postfix operators

Author: Stephen Kelly Date: 2021-02-20T17:54:12Z New Revision: 559f3728441d4b8342c71ef554d84a2804575d9d URL: https://github.com/llvm/llvm-project/commit/559f3728441d4b8342c71ef554d84a2804575d9d DIFF: https://github.com/llvm/llvm-project/commit/559f3728441d4b8342c71ef554d84a2804575d9d.diff

[PATCH] D96665: Revert "Implement nullPointerConstant() using a better API."

This revision was automatically updated to reflect the committed changes. Closed by commit rG6984e0d43985: Revert Implement nullPointerConstant() using a better API. (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6984e0d - Revert "Implement nullPointerConstant() using a better API."

Author: Stephen Kelly Date: 2021-02-20T17:33:07Z New Revision: 6984e0d4398592a20055cb12842fc72462ce01a5 URL: https://github.com/llvm/llvm-project/commit/6984e0d4398592a20055cb12842fc72462ce01a5 DIFF: https://github.com/llvm/llvm-project/commit/6984e0d4398592a20055cb12842fc72462ce01a5.diff

[PATCH] D96665: Revert "Implement nullPointerConstant() using a better API."

steveire added a comment. As discussed elsewhere, the bots are not broken. The changes reverted here were made in 2019. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96665/new/ https://reviews.llvm.org/D96665

[PATCH] D96132: [clang-tidy] Simplify throw keyword missing check

steveire added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-throw-keyword-missing.cpp:97-107 +template +void templ(int i) { + if (i > 0) +SomeType(); +} + void funcCallWithTempExcTest() { steveire wrote: > njames93

[PATCH] D96132: [clang-tidy] Simplify throw keyword missing check

steveire added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-throw-keyword-missing.cpp:97-107 +template +void templ(int i) { + if (i > 0) +SomeType(); +} + void funcCallWithTempExcTest() { njames93 wrote: > Can I ask

[PATCH] D96131: [clang-tidy] Simplify function complexity check

steveire added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:505 + functionDecl(isDefinition(), unless(isWeak())).bind("func"), this); + Finder->addMatcher(lambdaExpr().bind("lambda"), this); }

[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

jlebar added a comment. Thank you for the review! I'll put a note in my cal to land this in a few days if I don't hear from @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95754/new/ https://reviews.llvm.org/D95754

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2576679 , @alsoijw wrote: > In D52050#2369838 , @dschuff wrote: > >> One other question then: do you know if Debian and/or Ubuntu still have the >> same support for running x32

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 325208. arnamoy10 added a comment. Updating the test case to include `-fc1` as well CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 Files: clang/include/clang/Driver/Options.td

[PATCH] D97119: [flang][driver] Add options for -std=2018

arnamoy10 created this revision. arnamoy10 added reviewers: awarzynski, sscalpone, clementval, tskeith. Herald added subscribers: jansvoboda11, dang. arnamoy10 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add support for the following

[PATCH] D96131: [clang-tidy] Simplify function complexity check

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:505 + functionDecl(isDefinition(), unless(isWeak())).bind("func"), this); + Finder->addMatcher(lambdaExpr().bind("lambda"), this); }

[PATCH] D96132: [clang-tidy] Simplify throw keyword missing check

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-throw-keyword-missing.cpp:97-107 +template +void templ(int i) { + if (i > 0) +SomeType(); +} + void funcCallWithTempExcTest() { Can I ask what the reason for

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

alsoijw added a comment. In D52050#2369838 , @dschuff wrote: > One other question then: do you know if Debian and/or Ubuntu still have the > same support for running x32 programs on the regular x86-64 distribution? I am not sure that I right understand

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:874 /// [C++0x] static_assert-declaration: /// static_assert ( constant-expression , string-literal ) ; /// xbolva00 wrote: > Do we warn for: > > static_assert(“my

[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

aaronpuchert accepted this revision. aaronpuchert added a comment. This revision is now accepted and ready to land. Thanks, this looks good to me. Maybe wait a few days whether @rsmith has a comment before you land it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

xbolva00 added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:874 /// [C++0x] static_assert-declaration: /// static_assert ( constant-expression , string-literal ) ; /// Do we warn for: static_assert(“my msg”)? I remember some

[PATCH] D96974: [clang][patch] Inclusive language, modify filename SanitizerBlacklist.h to NoSanitizeList.h

mibintc updated this revision to Diff 325191. mibintc added a comment. Herald added a subscriber: mgorny. What do you recommend as next steps, incrementally? Is there more clarity about option names? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96974: [clang][patch] Inclusive language, modify filename SanitizerBlacklist.h to NoSanitizeList.h

mibintc added inline comments. Comment at: clang/lib/Basic/SanitizerBlacklist.cpp:15 #include "clang/Basic/FileManager.h" +#include "clang/Basic/NoSanitizeList.h" #include "clang/Basic/SanitizerSpecialCaseList.h" vitalybuka wrote: > dexonsmith wrote: > >

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

aaron.ballman added a comment. In D89065#2320031 , @njames93 wrote: > I don't see any support for verifying fix-its in the test cases so unsure how > i could go about testing this change. We usually test fix-its with `-fdiagnostics-parseable-fixits` as

Re: [PATCH] [clang-tidy] ensure run-clang-tidy reports children killed by signals

Hi Alexander, Would it be better if I signed up for Phabricator and sent this there? I was trying to avoid signing up to yet another service if it wasn't strictly needed but happy to do it if that's what is expected. Thanks, Ian On Thu, 2021-02-11 at 10:22 +, Ian Campbell wrote: If a

[PATCH] D96906: [AMDGPU] gfx90a support

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp:191-199 + MCRegister RepReg; + for (MCRegister R : *MRI->getRegClass(Reg)) { +if (!MRI->isReserved(R)) { + RepReg = R; + break; +} + } rampitec wrote:

[PATCH] D96906: [AMDGPU] gfx90a support

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp:191-199 + MCRegister RepReg; + for (MCRegister R : *MRI->getRegClass(Reg)) { +if (!MRI->isReserved(R)) { + RepReg = R; + break; +} + } arsenm wrote: >

[PATCH] D96906: [AMDGPU] gfx90a support

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp:191-199 + MCRegister RepReg; + for (MCRegister R : *MRI->getRegClass(Reg)) { +if (!MRI->isReserved(R)) { + RepReg = R; + break; +} + } rampitec wrote: >

[PATCH] D96906: [AMDGPU] gfx90a support

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp:191-199 + MCRegister RepReg; + for (MCRegister R : *MRI->getRegClass(Reg)) { +if (!MRI->isReserved(R)) { + RepReg = R; + break; +} + } arsenm wrote: >

[PATCH] D96906: [AMDGPU] gfx90a support

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp:191-199 + MCRegister RepReg; + for (MCRegister R : *MRI->getRegClass(Reg)) { +if (!MRI->isReserved(R)) { + RepReg = R; + break; +} + } rampitec wrote: >

[PATCH] D97109: [clangd] Add support for auxiliary triple specification

oToToT added inline comments. Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:311 llvm::ErrorOr PrecompiledPreamble::Build( const CompilerInvocation , Though this file is in clang, clangd use this function to prepare preamble in `Preamble.cpp`,

[PATCH] D97109: [clangd] Add support for auxiliary triple specification

oToToT updated this revision to Diff 325186. oToToT added a comment. re-upload diff with full context, sorry for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97109/new/ https://reviews.llvm.org/D97109 Files:

[PATCH] D97109: [clangd] Add support for auxiliary triple specification

njames93 added a comment. Please upload diffs with full context. This can be done by passing `-U99` to diff or by using arcanist to upload your patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

sepavloff added inline comments. Comment at: clang/include/clang/Driver/Driver.h:210 + /// Set CC_PRINT_PROC_STAT mode, which causes the frontend to dump + /// performance report to CC_PRINT_PROC_STAT_FILE or to stdout. Strictly speaking it is driver that

[PATCH] D96110: [X86] Pass to transform tdpbf16ps intrinsics to scalar operation.

yubing updated this revision to Diff 325170. yubing edited the summary of this revision. yubing added a comment. Address comments above and refactor some code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96110/new/ https://reviews.llvm.org/D96110

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

LuoYuanke added inline comments. Comment at: llvm/include/llvm/CodeGen/Passes.h:496 + + FunctionPass *createX86LowerAMXIntrinsicsPass(); } // End llvm namespace Add comments to describe what the pass does? Comment at:

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

azabaznov marked 3 inline comments as done. azabaznov added inline comments. Comment at: clang/lib/Basic/OpenCLOptions.cpp:24 + auto CLVer = LO.OpenCLCPlusPlus ? 200 : LO.OpenCLVersion; + return CLVer >= 300 ? isEnabled("__opencl_c_fp64") : isEnabled("cl_khr_fp64"); +}

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:71 +OPENCL_EXTENSION(cl_khr_int64_extended_atomics, true, 100) +OPENCL_COREFEATURE(cl_khr_3d_image_writes, true, 100, OCL_C_20) Anastasia wrote: > azabaznov wrote: > >