[PATCH] D97577: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions.

lebedev.ri added a comment. It is best not to change existing tests, but add new ones. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97577/new/ https://reviews.llvm.org/D97577 ___ cfe-commits mailing

[PATCH] D96803: EntryExitInstrumenter: Enable at all optimization levels (PR49143)

aeubanks added a comment. Alternatively: https://reviews.llvm.org/D97608 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96803/new/ https://reviews.llvm.org/D96803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97608: Move EntryExitInstrumentation pass location

aeubanks created this revision. Herald added subscribers: nikic, pengfei, hiraditya. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This seems to be more of a Clang thing rather than a generic LLVM thing, so

[clang] 2e2ee43 - [test] Add -triple x86_64 to attr-retain.cpp

Author: Fangrui Song Date: 2021-02-26T19:35:53-08:00 New Revision: 2e2ee4300d1f9766209d435c0d8c44c72092b974 URL: https://github.com/llvm/llvm-project/commit/2e2ee4300d1f9766209d435c0d8c44c72092b974 DIFF: https://github.com/llvm/llvm-project/commit/2e2ee4300d1f9766209d435c0d8c44c72092b974.diff

[PATCH] D97606: [Clang interpreter] Avoid storing pointers at unaligned locations

jrtc27 added a comment. Is there any way I can usefully test this? As far as I can tell there's only a single constexpr test in the tree that uses the new interpreter, and it's pretty trivial? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

jrtc27 added a comment. In D64146#2591830 , @jrtc27 wrote: > In D64146#2591732 , @jrtc27 wrote: > >> In D64146#2567710 , @nand wrote: >> >>> CodePtr points into the bytecode

[PATCH] D97606: [Clang interpreter] Avoid storing pointers at unaligned locations

jrtc27 updated this revision to Diff 326872. jrtc27 added a comment. Reworked code slightly to make it look nicer after clang-format uglified it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97606/new/ https://reviews.llvm.org/D97606 Files:

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:477 + StringRef Message = D.getMessage(); + if (Message.startswith("error: ")) +Message = Message.substr(7); `StringRef::consume_front` I know you are moving code, but do you

[PATCH] D97606: [Clang interpreter] Avoid storing pointers at unaligned locations

jrtc27 created this revision. jrtc27 added reviewers: nand, jfb, Bigcheese, rsmith, dexonsmith. Herald added subscribers: kristof.beyls, arichardson. jrtc27 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The Clang interpreter's bytecode

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

MaskRay added a comment. I am supportive of getting rid of InlineAsmDiagnosticHandler, too. The updated AMDGPU tests suggeste that previously `MCContext::reportError` may be called with no `SrcMgr` or `InlineSrcMgr`, so the error is propagated to the temporary `SourceMgr()`. The

[PATCH] D97605: [Lifetimes] Fix false positive warning from BUG 49342

xazax.hun created this revision. xazax.hun added reviewers: rsmith, mgehre. xazax.hun added a project: clang. Herald added subscribers: Charusso, gamesh411, Szelethus, dkrupp, rnkovacs. xazax.hun requested review of this revision. Herald added a subscriber: cfe-commits. After some interaction

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

nickdesaulniers added a comment. I tested this on some wacko LTO kernel build failure (https://github.com/ClangBuiltLinux/linux/issues/1269). The error message went from: > :0: error: __ia32_compat_sys_sysctl changed binding to STB_GLOBAL To: unimplemented UNREACHABLE executed at

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

jrtc27 added a comment. In D64146#2591732 , @jrtc27 wrote: > In D64146#2567710 , @nand wrote: > >> CodePtr points into the bytecode emitted by the byte code compiler. In some >> instances, pointers to auxiliary

[clang] 9e0d550 - [clang][NFC] Clean up whitespace in ClangOpcodesEmitter output

Author: Jessica Clarke Date: 2021-02-27T01:28:56Z New Revision: 9e0d55024d4ed776f209ee04e260bdd314854993 URL: https://github.com/llvm/llvm-project/commit/9e0d55024d4ed776f209ee04e260bdd314854993 DIFF: https://github.com/llvm/llvm-project/commit/9e0d55024d4ed776f209ee04e260bdd314854993.diff

[clang] a0c1cd6 - [test] Add -triple x86_64 to attr-retain.c

Author: Fangrui Song Date: 2021-02-26T17:26:26-08:00 New Revision: a0c1cd642da51ab8f471d2dd5ba905cf81760187 URL: https://github.com/llvm/llvm-project/commit/a0c1cd642da51ab8f471d2dd5ba905cf81760187 DIFF: https://github.com/llvm/llvm-project/commit/a0c1cd642da51ab8f471d2dd5ba905cf81760187.diff

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

jrtc27 added a comment. In D64146#2567710 , @nand wrote: > CodePtr points into the bytecode emitted by the byte code compiler. In some > instances, pointers to auxiliary data structures are embedded into the byte > code, such as functions or AST nodes

[PATCH] D97447: Add GNU attribute 'retain'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8afdacba9dcd: Add GNU attribute retain (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D97447?vs=326766=326839#toc

[clang] 8afdacb - Add GNU attribute 'retain'

Author: Fangrui Song Date: 2021-02-26T16:37:50-08:00 New Revision: 8afdacba9dcd36fc838eb86fca86f7f903040030 URL: https://github.com/llvm/llvm-project/commit/8afdacba9dcd36fc838eb86fca86f7f903040030 DIFF: https://github.com/llvm/llvm-project/commit/8afdacba9dcd36fc838eb86fca86f7f903040030.diff

[clang] 233ba27 - [Driver] Fix a warning about the the initialization order

Author: Kazu Hirata Date: 2021-02-26T16:32:30-08:00 New Revision: 233ba2709bde54ea820cdaba0405d46b2c197e01 URL: https://github.com/llvm/llvm-project/commit/233ba2709bde54ea820cdaba0405d46b2c197e01 DIFF: https://github.com/llvm/llvm-project/commit/233ba2709bde54ea820cdaba0405d46b2c197e01.diff

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

This revision was automatically updated to reflect the committed changes. Closed by commit rG155c49e0878d: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable. (authored by vvereschaka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 155c49e - [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

Author: Vladimir Vereschaka Date: 2021-02-26T16:16:00-08:00 New Revision: 155c49e0878de667b8021b9ba685390151dee11e URL: https://github.com/llvm/llvm-project/commit/155c49e0878de667b8021b9ba685390151dee11e DIFF:

[PATCH] D95409: [clang] implicitly delete space ship operator with function pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a8530fc3039: [clang] implicitly delete space ship operator with function pointers (authored by mizvekov, committed by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4a8530f - [clang] implicitly delete space ship operator with function pointers

Author: Matheus Izvekov Date: 2021-02-26T16:03:01-08:00 New Revision: 4a8530fc3039f128eddc38737f0172bb3d489bcf URL: https://github.com/llvm/llvm-project/commit/4a8530fc3039f128eddc38737f0172bb3d489bcf DIFF:

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

jdenny added a comment. In D94973#2591210 , @Meinersbur wrote: > In D94973#2590867 , @jdenny wrote: > >> One property of this patch that has bothered me is that OMPCanonicalLoop is >> not a loop. Instead, it's an

[PATCH] D97417: [clangd] use a compatible preamble for the first AST built

qchateau updated this revision to Diff 326816. qchateau added a comment. - [clangd] make more compile commands compatible - [clangd] ignore incompatible preamble I improved command line compatibility detection (faster & matches more files) and I had to blacklist some preambles. Namely, when

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

vitalybuka added a comment. >> This is intended as a step to porting scudo standalone. Why this is needed for scudo stadalone? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96120/new/ https://reviews.llvm.org/D96120

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

mstorsjo added a comment. In D96120#2590587 , @russell.gallop wrote: > Hi @mstorsjo. Thanks for the suggestions. I tried running up an mingw > environment with msys but had trouble getting it working (running into cmake > issues). Would you be able to

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

flx updated this revision to Diff 326798. flx added a comment. Add tests for PerformanceUnnecssaryCopyInitialization check which actually uses decl_ref_expr::isOnlyUsedAsConst(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen updated this revision to Diff 326797. ychen added a comment. - Simplify MCContext changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97449/new/ https://reviews.llvm.org/D97449 Files: clang/lib/CodeGen/CodeGenAction.cpp

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added a comment. In D94973#2590867 , @jdenny wrote: > One property of this patch that has bothered me is that OMPCanonicalLoop is > not a loop. Instead, it's an AST node that is sandwiched between a directive > and a loop to contain extra

[PATCH] D97577: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions.

flx updated this revision to Diff 326793. flx added a comment. Remove include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97577/new/ https://reviews.llvm.org/D97577 Files: clang-tools-extra/clang-tidy/performance/ForRangeCopyCheck.cpp

[PATCH] D97577: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions.

flx updated this revision to Diff 326792. flx added a comment. Remove include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97577/new/ https://reviews.llvm.org/D97577 Files: clang-tools-extra/clang-tidy/performance/ForRangeCopyCheck.cpp

[PATCH] D97577: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions.

flx created this revision. flx added reviewers: aaron.ballman, alexfh, sbenza. Herald added a subscriber: xazax.hun. flx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This disables the check for false positive cases where implicit type

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang updated this revision to Diff 326787. akhuang marked 3 inline comments as done. akhuang added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/ https://reviews.llvm.org/D97411 Files:

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a comment. In D97411#2591030 , @aaron.ballman wrote: > Thanks! I am still curious about the forward declare/redeclaration behavior > and whether that is a situation that makes sense or not. I suspect this case > may make sense (and likely

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

dblaikie added a comment. In D97411#2591030 , @aaron.ballman wrote: > Thanks! I am still curious about the forward declare/redeclaration behavior > and whether that is a situation that makes sense or not. I suspect this case > may make sense (and

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

djtodoro added a comment. Ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D84924: [clang-tidy] Added command line option `fix-notes`

njames93 updated this revision to Diff 326779. njames93 marked 6 inline comments as done. njames93 added a comment. Rebased and address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84924/new/ https://reviews.llvm.org/D84924 Files:

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

ldionne added a comment. In D97411#2588181 , @akhuang wrote: > @ldionne Do you think it'd be reasonable to add this debug info attribute to > some types in libc++? (For types that have constructors but don't call them; > some previous discussion in

[PATCH] D97574: [AIX][clang][driver] Restrict /usr/lib to internal library search paths

daltenty created this revision. daltenty added reviewers: hubert.reinterpretcast, stevewan, jasonliu. daltenty requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adding it to the general filepaths results in it being added to the linker

[PATCH] D96744: clang-format IncludeBlocks: Regroup determination of "main" for framework-style includes fix

poelmanc added a comment. In D96744#2564828 , @MyDeveloperDay wrote: > Does this need to be an option? It's easy to add an option, but there are already two //main include//-related options, so before adding a third I wanted to give this some thought.

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

aaron.ballman added a comment. Thanks! I am still curious about the forward declare/redeclaration behavior and whether that is a situation that makes sense or not. I suspect this case may make sense (and likely already works): // Should test redeclaration behavior. struct

[PATCH] D97573: [OpenMP] Handle non-function context before checking for diagnostic emission

pmrao created this revision. pmrao added reviewers: ABataev, bader, erichkeane, jdoerfert. Herald added subscribers: guansong, yaxunl. pmrao requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Ensure that we are in a function declaration context

[PATCH] D97534: SEH: capture 'this'

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97534/new/ https://reviews.llvm.org/D97534 ___ cfe-commits mailing list

[PATCH] D97513: Add ConfigVersion.cmake files

alexreinking added a comment. So with this patch, I tried to imitate the existing code as much as possible. However, I think it would be quite a bit better to use the `write_basic_package_version_file` command from `CMakePackageConfigHelpers`. It gained support for major + minor version

[PATCH] D97447: Add GNU attribute 'retain'

MaskRay updated this revision to Diff 326766. MaskRay added a comment. Improve doc as rnk suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97447/new/ https://reviews.llvm.org/D97447 Files: clang/include/clang/Basic/Attr.td

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:66 +// element type which is bool +// 0: void type, ignores "t" +// z: size_t, ignores "t" jrtc27 wrote: > craig.topper wrote: > > jrtc27 wrote: > > > khchen

[PATCH] D95984: [CodeGen] Fix codegen for __attribute__((swiftasynccall)).

varungandhi-apple updated this revision to Diff 326762. varungandhi-apple added a comment. Added checks for C++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95984/new/ https://reviews.llvm.org/D95984 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D97447: Add GNU attribute 'retain'

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm with a minor doc tweak My reading of the discussion is that this is ready, but please wait for others if you are aware of any outstanding concerns. Comment at:

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

jrtc27 added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:66 +// element type which is bool +// 0: void type, ignores "t" +// z: size_t, ignores "t" craig.topper wrote: > jrtc27 wrote: > > khchen wrote: > > > jrtc27 wrote: > >

[PATCH] D97119: [flang][driver] Add options for -std=2018

arnamoy10 updated this revision to Diff 326760. arnamoy10 added a comment. 1. Updated the test case to include a check when the option is not given and make sure works with f18 as well (with `Mstandard`) 2. Changed variable names as suggested. CHANGES SINCE LAST ACTION

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:259-260 + +LMULType ::operator*=(unsigned RHS) { + this->Log2LMUL = this->Log2LMUL + RHS; + return *this; jrtc27 wrote: > That's not how multiplication works. This is

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

jrtc27 added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:567 + // Compute type transformers + for (char I : Transformer.take_front(Transformer.size() - 1)) { +switch (I) { craig.topper wrote: > jrtc27 wrote: > > craig.topper wrote:

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:567 + // Compute type transformers + for (char I : Transformer.take_front(Transformer.size() - 1)) { +switch (I) { jrtc27 wrote: > craig.topper wrote: > > Can we do

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper requested changes to this revision. craig.topper added a comment. This revision now requires changes to proceed. Dropping my approval pending @jrtc27 comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

jrtc27 added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:116 + D = 1 << 2, + ZFH = 1 << 3 +}; Zfh Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:241 + case 8: +ExpResult = Log2LMUL + 3; +break;

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:66 +// element type which is bool +// 0: void type, ignores "t" +// z: size_t, ignores "t" jrtc27 wrote: > khchen wrote: > > jrtc27 wrote: > > > Then why aren't

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

jdenny added a comment. One property of this patch that has bothered me is that OMPCanonicalLoop is not a loop. Instead, it's an AST node that is sandwiched between a directive and a loop to contain extra information about the loop. The TreeTransform issues we've been discussing highlight

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

NoQ added a comment. The warning should be emitted but it shouldn't have a note at `P.get()` telling the user that an inner pointer was obtained. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

jrtc27 added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:56 +// +// e: type of "t" as is (identity) +// v: computes a vector type whose element type is "t" for the current LMUL khchen wrote: > jrtc27 wrote: > > Do we really need to

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

flx created this revision. flx added reviewers: aaron.ballman, sbenza. Herald added a subscriber: xazax.hun. flx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Until now when determining all the const uses of a VarDecl we only considered

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

cjdb marked an inline comment as done. cjdb added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10326 + !isa( + Cast->getSubExpr()->IgnoreImplicitAsWritten()->IgnoreParens())) +return; cjdb wrote: > aaron.ballman wrote: > > I'm

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

cjdb updated this revision to Diff 326748. cjdb added a comment. `s/IgnoreImplicitAsWritten/IgnoreParenImpCasts/` since the latter seems to work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97512/new/ https://reviews.llvm.org/D97512 Files:

[PATCH] D97488: [clang-tidy][NFC] Tweak some generation of diag messages

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a721b6a2634: [clang-tidy][NFC] Tweak some generation of diag messages (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97488/new/

[clang-tools-extra] 1a721b6 - [clang-tidy][NFC] Tweak some generation of diag messages

Author: Nathan James Date: 2021-02-26T19:10:25Z New Revision: 1a721b6a2634d9740b389a7604275b426c22600a URL: https://github.com/llvm/llvm-project/commit/1a721b6a2634d9740b389a7604275b426c22600a DIFF: https://github.com/llvm/llvm-project/commit/1a721b6a2634d9740b389a7604275b426c22600a.diff LOG:

[PATCH] D97544: [clang-tidy] Remove some test c++ mode restrictions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb18f14d6897b: [clang-tidy] Remove some test c++ mode restrictions. (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97544/new/

[clang-tools-extra] b18f14d - [clang-tidy] Remove some test c++ mode restrictions.

Author: Nathan James Date: 2021-02-26T19:09:28Z New Revision: b18f14d6897b9e9f34ffd0d8ed46b8ac596fbf05 URL: https://github.com/llvm/llvm-project/commit/b18f14d6897b9e9f34ffd0d8ed46b8ac596fbf05 DIFF: https://github.com/llvm/llvm-project/commit/b18f14d6897b9e9f34ffd0d8ed46b8ac596fbf05.diff LOG:

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-concat-nested-namespaces.cpp:4 +// RUN: FileCheck -input-file=%T/modernize-concat-nested-namespaces.h

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:908 + +// Compute Buitlin types +SmallVector ProtoMaskSeq = ProtoSeq;

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

cjdb added a subscriber: rsmith. cjdb added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10320 + + const clang::CastKind Kind = Cast->getCastKind(); + if (Kind == clang::CK_BitCast && aaron.ballman wrote: > We don't typically use top-level

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

cjdb updated this revision to Diff 326742. cjdb marked 2 inline comments as done. cjdb added a comment. applies comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97512/new/ https://reviews.llvm.org/D97512 Files:

[PATCH] D97488: [clang-tidy][NFC] Tweak some generation of diag messages

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thanks, these are really nice cleanups! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97488/new/

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28cb620321f5: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 28cb620 - Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

Author: Fangrui Song Date: 2021-02-26T10:42:07-08:00 New Revision: 28cb620321f5461255423f84c85e6891b5174c13 URL: https://github.com/llvm/llvm-project/commit/28cb620321f5461255423f84c85e6891b5174c13 DIFF: https://github.com/llvm/llvm-project/commit/28cb620321f5461255423f84c85e6891b5174c13.diff

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

MaskRay updated this revision to Diff 326739. MaskRay added a comment. Simplify with `CodeGenModule::getTriple()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97446/new/ https://reviews.llvm.org/D97446 Files: clang/lib/CodeGen/CGDecl.cpp

[PATCH] D97553: [clang][NFC] pack StaticDiagInfoRec

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Basic/DiagnosticIDs.cpp:171 const StaticDiagInfoRec StaticDiagInfo[] = { +// clang-format off #define DIAG(ENUM, CLASS,

[PATCH] D97566: [WIP][RGT] Rotten Green Test checking for LLVM and Clang unittests

probinson created this revision. probinson added reviewers: MaskRay, dblaikie. Herald added a subscriber: mgrang. probinson requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. This is an enhancement of the 'googletest' support code, to

[PATCH] D97447: Add GNU attribute 'retain'

MaskRay added a comment. I have performed a large-scale internal test. I don't find any problem with a toolchain built with D97446 /D97447 /D97448 . Repository: rG LLVM Github Monorepo

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang updated this revision to Diff 326738. akhuang marked an inline comment as done. akhuang added a comment. -Add documentation -Add more test cases and semantics tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD marked an inline comment as done. RedDocMD added a comment. In D97183#2589445 , @NoQ wrote: > Nice! > > I suspect you're adding too many notes. The note needs to not be there if the > *raw* pointer is not tracked. Eg., I suspect that your patch

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

DmitryPolukhin marked an inline comment as done. DmitryPolukhin added a comment. @njames93 thank you for quick response and good suggestion! Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-concat-nested-namespaces.cpp:4 +// RUN: FileCheck

[PATCH] D97544: [clang-tidy] Remove some test c++ mode restrictions.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97544/new/ https://reviews.llvm.org/D97544

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

DmitryPolukhin updated this revision to Diff 326734. DmitryPolukhin added a comment. Comments resolved Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97563/new/ https://reviews.llvm.org/D97563 Files:

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD updated this revision to Diff 326733. RedDocMD added a comment. Removed unnecessary includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96976/new/ https://reviews.llvm.org/D96976 Files:

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka updated this revision to Diff 326729. vvereschaka added a comment. Updated diff: - updated doc parts @aganea thanks a lot for your suggestions for doc improvements. I have updated it accordingly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10320 + + const clang::CastKind Kind = Cast->getCastKind(); + if (Kind == clang::CK_BitCast && We don't typically use top-level `const` on locals or params.

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD added a comment. @steakhal, you are absolutely right! It works. Thank you for pointing it out, not sure how I missed this earlier this evening. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96976/new/ https://reviews.llvm.org/D96976

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD updated this revision to Diff 326731. RedDocMD added a comment. Replaced BFS with existing CXXRecordDeclMethod Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96976/new/ https://reviews.llvm.org/D96976 Files:

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/modernize-concat-nested-namespaces/modernize-concat-nested-namespaces.h:7 +} // namespace nn1 +// CHECK-FIXES: } This fix line isn't actually contributing to the test.

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:8321 +TreeTransform::TransformOMPCanonicalLoop(OMPCanonicalLoop *L) { + // The OMPCanonicalLoop will be recreated when transforming the loop-associted + // directive. jdenny wrote: >

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

russell.gallop marked 2 inline comments as done. russell.gallop added a comment. In D96120#2550941 , @mstorsjo wrote: > In D96120#2550876 , @russell.gallop > wrote: > >> In D96120#2546077

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: hokein, aaron.ballman, alexfh, JonasToth, njames93. DmitryPolukhin added a project: clang. Herald added a subscriber: xazax.hun. DmitryPolukhin requested review of this revision. For some reason the initial implementation of

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

cjdb added a comment. In D94640#2590512 , @thakis wrote: > This seems to flag > https://source.chromium.org/chromium/chromium/src/+/master:third_party/libsync/src/sync.c;l=142?q=sync.c=chromium > : > > info->sync_fence_info = (uint64_t)

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

cjdb updated this revision to Diff 326723. cjdb edited the summary of this revision. cjdb added a comment. updates commit message to explain what's going on and why the change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97512/new/

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:279 SymbolSlabs.push_back(FileAndSymbols.second); + for (const auto : *FileAndSymbols.second) { +if (S.Definition) iterating over all the symbols here

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman updated this revision to Diff 326719. dgoldman marked an inline comment as done. dgoldman added a comment. Limit changes to document symbols Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96612/new/ https://reviews.llvm.org/D96612 Files:

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

russell.gallop updated this revision to Diff 326716. russell.gallop added a comment. Added comment on AllocatorSize. Applied Mingw changes suggested by @mstorsjo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96120/new/

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

thakis added a comment. This seems to flag https://source.chromium.org/chromium/chromium/src/+/master:third_party/libsync/src/sync.c;l=142?q=sync.c=chromium : info->sync_fence_info = (uint64_t) calloc(num_fences, sizeof(struct sync_fence_info)); if ((void

[PATCH] D97561: [clang] Use CompilerInstance::createTarget to createTarget

oToToT added inline comments. Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:368 // Create the target instance. - Clang->setTarget(TargetInfo::CreateTargetInfo( - Clang->getDiagnostics(), Clang->getInvocation().TargetOpts)); - if (!Clang->hasTarget()) + if

[PATCH] D97561: [clang] Use CompilerInstance::createTarget to createTarget

oToToT created this revision. oToToT added reviewers: sammccall, rsmith, klimek, dexonsmith. oToToT added a project: clang. oToToT requested review of this revision. Herald added a subscriber: cfe-commits. As proposed in D97109 , I tried to replace all similar

  1   2   >