[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

jansvoboda11 added a comment. In D97743#2614899 , @MaskRay wrote: > Move to driver Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97743/new/ https://reviews.llvm.org/D97743

[PATCH] D98251: [-Wcompletion-handler] Extend list of detected conventions

vsavchenko added a comment. In D98251#2615049 , @NoQ wrote: > Looks all clear. > > In that document there's also a clause that the conventional completion > handler discovered through its suffix has to be the //last// parameter. I > don't immediately see

[PATCH] D98244: [analyzer] Fix StdLibraryFunctionsChecker performance issue

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc7635040ce0a: [analyzer] Fix StdLibraryFunctionsChecker performance issue (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES S

[clang] c763504 - [analyzer] Fix StdLibraryFunctionsChecker performance issue

Author: Valeriy Savchenko Date: 2021-03-10T10:44:04+03:00 New Revision: c7635040ce0a546020cbcd9f2030817725bd7494 URL: https://github.com/llvm/llvm-project/commit/c7635040ce0a546020cbcd9f2030817725bd7494 DIFF: https://github.com/llvm/llvm-project/commit/c7635040ce0a546020cbcd9f2030817725bd7494.d

[PATCH] D98251: [-Wcompletion-handler] Extend list of detected conventions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG59112eacb979: [-Wcompletion-handler] Extend list of detected conventions (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] 59112ea - [-Wcompletion-handler] Extend list of detected conventions

Author: Valeriy Savchenko Date: 2021-03-10T10:43:19+03:00 New Revision: 59112eacb97910601504d4ce5115b2d535bcbeb6 URL: https://github.com/llvm/llvm-project/commit/59112eacb97910601504d4ce5115b2d535bcbeb6 DIFF: https://github.com/llvm/llvm-project/commit/59112eacb97910601504d4ce5115b2d535bcbeb6.d

[PATCH] D98321: [NFC] Unify FIME with FIXME in comments

b1f6c1c4 added a comment. I do NOT have commit access so it would be nice if anyone can help me commit this (after being reviewed). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98321/new/ https://reviews.llvm.org/D98321 _

[PATCH] D98321: [NFC] Unify FIME with FIXME in comments

b1f6c1c4 created this revision. b1f6c1c4 added reviewers: alexfh, craig.topper. Herald added subscribers: kbarton, hiraditya, nemanjai. b1f6c1c4 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. There are 5 occurrences FIME

[clang-tools-extra] cd6d179 - [clangd] Treat __GCC_HAVE_DWARF2_CFI_ASM the same as isWrittenInBuiltinFile macros

Author: Fangrui Song Date: 2021-03-09T23:11:54-08:00 New Revision: cd6d1799adfc589626917bce968f33cca821a129 URL: https://github.com/llvm/llvm-project/commit/cd6d1799adfc589626917bce968f33cca821a129 DIFF: https://github.com/llvm/llvm-project/commit/cd6d1799adfc589626917bce968f33cca821a129.diff

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

davidxl added a comment. thanks for the background. This patch looks good at higher level. Vedant can help detailed review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98061/new/ https://reviews.llvm.org/D98061 _

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

phosek added a comment. In D98061#2615575 , @davidxl wrote: > Is the case when there is no counters very rare? And for those cases, how > much overhead the runtime hook can incur? I assume it is small compared with > actual instrumentation? I'll try t

[clang-tools-extra] 46bf25a - [test] Update tests

Author: Fangrui Song Date: 2021-03-09T22:32:28-08:00 New Revision: 46bf25a7c5d3d648093edf6aab99004c053abcd4 URL: https://github.com/llvm/llvm-project/commit/46bf25a7c5d3d648093edf6aab99004c053abcd4 DIFF: https://github.com/llvm/llvm-project/commit/46bf25a7c5d3d648093edf6aab99004c053abcd4.diff

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d117e7b2a39: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 9d117e7 - Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

Author: Fangrui Song Date: 2021-03-09T22:21:36-08:00 New Revision: 9d117e7b2a399a9b2bcf53fb9b9c0946e82dc75c URL: https://github.com/llvm/llvm-project/commit/9d117e7b2a399a9b2bcf53fb9b9c0946e82dc75c DIFF: https://github.com/llvm/llvm-project/commit/9d117e7b2a399a9b2bcf53fb9b9c0946e82dc75c.diff

[PATCH] D98291: [compiler-rt] Fix stale incremental builds when using `LLVM_BUILD_EXTERNAL_COMPILER_RT=ON`.

beanz added a comment. In D98291#2615663 , @delcypher wrote: > The fact that we have 3 different ways to build compiler-rt in LLVM makes me > sad. There should only be 1. I don't have time to do it now but I've filed a > radar to do this work at some poi

[PATCH] D98291: [compiler-rt] Fix stale incremental builds when using `LLVM_BUILD_EXTERNAL_COMPILER_RT=ON`.

delcypher added a comment. In D98291#2615593 , @beanz wrote: > So... this patch is fine. (marked as approved). That said, we should really > be working to remove the `LLVM_BUILD_EXTERNAL_COMPILER_RT` option entirely in > favor of just using `LLVM_ENABLE_

[PATCH] D98291: [compiler-rt] Fix stale incremental builds when using `LLVM_BUILD_EXTERNAL_COMPILER_RT=ON`.

delcypher added a comment. In D98291#2615590 , @kubamracek wrote: > When using Ninja, does this mean running a null build is no longer a null > build, but it at least always invokes this sub-build? Not saying that's bad, > just want to understand the cha

[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

lxfind updated this revision to Diff 329517. lxfind added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98135/new/ https://reviews.llvm.org/D98135 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/omp_wi

[clang] 3f7f7f1 - [clang][APINotes] Fix gcc Wunused-function warning (NFC)

Author: Yang Fan Date: 2021-03-10T11:47:00+08:00 New Revision: 3f7f7f161540ba4a0f8cd48a4f1d5ab323cedd92 URL: https://github.com/llvm/llvm-project/commit/3f7f7f161540ba4a0f8cd48a4f1d5ab323cedd92 DIFF: https://github.com/llvm/llvm-project/commit/3f7f7f161540ba4a0f8cd48a4f1d5ab323cedd92.diff LOG:

[PATCH] D98291: [compiler-rt] Fix stale incremental builds when using `LLVM_BUILD_EXTERNAL_COMPILER_RT=ON`.

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. So... this patch is fine. (marked as approved). That said, we should really be working to remove the `LLVM_BUILD_EXTERNAL_COMPILER_RT` option entirely in favor of just using `LLVM_ENABLE_RUNTIME

[PATCH] D98291: [compiler-rt] Fix stale incremental builds when using `LLVM_BUILD_EXTERNAL_COMPILER_RT=ON`.

kubamracek added a comment. When using Ninja, does this mean running a null build is no longer a null build, but it at least always invokes this sub-build? Not saying that's bad, just want to understand the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D96404: [Android] Default to --rtlib=compiler-rt

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa478b0a199f4: [Android] Default to --rtlib=compiler-rt (authored by rprichard). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] a478b0a - [Android] Default to --rtlib=compiler-rt

Author: Ryan Prichard Date: 2021-03-09T18:09:53-08:00 New Revision: a478b0a199f4928041390d1f35dd5e226936b42c URL: https://github.com/llvm/llvm-project/commit/a478b0a199f4928041390d1f35dd5e226936b42c DIFF: https://github.com/llvm/llvm-project/commit/a478b0a199f4928041390d1f35dd5e226936b42c.diff

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

davidxl added a comment. Is the case when there is no counters very rare? And for those cases, how much overhead the runtime hook can incur? I assume it is small compared with actual instrumentation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D98134: [RFC] Introduce callback argument encoding mode into callback metadata

tianshilei1992 updated this revision to Diff 329510. tianshilei1992 added a comment. put the encoding mode into `ParameterEncoding` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98134/new/ https://reviews.llvm.org/D98134 Files: clang/include/cla

[PATCH] D93164: [AST] Add generator for source location introspection

steveire updated this revision to Diff 329509. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93164/new/ https://reviews.llvm.org/D93164 Files: clang/include/clang/Tooling/NodeIntrospection.h clang/lib/Tooling/C

[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

MaskRay accepted this revision. MaskRay added a subscriber: vsk. MaskRay added a comment. This revision is now accepted and ready to land. LG, but I hope an OpenMP expert can take a look. Perhaps @vsk can comment on why we hardly have any `@llvm.instrprof.increment` IR test for clang -fprofile-i

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

vsk added a comment. In D98061#2615386 , @phosek wrote: > In D98061#2615334 , @vsk wrote: > >> In D98061#2615250 , @phosek wrote: >> >>> In D98061#2615239

[PATCH] D97963: [ASTMatchers][Dynamic] Provide Fallback and suggestions for typos.

steveire added a comment. I like the idea, but I think you're violating the Interface Segregation Principle by putting it in the `Registry::lookupMatcherCtor` implementation. The interface here is easy to use incorrectly. Consider adding a new method instead. That way, `lookupMatcherCtor` will

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry added a comment. In D87587#2602523 , @HazardyKnusperkeks wrote: > In D87587#2597241 , @kuzkry wrote: > >> Thank you for delivering it, @HazardyKnusperkeks. >> >> One thing concerns me though. I'm not an auth

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

phosek marked an inline comment as done. phosek added a comment. In D98061#2615334 , @vsk wrote: > In D98061#2615250 , @phosek wrote: > >> In D98061#2615239 , @vsk wrote: >>

[PATCH] D97784: [ASTMatchers] Always create a "binding" for the node being matched on.

steveire added a comment. Can you add some tests for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97784/new/ https://reviews.llvm.org/D97784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

vsk added a comment. In D98061#2615250 , @phosek wrote: > In D98061#2615239 , @vsk wrote: > >> @ributzka may have stronger thoughts about when -fprofile-instr-generate >> must imply that a known set of symbols appe

[PATCH] D98300: [TLS] Initialization functions of dynamic TLS variables cannot be in a comdat (fix for PR48030)

wolfgangp created this revision. wolfgangp added reviewers: cfe-commits, rsmith. wolfgangp requested review of this revision. This is an attempt to fix PR48030. The initialization function of dynamic TLS variables are currently placed into comdats (on ELF at least). The wrapper functions that ar

[PATCH] D98296: Simplify readability checks to not need ignoring* matchers

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D98296 Files: clang-tools-extra/c

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

phosek marked an inline comment as done. phosek added a comment. In D98061#2615239 , @vsk wrote: > @ributzka may have stronger thoughts about when -fprofile-instr-generate must > imply that a known set of symbols appear with external visibility. Up until

[clang] a892b00 - PR49465: Disallow constant evaluation of a call to operator delete(nullptr).

Author: Richard Smith Date: 2021-03-09T15:06:06-08:00 New Revision: a892b0015ed6af5945d06e87ca5da1ad8be7ad29 URL: https://github.com/llvm/llvm-project/commit/a892b0015ed6af5945d06e87ca5da1ad8be7ad29 DIFF: https://github.com/llvm/llvm-project/commit/a892b0015ed6af5945d06e87ca5da1ad8be7ad29.diff

[clang] 234f321 - [clang][driver] Support Darwin SDK names with an optional prefix in their name

Author: Alex Lorenz Date: 2021-03-09T14:57:58-08:00 New Revision: 234f3211a3dd84bb2c074402054452af24b914a6 URL: https://github.com/llvm/llvm-project/commit/234f3211a3dd84bb2c074402054452af24b914a6 DIFF: https://github.com/llvm/llvm-project/commit/234f3211a3dd84bb2c074402054452af24b914a6.diff L

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

vsk added a subscriber: ributzka. vsk added a comment. @ributzka may have stronger thoughts about when -fprofile-instr-generate must imply that a known set of symbols appear with external visibility. Up until now, the answer has been "always", and this is what tapi enforces for MachO. It's awkw

[PATCH] D96404: [Android] Default to --rtlib=compiler-rt

rprichard updated this revision to Diff 329475. rprichard added a comment. Rebase this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96404/new/ https://reviews.llvm.org/D96404 Files: clang/lib/Driver/ToolChains/Linux.cpp clang/lib/Dr

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

phosek added a comment. @vsk do you have any thoughts on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98061/new/ https://reviews.llvm.org/D98061 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

hctim added a comment. In D96120#2615085 , @russell.gallop wrote: > In D96120#2597877 , @kcc wrote: > >> I am afraid we will have to delete the older (non-standalone) variant >> entirely. >> (And the sooner the b

[PATCH] D98295: [Clang] Add addrsig attribute to mark global functions/variables as address significant.

zequanwu created this revision. zequanwu added reviewers: pcc, aaron.ballman, rnk, rsmith. Herald added subscribers: dexonsmith, jdoerfert, hiraditya. zequanwu requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Functions or v

[PATCH] D98291: [compiler-rt] Fix stale incremental builds when using `LLVM_BUILD_EXTERNAL_COMPILER_RT=ON`.

delcypher updated this revision to Diff 329469. delcypher added a comment. - update description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98291/new/ https://reviews.llvm.org/D98291 Files: clang/runtime/CMakeLists.txt Index: clang/runtime/C

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

asmith added a comment. Hi John, how does this look now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D98291: [compiler-rt] Fix stale incremental builds when using `LLVM_BUILD_EXTERNAL_COMPILER_RT=ON`.

delcypher created this revision. delcypher added reviewers: kubamracek, yln, aralisza, beanz, samsonov. Herald added subscribers: mgorny, dberris. delcypher requested review of this revision. Herald added a project: clang. When building with `LLVM_BUILD_EXTERNAL_COMPILER_RT=ON` (e.g. Swift does th

[PATCH] D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type

AndreyChurbanov updated this revision to Diff 329461. AndreyChurbanov added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed the size of task dependences flags from 8 bit to 32 bit, so that runtime does not get garbage data in unused bits of the structure,

[PATCH] D97388: [analyzer] Replace StoreManager::evalIntegralCast with SValBuilder::evalCast

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ok then, let's try to land it! 🤞 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97388/new/ https://reviews.llvm.org/D97388 ___ cfe-commits mailin

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/remote/Service.proto:13 +import "google/protobuf/empty.proto"; import "Index.proto"; question of style, but unless there's a concrete benefit I'd suggest just defining the request inl

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

NoQ added a comment. > why does this not work? How does this not work? What does it say? > what is tracking mode for an ExplodedNode? Mmm yeah, in hindsight i should have explained it much more. First of all, we have "bug visitors". They are the entity that adds notes to bug reports. Note tag

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

russell.gallop abandoned this revision. russell.gallop added a comment. In D96120#2597877 , @kcc wrote: > I am afraid we will have to delete the older (non-standalone) variant > entirely. > (And the sooner the better) Okay, think we found a few things o

[PATCH] D98274: [clangd][NFC] Use std::string::replace in SourceCode:applyChange.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc92d2ea59e79: [clangd][NFC] Use std::string::replace in SourceCode:applyChange. (authored by njames93). Repository: rG LLVM Github Monorepo CHANG

[clang-tools-extra] c92d2ea - [clangd][NFC] Use std::string::replace in SourceCode:applyChange.

Author: Nathan James Date: 2021-03-09T21:39:23Z New Revision: c92d2ea59e79fb366512e16eb1209f2de3ed6ff1 URL: https://github.com/llvm/llvm-project/commit/c92d2ea59e79fb366512e16eb1209f2de3ed6ff1 DIFF: https://github.com/llvm/llvm-project/commit/c92d2ea59e79fb366512e16eb1209f2de3ed6ff1.diff LOG:

[clang] 2de0a18 - [clang][ObjC] allow the use of NSAttributedString * return type with format_arg attribute

Author: Alex Lorenz Date: 2021-03-09T13:36:57-08:00 New Revision: 2de0a18a8949f0235fb3a08dcc55ff3aa7d969e7 URL: https://github.com/llvm/llvm-project/commit/2de0a18a8949f0235fb3a08dcc55ff3aa7d969e7 DIFF: https://github.com/llvm/llvm-project/commit/2de0a18a8949f0235fb3a08dcc55ff3aa7d969e7.diff L

[PATCH] D97874: [analyzer] Improve SVal cast from integer to bool using known RangeSet

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Great, thanks! I still have concerns about these functions - `isNull`, `isNonNull` etc. They do indeed provide a quick test for nullness that doesn't involve constructing a new program state. This

[PATCH] D46443: [libc++] Add missing cstdalign header

hubert.reinterpretcast added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + curdeius wrote: > curdeius wrote: > > hubert.reinterpretcast wrote: > > > sbc100 wrote: > > > > hubert.reinterpretcast wrote: > > > > > This se

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

fhahn added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96418/new/ https://reviews.llvm.org/D96418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D98251: [-Wcompletion-handler] Extend list of detected conventions

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks all clear. In that document there's also a clause that the conventional completion handler discovered through its suffix has to be the //last// parameter. I don't immediately see that respect

[PATCH] D91944: OpenMP 5.0 metadirective

protze.joachim added a comment. In D91944#2458154 , @jdoerfert wrote: > The problem is this patch can only resolve to a single directive during > parsing. Take > > template > void foo() { > #pragma omp metadirective when(user={condition(b)}) ... >

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:332-340 if (Changes[ScopeStart - 1].Tok->is(TT_FunctionDeclarationName) || (ScopeStart > Start + 1 && Ch

[PATCH] D98286: [Driver] Enable the kernel address sanitizer on FreeBSD

markj created this revision. Herald added a subscriber: emaste. markj requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Test Plan: Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D98286 Files: clang/lib/Driver/ToolChains/

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

MaskRay updated this revision to Diff 329441. MaskRay added a comment. Move to driver Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97743/new/ https://reviews.llvm.org/D97743 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Preprocessor

[PATCH] D98242: [clangd] Store system relative includes as verbatim

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. I think this is going to be more good than bad, and the alternatives are terrifically complicated. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:801 +

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

jansvoboda11 added a comment. In D97743#2614480 , @MaskRay wrote: > In D97743#2613629 , @jansvoboda11 > wrote: > >> Could the logic be implemented in the driver? >> >> LGTM regardless. > > No. `Res` is a `clang::Co

[PATCH] D98274: [clangd][NFC] Use std::string::replace in SourceCode:applyChange.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98274/new/ https://reviews.llvm.org/D98274

[PATCH] D98242: [clangd] Store system relative includes as verbatim

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:801 + if (IsSystem) +return "<" + ShorterInclude + ">"; // Standard case: just insert the file itself. sammccall wrote: > This is a great heuristic, now I'm thi

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

MaskRay added a comment. In D97743#2614827 , @thakis wrote: > Still broken: http://45.33.8.238/linux/41278/step_7.txt b4948c27d2e40586c0c4fa7cbf20b9c40a9f7584 The green Harbomaster mi

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

HazardyKnusperkeks added a comment. I would like additional tests: - With at least 2 empty lines - With 0-2 empty lines without `verifyFormat` to demonstrate what is kept, added, and removed. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1284 (!PreviousLine->

[clang] b4948c2 - Revert D97743 "Define __GCC_HAVE_DWARF2_CFI_ASM if applicable"

Author: Fangrui Song Date: 2021-03-09T12:14:12-08:00 New Revision: b4948c27d2e40586c0c4fa7cbf20b9c40a9f7584 URL: https://github.com/llvm/llvm-project/commit/b4948c27d2e40586c0c4fa7cbf20b9c40a9f7584 DIFF: https://github.com/llvm/llvm-project/commit/b4948c27d2e40586c0c4fa7cbf20b9c40a9f7584.diff

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

thakis added a comment. Still broken: http://45.33.8.238/linux/41278/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97743/new/ https://reviews.llvm.org/D97743 ___ cfe-commits mailing list cfe-c

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

HazardyKnusperkeks added a comment. In D93938#2613096 , @atirit wrote: > In D93938#2612952 , > @HazardyKnusperkeks wrote: > >> In my opinion you should then, either temporarily deactivate the test, or >> fix the b

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

MaskRay added a comment. In D97743#2614792 , @thakis wrote: > This seems to break tests everywhere: > http://45.33.8.238/linux/41275/step_7.txt My bad. Fixed by df67d3526962ae51446b1390e7c40e045e580ec2

[clang] df67d35 - [test] Fix debug-info-macro.c

Author: Fangrui Song Date: 2021-03-09T12:04:51-08:00 New Revision: df67d3526962ae51446b1390e7c40e045e580ec2 URL: https://github.com/llvm/llvm-project/commit/df67d3526962ae51446b1390e7c40e045e580ec2 DIFF: https://github.com/llvm/llvm-project/commit/df67d3526962ae51446b1390e7c40e045e580ec2.diff

[PATCH] D97872: [clang] Don't assert in EmitAggregateCopy on trivial_abi types

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97872/new/ https://reviews.llvm.org/D97872 ___ cfe-com

[clang] 8bb8d65 - Move some attribute diagnostic helper functions; NFC.

Author: Aaron Ballman Date: 2021-03-09T14:57:00-05:00 New Revision: 8bb8d65e167dceb659211468fd44df5da17e0785 URL: https://github.com/llvm/llvm-project/commit/8bb8d65e167dceb659211468fd44df5da17e0785 DIFF: https://github.com/llvm/llvm-project/commit/8bb8d65e167dceb659211468fd44df5da17e0785.diff

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

thakis added a comment. This seems to break tests everywhere: http://45.33.8.238/linux/41275/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97743/new/ https://reviews.llvm.org/D97743 ___ cfe-co

[PATCH] D98277: [release][docs] List all cores Arm has added support for in LLVM 12.

amilendra created this revision. amilendra added reviewers: willlovett, kristof.beyls, jgreenhalgh. amilendra requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D98277 Files: c

[PATCH] D98275: [clang-tidy] Fix mpi checks when running multiple TUs per clang-tidy process

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman. Herald added a subscriber: xazax.hun. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Both the mpi-type-mismatch and mpi-buffer-deref check make use o

[PATCH] D98274: [clangd][NFC] Use std::string::replace in SourceCode:applyChange.

njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Just looks nicer and easier to rea

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc11ff4bbada3: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c11ff4b - Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

Author: Fangrui Song Date: 2021-03-09T10:52:26-08:00 New Revision: c11ff4bbada3b5127a1f010e0a97a1e6e46fb61a URL: https://github.com/llvm/llvm-project/commit/c11ff4bbada3b5127a1f010e0a97a1e6e46fb61a DIFF: https://github.com/llvm/llvm-project/commit/c11ff4bbada3b5127a1f010e0a97a1e6e46fb61a.diff

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

SjoerdMeijer added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:1495 let DecoderNamespace = "Fallback"; + let Defs = [NZCV]; } dmgreen wrote: > SjoerdMeijer wrote: > > dmgreen wrote: > > > SjoerdMeijer wrote: > > > > Do all MRS

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

MaskRay added a comment. In D97743#2613629 , @jansvoboda11 wrote: > Could the logic be implemented in the driver? > > LGTM regardless. No. `Res` is a `clang::CompilerInvocation` object. `CompilerInvocation` is not in the driver... Repository: rG LLV

[PATCH] D98255: [release][docs] List all cores Arm has added support for in LLVM 12.

amilendra abandoned this revision. amilendra added a comment. Herald added a subscriber: JDevlieghere. Abandoning this revision because I think I messed up something when using arcanist to fix pre-merge errors. https://buildkite.com/llvm-project/diff-checks/builds/32719 I'll submit a new review.

[PATCH] D98255: [release][docs] List all cores Arm has added support for in LLVM 12.

amilendra updated this revision to Diff 329380. amilendra added a comment. Herald added subscribers: llvm-commits, libcxx-commits, openmp-commits, lldb-commits, Sanitizers, jansvoboda11, frasercrmck, dexonsmith, ecnelises, wenlei, dang, jdoerfert, sstefan1, omjavaid, jvesely, phosek, kerbowa, lu

[PATCH] D98265: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG561fb7f60ab6: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX (authored by Xiangling_L). Repository: rG LLVM Github Monorepo

[clang] 561fb7f - [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX

Author: Xiangling Liao Date: 2021-03-09T13:03:52-05:00 New Revision: 561fb7f60ab631e712c3fb6bbeb47061222c6818 URL: https://github.com/llvm/llvm-project/commit/561fb7f60ab631e712c3fb6bbeb47061222c6818 DIFF: https://github.com/llvm/llvm-project/commit/561fb7f60ab631e712c3fb6bbeb47061222c6818.diff

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

dmgreen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:15993 + DAG.getConstant(0, dl, MVT::i32), + DAG.getConstant(AArch64CC::EQ, dl, MVT::i32), A.getValue(1)); + return DAG.getMergeValues( Can you make s

[PATCH] D46443: [libc++] Add missing cstdalign header

curdeius added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + curdeius wrote: > hubert.reinterpretcast wrote: > > sbc100 wrote: > > > hubert.reinterpretcast wrote: > > > > This seems to be assuming that the underlying C

[PATCH] D46443: [libc++] Add missing cstdalign header

curdeius added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + hubert.reinterpretcast wrote: > sbc100 wrote: > > hubert.reinterpretcast wrote: > > > This seems to be assuming that the underlying C library's `stdalign.h`

[PATCH] D98265: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98265/new/ https://reviews.llvm.org/D98265

[clang] b8b7a9d - [clang] unbreak Index/preamble-reparse-changed-module.m with LLVM_APPEND_VC_REV=NO after 46d4d1fea401

Author: Nico Weber Date: 2021-03-09T12:29:43-05:00 New Revision: b8b7a9dcdcbcd7427119f92b9a276ac0122ca8c6 URL: https://github.com/llvm/llvm-project/commit/b8b7a9dcdcbcd7427119f92b9a276ac0122ca8c6 DIFF: https://github.com/llvm/llvm-project/commit/b8b7a9dcdcbcd7427119f92b9a276ac0122ca8c6.diff LO

[PATCH] D98265: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX

Xiangling_L added a comment. In D98265#2614245 , @craig.topper wrote: > Maybe this needs to be addressed in the forward declaration in > clang/include/clang/Basic/LLVM.h ? Yeah, adding an additional llvm namespace is a certain another way to workaround

[PATCH] D97277: [analyzer] Eliminate dispatchCast, evalCastFromNonLoc and evalCastFromLoc functions from SValBuilder

steakhal added a comment. Please, @ASDenysPetrov, mention `NFC` in the commit message when you commit this change. The same applies to all of your NFC changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97277/new/ https://reviews.llvm.org/D97277

[PATCH] D98244: [analyzer] Fix StdLibraryFunctionsChecker performance issue

steakhal accepted this revision. steakhal added a comment. > For projects not using standard libraries, the speed-up can reach 50% after > this patch. Uh, that's something serious! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98244/new/ https://

[PATCH] D98265: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX

craig.topper added a comment. Maybe this needs to be addressed in the forward declaration in clang/include/clang/Basic/LLVM.h ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98265/new/ https://reviews.llvm.org/D98265 _

[PATCH] D98244: [analyzer] Fix StdLibraryFunctionsChecker performance issue

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Good catch! Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98244/new/ https://reviews.llvm.org/D98244 _

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

SjoerdMeijer added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:1495 let DecoderNamespace = "Fallback"; + let Defs = [NZCV]; } dmgreen wrote: > SjoerdMeijer wrote: > > Do all MRS instructions do this? > No, but some do and it's

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 329361. serge-sans-paille added a comment. Fix some formatting Support literal operator CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/ https://reviews.llvm.org/D93095 Files: clang/include/clang/AST/Decl.h clang/include/clang

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen added a comment. @jrtc27, please advise if there is anything more should to be changed, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/ https://reviews.llvm.org/D95016 ___ cfe-com

  1   2   >