[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

thakis added a comment. Hi, this breaks check-clang on arm macs: http://45.33.8.238/macm1/5421/step_6.txt (The `fatal error: 'opencl-c-base.h' file not found` bit is printed when the test passes too, and is unrelated.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:293 + driverPath = driverPath.substr(0, driverPath.size() - 9); + return driverPath.append("/../tools/flang/include/flang/"); +} tskeith wrote: > tskeith wrote: > >

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

tskeith added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:293 + driverPath = driverPath.substr(0, driverPath.size() - 9); + return driverPath.append("/../tools/flang/include/flang/"); +} tskeith wrote: > arnamoy10 wrote: > > tskeith

[PATCH] D97224: Use Address for CGBuilder's CreateAtomicRMW and CreateAtomicCmpXchg.

jyknight added a comment. In D97224#2621328 , @rjmccall wrote: > In D97224#2604537 , @jyknight wrote: > >>> I'm less certain about what to do with the `__atomic_*` builtins >> >> The `__atomic` builtins have

[PATCH] D98521: [clang-tidy] Fix readability-identifer-naming duplicating prefix or suffix for replacements.

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh. Herald added a subscriber: xazax.hun. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If a identifier has a correct prefix/suffix but a bad case, the

[PATCH] D98494: [NFC] Minor cleanup to use default setting of getLastArg()

maxim-kuvyrkov updated this revision to Diff 330273. maxim-kuvyrkov added a comment. Fixed thinko: GetLastArg -> GetLastArgValue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98494/new/ https://reviews.llvm.org/D98494 Files:

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov updated this revision to Diff 330272. maxim-kuvyrkov added a comment. Added missing header to pull in definition of CLANG_DEFAULT_LINKER. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98493/new/ https://reviews.llvm.org/D98493

[PATCH] D98483: [clang] Mark re-injected tokens appropriately during pragma handling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf43ff34ae67a: [clang] Mark re-injected tokens appropriately during pragma handling (authored by kadircet). Repository: rG LLVM Github Monorepo

[clang] f43ff34 - [clang] Mark re-injected tokens appropriately during pragma handling

Author: Kadir Cetinkaya Date: 2021-03-12T18:18:17+01:00 New Revision: f43ff34ae67a6557fe9fd1ba0e992da18bd102f7 URL: https://github.com/llvm/llvm-project/commit/f43ff34ae67a6557fe9fd1ba0e992da18bd102f7 DIFF:

[PATCH] D98520: [OpenCL] Remove spurious atomic_fetch tablegen builtins

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: jfb, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. The `int` and `long` versions of these builtins already provide the necessary

[PATCH] D98483: [clang] Mark re-injected tokens appropriately during pragma handling

kadircet updated this revision to Diff 330266. kadircet added a comment. - Introduce a helper to mark tokens as reinjected Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98483/new/ https://reviews.llvm.org/D98483 Files:

[PATCH] D98388: [RISCV][Clang] Add RVV vle/vse intrinsic functions.

khchen marked 6 inline comments as done. khchen added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:689 + skew = 1; +for (unsigned i = 0; i < PermuteOperands.size(); ++i) { + if (i != PermuteOperands[i]) rogfer01 wrote: >

[PATCH] D98488: [CodeCompletion] Avoid spurious signature help for init-list args

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang/lib/Parse/Parser.cpp:2117 if (S->getFlags() & Scope::FnScope) { + cutOffParsing();

[clang] b5fae4b - [PowerPC] Add more missing overloads to altivec.h

Author: Nemanja Ivanovic Date: 2021-03-12T10:51:57-06:00 New Revision: b5fae4b9b2fd0ac8f0ad99178f876dc78ba5613f URL: https://github.com/llvm/llvm-project/commit/b5fae4b9b2fd0ac8f0ad99178f876dc78ba5613f DIFF:

[PATCH] D98499: [clangd] Introduce ASTHooks to FeatureModules

kadircet updated this revision to Diff 330258. kadircet added a comment. - Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98499/new/ https://reviews.llvm.org/D98499 Files: clang-tools-extra/clangd/ClangdServer.cpp

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

steakhal added a comment. In D96976#2622039 , @RedDocMD wrote: > @steakhal, your views? I'm somewhat busy. If it's not urgent, I would postpone this. Ping me in a few weeks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98514: [RGT] Fix ASTMatchersTest so all assertions are executed

probinson created this revision. probinson added a reviewer: Prazek. probinson requested review of this revision. Herald added a project: clang. Some 'if' conditions turn out always to be false, so change test expectations to match. Found by the Rotten Green Tests project. Repository: rG

[PATCH] D98277: [release][docs] List all cores Arm has added support for in LLVM 12.

kristof.beyls accepted this revision. kristof.beyls added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98277/new/ https://reviews.llvm.org/D98277

[PATCH] D98504: [clang][Checkers] Fix state cleanup at dead symbol.

balazske updated this revision to Diff 330243. balazske added a comment. Improved commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98504/new/ https://reviews.llvm.org/D98504 Files:

[clang] 731b3d7 - [clang] Use Constant::getAllOnesValue helper. NFCI.

Author: Simon Pilgrim Date: 2021-03-12T15:16:36Z New Revision: 731b3d766420ce05726174ff0e1527dca8a63791 URL: https://github.com/llvm/llvm-project/commit/731b3d766420ce05726174ff0e1527dca8a63791 DIFF: https://github.com/llvm/llvm-project/commit/731b3d766420ce05726174ff0e1527dca8a63791.diff

[PATCH] D98505: [clangd] Propagate data in diagnostics

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D98504: [clang][Checkers] Fix state cleanup at dead symbol.

balazske created this revision. Herald added subscribers: martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: Szelethus. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It is possible that an entry in 'DestroyRetVal'

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

stelios-arm added inline comments. Comment at: clang/test/CodeGen/arm_acle.c:908 +#if __ARM_64BIT_STATE && defined(__ARM_FEATURE_RNG) +// AArch64-v8_3-LABEL: @test_rndr( +// AArch64-v8_3-NEXT: entry: SjoerdMeijer wrote: > Not sure if I am surprised that this

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

stelios-arm updated this revision to Diff 330230. stelios-arm marked an inline comment as done. stelios-arm added a comment. 1. Removed a redundant comment 2. Removed the changes made in the `test/CodeGen/arm_acle.c`, since the test is disabled. 3. Added a clang preprocessor test to check the

[PATCH] D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).

balazske created this revision. Herald added subscribers: martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: Szelethus. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add printing of map 'DestroyRetVal'.

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

tskeith added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:293 + driverPath = driverPath.substr(0, driverPath.size() - 9); + return driverPath.append("/../tools/flang/include/flang/"); +} arnamoy10 wrote: > tskeith wrote: > > Does

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD added a comment. @steakhal, your views? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96976/new/ https://reviews.llvm.org/D96976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D98128: [clang][clangd] Avoid inconsistent target creation

oToToT added a comment. Kindly ping. Maybe I should add a test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98128/new/ https://reviews.llvm.org/D98128 ___ cfe-commits mailing list

[PATCH] D98499: [clangd] Introduce ASTHooks to FeatureModules

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman, javed.absar. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. These can be invoked at

[PATCH] D98498: [clangd] Enable modules to contribute tweaks.

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. First patch to enable diagnostic fix

[PATCH] D98497: [ASTMatchers] Don't forward matchers in MapAnyOf

njames93 created this revision. njames93 added reviewers: aaron.ballman, steveire, klimek. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Forwarding these means that if an r-value reference is passed, the matcher will be moved.

[PATCH] D98488: [CodeCompletion] Avoid spurious signature help for init-list args

sammccall updated this revision to Diff 330218. sammccall added a comment. oops, enable clangd test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98488/new/ https://reviews.llvm.org/D98488 Files:

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

svenvh accepted this revision. svenvh added a comment. In D98411#2621736 , @ldrumm wrote: > @Anastasia @svenvh is this already covered by https://reviews.llvm.org/D98039 > ? D98039 adds the calling convention for OpenCL

[PATCH] D98494: [NFC] Minor cleanup to use default setting of getLastArg()

maxim-kuvyrkov created this revision. maxim-kuvyrkov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Noticed this while I was looking at linker defaults. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D98494 Files:

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov created this revision. maxim-kuvyrkov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. At the moment "link.exe" is hard-coded as default linker in MSVC.cpp, so there's no way to use LLD as default linker for MSVC driver.

[PATCH] D98450: [clang] store an identifer instead of declref for ns_error_domain attribute

aaron.ballman added a comment. In D98450#2621877 , @MForster wrote: > That's ok for me. I'd suggest to wait for Aaron's feedback, because IIRC it > was his suggestion in the first place to go to declref. I have the same concerns with this patch as I did

[PATCH] D98483: [clang] Mark re-injected tokens appropriately during pragma handling

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Parse/ParsePragma.cpp:2610 EoF.setKind(tok::eof); + EoF.setFlag(clang::Token::IsReinjected); AnnotTok.startToken();

[PATCH] D98341: [analyzer][solver] Prevent infeasible states (PR49490)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6dc152350824: [analyzer][solver] Prevent infeasible states (PR49490) (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 6dc1523 - [analyzer][solver] Prevent infeasible states (PR49490)

Author: Valeriy Savchenko Date: 2021-03-12T15:56:48+03:00 New Revision: 6dc152350824d0abcf4e1836c2846f8f9256779c URL: https://github.com/llvm/llvm-project/commit/6dc152350824d0abcf4e1836c2846f8f9256779c DIFF:

[clang] f50aef7 - Revert "[InstrProfiling] Don't generate __llvm_profile_runtime_user"

Author: Hans Wennborg Date: 2021-03-12T13:53:46+01:00 New Revision: f50aef745c3ba981f3d0bf118b809d0c3880a490 URL: https://github.com/llvm/llvm-project/commit/f50aef745c3ba981f3d0bf118b809d0c3880a490 DIFF: https://github.com/llvm/llvm-project/commit/f50aef745c3ba981f3d0bf118b809d0c3880a490.diff

[PATCH] D98450: [clang] store an identifer instead of declref for ns_error_domain attribute

MForster added a comment. That's ok for me. I'd suggest to wait for Aaron's feedback, because IIRC it was his suggestion in the first place to go to declref. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98450/new/ https://reviews.llvm.org/D98450

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

sgraenitz added a comment. I think this makes good progress. I found two details in the test code that need attention. The stdout issue might be done now or in a follow-up patch some time soon. Otherwise, this seems to get ready to land. @teemperor What about your notes. Are there any open

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

hokein added a comment. This looks like a reasonable solution to me -- if we don't know the function call result type (e.g. dependent-type callExpr in template context), modeling it as a dependent type. Comment at: clang/lib/AST/Expr.cpp:1387 + + auto CreateDependentType =

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

aaron.ballman added a comment. I should note, you need to also fix the CI build failures: https://reviews.llvm.org/harbormaster/unit/view/421174/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/ https://reviews.llvm.org/D97411

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with a small, technical nit to be fixed. Comment at: clang/include/clang/Basic/Attr.td:1664 +def StandaloneDebug : InheritableAttr { + let Spellings = [Clang<"standalone_debug">]; + let Subjects =

[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

stefanp accepted this revision. stefanp added a comment. This revision is now accepted and ready to land. Thank you for adding this! Other than one minor nit I think this LGTM. Feel free to address nits on commits. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:8834

[PATCH] D98030: [IR] Add vscale_range IR function attribute

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. Looks fine to me, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98030/new/ https://reviews.llvm.org/D98030

[PATCH] D98337: Add support for digit separators in C2x

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the review, I've commit in e448310059053d69fbdd6c66dd95ad5d3cfc6243 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e448310 - Add support for digit separators in C2x.

Author: Aaron Ballman Date: 2021-03-12T07:21:03-05:00 New Revision: e448310059053d69fbdd6c66dd95ad5d3cfc6243 URL: https://github.com/llvm/llvm-project/commit/e448310059053d69fbdd6c66dd95ad5d3cfc6243 DIFF: https://github.com/llvm/llvm-project/commit/e448310059053d69fbdd6c66dd95ad5d3cfc6243.diff

[PATCH] D98030: [IR] Add vscale_range IR function attribute

bsmith added inline comments. Comment at: llvm/lib/IR/Attributes.cpp:570 +Result += utostr(MinValue); +Result += ','; +Result += utostr(MaxValue); peterwaller-arm wrote: > Nit: The only other precedent I can see for this is `allocsize`. Grepping the

[PATCH] D98030: [IR] Add vscale_range IR function attribute

bsmith updated this revision to Diff 330205. bsmith marked 3 inline comments as done. bsmith added a comment. - State what lack of vscale_range attribute means in LangRef - Minor formatting change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98488: [CodeCompletion] Avoid spurious signature help for init-list args

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Somewhat surprisingly, signature help is emitted as a

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

bsmith created this revision. bsmith added reviewers: paulwalker-arm, peterwaller-arm, joechrisellis, CarolineConcatto, dmgreen. Herald added subscribers: hiraditya, kristof.beyls, tschuett. bsmith requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers:

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

ldrumm added a subscriber: svenvh. ldrumm added a comment. @Anastasia @svenvh is this already covered by https://reviews.llvm.org/D98039 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98411/new/ https://reviews.llvm.org/D98411

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon abandoned this revision. segoon added a comment. see https://reviews.llvm.org/D94622#2617417 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93940/new/ https://reviews.llvm.org/D93940 ___ cfe-commits mailing list

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon abandoned this revision. segoon added a comment. see https://reviews.llvm.org/D94622#2617417 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94621/new/ https://reviews.llvm.org/D94621 ___ cfe-commits mailing list

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

RKSimon added a comment. @azabaznov This has broken some buildbots http://lab.llvm.org:8011/#/builders/105/builds/6855 - can you take a look please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97058/new/ https://reviews.llvm.org/D97058

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

SjoerdMeijer added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:364 + if (HasRandGen) +Builder.defineMacro("__ARM_FEATURE_RNG", "1"); + This needs a clang preprocessor test: both a check for its presence and absence. Have a look/grep

[PATCH] D98483: [clang] Mark re-injected tokens appropriately during pragma handling

kadircet updated this revision to Diff 330184. kadircet added a comment. - Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98483/new/ https://reviews.llvm.org/D98483 Files: clang/lib/Parse/ParsePragma.cpp

[PATCH] D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type

protze.joachim added inline comments. Comment at: openmp/runtime/src/kmp_taskdeps.cpp:344-346 +// link node as successor of all nodes in the prev_set if any +npredecessors += +__kmp_depnode_link_successor(gtid, thread, task, node, prev_set);

[clang] 194861f - [Matrix] Add missing newline to appease sphinx.

Author: Florian Hahn Date: 2021-03-12T09:33:36Z New Revision: 194861fa1bdfa852f18cb5690509ac0f05219ba1 URL: https://github.com/llvm/llvm-project/commit/194861fa1bdfa852f18cb5690509ac0f05219ba1 DIFF: https://github.com/llvm/llvm-project/commit/194861fa1bdfa852f18cb5690509ac0f05219ba1.diff LOG:

[PATCH] D98459: [CodeCompletion] Don't track preferred types if code completion is disabled.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang/include/clang/Parse/Parser.h:944 public: -explicit TentativeParsingAction(Parser& p) : P(p) { - PrevPreferredType =

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG840643bbe1d2: [OpenCL] Refactor diagnostic for OpenCL extension/feature (authored by azabaznov). Changed prior to commit:

[clang] 840643b - [OpenCL] Refactor diagnostic for OpenCL extension/feature

Author: Anton Zabaznov Date: 2021-03-12T11:43:53+03:00 New Revision: 840643bbe1d25c88b0832f93c8bf3b2c451c7b14 URL: https://github.com/llvm/llvm-project/commit/840643bbe1d25c88b0832f93c8bf3b2c451c7b14 DIFF:

[PATCH] D98483: [clang] Mark re-injected tokens appropriately during pragma handling

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a subscriber: usaxena95. kadircet requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. This hides such tokens from TokenWatcher, preventing crashes

[PATCH] D98459: [CodeCompletion] Don't track preferred types if code completion is disabled.

sammccall updated this revision to Diff 330163. sammccall added a comment. Omit narrower, now-redundant check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98459/new/ https://reviews.llvm.org/D98459 Files: clang/include/clang/Parse/Parser.h

<    1   2