[PATCH] D99227: [Coroutine][Clang] Force emit lifetime intrinsics for Coroutines

lxfind added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1318 /// otherwise llvm::Value *CodeGenFunction::EmitLifetimeStart(uint64_t Size, llvm::Value *Addr) { ChuanqiXu wrote: > Can we sure

[PATCH] D99237: [AVR][clang] Fix wrong calling convention in functions return struct type

benshi001 updated this revision to Diff 332871. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99237/new/ https://reviews.llvm.org/D99237 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/avr/struct.c Index: clang/test/CodeGen/avr/struct.c

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

alok updated this revision to Diff 332870. alok added a comment. Re-based after setting the parent patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99238/new/ https://reviews.llvm.org/D99238 Files: clang/include/clang/Basic/CodeGenOptions.def

[clang] 4020932 - [PowerPC] Make altivec.h work with AIX which has no __int128

Author: Nemanja Ivanovic Date: 2021-03-24T00:35:51-05:00 New Revision: 4020932706f6f8538b48b9b8439a7ec1266a7ae5 URL: https://github.com/llvm/llvm-project/commit/4020932706f6f8538b48b9b8439a7ec1266a7ae5 DIFF:

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

alok created this revision. alok added reviewers: djtodoro, aprantl, jmorse, SouraVX, jini.susan.george, bhuvanendrakumarn. alok added a project: debug-info. Herald added subscribers: jansvoboda11, dexonsmith. alok requested review of this revision. Herald added projects: clang, LLVM. Herald

[PATCH] D99227: [Coroutine][Clang] Force emit lifetime intrinsics for Coroutines

lxfind added a comment. In D99227#2646568 , @ChuanqiXu wrote: > Only one problem I had for emitting lifetime markers even at O0 is that would > action make allocas to be optimized even at O0? If so, I wonder if it > confuses programmers since they may

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

alok updated this revision to Diff 332867. alok added a comment. Updated to incorporate comments from @djtodoro - to split out separate patch for clang change. and fixed clang-format issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99160/new/ https://reviews.llvm.org/D99160

[PATCH] D99227: [Coroutine][Clang] Force emit lifetime intrinsics for Coroutines

lxfind added a subscriber: lewissbaker. lxfind added a comment. > I think you just set `ShouldEmitLifetimeMarkers` correctly in the first place > instead of adding this as an extra condition to every place that considers > it, however. This was set when a CodeGenFunction is constructed, at

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

alok added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1645 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArchs, T.getArch())) djtodoro wrote: > I think this should be a

[PATCH] D99151: [RISCV][Clang] Add RVV vleff intrinsic functions.

khchen added a comment. maybe we could merge different test into one vleff.c? Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics/vle16ff.c:9 +// RUN: -target-feature +experimental-zfh -target-feature +m -fallow-half-arguments-and-returns -Werror -Wall -S -o - %s >/dev/null

[PATCH] D99237: [AVR][clang] Fix wrong calling convention in functions return struct type

benshi001 created this revision. benshi001 added reviewers: dylanmckay, aykevl, MaskRay. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. According to AVR ABI (https://gcc.gnu.org/wiki/avr-gcc),

Re: [clang] aae84b8 - Revert "[Driver] Bring back "Clean up Debian multiarch /usr/include/ madness" and restore i586-linux-gnu"

(Reduced repro: https://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20210322/362775.html ) On Tue, Mar 23, 2021 at 11:14 PM Zequan Wu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Zequan Wu > Date: 2021-03-23T20:12:09-07:00 > New Revision:

Re: [clang] 874bdc8 - [Driver] Clean up Debian multiarch /usr/include/ madness

Yes. 1. Download https://commondatastorage.googleapis.com/chrome-linux-sysroot/toolchain/500976182686961e34974ea7bdc0a21fca32be06/debian_sid_amd64_sysroot.tar.xz 2. Unpack somewhere 3. Delete the lib/ folder in it 4. Try to use that sysroot like so: thakis@thakis:~/src/llvm-project$ cat test.cc

[PATCH] D99235: [HIP] Change to code object v4

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Change to code object v4 by default to match ROCm 4.1. This is upstream of code object v4 support from amd-stg-open branch. https://reviews.llvm.org/D99235 Files:

[PATCH] D99233: [HIP] Add option --gpu-inline-threshold

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: jansvoboda11, dang. yaxunl requested review of this revision. Add option --gpu-inline-threshold for inline threshold for device compilation only. https://reviews.llvm.org/D99233 Files:

[clang] aae84b8 - Revert "[Driver] Bring back "Clean up Debian multiarch /usr/include/ madness" and restore i586-linux-gnu"

Author: Zequan Wu Date: 2021-03-23T20:12:09-07:00 New Revision: aae84b8e3939e815bbc1e64b3b30c0f10b055be4 URL: https://github.com/llvm/llvm-project/commit/aae84b8e3939e815bbc1e64b3b30c0f10b055be4 DIFF: https://github.com/llvm/llvm-project/commit/aae84b8e3939e815bbc1e64b3b30c0f10b055be4.diff

[PATCH] D99227: [Coroutine][Clang] Force emit lifetime intrinsics for Coroutines

ChuanqiXu added a comment. Only one problem I had for emitting lifetime markers even at O0 is that would action make allocas to be optimized even at O0? If so, I wonder if it confuses programmers since they may find some variables disappear surprisingly. Or there would be no optimization since

[PATCH] D99189: [RISCV][Clang] Update new overloading rules for RVV intrinsics.

khchen updated this revision to Diff 332852. khchen added a comment. Fix unintended change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99189/new/ https://reviews.llvm.org/D99189 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D98848: [RISCV][Clang] Add RVV Vector Indexed Load intrinsic functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG88c2d4c8eb0e: [RISCV][Clang] Add RVV Vector Indexed Load intrinsic functions. (authored by khchen). Changed prior to commit: https://reviews.llvm.org/D98848?vs=332660=332850#toc Repository: rG LLVM

Re: [clang] 874bdc8 - [Driver] Clean up Debian multiarch /usr/include/ madness

Was this reviewed anywhere? On Mon, Mar 22, 2021 at 1:40 AM Fangrui Song via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Fangrui Song > Date: 2021-03-21T22:40:38-07:00 > New Revision: 874bdc8e61662b5f39a9626b9132e0979fae556f > > URL: >

[PATCH] D99227: [Coroutine][Clang] Force emit lifetime intrinsics for Coroutines

rjmccall added a comment. In D99227#2646532 , @rjmccall wrote: > I am skeptical that it's reasonable to do this for *correctness*, however; I > don't think the frontend unconditionally emits lifetime intrinsics. Sorry, I re-read this after posting, and

[PATCH] D99227: [Coroutine][Clang] Force emit lifetime intrinsics for Coroutines

rjmccall added a comment. I have no objection to trying to always emit lifetime intrinsics in coroutines since it has a less-trivial runtime cost. I am skeptical that it's reasonable to do this for *correctness*, however; I don't think the frontend unconditionally emits lifetime intrinsics.

[PATCH] D99225: [clang] cxx tests: cleanup, update and add some new ones

mizvekov updated this revision to Diff 332844. mizvekov added a comment. Normalize test tag names on clang/test/SemaCXX/P1155 .cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99225/new/

[PATCH] D97831: [Clang][Sema] Implement GCC -Wcast-function-type

ychen added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:1044-1048 + // Allow integral type mismatch if their size are equal. + if (SrcType->isIntegralType(Context) && DestType->isIntegralType(Context)) +if (Context.getTypeInfoInChars(SrcType).Width == +

[PATCH] D97831: [Clang][Sema] Implement GCC -Wcast-function-type

ychen updated this revision to Diff 332840. ychen marked 3 inline comments as done. ychen added a comment. - Add code/tests for `function -> function pointer` and `block pointer -> function pointer`. - Use Context.hasSameUnqualifiedType - Style Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D98554: Save strings for CC_PRINT env vars

SeanP marked 2 inline comments as done. SeanP added inline comments. Comment at: clang/include/clang/Driver/Driver.h:160 /// The file to log CC_PRINT_PROC_STAT_FILE output to, if enabled. - const char *CCPrintStatReportFilename; + std::string CCPrintStatReportFilename;

[PATCH] D98554: Save strings for CC_PRINT env vars

SeanP updated this revision to Diff 332836. SeanP added a comment. Changed the code checking the env vars so it doesn't assign a null_ptr to the string. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98554/new/ https://reviews.llvm.org/D98554 Files:

[PATCH] D99005: [clang] WIP: Implement P2266

mizvekov added a comment. Splitting off the test changes into: https://reviews.llvm.org/D99225 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https://reviews.llvm.org/D99005 ___ cfe-commits

[PATCH] D99231: [AST] Add introspection support for more base nodes

steveire created this revision. steveire added a reviewer: njames93. Herald added a subscriber: mgorny. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Replace an assert for a CXXCtorInitializer SourceLocation with a condition, as

[PATCH] D99225: [clang] cxx tests: cleanup, update and add some new ones

mizvekov updated this revision to Diff 332832. mizvekov added a comment. Changes per Arthur. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99225/new/ https://reviews.llvm.org/D99225 Files:

[PATCH] D99225: [clang] cxx tests: cleanup, update and add some new ones

mizvekov added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:444 void f(volatile void); // expected-error {{'void' as parameter must not have type qualifiers}} + // cxx20_2b-warning@-1 {{volatile-qualified parameter type 'volatile void' is deprecated}} void

[PATCH] D99225: [clang] cxx tests: cleanup, update and add some new ones

mizvekov added inline comments. Comment at: clang/test/CXX/dcl.dcl/dcl.spec/dcl.type/dcl.spec.auto/p7-cxx14.cpp:3 +// RUN: %clang_cc1 -verify -std=c++20 -verify %s +// RUN: %clang_cc1 -verify -std=c++14 -verify %s Quuxplusone wrote: > (1) You skipped 17. >

[clang] 4259301 - Support #__private_macro and #__public_macro in local submodule

Author: Richard Smith Date: 2021-03-23T16:54:28-07:00 New Revision: 4259301aaf58c13b004d968dfbd20428bf978b32 URL: https://github.com/llvm/llvm-project/commit/4259301aaf58c13b004d968dfbd20428bf978b32 DIFF: https://github.com/llvm/llvm-project/commit/4259301aaf58c13b004d968dfbd20428bf978b32.diff

[clang] 4cd1098 - Improve const-correctness. NFC.

Author: Richard Smith Date: 2021-03-23T16:54:27-07:00 New Revision: 4cd109891cbc448819eb9de9104cd14d993e45b1 URL: https://github.com/llvm/llvm-project/commit/4cd109891cbc448819eb9de9104cd14d993e45b1 DIFF: https://github.com/llvm/llvm-project/commit/4cd109891cbc448819eb9de9104cd14d993e45b1.diff

[PATCH] D99227: [Coroutine][Clang] Force emit lifetime intrinsics for Coroutines

lxfind created this revision. Herald added subscribers: ChuanqiXu, hoy, modimo, wenlei. lxfind requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. tl;dr Correct implementation of Corouintes requires having lifetime intrinsics available.

[PATCH] D99225: [clang] cxx tests: cleanup, update and add some new ones

Quuxplusone added a comment. IMHO you should just go ahead and land the trivial trailing-whitespace changes. Comment at: clang/test/CXX/dcl.dcl/dcl.spec/dcl.type/dcl.spec.auto/p7-cxx14.cpp:3 +// RUN: %clang_cc1 -verify -std=c++20 -verify %s +// RUN: %clang_cc1 -verify

[clang] 431e313 - [CGAtomic] Lift stronger requirements on cmpxch and support acquire failure mode

Author: Bruno Cardoso Lopes Date: 2021-03-23T16:45:37-07:00 New Revision: 431e3138a1f3fd2bb7b25e1f4766d935058136f8 URL: https://github.com/llvm/llvm-project/commit/431e3138a1f3fd2bb7b25e1f4766d935058136f8 DIFF:

[PATCH] D98995: [CGAtomic] Lift stronger requirements on cmpxch and add support for acquire failure mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG431e3138a1f3: [CGAtomic] Lift stronger requirements on cmpxch and support acquire failure mode (authored by bruno). Herald added a project: clang.

[PATCH] D98995: [CGAtomic] Lift stronger requirements on cmpxch and add support for acquire failure mode

bruno updated this revision to Diff 332823. bruno edited the summary of this revision. bruno added a comment. @jfb sure! Also fix test failures. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98995/new/ https://reviews.llvm.org/D98995 Files: clang/lib/CodeGen/CGAtomic.cpp

[PATCH] D99225: [clang] cxx tests: cleanup, update and add some new ones

mizvekov created this revision. Herald added a subscriber: lxfind. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reworks a small set of tests, as preparatory work for implementing P2266 . -

[PATCH] D98881: [RISCV] Fix mcount name

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGen/mcount.c:17 +// RUN: %clang_cc1 -pg -triple riscv64 -emit-llvm -o - %s | FileCheck -check-prefixes=CHECK-PREFIXED,NO-MCOUNT1 %s +//

[PATCH] D98881: [RISCV] Fix mcount name

nathanchance updated this revision to Diff 332811. nathanchance retitled this revision from "[RISCV] Fix mcount name for Linux" to "[RISCV] Fix mcount name". nathanchance edited the summary of this revision. nathanchance added a comment. Herald added subscribers: frasercrmck, apazos, jocewei,

[PATCH] D99220: [RISCV] Fix mcount name

nathanchance created this revision. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal,

[PATCH] D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level)

steveire added a comment. Does anything prevent this going in now? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69218/new/ https://reviews.llvm.org/D69218 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97831: [Clang][Sema] Implement GCC -Wcast-function-type

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8368 +def warn_cast_function_type : Warning< + "cast between incompatible function types from %0 to %1">, + InGroup, DefaultIgnore; I'd find something like "cast from

[PATCH] D99193: [PowerPC] Add mprivileged option

amyk accepted this revision as: amyk. amyk added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99193/new/ https://reviews.llvm.org/D99193 ___ cfe-commits mailing list

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

rjmccall added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:2668 // ::= g # __float128 + // ::= g # __ibm128 // UNSUPPORTED:::= Dd # IEEE 754r decimal floating point (64 bits) jwakely wrote: >

[clang] c4f65ef - [test] Add --sysroot= to make gcc-toolchain.cpp stable

Author: Fangrui Song Date: 2021-03-23T13:32:30-07:00 New Revision: c4f65ef78fd71b4db2dc7bc6646c7e3d2be11746 URL: https://github.com/llvm/llvm-project/commit/c4f65ef78fd71b4db2dc7bc6646c7e3d2be11746 DIFF: https://github.com/llvm/llvm-project/commit/c4f65ef78fd71b4db2dc7bc6646c7e3d2be11746.diff

[PATCH] D99107: [clang][CodeGen] Do not emit NVRO debug helper when not emitting debug info

rnk added a comment. In D99107#2642599 , @nick wrote: > Is this hack actually needed? I could not reproduce a problem with > https://bugs.chromium.org/p/chromium/issues/detail?id=860398#c13 repro, the > breakpoint fires for me and I see the variable. >

[PATCH] D99158: [RISCV][WIP] Implement intrinsics for P extension

craig.topper added a comment. What are we gaining from making the intrinsics use vector types if no vector operations are supported other than the intrinsics? Why can't we just use an xlen integer type? Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:706 + +

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

MaskRay added a comment. > This approach was already used prior to 9a041a75221ca, but we changed it to > always generate the llvm_profile_runtime due to a TAPI limitation. D43794 (rG9a041a75221ca

[PATCH] D99189: [RISCV][Clang] Update new overloading rules for RVV intrinsics.

craig.topper added inline comments. Comment at: llvm/docs/CommandGuide/tblgen.rst:133 - Generate generic automata. + Generate overloaded automata. This looks like an unintended change Comment at: llvm/docs/CommandGuide/tblgen.rst:279 -

[PATCH] D99121: [IR][InstCombine] IntToPtr Produces Typeless Pointer To Byte

dblaikie added a subscriber: jyknight. dblaikie added a comment. In D99121#2644362 , @lebedev.ri wrote: > In D99121#2644223 , @nlopes wrote: > >> The pointee type in LLVM doesn't really matter. It's even supposed

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

phosek added a comment. In D98061#2623959 , @MaskRay wrote: > I am a bit concerned that whether the file is generated or not is now > dependent on the instrumentation and linker garbage collection. That's a fair concern, do you know about use cases

[PATCH] D98848: [RISCV][Clang] Add RVV Vector Indexed Load intrinsic functions.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:23 #include "llvm/ADT/Twine.h" +#include "llvm/Support/Regex.h" #include "llvm/TableGen/Error.h"

[PATCH] D72566: [clang-tidy] Clang tidy is now alias aware

MartinG added a comment. In D72566#1815917 , @aaron.ballman wrote: > I'm not certain I agree. Many of the aliases have different sets of default > checking options from the primary check. And that's precisely the problem. Aliases should be just that:

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

phosek updated this revision to Diff 332739. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98061/new/ https://reviews.llvm.org/D98061 Files: clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Fuchsia.cpp

[PATCH] D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5f1de9cab1ce: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type. (authored by arthur.j.odwyer). Repository: rG LLVM

[clang] 5f1de9c - [C++20] [P1825] Fix bugs with implicit-move from variables of reference type.

Author: Arthur O'Dwyer Date: 2021-03-23T14:12:06-04:00 New Revision: 5f1de9cab1ce2fbb1e45239d3e0e8d4970d2124e URL: https://github.com/llvm/llvm-project/commit/5f1de9cab1ce2fbb1e45239d3e0e8d4970d2124e DIFF:

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl added a comment. In D71726#2645269 , @tra wrote: > @jyknight - James, do you have further concerns about the patch? I separated the change about diagnosing unaligned atomics for amdgpu to https://reviews.llvm.org/D99201 since these two changes

[PATCH] D99201: [HIP] Diagnose unaligned atomic for amdgpu

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall, jfb. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, jvesely, kzhuravl. yaxunl requested review of this revision. Herald added a subscriber: wdng. https://reviews.llvm.org/D99201 Files:

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl updated this revision to Diff 332730. yaxunl edited the summary of this revision. yaxunl added a comment. separate diagnosing unaligned atomc for amdgpu to another review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/ https://reviews.llvm.org/D71726 Files:

[PATCH] D99200: [SystemZ][z/OS] JSON file should be text files

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch sets the OF_Text flag correctly for the json file created in Clang::DumpCompilationDatabaseFragmentToDir.

[PATCH] D99199: Make -fcrash-diagnostics-dir control the Windows (mini-)dump location

probinson created this revision. probinson added a reviewer: rnk. Herald added subscribers: dexonsmith, hiraditya. probinson requested review of this revision. Herald added projects: clang, LLVM. There's no automated test for this, as I don't see any existing tests for creating minidumps. I

[PATCH] D98873: Document -fcrash-diagnostics-dir

This revision was automatically updated to reflect the committed changes. Closed by commit rGe150be612bf7: Document -fcrash-diagnostics-dir (authored by probinson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98873/new/

[clang] e150be6 - Document -fcrash-diagnostics-dir

Author: Paul Robinson Date: 2021-03-23T10:47:12-07:00 New Revision: e150be612bf79b75ce5b04136f18a7a1142aa423 URL: https://github.com/llvm/llvm-project/commit/e150be612bf79b75ce5b04136f18a7a1142aa423 DIFF: https://github.com/llvm/llvm-project/commit/e150be612bf79b75ce5b04136f18a7a1142aa423.diff

[PATCH] D97831: [Clang][Sema] Implement GCC -Wcast-function-type

ychen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97831/new/ https://reviews.llvm.org/D97831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan updated this revision to Diff 332720. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. After going through all the function usages, I realized FileSize is not used anywhere. I can remove this parameter. Repository:

[PATCH] D99185: [PowerPC] Change option to mrop-protect

amyk accepted this revision as: amyk. amyk added a comment. This also LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99185/new/ https://reviews.llvm.org/D99185 ___ cfe-commits mailing list

[PATCH] D99193: [PowerPC] Add mprivileged option

lei accepted this revision. lei added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99193/new/ https://reviews.llvm.org/D99193 ___

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

tra added a comment. @jyknight - James, do you have further concerns about the patch? Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6454 +bool DiagAtomicLibCall = true; +for (auto *A : Args.filtered(options::OPT_W_Joined)) { + if (StringRef(A->getValue()) ==

[PATCH] D99185: [PowerPC] Change option to mrop-protect

lei accepted this revision as: lei. lei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99185/new/ https://reviews.llvm.org/D99185

[PATCH] D98793: [SystemZ][z/OS] fix lit test related to alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rGf46c41febb88: [SystemZ][z/OS] fix lit test related to alignment (authored by NancyWang, committed by muiez). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[clang] f46c41f - [SystemZ][z/OS] fix lit test related to alignment

Author: Nancy Wang Date: 2021-03-23T13:15:19-04:00 New Revision: f46c41febb88182f172d0260b55bd17e4c690a43 URL: https://github.com/llvm/llvm-project/commit/f46c41febb88182f172d0260b55bd17e4c690a43 DIFF: https://github.com/llvm/llvm-project/commit/f46c41febb88182f172d0260b55bd17e4c690a43.diff

[PATCH] D99188: [clang][ASTImporter] Add import of DeducedTemplateSpecializationType.

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99188/new/ https://reviews.llvm.org/D99188 ___

[PATCH] D98873: Document -fcrash-diagnostics-dir

ormris accepted this revision. ormris added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98873/new/ https://reviews.llvm.org/D98873 ___

[PATCH] D33029: [clang-format] add option for dangling parenthesis

jakar added a comment. @catskul can you share your changes somehow? If you did, sorry, I'm new to Phabricator. Before I saw @catskul's comment, I rebased @stringham's diff and got the existing unit tests to work. But after some experimentation, I found that it didn't always behave like I

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 332703. arnamoy10 added a comment. 1. Leaning out the "wrong-option" test case 2. Adding aliases in f18 (`-pedantic` and `-std=2018` for `-Mstandard`) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97119/new/ https://reviews.llvm.org/D97119

[clang] 8298899 - [ASTMatchers][NFC] Use SmallVector when building variadic matcher descriptor

Author: Nathan James Date: 2021-03-23T16:38:45Z New Revision: 8298899e56cdf89c68215853010352c45398ab10 URL: https://github.com/llvm/llvm-project/commit/8298899e56cdf89c68215853010352c45398ab10 DIFF: https://github.com/llvm/llvm-project/commit/8298899e56cdf89c68215853010352c45398ab10.diff LOG:

[PATCH] D99106: [ASTMatchers][NFC] Use SmallVector when building variadic matcher descriptor

This revision was automatically updated to reflect the committed changes. Closed by commit rG8298899e56cd: [ASTMatchers][NFC] Use SmallVector when building variadic matcher descriptor (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98712: [Utils] Support lit-like substitutions in update_cc_test_checks

ggeorgakoudis added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:228 + '%t' : tempfile.NamedTemporaryFile().name, + '%S' : os.getcwd(), +} arichardson wrote: > Shouldn't this be the directory containing the test? You are right,

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd4abc5242c0: [flang][driver] Add -fintrinsic-modules-path option (authored by Arnamoy Bhattacharyya arnamoy.bhattachar...@huawei.com, committed by

[clang] cd4abc5 - [flang][driver] Add -fintrinsic-modules-path option

Author: Arnamoy Bhattacharyya Date: 2021-03-23T12:28:19-04:00 New Revision: cd4abc5242c03804b3d88277b03b52215a899f75 URL: https://github.com/llvm/llvm-project/commit/cd4abc5242c03804b3d88277b03b52215a899f75 DIFF:

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 updated this revision to Diff 332692. arnamoy10 added a comment. Thanks @awarzynski for the comments. 1. Moving diagnostics options parsing to a separate function 2. Adding a check so that `-Wblah` does not trigger the treatment of warnings as werrors, only `-Werror` triggers it 3.

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 added inline comments. Comment at: flang/test/Semantics/dosemantics03.f90:1-2 ! RUN: %S/test_errors.sh %s %t %f18 -Mstandard -Werror +! RUN: %S/test_errors.sh %s %t %flang_fc1 -Werror awarzynski wrote: > Rather than adding the 2nd line, could you

[PATCH] D99194: [analyzer] Fix body farm for Obj-C++ properties

steakhal resigned from this revision. steakhal added a comment. Herald added a subscriber: steakhal. I'm not familiar with Objective-C. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99194/new/ https://reviews.llvm.org/D99194

[PATCH] D99194: [analyzer] Fix body farm for Obj-C++ properties

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, steakhal, ASDenysPetrov. Herald added subscribers: Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, kristof.beyls. vsavchenko requested review of this revision.

[PATCH] D98950: [clang][deps] NFC: Document collector, rename members

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. Thanks for the cleanup. Code makes more sense now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98950/new/

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

balazske marked 3 inline comments as done. balazske added a comment. Ping. I am not sure how to the test should be changed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95244/new/ https://reviews.llvm.org/D95244

[PATCH] D99193: [PowerPC] Add mprivileged option

stefanp created this revision. stefanp added a reviewer: nemanjai. Herald added subscribers: jansvoboda11, dang, shchenz, kbarton, hiraditya. stefanp requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Add an option to tell the compiler

[PATCH] D99106: [ASTMatchers][NFC] Use SmallVector when building variadic matcher descriptor

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99106/new/ https://reviews.llvm.org/D99106

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

balazske updated this revision to Diff 332686. balazske added a comment. Fixed according to the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95244/new/ https://reviews.llvm.org/D95244 Files: clang/lib/AST/Expr.cpp

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

djtodoro updated this revision to Diff 332679. djtodoro added a comment. - addressing comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

djtodoro added inline comments. Comment at: clang/include/clang/Driver/Options.td:4872 + "optimizations.">; +def fverify_debuginfo_preserve_export +: Joined<["-"], "fverify-debuginfo-preserve-export=">, jansvoboda11 wrote: > Please, update the

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

Max_S added a comment. In D98237#2643815 , @MyDeveloperDay wrote: > If you follow people tweeting about clang-format (as I do) and you look > through the bug tracking system, one major criticism of clang-format is that > the second clang-format can be

[PATCH] D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type

mizvekov added a comment. In D98971#2644747 , @Quuxplusone wrote: > Shrink the code by one line, by introducing another local named variable. > Still hoping for an "accept" here. My two cents: Functionality-wise I think it is OK, but like I said before,

[PATCH] D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type

aaronpuchert accepted this revision. aaronpuchert added a comment. This revision is now accepted and ready to land. I thought maybe you wanted to follow @mizvekov's proposal to simplify, but I understand you want to stick close to the standard language. So LGTM. Repository: rG LLVM Github

[PATCH] D99190: [SYCL] Add design document for SYCL mode

bader created this revision. Herald added subscribers: mstorsjo, Anastasia, ebevhan, yaxunl. bader requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Initial version of the document covers most of

[PATCH] D97869: [OpenCL][Draft] Add OpenCL builtin test generator

svenvh updated this revision to Diff 332675. svenvh added a comment. Emit `#if` guards for extensions and versions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97869/new/ https://reviews.llvm.org/D97869 Files: clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp

[PATCH] D99189: [RISCV][Clang] Update new overloading rules for RVV intrinsics.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

  1   2   >