[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

bader marked an inline comment as done. bader added a comment. In D99190#2652054 , @keryell wrote: >> ! In D99190#2650326 , @bader wrote: >> >> 2. I'm looking for suggestions on "OpenCL extensions" clarification. >

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

bader updated this revision to Diff 333502. bader added a comment. Resolve "OpenCL extensions" ambiguity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99190/new/ https://reviews.llvm.org/D99190 Files: clang/docs/SYCLSupport.md

[PATCH] D99189: [RISCV][Clang] Update new overloading rules for RVV intrinsics.

khchen updated this revision to Diff 333486. khchen added a comment. remove riscv_vector_overloaded.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99189/new/ https://reviews.llvm.org/D99189 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D99360: [OpenMP][WIP] Add standard notes for ELF offload images

vzakhari updated this revision to Diff 333484. vzakhari edited the summary of this revision. vzakhari added a comment. Fixed issues detected in Windows testing downstream. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99360/new/ https://reviews.llvm.org/D99360 Files:

[PATCH] D99396: [clang] Support C++20's using ENUM_ID::IDENTIFIER

AntonBikineev created this revision. AntonBikineev added a reviewer: rsmith. AntonBikineev added a project: clang. AntonBikineev requested review of this revision. This change merely allows nested-name-specifiers for enums in using declarations but doesn't add support for the

[PATCH] D99189: [RISCV][Clang] Update new overloading rules for RVV intrinsics.

liaolucy added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:10 // This tablegen backend is responsible for emitting riscv_vector.h and -// riscv_vector_generic.h, which includes a declaration and definition of each -// intrinsic fucntions specified in

[clang] 4f3ea27 - Stop this test from dropping a .s file in the current directory.

Author: Richard Smith Date: 2021-03-25T18:22:18-07:00 New Revision: 4f3ea27dacdc1b428710174c88521ca717d897ea URL: https://github.com/llvm/llvm-project/commit/4f3ea27dacdc1b428710174c88521ca717d897ea DIFF: https://github.com/llvm/llvm-project/commit/4f3ea27dacdc1b428710174c88521ca717d897ea.diff

[clang] 11bf268 - Add a target triple to fix test failure on targets that don't support

Author: Richard Smith Date: 2021-03-25T17:05:36-07:00 New Revision: 11bf268864afbe35ad317e6354c51440d5184911 URL: https://github.com/llvm/llvm-project/commit/11bf268864afbe35ad317e6354c51440d5184911 DIFF: https://github.com/llvm/llvm-project/commit/11bf268864afbe35ad317e6354c51440d5184911.diff

[PATCH] D99008: [RISCV] [2/2] Add intrinsic for Zbr extension

craig.topper added inline comments. Comment at: clang/lib/Headers/riscv_zbr_intrin.h:9 + */ + +#ifndef __RISCV_ZBR_INTRIN_H Please add ``` #ifndef __RVINTRIN_H

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3398 // message. + bool miss_feature_error = false; + SmallVector ReqFeatures; Variable names should start with a capital letter and use CamelCase. Comment

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

craig.topper added a comment. Please reupload the patch using something like "git diff -U9". We should be able to expand the full diff here so that phabricator doesn't say "Context not available." Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99308: [Triple][Driver] Add muslx32 environment and use /lib/ld-musl-x32.so.1 for -dynamic-linker

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed956554f96c: [Triple][Driver] Add muslx32 environment and use /lib/ld-musl-x32.so.1 for… (authored by MaskRay). Repository: rG LLVM Github

[clang] ed95655 - [Triple][Driver] Add muslx32 environment and use /lib/ld-musl-x32.so.1 for -dynamic-linker

Author: Fangrui Song Date: 2021-03-25T16:25:47-07:00 New Revision: ed956554f96c0a37cc1f1291dbad303d3f1d495c URL: https://github.com/llvm/llvm-project/commit/ed956554f96c0a37cc1f1291dbad303d3f1d495c DIFF: https://github.com/llvm/llvm-project/commit/ed956554f96c0a37cc1f1291dbad303d3f1d495c.diff

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

keryell added a comment. > ! In D99190#2650326 , @bader wrote: > > 2. I'm looking for suggestions on "OpenCL extensions" clarification. I said that "OpenCL extensions" are misleading because it can be understood as either extensions inside OpenCL

[PATCH] D99386: [compiler-rt][hwasan] Add definition for Symbolizer::SymbolizeFrame

leonardchan created this revision. leonardchan added reviewers: mcgrathr, phosek. leonardchan added a project: Sanitizers. Herald added a subscriber: dberris. leonardchan requested review of this revision. Herald added a subscriber: Sanitizers. This is undefined if `SANITIZER_SYMBOLIZER_MARKUP`

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

mcgrathr added a comment. I don't think this is warranted. There should not be any references to such things when building for Fuchsia. This looks like it's intended to satisfy one reference in dead code in hwasan_interceptors.cpp. I think the right solution is just to refactor the hwasan code

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, pcc, eugenis. leonardchan added a project: Sanitizers. Herald added a subscriber: dberris. leonardchan requested review of this revision. Herald added a subscriber: Sanitizers. Fuchsia has it's own platform limits

[PATCH] D98146: OpaquePtr: Turn inalloca into a type attribute

rnk accepted this revision. rnk added a comment. This looks good from my PoV but make sure all of David's oustanding concerns are addressed. I think we hoped that the preallocated feature would have replaced inalloca before the opaque type pointer transition happened, but there's no reason to

[PATCH] D82880: [clang] Handle 128-bits IntegerLiterals in StmtPrinter

aaron.ballman closed this revision. aaron.ballman added a comment. In D82880#2651698 , @davidstone wrote: > In D82880#2651219 , @aaron.ballman > wrote: > >> Do you need me to commit on your behalf? If so, which

[clang] 4b5baa5 - Handle 128-bits IntegerLiterals in StmtPrinter

Author: David Stone Date: 2021-03-25T17:27:13-04:00 New Revision: 4b5baa5b8244778b0e7253cdb98924c3dab611b7 URL: https://github.com/llvm/llvm-project/commit/4b5baa5b8244778b0e7253cdb98924c3dab611b7 DIFF: https://github.com/llvm/llvm-project/commit/4b5baa5b8244778b0e7253cdb98924c3dab611b7.diff

[PATCH] D98892: [HWASan] Mention x86_64 aliasing mode in design doc.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e0bb21931db: [HWASan] Mention x86_64 aliasing mode in design doc. (authored by morehouse). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 8e0bb21 - [HWASan] Mention x86_64 aliasing mode in design doc.

Author: Matt Morehouse Date: 2021-03-25T14:22:20-07:00 New Revision: 8e0bb21931db80ca2f1f4f3e47c1d9d71943064a URL: https://github.com/llvm/llvm-project/commit/8e0bb21931db80ca2f1f4f3e47c1d9d71943064a DIFF:

[PATCH] D95984: [CodeGen] Fix codegen for __attribute__((swiftasynccall)).

varungandhi-apple updated this revision to Diff 333421. varungandhi-apple added a comment. Fix codegen + add tests for methods and function pointers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95984/new/ https://reviews.llvm.org/D95984 Files:

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. @fhahn Are you still at this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96418/new/ https://reviews.llvm.org/D96418

[PATCH] D99344: [Analyzer] Track RValue expressions

NoQ added a comment. I think this is a good targeted fix for that problem we've discussed, demonstrated by tests. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:119-124 +/// Attempts to add visitors to track an RValue expression back to

[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf490a5969bd5: [OpenMP][InstrProfiling] Fix a missing instr profiling counter (authored by lxfind). Repository: rG LLVM Github Monorepo CHANGES

[clang] f490a59 - [OpenMP][InstrProfiling] Fix a missing instr profiling counter

Author: Xun Li Date: 2021-03-25T13:52:36-07:00 New Revision: f490a5969bd52c8a48586f134ff8f02ccbb295b3 URL: https://github.com/llvm/llvm-project/commit/f490a5969bd52c8a48586f134ff8f02ccbb295b3 DIFF: https://github.com/llvm/llvm-project/commit/f490a5969bd52c8a48586f134ff8f02ccbb295b3.diff LOG:

[PATCH] D82880: [clang] Handle 128-bits IntegerLiterals in StmtPrinter

davidstone added a comment. In D82880#2651219 , @aaron.ballman wrote: > Do you need me to commit on your behalf? If so, which email address would you > like me to use for attribution? Yeah, I do not have commit access. davidfromonl...@gmail.com, please

[PATCH] D97993: [Driver] Suppress GCC detection under -B

MaskRay added a comment. In D97993#2644664 , @thakis wrote: > Also broke something in chromium: > https://bugs.chromium.org/p/chromium/issues/detail?id=1191244 (since fixed by > switching something from `-B` to `--gcc-toolchain`. This only landed 4 days

[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

ABataev accepted this revision. ABataev added a comment. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98135/new/ https://reviews.llvm.org/D98135 ___ cfe-commits mailing list

[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

lxfind updated this revision to Diff 333417. lxfind added a comment. This revision is now accepted and ready to land. check null on S Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98135/new/ https://reviews.llvm.org/D98135 Files:

[clang] 622f8de - PR49724: Fix deduction of null member pointers.

Author: Richard Smith Date: 2021-03-25T13:47:22-07:00 New Revision: 622f8de4f25136630007ce70915da4ef5321d080 URL: https://github.com/llvm/llvm-project/commit/622f8de4f25136630007ce70915da4ef5321d080 DIFF: https://github.com/llvm/llvm-project/commit/622f8de4f25136630007ce70915da4ef5321d080.diff

[PATCH] D99227: [Coroutine][Clang] Force emit lifetime intrinsics for Coroutines

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc7a39c833af1: [Coroutine][Clang] Force emit lifetime intrinsics for Coroutines (authored by lxfind). Repository: rG LLVM Github Monorepo CHANGES

[clang] c7a39c8 - [Coroutine][Clang] Force emit lifetime intrinsics for Coroutines

Author: Xun Li Date: 2021-03-25T13:46:20-07:00 New Revision: c7a39c833af173a7797692757b13b4b8eb801acd URL: https://github.com/llvm/llvm-project/commit/c7a39c833af173a7797692757b13b4b8eb801acd DIFF: https://github.com/llvm/llvm-project/commit/c7a39c833af173a7797692757b13b4b8eb801acd.diff LOG:

[PATCH] D99227: [Coroutine][Clang] Force emit lifetime intrinsics for Coroutines

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99227/new/ https://reviews.llvm.org/D99227

[clang] 1abaadb - [clang][driver] Support HWASan in the Fuchsia toolchain

Author: Leonard Chan Date: 2021-03-25T13:36:23-07:00 New Revision: 1abaadb30d37e229eedb0e2ede6cd7f788aed76b URL: https://github.com/llvm/llvm-project/commit/1abaadb30d37e229eedb0e2ede6cd7f788aed76b DIFF: https://github.com/llvm/llvm-project/commit/1abaadb30d37e229eedb0e2ede6cd7f788aed76b.diff

[PATCH] D99361: [clang][driver] Support HWASan in the Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG1abaadb30d37: [clang][driver] Support HWASan in the Fuchsia toolchain (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99361/new/

[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

ABataev added a comment. In D98135#2651193 , @lxfind wrote: > In D98135#2650940 , @ABataev wrote: > >> In D98135#2650914 , @lxfind wrote: >> >>> @ABataev, wondering if you

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

keryell added a comment. Herald added subscribers: jansvoboda11, dang, sstefan1, yaxunl. By looking at this, did we forgot about adding some documentation along what we have for https://clang.llvm.org/docs/ClangOffloadBundler.html ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D99372: [OpenMP][NFC] Generate check lines with update script

ABataev added inline comments. Comment at: clang/test/OpenMP/cancel_codegen.cpp:83 +// OMP-LABEL: @main( +// OMP-NEXT: entry: +// OMP-NEXT:[[RETVAL:%.*]] = alloca i32, align 4 I think it may fail in release mode, where no symbol names are generated. Need

[PATCH] D99372: [OpenMP][NFC] Generate check lines with update script

jdoerfert created this revision. jdoerfert added reviewers: AMDChirag, fghanim, ggeorgakoudis, ABataev. Herald added subscribers: jfb, guansong, yaxunl. Herald added a reviewer: bollu. jdoerfert requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang.

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Frontend/Rewrite/FrontendActions.cpp:190 + std::unique_ptr OS = CI.createDefaultOutputFile( + /*Binary=*/llvm::Triple(LLVM_HOST_TRIPLE).isOSWindows(), + getCurrentFileOrBufferName());

[PATCH] D99301: [HIP] add __builtin_get_device_side_mangled_name

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc9477166a53: [CUDA][HIP] add __builtin_get_device_side_mangled_name (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D99301?vs=333296=91#toc

[clang] cc94771 - [CUDA][HIP] add __builtin_get_device_side_mangled_name

Author: Yaxun (Sam) Liu Date: 2021-03-25T15:25:29-04:00 New Revision: cc9477166a53faced47cbd4146ac4adea431ccfd URL: https://github.com/llvm/llvm-project/commit/cc9477166a53faced47cbd4146ac4adea431ccfd DIFF:

[PATCH] D99368: [compiler-rt][hwasan] Add C++17 new/delete operators with alignment

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, pcc, eugenis. leonardchan added a project: Sanitizers. Herald added a subscriber: dberris. leonardchan requested review of this revision. Herald added a subscriber: Sanitizers. Found that these were missing when

[PATCH] D99361: [clang][driver] Support HWASan in the Fuchsia toolchain

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99361/new/ https://reviews.llvm.org/D99361 ___

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

jsji added a comment. In D99250#2651335 , @dblaikie wrote: > In D99250#2651294 , @jsji wrote: > >> In D99250#2651207 , @dblaikie wrote: >> >>> But if folks supporting

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99363/new/ https://reviews.llvm.org/D99363 ___

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

dblaikie added a comment. In D99250#2651294 , @jsji wrote: > In D99250#2651207 , @dblaikie wrote: > >> But if folks supporting previous builds of DBX are likely going to need a >> bunch of other compatibility work

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

abhina.sreeskantharajan updated this revision to Diff 82. abhina.sreeskantharajan added a comment. Revert changes that cause errors instead by turning on binary mode again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99363/new/

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

rnk requested changes to this revision. rnk added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Frontend/Rewrite/FrontendActions.cpp:190 + std::unique_ptr OS = CI.createDefaultOutputFile( +

[PATCH] D99360: [OpenMP][WIP] Add standard notes for ELF offload images

vzakhari updated this revision to Diff 78. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99360/new/ https://reviews.llvm.org/D99360 Files: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp llvm/include/llvm/BinaryFormat/ELF.h llvm/tools/llvm-readobj/ELFDumper.cpp

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

jsji added a comment. In D99250#2651207 , @dblaikie wrote: > But if folks supporting previous builds of DBX are likely going to need a > bunch of other compatibility work - then maybe adding the debugger tuning may > be suitable/necessary/worthwhile at

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan added a comment. In D97785#2651008 , @amccarth wrote: > When changing an IO stream's mode from binary to text breaks only Windows, > it's likely due to the fact that Windows uses CR+LF as the newline indicator. > Not only are

[PATCH] D96363: Mark output as text if it is really text

abhina.sreeskantharajan added a comment. In D96363#2651116 , @rnk wrote: > In D96363#2650999 , > @abhina.sreeskantharajan wrote: > >> Right, adding a new flag like OF_TextNoCrlf is something I can look into as >>

[PATCH] D99364: [clang][cache] Update Fuchsia-stage2.cmake to create hwasan multilibs

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a subscriber: mgorny. leonardchan requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99364 Files:

[PATCH] D99199: Make -fcrash-diagnostics-dir control the Windows (mini-)dump location

rnk added a comment. Seems reasonable, but I have a concern about the cc1 line being replicable Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5127 +#ifdef _WIN32 + // Put (mini-)dumps in the same place as other crash diagnostics files. I guess I would

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan added reviewers: rnk, amccarth, yroux, aganea. Herald added a subscriber: hiraditya. abhina.sreeskantharajan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[clang] 33930a0 - [clang] Pass option directly to command. NFC

Author: Shoaib Meenai Date: 2021-03-25T11:36:06-07:00 New Revision: 33930a0787f6007ba7ebf36384115bebb412e08a URL: https://github.com/llvm/llvm-project/commit/33930a0787f6007ba7ebf36384115bebb412e08a DIFF: https://github.com/llvm/llvm-project/commit/33930a0787f6007ba7ebf36384115bebb412e08a.diff

[clang] 0135bc9 - [clang] Always execute multi-stage install steps

Author: Shoaib Meenai Date: 2021-03-25T11:36:00-07:00 New Revision: 0135bc996d82ff68677820c421b4d666590e4f31 URL: https://github.com/llvm/llvm-project/commit/0135bc996d82ff68677820c421b4d666590e4f31 DIFF: https://github.com/llvm/llvm-project/commit/0135bc996d82ff68677820c421b4d666590e4f31.diff

[PATCH] D99322: [clang] Pass option directly to command. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33930a0787f6: [clang] Pass option directly to command. NFC (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99321: [clang] Always execute multi-stage install steps

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0135bc996d82: [clang] Always execute multi-stage install steps (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D82880: [clang] Handle 128-bits IntegerLiterals in StmtPrinter

aaron.ballman added a comment. Do you need me to commit on your behalf? If so, which email address would you like me to use for attribution? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82880/new/ https://reviews.llvm.org/D82880

[PATCH] D99361: [clang][driver] Support HWASan in the Fuchsia toolchain

leonardchan created this revision. leonardchan added reviewers: mcgrathr, phosek. leonardchan added a project: clang. leonardchan requested review of this revision. These contain clang driver changes for supporting HWASan on Fuchsia. This includes hwasan multilibs and the dylib path change.

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

dblaikie added a comment. But if folks supporting previous builds of DBX are likely going to need a bunch of other compatibility work - then maybe adding the debugger tuning may be suitable/necessary/worthwhile at this point. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

dblaikie added a comment. Does anyone else have a DWARFv3 consumer they care about? (@aprantl and @probinson) Does anyone have a DWARF consumer that changes significantly based on the language version (I guess lldb (@aprantl can you confirm?)? I doubt gdb does (yeah, it just treats all C++

[PATCH] D82880: [clang] Handle 128-bits IntegerLiterals in StmtPrinter

davidstone updated this revision to Diff 69. davidstone added a comment. Reformatted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82880/new/ https://reviews.llvm.org/D82880 Files: clang/lib/AST/StmtPrinter.cpp

[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

lxfind added a comment. In D98135#2650940 , @ABataev wrote: > In D98135#2650914 , @lxfind wrote: > >> @ABataev, wondering if you have a timeline on this? >> Missing counters from OMP functions sometimes cause

[PATCH] D99360: [OpenMP][WIP] Add standard notes for ELF offload images

vzakhari created this revision. vzakhari added a project: OpenMP. Herald added subscribers: kerbowa, rupprecht, guansong, yaxunl, mgorny, nhaehnle, jvesely. Herald added a reviewer: alexshap. Herald added a reviewer: jhenderson. vzakhari requested review of this revision. Herald added

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

jsji added a comment. I also agree that consumer *SHOULD* handle the unexpected value better. eg: newer DBX will handle such failures better. However, there are situations that the end user might not get up to date debugger, then the user experiences will be BAD. If updating these tags

[PATCH] D96363: Mark output as text if it is really text

rnk added a comment. In D96363#2650999 , @abhina.sreeskantharajan wrote: > Right, adding a new flag like OF_TextNoCrlf is something I can look into as a > solution. However, if Windows is always using binary mode and has no use for > OF_Text flag,

[PATCH] D93822: [clang-tidy] Add check for implicit widening of multiplication result

lebedev.ri updated this revision to Diff 57. lebedev.ri retitled this revision from "[clang][Sema] Add diagnostics for implicit widening of multiplication result" to "[clang-tidy] Add check for implicit widening of multiplication result". lebedev.ri edited the summary of this revision.

[PATCH] D99291: [AIX] Support init priority attribute

Xiangling_L updated this revision to Diff 58. Xiangling_L marked an inline comment as done. Xiangling_L added a comment. Add assertion to make sure we have correct priority value in range; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99291/new/ https://reviews.llvm.org/D99291

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. usaxena95 marked an inline comment as done. Closed by commit rGaa979084dffb: [clang][Syntax] Optimize expandedTokens for token ranges. (authored by usaxena95).

[clang] aa97908 - [clang][Syntax] Optimize expandedTokens for token ranges.

Author: Utkarsh Saxena Date: 2021-03-25T18:54:15+01:00 New Revision: aa979084dffba86a3e170826b4e89d90820bb78b URL: https://github.com/llvm/llvm-project/commit/aa979084dffba86a3e170826b4e89d90820bb78b DIFF:

[PATCH] D99344: [Analyzer] Track RValue expressions

martong marked an inline comment as done. martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:119-124 +/// Attempts to add visitors to track an RValue expression back to its point of +/// origin. Works similarly

[PATCH] D99344: [Analyzer] Track RValue expressions

martong updated this revision to Diff 47. martong added a comment. - Assert in the callee and check in the caller - Fix typo in comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99344/new/ https://reviews.llvm.org/D99344 Files:

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

amccarth added a comment. When changing an IO stream's mode from binary to text breaks only Windows, it's likely due to the fact that Windows uses CR+LF as the newline indicator. Not only are the CRs sometimes unexpected, they can also throw off code that tries to seek to a computed file

[PATCH] D99344: [Analyzer] Track RValue expressions

martong updated this revision to Diff 46. martong added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99344/new/ https://reviews.llvm.org/D99344 Files:

[PATCH] D96363: Mark output as text if it is really text

abhina.sreeskantharajan added a comment. In D96363#2650904 , @rnk wrote: > This is why, in the past, we have taken the direction of opening all files as > binary files. You have probably noticed all of the changes in this direction > that you have to

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

dblaikie added a comment. My 2c: I don't have super strong feelings either way about this particular issue. Yes, I agree a consumer shouldn't crash and probably should handle an unknown language code fairly gracefully - but equally it's a loss of quality for a conforming DWARFv3 consumer to

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

usaxena95 updated this revision to Diff 44. usaxena95 marked 4 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99086/new/ https://reviews.llvm.org/D99086 Files:

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

awarzynski added a subscriber: protze.joachim. awarzynski added a comment. I've not had a chance to add tests yet. I will add them shortly. @protze.joachim , hopefully this addresses the issues that you raised in https://reviews.llvm.org/D95460. Please, could you verify before I update this? I

[clang-tools-extra] 7f5abb6 - [clangd] Fix a use-after-free

Author: Kadir Cetinkaya Date: 2021-03-25T18:26:17+01:00 New Revision: 7f5abb63733238b89cf5d47116b2af68cda2af4e URL: https://github.com/llvm/llvm-project/commit/7f5abb63733238b89cf5d47116b2af68cda2af4e DIFF:

[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

ABataev added a comment. In D98135#2650914 , @lxfind wrote: > @ABataev, wondering if you have a timeline on this? > Missing counters from OMP functions sometimes cause llvm-cov to crash because > of data inconsistency. Cannot answer right now. It would

[PATCH] D99343: [Analyzer] Infer 0 value when the divisible is 0 (bug fix)

vsavchenko added a comment. Awesome! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99343/new/ https://reviews.llvm.org/D99343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99343: [Analyzer] Infer 0 value when the divisible is 0 (bug fix)

This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rG015c39882ebc: [Analyzer] Infer 0 value when the divisible is 0 (bug fix) (authored by martong). Changed prior to commit:

[clang] 015c398 - [Analyzer] Infer 0 value when the divisible is 0 (bug fix)

Author: Gabor Marton Date: 2021-03-25T18:25:06+01:00 New Revision: 015c39882ebc1771713a7523ae76903ebae83288 URL: https://github.com/llvm/llvm-project/commit/015c39882ebc1771713a7523ae76903ebae83288 DIFF: https://github.com/llvm/llvm-project/commit/015c39882ebc1771713a7523ae76903ebae83288.diff

[PATCH] D98638: [RFC][Coroutine] Force stack allocation after await_suspend() call

lxfind abandoned this revision. lxfind added a comment. Abandoning in favor of D99227 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98638/new/ https://reviews.llvm.org/D98638

[PATCH] D99343: [Analyzer] Infer 0 value when the divisible is 0 (bug fix)

martong marked an inline comment as done. martong added a comment. Thanks for the review! Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:655 return makeSymExprValNN(op, InputLHS, InputRHS, resultTy); + case BO_Div: case BO_Rem:

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

awarzynski created this revision. Herald added a reviewer: sscalpone. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds extra logic in Driver::ParseArgStrings so that `clang` (Clang's compiler driver) generates a

[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

lxfind added a comment. @ABataev, wondering if you have a timeline on this? Missing counters from OMP functions sometimes cause llvm-cov to crash because of data inconsistency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98135/new/

[PATCH] D99227: [Coroutine][Clang] Force emit lifetime intrinsics for Coroutines

lxfind updated this revision to Diff 38. lxfind added a comment. Address comments, and fix all tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99227/new/ https://reviews.llvm.org/D99227 Files: clang/lib/CodeGen/CGCoroutine.cpp

[PATCH] D96363: Mark output as text if it is really text

rnk added a comment. This is why, in the past, we have taken the direction of opening all files as binary files. You have probably noticed all of the changes in this direction that you have to work around. I think the best solution here would be to add a new `OF_TextNoCrlf` mode that does what

Re: [PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

On Thu, 25 Mar 2021 at 18:13, Abhina Sree via Phabricator < revi...@reviews.llvm.org> wrote: > abhina.sreeskantharajan added a comment. > > In D97785#2650824 , @yroux wrote: > > > Hi Abhina, > > > > I think this patch broke Windows on ARM bots, the first

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan added a comment. In D97785#2650824 , @yroux wrote: > Hi Abhina, > > I think this patch broke Windows on ARM bots, the first failure observed 6 > days ago in this build: > > https://lab.llvm.org/buildbot/#/builders/65/builds/1245 >

[PATCH] D97119: [flang][driver] Add options for -std=f2018

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c7ebf79e923: [flang][driver] Add options for -std=f2018 (authored by arnamoy10). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4c7ebf7 - [flang][driver] Add options for -std=f2018

Author: Arnamoy Bhattacharyya Date: 2021-03-25T13:03:16-04:00 New Revision: 4c7ebf79e923072e8d298134e6ca04618fe4eba9 URL: https://github.com/llvm/llvm-project/commit/4c7ebf79e923072e8d298134e6ca04618fe4eba9 DIFF:

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

probinson added a comment. I think there are degrees of compatibility with regard to DWARF, which is inherently supposed to be extensible if the extension can be safely ignored by a consumer. This is the "permissive" rule in the standard. - A new FORM must *never* be used, because that makes

Re: [PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

I Abhina, I think this patch broke Windows on ARM bots, the first failure observed 6 days ago in this build: https://lab.llvm.org/buildbot/#/builders/65/builds/1245 I don't really get what the problem is, but the issue is related to tablegen generated file AbstractTypeReader.inc and your patch

  1   2   >