[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 336316. haberman added a comment. - Rename and refine IgnoreElidableImplicitConstructorSingleStep(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 Files:

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2828-2829 + "%0 attribute requires that the return value, all parameters, and any " + "temporaries created by the expression are trivially destructible and " + "do not require ARC">;

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 336310. haberman marked 3 inline comments as done. haberman added a comment. - Refined the implicit constructor skipping code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/

[PATCH] D97264: [RISCV] Define types for Zvlsseg.

HsiangKai added a comment. In D97264#2663082 , @rogfer01 wrote: > I was under the impression we didn't want to use class-member access syntax > for vector tuples (see > https://github.com/riscv/rvv-intrinsic-doc/issues/17#issuecomment-628998077 ) > so

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added a comment. Hi @craig.topper and @skan , THX for review! I tested that deleting sgx indeed leads to not generating "+sgx" in 'target-features', didn't know before:) '+sgx' is not a recognized feature for this target (ignoring feature) Repository: rG LLVM Github Monorepo

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe updated this revision to Diff 336303. FreddyYe added a comment. revert clang-format and revert deleting FeatureSGX def. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 Files:

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe updated this revision to Diff 336301. FreddyYe added a comment. cancel the clang-format in constexpr ProcInfo Processors[] = {} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 Files:

[PATCH] D100085: [X86] Support -march=rocketlake

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86.td:271-273 -def FeatureSGX : SubtargetFeature<"sgx", "HasSGX", "true", - "Enable Software Guard Extensions">; def FeatureCLFLUSHOPT : SubtargetFeature<"clflushopt",

[PATCH] D100161: Redistribute energy for Corpus

gtt1995 created this revision. gtt1995 added reviewers: 01alchemist, 0b01. gtt1995 requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Divide the corpus into n parts according to size. Each job executes each corpus in

[PATCH] D100085: [X86] Support -march=rocketlake

skan added inline comments. Comment at: llvm/lib/Target/X86/X86.td:271-273 -def FeatureSGX : SubtargetFeature<"sgx", "HasSGX", "true", - "Enable Software Guard Extensions">; def FeatureCLFLUSHOPT : SubtargetFeature<"clflushopt",

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added a comment. In D97669#2676826 , @Anastasia wrote: > In D97669#2665865 , @benshi001 wrote: > >> In D97669#2661560 , @Anastasia >> wrote: >> >>> Is `stdio.h`

[PATCH] D100085: [X86] Support -march=rocketlake

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86.td:271 "Invalidate Process-Context Identifier">; -def FeatureSGX : SubtargetFeature<"sgx", "HasSGX", "true", - "Enable Software

[PATCH] D100085: [X86] Support -march=rocketlake

skan added inline comments. Comment at: llvm/lib/Support/X86TargetParser.cpp:293-301 +// Empty processor. Include X87 and CMPXCHG8 for backwards compatibility. +{{""}, CK_None, ~0U, FeatureX87 | FeatureCMPXCHG8B}, +// i386-generation processors. +{{"i386"},

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe updated this revision to Diff 336295. FreddyYe added a comment. delete FeatureSGX in the backend since there are no IR intrinsics for SGX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 Files:

[clang] ca55f05 - [clang][SourceManager] Fix -Wparentheses warning (NFC)

Author: Yang Fan Date: 2021-04-09T10:22:56+08:00 New Revision: ca55f0511698e5b64538e02eff9f6b2280282b15 URL: https://github.com/llvm/llvm-project/commit/ca55f0511698e5b64538e02eff9f6b2280282b15 DIFF: https://github.com/llvm/llvm-project/commit/ca55f0511698e5b64538e02eff9f6b2280282b15.diff

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:767 + // Rocketlake + list RKLAdditionalFeatures = [FeatureAES, + FeatureXSAVEC, craig.topper wrote: > FreddyYe wrote: > > craig.topper

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:790 + FeatureFSRM]; + list RKLTuning = ICLTuning; + list RKLFeatures = RKSimon wrote: > Using ICLTuning suggests we should still be avoiding

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

brooksmoses added a comment. In D99790#2677919 , @lebedev.ri wrote: > In D99790#2677917 , @brooksmoses > wrote: > >> As a heads up, I'm seeing segfaults on internal code as a result of this >> change, as well as

[clang] eb8a28e - DebugInfo: Include inline namespaces in template specialization parameter names

Author: David Blaikie Date: 2021-04-08T17:37:55-07:00 New Revision: eb8a28e2cf033f2bfbfe33a0bd0d9e75a12e2679 URL: https://github.com/llvm/llvm-project/commit/eb8a28e2cf033f2bfbfe33a0bd0d9e75a12e2679 DIFF: https://github.com/llvm/llvm-project/commit/eb8a28e2cf033f2bfbfe33a0bd0d9e75a12e2679.diff

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

Holman updated this revision to Diff 336274. Holman set the repository for this revision to rG LLVM Github Monorepo. Holman added a comment. Add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/new/ https://reviews.llvm.org/D4

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2828-2829 + "%0 attribute requires that the return value, all parameters, and any " + "temporaries created by the expression are trivially destructible and " + "do not require ARC">;

[PATCH] D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f181086b5cb: [ASTMatchers] Add `cxxBaseSpecifier` matcher

[clang] 2f18108 - [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level)

Author: Nikita Kniazev Date: 2021-04-09T00:05:36+01:00 New Revision: 2f181086b5cbbe83c4492aa44484a77ed06ec812 URL: https://github.com/llvm/llvm-project/commit/2f181086b5cbbe83c4492aa44484a77ed06ec812 DIFF:

[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

smaslov added a comment. > Sergey, remind me, does icc always emit unaligned loads/stores? Is there any > option to control it? There was a control to emit aligned opcodes, yes, but I don't think anyone ever used it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100150: [Sanitizers] Add a flag -f[no-]sanitize-merge-traps

rnk created this revision. rnk added reviewers: pcc, phosek, rsmith, zequanwu. Herald added subscribers: jansvoboda11, dexonsmith, dang. rnk requested review of this revision. Herald added a project: clang. Without this flag, enabling optimizations causes clang to emit a single ubsantrap for

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

hvdijk created this revision. hvdijk added a reviewer: glaubitz. hvdijk added a project: clang. Herald added subscribers: pengfei, dberris. hvdijk requested review of this revision. Herald added a subscriber: cfe-commits. x86_64-linux-gnu and x86_64-linux-gnux32 use different ABIs and objects

[PATCH] D99368: [compiler-rt][hwasan] Add C++17 new/delete operators with alignment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. leonardchan marked an inline comment as done. Closed by commit rGa7b51d8a4fc8: [compiler-rt][hwasan] Add C++17 new/delete operators with alignment (authored by

[PATCH] D100144: [AMDGPU] Allow relaxed/consume memory order for atomic inc/dec

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Nice. Thank you for fixing the oversight. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100144/new/ https://reviews.llvm.org/D100144

[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

craig.topper added a comment. I think I wouldn't mind if we just didn't emit aligned loads/store instructions for AVX/AVX512 from isel and other places in the compiler in the first place. As noted, if the load gets folded the alignment check doesn't happen. That would reduce the size of the

[PATCH] D100136: Allow applying attributes to subset of allowed subjects.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100136/new/ https://reviews.llvm.org/D100136

[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

smaslov added a comment. > I really don't think this should go in. Here are more arguments for why, I think, this is an useful option in my opinion, in arbitrary order: 1. This was requested by and added for users of Intel Compiler. Having similar option in LLVM would make the two compilers

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

jyknight added a comment. In D99790#2677917 , @brooksmoses wrote: > As a heads up, I'm seeing segfaults on internal code as a result of this > change, as well as errors in Eigen's unalignedassert.cpp test (specifically, > this line asserts: >

[PATCH] D100144: [AMDGPU] Allow relaxed/consume memory order for atomic inc/dec

yaxunl created this revision. yaxunl added a reviewer: JonChesterfield. Herald added subscribers: jfb, t-tye, tpr, dstuttard, jvesely, kzhuravl. yaxunl requested review of this revision. Herald added a subscriber: wdng. https://reviews.llvm.org/D100144 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D100136: Allow applying attributes to subset of allowed subjects.

tra added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:896 + attr::SubjectMatchRule MatchRule = attr::SubjectMatchRule(Rule.first); + if (auto ParentRule = getParentAttrMatcherRule(MatchRule)) { +if (llvm::any_of(StrictSubjectMatchRuleSet,

[PATCH] D100136: Allow applying attributes to subset of allowed subjects.

tra updated this revision to Diff 336236. tra added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100136/new/ https://reviews.llvm.org/D100136 Files: clang/lib/Sema/SemaAttr.cpp

[PATCH] D99368: [compiler-rt][hwasan] Add C++17 new/delete operators with alignment

eugenis accepted this revision. eugenis added a comment. LGTM Comment at: compiler-rt/lib/hwasan/hwasan_new_delete.cpp:104 +INTERCEPTOR_ATTRIBUTE SANITIZER_WEAK_ATTRIBUTE void operator delete( +void *ptr, std::align_val_t align)NOEXCEPT { + OPERATOR_DELETE_BODY;

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

lebedev.ri added a comment. In D99790#2677917 , @brooksmoses wrote: > As a heads up, I'm seeing segfaults on internal code as a result of this > change, as well as errors in Eigen's unalignedassert.cpp test (specifically, > this line asserts: >

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

brooksmoses added a comment. As a heads up, I'm seeing segfaults on internal code as a result of this change, as well as errors in Eigen's unalignedassert.cpp test (specifically, this line asserts: https://github.com/madlib/eigen/blob/master/test/unalignedassert.cpp#L151). Repository: rG

[PATCH] D99368: [compiler-rt][hwasan] Add C++17 new/delete operators with alignment

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM but you should wait a bit for @pcc or @eugenis to have a chance to to review this as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100136: Allow applying attributes to subset of allowed subjects.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:896 + attr::SubjectMatchRule MatchRule = attr::SubjectMatchRule(Rule.first); + if (auto ParentRule = getParentAttrMatcherRule(MatchRule)) { +if (llvm::any_of(StrictSubjectMatchRuleSet,

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

rnk added a comment. Seems reasonable, but we still need a small IR test. Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:807 // TODO: Figure out which other flags need to be set. + if (MMI->getModule()->getProfileSummary(/* IsCS */ false) != nullptr) { +

[PATCH] D100139: [ifs][elfabi] Merge llvm-ifs/elfabi tools

haowei created this revision. haowei added reviewers: phosek, plotfi, compnerd, mcgrathr. Herald added subscribers: hiraditya, mgorny. haowei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This change merges llvm-elfabi

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

krisb added a comment. Do we still need the following tests: - clang/test/CXX/temp/temp.spec/temp.explicit/p11.cpp - clang/test/CXX/temp/temp.spec/temp.explicit/p12.cpp ? Comment at: clang/test/CXX/temp/temp.spec/func.spec.cpp:105 +template void func10(A::B, int x) {}

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

Holman updated this revision to Diff 336223. Holman added a comment. Get PGO info from Module instead of adding new field to debug info. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/new/ https://reviews.llvm.org/D4 Files: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp

[PATCH] D100087: Include `count` in AppleClang toolchains.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf66e05a720f7: Include `count` in AppleClang toolchains. (authored by delcypher). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100087/new/

[clang] f66e05a - Include `count` in AppleClang toolchains.

Author: Dan Liew Date: 2021-04-08T14:00:29-07:00 New Revision: f66e05a720f74409790bdede308380909f2ecd86 URL: https://github.com/llvm/llvm-project/commit/f66e05a720f74409790bdede308380909f2ecd86 DIFF: https://github.com/llvm/llvm-project/commit/f66e05a720f74409790bdede308380909f2ecd86.diff

[PATCH] D100136: Allow applying attributes to subset of allowed subjects.

tra updated this revision to Diff 336212. tra added a comment. Updated Sema/pragma-attribute-strict-subjects.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100136/new/ https://reviews.llvm.org/D100136 Files: clang/lib/Sema/SemaAttr.cpp

[PATCH] D100136: Allow applying attributes to subset of allowed subjects.

tra created this revision. tra added reviewers: rsmith, arphaman. Herald added a subscriber: bixia. tra requested review of this revision. Herald added a project: clang. The original intent of enforcing exact match between `apply_to` and the attribute's was to `ensure that the user will know

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman marked 2 inline comments as done. haberman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:561-568 + for (const auto *A : Attrs) { +if (A->getKind() == attr::MustTail) { + if (!checkMustTailAttr(SubStmt, *A)) { +return SubStmt; + }

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 336203. haberman added a comment. - Formatted files with clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 Files: clang/include/clang/AST/Expr.h

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

Holman added a comment. In D4#2677566 , @rnk wrote: > IMO it's best to avoid adding fields to DICompileUnit if at all possible. > It's the "god object" / "katamari damacy" of module debug info. Is there > something about the IR module that indicates

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

aaron.ballman added a comment. In D75844#2677457 , @brooksmoses wrote: > FWIW, this now causes Clang to produce an error on this code, when it didn't > before: > > using namespace::foo __attribute__((deprecated("message"))); > > I discussed this with

[PATCH] D100129: Tiny format fix

bruno accepted this revision. bruno added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100129/new/ https://reviews.llvm.org/D100129 ___ cfe-commits mailing list

[clang] 189310a - [AMDGPU] Allow -amdgpu-unsafe-fp-atomics to ignore denorm mode

Author: Stanislav Mekhanoshin Date: 2021-04-08T12:46:36-07:00 New Revision: 189310a140fa1c33f8f4838560f567bab9e99245 URL: https://github.com/llvm/llvm-project/commit/189310a140fa1c33f8f4838560f567bab9e99245 DIFF:

[PATCH] D99291: [AIX] Support init priority attribute

This revision was automatically updated to reflect the committed changes. Xiangling_L marked an inline comment as done. Closed by commit rGd5085617986e: [AIX] Support init priority attribute (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d508561 - [AIX] Support init priority attribute

Author: Xiangling Liao Date: 2021-04-08T15:40:09-04:00 New Revision: d5085617986e8ceabe7af02eb9c50f5350b3f980 URL: https://github.com/llvm/llvm-project/commit/d5085617986e8ceabe7af02eb9c50f5350b3f980 DIFF:

[PATCH] D100127: [RISCV][Clang] Add some RVV Permutation intrinsic functions.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100127/new/ https://reviews.llvm.org/D100127

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

rnk added a comment. IMO it's best to avoid adding fields to DICompileUnit if at all possible. It's the "god object" / "katamari damacy" of module debug info. Is there something about the IR module that indicates if PGO data is present or not? We could check that instead. I looked, but I

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha added a comment. The windows build failure is solved by itself and its all passing now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99037/new/ https://reviews.llvm.org/D99037 ___

[PATCH] D99984: [RISCV] Prevent __builtin_riscv_orc_b_64 from being compiled RV32 target.

This revision was automatically updated to reflect the committed changes. Closed by commit rG02ef9963e1ad: [RISCV] Prevent __builtin_riscv_orc_b_64 from being compiled RV32 target. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 02ef996 - [RISCV] Prevent __builtin_riscv_orc_b_64 from being compiled RV32 target.

Author: Craig Topper Date: 2021-04-08T11:34:56-07:00 New Revision: 02ef9963e1ad1e6ded539c830861a074b879dc70 URL: https://github.com/llvm/llvm-project/commit/02ef9963e1ad1e6ded539c830861a074b879dc70 DIFF: https://github.com/llvm/llvm-project/commit/02ef9963e1ad1e6ded539c830861a074b879dc70.diff

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

brooksmoses added a comment. FWIW, this now causes Clang to produce an error on this code, when it didn't before: using namespace::foo __attribute__((deprecated("message"))); I discussed this with Richard Smith, who points out that GCC does not accept this and it's not permitted according

[PATCH] D100057: Remove warning "suggest braces" for aggregate initialization of an empty class with an aggregate base class.

ldionne added a comment. FWIW, I think this is acceptable, but I think even better would be to make it clear in the Standard that this is acceptable. Having spoken with a few folks about this, it doesn't appear to be specified very clearly. CHANGES SINCE LAST ACTION

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

Qix- updated this revision to Diff 336173. Qix- added a comment. Updated the diff to include a lot more context (-U). Thanks again for the tip :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99861/new/ https://reviews.llvm.org/D99861 Files:

[PATCH] D99877: [Clang] Allow processing of attributes on statements by plugins

Qix- updated this revision to Diff 336172. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99877/new/ https://reviews.llvm.org/D99877 Files: clang/include/clang/Sema/ParsedAttr.h clang/lib/Sema/SemaStmtAttr.cpp Index:

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. @krisb Thank you for your comments. I will consider them. Comment at: clang/test/CXX/temp/temp.spec/func.spec.cpp:105 +template void func10(A::B, int x) {} +template void func11(A::C, A::D, int) {} +template void func12() {} krisb

[PATCH] D90157: [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way

NoQ added a comment. I'm catching up and these changes look great. In D90157#2433657 , @steakhal wrote: > I've run the baseline and your patch as well on 15 projects, both with and > without Z3 refutation enabled. > (...) > All in all, I'm still in

[PATCH] D99675: RFC [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

efriedma added a comment. In D99675#2672138 , @kbsmith1 wrote: > In D99675#2671924 , @efriedma wrote: > >> How is llvm.arith.fence() different from using "freeze" on a floating-point >> value? The goal isn't

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

NoQ added a comment. > Which is fairly shocking and mind blowing that we've organically developed > two independent implementations of casting, one for RegionStore and one for > everything else. Wait, no, nvm, please disregard this. It wasn't like this forever, i just happened to catch code

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl added a comment. Any other concerns? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99683/new/ https://reviews.llvm.org/D99683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D100129: Tiny format fix

urnathan created this revision. urnathan added reviewers: rsmith, bruno. urnathan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A mis-indented } in the middle of a function. Repository: rG LLVM Github Monorepo

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

efriedma added a comment. Please add a test for `(char*)0-(char*)0`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D100124: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions

tra added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:460-468 +TARGET_BUILTIN(__nvvm_redux_sync_add_s32, "SiSii", "", SM_80) +TARGET_BUILTIN(__nvvm_redux_sync_min_s32, "SiSii", "", SM_80) +TARGET_BUILTIN(__nvvm_redux_sync_max_s32, "SiSii", "", SM_80)

[PATCH] D99260: [analyzer] Fix false positives in inner pointer checker (PR49628)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG663ac91ed1d6: [analyzer] Fix false positives in inner pointer checker (PR49628) (authored by vsavchenko). Repository: rG LLVM Github Monorepo

[clang] 663ac91 - [analyzer] Fix false positives in inner pointer checker (PR49628)

Author: Valeriy Savchenko Date: 2021-04-08T20:30:12+03:00 New Revision: 663ac91ed1d6156e848e5f5f00cd7e7dd6cf867f URL: https://github.com/llvm/llvm-project/commit/663ac91ed1d6156e848e5f5f00cd7e7dd6cf867f DIFF:

[PATCH] D99181: [analyzer] Fix crash on spaceship operator (PR47511)

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b958dd6bcca: [analyzer] Fix crash on spaceship operator (PR47511) (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99181/new/

[clang] 4b958dd - [analyzer] Fix crash on spaceship operator (PR47511)

Author: Valeriy Savchenko Date: 2021-04-08T20:28:05+03:00 New Revision: 4b958dd6bccab386be432cac99332b867ab9ee22 URL: https://github.com/llvm/llvm-project/commit/4b958dd6bccab386be432cac99332b867ab9ee22 DIFF:

[PATCH] D99995: [OpenMP51] Initial support for masked directive and filter clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5/new/ https://reviews.llvm.org/D5 ___

[PATCH] D99877: [Clang] Allow processing of attributes on statements by plugins

aaron.ballman added a comment. Thank you for the patch! Btw, can you add more context to the patch when you generate it (I usually use `-U 999` when making patches)? The changes look good so far, but I think `docs\ClangPlugins.rst` should be updated to document the new functionality and it

[PATCH] D100085: [X86] Support -march=rocketlake

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86.td:767 + // Rocketlake + list RKLAdditionalFeatures = [FeatureAES, + FeatureXSAVEC, FreddyYe wrote: > craig.topper wrote: > > Is this list

[PATCH] D100127: [RISCV][Clang] Add some RVV Permutation intrinsic functions.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D100120: [RISCV][Clang] Add all RVV Mask intrinsic functions.

craig.topper added a comment. LGTM other than that inheritance question Comment at: clang/include/clang/Basic/riscv_vector.td:247 +list> suffixes_prototypes> { + defm "" : RVVBuiltinSet; +} Can we use inheritance here?

[PATCH] D99260: [analyzer] Fix false positives in inner pointer checker (PR49628)

steakhal added a comment. I'm still not satisfied with the `addressof`, but I won't block this either. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99260/new/ https://reviews.llvm.org/D99260 ___

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha added inline comments. Comment at: clang/test/CodeGen/matrix-cast.c:82 + +void cast_unsigned_short_int_to_unsigned_int(unsigned_short_int_5x5 s, unsigned_int_5x5 i) { + // CHECK-LABEL: define{{.*}} void @cast_unsigned_short_int_to_unsigned_int(<25 x i16> %s, <25 x

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman added a comment. In D99517#2667025 , @rjmccall wrote: > You should structure this code so it's easy to add exceptions for certain > calling conventions that can support tail calls with weaker restrictions > (principally, callee-pop

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha updated this revision to Diff 336154. SaurabhJha added a comment. Addressed latest round of comments. Also rebased with latest main as the windows build failed for some reason Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99037/new/

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 336153. haberman added a comment. - Moved calling convention check to happen as early as possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 Files:

[PATCH] D99260: [analyzer] Fix false positives in inner pointer checker (PR49628)

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great now, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99260/new/ https://reviews.llvm.org/D99260

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:561-568 + for (const auto *A : Attrs) { +if (A->getKind() == attr::MustTail) { + if (!checkMustTailAttr(SubStmt, *A)) { +return SubStmt; + } + setFunctionHasMustTail(); +

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser updated this revision to Diff 336148. jamieschmeiser added a comment. Reformat to satisfy clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sema/pointer-addition.c

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

arichardson added a comment. I just merged this commit into our CHERI fork and noticed some failing tests due to round tripping: We add some additional CodeGenOptions and LangOptions, but are not including those in the generated command line. For example, I added an additional `std::string

[PATCH] D100124: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions

steffenlarsen created this revision. steffenlarsen added reviewers: jdoerfert, jholewinski. Herald added subscribers: hiraditya, yaxunl. steffenlarsen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Adds NVPTX builtins

[PATCH] D99593: [Clang][RISCV] Implement vlseg builtins.

khchen added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:594 auto PType = Transformer.back(); + static unsigned NFCount = 0; switch (PType) { rogfer01 wrote: > Was this meant to be `static` here? Maybe we can create a new complex

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:561-568 + for (const auto *A : Attrs) { +if (A->getKind() == attr::MustTail) { + if (!checkMustTailAttr(SubStmt, *A)) { +return SubStmt; + } + setFunctionHasMustTail(); +}

[PATCH] D99181: [analyzer] Fix crash on spaceship operator (PR47511)

NoQ accepted this revision. NoQ added a comment. Looks great now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99181/new/ https://reviews.llvm.org/D99181 ___ cfe-commits mailing list

[PATCH] D99984: [RISCV] Prevent __builtin_riscv_orc_b_64 from being compiled RV32 target.

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:259 .Case("riscv64", Is64Bit) + .Case("64bit", Is64Bit) .Case("m", HasM) frasercrmck wrote: > craig.topper wrote: > > frasercrmck wrote: > > > What's the

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 336141. haberman added a comment. - Factored duplicated code into a method on MustTailAttr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 Files:

[PATCH] D99995: [OpenMP51] Initial support for masked directive and filter clause

cchen added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2814 } if (CKind == OMPC_ordered && PP.LookAhead(/*N=*/0).isNot(tok::l_paren)) ABataev wrote: > This can be simplified like this: > ``` > if (!FirstClause) { >

[PATCH] D99984: [RISCV] Prevent __builtin_riscv_orc_b_64 from being compiled RV32 target.

frasercrmck accepted this revision. frasercrmck added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Basic/Targets/RISCV.cpp:259 .Case("riscv64", Is64Bit) + .Case("64bit", Is64Bit) .Case("m", HasM)

[PATCH] D100118: [clang] RFC Support new arithmetic __fence builtin to control floating point optiization

mibintc created this revision. mibintc added a reviewer: kpn. Herald added a subscriber: jfb. mibintc requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. This is a proposal to add a new clang builtin, __arithmetic_fence. The purpose of

  1   2   >