[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added a comment. Hi @MaskRay , I tried to refactor the test file by assembling the common CHECKs. But I found it will lead to too many check-prefixes ine one RUN line. For example, // RUN: %clang -march=c3 -m32 -E -dM %s -o - 2>&1 \ // RUN: -target i386-unknown-linux \ //

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe updated this revision to Diff 336133. FreddyYe added a comment. Herald added a subscriber: jfb. update lit test and clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 Files:

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 336130. haberman added a comment. - Added FIXME for attribute refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 Files: clang/include/clang/AST/Expr.h

[PATCH] D97116: Reduce the number of attributes attached to each function

xbolva00 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:496 //function. - CurFn->addFnAttr("min-legal-vector-width", llvm::utostr(LargestVectorWidth)); + if (LargestVectorWidth) +CurFn->addFnAttr("min-legal-vector-width",

[PATCH] D99984: [RISCV] Prevent __builtin_riscv_orc_b_64 from being compiled RV32 target.

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:259 .Case("riscv64", Is64Bit) + .Case("64bit", Is64Bit) .Case("m", HasM) frasercrmck wrote: > What's the difference between this new feature and `riscv64` above?

[PATCH] D99964: [RISCV][Clang] Add all RVV Reduction intrinsic functions.

khchen updated this revision to Diff 336123. khchen added a comment. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99964/new/ https://reviews.llvm.org/D99964 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D99669: [RISCV][Clang] Add more RVV Floating-Point intrinsic functions.

khchen updated this revision to Diff 336117. khchen added a comment. rebase. I don't know why `let` cannot overide field when we change instantiate single multiclasses to inheritance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99669/new/

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

Anastasia added a comment. In D97669#2665865 , @benshi001 wrote: > In D97669#2661560 , @Anastasia wrote: > >> Is `stdio.h` used by anything? > > No. `stdio.h` is not used. But if I do `#include `, then `-I >

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

awarzynski added a comment. I've just send an RFC for this change to cfe-dev: https://lists.llvm.org/pipermail/cfe-dev/2021-April/067981.html. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99353/new/ https://reviews.llvm.org/D99353

[PATCH] D99181: [analyzer] Fix crash on spaceship operator (PR47511)

vsavchenko updated this revision to Diff 336108. vsavchenko marked 4 inline comments as done. vsavchenko added a comment. Change produced SVal for the spaceship operator from Undefined to Unknown Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97116: Reduce the number of attributes attached to each function

wxiao3 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:496 //function. - CurFn->addFnAttr("min-legal-vector-width", llvm::utostr(LargestVectorWidth)); + if (LargestVectorWidth) +CurFn->addFnAttr("min-legal-vector-width",

[PATCH] D99668: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions.

khchen updated this revision to Diff 336101. khchen added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99668/new/ https://reviews.llvm.org/D99668 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:561-568 + for (const auto *A : Attrs) { +if (A->getKind() == attr::MustTail) { + if (!checkMustTailAttr(SubStmt, *A)) { +return SubStmt; + } + setFunctionHasMustTail(); +

[PATCH] D99526: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions.

khchen updated this revision to Diff 336100. khchen added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99526/new/ https://reviews.llvm.org/D99526 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D100092: [clang-tidy] cppcoreguidelines-declare-loop-variable-in-the-initializer: a new check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/DeclareLoopVariableInTheInitializerCheck.cpp:28 + + diag(MatchedForStmt->getBeginLoc(), + "Prefer to declare a loop variable in the initializer part of a "

[clang] 9229465 - [NFC] Fix warning introduced in 20105b6b4874a85813f7a4a3d8ad2a0f023dda14

Author: serge-sans-paille Date: 2021-04-08T16:11:01+02:00 New Revision: 9229465bad8504190bdfb92be829cb6c1157fea5 URL: https://github.com/llvm/llvm-project/commit/9229465bad8504190bdfb92be829cb6c1157fea5 DIFF:

[PATCH] D99291: [AIX] Support init priority attribute

Xiangling_L marked an inline comment as done. Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:663 + // Create our global prioritized cleanup function. + if (!PrioritizedCXXStermFinalizers.empty()) { jasonliu wrote: > Just

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield added inline comments. Comment at: clang/include/clang/Driver/Options.td:921 HelpText<"HIP runtime installation path, used for finding HIP version and adding HIP include path.">; +def amdgpu_arch_tool_path_EQ : Joined<["--"], "amdgpu-arch-tool-path=">,

[PATCH] D99262: [analyzer] Fix dead store checker false positive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f0d8bac144c: [analyzer] Fix dead store checker false positive (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 9f0d8ba - [analyzer] Fix dead store checker false positive

Author: Valeriy Savchenko Date: 2021-04-08T16:12:42+03:00 New Revision: 9f0d8bac144c8eb1ca4aff823b2e2d5a0f990072 URL: https://github.com/llvm/llvm-project/commit/9f0d8bac144c8eb1ca4aff823b2e2d5a0f990072 DIFF:

[PATCH] D99260: [analyzer] Fix false positives in inner pointer checker (PR49628)

vsavchenko updated this revision to Diff 336077. vsavchenko added a comment. Require std::data to accept exactly 1 argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99260/new/ https://reviews.llvm.org/D99260 Files:

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

awarzynski updated this revision to Diff 336075. awarzynski added a comment. Refine comments, remove code for aliases (which didn't work anyway) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99353/new/ https://reviews.llvm.org/D99353 Files:

[PATCH] D99995: [OpenMP51] Initial support for masked directive and filter clause

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2814 } if (CKind == OMPC_ordered && PP.LookAhead(/*N=*/0).isNot(tok::l_paren)) This can be simplified like this: ``` if (!FirstClause) { Diag(Tok,

[PATCH] D98499: [clangd] Introduce ASTHooks to FeatureModules

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:237 + if (auto Hook = Mod.astHooks()) { +Inputs.PreambleHooks.emplace_back(std::move(Hook)); +Inputs.MainFileHooks.emplace_back(Mod.astHooks()); Now we're

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

vsavchenko added inline comments. Comment at: clang/unittests/StaticAnalyzer/RangeSetTest.cpp:471 + + // RHS adjacent to LHS in between. + // RHS => ___ I guess I also want to have more cases where ranges from RHS are in between ranges from LHS, also

[PATCH] D100054: Handle flags such as -m32 when computing the prefix for programs/runtime libs

arichardson updated this revision to Diff 336061. arichardson added a comment. Drop chunk that is no longer necessary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100054/new/ https://reviews.llvm.org/D100054 Files:

[PATCH] D100054: Handle flags such as -m32 when computing the prefix for programs/runtime libs

arichardson updated this revision to Diff 336059. arichardson added a comment. Add the raw triple prefix for programs (but prefer the adjusted triple) and always use the adjusted triple for libraries. Should hopefully address the feedback from @joerg. Also improve tests to check that we don't

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Seems fine to me. Might be good for someone else (@aaron.ballman ?) to also take a look, not sure. Thank you. Comment at: clang/lib/CodeGen/CGStmt.cpp:801 +

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

fhahn added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:801 + SourceLocToDebugLoc(R.getEnd()), + loopMustProgress(CondIsConst)); lebedev.ri wrote: > fhahn wrote: > > lebedev.ri wrote: > > > Now this doesn't make

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

vsavchenko added a comment. Well, that is a nice exercise for "two pointer" problems, but can we please talk about the actual use case for it? Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:136 + +RangeSet RangeSet::Factory::unite(RangeSet LHS, RangeSet

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

fhahn updated this revision to Diff 336058. fhahn added a comment. Change names of loopMustProgress to checkIfLoopMustProgress. Same for functionMustProgress. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96418/new/

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui updated this revision to Diff 336057. kamleshbhalui added a comment. Making changes effective only for windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99580/new/ https://reviews.llvm.org/D99580 Files:

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

aqjune added a comment. Thank you all! Incremental change makes sense to me as well. It will help smooth landing without buildbot failures. I'll start writing patches soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82317/new/

[clang] 6e8601f - [OpenCL][Docs] Fix typo in section label

Author: Anastasia Stulova Date: 2021-04-08T10:59:44+01:00 New Revision: 6e8601ff4ae1154e6f7963c70453b4818d7453e0 URL: https://github.com/llvm/llvm-project/commit/6e8601ff4ae1154e6f7963c70453b4818d7453e0 DIFF:

[PATCH] D97116: Reduce the number of attributes attached to each function

lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:496 //function. - CurFn->addFnAttr("min-legal-vector-width", llvm::utostr(LargestVectorWidth)); + if (LargestVectorWidth) +CurFn->addFnAttr("min-legal-vector-width",

[PATCH] D99501: ignore -flto= options recognized by GCC

fhahn added a comment. In D99501#2668774 , @lebedev.ri wrote: > Tests missing. > This somehow wasn't sent to cfe-commits list @doko could you add a test? e.g. in `clang/test/Driver/clang_f_opts.c`, which already contains a check for `-ffat-lto-objects`

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski added a comment. In D99645#2674496 , @kiranchandramohan wrote: > LGTM. > > Might be good to have a test for fdebug-dump-parse-tree-no-sema. Good point, added before merging into main! Thank you for reviewing. Repository: rG LLVM Github

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe81b3401177a: [flang][driver] Add debug options not requiring semantic checks (authored by awarzynski). Changed prior to commit:

[clang] e81b340 - [flang][driver] Add debug options not requiring semantic checks

Author: Andrzej Warzynski Date: 2021-04-08T09:44:19Z New Revision: e81b3401177a67481605447ea5250d8345cb4341 URL: https://github.com/llvm/llvm-project/commit/e81b3401177a67481605447ea5250d8345cb4341 DIFF: https://github.com/llvm/llvm-project/commit/e81b3401177a67481605447ea5250d8345cb4341.diff

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

fhahn added a comment. Thanks for the latest update! This basically looks good to me, with a few final nits! Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8584 +def err_invalid_conversion_between_matrixes : Error< + "conversion between matrix type%diff{ $ and

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal updated this revision to Diff 336037. pdhaliwal added a comment. Herald added subscribers: jansvoboda11, dang. - Addressed review comments - Added LIT test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/

[PATCH] D97116: Reduce the number of attributes attached to each function

wxiao3 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:496 //function. - CurFn->addFnAttr("min-legal-vector-width", llvm::utostr(LargestVectorWidth)); + if (LargestVectorWidth) +CurFn->addFnAttr("min-legal-vector-width",

[PATCH] D100085: [X86] Support -march=rocketlake

RKSimon added inline comments. Comment at: llvm/lib/Target/X86/X86.td:790 + FeatureFSRM]; + list RKLTuning = ICLTuning; + list RKLFeatures = Using ICLTuning suggests we should still be avoiding 512-bit ops

[clang] 8fcb114 - [OpenCL] Fix mipmap read_image return types

Author: Sven van Haastregt Date: 2021-04-08T09:51:44+01:00 New Revision: 8fcb114d002bf7cd61309af80b26af68389944d0 URL: https://github.com/llvm/llvm-project/commit/8fcb114d002bf7cd61309af80b26af68389944d0 DIFF:

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 336033. tentzen added a comment. fixed command option typos in two test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 Files: clang/include/clang/AST/Stmt.h

[PATCH] D99984: [RISCV] Prevent __builtin_riscv_orc_b_64 from being compiled RV32 target.

frasercrmck added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:259 .Case("riscv64", Is64Bit) + .Case("64bit", Is64Bit) .Case("m", HasM) What's the difference between this new feature and `riscv64` above? Repository: rG

[clang] 20105b6 - [clang] Speedup line offset mapping computation

Author: serge-sans-paille Date: 2021-04-08T10:11:56+02:00 New Revision: 20105b6b4874a85813f7a4a3d8ad2a0f023dda14 URL: https://github.com/llvm/llvm-project/commit/20105b6b4874a85813f7a4a3d8ad2a0f023dda14 DIFF:

[PATCH] D100092: [clang-tidy] cppcoreguidelines-declare-loop-variable-in-the-initializer: a new check

DNS320 created this revision. DNS320 added reviewers: aaron.ballman, njames93, alexfh. DNS320 added a project: clang-tools-extra. Herald added subscribers: shchenz, kbarton, xazax.hun, mgorny, nemanjai. DNS320 requested review of this revision. This check implements the ES.74

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88905/new/ https://reviews.llvm.org/D88905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

NoQ added a comment. This looks amazing, thanks a lot. I have one final question: can we already remove `dispatchCast()`? I don't see any other call sites anymore. Looks like it becomes dead code after your patch. Which is fairly shocking and mind blowing that we've organically developed two

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1219 + } else { +SrcElementTy = SrcTy; +DstElementTy = DstTy; fhahn wrote: > We should be able to assert here that both types are not matrix types, I > think? I did

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha updated this revision to Diff 336022. SaurabhJha added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99037/new/ https://reviews.llvm.org/D99037 Files: clang/include/clang/AST/OperationKinds.def

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added a comment. In D100085#2675965 , @MaskRay wrote: > In D100085#2675919 , @FreddyYe > wrote: > >> Hi @MaskRay, I tried to refactor, but met some difficulties. Since these >> defines are dictionary

[PATCH] D100085: [X86] Support -march=rocketlake

MaskRay added a comment. In D100085#2675919 , @FreddyYe wrote: > Hi @MaskRay, I tried to refactor, but met some difficulties. Since these > defines are dictionary ordered, a new #define may insert into a common CHECK. > So it is difficult to let

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 336011. tentzen marked an inline comment as done. tentzen added a comment. clang-format fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 Files:

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added a comment. Hi @MaskRay, I tried to refactor, but met some difficulties. Since these defines are dictionary ordered, a new #define may insert into a common CHECK. So it is difficult to let different RUN share common CHECKs. // RUN: %clang -march=pentium-mmx -m32 -E -dM %s -o -

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe updated this revision to Diff 336007. FreddyYe added a comment. Updating according to comments. Test refactoring not done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 Files:

<    1   2