[PATCH] D101156: [Clang] Support a user-defined __dso_handle

rjmccall added a comment. What's the crash exactly/ Is IRGen just unhappy about processing the user definition when we've generated a declaration with a different type? Because we're already supposed to be being cautious about this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D101097: [Sema] Don't set BlockDecl's DoesNotEscape bit If the block is being passed to a function taking a reference parameter

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101097/new/ https://reviews.llvm.org/D101097

[PATCH] D101389: [clang][CodeGen] Fix address space for sret

rjmccall added a comment. In D101389#2724700 , @yaxunl wrote: > In D101389#2724636 , @rjmccall > wrote: > >> I think this is intentional; requiring the indirect-result parameter to be >> in the alloca address

[PATCH] D101506: Support: Remove F_{None,Text,Append} compatibility synonyms, NFC

MaskRay added a comment. Perhaps split the migration part from the `OpenFlags` removal part. I thought about deleting the aliases too but refrained because I noticed our internal code base needs migration. Since you propose this, I will start migration and hopefully can finish that next week

[PATCH] D97265: [clang] Allow clang-check to customize analyzer output file or dir name

OikawaKirie added a comment. If this patch is OK, could you please commit it on my behalf (Ella Ma )? Thx. And I will continue working on the `-Xanalyzer` option for clang-check, as it is too complex when adding analyzer options via the `-extra-arg` option. CHANGES SINCE LAST ACTION

[PATCH] D101389: [clang][CodeGen] Fix address space for sret

yaxunl added a comment. In D101389#2724636 , @rjmccall wrote: > I think this is intentional; requiring the indirect-result parameter to be in > the alloca address space would prevent direct initialization of non-temporary > memory, which is an

[PATCH] D101389: [clang][CodeGen] Fix address space for sret

rjmccall added a comment. I think this is intentional; requiring the indirect-result parameter to be in the alloca address space would prevent direct initialization of non-temporary memory, which is an important optimization in C++. CHANGES SINCE LAST ACTION

[PATCH] D101502: [ObjC][ARC] Don't enter the cleanup scope if the initializer expression isn't an ExprWithCleanups

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101502/new/ https://reviews.llvm.org/D101502

[PATCH] D101491: [ASan] Rename `-fsanitize-address-destructor-kind=` to drop the `-kind` suffix.

delcypher updated this revision to Diff 341384. delcypher added a comment. Remove metavar Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101491/new/ https://reviews.llvm.org/D101491 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D101490: [NFC] Rename SanitizeAddressDtorKind codegen opt to not have `Kind` suffix.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1bbbcff99de8: [NFC] Rename SanitizeAddressDtorKind codegen opt to not have `Kind` suffix. (authored by delcypher). Repository: rG LLVM Github

[clang] 1bbbcff - [NFC] Rename SanitizeAddressDtorKind codegen opt to not have `Kind` suffix.

Author: Dan Liew Date: 2021-04-28T18:37:16-07:00 New Revision: 1bbbcff99de8e53b89146386bb2587ed4fc8e9cf URL: https://github.com/llvm/llvm-project/commit/1bbbcff99de8e53b89146386bb2587ed4fc8e9cf DIFF: https://github.com/llvm/llvm-project/commit/1bbbcff99de8e53b89146386bb2587ed4fc8e9cf.diff

[PATCH] D101506: Support: Remove F_{None,Text,Append} compatibility synonyms, NFC

dexonsmith created this revision. dexonsmith added a reviewer: zturner. Herald added subscribers: dcaballe, cota, teijeong, rdzhabarov, tatianashp, bmahjour, msifontes, jurahul, Kayjukh, grosul1, jvesely, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen,

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

kuhar added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp:28 + std::string FullNameTrimmed; + int Count = 0; + for (const auto : FullName) { Can you add a comment explaining what this loops tries to do? Ideally, with

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

clementval created this revision. clementval added reviewers: jdoerfert, kiranchandramohan. Herald added subscribers: rriddle, guansong, hiraditya, yaxunl. clementval requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1, stephenneuendorffer. Herald

[PATCH] D101502: [ObjC][ARC] Don't enter the cleanup scope if the initializer expression isn't an ExprWithCleanups

ahatanak created this revision. ahatanak added reviewers: rjmccall, erik.pilkington. ahatanak added a project: clang. ahatanak requested review of this revision. This patch fixes a bug where a temporary ObjC pointer is released before the end of the full expression. This fixes PR50043.

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp:29 + int Count = 0; + for (const auto : FullName) { +if (Character == '<') { I'm not sure, but probably braces could be elided in `for` and `if

[PATCH] D100768: [Clang][OpenMP] Remove the mandatory flush for capture for OpenMP 5.1

tianshilei1992 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100768/new/ https://reviews.llvm.org/D100768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101139: Create install targets for scan-build-py.

aabbaabb added a comment. In D101139#2721880 , @phosek wrote: > In D101139#2718112 , @aabbaabb > wrote: > >> In D101139#2718057 , @phosek wrote: >> >>> In

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

nicovank marked 3 inline comments as done. nicovank added a comment. Thank you for the feedback, I appreciate it! Let me know if there is any other I missed, AFAIK all `auto` uses introduced by me should be good now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101139: Create install targets for scan-build-py.

aabbaabb updated this revision to Diff 341352. aabbaabb edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/tools/CMakeLists.txt

[PATCH] D97955: [clang-tidy] Refactor loop-convert to bring most of the checking into matchers

njames93 updated this revision to Diff 341350. njames93 added a comment. Remove unnecessary test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97955/new/ https://reviews.llvm.org/D97955 Files:

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

nicovank updated this revision to Diff 341349. nicovank added a comment. Explicitely specify one more type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101471/new/ https://reviews.llvm.org/D101471 Files:

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

Eugene.Zelenko added a comment. Please mark fixed suggestions as done. Comment at: clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp:248 + const auto *Call = PushBackCall ? PushBackCall : EmplacyCall; + Please don't use auto unless type is spelled

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

nicovank updated this revision to Diff 341342. nicovank added a comment. Fix a couple variable names and explicitely specify a couple types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101471/new/ https://reviews.llvm.org/D101471 Files:

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 341338. Ericson2314 added a comment. Rebase, no changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: clang/tools/scan-build/CMakeLists.txt

[PATCH] D94355: [Passes] Add relative lookup table converter pass

gulfem added a comment. > I would say if it is going to take longer than the end of the week to fix the > issue, it might be nice to have it reverted so that other people's builds > continue to work (I know a few people who build with full LTO in a two stage > configuration every week).

[PATCH] D101344: [clang-format] Add `SpacesInAngles: Leave` option to keep spacing inside angle brackets as is.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101344/new/ https://reviews.llvm.org/D101344 ___ cfe-commits mailing list

[PATCH] D101491: [ASan] Rename `-fsanitize-address-destructor-kind=` to drop the `-kind` suffix.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/docs/ClangCommandLineReference.rst:873 -.. option:: -fsanitize-address-destructor-kind= +.. option:: -fsanitize-address-destructor=

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

This revision was automatically updated to reflect the committed changes. Closed by commit rGb30521c28a4d: [analyzer] Wrong type cast occurs during pointer dereferencing after type… (authored by ASDenysPetrov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b30521c - [analyzer] Wrong type cast occurs during pointer dereferencing after type punning

Author: Denys Petrov Date: 2021-04-29T01:03:38+03:00 New Revision: b30521c28a4dc1b94d793385e4144ede5822b2c1 URL: https://github.com/llvm/llvm-project/commit/b30521c28a4dc1b94d793385e4144ede5822b2c1 DIFF: https://github.com/llvm/llvm-project/commit/b30521c28a4dc1b94d793385e4144ede5822b2c1.diff

[PATCH] D101491: [ASan] Rename `-fsanitize-address-destructor-kind=` to drop the `-kind` suffix.

delcypher added a comment. @jansvoboda11 Should I use the the alias feature so that the old `-fsanitize-address-destructor-kind` argument is still parsed? I'm not sure if it's worth it but if doing so is very simple and has a low maintenance burden we should probably do it. Repository: rG

[clang-tools-extra] c3846bc - [clangd][NFC] Reserve storage when creating semantic token encoding.

Author: Nathan James Date: 2021-04-28T22:39:54+01:00 New Revision: c3846bcfe1cc6d6421a543757b5046ea841d4610 URL: https://github.com/llvm/llvm-project/commit/c3846bcfe1cc6d6421a543757b5046ea841d4610 DIFF: https://github.com/llvm/llvm-project/commit/c3846bcfe1cc6d6421a543757b5046ea841d4610.diff

[PATCH] D101461: [clangd][NFC] Reserve storage when creating semantic token encoding.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3846bcfe1cc: [clangd][NFC] Reserve storage when creating semantic token encoding. (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101122: introduce flag -fsanitize-address-detect-stack-use-after-return-mode. No functional change.

delcypher added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:225-228 +ENUM_CODEGENOPT(SanitizeAddressDetectStackUseAfterReturnMode, +llvm::AsanDetectStackUseAfterReturnMode, 2, +

[PATCH] D101491: [ASan] Rename `-fsanitize-address-destructor-kind=` to drop the `-kind` suffix.

delcypher created this revision. delcypher added reviewers: vitalybuka, jansvoboda11. Herald added a subscriber: dang. delcypher requested review of this revision. Herald added a project: clang. Renaming the option is based on discussions in https://reviews.llvm.org/D101122. It is normally not a

[PATCH] D101490: [NFC] Rename SanitizeAddressDtorKind codegen opt to not have `Kind` suffix.

delcypher created this revision. delcypher added a reviewer: vitalybuka. Herald added subscribers: dexonsmith, dang. delcypher requested review of this revision. Herald added a project: clang. This is post commit follow up based on discussions in https://reviews.llvm.org/D101122. Repository:

[clang] ea12d77 - [libc++] Support per-target __config_site in per-target runtime build

Author: Petr Hosek Date: 2021-04-28T14:27:16-07:00 New Revision: ea12d779bc238c387511fe7462020f4ecf4a8246 URL: https://github.com/llvm/llvm-project/commit/ea12d779bc238c387511fe7462020f4ecf4a8246 DIFF: https://github.com/llvm/llvm-project/commit/ea12d779bc238c387511fe7462020f4ecf4a8246.diff

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp:25 + Names) { + const auto FullName = "::" + Node.getQualifiedNameAsString(); + Please don't use auto unless type is spelled explicitly in

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. In D100581#2723801 , @xbolva00 wrote: > > Yes, the best solution. Also consider to check gcc’s test-suite - if they > have this type of testcase, then this is wanted behaviour. gcc has `Wunused-var-5.c`, where the warning

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

rsmith added a comment. When this change returns, I'd like to see a different implementation strategy. Running a recursive AST visitation after the fact is generally not the right way to look for this kind of issue; adding an extra pass to speculatively hunt for each kind of warning we might

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. @rsmith ping2... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

xbolva00 added a comment. In D100581#2723794 , @nickdesaulniers wrote: > In D100581#2723789 , @mbenfield > wrote: > >> But gcc's behavior is to not trigger here so maybe following it is best. > > Perhaps file a

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

nickdesaulniers added a comment. In D100581#2723789 , @mbenfield wrote: > But gcc's behavior is to not trigger here so maybe following it is best. Perhaps file a bug against GCC to find whether that was intentional or a bug? Repository: rG LLVM

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. So it seems there are 3 issues here: 1. local variables declared extern should not trigger this warning. I'll fix this. 2. Should `x` in this code trigger the warning: int x; int y = (x = 0); These are essentially the "false positives" reported in the Linux

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

lebedev.ri added a comment. In D100581#2723709 , @aeubanks wrote: > reverted > regarding having a reviewer who is knowledgable in clang diagnostics, I > assumed that george.burgess.iv was knowledgable and was happy with the change > after his comments,

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

aeubanks added a comment. reverted regarding having a reviewer who is knowledgable in clang diagnostics, I assumed that george.burgess.iv was knowledgable and was happy with the change after his comments, perhaps I should have waited for an explicit LGTM Repository: rG LLVM Github Monorepo

[PATCH] D101480: Revert "[Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable"

aeubanks added a comment. https://reviews.llvm.org/rG6d8d1338629ceeaf6f56dc9eabc72e1a63f05169 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101480/new/ https://reviews.llvm.org/D101480 ___ cfe-commits

[clang] 6d8d133 - Revert "[Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable"

Author: Arthur Eubanks Date: 2021-04-28T12:47:18-07:00 New Revision: 6d8d1338629ceeaf6f56dc9eabc72e1a63f05169 URL: https://github.com/llvm/llvm-project/commit/6d8d1338629ceeaf6f56dc9eabc72e1a63f05169 DIFF:

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

lebedev.ri added a comment. In D100581#2723621 , @Abpostelnicu wrote: > In D100581#2723611 , @lebedev.ri > wrote: > >> In D100581#2723505 , @Abpostelnicu >> wrote: >>

[PATCH] D101480: Revert "[Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable"

Abpostelnicu accepted this revision. Abpostelnicu added a comment. This revision is now accepted and ready to land. Thank you for this! Also I think it’s very well that you want to implement this warning in clang, with a little bit of more polish it will be up for merger! Repository: rG LLVM

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

Abpostelnicu added a comment. In D100581#2723611 , @lebedev.ri wrote: > In D100581#2723505 , @Abpostelnicu > wrote: > >> Also I don’t remember seeing this proposed on cfe dev mailing list. > > There is no such

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

lebedev.ri added a comment. In D100581#2723505 , @Abpostelnicu wrote: > Also I don’t remember seeing this proposed on cfe dev mailing list. There is no such requirement. I don't recall that happening basically ever, actually. Repository: rG LLVM

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. Link for the revert: https://reviews.llvm.org/D101480 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llvm.org/D100581 ___ cfe-commits mailing list

[PATCH] D101480: Revert "[Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable"

mbenfield created this revision. mbenfield added reviewers: aeubanks, george.burgess.iv, lebedev.ri, Abpostelnicu. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D100772: [ARM] Neon Polynomial vadd Intrinsic fix

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0395f9e70b8f: [ARM] Neon Polynomial vadd Intrinsic fix (authored by rsanthir.quic). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 0395f9e - [ARM] Neon Polynomial vadd Intrinsic fix

Author: Ryan Santhirarajan Date: 2021-04-28T11:59:40-07:00 New Revision: 0395f9e70b8f2dc55d3ef0bb7195c3542deffc5a URL: https://github.com/llvm/llvm-project/commit/0395f9e70b8f2dc55d3ef0bb7195c3542deffc5a DIFF:

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

vitalybuka added a comment. In D99381#2721619 , @phosek wrote: > What I think @vitalybuka meant is keeping > `sanitizer_platform_limits_fuchsia.h` as you had it, but including it > unconditionally. Since the entire file is wrapped in `#if

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan updated this revision to Diff 341280. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan updated this revision to Diff 341279. leonardchan marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D101479: [Driver] Support libc++ in MSVC

phosek created this revision. phosek added reviewers: hans, rnk, thakis. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements support for using libc++ headers in MSVC toolchain. We only support libc++ headers that are

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

Abpostelnicu added a comment. Please revert this. This change hasn’t been tested nor reviewed enough. Also I don’t remember seeing this proposed on cfe dev mailing list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/

[PATCH] D101344: [clang-format] Add `SpacesInAngles: Leave` option to keep spacing inside angle brackets as is.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Looks good, and I'm always in favor of having a `Leave` Option. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. In D100581#2723348 , @lebedev.ri wrote: > Also, from the reviewer list, it doesn't look like anyone with much > familiarity with clang/clang diags actually participated in the review? > I think this might be the point to

[PATCH] D101209: [PowerPC] Provide fastmath sqrt and div functions in altivec.h

nemanjai added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15130 + Value *Y = EmitScalarExpr(E->getArg(1)); + auto Ret = Builder.CreateFDiv(X, Y, "recipdiv"); + Builder.setFastMathFlags(FMF); bmahjour wrote: > I wonder if we can

[PATCH] D101122: introduce flag -fsanitize-address-detect-stack-use-after-return-mode. No functional change.

vitalybuka added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:225-228 +ENUM_CODEGENOPT(SanitizeAddressDetectStackUseAfterReturnMode, +llvm::AsanDetectStackUseAfterReturnMode, 2, +

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

lebedev.ri added a comment. Also, from the reviewer list, it doesn't look like anyone with much familiarity with clang/clang diags actually participated in the review? I think this might be the point to revert and re-review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

lebedev.ri added a comment. In D100581#2723329 , @nathanchance wrote: > In D100581#2721430 , > @nickdesaulniers wrote: > >> Huh, maybe not: https://godbolt.org/z/PnE1fMGWo > > This difference has caused some

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

nathanchance added a comment. In D100581#2721430 , @nickdesaulniers wrote: > Huh, maybe not: https://godbolt.org/z/PnE1fMGWo This difference has caused some confusion already for the Linux kernel:

[PATCH] D101389: [clang][CodeGen] Fix address space for sret

yaxunl updated this revision to Diff 341257. yaxunl added a comment. cast return value to default address space since it is expected. also fix debug info CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101389/new/ https://reviews.llvm.org/D101389 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

dbabokin added a comment. > Thanks for the report. It seems the thing to do is to modify the warning so > that variables marked extern are not candidates for this warning. I will make > a new commit with that modification unless there are other suggestions. I agree, this seems to be the right

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. In D100581#2721705 , @dbabokin wrote: > One more false-positive: > > void foo() { > extern int yydebug; > yydebug = 1; > } > > It was triggered in ISPC build. Thanks for the report. It seems the thing to do is to

[PATCH] D101122: introduce flag -fsanitize-address-detect-stack-use-after-return-mode. No functional change.

delcypher added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:225-228 +ENUM_CODEGENOPT(SanitizeAddressDetectStackUseAfterReturnMode, +llvm::AsanDetectStackUseAfterReturnMode, 2, +

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

nicovank added a comment. As you can see, this will fail some tests as there is one corner case which is tricky to handle: std::vector>> vec; // This is valid and should not be changed. vec.emplace_back(std::make_tuple(13, 31)); Does anyone have a suggestion for a good way to handle

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

nicovank created this revision. nicovank added reviewers: alexfh, Prazek, kuhar. nicovank added projects: clang, clang-tools-extra. Herald added a subscriber: xazax.hun. nicovank requested review of this revision. Herald added a subscriber: cfe-commits. modernize-use-emplace only recommends going

[PATCH] D100667: [clang] Fix assert() crash when checking undeduced arg alignment

adamcz updated this revision to Diff 341244. adamcz added a comment. moved the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100667/new/ https://reviews.llvm.org/D100667 Files: clang/lib/Sema/SemaChecking.cpp clang/lib/Sema/SemaExpr.cpp

[PATCH] D101463: [clang] Make libBasic not depend on MC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG671f0e2e189c: [clang] Make libBasic not depend on MC (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[clang] 671f0e2 - [clang] Make libBasic not depend on MC

Author: Nico Weber Date: 2021-04-28T12:16:22-04:00 New Revision: 671f0e2e189c561512511331d95de382e2d6d15d URL: https://github.com/llvm/llvm-project/commit/671f0e2e189c561512511331d95de382e2d6d15d DIFF: https://github.com/llvm/llvm-project/commit/671f0e2e189c561512511331d95de382e2d6d15d.diff

[PATCH] D101426: [RISCV] Update subset naming convertion for the latest spec

khchen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:180 + // as described in RISC-V User-Level ISA 20191213. SmallVector Split; Exts.split(Split, StringRef("_")); If we want to update the arch string rules to ISA 20191213,

[clang] 602c8b4 - [analyzer][NFC] Fix tests failing after a rebase

Author: Valeriy Savchenko Date: 2021-04-28T18:55:20+03:00 New Revision: 602c8b4db5dbe88be7080b411455538c9b4cd117 URL: https://github.com/llvm/llvm-project/commit/602c8b4db5dbe88be7080b411455538c9b4cd117 DIFF:

[PATCH] D101209: [PowerPC] Provide fastmath sqrt and div functions in altivec.h

bmahjour requested changes to this revision. bmahjour added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15130 + Value *Y = EmitScalarExpr(E->getArg(1)); + auto Ret = Builder.CreateFDiv(X, Y, "recipdiv"); +

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

This revision was automatically updated to reflect the committed changes. Closed by commit rGab5823867c4a: [analyzer] Find better description for tracked symbolic values (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100852: [analyzer] Track leaking object through stores

This revision was automatically updated to reflect the committed changes. Closed by commit rGe273918038a7: [analyzer] Track leaking object through stores (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100852/new/

[PATCH] D100839: [analyzer] Adjust the reported variable name in retain count checker

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG61ae2db2d7a9: [analyzer] Adjust the reported variable name in retain count checker (authored by vsavchenko). Repository: rG LLVM Github Monorepo

[clang] ab58238 - [analyzer] Find better description for tracked symbolic values

Author: Valeriy Savchenko Date: 2021-04-28T18:37:38+03:00 New Revision: ab5823867c4aee7f3e02ddfaa217905c87471bf9 URL: https://github.com/llvm/llvm-project/commit/ab5823867c4aee7f3e02ddfaa217905c87471bf9 DIFF:

[clang] e273918 - [analyzer] Track leaking object through stores

Author: Valeriy Savchenko Date: 2021-04-28T18:37:38+03:00 New Revision: e273918038a7aa300cb8e6afebd9714bf647eed0 URL: https://github.com/llvm/llvm-project/commit/e273918038a7aa300cb8e6afebd9714bf647eed0 DIFF:

[PATCH] D100626: [analyzer][NFC] Remove duplicated work from retain count leak report

This revision was automatically updated to reflect the committed changes. Closed by commit rG1dad8c5036bc: [analyzer][NFC] Remove duplicated work from retain count leak report (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 61ae2db - [analyzer] Adjust the reported variable name in retain count checker

Author: Valeriy Savchenko Date: 2021-04-28T18:37:37+03:00 New Revision: 61ae2db2d7a97af5206afe609a303071711f9e6e URL: https://github.com/llvm/llvm-project/commit/61ae2db2d7a97af5206afe609a303071711f9e6e DIFF:

[clang] 1dad8c5 - [analyzer][NFC] Remove duplicated work from retain count leak report

Author: Valeriy Savchenko Date: 2021-04-28T18:37:37+03:00 New Revision: 1dad8c5036bc912078f7859d89e3ea571616fc4a URL: https://github.com/llvm/llvm-project/commit/1dad8c5036bc912078f7859d89e3ea571616fc4a DIFF:

[PATCH] D101461: [clangd][NFC] Reserve storage when creating semantic token encoding.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101461/new/ https://reviews.llvm.org/D101461

[PATCH] D99079: [ARM][AArch64] Require appropriate features for crypto algorithms

This revision was automatically updated to reflect the committed changes. Closed by commit rGb8baa2a91324: [ARM][AArch64] Require appropriate features for crypto algorithms (authored by dcandler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b8baa2a - [ARM][AArch64] Require appropriate features for crypto algorithms

Author: David Candler Date: 2021-04-28T16:26:18+01:00 New Revision: b8baa2a9132498ea286dbb0d03f005760ecc6fdb URL: https://github.com/llvm/llvm-project/commit/b8baa2a9132498ea286dbb0d03f005760ecc6fdb DIFF: https://github.com/llvm/llvm-project/commit/b8baa2a9132498ea286dbb0d03f005760ecc6fdb.diff

[PATCH] D99079: [ARM][AArch64] Require appropriate features for crypto algorithms

dcandler added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.h:36 + bool HasSHA3; + bool HasSM4; bool HasUnaligned; rsanthir.quic wrote: > Would it make sense to further differentiate SM3 and SM4? I see that we > differentiate between the

[PATCH] D101439: [clang-cl] Add parsing support for a bunch of new flags

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Great :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101439/new/ https://reviews.llvm.org/D101439

[PATCH] D101463: [clang] Make libBasic not depend on MC

thakis created this revision. thakis added a reviewer: hans. Herald added subscribers: dexonsmith, dang, mgorny. Herald added a reviewer: aaron.ballman. thakis requested review of this revision. Herald added subscribers: llvm-commits, aheejin. Herald added a project: LLVM. Reduces numbers of

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 341211. Ericson2314 added a comment. Fix stray ':' typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: clang/tools/scan-build/CMakeLists.txt

[PATCH] D101461: [clangd][NFC] Reserve storage when creating semantic token encoding.

njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM

[PATCH] D101457: [clang] remove dead code after 2a1332245fc

thakis added a comment. > The real question is how did you find this? :) No exciting answer, I'm afraid: I just happened to read this code while looking at something else. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101457/new/

[PATCH] D101457: [clang] remove dead code after 2a1332245fc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d493291bd01: [clang] remove dead code after 2a1332245fc (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[clang] 5d49329 - [clang] remove dead code after 2a1332245fc

Author: Nico Weber Date: 2021-04-28T10:27:31-04:00 New Revision: 5d493291bd010bbba0fdc1e7da0922fd214fdffd URL: https://github.com/llvm/llvm-project/commit/5d493291bd010bbba0fdc1e7da0922fd214fdffd DIFF: https://github.com/llvm/llvm-project/commit/5d493291bd010bbba0fdc1e7da0922fd214fdffd.diff

[PATCH] D101457: [clang] remove dead code after 2a1332245fc

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm The real question is how did you find this? :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101457/new/ https://reviews.llvm.org/D101457

  1   2   >