[PATCH] D101813: [Driver] Move -print-runtime-dir and -print-resource-dir tests

phosek created this revision. phosek added a reviewer: MaskRay. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Put these into a separate files to match other -print-* options tests. Repository: rG LLVM Github Monorepo

[PATCH] D101797: [NewPM] Hide pass manager debug logging behind -debug-pass-manager-verbose

ychen added a comment. Looks like the precheck failures are real. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101797/new/ https://reviews.llvm.org/D101797 ___ cfe-commits mailing list

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

Abpostelnicu added a comment. I'm seeing here something very strange, if the user provided copy assignment operator is provided but is = delete and the copy constructor is default this warning will still trigger. Is this something expected? I'm referring at this

[PATCH] D99903: [Clang][Sema] better -Wcast-function-type diagnose for pointer parameters and parameters with cv-qualifiers

ychen added a comment. ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99903/new/ https://reviews.llvm.org/D99903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 2669aba - [clang][CodeGen] Use llvm::stable_sort for multi version resolver options

Author: Alex Lorenz Date: 2021-05-03T20:07:00-07:00 New Revision: 2669abaecfc47d4d2436559ab8c1fb49ad6e35c3 URL: https://github.com/llvm/llvm-project/commit/2669abaecfc47d4d2436559ab8c1fb49ad6e35c3 DIFF: https://github.com/llvm/llvm-project/commit/2669abaecfc47d4d2436559ab8c1fb49ad6e35c3.diff

[PATCH] D101788: [AST] AnyCall: Implement arguments().

NoQ added inline comments. Comment at: clang/include/clang/Analysis/AnyCall.h:170 + return {ME->getArgs(), ME->getNumArgs()}; +} else if (const auto *CE = dyn_cast(E)) { + return {CE->getArgs(), CE->getNumArgs()}; xazax.hun wrote: > As far as I

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

aqjune added inline comments. Comment at: llvm/test/Transforms/InstCombine/or.ll:1135 ; CHECK-NEXT:ret i1 [[OR]] ; %x = icmp sge i16 %a, %b This can be salvaged as well: https://alive2.llvm.org/ce/z/yXF96T But I think there are more patterns that are

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

yaxunl added a comment. Decls in Sema::DeclsToCheckForDeferredDiags is supposed to be unique. Therefore the fact that '1,734,387,685 out of 1,734,404,000 elements are the same' is surprising. Did this happen when you compile the source code and write AST? What language was the source code?

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 ___ cfe-commits mailing list

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

aqjune added inline comments. Comment at: llvm/test/Transforms/InstCombine/or.ll:1102 +; CHECK-NEXT:[[AND:%.*]] = select i1 [[Y]], i1 [[X]], i1 false +; CHECK-NEXT:[[OR:%.*]] = select i1 [[X_INV]], i1 true, i1 [[AND]] ; CHECK-NEXT:ret i1 [[OR]]

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:2618 +void CodeGenModule::EmitOMPAllocateDecl(const OMPAllocateDecl *D) { + for (Expr *E : const_cast(D)->varlists()) { +auto *DE = cast(E); jdoerfert wrote: > ABataev wrote: > >

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

efriedma added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:10723-10733 + bool LHSIsNullPtr = LHS.get()->IgnoreParenCasts()->isNullPointerConstant( + Context, Expr::NPC_ValueDependentIsNotNull); + bool RHSIsNullPtr =

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:2618 +void CodeGenModule::EmitOMPAllocateDecl(const OMPAllocateDecl *D) { + for (Expr *E : const_cast(D)->varlists()) { +auto *DE = cast(E); ABataev wrote: > jdoerfert wrote: > >

[PATCH] D101800: [OpenMP] Fix non-determinism in clang task codegen (lastprivates)

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101800/new/ https://reviews.llvm.org/D101800

[PATCH] D101683: [Utils] Run non-filecheck runlines in-order in update_cc_test_checks

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Add a commit message explaining why/what this does. I run into the problem before so I know but other won't. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100917: [NewPM] Only invalidate modified functions' analyses in CGSCC passes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd14d84af2f5e: [NewPM] Only invalidate modified functions analyses in CGSCC passes (authored by aeubanks). Repository: rG LLVM Github Monorepo

[clang] d14d84a - [NewPM] Only invalidate modified functions' analyses in CGSCC passes

Author: Arthur Eubanks Date: 2021-05-03T17:21:44-07:00 New Revision: d14d84af2f5ebb8ae2188ce6884a29a586dc0a40 URL: https://github.com/llvm/llvm-project/commit/d14d84af2f5ebb8ae2188ce6884a29a586dc0a40 DIFF:

[PATCH] D100917: [NewPM] Only invalidate modified functions' analyses in CGSCC passes

aeubanks updated this revision to Diff 342602. aeubanks added a comment. Herald added a subscriber: nikic. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100917/new/ https://reviews.llvm.org/D100917 Files:

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

nickdesaulniers added a comment. I didn't see any instances in quick testing on the Linux kernel: x86_64 defconfig, aarch64 defconfig, arm defconfig, x86_64 allmodconfig. So I guess that's a good thing (for Linux)! Comment at: clang/lib/Sema/SemaExpr.cpp:10723-10733 +

[PATCH] D99599: [NewPM] Add an option to dump pass structure

aeubanks added a comment. I've already run into having to update these two golden file tests twice, we really shouldn't be having multiple types of golden file tests for the same thing in different locations and with different formats. I'd like to revert this change. Perhaps something like

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

xazax.hun added a comment. Don't mind my previous comment :) I missed the conversation about function by-ref arguments. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96215/new/ https://reviews.llvm.org/D96215 ___ cfe-commits mailing list

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

xazax.hun added a comment. > I'm arguing that it should scan for lambda captures by reference as well. What about immediately invoked lambdas? Would it make sense to exclude those? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96215/new/ https://reviews.llvm.org/D96215

[PATCH] D101788: [AST] AnyCall: Implement arguments().

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/AnyCall.h:170 + return {ME->getArgs(), ME->getNumArgs()}; +} else if (const auto *CE = dyn_cast(E)) { + return {CE->getArgs(), CE->getNumArgs()}; As far as I remember

[PATCH] D101645: [clang] RecursiveASTVisitor visits ObjCPropertyRefExpr's class receiver

akyrtzi added inline comments. Comment at: clang/test/Index/Core/index-source.m:410 // CHECK-NEXT: RelCont | classReceivers | c:@F@classReceivers +// CHECK: [[@LINE-3]]:3 | class/ObjC | ClassReceivers | c:objc(cs)ClassReceivers | _OBJC_CLASS_$_ClassReceivers | Ref,RelCont |

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1593 +tok::kw_namespace, tok::r_paren, tok::r_square, tok::r_brace, +tok::kw_false, tok::kw_true, Keywords.kw_type, Keywords.kw_get, +Keywords.kw_set) ||

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv updated this revision to Diff 342594. exv marked 2 inline comments as done. exv added a comment. - [clang-format] Add more support for C# 8 nullables - Fix null-coalescing assignment whitespace behavior - Incorporate feedback from curdeius - Combine JS and CS types/parsing Repository: rG

[PATCH] D101379: [NewPM] Invalidate AAManager after populating GlobalsAA

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2df3426fd15e: [NewPM] Invalidate AAManager after populating GlobalsAA (authored by aeubanks). Herald added a project: clang. Herald added a

[clang] 2df3426 - [NewPM] Invalidate AAManager after populating GlobalsAA

Author: Arthur Eubanks Date: 2021-05-03T16:37:32-07:00 New Revision: 2df3426fd15e41880c2da1484b560cd9c5f1f842 URL: https://github.com/llvm/llvm-project/commit/2df3426fd15e41880c2da1484b560cd9c5f1f842 DIFF:

[PATCH] D101800: [OpenMP] Fix non-determinism in clang task codegen (lastprivates)

ggeorgakoudis created this revision. Herald added subscribers: mgrang, guansong, yaxunl. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

nickdesaulniers added a comment. In D98798#2734598 , @xbolva00 wrote: > Maybe Nick could try this patch with linux kernel? Yes! Thank you of thinking of me for this; we're currently sorting issues identified by this warning (as implemented today, for

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

dblaikie added a comment. In D101566#2733172 , @aaronpuchert wrote: > In D101566#2730746 , @dblaikie > wrote: > >> Out of curiosity - have you tried it & measured any significant >> improvement/value in build

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

weiwang added a comment. We've seen a huge memory footprint from AST Reader/Writer in a single CU with module enabled. Upon further analysis, the content of vector `DeclsToCheckForDeferredDiags` seems mostly redundant. In one case, 1,734,387,685 out of 1,734,404,000 elements are the same.

[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101766/new/ https://reviews.llvm.org/D101766

[PATCH] D101790: [clang-tidy] Aliasing: Add support for passing the variable into a function by reference.

NoQ added a reviewer: baloghadamsoftware. NoQ added a comment. Herald added a subscriber: rnkovacs. +Adam, the original author of bugprone-redundant-branch-condition. Adam, do you have any thoughts regarding the tests regressed by this patch? Are they something we should absolutely keep warning

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

weiwang created this revision. Herald added subscribers: hoy, wenlei. weiwang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Reduce memory footprint of AST Reader/Writer: 1. Adjust internal data containers' element type. 2. Switch to set

[PATCH] D101787: [clang-tidy] Aliasing: Add more support for lambda captures.

NoQ updated this revision to Diff 342570. NoQ added a comment. Fxd! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101787/new/ https://reviews.llvm.org/D101787 Files: clang-tools-extra/clang-tidy/utils/Aliasing.cpp

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

NoQ added a comment. I covered pass-by-reference-into-function in D101790 and decomposition (from a certain point of view) in D101791 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96215/new/

[PATCH] D101791: [clang-tidy] Aliasing: Add support for aggregates with references.

NoQ created this revision. NoQ added reviewers: alexfh, gribozavr2, aaron.ballman, vsavchenko. Herald added subscribers: martong, mgehre, xazax.hun. NoQ requested review of this revision. Herald added a project: clang-tools-extra. When a variable is used in an initializer of an aggregate for its

[PATCH] D101790: [clang-tidy] Aliasing: Add support for passing the variable into a function by reference.

NoQ updated this revision to Diff 342567. NoQ added a comment. Unforget to `git add` Objective-{C,C++} tests. Apart from testing the patch, some of these tests demonstrate that the checker doesn't really work in Objective-C. The problem is that `forFunction()` doesn't treat Objective-C methods

[PATCH] D101790: [clang-tidy] Aliasing: Add support for passing the variable into a function by reference.

NoQ created this revision. NoQ added reviewers: alexfh, gribozavr2, aaron.ballman, vsavchenko. Herald added subscribers: martong, mgehre, xazax.hun. NoQ requested review of this revision. Herald added a project: clang-tools-extra. This is a fairly basic form of aliasing that as we've noticed in

[PATCH] D101787: [clang-tidy] Aliasing: Add more support for lambda captures.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/Aliasing.cpp:76 +const VarDecl *Var) { + const CXXMethodDecl *MD = dyn_cast(Func); + if (!MD) `const auto*` could be used

[PATCH] D101788: [AST] AnyCall: Implement arguments().

NoQ created this revision. NoQ added reviewers: vsavchenko, george.karpenkov, rjmccall. Herald added a subscriber: martong. NoQ requested review of this revision. AnyCall is an interface provided by libAnalysis to polymorphically handle various call-like entities (function calls, Obj-C message

[PATCH] D101628: [Format] Don't sort includes if DisableFormat is true

njames93 added a comment. In D101628#2734501 , @curdeius wrote: > Is it testable? I guess it would be, gimme a few to have a look at format unittests and I'll rustle up a quick test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

NoQ updated this revision to Diff 342550. NoQ retitled this revision from "[clang-tidy] Recognize captures as a form of aliasing." to "[clang-tidy] Aliasing: Add support for lambda captures.". NoQ added a comment. Herald added a project: clang-tools-extra. Trivial rebase. CHANGES SINCE LAST

[PATCH] D101735: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c1406f24d8b: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101735/new/

[clang] 1c1406f - [WebAssembly] Reenable end-to-end test in wasm-eh.cpp

Author: Heejin Ahn Date: 2021-05-03T14:42:12-07:00 New Revision: 1c1406f24d8b1c8ebec76c516ea969072d24cc75 URL: https://github.com/llvm/llvm-project/commit/1c1406f24d8b1c8ebec76c516ea969072d24cc75 DIFF: https://github.com/llvm/llvm-project/commit/1c1406f24d8b1c8ebec76c516ea969072d24cc75.diff

[PATCH] D101787: [clang-tidy] Aliasing: Add more support for lambda captures.

NoQ created this revision. NoQ added reviewers: alexfh, gribozavr2, aaron.ballman, vsavchenko. Herald added subscribers: martong, mgehre, xazax.hun. NoQ requested review of this revision. Herald added a project: clang-tools-extra. D96215 takes care of the

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. Looks very good already. Just some questions and test requests. Requesting changes so it shows up nicely in the revision queue. Comment at:

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan added a comment. Will submit this later today unless there's any more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 ___ cfe-commits

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

nikic added a comment. Went through all the tests again, looks like there's three patterns that could still be handled. I think the last one of them should be handled, and for the other two it's fine to just open an issue. Comment at:

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

xbolva00 added a comment. Maybe Nick could try this patch with linux kernel? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

tlively added a comment. I chatted with @dblaikie offline about this just now, and we both think it makes sense to turn this particular test into a C->IR test, then later potentially add a C->Wasm end-to-end test to the cross-project-tests directory created in this WIP stack of diffs:

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D100991: Fix parsing of vector keyword in presence of conflicting uses.

jamieschmeiser updated this revision to Diff 342540. jamieschmeiser added a comment. Limit tests to platform that supports altivec. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100991/new/ https://reviews.llvm.org/D100991 Files: clang/lib/Parse/Parser.cpp

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:177-179 +const Environment = State->getEnvironment(); +EnvironmentEntry Entry(Sub, Node->getLocationContext()); +const SVal ExprVal =

[PATCH] D101628: [Format] Don't sort includes if DisableFormat is true

curdeius added a comment. Is it testable? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101628/new/ https://reviews.llvm.org/D101628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:365 + + verifyFormat("test \?\?= ABC;", Style); + verifyFormat("test \?\?= true;", Style); HazardyKnusperkeks wrote: > Why do you escape `?`? I've never seen that. Apparently,

[PATCH] D101139: Create install targets for scan-build-py.

aabbaabb marked an inline comment as done. aabbaabb added inline comments. Comment at: clang/tools/scan-build-py/CMakeLists.txt:8 + "bin/intercept-cc" + "bin/scan-build") + wanders wrote: > This overwrites the "bin/scan-build" that was installed from the

[PATCH] D101641: [Sema] Preserve invalid CXXCtorInitializers using RecoveryExpr in initializer

hokein added a comment. thanks, this code looks pretty solid, just a question. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4475 // name that denotes that base class type. - bool Dependent = BaseType->isDependentType() || Init->isTypeDependent(); + bool Dependent =

[PATCH] D101139: Create install targets for scan-build-py.

aabbaabb updated this revision to Diff 342529. aabbaabb added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Rename scan-build to scan-build-py during install to prevent overwriting pearl implementation. CHANGES SINCE LAST ACTION

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv added a comment. Hey all, I'm really sorry for the noise, I screwed up my arc command to revise the submission. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv updated this revision to Diff 342521. exv added a comment. Herald added a subscriber: JDevlieghere. Fixing arc, hopefully? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 Files:

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv updated this revision to Diff 342520. exv added a comment. Herald added subscribers: llvm-commits, libcxx-commits, lldb-commits, Sanitizers, dcaballe, cota, teijeong, frasercrmck, dexonsmith, rdzhabarov, tatianashp, lxfind, dang, msifontes, jurahul, Kayjukh, grosul1, Joonsoo,

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:365 + + verifyFormat("test \?\?= ABC;", Style); + verifyFormat("test \?\?= true;", Style); Why do you escape `?`? I've never seen that. Repository: rG LLVM

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:2618 +void CodeGenModule::EmitOMPAllocateDecl(const OMPAllocateDecl *D) { + for (Expr *E : const_cast(D)->varlists()) { +auto *DE = cast(E); jdoerfert wrote: > ABataev wrote: > >

[PATCH] D101628: [Format] Don't sort includes if DisableFormat is true

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Jep, that would also confuse myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101628/new/ https://reviews.llvm.org/D101628

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

dgoldman created this revision. dgoldman added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, jfb, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Treat them just

[PATCH] D99599: [NewPM] Add an option to dump pass structure

aeubanks added a comment. As you said in the description, this overlaps a lot with -debug-pass-manager. What exactly is too verbose with the existing debug logging? I'd strongly prefer to have this consolidated into one pass instrumentation rather than two. Having a new pipeline test is very

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:2618 +void CodeGenModule::EmitOMPAllocateDecl(const OMPAllocateDecl *D) { + for (Expr *E : const_cast(D)->varlists()) { +auto *DE = cast(E); ABataev wrote: > jdoerfert wrote: > >

[PATCH] D101743: [clangd] Fix hover crash on broken code

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:2447 +// Setter variable heuristic might fail if the callexpr is broken. +struct X { int Y; void

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:2618 +void CodeGenModule::EmitOMPAllocateDecl(const OMPAllocateDecl *D) { + for (Expr *E : const_cast(D)->varlists()) { +auto *DE = cast(E); jdoerfert wrote: > ABataev wrote: > > Why

[PATCH] D101781: Fix assert on the variable which is used in omp clause is not marked as used

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101781/new/ https://reviews.llvm.org/D101781

[PATCH] D101696: [Matrix] Implement C-style explicit type conversions in CXX for matrix types

SaurabhJha added a comment. In D101696#2734312 , @fhahn wrote: > LGTM, thanks! > > I can land this on your behalf tomorrow. > > After that I think you could apply for commit access > https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access :)

[clang] 63f8226 - [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

Author: Valentin Clement Date: 2021-05-03T15:42:32-04:00 New Revision: 63f8226f259a03d7a56403be496724b77314e19a URL: https://github.com/llvm/llvm-project/commit/63f8226f259a03d7a56403be496724b77314e19a DIFF:

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG63f8226f259a: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions (authored by clementval). Repository: rG LLVM

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

clementval updated this revision to Diff 342512. clementval added a comment. Rebase 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101503/new/ https://reviews.llvm.org/D101503 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D101696: [Matrix] Implement C-style explicit type conversions in CXX for matrix types

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! I can land this on your behalf tomorrow. After that I think you could apply for commit access https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access :) Repository:

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

clementval updated this revision to Diff 342508. clementval added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101503/new/ https://reviews.llvm.org/D101503 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D101781: Fix assert on the variable which is used in omp clause is not marked as used

jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert, mikerice. jyu2 added a project: clang. jyu2 requested review of this revision. Herald added a subscriber: sstefan1. The problem only happens with constexpr variable, for constexpr variable, variable is not marked during parser

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3197 +Right.is(TT_CSharpNullCoalescingAssignment)) + return true; + MyDeveloperDay wrote: > should this honour SpaceBeforeAssignmentOperators ? Good point. Looking more

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

exv updated this revision to Diff 342497. exv added a comment. Remove special whitespace handling for ??= Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D101776: Work around an unfortunate macro in the Windows SDK

zahen created this revision. zahen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rename LLVM's single use of CALLBACK as a template parameter to work around the Windows SDK `#define CALLBACK __stdcall` I'm sympathetic to the Michael

[PATCH] D101775: Fix for Bug 50033 - -fno-temp-file is not respected when creating a pch in clang 12

zahen added a comment. Thanks for taking a look right away Duncan! The same concern about a lack of tests was raised when I first added `-fno-temp-file` and I'm afraid inspiration hasn't struck me in the meantime. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev marked 2 inline comments as done. v.g.vassilev added a comment. In D96033#2717749 , @teemperor wrote: > Sorry for the delay. I think all my points have been resolved beside the > insertion SourceLoc. Apologies, I overlooked this comment.

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev updated this revision to Diff 342485. v.g.vassilev added a comment. Address source location comment of teemperor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 Files: clang/include/clang/CodeGen/CodeGenAction.h

[PATCH] D101775: Fix for Bug 50033 - -fno-temp-file is not respected when creating a pch in clang 12

dexonsmith added a comment. Yep, this fixes a regression (https://bugs.llvm.org/show_bug.cgi?id=50033) caused by ad7aaa475e5e632242b07380ec47d2f35d077209 , where I somehow missed that modules and PCHs had different actual

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

xbolva00 accepted this revision. xbolva00 added a comment. LG in the current state. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101387/new/ https://reviews.llvm.org/D101387 ___ cfe-commits mailing

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

xbolva00 added inline comments. Comment at: clang/test/Driver/stack-protector-guard.c:38 // CHECK-GS: "-cc1" {{.*}}"-mstack-protector-guard-reg=gs" -// INVALID-REG: error: invalid value {{.*}} in 'mstack-protector-guard-reg=','for X86, valid arguments to

[PATCH] D101775: Fix for Bug 50033 - -fno-temp-file is not respected when creating a pch in clang 12

zahen created this revision. zahen added reviewers: dexonsmith, erik.pilkington. zahen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When creating a PCH file the use of a temp file will be dictated by the presence or absence of the

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc updated this revision to Diff 342478. mibintc retitled this revision from "[clang][patch] Add support for option -fextend-arguments-64: widen integer arguments to int64 in unprototyped function calls" to "[clang][patch] Add support for option -fextend-arguments={32,64}: widen integer

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers marked 7 inline comments as done. nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:279 "-fembed-bitcode is not supported on versions of iOS prior to 6.0">; +def err_drv_negative_columns : Error< +

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

xbolva00 added a comment. Looks better now, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101387/new/ https://reviews.llvm.org/D101387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers updated this revision to Diff 342475. nickdesaulniers added a comment. - "expected one of: ..." Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101387/new/ https://reviews.llvm.org/D101387 Files:

[PATCH] D101758: [clang][modules] Add -cc1 option to backup PCM files

dexonsmith added a comment. A few high-level comments: - Something like this *does* seem really useful for debugging problems with implicit module builds using a fuzzy context hash. But I feel like the use case is carved out at the wrong place; I feel like we either want this to be: - more

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:279 "-fembed-bitcode is not supported on versions of iOS prior to 6.0">; +def err_drv_negative_columns : Error< +"invalid value '%1' in '%0', value must be 'none' or a

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:279 "-fembed-bitcode is not supported on versions of iOS prior to 6.0">; +def err_drv_negative_columns : Error< +"invalid value '%1' in '%0', value must be 'none' or a positive

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

xbolva00 added inline comments. Comment at: clang/test/Driver/stack-protector-guard.c:38 // CHECK-GS: "-cc1" {{.*}}"-mstack-protector-guard-reg=gs" -// INVALID-REG: error: invalid value {{.*}} in 'mstack-protector-guard-reg=','for X86, valid arguments to

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

xbolva00 added inline comments. Comment at: clang/test/Driver/stack-protector-guard.c:38 // CHECK-GS: "-cc1" {{.*}}"-mstack-protector-guard-reg=gs" -// INVALID-REG: error: invalid value {{.*}} in 'mstack-protector-guard-reg=','for X86, valid arguments to

[PATCH] D99543: [clang-tidy] Allow opt-in or out of some commonly occuring patterns in NarrowingConversionsCheck.

Stephen marked an inline comment as done. Stephen added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-narrowing-conversions-ignoreconversionfromtypes-option.cpp:12 + +typedef long long size_t; + njames93 wrote: > This

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. One last nit. Perhaps leave it open for two days in case other reviewers have further comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:279

  1   2   3   >