[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

tbaeder updated this revision to Diff 346635. tbaeder added a comment. Thanks for the feedback, I think this should work better. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102479/new/ https://reviews.llvm.org/D102479 Files: clang/include/clang/Driver/Options.td

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

tbaeder updated this revision to Diff 346634. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102479/new/ https://reviews.llvm.org/D102479 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/lto.c

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD updated this revision to Diff 346633. RedDocMD added a comment. Removed unnecessary includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtr.h

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD updated this revision to Diff 346632. RedDocMD added a comment. Herald added a reviewer: teemperor. Herald added a subscriber: manas. Added a test for multiple get's Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/

[PATCH] D102822: [Clang][CodeGen] Set the size of llvm.lifetime to unknown for scalable types.

HsiangKai added a comment. In D102822#2770175 , @craig.topper wrote: > Am I mistaken, or does this test already pass without these changes? You are right. I didn't confirm it. I need to update the test case. Thanks. Repository: rG LLVM Github

[PATCH] D101973: [OpenMP][NFC] Remove SIMD check lines for non-simd tests

jdoerfert added a comment. In D101973#2770283 , @JonChesterfield wrote: > I can't see a change to a script in this diff. Should there be one? Looks > like the test change was done programmatically It was, but I did not expect to need the script in the

[PATCH] D102614: [index] Add support for type of pointers to class members

OikawaKirie added inline comments. Comment at: clang/lib/Index/USRGeneration.cpp:897 +if (const MemberPointerType *MPT = T->getAs()) { + VisitType(QualType(MPT->getClass(), 0)); + Out << "::*"; akyrtzi wrote: > A bit better to do

[PATCH] D101973: [OpenMP][NFC] Remove SIMD check lines for non-simd tests

JonChesterfield added a comment. I can't see a change to a script in this diff. Should there be one? Looks like the test change was done programmatically Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101973/new/ https://reviews.llvm.org/D101973

[PATCH] D102805: [M68k] Allow user to preserve certain registers

myhsu updated this revision to Diff 346627. myhsu marked an inline comment as done. myhsu added a comment. Fix formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102805/new/ https://reviews.llvm.org/D102805 Files: clang/include/clang/Driver/Options.td

[PATCH] D102818: [PGO] Don't reference functions unless value profiling is enabled

davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. lgtm (value profiling is off by default for FE PGO anyway) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102818/new/

[clang] f8444a8 - [clang-offload-bundler] Delimit input/output file names by '--' for llvm-objcopy

Author: Sergey Dmitriev Date: 2021-05-19T20:25:05-07:00 New Revision: f8444a8e94227401f816d948ec09ae1b2761d575 URL: https://github.com/llvm/llvm-project/commit/f8444a8e94227401f816d948ec09ae1b2761d575 DIFF:

[PATCH] D102752: [clang-offload-bundler] Delimit input/output file names by '--' for llvm-objcopy

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8444a8e9422: [clang-offload-bundler] Delimit input/output file names by -- for llvm-objcopy (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

jdoerfert updated this revision to Diff 346621. jdoerfert added a comment. Drop the `weak` attribute, will solve the problem differently Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101976/new/ https://reviews.llvm.org/D101976 Files:

[PATCH] D102822: [Clang][CodeGen] Set the size of llvm.lifetime to unknown for scalable types.

craig.topper added a comment. Am I mistaken, or does this test already pass without these changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102822/new/ https://reviews.llvm.org/D102822 ___

[PATCH] D102822: [Clang][CodeGen] Set the size of llvm.lifetime to unknown for scalable types.

HsiangKai created this revision. HsiangKai added reviewers: craig.topper, frasercrmck, rogfer01. Herald added subscribers: StephenFan, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook,

[PATCH] D101973: [OpenMP][NFC] Remove SIMD check lines for non-simd tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ff380f43987: [OpenMP][NFC] Remove SIMD check lines for non-simd tests (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101973/new/

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/pre-ra-sched.c:1-2 +// RUN: %clang %s -mllvm -pre-RA-sched=fast -c -o - | FileCheck %s +// RUN: %clang %s -mllvm -pre-RA-sched=linearize -c -o - | FileCheck %s + The test as was

[PATCH] D102558: [Utils] Check for generated functions inline if possible

jdoerfert planned changes to this revision. jdoerfert added a comment. This doesn't work properly yet :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102558/new/ https://reviews.llvm.org/D102558 ___

[PATCH] D102469: [sanitizer] Reduce redzone size for small size global objects

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdbc641deb988: [sanitizer] Reduce redzone size for small size global objects (authored by condy, committed by MaskRay). Repository: rG LLVM Github

[clang] dbc641d - [sanitizer] Reduce redzone size for small size global objects

Author: Zhiwei Chen Date: 2021-05-19T19:18:50-07:00 New Revision: dbc641deb9883c502b5650e36a31c23d11a358fe URL: https://github.com/llvm/llvm-project/commit/dbc641deb9883c502b5650e36a31c23d11a358fe DIFF: https://github.com/llvm/llvm-project/commit/dbc641deb9883c502b5650e36a31c23d11a358fe.diff

[PATCH] D102469: [sanitizer] Reduce redzone size for small size global objects

MaskRay updated this revision to Diff 346614. MaskRay added a comment. Herald added a subscriber: steven_wu. fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102469/new/ https://reviews.llvm.org/D102469 Files:

[PATCH] D98895: [X86][Draft] Disable long double type for -mno-x87 option

pengfei added inline comments. Comment at: clang/test/Sema/x86-no-x87.c:48-61 +void assign2() { + struct st_long_double st; +#ifndef NOERROR + // expected-error@+2{{long double is not supported on this target}} +#endif + st.ld = 0.42; +} asavonic wrote: >

[PATCH] D102469: [sanitizer] Reduce redzone size for small size global objects

condy marked 3 inline comments as done. condy added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2556 + uint64_t RZ = 0; + if (SizeInBytes < MinRZ / 2) { +// Reduce redzone size for small size objects, e.g. int, char[1]. MinRZ is

[PATCH] D102469: [sanitizer] Reduce redzone size for small size global objects

condy updated this revision to Diff 346612. condy added a comment. Apply optimization when SizeInBytes <= MinRZ/2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102469/new/ https://reviews.llvm.org/D102469 Files:

[PATCH] D102820: [Clang] Check for returns_nonnull when deciding to add allocation null checks

modimo updated this revision to Diff 346610. modimo added a comment. Go back to single statement return, fix up ATTR_BUILTIN_NOTHROW_NEW test label that pointed to nothing to correct ATTR_NOBUILTIN_NOUNWIND_ALLOCSIZE label. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102820/new/

[PATCH] D102820: [Clang] Check for returns_nonnull when deciding to add allocation null checks

modimo created this revision. modimo added reviewers: bruno, lebedev.ri, rsmith. Herald added subscribers: hoy, wenlei, lxfind. modimo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Non-throwing allocators currently will always get

[PATCH] D20401: [Lexer] Don't merge macro args from different macro files

nickdesaulniers added a comment. I know this was sped up slightly in 3339c568c43e4644f02289e5edfc78c860f19c9f, but this change makes `updateConsecutiveMacroArgTokens` the hottest function in clang in a bottom up profile of an entire build of the Linux kernel. It thrashes the one entry

[PATCH] D102818: [PGO] Don't reference functions unless value profiling is enabled

rnk created this revision. rnk added reviewers: vsk, davidxl, Bigcheese. Herald added subscribers: wenlei, hiraditya. rnk requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added a subscriber: Sanitizers. This reduces the size of chrome.dll.pdb built with

[PATCH] D101973: [OpenMP][NFC] Remove SIMD check lines for non-simd tests

jdoerfert updated this revision to Diff 346604. jdoerfert added a comment. Accidentally deleted too many check lines this time ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101973/new/ https://reviews.llvm.org/D101973 Files:

[PATCH] D102814: [AIX] Print printable byte list as quoted string

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/MC/MCAsmStreamer.cpp:1007-1008 +static inline bool isPrintableString(StringRef Data) { + const auto BeginPtr = Data.begin(), EndPtr = Data.end(); + for (const unsigned char C : make_range(BeginPtr, EndPtr)) { +

[PATCH] D100252: [clang] Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete"

super_concat updated this revision to Diff 346595. super_concat added a comment. Correctly handle string literals and add more test cases. Also MSVC by default gives an error when trying to use `__identifier` with a string literal but disabling/surprising that

[PATCH] D102801: [CUDA][HIP] Fix implicit constant variable

tra added a comment. This patch does not appear to fix the second regression introduced by the D102237 . Trying to compile the following code triggers an assertion in CGExpr.cpp: class a { public: a(char *); }; void b() { [](char *c) {

[PATCH] D102237: [CUDA][HIP] Fix non-ODR-use of static device variable

tra added a comment. In D102237#2769475 , @yaxunl wrote: > In D102237#2767538 , @tra wrote: > >> Here's a slightly simpler reproducer: https://godbolt.org/z/rW6P9e37s > > I have a fix for this:

[clang] ac06f6d - [test] Fix test

Author: Fangrui Song Date: 2021-05-19T16:23:52-07:00 New Revision: ac06f6d06de408c00923708dd8a795b6ba9d23d7 URL: https://github.com/llvm/llvm-project/commit/ac06f6d06de408c00923708dd8a795b6ba9d23d7 DIFF: https://github.com/llvm/llvm-project/commit/ac06f6d06de408c00923708dd8a795b6ba9d23d7.diff

[PATCH] D102583: -fno-semantic-interposition: Don't set dso_local on GlobalVariable

thakis added a comment. Looks like this breaks check-clang: http://45.33.8.238/linux/47049/step_7.txt http://45.33.8.238/macm1/9850/step_7.txt PTAL! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102583/new/ https://reviews.llvm.org/D102583

[PATCH] D102583: -fno-semantic-interposition: Don't set dso_local on GlobalVariable

This revision was automatically updated to reflect the committed changes. Closed by commit rG37561ba89b7d: -fno-semantic-interposition: Dont set dso_local on GlobalVariable (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 37561ba - -fno-semantic-interposition: Don't set dso_local on GlobalVariable

Author: Fangrui Song Date: 2021-05-19T16:08:28-07:00 New Revision: 37561ba89b7de57bd8ff5ae0691d02604885d4ee URL: https://github.com/llvm/llvm-project/commit/37561ba89b7de57bd8ff5ae0691d02604885d4ee DIFF: https://github.com/llvm/llvm-project/commit/37561ba89b7de57bd8ff5ae0691d02604885d4ee.diff

[clang] 2f8ac07 - PR50402: Use proper constant evaluation rules for checking constraint

Author: Richard Smith Date: 2021-05-19T16:02:53-07:00 New Revision: 2f8ac0758bbfad72e52ef8602fbbd796e1347784 URL: https://github.com/llvm/llvm-project/commit/2f8ac0758bbfad72e52ef8602fbbd796e1347784 DIFF: https://github.com/llvm/llvm-project/commit/2f8ac0758bbfad72e52ef8602fbbd796e1347784.diff

[PATCH] D102805: [M68k] Allow user to preserve certain registers

nickdesaulniers added a comment. Please fix up the linter warnings; LGTM. Comment at: llvm/lib/Target/M68k/M68kRegisterInfo.cpp:137 + // Registers reserved by users + for (size_t Reg = 0; Reg < getNumRegs(); ++Reg) { +if (MF.getSubtarget().isRegisterReservedByUser(Reg))

[PATCH] D102791: [WebAssembly] Warn on exception spec for Emscripten EH

dschuff added a comment. BTW Is there a way to disable this warning? Since IIUC this could cause code that was not warning (because it used -fno-exceptions or used emscripten's default of -fignore-exceptions) to now start warning, sometimes that makes users who use -Werror unhappy.

[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

nickdesaulniers added a comment. Looking good @myhsu . Also, I got your LLVM book recently! You'll need to sign it for me at the next llvm conf in person. Comment at: clang/lib/Basic/Targets/M68k.cpp:197-199 +std::string R = std::string("^") + std::string(Constraint,

[PATCH] D102614: [index] Add support for type of pointers to class members

akyrtzi added inline comments. Comment at: clang/lib/Index/USRGeneration.cpp:897 +if (const MemberPointerType *MPT = T->getAs()) { + VisitType(QualType(MPT->getClass(), 0)); + Out << "::*"; A bit better to do `VisitTagDecl(MPT->getClass())`, what

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers updated this revision to Diff 346585. nickdesaulniers added a comment. - remove spurious comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102742/new/ https://reviews.llvm.org/D102742 Files:

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers updated this revision to Diff 346584. nickdesaulniers added a comment. Herald added a subscriber: dang. - add cc1 test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102742/new/ https://reviews.llvm.org/D102742 Files:

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic updated this revision to Diff 346582. rsanthir.quic added a comment. Localized changes to Options.td, needed to explicitly add negative flag for -Wframe-larger-than Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

eugenis added a comment. I think it is too hit-and-miss to add even under a flag. It's just not the right approach - but I also don't know what the right approach would be. Perhaps adding a small left redzone for all globals and reducing the right redzone to keep the total size under control?

[PATCH] D101973: [OpenMP][NFC] Remove SIMD check lines for non-simd tests

jdoerfert updated this revision to Diff 346579. jdoerfert added a comment. Make the script remove leftover `CHECK:` lines that would now trigger given the absence of a specific check prefix for the -fopenmp-simd invocations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102772: [SanitizeCoverage] Add support for NoSanitizeCoverage function attribute

melver updated this revision to Diff 346577. melver added a comment. Herald added a subscriber: steven_wu. Rest of long-tail of IR changes related to introducing a new attributes... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102772/new/

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

jsji added a comment. In D102724#2769756 , @jasonliu wrote: > Good idea, fyi, this is the patch: https://reviews.llvm.org/D83252 Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102724/new/

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers added inline comments. Comment at: llvm/include/llvm/IR/Module.h:898 + // enum class StackProtectorGuards { None, TLS, Global, SysReg }; + StringRef getStackProtectorGuard() const; TODO: delete this comment Repository: rG LLVM Github

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers planned changes to this revision. nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:776-783 + if (getCodeGenOpts().StackProtectorGuard != "") +getModule().setStackProtectorGuard(getCodeGenOpts().StackProtectorGuard); +

[PATCH] D102633: [clang-scan-deps] Improvements to thread usage

arphaman added a reviewer: aganea. arphaman added a comment. It might be good for @aganea to take a look as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102633/new/ https://reviews.llvm.org/D102633

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers updated this revision to Diff 346573. nickdesaulniers added a comment. Herald added a subscriber: pengfei. - remove TargetOption members, update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102742/new/

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

jasonliu added a comment. Good idea, fyi, this is the patch: https://reviews.llvm.org/D83252 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102724/new/ https://reviews.llvm.org/D102724 ___ cfe-commits

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang added a comment. In D102736#2769358 , @amccarth wrote: > At some point, the duplicate handle must be closed. I don't see that > happening. I've added an inline comment where I think it should be done. > > (I find it weird that duplicating the

[PATCH] D102814: [AIX] Print printable byte list as quoted string

jsji created this revision. jsji added reviewers: PowerPC, hubert.reinterpretcast, DiggerLin, xingxue, shchenz. Herald added subscribers: hiraditya, nemanjai. jsji requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. .byte

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

jsji added a comment. > because AIX now has an alias implementation. Can we please include the patches or commits that implement the alias? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102724/new/ https://reviews.llvm.org/D102724

[PATCH] D102812: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

mstorsjo updated this revision to Diff 346568. mstorsjo added a comment. Rebased on top of the revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102812/new/ https://reviews.llvm.org/D102812 Files: clang/lib/Driver/ToolChains/Clang.cpp

[clang] 688b917 - Revert "[Driver] Delete -mimplicit-it="

Author: Martin Storsjö Date: 2021-05-20T00:17:50+03:00 New Revision: 688b917b4b3cbe09bf4954b2c10b01ef57386c0a URL: https://github.com/llvm/llvm-project/commit/688b917b4b3cbe09bf4954b2c10b01ef57386c0a DIFF:

[PATCH] D102812: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

mstorsjo created this revision. mstorsjo added reviewers: MaskRay, nickdesaulniers, raj.khem. Herald added a subscriber: kristof.beyls. mstorsjo requested review of this revision. Herald added a project: clang. If multiple instances of the -arm-implicit-it option is passed to the backend, it

[PATCH] D102469: [sanitizer] Reduce redzone size for small size global objects

vitalybuka added a comment. Do you need help with landing thin? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102469/new/ https://reviews.llvm.org/D102469 ___ cfe-commits mailing list

[PATCH] D102469: [sanitizer] Reduce redzone size for small size global objects

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2556 + uint64_t RZ = 0; + if (SizeInBytes < MinRZ / 2) { +// Reduce redzone size for small size objects, e.g. int, char[1]. MinRZ is MaskRay wrote: > I

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102724/new/ https://reviews.llvm.org/D102724

[PATCH] D102568: [Driver] Delete -mimplicit-it=

mstorsjo added inline comments. Comment at: clang/test/Driver/arm-target-as-mimplicit-it.s:18 /// Test comma separated -Wa,- arguments (latter wins). // RUN: %clang -target arm-linux-gnueabi -### -Wa,-mimplicit-it=never,-mimplicit-it=always %s 2>&1 | FileCheck %s

[PATCH] D102807: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

Jake-Egan abandoned this revision. Jake-Egan added a comment. Duplicate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102807/new/ https://reviews.llvm.org/D102807 ___ cfe-commits mailing list

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

Jake-Egan updated this revision to Diff 346560. Jake-Egan added a comment. Added the changes jasonliu asked for. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102724/new/ https://reviews.llvm.org/D102724 Files:

[PATCH] D102801: [CUDA][HIP] Fix implicit constant variable

tra added a reviewer: rsmith. tra added a subscriber: rsmith. tra added a comment. Tentative LGTM as we need it to fix the regression soon. Summoning @rsmith for the 'big picture' opinion. While the patch may fix this particular regression, I wonder if there's a better way to deal with this.

[PATCH] D102807: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

Jake-Egan created this revision. Herald added a subscriber: jeroen.dobbelaere. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit b116ded57da3530e661f871f4191c59cd9e091cd

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

apazos added inline comments. Comment at: clang/lib/Basic/Warnings.cpp:101 +Opt = "no-frame-larger-than="; + // Check to see if this warning starts with "no-", if so, this is a Since GCC supports the negative option -Wno-stack-usage, I think it is

[PATCH] D102805: [M68k] Allow user to preserve certain registers

myhsu created this revision. myhsu added reviewers: nickdesaulniers, simoncook. Herald added subscribers: dang, s.egerton, hiraditya. myhsu requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Add `-ffixed-a[0-6]` and

[PATCH] D100991: Fix parsing of vector keyword in presence of conflicting uses.

jamieschmeiser updated this revision to Diff 346548. jamieschmeiser added a comment. Expand testing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100991/new/ https://reviews.llvm.org/D100991 Files: clang/lib/Parse/Parser.cpp clang/test/Parser/altivec-non-type-vector.c

[clang] d38057f - Treat implicit deduction guides as being equivalent to their

Author: Richard Smith Date: 2021-05-19T13:31:53-07:00 New Revision: d38057f3ecb080e0ae4aba367a737226221327f2 URL: https://github.com/llvm/llvm-project/commit/d38057f3ecb080e0ae4aba367a737226221327f2 DIFF: https://github.com/llvm/llvm-project/commit/d38057f3ecb080e0ae4aba367a737226221327f2.diff

[PATCH] D102469: [sanitizer] Reduce redzone size for small size global objects

MaskRay accepted this revision. MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2556 + uint64_t RZ = 0; + if (SizeInBytes < MinRZ / 2) { +// Reduce redzone size for small size objects, e.g. int, char[1]. MinRZ is

[PATCH] D102583: -fno-semantic-interposition: Don't set dso_local on GlobalVariable

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102583/new/ https://reviews.llvm.org/D102583 ___

[PATCH] D102237: [CUDA][HIP] Fix non-ODR-use of static device variable

yaxunl added a comment. In D102237#2767538 , @tra wrote: > Here's a slightly simpler reproducer: https://godbolt.org/z/rW6P9e37s I have a fix for this: https://reviews.llvm.org/D102801 It seems the issue was due to clang emits the implicit constant

[PATCH] D102696: [Analyzer] Find constraints that are directly attached to a BinOp

NoQ added a comment. In D102696#2767894 , @martong wrote: >> In this case the equations are $y == 0 and $x + 0 == 0 which is much easier >> to solve. > > Yes, you are right. > >> This happens for the same reason that your patch is needed in the first

[PATCH] D102801: [CUDA][HIP] Fix implicit constant variable

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a reviewer: aaron.ballman. yaxunl requested review of this revision. constexpr variables are implicit constant variables in device compilation. Not all constexpr variables are valid to be emitted on device side, therefore we

[PATCH] D102568: [Driver] Delete -mimplicit-it=

MaskRay added a comment. In D102568#2769401 , @dblaikie wrote: > Ah, thanks for the history. Yeah, still not sure those bugs are on equal > footing - if the patch had been in for a few months before musl was fixed (If > they're interested in building

[PATCH] D102568: [Driver] Delete -mimplicit-it=

mstorsjo added a comment. In D102568#2769390 , @MaskRay wrote: > In D102568#2769340 , @mstorsjo > wrote: > >> In the meantime, wouldn't it be possible to detect the presence of the other >> one and check if

[PATCH] D102568: [Driver] Delete -mimplicit-it=

dblaikie added a comment. In D102568#2769395 , @MaskRay wrote: > In D102568#2769389 , @dblaikie > wrote: > >> In D102568#2769341 , @MaskRay >> wrote: >> >>> I think

[PATCH] D102568: [Driver] Delete -mimplicit-it=

MaskRay added a comment. In D102568#2769389 , @dblaikie wrote: > In D102568#2769341 , @MaskRay wrote: > >> I think libvpx's ASFLAGS usage is about GNU as, not the driver option. >> >> In D102568#2769296

[PATCH] D102459: [clang][ObjC] Allow different availability annotation on a method when implementing an optional protocol requirement

This revision was automatically updated to reflect the committed changes. Closed by commit rG50be48b0f3c8: [clang][ObjC] Allow different availability annotation on a method (authored by arphaman). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 50be48b - [clang][ObjC] Allow different availability annotation on a method

Author: Alex Lorenz Date: 2021-05-19T12:13:57-07:00 New Revision: 50be48b0f3c884a87ddf19c7c51abcab035c1efb URL: https://github.com/llvm/llvm-project/commit/50be48b0f3c884a87ddf19c7c51abcab035c1efb DIFF: https://github.com/llvm/llvm-project/commit/50be48b0f3c884a87ddf19c7c51abcab035c1efb.diff

[PATCH] D102568: [Driver] Delete -mimplicit-it=

MaskRay added a comment. In D102568#2769340 , @mstorsjo wrote: > In the meantime, wouldn't it be possible to detect the presence of the other > one and check if they match or not, to avoid passing duplicate options to the > backend? I can give that a

[PATCH] D102568: [Driver] Delete -mimplicit-it=

dblaikie added a comment. In D102568#2769341 , @MaskRay wrote: > I think libvpx's ASFLAGS usage is about GNU as, not the driver option. > > In D102568#2769296 , @dblaikie > wrote: > >>> I think "waiting for a

[PATCH] D102784: [Diagnostics] Allow emitting analysis and missed remarks on functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG2db182ff8d0c: [Diagnostics] Allow emitting analysis and missed remarks on functions (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D102784?vs=346516=346531#toc Repository:

[clang] 2db182f - [Diagnostics] Allow emitting analysis and missed remarks on functions

Author: Joseph Huber Date: 2021-05-19T15:10:20-04:00 New Revision: 2db182ff8d0c0d50155bf70d1db60b4e78c348ca URL: https://github.com/llvm/llvm-project/commit/2db182ff8d0c0d50155bf70d1db60b4e78c348ca DIFF: https://github.com/llvm/llvm-project/commit/2db182ff8d0c0d50155bf70d1db60b4e78c348ca.diff

[PATCH] D102736: Fix tmp files being left on Windows builds.

amccarth requested changes to this revision. amccarth added a comment. This revision now requires changes to proceed. Sorry, forgot to Request Changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102736/new/ https://reviews.llvm.org/D102736

[PATCH] D102736: Fix tmp files being left on Windows builds.

amccarth added a comment. At some point, the duplicate handle must be closed. I don't see that happening. I've added an inline comment where I think it should be done. (I find it weird that duplicating the handle seems necessary.) At a high level, it seems a shame that `llvm::support::fs`

[PATCH] D102568: [Driver] Delete -mimplicit-it=

mstorsjo added a comment. In D102568#2769341 , @MaskRay wrote: > I think libvpx's ASFLAGS usage is about GNU as, not the driver option. It is indeed for calling a GNU as-like tool, but at

[PATCH] D102568: [Driver] Delete -mimplicit-it=

MaskRay added a comment. I think libvpx's ASFLAGS usage is about GNU as, not the driver option. In D102568#2769296 , @dblaikie wrote: >> I think "waiting for a few releases" is too much and doesn't improve things >> (they will notice issues until you

[PATCH] D102568: [Driver] Delete -mimplicit-it=

mstorsjo added a comment. In D102568#2769267 , @MaskRay wrote: > I don't mind reverting this temporarily. > However, reverting this would break musl build. > musl (since 2018-09) detects both options and will add both if available: >

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

weiwang added a comment. Tried to make `Sema::DeclsToCheckForDeferredDiags` `llvm::SmallSetVector`. The heap RSS did drop significantly (from peak 100GB to 59GB) , but not as good as the current fix (peak 26GB), which makes `ASTReader::DeclsToCheckForDeferredDiags` `llvm::SmallSetVector`. I

[PATCH] D102568: [Driver] Delete -mimplicit-it=

dblaikie added a comment. > I think "waiting for a few releases" is too much and doesn't improve things > (they will notice issues until you remove the option). I can accept "waiting > for one major release". Having fairly broad windows of not breaking backwards compatibility is a fairly

[PATCH] D102568: [Driver] Delete -mimplicit-it=

MaskRay added a comment. In D102568#2769237 , @mstorsjo wrote: > In D102568#2769053 , > @nickdesaulniers wrote: > >>> But this change did break my build in these places: >>>

[PATCH] D102715: Fix LIT failure on native aix

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang/test/Sema/struct-packed-align.c:170 +#elif defined(_AIX) +// On AIX, [bool, char, short] bitfields have the same alignment as unsigned +// int. hubert.reinterpretcast

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

dblaikie added a comment. Generally looks reasonable to me - but I'll leave signoff to some other folks who have been more involved in the discussion so far. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/

[PATCH] D102568: [Driver] Delete -mimplicit-it=

mstorsjo added a comment. In D102568#2769053 , @nickdesaulniers wrote: >> But this change did break my build in these places: >> https://code.videolan.org/videolan/x264/-/blob/b684ebe04a6f80f8207a57940a1fa00e25274f81/configure#L855 >>

[PATCH] D102791: [WebAssembly] Warn on exception spec for Emscripten EH

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100. aheejin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It turns out we have not correctly

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser requested review of this revision. jamieschmeiser added a comment. Significant changes made since previously accepted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 ___ cfe-commits

  1   2   >