[PATCH] D103434: [analyzer] Allow visitors to run callbacks on completion

RedDocMD created this revision. RedDocMD added reviewers: NoQ, vsavchenko, xazax.hun, teemperor. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. RedDocMD requested review of this

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

tlively accepted this revision. tlively added a comment. In D101140#2789199 , @wingo wrote: > Quick r? to @tlively -- OK with having the new util function in > WebAssemblyFrameLowering? It didn't work to have it in the utils library > because the

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

walli99 added a comment. انت Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99645/new/ https://reviews.llvm.org/D99645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102582: [RISCV] Report an error when ABI mismatch with target-abi module flag.

khchen updated this revision to Diff 348870. khchen added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Revert to previous revision Diff 347356 and add empty module flag could be empty in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103080: [CMake] Ignore arm_*.h for non-ARM build

sunlin added a comment. Hi @kristof.beyls The original `lib/clang/12.0.1/include` is about total ~10M, and the `arm*.h` take about ~5M. Ignore these unused header files will save the developers who work on the low storage device. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D103319: [analyzer] Use Optional as a return type of StoreManager::castRegion

NoQ added a comment. In D103319#2788304 , @ASDenysPetrov wrote: > WDYT? Fair point! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103319/new/ https://reviews.llvm.org/D103319

[PATCH] D88084: [clang-format] Changed default styles BraceWrappping bool table to directly use variables

HazardyKnusperkeks added a comment. Under "Related Objects" you can add the commit, so that one can navigate to it. And as action there is "Close Revision", which marks this as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88084/new/

[PATCH] D100782: [PowerPC] Improve f32 to i32 bitcast code gen

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdb26cd30b6dd: [PowerPC] Improve f32 to i32 bitcast code gen (authored by Conanap). Changed prior to commit:

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

ldionne updated this revision to Diff 348861. ldionne added a comment. Fix embarrassingly obvious oversight when I applied Aaron's feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91630/new/ https://reviews.llvm.org/D91630 Files:

[PATCH] D102723: [HIP] Tighten checks in hip-include-path.hip test case

bjope added a comment. I relaxed the checks a bit again here: https://reviews.llvm.org/rGf0e10cc91bc4 But it looks like the workers here (https://lab.llvm.org/staging/#/workers/109) are paused so hard to tell if it helped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f0e10cc - [HIP] Relax checks in hip-include-path.hip test case again

Author: Bjorn Pettersson Date: 2021-05-31T22:40:21+02:00 New Revision: f0e10cc91bc40fb5c0698846f0a324d4658f54c7 URL: https://github.com/llvm/llvm-project/commit/f0e10cc91bc40fb5c0698846f0a324d4658f54c7 DIFF:

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

ldionne updated this revision to Diff 348859. ldionne added a comment. Rebase onto `main`. I want to trigger CI again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91630/new/ https://reviews.llvm.org/D91630 Files:

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

ldionne added a comment. In D91630#2787438 , @thakis wrote: > This is breaking check-clang everywhere, eg > https://lab.llvm.org/buildbot/#/builders/109/builds/15757 > > Please run tests before landing, or failing that watch the bots after > committing.

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

MarcusJohnson91 created this revision. MarcusJohnson91 created this object with visibility "All Users". MarcusJohnson91 added a project: clang. Herald added a subscriber: martong. Herald added a reviewer: aaron.ballman. MarcusJohnson91 requested review of this revision. Herald added a project:

[PATCH] D88084: [clang-format] Changed default styles BraceWrappping bool table to directly use variables

MarcusJohnson91 added a comment. @MyDeveloperDay This patch was merged upstream a long time ago, how do I close it here on Phabricator? thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88084/new/ https://reviews.llvm.org/D88084

[PATCH] D103386: [PowerPC] Fix x86 vector intrinsics wrapper compilation under C++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc0b3071833a8: [PowerPC] Fix x86 vector intrinsics wrapper compilation under C++ (authored by qiucf, committed by ecnelises). Changed prior to

[clang] c0b3071 - [PowerPC] Fix x86 vector intrinsics wrapper compilation under C++

Author: Qiu Chaofan Date: 2021-06-01T01:19:12+08:00 New Revision: c0b3071833a80121a5a7ca9ea54fd59a59806acc URL: https://github.com/llvm/llvm-project/commit/c0b3071833a80121a5a7ca9ea54fd59a59806acc DIFF: https://github.com/llvm/llvm-project/commit/c0b3071833a80121a5a7ca9ea54fd59a59806acc.diff

[PATCH] D102723: [HIP] Tighten checks in hip-include-path.hip test case

yaxunl added a comment. In D102723#2789610 , @bjope wrote: > In D102723#2789537 , @yaxunl wrote: > >> It seems we cannot introduce `ROOT` by line 19 since it is not used in other >> lines in situations where

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

hans added a comment. In D102517#2789593 , @AbbasSabra wrote: > In D102517#2789450 , @goncharov > wrote: > >> Sorry, had to revert it as this fails under sanitizer : >>

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG116179c2ee52: Re-commit [clang] Add support for the abstract

[clang] 116179c - Re-commit [clang] Add support for the "abstract" contextual keyword of MSVC

Author: Abbas Sabra Date: 2021-05-31T18:45:26+02:00 New Revision: 116179c2ee5213f2ae8f07a400ac98f0c995b3d3 URL: https://github.com/llvm/llvm-project/commit/116179c2ee5213f2ae8f07a400ac98f0c995b3d3 DIFF: https://github.com/llvm/llvm-project/commit/116179c2ee5213f2ae8f07a400ac98f0c995b3d3.diff

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

cor3ntin updated this revision to Diff 348828. cor3ntin added a comment. Cleanup tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103380/new/ https://reviews.llvm.org/D103380 Files: clang/lib/Sema/SemaConcept.cpp

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. LGTM, but I'm neither a Clang nor core expert (and I'm not a maintainer), so please wait for others' approval. Comment at:

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

vsavchenko added a comment. I had another thought, `merge` is usually called in situations when we found out that two symbols should be marked equal (and checked that it's possible to begin with), which is not true in your case. If we update my case from before, we can get: `a + b == c` and `a

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1576-1577 + // Add the newly simplified symbol to the equivalence class. + State = + Class.merge(this->getBasicVals(), F, State, +

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

vsavchenko added a comment. That's awesome, just a few stylistic tweaks and tests and we are to land! Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1561-1562 + +if (!Constraint.getConcreteValue()) + return State; + I think we

[PATCH] D102723: [HIP] Tighten checks in hip-include-path.hip test case

bjope added a comment. In D102723#2789537 , @yaxunl wrote: > It seems we cannot introduce `ROOT` by line 19 since it is not used in other > lines in situations where working directories have sym links. > > Instead, we just change `{{.*}}clang/` to

[PATCH] D90188: Add support for attribute 'using_if_exists'

ldionne updated this revision to Diff 348810. ldionne added a comment. Herald added a project: clang. Rebase onto `main`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90188/new/ https://reviews.llvm.org/D90188 Files:

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

martong updated this revision to Diff 348808. martong marked an inline comment as done. martong added a comment. - Merge the simplified symbol to the old class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103314/new/

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1561 + return nullptr; + +ConstraintMap CM = getConstraintMap(State); vsavchenko wrote: > Also I think we can

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

AbbasSabra added a comment. In D102517#2789450 , @goncharov wrote: > Sorry, had to revert it as this fails under sanitizer : > https://lab.llvm.org/buildbot/#/builders/5/builds/8150 Thanks! I missed adding "Ident_abstract" in the Parser initialize

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

AbbasSabra updated this revision to Diff 348806. AbbasSabra added a comment. Updating D102517 : [clang]Fix use-of-uninitialized-value detected by the sanitizer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103080: [CMake] Ignore arm_*.h for non-ARM build

kristof.beyls added a comment. I'm wondering what the rationale for this change is. If there is a good rationale for this; wouldn't it need to be applied to all target-specific header files, not only the Arm-specific header files? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D102723: [HIP] Tighten checks in hip-include-path.hip test case

yaxunl added a comment. It seems we cannot introduce `ROOT` by line 19 since it is not used in other lines in situations where working directories have sym links. Instead, we just change `{{.*}}clang/` to `{{.*}}/lib/clang/` in other lines. Hopefully this will still work. Repository: rG

[PATCH] D103131: support debug info for alias variable

probinson added a comment. > Mixed feelings - somewhat in favor of "do the thing that's probably already > fairly tested/known to work" (GCC's thing). But open to the idea that that > approach has problems, for sure. "Known to work" for whom? gdb, sure, because gcc/gdb cooperate on many

[PATCH] D103286: [clang-format] Add PPIndentWidth option

gergap added a comment. @HazardyKnusperkeks could you please land this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103286/new/ https://reviews.llvm.org/D103286 ___ cfe-commits mailing list

[PATCH] D103286: [clang-format] Add PPIndentWidth option

gergap updated this revision to Diff 348794. gergap added a comment. changed wording as requested and updated release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103286/new/ https://reviews.llvm.org/D103286 Files:

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

gergap added a comment. In D103245#2789423 , @HazardyKnusperkeks wrote: > Thank you very much. :) > Do you have commit access, or do you need someone to land it? If the latter > please state name and email for the commit. I started working on this

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

gergap updated this revision to Diff 348791. gergap added a comment. update release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103245/new/ https://reviews.llvm.org/D103245 Files: clang/docs/ReleaseNotes.rst

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

goncharov added a comment. Sorry, had to revert it as this fails under sanitizer : https://lab.llvm.org/buildbot/#/builders/5/builds/8150 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102517/new/ https://reviews.llvm.org/D102517

[clang] c36ff64 - Revert "[clang] Add support for the "abstract" contextual keyword of MSVC"

Author: Mikhail Goncharov Date: 2021-05-31T15:34:20+02:00 New Revision: c36ff6424f249d3e2005fb0589337452cd7ddad3 URL: https://github.com/llvm/llvm-project/commit/c36ff6424f249d3e2005fb0589337452cd7ddad3 DIFF:

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Removing from queue - i don't expect to review this. Looks like this has been reverted twice now, presumably llvm stage 2/linux kernel/chrome should be enough of a coverage to be

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

dblaikie added a comment. In D101921#2786245 , @MaskRay wrote: > Because of `new MCObjectFileInfo`, we cannot use a forward declaration > (incomplete class) to replace `#include "llvm/MC/MCObjectFileInfo.h"` in > `TargetRegistry.h`. > > I thought about

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added a comment. @NoQ This solution only intends to make correct calculations whenever cast occures. We can mark this as //alpha// or add an argument flag to turn cast reasoning on/off, or we can even disable any part of this patch with argument settings. > But this still

[PATCH] D103393: [clangd] Bump recommended gRPC version (1.33.2 -> 1.36.3)

kadircet added a comment. I think we should wait for build bot update on this one too. Otherwise we might miss some breakages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103393/new/ https://reviews.llvm.org/D103393

[libunwind] 2fc05fd - [libunwind] fix -Wc++98-compat-extra-semi without _LIBUNWIND_HIDE_SYMBOLS

Author: Nico Weber Date: 2021-05-31T08:54:53-04:00 New Revision: 2fc05fdc156fab5a7a7ef1d5b7d217ffa766d86f URL: https://github.com/llvm/llvm-project/commit/2fc05fdc156fab5a7a7ef1d5b7d217ffa766d86f DIFF: https://github.com/llvm/llvm-project/commit/2fc05fdc156fab5a7a7ef1d5b7d217ffa766d86f.diff

[PATCH] D103377: [clangd] Add ability to change storage directory of index files

kadircet added a comment. > Strictly speaking you could, assuming you have a compile database and it's > okay to have copies or symlinks of the database. Well you wouldn't have index shards without a compilation database anyway though. > That does speak to another issue though; moving the

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

HazardyKnusperkeks added a comment. Forgot about that: Please add an entry in the ReleaseNotes.rst, I can imagine there are some people out there waiting for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103245/new/

[PATCH] D103286: [clang-format] Add PPIndentWidth option

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Looks good to me, I would just change the wording a bit. Could you please also add a entry in the ReleaseNotes.rst? Comment at:

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Thank you very much. :) Do you have commit access, or do you need someone to land it? If the latter please state name and email for the commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103377: [clangd] Add ability to change storage directory of index files

crr0004 added a comment. Strictly speaking you could, assuming you have a compile database and it's okay to have copies or symlinks of the database. I would have probably done that if I had realised I could. That does speak to another issue though; moving the compile database to move the

[PATCH] D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines

Jeroen added a comment. In D14484#2788953 , @FStefanni wrote: > Hi, > > in case of any doubt: yet it is of interest. > 6 years old means only that it has not been "fixed" in the meanwhile... > > Please consider that there are not many code formatters for

[PATCH] D103401: [OpenCL] Add support of __opencl_c_generic_address_space feature macro

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: ldrumm, kerbowa, yaxunl, nhaehnle, jvesely. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[clang] 8006ac7 - fix test for symlinked clang c1ee4fb5af49a

Author: Mikhail Goncharov Date: 2021-05-31T13:29:33+02:00 New Revision: 8006ac7fe449e272385b85db80d22c924ab61d3a URL: https://github.com/llvm/llvm-project/commit/8006ac7fe449e272385b85db80d22c924ab61d3a DIFF:

[PATCH] D101429: PR45879: Use LValue object to evaluate active union members

sepavloff abandoned this revision. sepavloff added a comment. Alternative implementation in in https://reviews.llvm.org/D103395. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101429/new/ https://reviews.llvm.org/D101429

[PATCH] D103395: PR45879: Keep evaluated expression in LValue object

sepavloff created this revision. sepavloff added a reviewer: rsmith. sepavloff requested review of this revision. Herald added a project: clang. Class LValue keeps result of lvalue evaluation. In some analyses it is also necessary to have access to the original expression. This change adds new

[PATCH] D103393: [clangd] Bump recommended gRPC version (1.33.2 -> 1.36.3)

kbobyrev added a comment. I don't really know if we should do this before the buildbot update so I just wanted to know your opinion @kadircet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103393/new/ https://reviews.llvm.org/D103393

[PATCH] D103393: [clangd] Bump recommended gRPC version (1.33.2 -> 1.36.3)

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Context:

[clang] a723ca3 - fix broken clang tests after 7161bb87c914

Author: Juneyoung Lee Date: 2021-05-31T19:25:14+09:00 New Revision: a723ca32af896d99058672a43fe457ba155a23b2 URL: https://github.com/llvm/llvm-project/commit/a723ca32af896d99058672a43fe457ba155a23b2 DIFF: https://github.com/llvm/llvm-project/commit/a723ca32af896d99058672a43fe457ba155a23b2.diff

[PATCH] D103386: [PowerPC] Fix x86 vector intrinsics wrapper compilation under C++

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing this. Comment at: clang/lib/Headers/ppc_wrappers/xmmintrin.h:31 use vector SIMD operations. We recommend this for new applications. */

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

cor3ntin updated this revision to Diff 348759. cor3ntin added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103380/new/ https://reviews.llvm.org/D103380 Files: clang/lib/Sema/SemaConcept.cpp

[PATCH] D103377: [clangd] Add ability to change storage directory of index files

kadircet added a comment. > I mainly added this because I am doing profiling of indexing and needed a way > for multiple instances of index files not to conflict with each other. If this is solely for testing purposes, can't you make use of `--compile-commands-dir` instead? You'll also need to

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo added a comment. Quick r? to @tlively -- OK with having the new util function in WebAssemblyFrameLowering? It didn't work to have it in the utils library because the function needs the vtable of WebAssemblyFunctionInfo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo updated this revision to Diff 348758. wingo added a comment. Fix shared-library build by moving util function to WebAssemblyFrameLowering. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101140/new/ https://reviews.llvm.org/D101140 Files:

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

whisperity added a comment. Bump.  This is the last part that's still unreviewed and also the most complex. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75041/new/ https://reviews.llvm.org/D75041 ___

[PATCH] D103286: [clang-format] Add PPIndentWidth option

gergap updated this revision to Diff 348753. gergap marked an inline comment as done. gergap added a comment. fix review findings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103286/new/ https://reviews.llvm.org/D103286 Files:

[PATCH] D103286: [clang-format] Add PPIndentWidth option

gergap marked 3 inline comments as done. gergap added a comment. I fixed the review findings and changed the behavior to be better backwards compatible by using PPIndentWidth=-1 by default. This value defaults to IndentWidth now. Comment at:

[PATCH] D103229: [clang] NFC: split HeaderMapTest to have re-usable header map implementation for testing

This revision was automatically updated to reflect the committed changes. Closed by commit rG37b530a2ea8b: [clang] NFC: split HeaderMapTest to have re-usable header map implementation… (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 37b530a - [clang] NFC: split HeaderMapTest to have re-usable header map implementation for testing

Author: Dmitry Polukhin Date: 2021-05-31T01:57:36-07:00 New Revision: 37b530a2ea8bdc28a22a3f8ca701455fb7febdea URL: https://github.com/llvm/llvm-project/commit/37b530a2ea8bdc28a22a3f8ca701455fb7febdea DIFF:

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo reopened this revision. wingo added a comment. This revision is now accepted and ready to land. Yarrrgh, broke the shared library build. Fix incoming... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101140/new/

[PATCH] D103387: [clangd] Fix feature modules to drop diagnostics

kadircet updated this revision to Diff 348747. kadircet added a comment. Get rid of LastDiagWasSuppressed state in StoreDiags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103387/new/ https://reviews.llvm.org/D103387 Files:

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

hans added a comment. Pushed as http://github.com/llvm/llvm-project/commit/818338add77411f5e9713247ea66142f332ef350 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102517/new/ https://reviews.llvm.org/D102517

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG818338add774: [clang] Add support for the abstract contextual keyword of MSVC (authored by AbbasSabra, committed by hans). Repository: rG LLVM

[clang] 818338a - [clang] Add support for the "abstract" contextual keyword of MSVC

Author: Abbas Sabra Date: 2021-05-31T10:44:53+02:00 New Revision: 818338add77411f5e9713247ea66142f332ef350 URL: https://github.com/llvm/llvm-project/commit/818338add77411f5e9713247ea66142f332ef350 DIFF: https://github.com/llvm/llvm-project/commit/818338add77411f5e9713247ea66142f332ef350.diff

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf35f4af51cd: [WebAssembly][CodeGen] IR support for WebAssembly local variables (authored by wingo). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo added a comment. In D101140#2786870 , @jrtc27 wrote: > In D101140#2786844 , @wingo wrote: > >> In D101140#2786777 , @jrtc27 wrote: >> >>> Is it just me or does

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

gergap updated this revision to Diff 348736. gergap added a comment. remove `continue` statement from AlignTokenSequence as requested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103245/new/ https://reviews.llvm.org/D103245 Files:

[PATCH] D103387: [clangd] Fix feature modules to drop diagnostics

kadircet updated this revision to Diff 348733. kadircet added a comment. Exit after introducing cleanup function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103387/new/ https://reviews.llvm.org/D103387 Files:

[PATCH] D103387: [clangd] Fix feature modules to drop diagnostics

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Ignored diagnostics were only

[PATCH] D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines

FStefanni added a comment. Hi, in case of any doubt: yet it is of interest. 6 years old means only that it has not been "fixed" in the meanwhile... Please consider that there are not many code formatters for C++, since it is quite a complex language (and a lot of different formatting

[clang-tools-extra] e972068 - [clangd] Move gtest include to TestTU.cpp from TestTU.h

Author: Kadir Cetinkaya Date: 2021-05-31T07:56:56+02:00 New Revision: e972068840710a8c832d21603b8409692604b865 URL: https://github.com/llvm/llvm-project/commit/e972068840710a8c832d21603b8409692604b865 DIFF: