[PATCH] D102914: [analyzer] Make checker silencing work for non-pathsensitive bug reports

NoQ accepted this revision. NoQ added a comment. > Checker silencing used to kick in after all of these. Now it does before any > of them :^) This is probably the main benefit of the patch. Running visitors is cheap most of the time but it can be expensive. Silencing path-insensitive checkers

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. Conanap requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch implements trap and FP to and from double conversions. The

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

NoQ added a comment. Ok. Oof. Whoa. That's amazing. Let me re-iterate to make sure that my understanding of this patchset is correct. **Chapter 1.** //"A is correlated with B (ρ = 0.56), given C, assuming D and under E conditions"// - Two new entities are introduced: trackers and handlers. -

[PATCH] D103667: [WIP] BPF: add support for DWARF_AT_LLVM_annotations attribute

dblaikie added subscribers: JDevlieghere, probinson, aprantl. dblaikie added a comment. Is the C source syntax already fixed? Could it use a more specific name - then maybe wouldn't need the flag to opt-in if the only places the attribute appears is where it should be propagated? This'll end

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'.

Meinersbur marked 8 inline comments as done. Meinersbur added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:463-478 + static const SpecificClause *getSingleClause(ArrayRef Clauses) { +auto ClausesOfKind = getClausesOfKind(Clauses); -if

[PATCH] D103667: [WIP] BPF: add support for DWARF_AT_LLVM_annotations attribute

yonghong-song created this revision. yonghong-song added a reviewer: dblaikie. yonghong-song added a project: debug-info. Herald added subscribers: dexonsmith, dang, ormris, hiraditya. yonghong-song requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers:

[PATCH] D103666: [Clang][OpenMP] Refactor checking for mutually exclusive clauses. NFC.

Meinersbur created this revision. Meinersbur added a reviewer: ABataev. Meinersbur added a project: OpenMP. Herald added subscribers: guansong, yaxunl. Meinersbur requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Herald added a project:

[PATCH] D103665: [Clang][OpenMP] Add static version of getSingleClause NFC.

Meinersbur updated this revision to Diff 349762. Meinersbur edited the summary of this revision. Meinersbur added a comment. Add context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103665/new/ https://reviews.llvm.org/D103665 Files:

[PATCH] D103665: [Clang][OpenMP] Add static version of getSingleClause NFC.

Meinersbur created this revision. Meinersbur added a reviewer: ABataev. Meinersbur added a project: OpenMP. Herald added subscribers: guansong, yaxunl. Meinersbur requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a

[PATCH] D103563: [HIP] Fix amdgcn builtin for long type

yaxunl added a comment. In D103563#2797917 , @rjmccall wrote: > If you want a way to say "some 64-bit type" in the builtins file, we could > add that. It is already there. The width modifier `W` means 64-bit. Repository: rG LLVM Github Monorepo

[PATCH] D103527: [Clang][RISCV] Implement vlseg and vlsegff.

HsiangKai updated this revision to Diff 349754. HsiangKai added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103527/new/ https://reviews.llvm.org/D103527 Files: clang/include/clang/Basic/IdentifierTable.h

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

tentzen created this revision. tentzen added reviewers: asmith, aganea, zahiraam. tentzen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes a Windows -EHa crash induced by previous commit

[PATCH] D103613: [flang][driver] Add support for `-module-suffix`

PeteSteinfeld accepted this revision. PeteSteinfeld added a comment. This revision is now accepted and ready to land. All builds, tests, and looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103613/new/ https://reviews.llvm.org/D103613

[PATCH] D102822: [Clang][CodeGen] Set the size of llvm.lifetime to unknown for scalable types.

HsiangKai updated this revision to Diff 349751. HsiangKai added a comment. clang format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102822/new/ https://reviews.llvm.org/D102822 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D102822: [Clang][CodeGen] Set the size of llvm.lifetime to unknown for scalable types.

HsiangKai updated this revision to Diff 349750. HsiangKai added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102822/new/ https://reviews.llvm.org/D102822 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas updated this revision to Diff 349749. manas added a comment. Added tests for residual paths and negation of certain values, and fixed expected warnings for UNKNOWN cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103440/new/

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added a comment. > I also would like to see tests where the ranges are not going all the way to > either INT_MIN or INT_MAX (if we talk about int), but overflow still might > happen, and cases where overflow might happen, but we still can identify the > overflowing results precisely

[PATCH] D103603: [Sema][RISCV][SVE] Allow ?: to select Typedef BuiltinType in C

rjmccall accepted this revision. rjmccall added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103603/new/ https://reviews.llvm.org/D103603 ___ cfe-commits mailing list

[PATCH] D101156: [Clang] Support a user-defined __dso_handle

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4425 + if (ReplaceInitWithGV) +Init = llvm::ConstantExpr::getBitCast(GV, GV->getValueType()); + Can we actually do this bitcast for arbitrary initializers? This seems

[PATCH] D103563: [HIP] Fix amdgcn builtin for long type

rjmccall added a comment. If you want a way to say "some 64-bit type" in the builtins file, we could add that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103563/new/ https://reviews.llvm.org/D103563

[PATCH] D103564: [NFC][compiler-rt][hwasan] Wrap fork interceptor with HWASAN_WITH_INTERCEPTORS

mcgrathr added a comment. In D103564#2797657 , @leonardchan wrote: > I don't think we can move the `__sanitizer_*` allocation functions since > they're used for aliases for their libc equivalents which require definitions > in the same TU: What I

[PATCH] D103658: CUDA/HIP: Change device-use-host-var.cu's NOT "external" check to include "addrspace"

yaxunl accepted this revision. yaxunl added a comment. LGTM. thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103658/new/ https://reviews.llvm.org/D103658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D103658: CUDA/HIP: Change device-use-host-var.cu's NOT "external" check to include "addrspace"

kzhuravl updated this revision to Diff 349732. kzhuravl marked an inline comment as done. kzhuravl added a comment. Address review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103658/new/ https://reviews.llvm.org/D103658 Files:

[PATCH] D103589: [Format] Fix incorrect pointer detection

Nuu added a comment. In D103589#2796032 , @curdeius wrote: > LGTM. Thanks for fixing this! > Do you have commit rights or you need somebody to land it for you? I don't have commit access. I'd appreciate it if you or someone else could land this

[PATCH] D103658: CUDA/HIP: Change device-use-host-var.cu's NOT "external" check to include "addrspace"

tra added inline comments. Comment at: clang/test/CodeGenCUDA/device-use-host-var.cu:68 // NEG-NOT: @_ZL13var_host_only -// NEG-NOT: external +// NEG-NOT: external addrspace This may be too specific. What if we end up generating a variable in generic AS

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 updated this revision to Diff 349730. feg208 added a comment. Had some invalid code in the lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D103658: CUDA/HIP: Change device-use-host-var.cu's NOT "external" check to include "addrspace"

kzhuravl created this revision. kzhuravl added a reviewer: yaxunl. kzhuravl requested review of this revision. Herald added a subscriber: wdng. Otherwise it is causing one of our build jobs to fail, it is using "external" as directory, and NOT is failing because "external" is found in ModuleID.

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 updated this revision to Diff 349728. feg208 added a comment. Rebased against main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D100917: [NewPM] Only invalidate modified functions' analyses in CGSCC passes

aeubanks reopened this revision. aeubanks added a comment. This revision is now accepted and ready to land. Herald added a subscriber: ormris. Using valgrind's massif, I profiled using clang build build PassBuilder.cpp (it's one of the longest LLVM files to compile), and at peak memory usage:

[PATCH] D103563: [HIP] Fix amdgcn builtin for long type

This revision was automatically updated to reflect the committed changes. Closed by commit rGe42def62d8d9: [HIP] Fix amdgcn builtin for long type (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e42def6 - [HIP] Fix amdgcn builtin for long type

Author: Yaxun (Sam) Liu Date: 2021-06-03T19:05:56-04:00 New Revision: e42def62d8d9572190b31182e5db8c4b3a57cdaf URL: https://github.com/llvm/llvm-project/commit/e42def62d8d9572190b31182e5db8c4b3a57cdaf DIFF:

[PATCH] D103564: [NFC][compiler-rt][hwasan] Wrap vfork interceptor with HWASAN_WITH_INTERCEPTORS

leonardchan updated this revision to Diff 349712. leonardchan added a comment. In D103564#2795287 , @mcgrathr wrote: > I think probably the better refactoring here would be to split this file in > two: one containing just the allocation functions; and a

[PATCH] D99364: [clang][cache] Update Fuchsia-stage2.cmake to create hwasan multilibs

leonardchan updated this revision to Diff 349700. leonardchan added a comment. Update to remove instrumentation on globals. It's likel we may not need the `hwasan+relative-vtables` multilibs when the next clang roll comes around. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103587: [AIX] Transfer predefined macros

cebowleratibm added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:680 + +if (Opts.LangStd == LangStandard::lang_c11 || +Opts.LangStd == LangStandard::lang_gnu11 || I think LangStandard::isC11() does what you want. You wouldn't

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4e478b8: [NFC][compiler-rt][hwasan] Refactor hwasan functions (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D103579: [LTO] Fix -fwhole-program-vtables handling after HIP ThinLTO patch

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0ee8b64ecf3: [LTO] Fix -fwhole-program-vtables handling after HIP ThinLTO patch (authored by tejohnson). Repository: rG LLVM Github Monorepo

[clang] d0ee8b6 - [LTO] Fix -fwhole-program-vtables handling after HIP ThinLTO patch

Author: Teresa Johnson Date: 2021-06-03T14:25:03-07:00 New Revision: d0ee8b64ecf359737ce550d8f47f465ab6657be7 URL: https://github.com/llvm/llvm-project/commit/d0ee8b64ecf359737ce550d8f47f465ab6657be7 DIFF:

[PATCH] D103579: [LTO] Fix -fwhole-program-vtables handling after HIP ThinLTO patch

tejohnson updated this revision to Diff 349690. tejohnson marked an inline comment as done. tejohnson added a comment. Combine check prefixes as suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103579/new/ https://reviews.llvm.org/D103579

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

leonardchan updated this revision to Diff 349689. leonardchan marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103562/new/ https://reviews.llvm.org/D103562 Files: compiler-rt/lib/hwasan/hwasan.cpp

[PATCH] D103646: [OPENMP]Fix PR50129: omp cancel parallel not working as expected.

jdoerfert added a comment. Do we have to update `OpenMPIRBuilder::createCancel` too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103646/new/ https://reviews.llvm.org/D103646 ___ cfe-commits mailing

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. @aganea Oh, my mistake. did not mean to enable -fasync-exceptions under -EHa in this patch. will fix it shortly... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344

[PATCH] D102943: Hashing: use a 64-bit storage type on all platforms.

dexonsmith added reviewers: jansvoboda11, Bigcheese. dexonsmith added a subscriber: Bigcheese. dexonsmith added a comment. This looks much cleaner; thanks for the update! I'm not sure this has decided whether it's writing special case code for building a CompilerInvocation's module context

[clang] da3ed58 - [test] Update more clang/test/Profile tests

Author: Fangrui Song Date: 2021-06-03T13:43:19-07:00 New Revision: da3ed58b97c1cc1356b7732d5dcbb6e4de3057da URL: https://github.com/llvm/llvm-project/commit/da3ed58b97c1cc1356b7732d5dcbb6e4de3057da DIFF: https://github.com/llvm/llvm-project/commit/da3ed58b97c1cc1356b7732d5dcbb6e4de3057da.diff

[clang] ba1fb0f - [test] Update c-linkage-available_externally.c

Author: Fangrui Song Date: 2021-06-03T13:40:01-07:00 New Revision: ba1fb0ff8c9f9ef7f9b7d1fe43cb95c8d1363f78 URL: https://github.com/llvm/llvm-project/commit/ba1fb0ff8c9f9ef7f9b7d1fe43cb95c8d1363f78 DIFF: https://github.com/llvm/llvm-project/commit/ba1fb0ff8c9f9ef7f9b7d1fe43cb95c8d1363f78.diff

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

aganea added a comment. In D80344#2797317 , @tentzen wrote: > @aganea , this patch should be zero-impact without explicit option > -fasync-exceptions. Are you also seeing a crash without this option? I'm using `/EHa` which I expect translates to

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. Hi, yes I can repro the crash with -fasync-exceptions plus -O2 option. Working on it now.. thank you for reporting this bug.. @aganea , this patch should be zero-impact without explicit option -fasync-exceptions. Are you also seeing a crash without this option? thanks

[PATCH] D103644: [analyzer] Refactor StoreSiteFinder and extract DefaultStoreHandler

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this

[PATCH] D103579: [LTO] Fix -fwhole-program-vtables handling after HIP ThinLTO patch

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103579/new/ https://reviews.llvm.org/D103579 ___ cfe-commits mailing list

[PATCH] D103579: [LTO] Fix -fwhole-program-vtables handling after HIP ThinLTO patch

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM for CUDA. @yaxunl Sam, does the change make sense for HIP? Comment at: clang/test/Driver/cuda-options.cu:190-192 +// RUN: | FileCheck -check-prefix DEVICE -check-prefix

[PATCH] D103642: [OPENMP]Fix PR49790: Constexpr values not handled in `omp declare mapper` clause.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103642/new/ https://reviews.llvm.org/D103642

[PATCH] D103633: [analyzer] Refactor trackExpressionValue to accept TrackingOptions

vsavchenko updated this revision to Diff 349660. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103633/new/ https://reviews.llvm.org/D103633 Files:

[PATCH] D103633: [analyzer] Refactor trackExpressionValue to accept TrackingOptions

vsavchenko updated this revision to Diff 349659. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103633/new/ https://reviews.llvm.org/D103633 Files:

[PATCH] D103631: [analyzer] Turn TrackControlDependencyCond into a tracking visitor

vsavchenko updated this revision to Diff 349657. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103631/new/ https://reviews.llvm.org/D103631 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp Index:

[PATCH] D103630: [analyzer] Refactor trackRValueExpression into ExpressionHandler

vsavchenko updated this revision to Diff 349656. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103630/new/ https://reviews.llvm.org/D103630 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp Index:

[PATCH] D103628: [analyzer] Turn ReturnVisitor into a tracking visitor

vsavchenko updated this revision to Diff 349655. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103628/new/ https://reviews.llvm.org/D103628 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp Index:

[PATCH] D103624: [analyzer] Hide and rename FindLastStoreBRVisitor

vsavchenko updated this revision to Diff 349654. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103624/new/ https://reviews.llvm.org/D103624 Files:

[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

vsavchenko updated this revision to Diff 349653. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103618/new/ https://reviews.llvm.org/D103618 Files:

[PATCH] D103616: [analyzer] Reimplement trackExpressionValue as ExpressionHandler

vsavchenko updated this revision to Diff 349652. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103616/new/ https://reviews.llvm.org/D103616 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp Index:

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

vsavchenko updated this revision to Diff 349650. vsavchenko added a comment. Add forgotten piece of StoreInfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103605/new/ https://reviews.llvm.org/D103605 Files:

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

rupprecht added a comment. In D101191#2788596 , @spatel wrote: > In D101191#2783570 , @rupprecht > wrote: > >> In D101191#2782963 , @rupprecht >> wrote: >> >>> The

[PATCH] D103579: [LTO] Fix -fwhole-program-vtables handling after HIP ThinLTO patch

tejohnson marked an inline comment as done. tejohnson added inline comments. Comment at: clang/test/Driver/hip-options.hip:63 // RUN: %clang -### -target x86_64-unknown-linux-gnu -nogpuinc -nogpulib \ -// RUN: --cuda-gpu-arch=gfx906 -foffload-lto=thin %s 2>&1 \ -// RUN: |

[PATCH] D103579: [LTO] Fix -fwhole-program-vtables handling after HIP ThinLTO patch

tejohnson updated this revision to Diff 349647. tejohnson added a comment. Add Cuda test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103579/new/ https://reviews.llvm.org/D103579 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D103231: [clang][AST] Set correct DeclContext in ASTImporter lookup table for ParmVarDecl.

martong accepted this revision. martong added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103231/new/ https://reviews.llvm.org/D103231 ___ cfe-commits mailing list

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc updated this revision to Diff 349644. mibintc added a comment. I made a change to ActOnParenExpr to check that the parenthesized expression is not an lvalue before inserting the call to builtin __arithmetic_fence Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103642: [OPENMP]Fix PR49790: Constexpr values not handled in `omp declare mapper` clause.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a project: clang. Patch allows using of constexpr vars evaluatable to constant calue to be used in declare mapper construct.

[PATCH] D103587: [AIX] Transfer predefined macros

Jake-Egan updated this revision to Diff 349638. Jake-Egan added a comment. Set macros for C11 and higher. Add negative test for pre C11. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103587/new/ https://reviews.llvm.org/D103587 Files:

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan updated this revision to Diff 349635. urnathan added a comment. Rebasing again. Please review! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102241/new/ https://reviews.llvm.org/D102241 Files: clang-tools-extra/clangd/FindTarget.cpp clang/include/clang/AST/ASTContext.h

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

urnathan updated this revision to Diff 349634. urnathan added a comment. Rebasing again. Please review! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100276/new/ https://reviews.llvm.org/D100276 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D103082: [AArch64][SVE] Improve codegen for dupq SVE ACLE intrinsics

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9068 +VecOps.push_back(llvm::ConstantInt::get( +EltTy, cast(Ops[I])->getZExtValue())); + else Constant doesn't imply ConstantInt. (For example, it could be the

[PATCH] D103611: Correct the behavior of va_arg checking in C++

efriedma added a comment. I'm a little nervous about using C type merging in C++; it's not designed to support C++ types, so it might end up crashing or something like that. I think I'd prefer to explicitly convert enum types to their underlying type. Repository: rG LLVM Github Monorepo

[PATCH] D99436: [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

ABataev updated this revision to Diff 349627. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99436/new/ https://reviews.llvm.org/D99436 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D103579: [LTO] Fix -fwhole-program-vtables handling after HIP ThinLTO patch

tra added inline comments. Comment at: clang/test/Driver/hip-options.hip:63 // RUN: %clang -### -target x86_64-unknown-linux-gnu -nogpuinc -nogpulib \ -// RUN: --cuda-gpu-arch=gfx906 -foffload-lto=thin %s 2>&1 \ -// RUN: | FileCheck -check-prefix=THINLTO %s +// RUN:

[PATCH] D103547: Don't delete the module you're inspecting

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG13a9b2220f22: Dont delete the module youre inspecting (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 13a9b22 - Don't delete the module you're inspecting

Author: Chris Bieneman Date: 2021-06-03T13:00:09-05:00 New Revision: 13a9b2220f227631b3495a42abbab7fc2b414b69 URL: https://github.com/llvm/llvm-project/commit/13a9b2220f227631b3495a42abbab7fc2b414b69 DIFF:

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

zahiraam added a comment. Actually adding -O2 to all the LIT tests in this patch will trigger the same assertion at CGCleanup.cpp:1326. The code's assuming there is always an invoke destination in the program, but in these cases the InvokeDest is null. According to Microsoft's documentation,

[PATCH] D103039: [AST] fully-qualify template args of outer types in getFullyQualifiedType

saugustine added a comment. Committed as 3e55f55048387a8efef01e445d46fc5cf100285d . Thanks again for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103039/new/

[PATCH] D103579: [LTO] Fix -fwhole-program-vtables handling after HIP ThinLTO patch

tejohnson added inline comments. Comment at: clang/test/Driver/hip-options.hip:63 // RUN: %clang -### -target x86_64-unknown-linux-gnu -nogpuinc -nogpulib \ -// RUN: --cuda-gpu-arch=gfx906 -foffload-lto=thin %s 2>&1 \ -// RUN: | FileCheck -check-prefix=THINLTO %s +// RUN:

[clang] 3e55f55 - Fully-qualify template args of outer types in getFullyQualifiedType

Author: Victor Kuznetsov Date: 2021-06-03T10:50:00-07:00 New Revision: 3e55f55048387a8efef01e445d46fc5cf100285d URL: https://github.com/llvm/llvm-project/commit/3e55f55048387a8efef01e445d46fc5cf100285d DIFF:

[PATCH] D103579: [LTO] Fix -fwhole-program-vtables handling after HIP ThinLTO patch

tra added inline comments. Comment at: clang/test/Driver/hip-options.hip:63 // RUN: %clang -### -target x86_64-unknown-linux-gnu -nogpuinc -nogpulib \ -// RUN: --cuda-gpu-arch=gfx906 -foffload-lto=thin %s 2>&1 \ -// RUN: | FileCheck -check-prefix=THINLTO %s +// RUN:

[PATCH] D103633: [analyzer] Refactor trackExpressionValue to accept TrackingOptions

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this

[PATCH] D103184: [AArch64] handle -Wa,-march=

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. LGTM; any additional thoughts @DavidSpickett ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103184/new/

[PATCH] D103603: [Sema][RISCV][SVE] Allow ?: to select Typedef BuiltinType in C

arcbbb updated this revision to Diff 349600. arcbbb marked an inline comment as done. arcbbb retitled this revision from "[Sema][RISCV] Allow ?: to select Typedef BuiltinType in C" to "[Sema][RISCV][SVE] Allow ?: to select Typedef BuiltinType in C". arcbbb added a reviewer: frasercrmck. arcbbb

[PATCH] D103587: [AIX] Transfer predefined macros

cebowleratibm requested changes to this revision. cebowleratibm added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Basic/Targets/OSTargets.h:680 + +if (Opts.LangStd == LangStandard::lang_c11 || +Opts.LangStd ==

[PATCH] D99675: [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

craig.topper added inline comments. Comment at: llvm/include/llvm/IR/IRBuilder.h:903 + const Twine = "") { +return CreateIntrinsic(Intrinsic::arithmetic_fence, {DstType}, {Val}, nullptr, + Name);

[PATCH] D103612: [flang][driver] Add `-fno-unparse-typed-exprs`

awarzynski updated this revision to Diff 349598. awarzynski added a comment. Rebased on top of D103613 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103612/new/ https://reviews.llvm.org/D103612 Files:

[PATCH] D103613: [flang][driver] Add support for `-module-suffix`

awarzynski updated this revision to Diff 349595. awarzynski added a comment. Minor tweaks (different suffix in test, updated help text) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103613/new/ https://reviews.llvm.org/D103613 Files:

[PATCH] D103563: [HIP] Fix amdgcn builtin for long type

tra accepted this revision. tra added a comment. Still LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103563/new/ https://reviews.llvm.org/D103563 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D103631: [analyzer] Turn TrackControlDependencyCond into a tracking visitor

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 added a comment. Got both of these Comment at: clang/lib/Format/TokenAnnotator.cpp:737-740 +const auto End = Contexts.rbegin() + 2; +auto Last = Contexts.rbegin(); +unsigned Depth = 0; +for (; Last != End; Last = std::next(Last)) {

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 updated this revision to Diff 349589. feg208 marked 2 inline comments as done. feg208 added a comment. Grabs up some review comments and adds lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/

[PATCH] D103491: [ADT] Move DenseMapInfo for ArrayRef/StringRef into respective headers (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG983565a6fe4a: [ADT] Move DenseMapInfo for ArrayRef/StringRef into respective headers (NFC) (authored by nikic). Changed prior to commit:

[clang] 983565a - [ADT] Move DenseMapInfo for ArrayRef/StringRef into respective headers (NFC)

Author: Nikita Popov Date: 2021-06-03T18:34:36+02:00 New Revision: 983565a6fe4a9f40c7caf82b65c650c20dbcc104 URL: https://github.com/llvm/llvm-project/commit/983565a6fe4a9f40c7caf82b65c650c20dbcc104 DIFF: https://github.com/llvm/llvm-project/commit/983565a6fe4a9f40c7caf82b65c650c20dbcc104.diff

[PATCH] D103630: [analyzer] Refactor trackRValueExpression into ExpressionHandler

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this

[PATCH] D103524: [clang][deps] Handle precompiled headers' AST files

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. Comment at: clang/test/ClangScanDeps/modules-pch.c:7 // RUN: %clang -x c-header %t/pch.h -fmodules -gmodules -fimplicit-module-maps \ -// RUN:

[PATCH] D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/test/CodeGen/mingw-long-double.c:56-58 + // GNU32: bitcast i8* %argp.cur to x86_fp80* + // GNU64: bitcast i8* %argp.cur to x86_fp80** + // MSC64: bitcast

[PATCH] D103231: [clang][AST] Set correct DeclContext in ASTImporter lookup table for ParmVarDecl.

balazske updated this revision to Diff 349583. balazske added a comment. Added assert messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103231/new/ https://reviews.llvm.org/D103231 Files: clang/include/clang/AST/ASTImporterLookupTable.h

[PATCH] D103628: [analyzer] Turn ReturnVisitor into a tracking visitor

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this

[PATCH] D103519: [clang][deps] Support object files

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:161-162 + std::make_unique()); + PCHContainerOps->registerWriter( +

[PATCH] D103563: [HIP] Fix amdgcn builtin for long type

yaxunl added a comment. I got regressions in OpenCL tests since long long int is 128 bit in OpenCL. I switched to use `W` as width modifier in builtin definitions since `W` is for fixed-length 64 bit int type. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103563/new/

[PATCH] D103624: [analyzer] Hide and rename FindLastStoreBRVisitor

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this

  1   2   >