[PATCH] D103760: [clang] use correct builtin type for defaulted comparison analyzer

mizvekov added a comment. Since we can still crash with user defined conversion operators for any builtin types not supported by `getComparisonCategoryForBuiltinCmp` (many others), I will make a follow up patch to just replace that assert with a deleted result. Repository: rG LLVM Github

[PATCH] D103760: [clang] use correct builtin type for defaulted comparison analyzer

mizvekov created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes PR50591. When

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99696/new/ https://reviews.llvm.org/D99696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D103663: [AMDGPU] Add gfx1013 target

bcahoon updated this revision to Diff 350075. bcahoon added a comment. Addressed review comments. Updated the patch to use the new AEncoding target feature correctly. Added code to report an error for the image intersect intrinsics for unsupported targets. CHANGES SINCE LAST ACTION

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

RedDocMD updated this revision to Diff 350067. RedDocMD added a comment. Accounting for std::make_unique_for_overwrite Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750 Files:

[PATCH] D103611: Correct the behavior of va_arg checking in C++

aaron.ballman updated this revision to Diff 350060. aaron.ballman added a comment. Added some more logic and new tests. The CI pipeline pointed out a valid issue which has now been corrected -- C++ was not properly handling the case where one type was `int` and the other was `unsigned int`,

[PATCH] D100733: [clang] NFC: change uses of `Expr->getValueKind` into `is?Value`

mizvekov added a comment. I created a DR which proposes the renaming as rsmith suggested: https://reviews.llvm.org/D103720 In D100733#2773944 , @aaronpuchert wrote: > A new value category feels like a global change for a local problem. We can >

[PATCH] D103745: [dfsan] Add full fast8 support

stephan.yichao.zhao added inline comments. Comment at: clang/docs/DataFlowSanitizer.rst:172-178 assert(ij_label == 3); // Verifies all of the above +// Or, equivalently: +assert(dfsan_has_label(ij_label, i_label)); +assert(dfsan_has_label(ij_label, j_label));

[PATCH] D103745: [dfsan] Add full fast8 support

stephan.yichao.zhao added a comment. The failed test cases from x64 debian > libFuzzer.libFuzzer::* seem related. They still use -dfsan-fast-16-labels. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103745/new/ https://reviews.llvm.org/D103745

[PATCH] D101696: [Matrix] Implement C-style explicit type conversions in CXX for matrix types

SaurabhJha added a comment. In D101696#2798713 , @SjoerdMeijer wrote: > Perhaps for bonus points, update the Clang documentation in > https://clang.llvm.org/docs/LanguageExtensions.html#matrix-types with some > examples? Can you please point me to

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added a comment. In D103440#2800710 , @vsavchenko wrote: > In D103440#2800122 , @manas wrote: > >> In D103440#2799629 , @xazax.hun >> wrote: >> >>> I was

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

RedDocMD created this revision. RedDocMD added reviewers: NoQ, vsavchenko, xazax.hun, teemperor. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. RedDocMD requested review of this

[PATCH] D103749: [clang][driver] Add -foperator-names

zero9178 created this revision. zero9178 added reviewers: MaskRay, thakis, hans. Herald added a subscriber: dang. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds the command line option -foperator-names which acts

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

vsavchenko added a comment. In D103440#2799629 , @xazax.hun wrote: > I was wondering, if we could try something new with the tests. To increase > our confidence that the expected behavior is correct, how about including a > Z3 proof with each of the

[PATCH] D102822: [Clang][CodeGen] Set the size of llvm.lifetime to unknown for scalable types.

HsiangKai updated this revision to Diff 350035. HsiangKai added a comment. Simplify the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102822/new/ https://reviews.llvm.org/D102822 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D103372: [InstrProfiling] If no value profiling, make data variable private and (for Windows) use one comdat

MaskRay added a comment. I measured a stage 2 `-DLLVM_TARGETS_TO_BUILD=X86 -DCMAKE_BUILD_TYPE=Release -DLLVM_BUILD_INSTRUMENTED_COVERAGE=on` build on Linux x86-64. % ls -1 /tmp/out/s3-custom/**/*.o(.) | wc -l 2174 % stat -c %s /tmp/out/s3-custom/**/*.o(.) | awk '{s+=$1}END{print s}'