[PATCH] D103131: support debug info for alias variable

kamleshbhalui added a comment. In D103131#2791881 , @dblaikie wrote: > In D103131#2789493 , @probinson > wrote: > >>> Mixed feelings - somewhat in favor of "do the thing that's probably already >>> fairly

[PATCH] D103633: [analyzer] Refactor trackExpressionValue to accept TrackingOptions

NoQ accepted this revision. NoQ added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp:288 + bugreporter::trackExpressionValue( + N, RS->getRetValue(), *R, {bugreporter::TrackingKind::Thorough,

[PATCH] D103630: [analyzer] Refactor trackRValueExpression into ExpressionHandler

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I guess you should mark all of these commits as NFC? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103630/new/ https://reviews.llvm.org/D103630

[PATCH] D103628: [analyzer] Turn ReturnVisitor into a tracking visitor

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103628/new/ https://reviews.llvm.org/D103628 ___

[PATCH] D103624: [analyzer] Hide and rename FindLastStoreBRVisitor

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Excellent! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103624/new/ https://reviews.llvm.org/D103624

[PATCH] D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2274 + const StackFrameContext *Origin) { + Tracker::create(Report)->track(V, R, Opts, Origin); +} How does lifetime work here? Do I

[PATCH] D103616: [analyzer] Reimplement trackExpressionValue as ExpressionHandler

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Everything's perfect, can't complain! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103616/new/ https://reviews.llvm.org/D103616

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:160-161 + PathSensitiveBugReport + std::deque ExpressionHandlers; + std::deque StoreHandlers; + Empty deques can be pretty large: >

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

NoQ added a comment. > - ... Implementation of isTracked on it's own is fairly simple. And we can > have users of `isTracked` and `ExpressionHandler` at the same time. Maybe, > once we migrate all uses, `ExpressionHandler` can be safely retired. I think this sounds like a plan. More

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

MarcusJohnson91 added a comment. In D103426#2807860 , @aaron.ballman wrote: > In D103426#2807245 , > @MarcusJohnson91 wrote: > >> In D103426#2806391 , >>

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

NoQ added a comment. Yes we should definitely have as much as possible in the state dump. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm.org/D103967 ___ cfe-commits

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

MarcusJohnson91 added inline comments. Comment at: clang/lib/AST/Type.cpp:1980-2002 +bool Type::isChar16Type(const LangOptions ) const { if (const auto *BT = dyn_cast(CanonicalType)) -return BT->getKind() == BuiltinType::Char16; - return false; -} - -bool

[PATCH] D101630: [HIP] Add --gpu-bundle-output

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG5fc2673fbce2: [HIP] Add --gpu-bundle-output (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[clang] 5fc2673 - [HIP] Add --gpu-bundle-output

Author: Yaxun (Sam) Liu Date: 2021-06-09T23:31:43-04:00 New Revision: 5fc2673fbce247e107094b28c22cbb2d5f1691a8 URL: https://github.com/llvm/llvm-project/commit/5fc2673fbce247e107094b28c22cbb2d5f1691a8 DIFF:

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. Thanks for your patience through all the review! Let's get this landed :) Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrTable.td:19 [],

[PATCH] D103894: NarrowingConversionsCheck should support inhibiting conversions of mixed integer and floating point types with WarnOnEquivalentBitWidth=0.

Stephen updated this revision to Diff 351030. Stephen added a comment. Try again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103894/new/ https://reviews.llvm.org/D103894 Files:

[PATCH] D103894: NarrowingConversionsCheck should support inhibiting conversions of mixed integer and floating point types with WarnOnEquivalentBitWidth=0.

Stephen updated this revision to Diff 351029. Stephen added a comment. Try specifying the commit range. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103894/new/ https://reviews.llvm.org/D103894 Files:

[PATCH] D103894: NarrowingConversionsCheck should support inhibiting conversions of mixed integer and floating point types with WarnOnEquivalentBitWidth=0.

Stephen updated this revision to Diff 351028. Stephen added a comment. Undo that last move, since that didn't work. I'm absolutely incompetent with this tool. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103894/new/

[PATCH] D103878: [clang][RISCV][test] Add more tests of the -mabi and -march options

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0eb3919835a: [clang][RISCV][test] Add more tests of the -mabi and -march options (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D103878?vs=350828=351025#toc Repository:

[clang] b0eb391 - [clang][RISCV][test] Add more tests of the -mabi and -march options

Author: Ben Shi Date: 2021-06-10T09:14:14+08:00 New Revision: b0eb3919835a7bb57cb28ae684d77fece8ff025c URL: https://github.com/llvm/llvm-project/commit/b0eb3919835a7bb57cb28ae684d77fece8ff025c DIFF: https://github.com/llvm/llvm-project/commit/b0eb3919835a7bb57cb28ae684d77fece8ff025c.diff LOG:

[PATCH] D103894: NarrowingConversionsCheck should support inhibiting conversions of mixed integer and floating point types with WarnOnEquivalentBitWidth=0.

Stephen updated this revision to Diff 351024. Stephen added a comment. Fix the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103894/new/ https://reviews.llvm.org/D103894 Files:

[PATCH] D103958: [WIP] Support MustControl conditional control attribute

efriedma added a comment. You could break `__builtin_load_with_control_dependency(x)` into something like `__builtin_control_dependency(READ_ONCE(x))`. I don't think any transforms will touch that in practice, even if it isn't theoretically sound. The rest of my suggestion still applies to

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang updated this revision to Diff 350991. NeHuang added a comment. - Renamed the XLCompat builtin as `__builtin_ppc_*` and add them to `definedXLCompatMacros` and update the test cases. - Report error in SemaChecking when 64 bit only builtins run on a 32 bit target and update the test

[PATCH] D103252: [C++4OpenCL] Fix missing address space on implicit move assignment operator

abhinavgaba added inline comments. Comment at: clang/test/AST/ast-dump-implicit-members.clcpp:10 + +// CHECK: CXXConstructorDecl {{.*}} implicit used constexpr S 'void () __generic noexcept' +// CHECK: CXXConstructorDecl {{.*}} implicit constexpr S 'void (const __generic S &)

[PATCH] D103995: [OpenMP] Add type to firstprivate symbol for const firstprivate values

jhuber6 updated this revision to Diff 351012. jhuber6 added a comment. Changing to only mangle when using C++. It should be correct either way but is unnecessary with C. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103995/new/

[PATCH] D103995: [OpenMP] Add type to firstprivate symbol for const firstprivate values

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10598 +CGM.getCXXABI().getMangleContext().mangleTypeName(VD->getType(), OS); +OS << "_" << VD->getName() << "_l" << Line; VarName = OS.str(); jdoerfert wrote: > What if

[PATCH] D103995: [OpenMP] Add type to firstprivate symbol for const firstprivate values

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10598 +CGM.getCXXABI().getMangleContext().mangleTypeName(VD->getType(), OS); +OS << "_" << VD->getName() << "_l" << Line; VarName = OS.str(); What if the code is not

[PATCH] D103878: [clang][RISCV][test] Add more tests of the -mabi and -march options

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/Driver/riscv-arch.c:122 + +// CHECK-LP64F: "-target-feature" "+m" +// CHECK-LP64F-SAME: {{^}} "-target-feature" "+a" ``` //

[PATCH] D103928: [IR] make -warn-frame-size into a module attr

nickdesaulniers updated this revision to Diff 351008. nickdesaulniers added a comment. - add `<` to same comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103928/new/ https://reviews.llvm.org/D103928 Files:

[PATCH] D103928: [IR] make -warn-frame-size into a module attr

nickdesaulniers updated this revision to Diff 351007. nickdesaulniers added a comment. - update comment in clang/include/clang/Basic/CodeGenOptions.def Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103928/new/ https://reviews.llvm.org/D103928

[PATCH] D103928: [IR] make -warn-frame-size into a module attr

nickdesaulniers updated this revision to Diff 351006. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - introduce -fwarn-stack-size Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103928/new/

[PATCH] D103878: [clang][RISCV][test] Add more tests of the -mabi and -march options

benshi001 added a comment. In D103878#2809033 , @luismarques wrote: > In D103878#2807118 , @benshi001 > wrote: > >> 1. there is no tests for mabi=ilp32e, and my patch covers that. >> 2. the tests in riscv-abi.c

[PATCH] D103958: [WIP] Support MustControl conditional control attribute

melver added a comment. In D103958#2809145 , @efriedma wrote: > In D103958#2808966 , @melver wrote: > >> In D103958#2808861 , @efriedma >> wrote: >> >>> I don't like

[PATCH] D103995: [OpenMP] Add type to firstprivate symbol for const firstprivate values

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, ABataev. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Clang will create a global value put in constant

[PATCH] D103928: [IR] make -warn-frame-size into a module attr

rsmith added inline comments. Comment at: clang/include/clang/Driver/Options.td:2575-2581 // These "special" warning flags are effectively processed as f_Group flags by the driver: // Just silence warnings about -Wlarger-than for now. def Wlarger_than_EQ : Joined<["-"],

[clang] cf11d95 - Fix to Windows temp file change.

Author: Amy Huang Date: 2021-06-09T16:15:16-07:00 New Revision: cf11d9585afd5c43031a9fb622c8c31b4bef URL: https://github.com/llvm/llvm-project/commit/cf11d9585afd5c43031a9fb622c8c31b4bef DIFF: https://github.com/llvm/llvm-project/commit/cf11d9585afd5c43031a9fb622c8c31b4bef.diff

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

aaronpuchert added a comment. In D99696#2808592 , @Quuxplusone wrote: > @aaronpuchert what's your take on D99696 at > this point; is it good to go or still unresolved issues? Overall this looks sensible to me, and I

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:857-858 + OS.reset(new llvm::raw_fd_ostream(Temp->FD, /*shouldClose=*/false, +Binary ? llvm::sys::fs::OF_None +

[PATCH] D102736: Fix tmp files being left on Windows builds.

Quuxplusone added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:857-858 + OS.reset(new llvm::raw_fd_ostream(Temp->FD, /*shouldClose=*/false, +Binary ? llvm::sys::fs::OF_None +

[PATCH] D102736: Fix tmp files being left on Windows builds.

amccarth added a comment. Nice catch Reid. Comment at: clang/lib/Frontend/CompilerInstance.cpp:857-858 + OS.reset(new llvm::raw_fd_ostream(Temp->FD, /*shouldClose=*/false, +Binary ? llvm::sys::fs::OF_None +

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic added inline comments. Comment at: clang/docs/ReleaseNotes.rst:79-80 +- ``-Wstack-usage=`` warn if stack usage of user functions might + exceed . + Quuxplusone wrote: > Does this mean: > - Warn if the size of any single function's stack frame

[PATCH] D103958: [WIP] Support MustControl conditional control attribute

efriedma added a comment. In D103958#2808966 , @melver wrote: > In D103958#2808861 , @efriedma > wrote: > >> I don't like using metadata like this. Dropping metadata should generally >> preserve the semantics

[PATCH] D103987: Start tracking Clang's C implementation status

jyknight accepted this revision. jyknight added a comment. This revision is now accepted and ready to land. Sounds like a great plan to me. I might suggest adding some text about the page being incomplete, so that people don't wonder if the blank sections for pre-C2x are a bug. Repository:

[PATCH] D102736: Fix tmp files being left on Windows builds.

rnk added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:857-858 + OS.reset(new llvm::raw_fd_ostream(Temp->FD, /*shouldClose=*/false, +Binary ? llvm::sys::fs::OF_None +

[PATCH] D103495: [static initializers] Emit global_ctors and global_dtors in reverse order when init_array is not used.

wolfgangp added a comment. In D103495#2808247 , @rnk wrote: > So, a question for @wolfgangp and @probinson , do we need to make adjustments > to the LTO library, or is this OK as is? We never guaranteed our licensees any particular initialization order

[PATCH] D100713: [clang] NFC: refactor usage of getDecltypeForParenthesizedExpr

mizvekov updated this revision to Diff 350998. mizvekov added a comment. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100713/new/ https://reviews.llvm.org/D100713 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations.

flx added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:98-101 auto Matches = match(findAll(declStmt(has(varDecl(equalsNode( .bind("declStmt")), +Body, Context);

[PATCH] D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations.

flx updated this revision to Diff 350994. flx marked 2 inline comments as done. flx added a comment. Addressed first round of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103021/new/ https://reviews.llvm.org/D103021 Files:

[PATCH] D103878: [clang][RISCV][test] Add more tests of the -mabi and -march options

luismarques added a comment. In D103878#2807118 , @benshi001 wrote: > 1. there is no tests for mabi=ilp32e, and my patch covers that. > 2. the tests in riscv-abi.c will show default abi changes for special archs, > especially for the arch with F but

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov added a comment. In D99696#2808592 , @Quuxplusone wrote: > @mizvekov, my understanding is: > > - D99696 was temporarily blocked on D103720 > , but now D103720 >

[PATCH] D103958: [WIP] Support MustControl conditional control attribute

jdoerfert added subscribers: nhaehnle, rjmccall, arsenm. jdoerfert added a comment. This starts to sound an awful lot like `convergent` to me, basically: Do not change the control conditions of this call. Still unsure, maybe you can add a LangRef draft so we know what you try to do, or a nice

[PATCH] D103958: [WIP] Support MustControl conditional control attribute

melver added a comment. In D103958#2808967 , @jdoerfert wrote: >> Please bear with me, I'm updating examples and documentation. I didn't think >> anybody would look at this while [WIP]. :-) > > People try to help so you have early design feedback ;)

[PATCH] D103958: [WIP] Support MustControl conditional control attribute

jdoerfert added a comment. > Please bear with me, I'm updating examples and documentation. I didn't think > anybody would look at this while [WIP]. :-) People try to help so you have early design feedback ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103958: [WIP] Support MustControl conditional control attribute

melver added a comment. In D103958#2808861 , @efriedma wrote: > I don't like using metadata like this. Dropping metadata should generally > preserve the semantics of the code. Anything better for this without introducing new instructions? Would an

[PATCH] D103018: [clang-tidy] performance-unnecessary-copy-initialization: Look at the canonical type when checking for aliases.

This revision was automatically updated to reflect the committed changes. Closed by commit rGefa4dbc32ca9: [clang-tidy] performance-unnecessary-copy-initialization: Look at the canonical… (authored by flx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] efa4dbc - [clang-tidy] performance-unnecessary-copy-initialization: Look at the canonical type when checking for aliases.

Author: Felix Berger Date: 2021-06-09T16:36:53-04:00 New Revision: efa4dbc32ca9b7f3319edbcc6ac502ea962c8f0a URL: https://github.com/llvm/llvm-project/commit/efa4dbc32ca9b7f3319edbcc6ac502ea962c8f0a DIFF: https://github.com/llvm/llvm-project/commit/efa4dbc32ca9b7f3319edbcc6ac502ea962c8f0a.diff

[PATCH] D102901: [HWASan] Add basic stack tagging support for LAM.

morehouse updated this revision to Diff 350989. morehouse marked 2 inline comments as done. morehouse added a comment. - - Address nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102901/new/ https://reviews.llvm.org/D102901 Files:

[PATCH] D103982: [clang] Make CXXDefaultArgExpr inherit dependence from the inner Expr

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103982/new/ https://reviews.llvm.org/D103982

[PATCH] D102901: [HWASan] Add basic stack tagging support for LAM.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:503 + // planned for globals as well. + bool IsX86 = TargetTriple.getArch() ==

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 marked 3 inline comments as done. feg208 added a comment. All the review comments are addressed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 ___

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 updated this revision to Diff 350984. feg208 marked 11 inline comments as done. feg208 added a comment. Rolls up the remaining review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868

[PATCH] D103987: Start tracking Clang's C implementation status

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, erichkeane, jyknight. aaron.ballman requested review of this revision. Herald added a project: clang. We currently have a very useful page tracking our implementation status of C++ features

[PATCH] D103958: [WIP] Support MustControl conditional control attribute

efriedma added a comment. In D103958#2808861 , @efriedma wrote: >> without resorting to inline assembly (which often results in poor codegen). > > Could you give an example of the resulting assembly with mustcontrol vs. this > patch? Err, I mean, the

[PATCH] D103958: [WIP] Support MustControl conditional control attribute

efriedma added a comment. I don't like using metadata like this. Dropping metadata should generally preserve the semantics of the code. > without resorting to inline assembly (which often results in poor codegen). Could you give an example of the resulting assembly with mustcontrol vs. this

[PATCH] D102175: [clang-tidy] performance-unnecessary-copy-initialization: Remove the complete statement when the copied variable is unused.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5dbe3bf4b8db: [clang-tidy] performance-unnecessary-copy-initialization: Remove the complete… (authored by flx). Repository: rG LLVM Github

[clang-tools-extra] 5dbe3bf - [clang-tidy] performance-unnecessary-copy-initialization: Remove the complete statement when the copied variable is unused.

Author: Felix Berger Date: 2021-06-09T15:52:48-04:00 New Revision: 5dbe3bf4b8dbb7e67d41c7c1360f15d512dd72a0 URL: https://github.com/llvm/llvm-project/commit/5dbe3bf4b8dbb7e67d41c7c1360f15d512dd72a0 DIFF: https://github.com/llvm/llvm-project/commit/5dbe3bf4b8dbb7e67d41c7c1360f15d512dd72a0.diff

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 marked an inline comment as done. feg208 added a comment. In D101868#2808826 , @curdeius wrote: > LGTM. That's a great piece work @feg208. Thank you! Awww thanks. I learned a lot from all the comments honestly. I appreciate the patience. > I've

[PATCH] D102175: [clang-tidy] performance-unnecessary-copy-initialization: Remove the complete statement when the copied variable is unused.

flx added a comment. Thank you for the review, Yitzhak! Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-unnecessary-copy-initialization.cpp:541 Orig.constMethod(); + UnnecessaryCopy.constMethod(); } ymandel wrote: > If this line

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. That's a great piece work @feg208. Thank you! I've added many nit comments, but I didn't do it for all code comments. Please check that all comments are full phrases (with full stops

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. quinnp requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D103986

[PATCH] D102901: [HWASan] Add basic stack tagging support for LAM.

morehouse updated this revision to Diff 350976. morehouse added a comment. - Privatize new member variables. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102901/new/ https://reviews.llvm.org/D102901 Files: clang/lib/Driver/SanitizerArgs.cpp

[PATCH] D103958: [WIP] Support MustControl conditional control attribute

jdoerfert added a comment. In D103958#2808767 , @nickdesaulniers wrote: > The first talk from https://www.youtube.com/watch?v=FFjV9f_Ub9o > (https://github.com/ClangBuiltLinux/plumbers-2020-slides/blob/master/LPC_2020_--_Dependency_ordering.pdf) >

[PATCH] D102901: [HWASan] Add basic stack tagging support for LAM.

morehouse updated this revision to Diff 350975. morehouse marked 3 inline comments as done. morehouse added a comment. Herald added a project: clang. Herald added subscribers: Sanitizers, cfe-commits. - Rename flag as experimental. - Refactor and simplify code. - Apply mask to base tag only. -

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 marked an inline comment as done. feg208 added a comment. addressed the remaining review comment Comment at: clang/docs/ClangFormatStyleOptions.rst:216-221 +struct test demo[] = +{ +{56,23, "hello"}, +{-1, 93463, "world"}, +{ 7,

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 updated this revision to Diff 350974. feg208 added a comment. Regenerated the mangled ClangFormatStyle.rst file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 Files:

[PATCH] D103958: [WIP] Support MustControl conditional control attribute

nickdesaulniers added a comment. The first talk from https://www.youtube.com/watch?v=FFjV9f_Ub9o (https://github.com/ClangBuiltLinux/plumbers-2020-slides/blob/master/LPC_2020_--_Dependency_ordering.pdf) might be helpful to link to at some point from the commit message, for a little additional

[PATCH] D101139: Create install targets for scan-build-py.

isthismyaccount added a comment. Thanks for the reviews. I'll take over this and try to get the merge conflicts resolved. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139 ___ cfe-commits mailing

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1789 + if (DisequalToOther.contains(*this)) +return nullptr; if (!DisequalToOther.isEmpty()) { vsavchenko wrote:

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

martong updated this revision to Diff 350966. martong marked an inline comment as done. martong added a comment. - Remove isEqualTo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103314/new/ https://reviews.llvm.org/D103314 Files:

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

martong added a comment. > OK, we definitely need to know about performance. Couldn't agree more. I am in the middle of a performance measurement that I do with csa-testbench (on memchached,tmux,curl,twin,redis,vim,openssl,sqlite,ffmpeg,postgresql,tinyxml2,libwebm,xerces,bitcoin,protobuf).

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

adamcz added a comment. Thanks Haojian! I sent out https://reviews.llvm.org/D103982 for the CXXDefaultArgExpr. I'll update this change after I submit that one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103825/new/

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/test/Analysis/find-binop-constraints.cpp:155-158 +// Here, e1 is still bound to (reg_$0) - (reg_$1) but we +// should be able to simplify it to (reg_$0) - 2 and thus realize +

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

curdeius added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:216-221 +struct test demo[] = +{ +{56,23, "hello"}, +{-1, 93463, "world"}, +{ 7, 5,"!!"} +}; feg208 wrote: > curdeius wrote: > >

[PATCH] D103982: [clang] Make CXXDefaultArgExpr inherit dependence from the inner Expr

adamcz created this revision. adamcz added a reviewer: hokein. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this change, CXXDefaultArgExpr would always have ExprDependence::None. This can lead to issues when, for example,

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

Quuxplusone accepted this revision. Quuxplusone added a comment. This revision is now accepted and ready to land. @mizvekov, my understanding is: - D99696 was temporarily blocked on D103720 , but now D103720

[PATCH] D103909: [CSSPGO] Emit mangled dwarf names for line tables debug option under -fpseudo-probe-for-profiling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64b2fb7967a7: [CSSPGO] Emit mangled dwarf names for line tables debug option under -fpseudo… (authored by hoy). Repository: rG LLVM Github

[clang] 64b2fb7 - [CSSPGO] Emit mangled dwarf names for line tables debug option under -fpseudo-probe-for-profiling

Author: Hongtao Yu Date: 2021-06-09T10:46:03-07:00 New Revision: 64b2fb7967a749b83f59656f0cd2f4d00501efaa URL: https://github.com/llvm/llvm-project/commit/64b2fb7967a749b83f59656f0cd2f4d00501efaa DIFF: https://github.com/llvm/llvm-project/commit/64b2fb7967a749b83f59656f0cd2f4d00501efaa.diff

[PATCH] D103845: [compiler-rt][hwasan] Add newline between record_addr lines on frame record dumps

pcc added a comment. Thanks for tracking this down. It seems best to change the Printf call to add the newline, since otherwise it looks like you'd be adding a spurious newline to the other callers of `RenderFrame` on Fuchsia. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103894: NarrowingConversionsCheck should support inhibiting conversions of mixed integer and floating point types with WarnOnEquivalentBitWidth=0.

Stephen updated this revision to Diff 350950. Stephen added a comment. Fix the expected error messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103894/new/ https://reviews.llvm.org/D103894 Files:

[clang] 8908903 - Corrects some minor issues with the CXX status page.

Author: Aaron Ballman Date: 2021-06-09T13:38:41-04:00 New Revision: 8908903eacb0e0a79c004e49959f860b5c0e4d53 URL: https://github.com/llvm/llvm-project/commit/8908903eacb0e0a79c004e49959f860b5c0e4d53 DIFF: https://github.com/llvm/llvm-project/commit/8908903eacb0e0a79c004e49959f860b5c0e4d53.diff

[PATCH] D101139: Create install targets for scan-build-py.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139 ___ cfe-commits mailing list

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

vsavchenko added a comment. This is definitely useful! Thanks! I was just wondering if we should add it into the state printer instead. @NoQ what's your take on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

martong marked 2 inline comments as done. martong added a comment. > I have one thought here. If the lack of simplification indeed caused the > crash, we are in trouble with this patch. IMO simplification in just one > place should make it better, but shouldn't produce infeasible states for us.

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 updated this revision to Diff 350924. feg208 added a comment. Ick. Missed a semi colon in the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 updated this revision to Diff 350920. feg208 added a comment. Fixes the busted test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D103949: Only consider built-in compound assignment operators for -Wunused-but-set-*

mbenfield added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:7794-7798 +if (BO->getLHS()->getType()->isDependentType() || +BO->getRHS()->getType()->isDependentType()) +{ + if (BO->getOpcode() != BO_Assign) +return;

[PATCH] D103934: clang/darwin: use response files with ld64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c7f3395b8ec: clang/darwin: use response files with ld64 (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1c7f339 - clang/darwin: use response files with ld64

Author: Keith Smiley Date: 2021-06-09T09:04:37-07:00 New Revision: 1c7f3395b8ec52462220898495883ec570390367 URL: https://github.com/llvm/llvm-project/commit/1c7f3395b8ec52462220898495883ec570390367 DIFF: https://github.com/llvm/llvm-project/commit/1c7f3395b8ec52462220898495883ec570390367.diff

[PATCH] D103495: [static initializers] Emit global_ctors and global_dtors in reverse order when init_array is not used.

rnk added a subscriber: probinson. rnk added a comment. In D103495#2806097 , @jyknight wrote: > Won't this change cause weird effects with LTO, when you're merging multiple > TUs' global_ctors arrays before emitting? Won't this end up reversing the >

[PATCH] D99675: [llvm][clang] Create new intrinsic llvm.arithmetic.fence to control FP optimization at expression level

mibintc updated this revision to Diff 350912. mibintc retitled this revision from "[llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level" to "[llvm][clang] Create new intrinsic llvm.arithmetic.fence to control FP optimization at expression level".

  1   2   >