[PATCH] D104242: Alters a lit test to simplify and avoid a buildbot error

feg208 added a comment. I don’t have commit rights currently. Could I get someone to land this on my behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104242/new/ https://reviews.llvm.org/D104242

[PATCH] D104275: [compiler-rt][hwasan] Add SHADOW_OFFSET macro

vitalybuka added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_mapping.h:57 extern uptr kAliasRegionStart; Maybe the following to minimize code which compiles only on limited set of platforms? ``` inline uptr GetShadowOffset() { return

[PATCH] D104097: [analyzer] Fix calculating offset for fields with an empty type

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. This looks correct, thanks! I think there are some weird rules with respect to `[[no_unique_address]]` on two consecutive fields when there's only one other field in the structure, eg. struct S

[PATCH] D103928: [IR] make -warn-frame-size into a module attr

dblaikie added inline comments. Comment at: llvm/test/Linker/warn-stack-frame.ll:6 + +; CHECK-MISMATCH: error: linking module flags 'warn-stack-size': IDs have conflicting values + If you like, you could make this a function attribute instead, that way it'd be

[PATCH] D104046: [analyzer] Simplify the process of producing notes for stores

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thanks! Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1299 + } else if (SI.Value.isUndef()) { +OS << "uninitialized value"; +

[PATCH] D103961: [analyzer] Extract InlinedFunctionCallHandler

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103961/new/ https://reviews.llvm.org/D103961 ___

[PATCH] D104279: [asan] Remove Asan, Ubsan support of RTEMS and Myriad

vitalybuka created this revision. Herald added subscribers: phosek, jfb, fedor.sergeev, hiraditya, krytarowski, mgorny. vitalybuka requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Repository: rG

[PATCH] D103644: [analyzer] Refactor StoreSiteFinder and extract DefaultStoreHandler

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103644/new/ https://reviews.llvm.org/D103644

[PATCH] D104135: [analyzer] Decouple NoteTag from its Factory

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:777 static bool classof(const ProgramPointTag *T) { return T->getTagKind() == } vsavchenko wrote: > NoQ wrote: > > NoQ wrote: > > > It sounds

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:207 + +const auto PtrVal = C.getSValBuilder().conjureSymbolVal( +Call.getOriginExpr(), C.getLocationContext(), Can you do a `getConjuredHeapSymbolVal()`

[PATCH] D98068: Do not merge LocalInstantiationScope for template specialization

This revision was automatically updated to reflect the committed changes. Closed by commit rG79f9cfbc21e0: Do not merge LocalInstantiationScope for template specialization (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 79f9cfb - Do not merge LocalInstantiationScope for template specialization

Author: Yaxun (Sam) Liu Date: 2021-06-14T23:28:04-04:00 New Revision: 79f9cfbc21e02555258523ea77c3dd389891cfb3 URL: https://github.com/llvm/llvm-project/commit/79f9cfbc21e02555258523ea77c3dd389891cfb3 DIFF:

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 added inline comments. Comment at: clang/test/Format/struct-array-initializer.cpp:5 +// RUN: grep -Ev "// *[A-Z-]+:" %s \ +// RUN: | clang-format -style="{BasedOnStyle: LLVM, AlignArrayOfStructures: Left}" %s \ +// RUN: | FileCheck -strict-whitespace

[PATCH] D104275: [compiler-rt][hwasan] Add SHADOW_OFFSET macro

leonardchan created this revision. leonardchan added reviewers: vitalybuka, eugenis. leonardchan added a project: Sanitizers. Herald added a subscriber: dberris. leonardchan requested review of this revision. Herald added a subscriber: Sanitizers. Similar to `SHADOW_OFFSET` on asan, we can use

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

vitalybuka added inline comments. Comment at: clang/test/Format/struct-array-initializer.cpp:5 +// RUN: grep -Ev "// *[A-Z-]+:" %s \ +// RUN: | clang-format -style="{BasedOnStyle: LLVM, AlignArrayOfStructures: Left}" %s \ +// RUN: | FileCheck -strict-whitespace

[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

shchenz added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:579 LangTag = llvm::dwarf::DW_LANG_ObjC; + } else if (LO.OpenCL && CGM.getCodeGenOpts().DwarfVersion >= 5) { +LangTag = llvm::dwarf::DW_LANG_OpenCL; I think for non-strict

[clang] b8919fb - [NFC][sanitizer] clang-format some code

Author: Vitaly Buka Date: 2021-06-14T18:05:22-07:00 New Revision: b8919fb0eac15d13c5f56d3d30ce378a588dd78c URL: https://github.com/llvm/llvm-project/commit/b8919fb0eac15d13c5f56d3d30ce378a588dd78c DIFF: https://github.com/llvm/llvm-project/commit/b8919fb0eac15d13c5f56d3d30ce378a588dd78c.diff

[PATCH] D103845: [compiler-rt][hwasan] Add newline between record_addr lines on frame record dumps

This revision was automatically updated to reflect the committed changes. Closed by commit rG312011899ac3: [compiler-rt][hwasan] Add newline between record_addr lines on frame record… (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

ahatanak added a comment. C++ non-virtual thunks and global initialization functions (`_GLOBAL__sub_I_*`) have only linkage names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104082/new/ https://reviews.llvm.org/D104082

Re: [PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

On Mon, Jun 14, 2021 at 4:04 PM Xinliang David Li wrote: > > > On Mon, Jun 14, 2021 at 3:59 PM Roman Lebedev via Phabricator < > revi...@reviews.llvm.org> wrote: > >> lebedev.ri added a subscriber: MaskRay. >> lebedev.ri added a comment. >> >> In D104099#2815531

[PATCH] D104248: [compiler-rt][hwasan] Refactor Thread::Init

leonardchan updated this revision to Diff 352015. leonardchan marked an inline comment as not done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104248/new/ https://reviews.llvm.org/D104248 Files: compiler-rt/lib/hwasan/hwasan_linux.cpp

Re: [PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

On Mon, Jun 14, 2021 at 3:59 PM Roman Lebedev via Phabricator < revi...@reviews.llvm.org> wrote: > lebedev.ri added a subscriber: MaskRay. > lebedev.ri added a comment. > > In D104099#2815531 , @wenlei > wrote: > > > In D104099#2814167

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

lebedev.ri added a subscriber: MaskRay. lebedev.ri added a comment. In D104099#2815531 , @wenlei wrote: > In D104099#2814167 , @davidxl wrote: > >> Adding Wei to help measure performance impact on our internal

[PATCH] D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type

AndreyChurbanov updated this revision to Diff 352010. AndreyChurbanov added a comment. Fixed backwards compatibility problem introduced by previous version of the patch. That is restored the size of task dependence flag to 8 bits in clang, and instead changed the size of the flag in the library

[PATCH] D104088: Add clang frontend flags for MIP

ellis updated this revision to Diff 352007. ellis added a comment. MIP does not support windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104088/new/ https://reviews.llvm.org/D104088 Files: clang/include/clang/Driver/Options.td

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov added a comment. In D99696#2817126 , @rjmccall wrote: > When `__block` variables get moved to the heap, they're supposed to be moved > if possible, not copied. It looks like PerformMoveOrCopyInitialization > requires NRVO info to be passed in

[clang] 0577f4b - [Hexagon] Add HVX and control register names to Hexagon target

Author: Krzysztof Parzyszek Date: 2021-06-14T17:14:37-05:00 New Revision: 0577f4b1789eff410f5b28434a4f7854a50dc639 URL: https://github.com/llvm/llvm-project/commit/0577f4b1789eff410f5b28434a4f7854a50dc639 DIFF:

[PATCH] D104258: [OPENMP]Fix PR50699: capture locals in combine directrives for aligned clause.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104258/new/ https://reviews.llvm.org/D104258

[PATCH] D103845: [compiler-rt][hwasan] Add newline between record_addr lines on frame record dumps

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103845/new/ https://reviews.llvm.org/D103845 ___

[PATCH] D98068: Exampt asserts for recursive lambdas about LocalInstantiationScope

yaxunl updated this revision to Diff 351990. yaxunl edited the summary of this revision. yaxunl added a comment. Revised by Richard's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98068/new/ https://reviews.llvm.org/D98068 Files:

[PATCH] D104253: [Clang][Codegen] emit noprofile IR Fn Attr for no_instrument_function Fn Attr

nickdesaulniers added a comment. In D104253#2817695 , @MaskRay wrote: > `__attribute__((no_instrument_function))` seems specific to > `-finstrument-functions`. Somehow `gcc -pg` uses it as well. > > The name may not be generic, so it may be odd to

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang updated this revision to Diff 351989. NeHuang added a comment. Rebased the patch with changes in https://reviews.llvm.org/D104125 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102875/new/ https://reviews.llvm.org/D102875 Files:

[clang] 00dbf8c - Adding some of the documents for C11.

Author: Aaron Ballman Date: 2021-06-14T16:43:44-04:00 New Revision: 00dbf8c83218829633b9f2ec1ee94a1f3b8dd29c URL: https://github.com/llvm/llvm-project/commit/00dbf8c83218829633b9f2ec1ee94a1f3b8dd29c DIFF: https://github.com/llvm/llvm-project/commit/00dbf8c83218829633b9f2ec1ee94a1f3b8dd29c.diff

[PATCH] D99483: [clang][AIX] Define __STDC_NO_ATOMICS__ for c11 and above

jsji added a comment. Done in https://reviews.llvm.org/D103707? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99483/new/ https://reviews.llvm.org/D99483 ___ cfe-commits mailing list

[PATCH] D104242: Removes an unused variable and alters a lit test to simplify and avoid a buildbot error

feg208 updated this revision to Diff 351982. feg208 added a comment. Looks like the dead code is removed in main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104242/new/ https://reviews.llvm.org/D104242 Files:

[PATCH] D104242: Removes an unused variable and alters a lit test to simplify and avoid a buildbot error

feg208 added a comment. In D104242#2817815 , @HazardyKnusperkeks wrote: > Could you split this into two diffs? Or are those two changes in any way > related? I can if you'd like. They are related in the sense that the dead code yielded warnings in

[PATCH] D104261: Thread safety analysis: Always warn when dropping locks on back edges

aaronpuchert added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:868 ThreadSafetyHandler ) const override { -if (!managed() && !asserted() && !negative() && !isUniversal()) { +if (!asserted() && !negative() &&

[PATCH] D98068: Exampt asserts for recursive lambdas about LocalInstantiationScope

rsmith added a comment. I think this is the wrong solution; I think the assertion is correct and is observing a problem elsewhere. Imagine if we had something like: template void f() { auto a = [] (auto recurse, auto x) { auto b = [] (auto) { refer to local decl in a

[PATCH] D104261: Thread safety analysis: Always warn when dropping locks on back edges

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, delesley. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We allow branches to join where one holds a managed lock but the other doesn't, but we

[PATCH] D104242: Removes an unused variable and alters a lit test to simplify and avoid a buildbot error

HazardyKnusperkeks added a comment. Could you split this into two diffs? Or are those two changes in any way related? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104242/new/ https://reviews.llvm.org/D104242

[PATCH] D102478: [Matrix] Emit assumption that matrix indices are valid.

erichkeane added a comment. Just a couple of nits here, basically see how much we can put in the 'cheap to check' branch. Comment at: clang/lib/CodeGen/CGExpr.cpp:1944 +llvm::Value *Idx = LV.getMatrixIdx(); +const auto MatTy = LV.getType()->getAs(); +

[PATCH] D104258: [OPENMP]Fix PR50699: capture locals in combine directrives for aligned clause.

lebedev.ri added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104258/new/ https://reviews.llvm.org/D104258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D104258: [OPENMP]Fix PR50699: capture locals in combine directrives for aligned clause.

ABataev created this revision. ABataev added reviewers: lebedev.ri, jdoerfert. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Need to capture locals in aligned clauses for the combined

[PATCH] D103772: [clang-cl] Reenable /Zc:twoPhase by default if targetting MSVC 2017 Update 3 or newer

rnk added a comment. If we look back at the original intention of our MSVC compatibility work, we tried to accept as much invalid code as necessary to parse "system headers". System headers were widely interpreted to bethe MSVC STL, ATL, and the Windows SDK. So, even if MSVC defaults to

[PATCH] D104253: [Clang][Codegen] emit noprofile IR Fn Attr for no_instrument_function Fn Attr

MaskRay added a comment. `__attribute__((no_instrument_function))` seems specific to `-finstrument-functions`. Somehow `gcc -pg` uses it as well. The name may not be generic, so it may be odd to exclude various instrumentations under this generic attribute. clang -fprofile-instr-generate

[PATCH] D102478: [Matrix] Emit assumption that matrix indices are valid.

fhahn added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102478/new/ https://reviews.llvm.org/D102478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D104253: [Clang][Codegen] emit noprofile IR Fn Attr for no_instrument_function Fn Attr

melver added a comment. In D104253#2817673 , @void wrote: > What are your thoughts on adding a `noprofile` function attribute in the FE? > @MaskRay suggested filing a bug with gcov (below) to get their take on it. > > >

[PATCH] D103845: [compiler-rt][hwasan] Add newline between record_addr lines on frame record dumps

leonardchan updated this revision to Diff 351961. leonardchan edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103845/new/ https://reviews.llvm.org/D103845 Files: compiler-rt/lib/hwasan/hwasan_report.cpp Index:

[PATCH] D104253: [Clang][Codegen] emit noprofile IR Fn Attr for no_instrument_function Fn Attr

nickdesaulniers updated this revision to Diff 351960. nickdesaulniers added a comment. - rename new test from fprofile-generate.c to fprofile-instrument.c; -fprofile-generate is the driver opt, -fprofile-instrument is the frontend opt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D104248: [compiler-rt][hwasan] Refactor Thread::Init

leonardchan marked an inline comment as not done. leonardchan added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_linux.cpp:430 +void Thread::Init(uptr stack_buffer_start, uptr stack_buffer_size) { + CHECK_EQ(0, unique_id_); // try to catch bad stack reuse

[PATCH] D104253: [Clang][Codegen] emit noprofile IR Fn Attr for no_instrument_function Fn Attr

void added a comment. What are your thoughts on adding a `noprofile` function attribute in the FE? @MaskRay suggested filing a bug with gcov (below) to get their take on it. https://gcc.gnu.org/bugzilla/buglist.cgi?bug_status=__open__=gcov-profile_id=304970=gcc Repository: rG LLVM Github

[PATCH] D104248: [compiler-rt][hwasan] Move Thread::Init into hwasan_linux.cpp

leonardchan added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_linux.cpp:430 +void Thread::Init(uptr stack_buffer_start, uptr stack_buffer_size) { + CHECK_EQ(0, unique_id_); // try to catch bad stack reuse mcgrathr wrote: > Most of this code

[PATCH] D104248: [compiler-rt][hwasan] Move Thread::Init into hwasan_linux.cpp

leonardchan updated this revision to Diff 351957. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104248/new/ https://reviews.llvm.org/D104248 Files: compiler-rt/lib/hwasan/hwasan_linux.cpp compiler-rt/lib/hwasan/hwasan_thread.cpp

[PATCH] D104253: [Clang][Codegen] emit noprofile IR Fn Attr for no_instrument_function Fn Attr

nickdesaulniers updated this revision to Diff 351956. nickdesaulniers added a comment. - add -disable-llvm-passes to unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104253/new/ https://reviews.llvm.org/D104253 Files:

[PATCH] D104248: [compiler-rt][hwasan] Move Thread::Init into hwasan_linux.cpp

leonardchan updated this revision to Diff 351953. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104248/new/ https://reviews.llvm.org/D104248 Files: compiler-rt/lib/hwasan/hwasan_thread.cpp compiler-rt/lib/hwasan/hwasan_thread.h Index:

[PATCH] D104240: [OPENMP][C++20]Add support for CXXRewrittenBinaryOperator in ranged for loops.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e155608796b: [OPENMP][C++20]Add support for CXXRewrittenBinaryOperator in ranged for loops. (authored by ABataev). Repository: rG LLVM Github

[clang] 4e15560 - [OPENMP][C++20]Add support for CXXRewrittenBinaryOperator in ranged for loops.

Author: Alexey Bataev Date: 2021-06-14T11:50:27-07:00 New Revision: 4e155608796b79d7e369f4e42980ce670bff7172 URL: https://github.com/llvm/llvm-project/commit/4e155608796b79d7e369f4e42980ce670bff7172 DIFF: https://github.com/llvm/llvm-project/commit/4e155608796b79d7e369f4e42980ce670bff7172.diff

[PATCH] D104253: [Clang][Codegen] emit noprofile IR Fn Attr for no_instrument_function Fn Attr

nickdesaulniers created this revision. nickdesaulniers added reviewers: MaskRay, melver, void. Herald added a subscriber: wenlei. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. noprofile IR attribute already exists to

[PATCH] D104248: [compiler-rt][hwasan] Move Thread::Init into hwasan_linux.cpp

mcgrathr added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_linux.cpp:430 +void Thread::Init(uptr stack_buffer_start, uptr stack_buffer_size) { + CHECK_EQ(0, unique_id_); // try to catch bad stack reuse Most of this code can actually be reused

[PATCH] D103615: [Clang] Add option for vector compare compatibility.

bmahjour added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:248 + enum class VectorCompareCompatKind { +// Default clang behaviour. +// All vector compares produce scalars except vector Pixel and vector bool. How about adding

[PATCH] D104248: [compiler-rt][hwasan] Move Thread::Init into hwasan_linux.cpp

leonardchan created this revision. leonardchan added reviewers: eugenis, vitalybuka, pcc. leonardchan added a project: Sanitizers. Herald added a subscriber: dberris. leonardchan requested review of this revision. Herald added a subscriber: Sanitizers. This allows for other implementations to

[PATCH] D98068: Exampt asserts for recursive lambdas about LocalInstantiationScope

yaxunl updated this revision to Diff 351934. yaxunl retitled this revision from "Remove asserts for LocalInstantiationScope" to "Exampt asserts for recursive lambdas about LocalInstantiationScope". yaxunl edited the summary of this revision. yaxunl added a comment. re-enable the assert but with

[PATCH] D104240: [OPENMP][C++20]Add support for CXXRewrittenBinaryOperator in ranged for loops.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104240/new/ https://reviews.llvm.org/D104240

[PATCH] D103936: [compiler-rt][hwasan] Define fuchsia implementations of required hwasan functions

leonardchan updated this revision to Diff 351931. leonardchan marked 10 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103936/new/ https://reviews.llvm.org/D103936 Files: compiler-rt/lib/hwasan/CMakeLists.txt

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

MyDeveloperDay added a subscriber: tstellar. MyDeveloperDay added a comment. I think we've missed the deadline for 12.0.1 which I believe was last friday. I did a practice merge and it didn't quite go in cleanly to 12.0.X branch Normally we would mark the bug in the bug tracker for the next

[clang] d650ccf - [NFC] Remove unused variable

Author: Vitaly Buka Date: 2021-06-14T10:57:26-07:00 New Revision: d650ccf6390bb1e4454dd735cfcec9eda9af8ca3 URL: https://github.com/llvm/llvm-project/commit/d650ccf6390bb1e4454dd735cfcec9eda9af8ca3 DIFF: https://github.com/llvm/llvm-project/commit/d650ccf6390bb1e4454dd735cfcec9eda9af8ca3.diff

[PATCH] D103899: [OpenMP] Fix C-only clang assert on parsing use_allocator clause of target directive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG44f197e94b83: [OpenMP] Fix C-only clang assert on parsing use_allocator clause of target… (authored by ABataev). Herald added a project: clang.

[clang] 44f197e - [OpenMP] Fix C-only clang assert on parsing use_allocator clause of target directive

Author: Alexey Bataev Date: 2021-06-14T10:36:27-07:00 New Revision: 44f197e94b83d389b59ce6a2a1977f972e6d34e3 URL: https://github.com/llvm/llvm-project/commit/44f197e94b83d389b59ce6a2a1977f972e6d34e3 DIFF: https://github.com/llvm/llvm-project/commit/44f197e94b83d389b59ce6a2a1977f972e6d34e3.diff

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj added a comment. > A crash (https://bugs.llvm.org/show_bug.cgi?id=50663) in 12.0.1 is fixed by > your changes here when merged to the 12 branch, I'm not sure if this needs to > be backported to 12 I guess it might depend on if we think it's critical > enough or if there will more 12

[PATCH] D103623: [Clang] Test case for -Wunused-but-set-variable, warn for volatile.

This revision was automatically updated to reflect the committed changes. Closed by commit rG20f7b5f3f9c8: [Clang] Test case for -Wunused-but-set-variable, warn for volatile. (authored by mbenfield, committed by george.burgess.iv). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 20f7b5f - [Clang] Test case for -Wunused-but-set-variable, warn for volatile.

Author: Michael Benfield Date: 2021-06-14T10:25:59-07:00 New Revision: 20f7b5f3f9c8ebbbe7bf6648c824b815385d4bf7 URL: https://github.com/llvm/llvm-project/commit/20f7b5f3f9c8ebbbe7bf6648c824b815385d4bf7 DIFF:

[PATCH] D103702: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries

paulwalker-arm added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.h:298-299 + bool LittleEndian, + unsigned MinSVEVectorSizeInBitsOverride = 0, + unsigned MaxSVEVectorSizeInBitsOverride = 0);

[PATCH] D104125: [PowerPC] Moving defineXLCompatMacros() definition

lei accepted this revision. lei added a comment. This revision is now accepted and ready to land. LGTM Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104125/new/ https://reviews.llvm.org/D104125

[PATCH] D104242: Removes an unused variable and alters a lit test to simplify and avoid a buildbot error

feg208 created this revision. feg208 added reviewers: HazardyKnusperkeks, Bigcheese. feg208 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D104242 Files:

[PATCH] D103702: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries

bsmith added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.cpp:226 + : SVEVectorBitsMaxOpt), TargetTriple(TT), FrameLowering(), InstrInfo(initializeSubtargetDependencies(FS, CPU)), TSInfo(),

[PATCH] D103702: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries

bsmith updated this revision to Diff 351910. bsmith marked 7 inline comments as done. bsmith added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Move attribute/command line logic into AArch64TargetMachine. - Fix issue with subtarget key appending integers. -

[PATCH] D104240: [OPENMP][C++20]Add support for CXXRewrittenBinaryOperator in ranged for loops.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Added support for CXXRewrittenBinaryOperator as a condition in

[PATCH] D103087: [clang-tidy] performances-unnecessary-* checks: Extend isOnlyUsedAsConst to expressions and catch const methods returning non-const references/pointers.

ymandel added a comment. In D103087#2813901 , @flx wrote: > In D103087#2793673 , @ymandel wrote: > >> I have some concerns about the cost of this checks as it used matching over >> entire contexts quite

[PATCH] D104116: AMD k8 family does not support SSE4.x which are required by x86-64-v2+

stella.stamenova added a comment. This change is generating warnings when building with clang: /usr/bin/clang++ -DCLANG_ROUND_TRIP_CC1_ARGS=ON -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/clang/lib/Basic

[PATCH] D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations.

ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:98-101 auto Matches = match(findAll(declStmt(has(varDecl(equalsNode( .bind("declStmt")), +Body, Context);

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

lichray added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104222/new/ https://reviews.llvm.org/D104222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

MyDeveloperDay updated this revision to Diff 351895. MyDeveloperDay added a comment. Remove unused functions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104222/new/ https://reviews.llvm.org/D104222 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp

[PATCH] D103792: [clang][AST] Set correct DeclContext in ASTImporter lookup table for template params.

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:5961-5962 if (Error Err = ImportDeclParts(D, DC, LexicalDC, Name, ToD, Loc)) return std::move(Err); martong wrote: > Do you think that the alternative approach that is used

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

MyDeveloperDay added a comment. @Wawha do you have a project that perhaps uses this work your did? I would like to ensure I didn't break anything Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104222/new/ https://reviews.llvm.org/D104222

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

rjmccall added a comment. When `__block` variables get moved to the heap, they're supposed to be moved if possible, not copied. It looks like PerformMoveOrCopyInitialization requires NRVO info to be passed in to ever do a move. Maybe it's being passed in wrong when building `__block` copy

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

vsavchenko added a comment. In D103605#2816979 , @Szelethus wrote: > Sorry for the absence, took my time to catch up with this series! Really > interesting insight into how a new interface is being designed! I need some > time to digest things, but

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

Szelethus added a comment. Sorry for the absence, took my time to catch up with this series! Really interesting insight into how a new interface is being designed! I need some time to digest things, but can't wait to help on the remaining patches. Repository: rG LLVM Github Monorepo

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

Wawha added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3760 - (isAllmanBraceIncludedBreakableLambda(Left, ShortLambdaOption) || - isAllmanBraceIncludedBreakableLambda(Right, ShortLambdaOption))) { -return true; Without this

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

hans added a comment. Since it seems more discussion is needed here, I've reverted in c60dd3b2626a4d9eefd9f82f9a406b0d28d3fd72 . Since they were hard to tease apart, the revert is for both D99696

[clang] c60dd3b - Revert "[clang] NRVO: Improvements and handling of more cases."

Author: Hans Wennborg Date: 2021-06-14T16:46:58+02:00 New Revision: c60dd3b2626a4d9eefd9f82f9a406b0d28d3fd72 URL: https://github.com/llvm/llvm-project/commit/c60dd3b2626a4d9eefd9f82f9a406b0d28d3fd72 DIFF: https://github.com/llvm/llvm-project/commit/c60dd3b2626a4d9eefd9f82f9a406b0d28d3fd72.diff

[PATCH] D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check

mgartmann added a comment. Thanks a lot for your feedback, @aaron.ballman! I was able to incorporate it in the updated diff. On your advice, I also ran this check on a large open source project using the `run-clang-tidy.py` script. I decided to do it on the llvm project itself as follows:

[PATCH] D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check

mgartmann updated this revision to Diff 351869. mgartmann marked 10 inline comments as done. mgartmann added a comment. - changed name of check to `cppcoreguidelines-virtual-class-destructor` - removed matcher for class or struct in AST matcher - changed string concatenations to use `llvm::twine`

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

fhahn added a comment. Thanks for the patch! some comments inline. Comment at: clang/docs/LanguageExtensions.rst:527 +The matrix type extension supports compound assignments for addition, subtraction, and multiplication, provided +their types are consistent. +

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

hans added a comment. > @hans: FYI, that looks related to the immediately following D99005 > , not D99696 > specifically. No, my test case passes at 0d9e8f5f4b68252c6caa1ef81a30777b2f5d7242

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

Quuxplusone added a comment. @hans: FYI, that looks related to the immediately following D99005 , not D99696 specifically. I suspect that reverting D99005 (but leaving D99696

[PATCH] D98068: Remove asserts for LocalInstantiationScope

yaxunl added a comment. ping I will provide a detailed description of the issue: What happen are: First, fun1 is instantiated as `fun1<0,1>`, which calls lambda function `f(f, Number<1>)`. This causes lambda function `f` instantiated as `f(f, Number<1>)`. clang uses LocalInstantiationScope

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

hans added subscribers: rjmccall, hans. hans added a comment. We're seeing new build errors in Chromium after this (http://crbug.com/1219457). Here's a reduced example: $ cat /tmp/a.mm #include struct Callback { // Move-only! Callback(const Callback&) = delete; Callback&

[PATCH] D104116: AMD k8 family does not support SSE4.x which are required by x86-64-v2+

serge-sans-paille added a comment. In D104116#2816291 , @RKSimon wrote: > This leaves the question - what hardware should we align each of the > CK_x86_64_v* targets with? I'm not quite sure I get it. If I understand correctly, each `CK_x86_64_v*`

[PATCH] D104104: [clang][deps] NFC: Handle `DependencyOutputOptions` only once

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf95ff8162721: [clang][deps] NFC: Handle `DependencyOutputOptions` only once (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[PATCH] D104106: [clang][deps] NFC: Stop using moved-from object

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85208b96b85f: [clang][deps] NFC: Stop using moved-from object (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

  1   2   >