[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

2021-06-19 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur updated this revision to Diff 353220. Meinersbur edited the summary of this revision. Meinersbur added a comment. - Undo "typechange" changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

2021-06-19 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur created this revision. Herald added subscribers: dang, jvesely. Meinersbur requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: openmp-commits, libcxx-commits, cfe-commits, sstefan1. Herald added projects: clang, libc++, OpenMP. Herald added a

[PATCH] D104500: [clang] Apply P1825 as Defect Report for all C++ standards from C++11 up to C++20.

2021-06-19 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov updated this revision to Diff 353215. mizvekov added a comment. tests: improve consistency of expcted messages.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104500/new/ https://reviews.llvm.org/D104500 Files:

[PATCH] D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

2021-06-19 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added a comment. Herald added a subscriber: ormris. I think this change broke apt.llvm.org > [100%] Linking CXX shared library ../../lib/libLLVM-13.so > cd "/build/llvm-toolchain-snapshot-13~++20210619083511+1605fce6c307/build-llvm/tools/llvm-shlib" && /usr/bin/cmake -E

[PATCH] D104553: [compiler-rt][hwasan] Add InitState options to thread initialization

2021-06-19 Thread Petr Hosek via Phabricator via cfe-commits
phosek added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_linux.cpp:430 -void Thread::InitStackAndTls() { +void Thread::InitStackAndTls(const InitState *state) { uptr tls_size; If it's unused then you can omit the argument name to avoid the

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

2021-06-19 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. In D103750#2828995 , @RedDocMD wrote: > What about this? I believe that you might see `analyzer-eagerly-assume` in action. Basically, instead of keeping a constraint unknown, the analyzer can split the path eagerly. So you

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

2021-06-19 Thread Deep Majumder via Phabricator via cfe-commits
RedDocMD added a comment. In D103750#2827548 , @RedDocMD wrote: > In D103750#2825342 , @NoQ wrote: > >> Do the above tests pass when your new `evalCall` modeling is enabled? > > The analyzer doesn't seem to be

[PATCH] D104044: [clang-format] Fix the issue that empty lines being removed at the beginning of namespace

2021-06-19 Thread Darwin Xu via Phabricator via cfe-commits
darwin updated this revision to Diff 353200. darwin added a comment. Updated with the fix code. Look into the code, I am pretty sure this is a bug, it is about the logic of the parameter `KeepEmptyLinesAtTheStartOfBlocks`. When `KeepEmptyLinesAtTheStartOfBlocks` is false, it will remove the

[clang] decfad7 - Revert "Re-Revert "DirectoryWatcher: add an implementation for Windows""

2021-06-19 Thread Saleem Abdulrasool via cfe-commits
Author: Saleem Abdulrasool Date: 2021-06-19T09:19:52-07:00 New Revision: decfad7d8e9b268654dd2d76a7f5f777502b60a6 URL: https://github.com/llvm/llvm-project/commit/decfad7d8e9b268654dd2d76a7f5f777502b60a6 DIFF:

[PATCH] D103008: Handle multiple escaped newlines between */ correctly

2021-06-19 Thread Lode Willems via Phabricator via cfe-commits
lodewillems abandoned this revision. lodewillems added a comment. Made obsolete by commit de6164ec4da0cfea1b0d0e472c432ea1be4d9c29 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

2021-06-19 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. I’ve been trying to commit this patch. However, when I commit, the tests fail some 21 floating point tests in LNT. Also there is both performance improvement as well as regression which shouldn’t happen because the sum total of my clang patch + my LNT patch should

[clang] 9abaf5c - Revert "[clang][FPEnv] Clang floatng point model ffp-model=precise enables ffp-contract=on"

2021-06-19 Thread Melanie Blower via cfe-commits
Author: Melanie Blower Date: 2021-06-19T08:01:22-04:00 New Revision: 9abaf5c359ca29fcdd4f42b72ae0a62f18626180 URL: https://github.com/llvm/llvm-project/commit/9abaf5c359ca29fcdd4f42b72ae0a62f18626180 DIFF:

[PATCH] D103773: [clang-cl] Add /permissive and /permissive-

2021-06-19 Thread Markus Böck via Phabricator via cfe-commits
zero9178 marked an inline comment as done. zero9178 added inline comments. Comment at: clang/test/Driver/cl-permissive.c:15 +// PERMISSIVE-OVERWRITE-NOT: "-fdelayed-template-parsing" +// RUN: %clang_cl /permissive- /Zc:twoPhase- -### -- %s 2>&1 | FileCheck

[clang] c9889c4 - [clang-cl] Don't expand /permissive- to /ZC:strictStrings yet

2021-06-19 Thread Markus Böck via cfe-commits
Author: Markus Böck Date: 2021-06-19T13:28:32+02:00 New Revision: c9889c44ec5a4054833457c813e155f284703ef4 URL: https://github.com/llvm/llvm-project/commit/c9889c44ec5a4054833457c813e155f284703ef4 DIFF: https://github.com/llvm/llvm-project/commit/c9889c44ec5a4054833457c813e155f284703ef4.diff

[clang] a1449a1 - [clang][FPEnv] Clang floatng point model ffp-model=precise enables ffp-contract=on

2021-06-19 Thread Melanie Blower via cfe-commits
Author: Melanie Blower Date: 2021-06-19T06:49:27-04:00 New Revision: a1449a10dbcfcf353f4f761281c4e572b4ce9308 URL: https://github.com/llvm/llvm-project/commit/a1449a10dbcfcf353f4f761281c4e572b4ce9308 DIFF:

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

2021-06-19 Thread Manas Gupta via Phabricator via cfe-commits
manas added a comment. The diff fixes all invalid assertion issues and also reasons about the cases where Min > Max. One thing which is stuck for me is the case where Min <= Max but it overflows. I could reason about that in this way: 1. If one of Min/Max overflows while the other doesn't

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

2021-06-19 Thread Manas Gupta via Phabricator via cfe-commits
manas updated this revision to Diff 353168. manas added a comment. Reason about cases where Min > Max Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103440/new/ https://reviews.llvm.org/D103440 Files: